Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

On Wed, Apr 06, 2016 at 11:52:56PM +, Ilya Maximets wrote: > --- Original Message --- > Sender : Michael S. Tsirkin > Date : Apr 05, 2016 13:46 (GMT+03:00) > Title : Re: [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect. > > > On Thu, Mar 31, 2016 at 09:02:01AM +0300, Ilya Max

Re: [Qemu-devel] Any progress with the Cortex-M4 emulation?

> On 07 Apr 2016, at 03:46, Michael Davidsaver wrote: > > ... don't hesitate to appropriate, or ignore, what I've done so far. ... > https://github.com/mdavidsaver/qemu/tree/fixirq2 from what I see here, the nvic is still one big monolithic device. as I said before, I like modular things, and

Re: [Qemu-devel] [PATCH qemu v15 15/17] spapr_pci: Get rid of dma_loibn

On 04/07/2016 10:50 AM, David Gibson wrote: s/dma_loibn/dma_liobn/ in subject line. On Mon, Apr 04, 2016 at 07:33:44PM +1000, Alexey Kardashevskiy wrote: We are going to have 2 DMA windows which LIOBNs are calculated from the PHB index and the window number using the SPAPR_PCI_LIOBN macro so th

[Qemu-devel] [PATCH] i386: kvmvapic: initialise imm32 variable

From: Prasad J Pandit When processing Task Priorty Register(TPR) access, it could leak automatic stack variable 'imm32' in patch_instruction(). Initialise the variable to avoid it. Reported by: Donghai Zdh Signed-off-by: Prasad J Pandit --- hw/i386/kvmvapic.c | 2 +- 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

On 04/06/2016 04:22 PM, Dmitry Fleytman wrote: > Hi Jason, > > Please see my comments below. > >> On 8 Mar 2016, at 11:31 AM, Jason Wang > > wrote: >> >> >> >> On 02/23/2016 01:37 AM, Leonid Bloch wrote: >>> From: Dmitry Fleytman >>

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

On 04/06/2016 09:52 PM, Amit Shah wrote: > On (Wed) 06 Apr 2016 [09:48:19], Jason Wang wrote: >> >> On 04/05/2016 09:32 PM, Dr. David Alan Gilbert wrote: >>> * Amit Shah (amit.s...@redhat.com) wrote: On (Tue) 23 Feb 2016 [15:02:58], Jason Wang wrote: >>> This means that 2.5 cannot migrat

[Qemu-devel] [Bug 1567254] [NEW] qemu-2.5.1 will not run with gtk3/vte

Public bug reported: Using qemu-2.5.1 and compiling without gtk3 and vte-2.90. This works: CC="gcc -mtune=generic -Os -pipe" CXX="g++ -mtune=generic -Os -pipe -fno-exceptions -fno-rtti" ./configure --prefix=/usr/local --localstatedir=/var --libexecdir=/usr/local/lib/qemu --interp- prefix=/usr/lo

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On Wed, Apr 6, 2016 at 7:42 PM, Richard Henderson wrote: > On 04/06/2016 10:32 AM, Emilio G. Cota wrote: >> On Wed, Apr 06, 2016 at 08:06:57 +0200, Laurent Desnogues wrote: >>> On Tue, Apr 5, 2016 at 7:19 PM, Richard Henderson wrote: On 04/05/2016 09:33 AM, Laurent Desnogues wrote: > The

Re: [Qemu-devel] [PATCH v3 0/7] virtio: aio handler API

On 04/06/2016 12:16 PM, Paolo Bonzini wrote: > This version removes patches 1 and 9, fixes some commit messages, and > fixes some small in the formatting issues. > > Michael S. Tsirkin (2): > virtio: add aio handler > virtio-blk: use aio handler for data plane > > Paolo Bonzini (5): > virti

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo Signed-off-by: Steven Luo Reviewed-by: Edgar E. Iglesias Signed-off-by: Samuel Thibault --- slirp/tcp_subr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index dbfd2c6..32ff452 100644 --- a/slirp/tcp_subr.c +++

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

From: Steven Luo slirp currently only handles ECONNREFUSED in the case where connect() returns immediately with that error; since we use non-blocking sockets, most of the time we won't receive the error until we later try to read from the socket. Ensure that we deliver the appropriate RST to the

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to b9b314378ce

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

From: "Edgar E. Iglesias" When the host aborts (RST) its side of a TCP connection we need to propagate that RST to the guest. The current code can leave such guest connections dangling forever. Spotted by Jason Wessel. [ste...@steven676.net: coding style adjustments] Signed-off-by: Steven Luo S

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by refusing to continue to work with the socket in

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

On 07/04/2016 02:37, Emilio G. Cota wrote: > I take this back. I don't know anymore what I measured earlier today--it's > been a long day and was juggling quite a few things. > > I essentially see the same chain lengths (within 0.2%) for either function, > i.e. > func3 or func5 with the padded

Re: [Qemu-devel] [PATCH] i386: kvmvapic: initialise imm32 variable

On 07/04/2016 09:20, P J P wrote: > From: Prasad J Pandit > > When processing Task Priorty Register(TPR) access, it could leak > automatic stack variable 'imm32' in patch_instruction(). > Initialise the variable to avoid it. > > Reported by: Donghai Zdh > > Signed-off-by: Prasad J Pandit >

Re: [Qemu-devel] [PATCH v2 2/1 for-2.6] nbd: Don't kill server when client requests unknown option

On 07/04/2016 00:48, Eric Blake wrote: > nbd-server.c currently fails to handle unsupported options properly. > If during option haggling the client sends an unknown request, the > server kills the connection instead of letting the client try to > fall back to something older. This is precisely

Re: [Qemu-devel] [PATCH v4.1] Add optionrom compatible with fw_cfg DMA version

On Mon, 4 Apr 2016 16:02:04 +0100 Stefan Hajnoczi wrote: > On Fri, Apr 01, 2016 at 01:43:47PM +0100, Richard W.M. Jones wrote: > > From: Marc Marí > > > > This optionrom is based on linuxboot.S. > > > > Signed-off-by: Marc Marí > > Signed-off-by: Richard W.M. Jones > > --- > > .gitignore

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On 05/04/2016 04:17, David Gibson wrote: > From: Cédric Le Goater > > From: Benjamin Herrenschmidt > > This patch fixes the current AIL implementation for POWER8. The > interrupt vector address can be calculated directly from LPCR when the > exception is handled. The excp_prefix update become

Re: [Qemu-devel] [PULL 0/5] Net patches

On 6 April 2016 at 03:37, Jason Wang wrote: > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: > > Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-re

Re: [Qemu-devel] [PATCH] block: initialize qcrypto API at startup

Am 06.04.2016 um 13:12 hat Daniel P. Berrange geschrieben: > Any programs which call the qcrypto APIs should ensure that > qcrypto_init() has been called before anything else which > can use crypto. Essentially this means right at the start > of the main method before initializing anything else. >

[Qemu-devel] Virtio-9p and cgroup io-throttling

Hi All, I am using virtio-9p for sharing the file between host and guest. To test the shared file I do read/write options in the guest.To have controlled io, I am using cgroup blkio. While using cgroup I am facing two issues,Please find the issues below. 1. When I do IO throttling using the cgro

[Qemu-devel] [RFC PATCH v2 0/3] ARM64: Live migration optimization

From: Vijaya Kumar K To optimize Live migration time on ARM64 machine following changes are made. - Neon instructions are used for Zero page checking. - Added prefetch for Thunderx platform With these changes, total migration time comes down from 10 seconds to 2.5 seconds. These patches are t

[Qemu-devel] [RFC PATCH v2 1/3] target-arm: Use Neon for zero checking

From: Vijay Use Neon instructions to perform zero checking of buffer. This is helps in reducing downtime during live migration. Signed-off-by: Vijaya Kumar K Signed-off-by: Suresh --- util/cutils.c | 74 + 1 file changed, 74 insertions

[Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

From: Vijaya Kumar K utils cannot read target cpu information to fetch cpu information to implement cpu specific features or erratas. For this parse /proc/cpuinfo and fetch cpu information. For now this helper only fetches cpu information for arm architectures. Signed-off-by: Vijaya Kumar K Si

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

On 7 April 2016 at 10:58, wrote: > From: Vijaya Kumar K > > utils cannot read target cpu information to > fetch cpu information to implement cpu specific > features or erratas. For this parse /proc/cpuinfo > and fetch cpu information. > > For now this helper only fetches cpu information > for ar

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

On 7 April 2016 at 09:34, Samuel Thibault wrote: > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: > > Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git tag

[Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer

From: Prasad J Pandit When receiving packets over Stellaris ethernet controller, it uses receive buffer of size 2048 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pan

[Qemu-devel] [PATCH] net: mipsnet: check packet length against buffer

From: Prasad J Pandit When receiving packets over MIPSnet network device, it uses receive buffer of size 1514 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pandit -

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

On Thu, Apr 07, 2016 at 11:13:37AM +0100, Peter Maydell wrote: > On 7 April 2016 at 09:34, Samuel Thibault > wrote: > > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: > > > > Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) > > > > are available in

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

Hello Laurent, On 04/07/2016 11:13 AM, Laurent Vivier wrote: > > > On 05/04/2016 04:17, David Gibson wrote: >> From: Cédric Le Goater >> >> From: Benjamin Herrenschmidt >> >> This patch fixes the current AIL implementation for POWER8. The >> interrupt vector address can be calculated directly

Re: [Qemu-devel] [RFC PATCH v2 1/3] target-arm: Use Neon for zero checking

> +#elif defined __aarch64__ > +#include "arm_neon.h" > + > +#define NEON_VECTYPE uint64x2_t > +#define NEON_LOAD_N_ORR(v1, v2)(vld1q_u64(&v1) | vld1q_u64(&v2)) Why is the load and orr necessary? Is ((v1) | (v2)) enough? > +#define NEON_ORR(v1, v2) ((v1) | (v2)) > +#

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

On 7 April 2016 at 11:27, Edgar E. Iglesias wrote: > On Thu, Apr 07, 2016 at 11:13:37AM +0100, Peter Maydell wrote: >> On 7 April 2016 at 09:34, Samuel Thibault >> wrote: >> > The following changes since commit >> > 7acbff99c6c285b3070bf0e768d56f511e2bf346: >> > >> > Update version for v2.6.0

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

On 05.04.2016 16:43, Paolo Bonzini wrote: On 05/04/2016 06:05, Kevin Wolf wrote: The options I can think of is adding a request field "max number of descriptors" or a flag "only single descriptor" (with the assumption that clients always want one or unlimited), but maybe you have a better idea.

Re: [Qemu-devel] [RFC PATCH v2 1/3] target-arm: Use Neon for zero checking

On 7 April 2016 at 11:30, Paolo Bonzini wrote: > >> +#elif defined __aarch64__ >> +#include "arm_neon.h" >> + >> +#define NEON_VECTYPE uint64x2_t >> +#define NEON_LOAD_N_ORR(v1, v2)(vld1q_u64(&v1) | vld1q_u64(&v2)) > > Why is the load and orr necessary? Is ((v1) | (v2)) enough?

Re: [Qemu-devel] [RFC PATCH v2 1/3] target-arm: Use Neon for zero checking

On 7 April 2016 at 10:58, wrote: > From: Vijay > > Use Neon instructions to perform zero checking of > buffer. This is helps in reducing downtime during > live migration. > > Signed-off-by: Vijaya Kumar K > Signed-off-by: Suresh > --- > util/cutils.c | 74 >

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On 07/04/2016 12:27, Cédric Le Goater wrote: > Hello Laurent, > > On 04/07/2016 11:13 AM, Laurent Vivier wrote: >> >> >> On 05/04/2016 04:17, David Gibson wrote: >>> From: Cédric Le Goater >>> >>> From: Benjamin Herrenschmidt >>> >>> This patch fixes the current AIL implementation for POWER8.

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

On Thu, Apr 7, 2016 at 3:41 PM, Peter Maydell wrote: > On 7 April 2016 at 10:58, wrote: >> From: Vijaya Kumar K >> >> utils cannot read target cpu information to >> fetch cpu information to implement cpu specific >> features or erratas. For this parse /proc/cpuinfo >> and fetch cpu information.

[Qemu-devel] Questions about nbd with QIOChannel

Hi all Recently during test COLO, i found sometimes the client goes to hung on Primary side. First i thought it maybe a COLO revelant issue, but after ton of tests i doubt that this maybe a NBD issue (athough i'm not sure). So i'd like to share what i found: Since commit 1c778ef7, we convert

Re: [Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer

On 7 April 2016 at 11:25, P J P wrote: > From: Prasad J Pandit > > When receiving packets over Stellaris ethernet controller, it > uses receive buffer of size 2048 bytes. In case the controller > accepts large(MTU) packets, it could lead to memory corruption. > Add check to avoid it. > > Reported

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo Signed-off-by: Steven Luo Reviewed-by: Edgar E. Iglesias Signed-off-by: Samuel Thibault --- slirp/tcp_subr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index dbfd2c6..32ff452 100644 --- a/slirp/tcp_subr.c +++

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

From: "Edgar E. Iglesias" When the host aborts (RST) its side of a TCP connection we need to propagate that RST to the guest. The current code can leave such guest connections dangling forever. Spotted by Jason Wessel. Signed-off-by: Edgar E. Iglesias [ste...@steven676.net: coding style adjustm

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by refusing to continue to work with the socket in

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

Peter Maydell, on Thu 07 Apr 2016 11:37:45 +0100, wrote: > Thanks; Samuel, can I ask you to respin with that line added? Done so. Samuel

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 6625d83a6eb

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

From: Steven Luo slirp currently only handles ECONNREFUSED in the case where connect() returns immediately with that error; since we use non-blocking sockets, most of the time we won't receive the error until we later try to read from the socket. Ensure that we deliver the appropriate RST to the

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

> --- Original Message --- > Sender : Michael S. Tsirkin > Date : Apr 07, 2016 10:01 (GMT+03:00) > Title : Re: Re: [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect. > > On Wed, Apr 06, 2016 at 11:52:56PM +, Ilya Maximets wrote: > > --- Original Message --- > > Sender

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

* Eric Blake (ebl...@redhat.com) wrote: > On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: > > >> One thing I still can't understand, why the unit test in host environment > >> shows > >> 'memcmp()' have better performance? > > Have you tried running under a profiler, to see if there are ho

Re: [Qemu-devel] Questions about nbd with QIOChannel

On 07/04/2016 13:04, Changlong Xie wrote: > Hi all > > Recently during test COLO, i found sometimes the client goes to hung on > Primary side. First i thought it maybe a COLO revelant issue, but after > ton of tests i doubt that this maybe a NBD issue (athough i'm not sure). > So i'd like to sha

Re: [Qemu-devel] [PATCH v2 for-2.7 2/8] block: Let bdrv_open_inherit() return the snapshot

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > If bdrv_open_inherit() creates a snapshot BDS and *pbs is NULL, that > snapshot BDS should be returned instead of the BDS under it. > > To this end, bdrv_append_temp_snapshot() now returns the snapshot BDS > instead of just appending it on top of

[Qemu-devel] [PATCH] Improve documentation for TLS

* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a requirem

[Qemu-devel] Implementing 9p for Windows host

Good day, I'm using qemu on a Windows host. One thing I stumbled over was missing 9p support. I thought it was because of missing (x)attr, but Stefan Weil told me that 9p is supported only under Linux hosts. I searched a bit and got following questions: * are my following results right: The

[Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. nbd_reply_ready required these semantics because it has two conflicting requirements: 1) if a reply can be received on the socket, nbd_reply_ready needs to re

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

On 7 April 2016 at 11:56, Vijay Kilari wrote: > On Thu, Apr 7, 2016 at 3:41 PM, Peter Maydell > wrote: >> On 7 April 2016 at 10:58, wrote: >>> From: Vijaya Kumar K >>> >>> utils cannot read target cpu information to >>> fetch cpu information to implement cpu specific >>> features or erratas.

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On Thu, Apr 07, 2016 at 12:35:59PM +0100, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I be

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

On 7 April 2016 at 12:04, Samuel Thibault wrote: > The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: > > Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git tag

Re: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call

On Wed 06 Apr 2016 07:57:07 PM CEST, Max Reitz wrote: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from > when it used to do some modifications on that empty BDS, but now that is > unnecessary, so we can ju

Re: [Qemu-devel] [PATCH v2 for-2.7 1/8] block: Drop useless bdrv_new() call

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS > before invoking bdrv_open() on that BDS. This is probably a relict from > when it used to do some modifications on that empty BDS, but now that is > unnecessary, so we can just s

Re: [Qemu-devel] [PATCH v2 for-2.7 3/8] tests: Drop BDS from test-throttle.c

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > Now that throttling has been moved to the BlockBackend level, we do not > need to create a BDS along with the BB in the I/O throttling test. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

Daniel, On 7 Apr 2016, at 12:51, Daniel P. Berrange wrote: > IMHO, we should not permit what you call OPTIONALTLS or SELECTIVETLS, > because these open possibilities for a MITM to perform downgrade > attacks, where the MITM runs TLS to the real server, but runs no-TLS > to the real client. Coul

Re: [Qemu-devel] [PATCH v2 for-2.7 4/8] block: Drop blk_new_with_bs()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > Its only caller is blk_new_open(), so we can just inline it there. > > Signed-off-by: Max Reitz Maybe mention that this isn't pure code motion, but that you switch to a bdrv_open() call with a NULL BDS. Either way: Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 for-2.7 5/8] block: Drop bdrv_new_root()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > By now it has become just a wrapper around bdrv_new() and it has only a > single user. Use bdrv_new() there instead and drop this function. > > Signed-off-by: Max Reitz > Reviewed-by: Alberto Garcia The commit message isn't up-to-date any more

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

On Thu, Apr 07, 2016 at 11:09:48AM +, Ilya Maximets wrote: > > --- Original Message --- > > Sender : Michael S. Tsirkin > > Date : Apr 07, 2016 10:01 (GMT+03:00) > > Title : Re: Re: [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect. > > > > On Wed, Apr 06, 2016 at 11:52:56PM +

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 7 Apr 2016, at 13:13, Alex Bligh wrote: > I guess it's worth documenting > this, though I thought it was obvious. The next version will have this section: ### Downgrade attacks A danger inherent in any scheme relying on the negotiation of whether TLS should be employed is downgrade attacks

[Qemu-devel] [PATCH v2] net: stellaris_enet: check packet length against receive buffer

From: Prasad J Pandit When receiving packets over Stellaris ethernet controller, it uses receive buffer of size 2048 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pan

Re: [Qemu-devel] [PATCH 1/2] net: stellaris_enet: check packet length against receive buffer

+-- On Thu, 7 Apr 2016, Peter Maydell wrote --+ | > n -= 31; | > s->np++; | | We should do this check before we increase s->np, because | if we're going to bail out then we won't be putting this | packet into the RX FIFO. Ah, right. | The datasheet for this chip says that we shou

Re: [Qemu-devel] [PATCH v2 for-2.7 6/8] block: Make bdrv_open() return a BDS

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > There are no callers to bdrv_open() or bdrv_open_inherit() left that > pass a pointer to a non-NULL BDS pointer as the first argument of these > functions, so we can finally drop that parameter and just make them > return the new BDS. > > General

Re: [Qemu-devel] [PATCH v2 for-2.7 7/8] block: Assert !bs->refcnt in bdrv_close()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > The only caller of bdrv_close() left is bdrv_delete(). We may as well > assert that, in a way (there are some things in bdrv_close() that make > more sense under that assumption, such as the call to > bdrv_release_all_dirty_bitmaps() which in turn

Re: [Qemu-devel] [PATCH v2 for-2.7 8/8] block: Drop bdrv_parent_cb_...() from bdrv_close()

Am 06.04.2016 um 19:57 hat Max Reitz geschrieben: > bdrv_close() now asserts that the BDS's refcount is 0, therefore it > cannot have any parents and the bdrv_parent_cb_change_media() call is a > no-op. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

On Thu, Apr 07, 2016 at 12:09:52PM +0100, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: > > > > >> One thing I still can't understand, why the unit test in host > > >> environment shows > > >> 'memcmp()' have bett

Re: [Qemu-devel] [PATCH v2] net: stellaris_enet: check packet length against receive buffer

On 7 April 2016 at 13:35, P J P wrote: > From: Prasad J Pandit > > When receiving packets over Stellaris ethernet controller, it > uses receive buffer of size 2048 bytes. In case the controller > accepts large(MTU) packets, it could lead to memory corruption. > Add check to avoid it. > > Reported

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Apr 07, 2016 at 12:09:52PM +0100, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > > > On 11/12/2015 12:56 PM, Dr. David Alan Gilbert wrote: > > > > > > >> One thing I still can't understand, why the unit test in ho

Re: [Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

On Thu, Apr 07, 2016 at 01:44:55PM +0200, Paolo Bonzini wrote: > Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual > socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. > nbd_reply_ready required these semantics because it has two conflicting > requirements: >

Re: [Qemu-devel] [PATCH 1/2] qga: fix fd leak with guest-exec i/o channels

On 4/7/2016 2:53 AM, Michael Roth wrote: Quoting Denis V. Lunev (2016-04-06 00:43:30) From: Yuriy Pudgorodskiy Signed-off-by: Yuriy Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth --- qga/commands.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands.c b/qga/c

Re: [Qemu-devel] [v2 0/2] add avx2 instruction optimization

On 07/04/2016 14:54, Michael S. Tsirkin wrote: > > char check_zero(char *p, int len) > { > char res = 0; > int i; > > for (i = 0; i < len; i++) { > res = res | p[i]; > } > > return res; > } > > > If you compile this function with --tree-vectorize and --unroll-loop

Re: [Qemu-devel] [PATCH] xen: piix reuse pci generic class init function

On 04/06/2016 11:48 PM, Michael S. Tsirkin wrote: > On Wed, Apr 06, 2016 at 04:56:12PM -0700, Stefano Stabellini wrote: >> On Sun, 3 Apr 2016, Michael S. Tsirkin wrote: >>> piix3_ide_xen_class_init is identical to piix3_ide_class_init >>> except it's buggy as it does not set exit and does not dis

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On Thu, Apr 07, 2016 at 01:13:10PM +0100, Alex Bligh wrote: > Daniel, > > On 7 Apr 2016, at 12:51, Daniel P. Berrange wrote: > > > IMHO, we should not permit what you call OPTIONALTLS or SELECTIVETLS, > > because these open possibilities for a MITM to perform downgrade > > attacks, where the MIT

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

+Raghavendra G who implemented this option in write-behind, to this upstream patch review discussion Pranith On 04/06/2016 06:50 PM, Kevin Wolf wrote: Am 06.04.2016 um 15:10 hat Jeff Cody geschrieben: On Wed, Apr 06, 2016 at 01:51:59PM +0200, Kevin Wolf wrote: Am 06.04.2016 um 13:41 hat Kevin

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

Daniel, >> Could you describe how a downgrade attack might occur? It's >> always open to the client to refuse to access an export (or >> the server as a whole) unless TLS is negotiated, as I make >> clear here (see last phrase). > > Right, so that's OK if the client is implementing FORCEDTLS. Cl

[Qemu-devel] [PATCH v6 5/6] acpi: Add IPMI table entries

From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

[Qemu-devel] [PATCH v6 6/6] bios: Add tests for the IPMI ACPI and SMBIOS entries

From: Corey Minyard Signed-off-by: Corey Minyard --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5683 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 0 -> 8456 bytes tests/bios-tables-test.c | 58 --- 3 files changed, 54 insertions(+), 4 delet

[Qemu-devel] [PATCH v6 3/6] smbios: Move table build tools into an include file.

From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

[Qemu-devel] [PATCH v6 0/6] Sort the fw_cfg file list, add IPMI BIOS table entries

This patch set includes the fw_config file list sorting, which seems to have kind of stalled. Changes from v5: Added a check to rom_[re]set_order_override() functions to see if fw_cfg is set. This could cause a crash in certain circumstances. Regenerated the BIOS test tables for other changes.

[Qemu-devel] [PATCH] pc-bios/s390-ccw: Use correct strip when cross-compiling

From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- pc-bios/s390-ccw/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile index 4208cb429593..5ce6d4ccbaf5 100644 --- a/pc-bios/s390-cc

Re: [Qemu-devel] [PATCH v6 0/6] Sort the fw_cfg file list, add IPMI BIOS table entries

On Thu, Apr 07, 2016 at 09:12:57AM -0500, miny...@acm.org wrote: > This patch set includes the fw_config file list sorting, which seems > to have kind of stalled. v5 is in my tree but I'll replace it with v6. > Changes from v5: > > Added a check to rom_[re]set_order_override() functions to see i

[Qemu-devel] [PATCH v6 1/6] Sort the fw_cfg file list

From: Gerd Hoffmann Entries are inserted in filename order instead of being appended to the end in case sorting is enabled. This will avoid any future issues of moving the file creation around, it doesn't matter what order they are created now, the will always be in filename order. Signed-off-b

[Qemu-devel] [PATCH v6 2/6] pc: Postpone SMBIOS table installation to post machine init

From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c inde

[Qemu-devel] [PATCH v6 4/6] ipmi: Add SMBIOS table entry

From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/smbios/Makefile.objs| 2 + hw/smbios/ipmi.c | 76 +++

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

Lluís Vilanova writes: > Markus Armbruster writes: > >> Peter Maydell writes: >> [...] >>> if we move away from C I'd rather >>> it to be a language that's nicer than C rather than one that's >>> uglier and larger and still retains all of C's flaws. > >> Seconded strongly. > > Just curious. Do w

Re: [Qemu-devel] [PATCH for 2.6 0/2] qga: guest exec bugfixes

Quoting Denis V. Lunev (2016-04-06 00:43:29) > Signed-off-by: Yuriy Pudgorodskiy > Signed-off-by: Denis V. Lunev > CC: Michael Roth > Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga Can confirm it fixes guest-exec output on Windows 7 for me (was already working for

Re: [Qemu-devel] [PATCH 1/2] qga: fix fd leak with guest-exec i/o channels

Quoting Yuriy Pudgorodskiy (2016-04-07 06:22:13) > On 4/7/2016 2:53 AM, Michael Roth wrote: > > Quoting Denis V. Lunev (2016-04-06 00:43:30) > >> From: Yuriy Pudgorodskiy > >> > >> Signed-off-by: Yuriy Pudgorodskiy > >> Signed-off-by: Denis V. Lunev > >> CC: Michael Roth > >> --- > >> qga/com

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 04/07/2016 05:35 AM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as a

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 04/07/2016 05:51 AM, Daniel P. Berrange wrote: >> + >> +There are four modes of operation for a server. The >> +server MUST support one of these modes. >> + >> +* The server operates entirely without TLS ('NOTLS'); OR >> + >> +* The server makes TLS available (for all exports) and >> + it is a

Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavior

On 29/03/2016 17:08, Kevin Wolf wrote: > From: Max Reitz > > Passing -S 0 to qemu-img convert should result in all source data being > copied to the output, even if that source data is known to be 0. The > output image should therefore have exactly the same size on disk as an > image which we e

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

On 3 April 2016 at 14:05, Lluís Vilanova wrote: > QOM to C++ classes I suspect if you looked at this you'd find that the QOM semantics for various things don't map onto C++ (ie that we have more runtime flexibility than C++ does). This is just vaguely remembered from discussions back when we firs

Re: [Qemu-devel] [RFC v2 1/9] virtio: fix stray tab character

Stefan Hajnoczi writes: > The patches fixes a single occurrence of a tab character that resulted "The patch fixes" or "Fix", or drop the sentence. > in mis-aligned indentation. Really? It comes out aligned in my editor. > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Fam Zheng

[Qemu-devel] [PATCH for-2.6] vpc: fix return value check for blk_pwrite

bdrv_pwrite_sync used to return zero or negative error, while blk_pwrite returns the number of written bytes when successful. This caused VPC image creation to fail spectacularly: it wrote the first 512 bytes, and then exited immediately because of the non-zero answer from blk_pwrite. But the tru

Re: [Qemu-devel] [PATCH] Improve documentation for TLS

On 7 Apr 2016, at 15:31, Eric Blake wrote: >> +### TLS versions Certificates, authentication and authorisation > > s/versions/versions,/ ? ok >> + >> +NBD implementations supporting TLS MUST support TLS version >> +1.2, and MAY support other (earlier or later) versions of >> +TLS/SSL. > > Al

Re: [Qemu-devel] [RFC] [tcg] Idea on refactoring target code generation loop (gen_intermediate_code)

On 07/04/2016 16:49, Peter Maydell wrote: > > QOM to C++ classes > I suspect if you looked at this you'd find that the QOM semantics > for various things don't map onto C++ (ie that we have more runtime > flexibility than C++ does). True, but you don't have to use it. :) If your code is static,

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

On 04/07/2016 12:45 PM, Laurent Vivier wrote: > > > On 07/04/2016 12:27, Cédric Le Goater wrote: >> Hello Laurent, >> >> On 04/07/2016 11:13 AM, Laurent Vivier wrote: >>> >>> >>> On 05/04/2016 04:17, David Gibson wrote: From: Cédric Le Goater From: Benjamin Herrenschmidt >>>

  1   2   3   >