Re: [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel

2016-04-06 Thread Greg Kurz
On Wed, 6 Apr 2016 09:49:34 +0800 Jason Wang wrote: > On 04/05/2016 11:54 PM, Greg Kurz wrote: > > On Mon, 21 Mar 2016 13:25:53 +0800 > > Jason Wang wrote: > >> > Hi: > >> > > >> > This series enable vhost-kernel busy polling support. It's done > >> > through introducing a new property for ta

Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void

2016-04-06 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> Why not... > On 5 Apr 2016, at 14:26 PM, Cao jin wrote: > > Nobody use its return value, so change the type to void > > Signed-off-by: Cao jin > CC: Paolo Bonzini > CC: Dmitry Fleytman > --- > hw/scsi/vmw_pvscsi.c | 4 +--- > 1 file change

Re: [Qemu-devel] [PATCH v2 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-06 Thread Dmitry Fleytman
> On 8 Mar 2016, at 11:51 AM, Jason Wang wrote: > > > > On 02/23/2016 01:37 AM, Leonid Bloch wrote: >> Hello All, >> >> This is v2 of the patches, after the initial reviews. >> >> For convenience, the same patches are available at: >> https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-

Re: [Qemu-devel] [PATCH v2 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-06 Thread Dmitry Fleytman
> On 8 Mar 2016, at 05:01 AM, Jason Wang wrote: > > > > On 02/23/2016 01:37 AM, Leonid Bloch wrote: >> Hello All, >> >> This is v2 of the patches, after the initial reviews. >> >> For convenience, the same patches are available at: >> https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

2016-04-06 Thread Thomas Huth
On 06.04.2016 02:13, ste...@steven676.net wrote: > QEMU's user-mode networking does not currently pass received TCP RSTs to > guests, meaning that applications in guests hang if the remote server > rejects their network connections. This is particularly noticeable when > IPv6 is enabled, the guest

Re: [Qemu-devel] [PATCH v2 09/13] net_pkt: Name vmxnet3 packet abstractions more generic

2016-04-06 Thread Dmitry Fleytman
> On 8 Mar 2016, at 05:10 AM, Jason Wang wrote: > > > > On 02/23/2016 01:37 AM, Leonid Bloch wrote: >> From: Dmitry Fleytman >> >> This patch drops "vmx" prefix from packet abstrations names >> to emphasize the fact they are generic and not tied to any >> specific network device. >> >> Thes

Re: [Qemu-devel] [PATCH v2 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-06 Thread Dmitry Fleytman
> On 8 Mar 2016, at 05:01 AM, Jason Wang wrote: > > > > On 02/23/2016 01:37 AM, Leonid Bloch wrote: >> Hello All, >> >> This is v2 of the patches, after the initial reviews. >> >> For convenience, the same patches are available at: >> https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-

Re: [Qemu-devel] [PATCH qemu v15 13/17] vfio: Add host side DMA window capabilities

2016-04-06 Thread David Gibson
On Mon, Apr 04, 2016 at 07:33:42PM +1000, Alexey Kardashevskiy wrote: > There are going to be multiple IOMMUs per a container. This moves > the single host IOMMU parameter set to a list of VFIOHostIOMMU. ^^^ Haven't updated your commit message for

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-06 Thread Wen Congyang
On 04/01/2016 11:20 PM, Max Reitz wrote: > On 31.03.2016 13:42, Alberto Garcia wrote: >> On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: I also have another (not directly related) question: why not simply use the node name when removing children? I understood that the idea was

Re: [Qemu-devel] [PATCH] Fix NBD unsupported options

2016-04-06 Thread Paolo Bonzini
On 05/04/2016 20:55, Alex Bligh wrote: > nbd-client.c currently fails to handle unsupported options properly. > If during option haggling the server finds an option that is > unsupported, it returns an NBD_REP_ERR_UNSUP reply. > > According to nbd's proto.md, the format for such a reply > should

Re: [Qemu-devel] [PATCH for-2.6] qemu-nbd: Document -x option

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 04:02, Eric Blake wrote: > Commit 3d4b2f9c added -x to force qemu-nbd to use new-style > negotiation, but while it documented it in the man page, it > omitted docs in the --help output. > > Signed-off-by: Eric Blake > --- > qemu-nbd.c | 1 + > 1 file changed, 1 insertion(+) > >

[Qemu-devel] [PATCH] target-i386: check for PKU even for non-writable pages

2016-04-06 Thread Paolo Bonzini
Xiao Guangrong ran kvm-unit-tests on an actual machine with PKU and found that it fails: test pte.p pte.user pde.p pde.user pde.a pde.pse pkru.wd pkey=1 user write efer.nx cr4.pke: FAIL: error code 27 expected 7 Dump mapping: address: 0x1234 --L4: 2ebe007 --L3: 2ebf007 --L2: 8

Re: [Qemu-devel] [PATCH 2/3] slirp: Propagate host TCP RST to the guest.

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 02:14, ste...@steven676.net wrote: > As this patch isn't my work and did not come with a Signed-off-by line, > I'm not entirely clear on how I should handle that. Signed-off-by lines weren't in consistent use at the time, so I think it's okay to leave it out. Paolo

Re: [Qemu-devel] [RFC PATCH v1 2/2] target-arm: Use Neon for zero checking

2016-04-06 Thread Vijay Kilari
On Tue, Apr 5, 2016 at 8:06 PM, Peter Maydell wrote: > On 4 April 2016 at 14:39, wrote: >> From: Vijay >> >> Use Neon instructions to perform zero checking of >> buffer. This is helps in reducing downtime during >> live migration. >> >> Signed-off-by: Vijaya Kumar K >> --- >> util/cutils.c |

[Qemu-devel] [PATCH v3 02/16] pci: Introduce define for PM capability version 1.1

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/hw/pci/pci_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/pci/pci_regs.h b/include/hw/pci/pci_regs.h index ba8cbe9..7a83142 100644 --- a/include/hw/pci/pci_regs.h +++ b/include

[Qemu-devel] [PATCH v3 04/16] pcie: Introduce function for DSN capability creation

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 10 ++ include/hw/pci/pcie.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 24cfc3b..9599fde 100644 --- a/hw/pci/pcie.c +++ b/hw/pci

[Qemu-devel] [PATCH v3 03/16] pcie: Add support for PCIe CAP v1

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Added support for PCIe CAP v1, while reusing some of the existing v2 infrastructure. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 84 -- include/hw/pci/pcie.h | 4 +++ includ

[Qemu-devel] [PATCH v3 01/16] msix: make msix_clr_pending() visible for clients

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman This function will be used by e1000e device code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/msix.c | 2 +- include/hw/pci/msix.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index b

[Qemu-devel] [PATCH v3 05/16] vmxnet3: Use generic function for DSN capability definition

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 093a71e..0a4db4d 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c

[Qemu-devel] [PATCH v3 08/16] vmxnet3: Use common MAC address tracing macros

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 8 hw/net/vmxnet_debug.h | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 0a4db4d..26f6f90 100644 --- a/hw/net/

[Qemu-devel] [PATCH v3 09/16] net_pkt: Name vmxnet3 packet abstractions more generic

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch drops "vmx" prefix from packet abstrations names to emphasize the fact they are generic and not tied to any specific network device. These abstrations will be reused by e1000e emulation implementation introduced by following patches so their names need generaliza

[Qemu-devel] [PATCH v3 07/16] net: Add macros for MAC address tracing

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman These macros will be used by future commits introducing e1000e device emulation and by vmxnet3 tracing code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/net/net.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/net.h b/incl

[Qemu-devel] [PATCH v3 10/16] rtl8139: Move more TCP definitions to common header

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/rtl8139.c | 5 - include/net/eth.h | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index fee97bf..262228c 100644 --- a/hw/net/rtl813

[Qemu-devel] [PATCH v3 12/16] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman To make this device and network packets abstractions ready for IOMMU. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/net_tx_pkt.c | 16 +++- hw/net/net_tx_pkt.h | 5 +++-- hw/net/vmxnet3.c| 51 ++

[Qemu-devel] [PATCH v3 00/16] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-04-06 Thread Dmitry Fleytman
Hello All, This is v3 of e1000e series. For convenience, the same patches are available at: https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v3 Best regards, Dmitry. Changes since v2: 1. Interrupt storm on latest Linux kernels fixed 2. Device unit test added 3. Introduced code sharing

[Qemu-devel] [PATCH v3 14/16] e1000: Move out code that will be reused in e1000e

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Code that will be shared moved to a separate files. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- MAINTAINERS| 5 + hw/net/Makefile.objs | 2 +- hw/net/e1000.c | 411 +++-- hw/net/e100

[Qemu-devel] [PATCH v3 06/16] net: Introduce Toeplitz hash calculator

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/net/checksum.h | 45 + 1 file changed, 45 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 7de1acb..dd8b4f6 100644 --- a/inc

[Qemu-devel] [PATCH v3 13/16] e1000_regs: Add definitions for Intel 82574-specific bits

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/e1000_regs.h | 345 +++- 1 file changed, 342 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000_regs.h b/hw/net/e1000_regs.h index 1c40244..d62b3fa

[Qemu-devel] [PATCH v3 16/16] e1000e: Introduce qtest for e1000e device

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- tests/Makefile | 3 + tests/e1000e-test.c | 480 2 files changed, 483 insertions(+) create mode 100644 tests/e1000e-test.c diff --git a/tests/Makef

[Qemu-devel] [PATCH v3 11/16] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-04-06 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch extends the TX/RX packet abstractions with features that will be used by the e1000e device implementation. Changes are: 1. Support iovec lists for RX buffers 2. Deeper RX packets parsing 3. Loopback option for TX packets 4. Extended VLAN headers handling

Re: [Qemu-devel] [PATCH 03/10] seqlock: remove optional mutex

2016-04-06 Thread Alex Bennée
Emilio G. Cota writes: > This option is unused; besides, it bloats the struct when not needed. > Let's just let writers define their own locks elsewhere. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > cpus.c | 2 +- > include/qemu/seqlock.h | 10 +---

[Qemu-devel] [PATCH] virtio-gpu: add live migration support

2016-04-06 Thread Gerd Hoffmann
Store some additional state for cursor and resource backing storage, so we can write out and reload things. Implement vmsave+vmload for 2d mode. Block live migration in 3d/virgl mode. [ depends on https://patchwork.ozlabs.org/patch/604623/ ] Signed-off-by: Gerd Hoffmann --- hw/display/virtio-

Re: [Qemu-devel] [PATCH 04/10] seqlock: rename write_lock/unlock to write_begin/end

2016-04-06 Thread Alex Bennée
Emilio G. Cota writes: > It is a more appropriate name, now that the mutex embedded > in the seqlock is gone. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > cpus.c | 28 ++-- > include/qemu/seqlock.h | 4 ++-- > 2 files changed, 1

Re: [Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device

2016-04-06 Thread Stefan Hajnoczi
On Tue, Apr 05, 2016 at 02:54:56PM +0200, Baptiste Reynal wrote: > On Thu, Mar 31, 2016 at 11:12 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 18, 2016 at 10:13:03AM +0100, Baptiste Reynal wrote: > >> This is the virtio implementation for an SDM device. > >> > >> Parameters are: > >> comm=[sdm_commun

Re: [Qemu-devel] [RFC v2 0/6] QEMU shared-memory backend

2016-04-06 Thread Stefan Hajnoczi
On Tue, Apr 05, 2016 at 02:00:40PM +0200, Baptiste Reynal wrote: > On Thu, Mar 31, 2016 at 11:14 AM, Stefan Hajnoczi wrote: > > > > On Fri, Mar 18, 2016 at 10:13:52AM +0100, Baptiste Reynal wrote: > > > A new memory backend, the shared memory backend, based on > > > the file memory backend. > > >

Re: [Qemu-devel] [PATCH] TLS: provide slightly more information when TLS certificate loading fails

2016-04-06 Thread Daniel P. Berrange
On Tue, Apr 05, 2016 at 08:33:48PM +0100, Alex Bligh wrote: > Give slightly more information when certification loading fails. > Rather than have no information, you now get gnutls's only slightly > less unhelpful error messages. > > Signed-off-by: Alex Bligh > --- > crypto/tlscredsx509.c | 17 +

Re: [Qemu-devel] [Qemu-block] Possible bug: virtio-scsi + iothread (Former x-data-plane) = "Guest moved index from 0 to 61440" warning

2016-04-06 Thread Stefan Hajnoczi
On Tue, Apr 05, 2016 at 07:49:47PM -0300, Zir Blazer wrote: > The bare minimum script that produces the warning, should be this: > #!/bin/bash > qemu-system-x86_64 \-m 1024M \-enable-kvm \-object iothread,id=iothread0 > \-device virtio-scsi-pci,iothread=iothread0 \ > This produces the "Guest moved

Re: [Qemu-devel] [PATCH 2/3] slirp: Propagate host TCP RST to the guest.

2016-04-06 Thread Edgar E. Iglesias
On Tue, Apr 05, 2016 at 05:14:31PM -0700, ste...@steven676.net wrote: > When the host aborts (RST) it's side of a TCP connection we need to > propagate that RST to the guest. The current code can leave such guest > connections dangling forever. Spotted by Jason Wessel. > > [ste...@steven676.net: c

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Daniel P. Berrange
On Tue, Apr 05, 2016 at 09:01:10PM +0100, Alex Bligh wrote: > When I attempt to connect via TLS like this (using today's qemu master): > >./qemu-img info --object > tls-creds-x509,id=tls0,dir=../certs,endpoint=client --image-opts > driver=nbd,host=127.0.0.1,port=,export=foo,tls-creds=tls

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Daniel P. Berrange
On Wed, Apr 06, 2016 at 10:09:07AM +0100, Daniel P. Berrange wrote: > On Tue, Apr 05, 2016 at 09:01:10PM +0100, Alex Bligh wrote: > > When I attempt to connect via TLS like this (using today's qemu master): > > > >./qemu-img info --object > > tls-creds-x509,id=tls0,dir=../certs,endpoint=clien

Re: [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel

2016-04-06 Thread Jason Wang
On 04/06/2016 03:11 PM, Greg Kurz wrote: > On Wed, 6 Apr 2016 09:49:34 +0800 > Jason Wang wrote: > >> > On 04/05/2016 11:54 PM, Greg Kurz wrote: >>> > > On Mon, 21 Mar 2016 13:25:53 +0800 >>> > > Jason Wang wrote: > > >> > Hi: > > >> > > > >> > This series enable vhost-kernel bus

[Qemu-devel] [PATCH V2] tap: vhost busy polling support

2016-04-06 Thread Jason Wang
This patch add the capability of basic vhost net busy polling which is supported by recent kernel. User could configure the maximum number of us that could be spent on busy polling through a new property of tap "vhost-poll-us". Signed-off-by: Jason Wang --- Changes from V1: - add missing document

Re: [Qemu-devel] [PATCH] disas/microblaze: Add missing 'const' attributes

2016-04-06 Thread Edgar E. Iglesias
On Tue, Mar 22, 2016 at 08:31:33AM +0100, Stefan Weil wrote: > Making the opcode list 'const' saves memory. > Some function arguments and local variables needed 'const', too. > > Add also 'static' to two local functions. Hi Stefan, Sorry for the delays... I gave this a try but it fails for me:

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Alex Bligh
On 6 Apr 2016, at 10:09, Daniel P. Berrange wrote: > I've just tested using your certs and they work correctly for me. I have > gnutls-3.4.10-1.fc23.x86_64 on Fedora 23, so either there's something > broken with gnutls 2.x compatibility in general, or there's a specific > bug in your exact vers

[Qemu-devel] [PATCH] qemu-img: fix formatting of error message

2016-04-06 Thread Daniel P. Berrange
The error_reportf_err() will not automatically append a ': ' before adding its suffix, so we must include that in the message we pass it, otherwise we get a badly formatted message lacking whitespace: qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=,tls-creds=tls0'Failed to connect s

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Alex Bligh
On 6 Apr 2016, at 10:11, Daniel P. Berrange wrote: > Oh I'd be interested to know if the unit tests pass for you - can you > run this > > make ./tests/test-crypto-tlssession ./tests/test-crypto-tlscredsx509 > ./tests/test-crypto-tlscredsx509 > ./tests/test-crypto-tlssession See below. They

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

2016-04-06 Thread Alex Bligh
On 5 Apr 2016, at 22:26, Eric Blake wrote: > In particular, I had a question about the ideal layout of the data in > NBD_REP_SERVER; I'd like some discussion on that point before posting a > cleanup patch. Hmmm... Yes. In particular: > NBD_REP_SERVER (2) > > A description of an export. Data:

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Daniel P. Berrange
On Wed, Apr 06, 2016 at 10:22:45AM +0100, Alex Bligh wrote: > > On 6 Apr 2016, at 10:11, Daniel P. Berrange wrote: > > > Oh I'd be interested to know if the unit tests pass for you - can you > > run this > > > > make ./tests/test-crypto-tlssession ./tests/test-crypto-tlscredsx509 > > ./tests/

Re: [Qemu-devel] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Alberto Garcia
On Mon 04 Apr 2016 05:26:02 PM CEST, Kevin Wolf wrote: > The problem exists whenever a BDS has more users than just its BB, for > example it is used as a backing file for another node. The code seems correct, but I don't understand this use case. Berto

Re: [Qemu-devel] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 11:45 hat Alberto Garcia geschrieben: > On Mon 04 Apr 2016 05:26:02 PM CEST, Kevin Wolf wrote: > > The problem exists whenever a BDS has more users than just its BB, for > > example it is used as a backing file for another node. > > The code seems correct, but I don't understand t

Re: [Qemu-devel] [PATCH] disas/microblaze: Add missing 'const' attributes

2016-04-06 Thread Stefan Weil
Am 06.04.2016 um 11:16 schrieb Edgar E. Iglesias: > On Tue, Mar 22, 2016 at 08:31:33AM +0100, Stefan Weil wrote: >> Making the opcode list 'const' saves memory. >> Some function arguments and local variables needed 'const', too. >> >> Add also 'static' to two local functions. > Hi Stefan, > > Sorry

Re: [Qemu-devel] [PATCH for 2.6 1/1] iotests: fix the broken 026.nocache output

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 08:08 hat Denis V. Lunev geschrieben: > From: Pavel Butsykin > > This patch fixes longstanding issue with 026 iotest. Unfortunately, > this test contains 2 versions of the correct output, one for cached > writes and one for non-cached ones. People tends to fix only one > version

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

2016-04-06 Thread Edgar E. Iglesias
On Tue, Apr 05, 2016 at 05:13:58PM -0700, ste...@steven676.net wrote: > QEMU's user-mode networking does not currently pass received TCP RSTs to > guests, meaning that applications in guests hang if the remote server > rejects their network connections. This is particularly noticeable when > IPv6

Re: [Qemu-devel] [RFC v2 01/11] tcg: move tb_invalidated_flag to CPUState

2016-04-06 Thread Sergey Fedorov
On 05/04/16 18:44, Paolo Bonzini wrote: > > On 05/04/2016 17:32, Alex Bennée wrote: >> +cpu->tb_invalidated_flag = false; >> tb = tb_gen_code(cpu, orig_tb->pc, orig_tb->cs_base, orig_tb->flags, >> max_cycles | CF_NOCACHE >> | (ignore_icount ?

[Qemu-devel] [PATCH 1/7] virtio: make virtio_queue_notify_vq static

2016-04-06 Thread Paolo Bonzini
Acked-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 14d5d91..264d4f6 100644 --- a/hw/virtio/virtio.c +++ b/hw/virt

[Qemu-devel] [PATCH 2/7] virtio-blk: fix disabled mode

2016-04-06 Thread Paolo Bonzini
We must not call virtio_blk_data_plane_notify if dataplane is disabled: we would hit a segmentation fault in notify_guest_bh as s->guest_notifier has not been setup and is NULL. Reviewed-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 7 +++ hw/block/vir

[Qemu-devel] [PATCH v3 0/7] virtio: aio handler API

2016-04-06 Thread Paolo Bonzini
This version removes patches 1 and 9, fixes some commit messages, and fixes some small in the formatting issues. Michael S. Tsirkin (2): virtio: add aio handler virtio-blk: use aio handler for data plane Paolo Bonzini (5): virtio: make virtio_queue_notify_vq static virtio-blk: fix disable

[Qemu-devel] [PATCH 4/7] virtio: add aio handler

2016-04-06 Thread Paolo Bonzini
From: "Michael S. Tsirkin" In addition to handling IO in vcpu thread and in io thread, blk dataplane introduces yet another mode: handling it by AioContext. Currently, this reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Add instead a s

[Qemu-devel] [PATCH 6/7] virtio-scsi: use aio handler for data plane

2016-04-06 Thread Paolo Bonzini
In addition to handling IO in vcpu thread and in io thread, dataplane introduces yet another mode: handling it by AioContext. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Use a separate handler just for aio, and disable regular h

[Qemu-devel] [PATCH 3/7] virtio-scsi: fix disabled mode

2016-04-06 Thread Paolo Bonzini
Add two missing checks for s->dataplane_fenced. In one case, QEMU would skip injecting an IRQ due to a write to an uninitialized EventNotifier's file descriptor. In the second case, the dataplane_disabled field was used by mistake; in fact after fixing this occurrence it is completely unused. Re

[Qemu-devel] [PATCH 5/7] virtio-blk: use aio handler for data plane

2016-04-06 Thread Paolo Bonzini
From: "Michael S. Tsirkin" In addition to handling IO in vcpu thread and in io thread, dataplane introduces yet another mode: handling it by AioContext. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Use a separate handler just f

[Qemu-devel] [PATCH 7/7] virtio: merge virtio_queue_aio_set_host_notifier_handler with virtio_queue_set_aio

2016-04-06 Thread Paolo Bonzini
Eliminating the reentrancy is actually a nice thing that we can do with the API that Michael proposed, so let's make it first class. This also hides the complex assign/set_handler conventions from callers of virtio_queue_aio_set_host_notifier_handler, which in fact was always called with assign=tru

Re: [Qemu-devel] [PATCH] qemu-img: fix formatting of error message

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 11:16 hat Daniel P. Berrange geschrieben: > The error_reportf_err() will not automatically append a > ': ' before adding its suffix, so we must include that > in the message we pass it, otherwise we get a badly > formatted message lacking whitespace: > > qemu-img: Could not open

Re: [Qemu-devel] 'make check' failure on Fedora 23

2016-04-06 Thread Michael S. Tsirkin
On Tue, Apr 05, 2016 at 05:35:38PM -0600, Eric Blake wrote: > Fedora 23 recently pushed acpica-tools.x86_64 20160318-1.fc23; with this > installed, 'make check-qtest' (part of 'make check') now fails with: > > GTESTER check-qtest-x86_64 > ** > ERROR:tests/bios-tables-test.c:455:normalize_asl: asse

[Qemu-devel] [PATCH] doc/proto.md: NBD_OPT_STARTTLS cannot be used twice

2016-04-06 Thread Alex Bligh
Currently doc/proto.md is silent on use of NBD_OPT_STARTTLS when TLS has already been negotiated. Make it clear that this is not permitted. Signed-off-by: Alex Bligh --- doc/proto.md | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/proto.md b/doc/proto.md index 4d63b23

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Kevin Wolf
[ Adding some CCs ] Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben: > Upon receiving an I/O error after an fsync, by default gluster will > dump its cache. However, QEMU will retry the fsync, which is especially > useful when encountering errors such as ENOSPC when using the werror=stop > optio

Re: [Qemu-devel] [PATCH 4/7] virtio: add aio handler

2016-04-06 Thread Cornelia Huck
On Wed, 6 Apr 2016 12:16:25 +0200 Paolo Bonzini wrote: > From: "Michael S. Tsirkin" > > In addition to handling IO in vcpu thread and in io thread, blk dataplane > introduces yet another mode: handling it by AioContext. > > Currently, this reuses the same handler as previous modes, > which tr

[Qemu-devel] [PATCH] block: initialize qcrypto API at startup

2016-04-06 Thread Daniel P. Berrange
Any programs which call the qcrypto APIs should ensure that qcrypto_init() has been called before anything else which can use crypto. Essentially this means right at the start of the main method before initializing anything else. This is important because some versions of gnutls/gcrypt require exp

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Daniel P. Berrange
On Tue, Apr 05, 2016 at 09:01:10PM +0100, Alex Bligh wrote: > When I attempt to connect via TLS like this (using today's qemu master): > >./qemu-img info --object > tls-creds-x509,id=tls0,dir=../certs,endpoint=client --image-opts > driver=nbd,host=127.0.0.1,port=,export=foo,tls-creds=tls

Re: [Qemu-devel] [PATCH 06/10] include: add xxhash.h

2016-04-06 Thread Alex Bennée
Emilio G. Cota writes: > xxhash is a fast, high-quality hashing function. The appended > brings in the 32-bit version of it, with the small modification that > it assumes the data to be hashed is made of 32-bit chunks; this increases > speed slightly for the use-case we care about, i.e. tb-hash.

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Alex Bligh
Daniel, On 6 Apr 2016, at 12:13, Daniel P. Berrange wrote: > So the problem turned out to be that the qemu-img program failed to > call qcrypto_init(), so gnutls had not had its one-time initialization > performed. This doesn't matter for gnutls 3.x but does for anything > older than that. I jus

Re: [Qemu-devel] [PATCH] block: initialize qcrypto API at startup

2016-04-06 Thread Alex Bligh
On 6 Apr 2016, at 12:12, Daniel P. Berrange wrote: > Any programs which call the qcrypto APIs should ensure that > qcrypto_init() has been called before anything else which > can use crypto. Essentially this means right at the start > of the main method before initializing anything else. > > Th

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 13:19 hat Ric Wheeler geschrieben: > > We had a thread discussing this not on the upstream list. > > My summary of the thread is that I don't understand why gluster > should drop cached data after a failed fsync() for any open file. It certainly shouldn't, but it does by default

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

2016-04-06 Thread Paolo Bonzini
On 05/04/2016 22:09, Lluís Vilanova wrote: > Ah. That's just an example. For cross-compilation you would use a different > march argument (or none to use the default target sub-arch) and get the > parameter for the target processor. This should already be known by configure > as > part of the ar

Re: [Qemu-devel] [PATCH 07/10] tb hash: hash phys_pc, pc, and flags with xxhash

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 02:52, Emilio G. Cota wrote: > +static inline uint32_t tb_hash_func5(uint64_t a0, uint64_t b0, uint32_t e, > int seed) I would keep just this version and unconditionally zero-extend to 64-bits. The compiler is able to detect the high 32 bits are zero, drop the more expensive mult

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 13:41 hat Kevin Wolf geschrieben: > Am 06.04.2016 um 13:19 hat Ric Wheeler geschrieben: > > > > We had a thread discussing this not on the upstream list. > > > > My summary of the thread is that I don't understand why gluster > > should drop cached data after a failed fsync() for

Re: [Qemu-devel] Any progress with the Cortex-M4 emulation?

2016-04-06 Thread Peter Maydell
On 5 April 2016 at 22:57, Liviu Ionescu wrote: > (I know that from time to time this question pops up, but) is > there anyone working or planning to work on the M4 emulation? Not that I'm aware of; Michael Davidsaver had some patches for improving the v7M interrupt/exception emulation, but I don'

Re: [Qemu-devel] [PATCH 02/10] compiler.h: add QEMU_CACHELINE + QEMU_ALIGN() + QEMU_CACHELINE_ALIGNED

2016-04-06 Thread Laurent Desnogues
On Wed, Apr 6, 2016 at 1:44 PM, Paolo Bonzini wrote: > > > On 05/04/2016 22:09, Lluís Vilanova wrote: >> Ah. That's just an example. For cross-compilation you would use a different >> march argument (or none to use the default target sub-arch) and get the >> parameter for the target processor. Thi

Re: [Qemu-devel] [PATCH 4/7] virtio: add aio handler

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 13:11, Cornelia Huck wrote: >> > +static void virtio_queue_notify_aio_vq(VirtQueue *vq) >> > +{ >> > +if (vq->vring.desc && vq->handle_aio_output) { >> > +VirtIODevice *vdev = vq->vdev; >> > + >> > +trace_virtio_queue_notify(vdev, vq - vdev->vq, vq); >> > +

Re: [Qemu-devel] Error when attempting to perform TLS NBD connection

2016-04-06 Thread Daniel P. Berrange
On Wed, Apr 06, 2016 at 12:40:44PM +0100, Alex Bligh wrote: > Daniel, > > On 6 Apr 2016, at 12:13, Daniel P. Berrange wrote: > > > So the problem turned out to be that the qemu-img program failed to > > call qcrypto_init(), so gnutls had not had its one-time initialization > > performed. This do

Re: [Qemu-devel] [PATCH] doc/proto.md: NBD_OPT_STARTTLS cannot be used twice

2016-04-06 Thread Eric Blake
On 04/06/2016 04:50 AM, Alex Bligh wrote: > Currently doc/proto.md is silent on use of NBD_OPT_STARTTLS when > TLS has already been negotiated. Make it clear that this is not > permitted. > > Signed-off-by: Alex Bligh > --- > doc/proto.md | 5 - > 1 file changed, 4 insertions(+), 1 deletion(

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Jeff Cody
On Wed, Apr 06, 2016 at 01:02:16PM +0200, Kevin Wolf wrote: > [ Adding some CCs ] > > Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben: > > Upon receiving an I/O error after an fsync, by default gluster will > > dump its cache. However, QEMU will retry the fsync, which is especially > > useful wh

Re: [Qemu-devel] Any progress with the Cortex-M4 emulation?

2016-04-06 Thread Liviu Ionescu
> On 06 Apr 2016, at 15:02, Peter Maydell wrote: > > On 5 April 2016 at 22:57, Liviu Ionescu wrote: >> (I know that from time to time this question pops up, but) is >> there anyone working or planning to work on the M4 emulation? > > Not that I'm aware of; Michael Davidsaver had some patches f

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

2016-04-06 Thread Samuel Thibault
Hello, Thanks for this! ste...@steven676.net, on Tue 05 Apr 2016 17:13:58 -0700, wrote: > The second, > which fixes delivery of an RST interrupting an already-established TCP > connection, was submitted by Edgar Iglesias in 2008 and appears to have > been missed then. The last patch fixes the ca

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Jeff Cody
On Wed, Apr 06, 2016 at 01:51:59PM +0200, Kevin Wolf wrote: > Am 06.04.2016 um 13:41 hat Kevin Wolf geschrieben: > > Am 06.04.2016 um 13:19 hat Ric Wheeler geschrieben: > > > > > > We had a thread discussing this not on the upstream list. > > > > > > My summary of the thread is that I don't under

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-06 Thread Kevin Wolf
Am 05.04.2016 um 15:28 hat Paolo Bonzini geschrieben: > On 05/04/2016 07:09, Kevin Wolf wrote: > > > TRIM is an advisory operation, so it doesn't make sense to force access > > > to the medium. > > > > I think it does make sense. It means that on completion there is no > > pending discard operatio

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 15:10 hat Jeff Cody geschrieben: > On Wed, Apr 06, 2016 at 01:51:59PM +0200, Kevin Wolf wrote: > > Am 06.04.2016 um 13:41 hat Kevin Wolf geschrieben: > > > Am 06.04.2016 um 13:19 hat Ric Wheeler geschrieben: > > > > > > > > We had a thread discussing this not on the upstream list.

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

2016-04-06 Thread Michael S. Tsirkin
On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: > +MemoryRegion flash; > > > Looks there's no real implementation for flash. So is this really needed > (e.g did WHQL or other test check for this?). > > > From our experience some drivers may verify that devic

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 15:14, Kevin Wolf wrote: >>> > > >>> > > I think it does make sense. It means that on completion there is no >>> > > pending discard operation (i.e. either there wasn't a discard or if >>> > > there was, it has completed) and other readers will see the final state >>> > > of the bl

Re: [Qemu-devel] [PATCH 4/7] virtio: add aio handler

2016-04-06 Thread Cornelia Huck
On Wed, 6 Apr 2016 14:09:12 +0200 Paolo Bonzini wrote: > On 06/04/2016 13:11, Cornelia Huck wrote: > >> > +static void virtio_queue_notify_aio_vq(VirtQueue *vq) > >> > +{ > >> > +if (vq->vring.desc && vq->handle_aio_output) { > >> > +VirtIODevice *vdev = vq->vdev; > >> > + > >> > +

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

2016-04-06 Thread Dmitry Fleytman
> On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: >>+MemoryRegion flash; >> >> >>Looks there's no real implementation for flash. So is this really needed >>(e.g did WHQL or other test check for this?

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

2016-04-06 Thread Michael S. Tsirkin
On Wed, Apr 06, 2016 at 04:42:57PM +0300, Dmitry Fleytman wrote: > > > On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: > >>+MemoryRegion flash; > >> > >> > >>Looks there's no real implementation for

Re: [Qemu-devel] [PATCH v2 13/13] net: Introduce e1000e device emulation

2016-04-06 Thread Dmitry Fleytman
> On 6 Apr 2016, at 16:44 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 06, 2016 at 04:42:57PM +0300, Dmitry Fleytman wrote: >> >>> On 6 Apr 2016, at 16:23 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, Apr 06, 2016 at 11:22:24AM +0300, Dmitry Fleytman wrote: +MemoryRegion flash

Re: [Qemu-devel] [RFC v2 0/6] QEMU shared-memory backend

2016-04-06 Thread Igor Mammedov
On Wed, 6 Apr 2016 09:57:57 +0100 Stefan Hajnoczi wrote: > On Tue, Apr 05, 2016 at 02:00:40PM +0200, Baptiste Reynal wrote: > > On Thu, Mar 31, 2016 at 11:14 AM, Stefan Hajnoczi > > wrote: > > > > > > On Fri, Mar 18, 2016 at 10:13:52AM +0100, Baptiste Reynal wrote: > > > > A new memory back

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-06 Thread Ric Wheeler
We had a thread discussing this not on the upstream list. My summary of the thread is that I don't understand why gluster should drop cached data after a failed fsync() for any open file. For closed files, I think it might still happen but this is the same as any file system (and unlikely to

Re: [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 15:28 hat Paolo Bonzini geschrieben: > > > On 06/04/2016 15:14, Kevin Wolf wrote: > >>> > > > >>> > > I think it does make sense. It means that on completion there is no > >>> > > pending discard operation (i.e. either there wasn't a discard or if > >>> > > there was, it has com

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

2016-04-06 Thread Amit Shah
On (Wed) 06 Apr 2016 [09:48:19], Jason Wang wrote: > > > On 04/05/2016 09:32 PM, Dr. David Alan Gilbert wrote: > > * Amit Shah (amit.s...@redhat.com) wrote: > >> On (Tue) 23 Feb 2016 [15:02:58], Jason Wang wrote: > > This means that 2.5 cannot migrate 2.4 virtual machines, right? Is that > >

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-04-06 Thread Eric Blake
On 04/05/2016 11:57 PM, Denis V. Lunev wrote: >> Looks like there will still be some more conversation and at least a v3 >> needed, but I'll wait a couple days for that to happen so that more >> reviewers can chime in, without being too tired during the review >> process. >> > that looks correct t

Re: [Qemu-devel] [PATCH] qemu-img: fix formatting of error message

2016-04-06 Thread Eric Blake
On 04/06/2016 03:16 AM, Daniel P. Berrange wrote: > The error_reportf_err() will not automatically append a > ': ' before adding its suffix, so we must include that > in the message we pass it, otherwise we get a badly > formatted message lacking whitespace: > > qemu-img: Could not open > 'driver

Re: [Qemu-devel] Any progress with the Cortex-M4 emulation?

2016-04-06 Thread Peter Maydell
On 6 April 2016 at 13:52, Liviu Ionescu wrote: > >> On 06 Apr 2016, at 15:02, Peter Maydell wrote: >> >> On 5 April 2016 at 22:57, Liviu Ionescu wrote: >>> (I know that from time to time this question pops up, but) is >>> there anyone working or planning to work on the M4 emulation? >> >> Not th

  1   2   3   >