Thank you Sameeh & Itamar!
Peter, it looks like there are people who care about this device and
are willing to maintain it. Would it be enough to merge the patch?
CC Alexander who may be interested as well.
Thanks,
Ladi
On Mon, Apr 4, 2016 at 4:30 PM, Itamar Tal wrote:
> Hi all,
>
> That's the
On 04/05/2016 05:25 AM, David Gibson wrote:
> On Tue, Apr 05, 2016 at 12:19:50PM +1000, Benjamin Herrenschmidt wrote:
>> On Tue, 2016-04-05 at 12:17 +1000, David Gibson wrote:
>>> From: Cédric Le Goater
>>>
>>> From: Benjamin Herrenschmidt
>>>
>>> This patch fixes the current AIL implementation f
On 5 Apr 2016, at 00:08, Wouter Verhelst wrote:
>
> if bit 0 in the latter field is set, that means the block is allocated
> on the original device
> if bit 1 is set, that means the block is allocated on the first-level
> snapshot
> if bit 2 is set, that means the block is allocated on the se
On Mon, Apr 04, 2016 at 05:32:34PM -0600, Eric Blake wrote:
> On 04/04/2016 05:08 PM, Wouter Verhelst wrote:
> > On Mon, Apr 04, 2016 at 10:54:02PM +0300, Denis V. Lunev wrote:
> >> saying about dirtiness, we would soon come to the fact, that
> >> we can have several dirtiness states regarding diff
On 04/05/2016 02:35 PM, Changlong Xie wrote:
Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.
Signed-off-by: Changlong Xie
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index b7bf13e..898a35f 100
On Mo, 2016-04-04 at 16:21 +0100, Richard W.M. Jones wrote:
> On Mon, Apr 04, 2016 at 04:02:04PM +0100, Stefan Hajnoczi wrote:
> > (1) initrd loading is broken, kernel complains it finds only gibberish:
> >
> > [0.934582] Unpacking initramfs...
> > [1.166983] Initramfs unpacking fail
On 04/05/2016 02:09 PM, David Gibson wrote:
On Tue, Apr 05, 2016 at 12:12:01PM +1000, Paul Mackerras wrote:
On Mon, Apr 04, 2016 at 09:09:28PM +1000, Anton Blanchard wrote:
We don't support transactional memory in PR KVM, so don't tell
the OS that we do.
This assumes PR KVM won't ever support
On 5 April 2016 at 06:30, Emilio G. Cota wrote:
> I'm assuming windows compilers don't support this attribute.
Our windows compiler is gcc, so I would expect it to support
attribute aligned, and a quick grep through the sources shows
we already use it in several places.
> +#define QEMU_CACHELINE
On 5 April 2016 at 08:01, Ladi Prosek wrote:
> Thank you Sameeh & Itamar!
>
> Peter, it looks like there are people who care about this device and
> are willing to maintain it. Would it be enough to merge the patch?
I have no objections to the patch particularly, but I would
prefer it if you can
On Tue, Apr 05, 2016 at 06:38:36AM +0200, Kevin Wolf wrote:
> Am 01.04.2016 um 13:20 hat Richard W.M. Jones geschrieben:
> >
> > My patch, plus the configuration and comments from your patch,
> > combined. Plus I tested it with libguestfs boot-analysis and it works
> > and is still fast.
> >
> >
On 4 April 2016 at 18:45, Alex Bennée wrote:
> The following changes since commit e31f0451876aa7ada74d60304aa241506a383797:
>
> net: fix missing include of qapi/error.h in netmap.c (2016-04-04 15:01:14
> +0100)
>
> are available in the git repository at:
>
> https://github.com/stsquad/qemu.gi
Am 05.04.2016 um 10:04 hat Richard W.M. Jones geschrieben:
> On Tue, Apr 05, 2016 at 06:38:36AM +0200, Kevin Wolf wrote:
> > Am 01.04.2016 um 13:20 hat Richard W.M. Jones geschrieben:
> > >
> > > My patch, plus the configuration and comments from your patch,
> > > combined. Plus I tested it with
On Tue, Apr 05, 2016 at 10:05:17AM +0800, Jason Wang wrote:
>
>
> On 04/04/2016 03:25 AM, w...@redhat.com wrote:
> > From: Wei Xu
> >
> > A new feature bit 'VIRTIO_NET_F_GUEST_RSC' is introduced to support WHQL
> > Receive-Segment-Offload test, this feature will coalesce tcp packets in
> > IPv4/
On 4 April 2016 at 17:43, Peter Maydell wrote:
> ARM changes for rc1: a small set of bugfixes which didn't quite
> make rc0, mostly.
>
> thanks
> -- PMM
>
>
> The following changes since commit c40e13e106243a6798b7b02b4d7de5ff6c9be128:
>
> bsd-user: add necessary includes to fix warnings (2016-0
On 04/05/2016 11:43 AM, zhanghailiang wrote:
> After commit 338d3f, we support 'status' property for filter object.
> The segfault can be triggered by starting qemu with 'status=off' property
> for filter, when the s->incoming_queue is NULL, we reference it directly
> in qemu_net_queue_flush() wh
On Mon, Apr 04, 2016 at 07:14:48PM +0200, Laszlo Ersek wrote:
> On 04/04/16 17:57, Michael S. Tsirkin wrote:
>
> >> ... My question is, do we need the "opt/" prefix at all (for the future,
> >> i.e., the non-historical cases)?
> >> Looking at the last discussion, I
> >> believe we converged on:
>
Peter Maydell writes:
> On 4 April 2016 at 18:45, Alex Bennée wrote:
>> The following changes since commit e31f0451876aa7ada74d60304aa241506a383797:
>>
>> net: fix missing include of qapi/error.h in netmap.c (2016-04-04 15:01:14
>> +0100)
>>
>> are available in the git repository at:
>>
>>
Emilio G. Cota writes:
> This patchset is derived from my ongoing work on MTTCG, but does
> not depend on it and brings improvements that we can already
> benefit from. It applies cleanly on the current master and
> is checkpatch-clean.
>
> The key goal is to make the TB hash table faster, and w
On 03/29/2016 05:18 PM, Denis V. Lunev wrote:
On 03/29/2016 05:07 PM, Michael S. Tsirkin wrote:
On Tue, Mar 29, 2016 at 05:00:49PM +0300, Denis V. Lunev wrote:
From: Pavel Butsykin
If before loading snapshot we had set the timer of statistics, then
after
applying snapshot the expiry time wo
On 05/04/2016 07:30, Emilio G. Cota wrote:
> I'm assuming windows compilers don't support this attribute.
They actually do. :)
Paolo
> Signed-off-by: Emilio G. Cota
> ---
> include/qemu/compiler.h | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/qemu/compiler.h b
On 05/04/2016 07:30, Emilio G. Cota wrote:
> Since 5e5f07e08 "TCG: Move translation block variables
> to new context inside tcg_ctx: tb_ctx" on Feb 1 2013, compilation
> of usermode + TB_DEBUG_CHECK has been broken. Fix it.
>
> Signed-off-by: Emilio G. Cota
> ---
> translate-all.c | 3 ++-
> 1
On 05/04/2016 07:30, Emilio G. Cota wrote:
> Wrap pthread_spin on POSIX, or QemuMutex on Windows.
>
> AFAIK there are is no off-the-shelf spinlock implementation for
> Windows, so we'll just use QemuMutex.
It's much simpler to use a simple test-and-set spinlock.
GitHub is down, but this should
On Mon, Apr 04, 2016 at 10:39:10AM -0600, Eric Blake wrote:
> +To provide such class of information, the `BLOCK_STATUS` extension
> +adds a new `NBD_CMD_BLOCK_STATUS` command which returns a list of
> +ranges with their respective states. This extension is not available
> +unless the client also n
On Thu, Mar 17, 2016 at 09:33:40AM -0400, Gabriel L. Somlo wrote:
> On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote:
> > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote:
> > > Allowing for the future possibility of implementing AML-based
> > > (i.e., firmware-trigge
On 05/04/2016 07:30, Emilio G. Cota wrote:
> +static void qht_bucket_reset(struct qht_bucket *b)
> +{
> +qemu_spinlock_lock(&b->lock);
> +seqlock_write_begin(&b->sequence);
> +__qht_bucket_reset(b);
No __ names, please use names like qht_bucket_reset_locked.
"_locked" doesn't make mu
On 05/04/2016 07:30, Emilio G. Cota wrote:
> This patchset is derived from my ongoing work on MTTCG, but does
> not depend on it and brings improvements that we can already
> benefit from. It applies cleanly on the current master and
> is checkpatch-clean.
>
> The key goal is to make the TB hash
On Fri, 04/01 15:19, Paolo Bonzini wrote:
> In addition to handling IO in vcpu thread and in io thread, dataplane
> introduces yet another mode: handling it by aio.
>
> This reuses the same handler as previous modes, which triggers races as
> these were not designed to be reentrant.
>
> Use a sep
On Fri, 04/01 15:19, Paolo Bonzini wrote:
> This version fixes some commit messages, is based on qemu.git master
> and adds Cornelia's Reviewed-by tags. There are no code changes apart
> from context.
Apart from the nic-picks in patch 7, for patches 1-7:
Reviewed-by: Fam Zheng
>
> Michael S.
Dear all,
I'm so sorry for the late version 2 and appreciate the good comments came from
Cornelia and Michael.
Changes from v1:
- Drop the feature bit definaion for each algorithm, and using config space
instead [Cornelia]
- Add multiqueue support and add corresponding feature bit
- Update
The following changes since commit e31f0451876aa7ada74d60304aa241506a383797:
net: fix missing include of qapi/error.h in netmap.c (2016-04-04 15:01:14
+0100)
are available in the git repository at:
https://github.com/stsquad/qemu.git tags/travis-pull-05042016
for you to fetch changes up to
> > OK so this reminds me of the second problem. How to detect what
> > bioses are available, given a qemu binary. It would be nice if qemu
> > had an option like:
> >
> > qemu -bios \?
I didn't really think this one through. The extra time taken (in the
link loader) to run the above query c
On 04/05/16 10:35, Michael S. Tsirkin wrote:
> On Mon, Apr 04, 2016 at 07:14:48PM +0200, Laszlo Ersek wrote:
>> On 04/04/16 17:57, Michael S. Tsirkin wrote:
>>
... My question is, do we need the "opt/" prefix at all (for the future,
i.e., the non-historical cases)?
Looking at the las
The __all__ list contained a typo for as long as the iotests module
existed. That typo prevented "from iotests import *" (which is the
only case where iotests.__all__ is used at all) from ever working.
The names used by iotests are highly prone to name collisions, so
importing them all uncondition
Placing files with predictable or even hard-coded names in /tmp is a
security risk and can prevent or disturb operation on a multi-user
machine. Place them inside the "scratch" directory instead, as we
already do for most other test-related files.
Signed-off-by: Sascha Silbe
Reviewed-by: Bo Tu
-
Commit 61de4c68 [block: Remove BDRV_O_CACHE_WB] updated the reference
output for PCs, but neglected to do the same for the generic reference
output file. Fix 051 on all non-PC architectures by applying the same
change to the generic output file.
Fixes: 61de4c68 ("block: Remove BDRV_O_CACHE_WB")
Si
qemu-iotests test case 148 already had some code for skipping the test
if quorum support is missing, but it didn't work in all
cases. TestQuorumEvents.setUp() gets run before the actual test class
(which contains the skipping code) and tries to start qemu with a drive
using the quorum driver. For s
On error, VM.launch() cleaned up the monitor unix socket, but left the
qtest unix socket behind. This caused the remaining sub-tests to fail
with EADDRINUSE:
+==
+ERROR: testQuorum (__main__.TestFifoQuorumEvents)
+
None of the other test cases explicitly enable KVM and there's no
obvious reason for 068 to require it. Drop this so all test cases can be
executed in environments where KVM is not available (e.g. because the
user doesn't have sufficient permissions to access /dev/kvm).
Signed-off-by: Sascha Silbe
With these fixes, qemu-iotests complete successfully on my test
systems (s390x, x86_64) when used with QCOW2 or raw image formats.
These are purely bug fixes for tests and most are trivial, so they
should be safe even for hard freeze.
Sascha Silbe (7):
qemu-iotests: check: don't place files wi
Am 05.04.2016 um 11:19 hat Richard W.M. Jones geschrieben:
> > > OK so this reminds me of the second problem. How to detect what
> > > bioses are available, given a qemu binary. It would be nice if qemu
> > > had an option like:
> > >
> > > qemu -bios \?
>
> I didn't really think this one thr
Hi,
On Monday 04 April 2016 10:39:10 Eric Blake wrote:
> With the availability of sparse storage formats, it is often needed
> to query status of a particular range and read only those blocks of
> data that are actually present on the block device.
>
> To provide such information, the patch adds
On systems with fast IO, qemu-io may write more than 1 MiB before
receiving the block-job-cancel command, causing the test case to fail.
141 is inherently racy, but we can at least reduce the likelihood of the
job completing before the cancel command arrives by bumping the size of
the data getting
On Mon, 2016-04-04 at 11:11:12 UTC, Paul Mackerras via Linuxppc-dev wrote:
> In check_cpu_pa_features() we check a number of bits in the
Shouldn't we be clearing the user feature there too?
The ibm_pa_features array and the logic in scan_features() knows to flip the
cpu_user_features bits, it was
As agreed with Stefan, I'm listing myself a co-maintainer of block I/O
path and assist with the maintainership.
Signed-off-by: Fam Zheng
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9277fbf..d261412 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hi,
On Monday 04 April 2016 16:15:43 Eric Blake wrote:
> qemu already has an existing server implementation option that will
> explicitly search the payload of NBD_CMD_WRITE for large blocks of
> zeroes, and punch holes in the underlying file. For old clients
> that don't know how to use the new
On 04/04/2016 17:24, Daniel P. Berrange wrote:
> The pbkdf test is being built based on a check for CONFIG_NETTLE.
> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
> instead checking CONFIG_NETTLE_KDF
>
> Reported-by: "Dr. David Alan Gilbert"
> Reported-by: Bruce Rogers
> Signed-
On Tue, Apr 05, 2016 at 09:27:39AM +0800, Fam Zheng wrote:
> On Mon, 04/04 12:57, Stefan Hajnoczi wrote:
> > On Fri, Apr 01, 2016 at 09:57:38PM +0800, Fam Zheng wrote:
> > > +BdrvCoDrainData data;
> > > +
> > > +assert(qemu_in_coroutine());
> > > +data = (BdrvCoDrainData) {
> > > +
From: Marc-André Lureau
Since f1060c55bf1377b4, the pointer is directly passed to
qemu_ram_free(). However, on initialization failure, it may be called
with a NULL pointer. Return immediately in this case.
This fixes a SEGV when memory initialization failed, for example
permission denied on open
KVM does not let you read or write this MSR if the corresponding CPUID
bit is not set. This in turn causes MSRs that come after MSR_TSC_AUX
to be ignored by KVM_SET_MSRS.
One visible symptom is that s3.flat from kvm-unit-tests fails with
CPUs that do not have RDTSCP, because the SMBASE is not res
Signed-off-by: Paolo Bonzini
---
include/standard-headers/asm-x86/hyperv.h | 4 +-
include/standard-headers/linux/input.h | 1 +
include/standard-headers/linux/types.h | 5 +-
include/standard-headers/linux/virtio_balloon.h | 2 +-
include/standard-headers/linux/virtio
From: Eric Blake
The NBD protocol does not clearly document what will happen
if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH.
Historically, both the qemu and upstream NBD servers silently
ignored that flag, but that feels a bit risky. Meanwhile, the
qemu NBD client unconditionally sends the
The following changes since commit 92741fc4b6cbf7a8f6cce45e9a468d5637a4ff6a:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
staging (2016-03-31 11:52:44 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to
From: Andrey Smetanin
Add Hyper-V VMBus hypercalls blank handlers which
just returns error code - HV_STATUS_INVALID_HYPERCALL_CODE.
This is required when the synthetic interrupt controller is
active.
Fixes: 50efe82c3c27195162dd8df273eadd77d8aecad3
Signed-off-by: Andrey Smetanin
Reviewed-by: Rom
This would have caught the bug in the previous patch.
Signed-off-by: Paolo Bonzini
---
target-i386/kvm.c | 34 ++
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 19e2d94..799fdfa 100644
--- a/target-i386/k
From: Alex Bennée
To be safely portable no atomic access should be trying to do more than
the natural word width of the host. The most common abuse is trying to
atomically access 64 bit values on a 32 bit host.
This patch adds some QEMU_BUILD_BUG_ON to the __atomic instrinsic paths
to create a b
From: "Daniel P. Berrange"
Only some callers of tcp_chr_new_client are putting the
socket client into non-blocking mode. Move the call to
qio_channel_set_blocking() into the tcp_chr_new_client
method to guarantee that all code paths set non-blocking
mode
Reported-by: Andrew Baumann
Reported-by:
From: Cédric Le Goater
In some occasions, a patch [1] can start with a hunk containing a
simple type cast. At the time annotate_values() is run, the type is
unknown and the cast type is misinterpreted as a identifier, resulting
in an error if it is followed with a negative value:
ERROR:
From: Alex Bennée
As vm_clock_warp_start is a 64 bit value this causes problems for the
compiler trying to come up with a suitable atomic operation on 32 bit
hosts. Because the variable is protected by vm_clock_seqlock, we check its
value inside a seqlock critical section.
Signed-off-by: Alex Be
From: "Daniel P. Berrange"
Some of the chardev I/O paths really want to write the
complete data buffer even though the channel is in
non-blocking mode. To achieve this they look for EAGAIN
and g_usleep() for 100ms. Unfortunately the code is set
to check errno == EAGAIN a second time, after the g_
From: "Daniel P. Berrange"
The FreeBSD header files define the AI_V4MAPPED but its
implementation of getaddrinfo() always returns an error
when that flag is set. eg
address resolution failed for localhost:9000: Invalid value for ai_flags
There are also reports of the same problem on OS-X 10.6
From: Eric Blake
The client sends messages to the server, not itself.
Signed-off-by: Eric Blake
Message-Id: <1459459222-8637-3-git-send-email-ebl...@redhat.com>
Signed-off-by: Paolo Bonzini
---
nbd/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd/client.c b/nbd
From: Cao jin
There is no memory_region_io(). And remove a stray '-'.
Signed-off-by: Cao jin
Message-Id: <1459507677-16662-1-git-send-email-caoj.f...@cn.fujitsu.com>
Signed-off-by: Paolo Bonzini
---
docs/memory.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/m
From: "Daniel P. Berrange"
The netmap.c file fails to build on FreeBSD with
net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno'
is invalid in C99 [-Wimplicit-function-declaration]
error_setg_errno(errp, errno, "Failed to nm_open() %s",
^
net/netmap.c:432:9:
The following changes since commit 1dbc7cc9b91ba229ec958418bef483364f06fe72:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-20160405' into
staging (2016-04-05 09:32:35 +0100)
are available in the git repository at:
git://github.com/berrange/qemu tags/pull-qcrypto-
On 04/05/2016 05:50 PM, Paolo Bonzini wrote:
From: Cao jin
There is no memory_region_io(). And remove a stray '-'.
Signed-off-by: Cao jin
Message-Id: <1459507677-16662-1-git-send-email-caoj.f...@cn.fujitsu.com>
Signed-off-by: Paolo Bonzini
---
docs/memory.txt | 4 ++--
1 file changed, 2
The pbkdf test is being built based on a check for CONFIG_NETTLE.
As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
instead checking CONFIG_NETTLE_KDF
Reported-by: "Dr. David Alan Gilbert"
Tested-by: Bruce Rogers
Tested-by: Ed Maste
Signed-off-by: Daniel P. Berrange
---
tests/Makef
The docs for the secret object type specified the wrong number
of bytes for the AES initialization vector.
Signed-off-by: Daniel P. Berrange
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 789d9f6..587de8f 100644
---
On Tue, 2016-04-05 at 19:35 +1000, Michael Ellerman wrote:
> Shouldn't we be clearing the user feature there too?
>
> The ibm_pa_features array and the logic in scan_features() knows to
> flip the
> cpu_user_features bits, it was just never updated to handle
> cpu_user_features2.
>
> So it seems
On 5 April 2016 at 10:40, Paolo Bonzini wrote:
>
>
> On 04/04/2016 17:24, Daniel P. Berrange wrote:
>> The pbkdf test is being built based on a check for CONFIG_NETTLE.
>> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
>> instead checking CONFIG_NETTLE_KDF
>>
>> Reported-by: "Dr. Dav
available in the git repository at:
>
> git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160405
>
> for you to fetch changes up to efdaf797de009e194db89dcd8b171fa35181a6f2:
>
> vl: Move cpu_synchronize_all_states() into
On 5 April 2016 at 10:17, Alex Bennée wrote:
> The following changes since commit e31f0451876aa7ada74d60304aa241506a383797:
>
> net: fix missing include of qapi/error.h in netmap.c (2016-04-04 15:01:14
> +0100)
>
> are available in the git repository at:
>
> https://github.com/stsquad/qemu.gi
On 3/31/2016 10:09 PM, Dr. David Alan Gilbert wrote:
> * Jitendra Kolhe (jitendra.ko...@hpe.com) wrote:
>> While measuring live migration performance for qemu/kvm guest, it
>> was observed that the qemu doesn’t maintain any intelligence for the
>> guest ram pages which are released by the guest bal
On 04/01/2016 03:19 PM, Paolo Bonzini wrote:
> This version fixes some commit messages, is based on qemu.git master
> and adds Cornelia's Reviewed-by tags. There are no code changes apart
> from context.
>
> Michael S. Tsirkin (2):
> virtio: add aio handler
> virtio-blk: use aio handler for d
On 05/04/2016 11:59, Cao jin wrote:
> Seems the patch ignore the slight modification on that memory figure,
> So commit message isn`t consistent with the patch content. And actually
> I missed to remove a space between 7000 and 8000, since I removed a "-"
Oops, I forgot to adjust the commit mess
On Fri, Apr 01, 2016 at 03:19:46PM +0200, Paolo Bonzini wrote:
> There is no need to run the handler one last time; the device is
> being reset and it is okay to drop requests that are pending in
> the virtqueue. Even in the case of migration, the requests would
> be processed when ioeventfd is re
On 05/04/2016 12:38, Michael S. Tsirkin wrote:
>> > There is no need to run the handler one last time; the device is
>> > being reset and it is okay to drop requests that are pending in
>> > the virtqueue. Even in the case of migration, the requests would
>> > be processed when ioeventfd is re-e
On Thu, Mar 31, 2016 at 09:02:01AM +0300, Ilya Maximets wrote:
> On 30.03.2016 20:01, Michael S. Tsirkin wrote:
> > On Wed, Mar 30, 2016 at 06:14:05PM +0300, Ilya Maximets wrote:
> >> Currently QEMU always crashes in following scenario (assume that
> >> vhost-user application is Open vSwitch with '
* Paolo Bonzini (pbonz...@redhat.com) wrote:
>
>
> On 01/04/2016 19:58, Dr. David Alan Gilbert wrote:
> > In the continuing journeys of trying to migrate a q35 guest with ovmf,
> > I've just hit this assert:
> >
> > qemu-system-x86_64: /root/git/qemu/block/io.c:1297: bdrv_co_do_pwritev:
> > Ass
On 5 April 2016 at 10:50, Paolo Bonzini wrote:
> The following changes since commit 92741fc4b6cbf7a8f6cce45e9a468d5637a4ff6a:
>
> Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
> staging (2016-03-31 11:52:44 +0100)
>
> are available in the git repository at:
>
> git
On 04/05/16 12:48, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonz...@redhat.com) wrote:
>>
>>
>> On 01/04/2016 19:58, Dr. David Alan Gilbert wrote:
>>> In the continuing journeys of trying to migrate a q35 guest with ovmf,
>>> I've just hit this assert:
>>>
>>> qemu-system-x86_64: /root/git
On 05/04/2016 12:42, Paolo Bonzini wrote:
> I think you're right about this.
>
> Dataplane has an event_notifier_set; we should move it to
> virtio_queue_aio_set_host_notifier_handler and add it to
> virtio_queue_set_host_notifier_handler. I'll send v3 today.
As discussed on IRC, even that wou
On Tue, 04/05 10:39, Stefan Hajnoczi wrote:
> > > block/mirror.c should call bdrv_co_drain() explicitly and bdrv_drain()
> > > should assert(!qemu_in_coroutine()).
> > >
> > > The reason why existing bdrv_read() and friends detect coroutine context
> > > at runtime is because it is meant for legac
See patch 1 for the bug analysis.
v3: Make bdrv_co_drain a public function and use it directly in block/mirror.c.
[Stefan]
Fam Zheng (2):
block: Fix bdrv_drain in coroutine
mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)
block/io.c| 45 +++
Using the nested aio_poll() in coroutine is a bad idea. This patch
replaces the aio_poll loop in bdrv_drain with a BH, if called in
coroutine.
For example, the bdrv_drain() in mirror.c can hang when a guest issued
request is pending on it in qemu_co_mutex_lock().
Mirror coroutine in this case has
Suggested-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index f64db1a..c2cfc1a 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -650,7 +650,7 @@ static void coroutine_fn mirro
v4 changelog:
1. split into 5 patches, according to comments (Marcel)
2. fix to other minor comments (Marcel)
3. most devices have msi/msix(except vmxnet3 & pvscsi) property as a switch,
if it has and is switched on, then msi_init() failure should results in
return directly. So in this versio
All the other devices` .realize function name are xxx_realize, except this one
Signed-off-by: Cao jin
CC: Paolo Bonzini
---
hw/scsi/mptsas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
index 499c146..1c18c84 100644
--- a/hw/scsi/mp
This patch comes along with patch "Add param Error ** for msi_init".
Add more newlines to make the code block well separated; add more
comments for msi_init; and fix a indentation.
Signed-off-by: Cao jin
CC: Dmitry Fleytman
CC: Jason Wang
CC: Michael S. Tsirkin
---
hw/net/vmxnet3.c
Nobody use its return value, so change the type to void
Signed-off-by: Cao jin
CC: Paolo Bonzini
CC: Dmitry Fleytman
---
hw/scsi/vmw_pvscsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
index 9abc086..4ce3581 100644
--- a/h
Add param Error **errp, and change pci_add_capability() to
pci_add_capability2(), because pci_add_capability() report error, and
msi_init() is widely used in realize(), so it is not suitable for realize()
Also fix all the callers who should deal with the msi_init() failure
but actually not.
Signe
* Laszlo Ersek (ler...@redhat.com) wrote:
> On 04/05/16 12:48, Dr. David Alan Gilbert wrote:
> > * Paolo Bonzini (pbonz...@redhat.com) wrote:
> >>
> >>
> >> On 01/04/2016 19:58, Dr. David Alan Gilbert wrote:
> >>> In the continuing journeys of trying to migrate a q35 guest with ovmf,
> >>> I've jus
msi_init returns non-zero value on both failure and success
Signed-off-by: Cao jin
CC: Hannes Reinecke
CC: Paolo Bonzini
---
hw/scsi/megasas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index a63a581..56fb645 100644
--- a/hw/scsi/m
On Tue, Apr 05, 2016 at 07:26:37PM +0800, Cao jin wrote:
> v4 changelog:
> 1. split into 5 patches, according to comments (Marcel)
> 2. fix to other minor comments (Marcel)
> 3. most devices have msi/msix(except vmxnet3 & pvscsi) property as a switch,
>if it has and is switched on, then msi_ini
On 04/05/16 13:25, Dr. David Alan Gilbert wrote:
> * Laszlo Ersek (ler...@redhat.com) wrote:
>> On 04/05/16 12:48, Dr. David Alan Gilbert wrote:
>>> * Paolo Bonzini (pbonz...@redhat.com) wrote:
On 01/04/2016 19:58, Dr. David Alan Gilbert wrote:
> In the continuing journeys of try
From: Chen Fan
the function is used to get affected devices by bus reset.
so here extract it, and can used for aer soon.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 66 +++
1 file changed, 48 insertions(+), 18 deletions(-)
diff --git a/h
From: Chen Fan
v5-v6:
1. register resume handler both qemu and kernel to ensure the
reset in order.
2. fix the patches 6/12, 7/12 as Alex and MST sugguestion.
v4-v5:
1. add back the common function 0 hotplug code in pci core.
2. fix a sporadic device stuck on D3 problem when do
From: Chen Fan
Calling pcie_aer_init to initilize aer related registers for
vfio device, then reload physical related registers to expose
device capability.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 85 ---
hw/vfio/pci.h | 3 +++
2 fil
From: Chen Fan
PCI hotplug requires that function 0 is added last to close the
slot. Since vfio supporting AER, we require that the VM bus
contains the same set of devices as the host bus to support AER,
we can perform an AER validation test whenever a function 0 in
the VM is hot-added.
Signed-
From: Chen Fan
For vfio pcie device, we could expose the extended capability on
PCIE bus. due to add a new pcie capability at the tail of the chain,
in order to avoid config space overwritten, we introduce a copy config
for parsing extended caps. and rebuild the pcie extended config space.
Signe
From: Chen Fan
squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 75 +++
1 file changed, 44 insertions(+), 31 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
ind
1 - 100 of 295 matches
Mail list logo
