On 04/04/2016 06:49, David Gibson wrote:
> There are currently 3 calls to qemu_system_reset() in vl.c. Two of them
> are immediately preceded by a cpu_synchronize_all_states9) and the
> remaining one should be.
>
> The one which doesn't is the very first reset called directly from main().
> Wit
On 01/04/2016 18:08, Eric Blake wrote:
> The NBD protocol does not clearly document what will happen
> if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH.
> Historically, both the qemu and upstream NBD servers silently
> ignored that flag, but that feels a bit risky. Meanwhile, the
> qemu NBD c
On Mon, Apr 04, 2016 at 09:31:16AM +0200, Paolo Bonzini wrote:
>
>
> On 04/04/2016 06:49, David Gibson wrote:
> > There are currently 3 calls to qemu_system_reset() in vl.c. Two of them
> > are immediately preceded by a cpu_synchronize_all_states9) and the
> > remaining one should be.
> >
> > T
On 03/04/2016 15:49, Michael S. Tsirkin wrote:
> I agree but I think we need a better name for this function.
> qemu_ram_offset_to_ptr?
What about qemu_map_ram_ptr?
Paolo
> Will also serve to make sure backporting patches across this
> API change does not cause issues.
On Sun, 3 Apr 2016 23:13:28 +0200
Paolo Bonzini wrote:
> On 03/04/2016 21:59, Christian Borntraeger wrote:
> > Thread 1 (Thread 0x3ffad25bb90 (LWP 41685)):
> > ---Type to continue, or q to quit---
> > #0 0x03ffab5be2c0 in raise () at /lib64/libc.so.6
> > #1 0x03ffab5bfc26 in abort ()
On 01/04/2016 22:35, Pranith Kumar wrote:; barrier(); })
> I could not really understand why we need to wrap the fence with
> barrier()'s. There are three parts to my confusion. Let me ask one after the
> other.
>
> On x86, __atomic_thread_fence(__ATOMIC_SEQ_CST) will generate an mfence
> instru
On 04/04/2016 10:10, Cornelia Huck wrote:
> > This will be fixed by Cornelia's rework, and is an example of why I
> > think patch 1/9 is a good idea (IOW, assign=false is harmful).
>
> So what do we want to do for 2.6? The aio handler rework (without the
> cleanup) is needed. Do we want to inclu
On 04/04/2016 06:49, David Gibson wrote:
> There are currently 3 calls to qemu_system_reset() in vl.c. Two of them
> are immediately preceded by a cpu_synchronize_all_states9) and the
> remaining one should be.
>
> The one which doesn't is the very first reset called directly from main().
> Wit
On Mon, 4 Apr 2016 10:19:42 +0200
Paolo Bonzini wrote:
> On 04/04/2016 10:10, Cornelia Huck wrote:
> > > This will be fixed by Cornelia's rework, and is an example of why I
> > > think patch 1/9 is a good idea (IOW, assign=false is harmful).
> >
> > So what do we want to do for 2.6? The aio hand
The cacheflush system call (found on MIPS and ARM) has been included in
the libseccomp header since 2.2.0, so include include it back to that
version. Previously it was only enabled since 2.2.3 since that is when
it was enabled properly for ARM.
This will allow seccomp support to be enabled for MI
These patches enable seccomp sandboxing on MIPS.
libseccomp has supported MIPS since 2.2.0, but cacheflush isn't included
in the whitelist until libseccomp 2.2.3 since thats when it was enabled
for ARM. The first patch fixes that so that it will work with MIPS right
back to 2.2.0.
Finally the sec
Enable seccomp on MIPS since libseccomp version 2.2.0 when MIPS support
was first added.
Signed-off-by: James Hogan
Cc: Eduardo Otubo
Cc: Aurelien Jarno
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index 5db29f0245ae..f1c307bfc69c 100755
--- a/conf
On 04/04/2016 09:54, David Gibson wrote:
> > Acked-by: Paolo Bonzini
>
> Paolo / Peter, should I send this in a pull request for my tree, or
> should it go through someone else's tree?
Go ahead and send it.
Paolo
On 01/04/2016 17:03, Alex Bennée wrote:
>
>> > To be safely portable no atomic access should be trying to do more than
>> > the natural word width of the host. The most common abuse is trying to
>> > atomically access 64 bit values on a 32 bit host.
>> >
>> > This patch adds some QEMU_BUILD_BUG_
On Mon, Apr 04, 2016 at 10:03:12AM +0200, Paolo Bonzini wrote:
>
>
> On 03/04/2016 15:49, Michael S. Tsirkin wrote:
> > I agree but I think we need a better name for this function.
> > qemu_ram_offset_to_ptr?
>
> What about qemu_map_ram_ptr?
>
> Paolo
OK but this seems to imply there's also an
On Mon, Apr 04, 2016 at 10:25:34AM +0200, Cornelia Huck wrote:
> On Mon, 4 Apr 2016 10:19:42 +0200
> Paolo Bonzini wrote:
>
> > On 04/04/2016 10:10, Cornelia Huck wrote:
> > > > This will be fixed by Cornelia's rework, and is an example of why I
> > > > think patch 1/9 is a good idea (IOW, assign
Hi,
While reviewing the recent TB patching cleanup patches I wondered if
there is a cleaner way of handling TB invalidation. Currently we have a
single code generation buffer which slowly fills up with TBs as we
execute code. These TBs are chained together if they exist in the same
physical page (
On Sun, Apr 03, 2016 at 09:37:56PM -0400, Stefan Berger wrote:
> Get the interrupt the TPM device model is using. Do not activate
> the interrupt in the ACPI description yet since the current
> default value clashes with other devices.
>
> Signed-off-by: Stefan Berger
Is this doing anything at a
On 04/04/2016 10:54, Alex Bennée wrote:
> Thoughts, objections? Discuss ;-)
I think we're putting a lot of carts before the horse.
We have like half a dozen subprojects and none are moving because
there's no clear idea of what to do next and why. The first thing to do
is to focus on fixing and
On 04/04/2016 10:38, Michael S. Tsirkin wrote:
> > > I agree but I think we need a better name for this function.
> > > qemu_ram_offset_to_ptr?
> >
> > What about qemu_map_ram_ptr?
> >
> > Paolo
>
> OK but this seems to imply there's also an unmap operation?
Actually there is one, even though
On Sun, Apr 03, 2016 at 09:37:55PM -0400, Stefan Berger wrote:
> This patch addresses BZ 1281413.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1281413
>
> Fix the APCI description to make it work on operating systems that are
> more strict about the contents of the TPM's ACPI description than
On Sun, Apr 03, 2016 at 09:37:54PM -0400, Stefan Berger wrote:
> This series of patches fixes some problems with the TPM's ACPI
> description.
Could you pls describe how does this interact with Igor's patch?
> Stefan Berger (2):
> acpi: tpm: Fix TPM ACPI description (BZ 1281413)
> acpi: tpm:
On 30/03/16 15:10, Juergen Gross wrote:
> Add a Xenstore directory for each supported pv backend. This will allow
> Xen tools to decide which backend type to use in case there are
> multiple possibilities.
>
> The information is added under
> /local/domain//device-model//backends
> before the "run
On 04/04/16 11:18, David Vrabel wrote:
> On 30/03/16 15:10, Juergen Gross wrote:
>> Add a Xenstore directory for each supported pv backend. This will allow
>> Xen tools to decide which backend type to use in case there are
>> multiple possibilities.
>>
>> The information is added under
>> /local/do
This allows dynamic allocation for migrating arrays.
Already existing VMSTATE_VARRAY_UINT32 requires an array to be
pre-allocated, however there are cases when the size is not known in
advance and there is no real need to enforce it.
This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_
Since a788f227 "memory: Allow replay of IOMMU mapping notifications"
when new VFIO listener is added, all existing IOMMU mappings are
replayed. However there is a problem that the base address of
an IOMMU memory region (IOMMU MR) is ignored which is not a problem
for the existing user (which is pse
At the moment IOMMU MR only translate to the system memory.
However if some new code changes this, we will need clear indication why
it is not working so here is the check.
Signed-off-by: Alexey Kardashevskiy
Reviewed-by: David Gibson
---
Changes:
v15:
* added some spaces
v14:
* new to the seri
There are going to be multiple IOMMUs per a container. This moves
the single host IOMMU parameter set to a list of VFIOHostIOMMU.
This should cause no behavioral change and will be used later by
the SPAPR TCE IOMMU v2 which will also add a vfio_host_iommu_del() helper.
Signed-off-by: Alexey Karda
LoPAPR dictates that during system reset all DMA windows must be removed
and the default DMA32 window must be created so does the patch.
At the moment there is just one window supported so no change in
behaviour is expected.
Signed-off-by: Alexey Kardashevskiy
Reviewed-by: David Gibson
---
hw/
This makes use of the new "memory registering" feature. The idea is
to provide the userspace ability to notify the host kernel about pages
which are going to be used for DMA. Having this information, the host
kernel can pin them all once per user process, do locked pages
accounting (once) and not s
We are going to have 2 DMA windows which LIOBNs are calculated from
the PHB index and the window number using the SPAPR_PCI_LIOBN macro
so there is no actual use for dma_liobn.
This replaces dma_liobn with SPAPR_PCI_LIOBN. This marks it as unused
in the migration stream. This renames dma_liobn to
At the moment presence of vfio-pci devices on a bus affect the way
the guest view table is allocated. If there is no vfio-pci on a PHB
and the host kernel supports KVM acceleration of H_PUT_TCE, a table
is allocated in KVM. However, if there is vfio-pci and we do yet not
KVM acceleration for these,
6a81dd17 "spapr_iommu: Rename vfio_accel parameter" renamed vfio_accel
flag everywhere but one spot was missed.
Signed-off-by: Alexey Kardashevskiy
Reviewed-by: David Gibson
---
target-ppc/kvm_ppc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/kvm_ppc.h b/targe
This will be later used by the "ibm,reset-pe-dma-window" RTAS handler
which resets the DMA configuration to the defaults.
Signed-off-by: Alexey Kardashevskiy
Reviewed-by: David Gibson
---
hw/ppc/spapr_pci.c | 10 --
include/hw/pci-host/spapr.h | 2 ++
2 files changed, 10 inser
Currently TCE tables are created once at start and their sizes never
change. We are going to change that by introducing a Dynamic DMA windows
support where DMA configuration may change during the guest execution.
This changes spapr_tce_new_table() to create an empty zero-size IOMMU
memory region (
Every IOMMU has some granularity which MemoryRegionIOMMUOps::translate
uses when translating, however this information is not available outside
the translate context for various checks.
This adds a get_page_sizes callback to MemoryRegionIOMMUOps and
a wrapper for it so IOMMU users (such as VFIO) c
New VFIO_SPAPR_TCE_v2_IOMMU type supports dynamic DMA window management.
This adds ability to VFIO common code to dynamically allocate/remove
DMA windows in the host kernel when new VFIO container is added/removed.
This adds VFIO_IOMMU_SPAPR_TCE_CREATE ioctl to vfio_listener_region_add
and adds ju
The source guest could have reallocated the default TCE table and
migrate bigger/smaller table. This adds reallocation in post_load()
if the default table size is different on source and destination.
This adds @bus_offset, @page_shift, @enabled to the migration stream.
These cannot change without
The sPAPR TCE tables manage 2 copies when VFIO is using an IOMMU -
a guest view of the table and a hardware TCE table. If there is no VFIO
presense in the address space, then just the guest view is used, if
this is the case, it is allocated in the KVM. However since there is no
support yet for VFIO
Each Partitionable Endpoint (IOMMU group) has an address range on a PCI bus
where devices are allowed to do DMA. These ranges are called DMA windows.
By default, there is a single DMA window, 1 or 2GB big, mapped at zero
on a PCI bus.
PAPR defines a DDW RTAS API which allows pseries guests
queryin
We are going to have multiple DMA windows at different offsets on
a PCI bus. For the sake of migration, we will have as many TCE table
objects pre-created as many windows supported.
So we need a way to map windows dynamically onto a PCI bus
when migration of a table is completed but at this stage a
This adds support for Dynamic DMA Windows (DDW) option defined by
the SPAPR specification which allows to have additional DMA window(s)
The "ddw" property is enabled by default on a PHB but for compatibility
the pseries-2.5 machine and older disable it. This also creates a single
DMA window for th
On 04/04/2016 05:01 AM, Michael S. Tsirkin wrote:
On Sun, Apr 03, 2016 at 09:37:56PM -0400, Stefan Berger wrote:
Get the interrupt the TPM device model is using. Do not activate
the interrupt in the ACPI description yet since the current
default value clashes with other devices.
Signed-off-by:
On Mon, Apr 04, 2016 at 06:10:38AM -0400, Stefan Berger wrote:
> On 04/04/2016 05:01 AM, Michael S. Tsirkin wrote:
> >On Sun, Apr 03, 2016 at 09:37:56PM -0400, Stefan Berger wrote:
> >>Get the interrupt the TPM device model is using. Do not activate
> >>the interrupt in the ACPI description yet sin
The last 8 bytes of the receive buffer list page (that has been supplied
by the guest with the H_REGISTER_LOGICAL_LAN call) contain a counter
for frames that have been dropped because there was no suitable receive
buffer available. This patch introduces code to use this field to
provide the informa
On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote:
On Sun, Apr 03, 2016 at 09:37:55PM -0400, Stefan Berger wrote:
This patch addresses BZ 1281413.
https://bugzilla.redhat.com/show_bug.cgi?id=1281413
Fix the APCI description to make it work on operating systems that are
more strict about the con
Fix off-by-one error in ITC Tag read.
Remove the switch as we just want to check if index is in valid range
rather than test against list of values.
Signed-off-by: Leon Alrae
---
hw/misc/mips_itu.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/misc/mips_itu.
On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote:
On Sun, Apr 03, 2016 at 09:37:54PM -0400, Stefan Berger wrote:
This series of patches fixes some problems with the TPM's ACPI
description.
Could you pls describe how does this interact with Igor's patch?
Follow https://bugzilla.redhat.com/atta
On 02.04.2016 00:01, John Snow wrote:
On 04/01/2016 10:32 AM, Denis V. Lunev wrote:
From: Pavel Butsykin
ide_atapi_dma_restart() used to just complete the DMA with an error,
under the assumption that there isn't enough information to restart it.
However, as the contents of the ->io_buffer i
On 02.04.2016 01:34, John Snow wrote:
On 04/01/2016 10:32 AM, Denis V. Lunev wrote:
From: Pavel Butsykin
Restart of ATAPI DMA used to be unreachable, because the request to do
so wasn't indicated in bus->error_status due to the lack of spare bits, and
ide_restart_bh() would return early doin
On 04/04/16 12:01, Paolo Bonzini wrote:
> On 04/04/2016 10:54, Alex Bennée wrote:
>> Thoughts, objections? Discuss ;-)
> I think we're putting a lot of carts before the horse.
>
> We have like half a dozen subprojects and none are moving because
> there's no clear idea of what to do next and why.
On 01/04/2016 19:58, Dr. David Alan Gilbert wrote:
> In the continuing journeys of trying to migrate a q35 guest with ovmf,
> I've just hit this assert:
>
> qemu-system-x86_64: /root/git/qemu/block/io.c:1297: bdrv_co_do_pwritev:
> Assertion `!(bs->open_flags & 0x0800)' failed.
>
> This is just
Hi Alexey,
> > I can't get an Ubuntu Wily guest to boot on an Ubuntu Wily host in
> > PR KVM mode. The kernel in both cases is 4.2. To reproduce:
> >
> > wget -N
> > https://cloud-images.ubuntu.com/wily/current/wily-server-cloudimg-ppc64el-disk1.img
> >
> > qemu-system-ppc64 -cpu POWER8 -enable-k
This requires that all -fw_cfg command line users use names of the form
opt/RQFN/: such names are compatible with QEMU 2.4 and 2.5 as well as
future QEMU versions.
As ability to insert fw_cfg entries in QEMU root is useful for
firmware development, add a special prefix: unsupported/root/ that
allo
Am 31.03.2016 um 15:07 hat Paolo Bonzini geschrieben:
> Failing on -drive/drive_add created BlockBackends was a
> requirement for x-blockdev-del, but it sneaked through
> the patch review. Let's fix it now.
>
> Example:
>
> $ x86_64-softmmu/qemu-system-x86_64 -drive if=none,file=null-co://,id=nu
On 03/31/2016 05:07 PM, Igor Mammedov wrote:
On Thu, 31 Mar 2016 00:03:57 -0400
Stefan Berger wrote:
On 03/30/2016 09:33 AM, Igor Mammedov wrote:
On Mon, 21 Mar 2016 10:21:11 -0400
Stefan Berger wrote:
This patch addresses BZ 1281413.
Fix the APCI description to make it work on Windows ag
From: Sergey Fedorov
assert() always evaluates its argument so there's no need to #ifdef the
definitions which is only used for assert(). Actually, doing so
generates a compilation warning which is treated as an error in QEMU
build by default. Let compiler sort out and eliminate unnecessary
local
On 17 February 2016 at 04:39, Prem Mallappa wrote:
> Hi Peter,
>
> I have access till
> "PRD03-GENC-010952 Version 11.0" updated 18/04/15.
>
> infocenter.arm.com has only SMMUv2 made public
>
> Please let me know if there is a new version available
> - to public.
> - through channels, I have to
We don't support transactional memory in PR KVM, so don't tell
the OS that we do.
Signed-off-by: Anton Blanchard
---
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e7be21e..538bd87 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -696,6 +696,12 @@ static void spapr_populate_cpu_dt(CPUStat
In check_cpu_pa_features() we check a number of bits in the
ibm,pa-features array and set and clear CPU features based on what
we find. One of these bits is CPU_FTR_TM, the transactional memory
feature bit.
If this does disable TM at runtime, then we need to tell userspace
about it by clearing the
> Am 04.04.2016 um 13:09 schrieb Anton Blanchard :
>
> We don't support transactional memory in PR KVM, so don't tell
> the OS that we do.
>
> Signed-off-by: Anton Blanchard
> ---
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index e7be21e..538bd87 100644
> --- a/hw/ppc/spapr.c
> +++ b/h
On 04/01/2016 09:39 PM, David Kiarie wrote:
Added a bool, subject to review to machine properties which
it used to override iommu emulated from Intel to AMD.
Hi David,
The patch is looking good, thanks.
One minor comment below.
Signed-off-by: David Kiarie
---
hw/core/machine.c | 32
Sergey Fedorov writes:
> On 04/04/16 12:01, Paolo Bonzini wrote:
>> On 04/04/2016 10:54, Alex Bennée wrote:
>>> Thoughts, objections? Discuss ;-)
>> I think we're putting a lot of carts before the horse.
It is a very valid objection. I don't want to add another major code
change in while gettin
On 04/01/2016 09:39 PM, David Kiarie wrote:
Add AMD IOMMU emulation support to q35 chipset
Signed-off-by: David Kiarie
---
hw/pci-host/q35.c | 21 +++--
include/hw/i386/intel_iommu.h | 1 +
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/pci-h
On 04/04/2016 13:24, Alex Bennée wrote:
> FWIW I've dropped the patch that moves tb_find_fast out of tb_lock in
> the upcoming base-patches-v2 series because it:
> - weirdly breaks the pxe tests
I'm happy to take a look.
> - is pretty ugly anyway
What exactly makes it ugly?
Paolo
> This
On Mon, 4 Apr 2016 06:17:38 -0400
Stefan Berger wrote:
> On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote:
> > On Sun, Apr 03, 2016 at 09:37:55PM -0400, Stefan Berger wrote:
> >> This patch addresses BZ 1281413.
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1281413
> >>
> >> Fix the APCI
Am 04.04.2016 um 13:05 schrieb Sergey Fedorov:
> From: Sergey Fedorov
>
> assert() always evaluates its argument so there's no need to #ifdef the
> definitions which is only used for assert(). Actually, doing so
> generates a compilation warning which is treated as an error in QEMU
> build by defa
Paolo Bonzini writes:
> On 04/04/2016 13:24, Alex Bennée wrote:
>> FWIW I've dropped the patch that moves tb_find_fast out of tb_lock in
>> the upcoming base-patches-v2 series because it:
>> - weirdly breaks the pxe tests
>
> I'm happy to take a look.
Be my guest:
https://github.com/stsquad/
On Sun, 3 Apr 2016 21:37:56 -0400
Stefan Berger wrote:
> Get the interrupt the TPM device model is using. Do not activate
> the interrupt in the ACPI description yet since the current
> default value clashes with other devices.
>
> Signed-off-by: Stefan Berger
> ---
> hw/i386/acpi-build.c | 5
On Mon, 4 Apr 2016 06:31:43 -0400
Stefan Berger wrote:
> On 04/04/2016 05:04 AM, Michael S. Tsirkin wrote:
> > On Sun, Apr 03, 2016 at 09:37:54PM -0400, Stefan Berger wrote:
> >> This series of patches fixes some problems with the TPM's ACPI
> >> description.
> > Could you pls describe how does t
On 04/04/2016 14:01, Alex Bennée wrote:
> > > - is pretty ugly anyway
> >
> > What exactly makes it ugly?
>
> Subjective I guess but the use of tb_lock_recursive() and
> tb_lock_reset() seem not as clean as they could be. Is this stuff Fred
> re-introduced?
I think tb_lock_recursive is mine, w
On 1 April 2016 at 16:53, Samuel Thibault wrote:
> The following changes since commit de1d099a448beb2ec39af4bd9ce4dd6452a18cb5:
>
> Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault-2' into
> staging (2016-04-01 11:15:20 +0100)
>
> are available in the git repository at:
>
>
On Fri, Apr 01, 2016 at 05:30:58PM +0200, Max Reitz wrote:
> > Does it still serve its purpose if we warn the user that the
> > graph structure can contain little surprises :)?
>
> As I replied to Berto, I think we can come up with some constraints
> about what qemu may do and what it wil
Hello All,
I've tested windows live debugging using the Firewire device and it
seems to be good.
Test case scenario:
Kernel-Mode Debugging over a 1394 as detailed in:
https://msdn.microsoft.com/en-us/library/windows/hardware/ff556866(v=vs.85).aspx.
Setup:
Two separate VMs, both run
On 30 March 2016 at 17:37, Programmingkid wrote:
> Allow the user to select .cdr files in the file open dialog.
>
> Signed-off-by: John Arbuckle
> ---
> ui/cocoa.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 6914714..60a7c07 100644
>
I am curious about why overlapping_queue is required for sheepdog.
Overlapping requests have unspecified outcome so the CoQueue is not
necessary as long as the server doesn't crash or return an error.
Hitoshi, could you clarify this point for me?
Thanks,
Paolo
On 04/04/16 12:51, Michael S. Tsirkin wrote:
> This requires that all -fw_cfg command line users use names of the form
> opt/RQFN/: such names are compatible with QEMU 2.4 and 2.5 as well as
> future QEMU versions.
I think "RQFN" is a typo; shouldn't it be RFQDN (reverse fully qualified
domain nam
Hi Peter,
Thanks for following up.
I got access to 16.0 version, I dont particularly see any difference in
basic functionality.
I had been in touch with Edger, We agreed upon making usable code b/w
smmuv2 and smmuv3 for now. Currently the code is in working state.
I also heard, there has been ta
Hello, Richard.
I truly appreciate your guidance, it is of tremendous help to me.
I plan to address all issues you brought up in this mail in the V2 of my patch
series.
All is clear to me, except some subtleties regarding initialization of
platforms.
More specifically, for setting snan bit, I
On 04/04/16 14:56, Stefan Weil wrote:
> Am 04.04.2016 um 13:05 schrieb Sergey Fedorov:
>> From: Sergey Fedorov
>>
>> assert() always evaluates its argument so there's no need to #ifdef the
>> definitions which is only used for assert(). Actually, doing so
>> generates a compilation warning which i
Hi,
back from my easter vacation. A bit surprised to find 200 mails in the
NBD mailing list ;).
On Friday 25 March 2016 09:49:29 Wouter Verhelst wrote:
> On Thu, Mar 24, 2016 at 04:08:13PM -0600, Eric Blake wrote:
> > On 03/23/2016 08:16 AM, Denis V. Lunev wrote:
> > > From: Pavel Borzenkov
> >
Hi,
On Monday 28 March 2016 09:58:52 Eric Blake wrote:
> On 03/25/2016 02:49 AM, Wouter Verhelst wrote:
>
> >> You may also want to add a rule that for all future extensions, any
> >> command that requires data in the server response (other than the server
> >> response to NBD_CMD_READ) must incl
On 4 April 2016 at 14:21, Aleksandar Markovic
wrote:
> B. arm - explicitely sets other fields of float_status,
> explicit invocation of set_snan_bit_is_one(0) added
We zero the float_status structs on reset, because they are earlier
in the CPUARMState structure than the 'features' field (an
On 4 April 2016 at 14:39, wrote:
> From: Vijay
>
> Set target page size to minimum 4K for aarch64.
> This helps to reduce live migration downtime significantly.
>
> Signed-off-by: Vijaya Kumar K
> ---
> target-arm/cpu.h |7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/target-
The current way to obtain the list of existing block jobs is to
iterate over all root nodes and check which ones own a job.
Since we want to be able to support block jobs in other nodes as well,
this patch keeps a list of jobs that is updated every time one is
created or destroyed.
Signed-off-by:
This test case checks that it's not possible to perform two
block-stream operations if there are nodes involved in both.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 60 ++
tests/qemu-iotests/030.out | 4 ++--
2 files changed, 62 ins
bdrv_close_all() cancels all block jobs by iterating over all
BlockDriverStates. This patch simplifies the code by iterating
directly over the block jobs using block_job_next().
Signed-off-by: Alberto Garcia
---
block.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletion
Even if there are no common nodes involved, we currently don't support
several operations at the same time in the same backing chain.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/030 | 21 +
tests/qemu-iotests/030.out | 4 ++--
2 files changed, 23 insertions(+),
This makes sure that the image we are steaming into is open in
read-write mode during the operation.
The block job is created on the destination image, but operation
blockers are also set on the active layer. We do this in order to
prevent other block jobs from running in parallel in the same chai
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
docs/live-block-ops.txt | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt
index a257087..a05d869 100644
--- a/do
Hi!
Half a year later :) here's the new version of the intermediate block
streaming patches.
Quick summary: the feature was already working since June but there
were two problems that made it impossible to merge the patches. Here's
the full description:
https://lists.gnu.org/archive/html/qemu
qmp_query_block_jobs() uses bdrv_next() to look for block jobs, but
this function can only find those in top-level BlockDriverStates.
This patch uses block_job_next() instead.
Signed-off-by: Alberto Garcia
---
blockdev.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
This adds test_stream_intermediate(), similar to test_stream() but
streams to the intermediate image instead.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
tests/qemu-iotests/030 | 18 +-
tests/qemu-iotests/030.out | 4 ++--
2 files changed, 19 insertions(+), 3 d
This patch makes the 'device' parameter of the 'block-stream' command
accept a node name as well as a device name.
In addition to that, operation blockers will be checked in all
intermediate nodes between the top and the base node.
Since qmp_block_stream() now uses the error from bdrv_lookup_bs()
Currently, block jobs can only be owned by root nodes. This patch
allows block jobs to be in any arbitrary node, by making the following
changes:
- Block jobs can now be identified by the node name of their
BlockDriverState in addition to the device name. Since both device
and node names live
bdrv_drain_all() pauses all block jobs by using bdrv_next() to iterate
over all top-level BlockDriverStates. Therefore the code is unable to
find block jobs in other nodes.
This patch uses block_job_next() to iterate over all block jobs.
Signed-off-by: Alberto Garcia
---
block/io.c | 21 +++
On 04/01/2016 03:29 PM, Eric Blake wrote:
> Rather than requiring allocation by default and allowing trims
> only on request during WRITE_ZEROES, it seems like a better
> default is to allow server optimizations by default and require
> full allocation by specific request. Since WRITE_ZEROES is
>
On 31/03/16 17:49, Peter Maydell wrote:
> The regdef for SCTRL_EL3 was incorrectly marked as being an
> ARM_CP_ALIAS, with the remark that this was because the 32-bit
> definition would take care of reset and migration. However the
> intention for banked registers as documented in the comment in
>
On 31/03/16 17:49, Peter Maydell wrote:
> The regdefs for the ESR_EL2 and ESR_EL3 system registers should not
> be marked as ARM_CP_ALIAS, because these are the master copies; the
> DFSR regdef in vmsa_pmsa_cp_reginfo[] is marked as an alias.
> Remove the ALIAS tags so that these registers are corr
qemu already has an existing server implementation option that will
explicitly search the payload of NBD_CMD_WRITE for large blocks of
zeroes, and punch holes in the underlying file. For old clients
that don't know how to use the new NBD_CMD_WRITE_ZEROES, this is a
workaround to keep the server's
1 - 100 of 274 matches
Mail list logo
