Re: [Qemu-devel] [PATCHv2] Strawman proposal for NBD structured replies

2016-03-30 Thread Alex Bligh
On 30 Mar 2016, at 00:17, Eric Blake wrote: >> >> -The server replies with: >> +Replies take one of two forms. They may either be structured replies, > > Hmm, you put your strawman directly in the 'transmission phase' section, > while mine is deferred to the 'Experimental Extensions' section, a

Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer

2016-03-30 Thread Thomas Huth
There's a typo in the title: qemu_hexmap should be qemu_hexdump/ instead. On 25.03.2016 11:42, Isaac Lozano wrote: > qemu_hexdump() in util/hexdump.c has been changed to give also include a > ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have > been replaced with calls to qemu_

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 05:04, tu bo wrote: > Hi Christian: > > On 03/30/2016 12:31 AM, Christian Borntraeger wrote: >> On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote: >>> This works around races that data plane introduces >>> simply by exiting immediately if we detect >>> that dataplane is active. >>>

[Qemu-devel] How to enable the writable function in usb-mtp

2016-03-30 Thread soccercheng Cheng
Hi All, I've found that in the current dev-mtp.c, if I set the storage access capability to 0x (Access Capability, 0x is for read-write ), it still wont' work, the guest Windows treats the exposed MTP as read-only. Does any know how I can make MTP writable? The following is my change for

Re: [Qemu-devel] [Nbd] [PATCH v2 0/3] NBD Structured Read

2016-03-30 Thread Wouter Verhelst
Hi Eric, On Tue, Mar 29, 2016 at 05:00:57PM -0600, Eric Blake wrote: > I wrote this in parallel with Alex's strawman proposals, so I > may have picked up on some of his ideas, while diverging in > other places. > > Changes since v1: rebase, resend some pre-req patches, switch > from global/client

Re: [Qemu-devel] [PATCHv2] Strawman proposal for NBD structured replies

2016-03-30 Thread Wouter Verhelst
Morning, On Wed, Mar 30, 2016 at 07:59:15AM +0100, Alex Bligh wrote: > On 30 Mar 2016, at 00:17, Eric Blake wrote: > >> > >> -The server replies with: > >> +Replies take one of two forms. They may either be structured replies, > > > > Hmm, you put your strawman directly in the 'transmission pha

[Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare

2016-03-30 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. v2: - add jhash.h v1: - initial patch Zhang Chen (3): colo-compare: introduce colo compare initlization colo-compare: track connection and enqueue packet colo-

[Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

[Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-03-30 Thread Zhang Chen
packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-compare.c | 344 +++

[Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread

2016-03-30 Thread Zhang Chen
if packets are same, we send primary packet and drop secondary packet, otherwise notify COLO do checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 122 - 1 file changed, 121 in

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Thomas Huth
On 29.03.2016 01:44, Samuel Thibault wrote: > Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and > IPv6-only network environments. > > Signed-off-by: Samuel Thibault > > --- > > Changes since previous versions: > > - fix coding style > --- > net/slirp.c | 36

[Qemu-devel] [PULL v2 00/21] target-mips queue for 2.6

2016-03-30 Thread Leon Alrae
Here's version 2 with qapi/error.h includes. Thanks, Leon Cc: Peter Maydell Cc: Aurelien Jarno The following changes since commit 553934db664ecee676650fac0330dceff3531736: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2016-03-29 19:54:49 +0100) are avai

[Qemu-devel] [PULL v2 01/21] hw/mips: implement generic MIPS Coherent Processing System container

2016-03-30 Thread Leon Alrae
Implement generic MIPS Coherent Processing System (CPS) which in this commit just creates VPs, but it will serve as a container also for other components like Global Configuration Registers and Cluster Power Controller. Signed-off-by: Leon Alrae --- default-configs/mips-softmmu-common.mak | 1

[Qemu-devel] [PULL v2 10/21] hw/mips_malta: add CPS to Malta board

2016-03-30 Thread Leon Alrae
If the user specifies smp > 1 and the CPU with CM GCR support, then create Coherent Processing System (which takes care of instantiating CPUs) rather than CPUs directly and connect i8259 and cbus to the pins exposed by CPS. However, there is no GIC yet, thus CPS exposes CPU's IRQ pins so use the sa

[Qemu-devel] [PULL v2 04/21] hw/mips/cps: create GCR block inside CPS

2016-03-30 Thread Leon Alrae
Signed-off-by: Leon Alrae --- hw/mips/cps.c | 23 +++ include/hw/mips/cps.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index a74df46..e77b1da 100644 --- a/hw/mips/cps.c +++ b/hw/mips/cps.c @@ -62,6 +62,8 @@ static void mips_c

[Qemu-devel] [PULL v2 02/21] target-mips: add CMGCRBase register

2016-03-30 Thread Leon Alrae
From: Yongbok Kim Physical base address for the memory-mapped Coherency Manager Global Configuration Register space. The MIPS default location for the GCR_BASE address is 0x1FBF_8. This register only exists if Config3 CMGCR is set to one. Signed-off-by: Yongbok Kim [leon.al...@imgtec.com: move

[Qemu-devel] [PULL v2 07/21] hw/mips_malta: remove CPUMIPSState from the write_bootloader()

2016-03-30 Thread Leon Alrae
Remove CPUMIPSState from the write_bootloader() argument list as it is not used in the function. Signed-off-by: Leon Alrae --- hw/mips/mips_malta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 4ff1bb2..609f6dc 10064

[Qemu-devel] [PULL v2 13/21] hw/mips: implement ITC Storage - Control View

2016-03-30 Thread Leon Alrae
Control view is used to access the ITC Storage Cell Tags. It never causes the issuing thread to block. Guest can empty the FIFO cell by setting Empty bit to 1. Signed-off-by: Leon Alrae --- hw/misc/mips_itu.c | 104 + 1 file changed, 104 inser

[Qemu-devel] [PULL v2 14/21] hw/mips: implement ITC Storage - Empty/Full Sync and Try Views

2016-03-30 Thread Leon Alrae
Empty/Full Synchronized and Try views can be used to access FIFO cells. Store to the FIFO cell pushes the value into the queue, load pops the oldest element from the queue. Cell's Full and Empty bits are automatically updated to reflect new state of the cell. Empty/Full Synchronized View causes th

[Qemu-devel] [PULL v2 05/21] hw/mips: add initial Cluster Power Controller support

2016-03-30 Thread Leon Alrae
Cluster Power Controller (CPC) is responsible for power management in multiprocessing system. It provides registers to control the power and the clock frequency of the individual elements in the system. This patch implements only three registers that are used to control the power state of each VP

[Qemu-devel] [PULL v2 15/21] hw/mips: implement ITC Storage - P/V Sync and Try Views

2016-03-30 Thread Leon Alrae
P/V Synchronized and Try Views can be used to access Semaphore cells. Load returns current value and post-decrements the value in the cell (until it reaches zero). Stores increment the value (until it saturates at 0x). P/V Synchronized View causes the issuing thread to block on read if value i

[Qemu-devel] [PULL v2 18/21] target-mips: make ITC Configuration Tags accessible to the CPU

2016-03-30 Thread Leon Alrae
Add CP0.ErrCtl register with WST, SPR and ITC bits. In 34K and interAptiv processors these bits are used to enable CACHE instruction access to different arrays. When WST=0, SPR=0 and ITC=1 the CACHE instruction will access ITC tag values. Generally we do not model caches and we have been treating

[Qemu-devel] [PULL v2 03/21] hw/mips: add initial Global Config Register support

2016-03-30 Thread Leon Alrae
From: Yongbok Kim Add initial GCR support to indicate number of VPs present in the system, L2 bypass mode and revision number. Signed-off-by: Yongbok Kim [leon.al...@imgtec.com: * removed GIC part, * changed commit message, * replaced %lx format spec. with PRIx64, * renamed mips_gcr.{c,h} t

[Qemu-devel] [PULL v2 08/21] hw/mips_malta: remove redundant irq and clock init

2016-03-30 Thread Leon Alrae
Global smp_cpus is never zero (even if user provides -smp 0), thus clocks and irqs are always initialized for each created CPU in the loop at the beginning of mips_malta_init. These two lines cause a leak of already allocated timer and irqs for the first CPU - remove them. Signed-off-by: Leon Alr

[Qemu-devel] [PULL v2 19/21] hw/mips/cps: enable ITU for multithreading processors

2016-03-30 Thread Leon Alrae
Make ITU available in the system if CPU supports multithreading and is part of CPS. Signed-off-by: Leon Alrae --- hw/mips/cps.c | 32 include/hw/mips/cps.h | 2 ++ 2 files changed, 34 insertions(+) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index d46547

[Qemu-devel] [PULL v2 16/21] hw/mips: implement ITC Storage - Bypass View

2016-03-30 Thread Leon Alrae
Bypass View does not cause issuing thread to block and does not affect any of the cells state bit. Read from a FIFO cell returns the value of the oldest entry. Store to a FIFO cell changes the value of the newest entry. Signed-off-by: Leon Alrae --- hw/misc/mips_itu.c | 27 +

[Qemu-devel] [PULL v2 06/21] hw/mips/cps: create CPC block inside CPS

2016-03-30 Thread Leon Alrae
Create Cluster Power Controller and add a link to the CPC MemoryRegion in GCR. Guest can enable / map CPC to any physical address by writing to the memory-mapped GCR_CPC_BASE register. Set vp-start-reset property to 1 to allow only first VP to run from reset. Others are brought up by the guest via

[Qemu-devel] [PULL v2 09/21] hw/mips_malta: move CPU creation to a separate function

2016-03-30 Thread Leon Alrae
Signed-off-by: Leon Alrae --- hw/mips/mips_malta.c | 68 ++-- 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 60e8a8d..cc32a44 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_mal

[Qemu-devel] [PULL v2 17/21] target-mips: check CP0 enabled for CACHE instruction also in R6

2016-03-30 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index a5b8805..65f2caf 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -17194,6 +17194,7 @@ static void decode_opc_spec

[Qemu-devel] [PULL v2 12/21] hw/mips: implement ITC Configuration Tags and Storage Cells

2016-03-30 Thread Leon Alrae
Implement ITC as a single object consisting of two memory regions: 1) tag_io: ITC Configuration Tags (i.e. ITCAddressMap{0,1} registers) which are accessible by the CPU via CACHE instruction. Also adding MemoryRegion *itc_tag to the CPUMIPSState so that CACHE instruction will dispatch reads/writes

[Qemu-devel] [PULL v2 11/21] target-mips: enable CM GCR in MIPS64R6-generic CPU

2016-03-30 Thread Leon Alrae
Indicate that in the MIPS64R6-generic CPU the memory-mapped Global Configuration Register Space is implemented. Signed-off-by: Leon Alrae --- target-mips/translate_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_in

[Qemu-devel] [PULL v2 20/21] target-mips: use CP0_CHECK for gen_m{f|t}hc0

2016-03-30 Thread Leon Alrae
From: Yongbok Kim Reuse CP0_CHECK macro for gen_m{f|t}hc0. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Signed-off-by: Leon Alrae --- target-mips/translate.c | 46 +- 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/target-mips

Re: [Qemu-devel] [PATCH 2/5] slirp: Split get_dns_addr

2016-03-30 Thread Thomas Huth
On 29.03.2016 01:44, Samuel Thibault wrote: > Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf > to make conversion to IPv6 easier. > > Signed-off-by: Samuel Thibault > --- > slirp/slirp.c | 53 ++--- > 1 file changed, 34

Re: [Qemu-devel] [PATCH v3] Add param Error ** for msi_init()

2016-03-30 Thread Marcel Apfelbaum
On 03/30/2016 07:10 AM, Cao jin wrote: Hi Marcel, Thanks for your quick review for this big fat patch:) please see my comments inline. On 03/30/2016 04:56 AM, Marcel Apfelbaum wrote: On 03/28/2016 01:44 PM, Cao jin wrote: -#define VMXNET3_USE_64BIT (true) -#define VMXNET3_PE

[Qemu-devel] [PULL v2 21/21] target-mips: add MAAR, MAARI register

2016-03-30 Thread Leon Alrae
From: Yongbok Kim The MAAR register is a read/write register included in Release 5 of the architecture that defines the accessibility attributes of physical address regions. In particular, MAAR defines whether an instruction fetch or data load can speculatively access a memory region within the p

Re: [Qemu-devel] [PULL 00/48] Block layer patches

2016-03-30 Thread Kevin Wolf
Am 29.03.2016 um 21:56 hat Peter Maydell geschrieben: > On 29 March 2016 at 16:08, Kevin Wolf wrote: > > The following changes since commit b68a80139e37e806f004237e55311ebc42151434: > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into > > staging (2016-03-24 16:24:02 +

Re: [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-03-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > packet come from primary char indev will be send to > outdev - packet come from secondary char dev will be drop Please put in the description an example of how you invoke the filter on the primary and secondary. > Signed-off-by: Li Zhijian >

Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer

2016-03-30 Thread Gerd Hoffmann
On Fr, 2016-03-25 at 03:42 -0700, Isaac Lozano wrote: > qemu_hexdump() in util/hexdump.c has been changed to give also include a > ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have > been replaced with calls to qemu_hexdump(). This takes care of two misc > BiteSized Tasks. > >

Re: [Qemu-devel] [PATCH 3/5] slirp: Add dns6 resolution

2016-03-30 Thread Thomas Huth
On 29.03.2016 01:44, Samuel Thibault wrote: > This makes get_dns_addr address family-agnostic, thus allowing to add the > IPv6 case. > > Signed-off-by: Samuel Thibault > --- > slirp/ip6.h | 9 +++ > slirp/libslirp.h | 1 + > slirp/slirp.c| 72 > +++

Re: [Qemu-devel] [PATCH 4/5] slirp: Support link-local DNS addresses

2016-03-30 Thread Thomas Huth
On 29.03.2016 01:44, Samuel Thibault wrote: > They look like fe80::%eth0 > > Signed-off-by: Samuel Thibault > --- > slirp/libslirp.h | 2 +- > slirp/slirp.c| 26 ++ > slirp/socket.c | 2 +- > 3 files changed, 24 insertions(+), 6 deletions(-) > > diff --git a/slir

Re: [Qemu-devel] [PATCH 5/5] slirp: Add RDNSS advertisement

2016-03-30 Thread Thomas Huth
On 29.03.2016 01:44, Samuel Thibault wrote: > This adds the RDNSS option to IPv6 router advertisements, so that the guest > can autoconfigure the DNS server address. > > Signed-off-by: Samuel Thibault > --- > slirp/ip6_icmp.c | 19 --- > slirp/ip6_icmp.h | 12 ++-- > 2 fi

[Qemu-devel] [PATCH 1/9] hw/intc: QOM'ify etraxfs_pic.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/etraxfs_pic.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/intc/etraxfs_pic.c b/hw/intc/etraxfs_pic.c index 48f9477..64a6f4b 100644 --- a/hw/intc/etraxfs_pic.

[Qemu-devel] [PATCH 3/9] hw/intc: QOM'ify exynos4210_gic.c

2016-03-30 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Split the exynos4210_irq_gate_init into an instance_init and a DeviceClass::realize function Signed-off-by: xiaoqiang zhao --- hw/intc/exynos4210_gic.c | 39 --- 1 file changed, 20 insertions(+), 19

[Qemu-devel] [PATCH 5/9] hw/intc: QOM'ify lm32_pic.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/lm32_pic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/intc/lm32_pic.c b/hw/intc/lm32_pic.c index edc08f1..3dad01c 100644 --- a/hw/intc/lm32_pic.c +++ b/hw/in

[Qemu-devel] [PATCH 6/9] hw/intc: QOM'ify pl190.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/pl190.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/intc/pl190.c b/hw/intc/pl190.c index 5ecbc4a..1e50baf 100644 --- a/hw/intc/pl190.c +++ b/hw/intc/pl190.c

[Qemu-devel] [PATCH 4/9] hw/intc: QOM'ify imx_avic.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/imx_avic.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index 7027655..d21cb97 100644 --- a/hw/intc/imx_avic.c +++ b/hw

[Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files

2016-03-30 Thread xiaoqiang zhao
This patch set QOM'ify files under hw/intc directory. See each commit message for details. xiaoqiang zhao (9): hw/intc: QOM'ify etraxfs_pic.c hw/intc: QOM'ify exynos4210_combiner.c hw/intc: QOM'ify exynos4210_gic.c hw/intc: QOM'ify imx_avic.c hw/intc: QOM'ify lm32_pic.c hw/intc: QOM'i

[Qemu-devel] [PATCH 7/9] hw/intc: QOM'ify slavio_intctl.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/slavio_intctl.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index c9486ed..e82e893 100644 --- a/hw/intc/slavi

[Qemu-devel] [PATCH 2/9] hw/intc: QOM'ify exynos4210_combiner.c

2016-03-30 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/exynos4210_combiner.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index dc0c903..f19a706 100644 -

[Qemu-devel] [PATCH 9/9] hw/intc: QOM'ify omap_intc.c

2016-03-30 Thread xiaoqiang zhao
* Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/intc/omap_intc.c | 63 +++-- 1 file changed, 37 insertions(+), 26

[Qemu-devel] [PATCH 8/9] hw/intc: QOM'ify grlib_irqmp.c

2016-03-30 Thread xiaoqiang zhao
* Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function Signed-off-by: xiaoqiang zhao --- hw/intc/grlib_irqmp.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/intc/grlib_irqm

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > In this patch we use kernel jhash table to track > connection, and then enqueue net packet like this: > > + CompareState ++ > | | > +---+ +---+ +---+ > |conn list +--->conn

[Qemu-devel] [PULL v2 00/48] Block layer patches

2016-03-30 Thread Kevin Wolf
The following changes since commit 553934db664ecee676650fac0330dceff3531736: Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2016-03-29 19:54:49 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fe

Re: [Qemu-devel] [RFC PATCH 2/8] intel_iommu: name vtd address space with devfn

2016-03-30 Thread Michael S. Tsirkin
On Wed, Mar 30, 2016 at 09:12:46AM +0800, Jason Wang wrote: > > > On 03/28/2016 10:02 AM, Peter Xu wrote: > > On Fri, Mar 25, 2016 at 10:13:23AM +0800, Jason Wang wrote: > >> To avoid duplicated name and ease debugging. > >> > >> Cc: Michael S. Tsirkin > >> Cc: Paolo Bonzini > >> Cc: Richard He

Re: [Qemu-devel] [PATCH v7 0/4] ARM: add query-gic-capabilities QMP command

2016-03-30 Thread Andrea Bolognani
On Tue, 2016-03-29 at 21:10 +0100, Peter Maydell wrote: > On 24 March 2016 at 02:55, Peter Xu wrote: > > > > This patch is to add ARM-specific command "query-gic-capability". > > > > The new command can report which kind of GIC device the host/QEMU > > support. The returned result is in the form

Re: [Qemu-devel] [PULL 00/48] Block layer patches

2016-03-30 Thread Peter Maydell
On 30 March 2016 at 09:57, Kevin Wolf wrote: > Am 29.03.2016 um 21:56 hat Peter Maydell geschrieben: >> Hi. I'm afraid this doesn't compile: >> [...] >> Looks like you've also been hit by commit da34e65cb4025, which >> means you now need to explicitly include qapi/error.h if you need it. > > Ok, I

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-30 Thread Alberto Garcia
On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: >> It sounds like the argument here, and in Max's thread on >> query-block-node-tree, is that we DO have cases where order matters, and >> so we need a way for the hot-add operation to explicitly specify where >> in the list a child is inserted

Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread

2016-03-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > if packets are same, we send primary packet and drop secondary > packet, otherwise notify COLO do checkpoint. > > Signed-off-by: Zhang Chen > Signed-off-by: Li Zhijian > Signed-off-by: Wen Congyang > --- > net/colo-compare.c | 122 > ++

Re: [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare

2016-03-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > COLO-compare is a part of COLO project. It is used > to compare the network package to help COLO decide > whether to do checkpoint. Hi Zhang Chen, I've put comments on the individual patches, but some more general things: 1) Please add a c

Re: [Qemu-devel] [PULL 00/48] Block layer patches

2016-03-30 Thread Kevin Wolf
Am 30.03.2016 um 13:29 hat Peter Maydell geschrieben: > On 30 March 2016 at 09:57, Kevin Wolf wrote: > > Am 29.03.2016 um 21:56 hat Peter Maydell geschrieben: > >> Hi. I'm afraid this doesn't compile: > >> [...] > >> Looks like you've also been hit by commit da34e65cb4025, which > >> means you now

Re: [Qemu-devel] [PULL V2 0/7] Net patches

2016-03-30 Thread Peter Maydell
On 30 March 2016 at 02:22, Jason Wang wrote: > The following changes since commit 553934db664ecee676650fac0330dceff3531736: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2016-03-29 19:54:49 +0100) > > are available in the git repository at: > > https:

Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-30 Thread Stefan Hajnoczi
On Tue, Mar 29, 2016 at 06:58:03PM +0200, Cornelia Huck wrote: > On Tue, 29 Mar 2016 17:12:55 +0100 > Stefan Hajnoczi wrote: > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > index 2b5b248..1565e53 100644 > > --- a/include/hw/virtio/virtio.h > > +++ b/include/hw/virtio/v

Re: [Qemu-devel] [RFC v2 3/9] virtio: stop virtqueue processing if device is broken

2016-03-30 Thread Stefan Hajnoczi
On Tue, Mar 29, 2016 at 06:58:03PM +0200, Cornelia Huck wrote: > On Tue, 29 Mar 2016 17:12:55 +0100 > Stefan Hajnoczi wrote: > > > QEMU prints an error message and exits when the device enters an invalid > > state. Terminating the process is heavy-handed. The guest may still be > > able to func

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end

2016-03-30 Thread Alberto Garcia
On Thu 24 Mar 2016 05:39:23 PM CET, Paolo Bonzini wrote: > Extract the handling of throttling from bdrv_flush_io_queue. These > new functions will soon become BdrvChildRole callbacks, as they can > be generalized to "beginning of drain" and "end of drain". > > Signed-off-by: Paolo Bonzini I like

Re: [Qemu-devel] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 14:24, Alberto Garcia wrote: >> > +void bdrv_no_throttling_end(BlockDriverState *bs) >> > +{ >> > +--bs->io_limits_disabled; >> > } > Not very important, but you could assert that this doesn't go below 0. Sure, why not. Paolo

[Qemu-devel] [PATCH] MAINTAINERS: Delete invalid maintainer entries of the Exynos section

2016-03-30 Thread Thomas Huth
Mails to these e-mail addresses are rejected by the mail server of Samsung with "User unknown" messages, so it seems like these Exynos maintainers are no longer available. Signed-off-by: Thomas Huth --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS i

Re: [Qemu-devel] [Qemu-block] [RFC for-2.7 0/1] block/qapi: Add query-block-node-tree

2016-03-30 Thread Alberto Garcia
On Thu 24 Mar 2016 08:07:17 PM CET, Max Reitz wrote: > There are two reasons why I fear we may not want this: > > The first is that the node graph is more or less something internal to > qemu. Its actual structure may (and most probably will) change over > time. We do want to be able to let the use

[Qemu-devel] [PATCH 1/2] block/nfs: add missing #include "qapi/error.h"

2016-03-30 Thread Stefan Hajnoczi
error_setg() used to be included indirectly through qemu/osdep.h. Since commit da34e65cb4025728566d6504a99916f6e7e1dd6a ("include/qemu/osdep.h: Don't include qapi/error.h") it requires an explicit include. Cc: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- block/nfs.c | 1 + 1 file chang

[Qemu-devel] [PATCH 0/2] block/nfs: fix build breakage due to missing includes

2016-03-30 Thread Stefan Hajnoczi
Header files included by almost every source files have been slimmed down recently to speed up the build and eliminate unnecessary dependencies. The block/nfs.c file must have been forgotten when build testing because it currently fails to build. This series adds the necessary #include statements

[Qemu-devel] [PATCH 2/2] block/nfs: add missing #include "qemu/cutils.h"

2016-03-30 Thread Stefan Hajnoczi
parse_uint_full() used to be included from qemu-common.h but was moved to qemu/cutils.h in commit f348b6d1a53e5271cf1c9f9acc4646b4b98c1771 ("util: move declarations out of qemu-common.h"). Cc: Veronia Bahaa Signed-off-by: Stefan Hajnoczi --- block/nfs.c | 1 + 1 file changed, 1 insertion(+) di

[Qemu-devel] [PATCH 0/8] virtio: aio handler API

2016-03-30 Thread Paolo Bonzini
Since Tu Bo tested Michael's patches successfully, here is my take on them. The only change in Michael's patches is that I handled a failure to start dataplane; however, I am also adding other cleanups (patches 1-2 and 8), two bugfixes (patches 3-4), converting virtio-scsi (patch 7), and finally c

[Qemu-devel] [PATCH 3/9] virtio-blk: fix disabled mode

2016-03-30 Thread Paolo Bonzini
The missing check on dataplane_disabled caused a segmentation fault in notify_guest_bh, because s->guest_notifier was NULL. Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 7 +++ hw/block/virtio-blk.c | 2 +- include/hw/virtio/virtio-blk.h | 1 + 3 files changed

[Qemu-devel] [PATCH 2/9] virtio: make virtio_queue_notify_vq static

2016-03-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/virtio.c | 2 +- include/hw/virtio/virtio.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 08275a9..07c45b6 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1086,7 +1

[Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-03-30 Thread Paolo Bonzini
There is no need to run the handler one last time; the device is being reset and it is okay to drop requests that are pending in the virtqueue. By omitting this call, we dodge a possible cause of races between the dataplane thread on one side and the main/vCPU threads on the other. Signed-off-by:

[Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane

2016-03-30 Thread Paolo Bonzini
From: "Michael S. Tsirkin" In addition to handling IO in vcpu thread and in io thread, dataplane introduces yet another mode: handling it by aio. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Use a separate handler just for aio,

[Qemu-devel] [PATCH resend 0/9] virtio: aio handler API

2016-03-30 Thread Paolo Bonzini
Since Tu Bo tested Michael's patches successfully, here is my take on them. The only change in Michael's patches is that I handled a failure to start dataplane; however, I am also adding other cleanups (patches 1-2 and 8), two bugfixes (patches 3-4), converting virtio-scsi (patch 7), and finally c

[Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode

2016-03-30 Thread Paolo Bonzini
Add two missing checks for s->dataplane_fenced. In one case, QEMU would skip injecting an IRQ due to a write to an uninitialized EventNotifier's file descriptor. In the second case, the dataplane_disabled field was used by mistake; in fact after fixing this occurrence it is completely unused. Si

[Qemu-devel] [PATCH 8/9] virtio: merge virtio_queue_aio_set_host_notifier_handler with virtio_queue_set_aio

2016-03-30 Thread Paolo Bonzini
Eliminating the reentrancy is actually a nice thing that we can do with the API that Michael proposed, so let's make it first class. This also hides the complex assign/set_handler conventions from callers of virtio_queue_aio_set_host_notifier_handler, and fixes a possible race that could happen whe

[Qemu-devel] [PATCH 5/9] virtio: add aio handler

2016-03-30 Thread Paolo Bonzini
From: "Michael S. Tsirkin" In addition to handling IO in vcpu thread and in io thread, blk dataplane introduces yet another mode: handling it by aio. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. As a temporary fix, add a separa

[Qemu-devel] [PATCH 7/9] virtio-scsi: use aio handler for data plane

2016-03-30 Thread Paolo Bonzini
In addition to handling IO in vcpu thread and in io thread, dataplane introduces yet another mode: handling it by aio. This reuses the same handler as previous modes, which triggers races as these were not designed to be reentrant. Use a separate handler just for aio, and disable regular handlers

[Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks

2016-03-30 Thread Paolo Bonzini
Reentrancy cannot happen while the BQL is being held. Signed-off-by: Paolo Bonzini --- hw/block/dataplane/virtio-blk.c | 12 ++-- hw/scsi/virtio-scsi-dataplane.c | 9 + include/hw/virtio/virtio-scsi.h | 2 -- 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/hw/bl

Re: [Qemu-devel] [PATCH] MAINTAINERS: Delete invalid maintainer entries of the Exynos section

2016-03-30 Thread Laurent Vivier
On 30/03/2016 14:32, Thomas Huth wrote: > Mails to these e-mail addresses are rejected by the mail server > of Samsung with "User unknown" messages, so it seems like these > Exynos maintainers are no longer available. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 3 --- > 1 file changed

Re: [Qemu-devel] [PATCH] MAINTAINERS: Delete invalid maintainer entries of the Exynos section

2016-03-30 Thread Laurent Vivier
On 30/03/2016 15:00, Laurent Vivier wrote: > > > On 30/03/2016 14:32, Thomas Huth wrote: >> Mails to these e-mail addresses are rejected by the mail server >> of Samsung with "User unknown" messages, so it seems like these >> Exynos maintainers are no longer available. >> >> Signed-off-by: Thom

Re: [Qemu-devel] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState

2016-03-30 Thread Stefan Hajnoczi
On Thu, Mar 24, 2016 at 05:39:19PM +0100, Paolo Bonzini wrote: > Patch 1 comes from Kevin's series to do BlockBackend throttling. > > Patches 2-5 are from my bdrv_drain patches. > > Patches 6-7 are new but based on Ming Lei's old submission. > I'm including them here because they apply on top of

[Qemu-devel] [PATCH] virtio-input: add missing key mappings

2016-03-30 Thread Ladi Prosek
KEY_PAUSE is flat out missing. KEY_SYSRQ already has a keycode assigned but it's not what I'm seeing on my system. The mapping doesn't appear to have to be unique so both keycodes now map to KEY_SYSRQ which is what the "Keyboard PrintScreen", HID usage ID 0x46, translates to. Signed-off-by: Ladi P

Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu

2016-03-30 Thread Joscha Benz
Hi, On 29.03.2016 22:23, Alistair Francis wrote: > On Tue, Mar 29, 2016 at 12:51 PM, wrote: >> Signed-off-by: Joscha Benz > > Hello Joscha , > > Thanks for the patch. In future can you please use git send-email to > send the patches instead of attaching the patch file. You can find > more inf

[Qemu-devel] Virtio-9p

2016-03-30 Thread Pradeep Kiruvale
Hi All, Is virtio-9p-pci device only supports the fsdev deices? I am trying to use -drive option for applying QoS for block device using Virtio-9p-pci device, but failing to create/add a device other than fsdev. Can you please help me on this? Regards, Pradeep

Re: [Qemu-devel] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 15:06, Stefan Hajnoczi wrote: > On Thu, Mar 24, 2016 at 05:39:19PM +0100, Paolo Bonzini wrote: >> Patch 1 comes from Kevin's series to do BlockBackend throttling. >> >> Patches 2-5 are from my bdrv_drain patches. >> >> Patches 6-7 are new but based on Ming Lei's old submission. >> I

Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:00 +0200 Paolo Bonzini wrote: > There is no need to run the handler one last time; the device is being > reset and it is okay to drop requests that are pending in the virtqueue. What about virtio_blk_save()? Could there be any pending requests in that case? > By omitti

Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 15:23, Cornelia Huck wrote: > > There is no need to run the handler one last time; the device is being > > reset and it is okay to drop requests that are pending in the virtqueue. > > What about virtio_blk_save()? Could there be any pending requests in > that case? Those would be

Re: [Qemu-devel] [PATCH] exec: Rename and fix trace events for tracing I/O port access.

2016-03-30 Thread Paolo Bonzini
On 29/03/2016 17:02, Richard W.M. Jones wrote: > Back in the day you used to be able to set DEBUG_IOPORT in ioport.c > and get qemu to dump what (x86) I/O ports were being accessed by the > guest. This was rather useful for finding out what closed source > device drivers were up to. > > Now you

Re: [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows

2016-03-30 Thread Igor Mammedov
On Mon, 21 Mar 2016 10:21:11 -0400 Stefan Berger wrote: > This patch addresses BZ 1281413. > > Fix the APCI description to make it work on Windows again. The ACPI > description was broken in commit 9e47226. above commit just added missing ASL description for TMP device and you also posted exactl

[Qemu-devel] [PATCH] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS

2016-03-30 Thread Igor Mammedov
Windows will fail it initialize TMP driver with the reason: 'device cannot find enough free resources' That happens because parent BUS doesn't describe MMIO resources used by TPM child device. Fix it by describing it in top-most parent bus scope PCI0. Signed-off-by: Igor Mammedov --- hw/i386/a

Re: [Qemu-devel] [PATCH 2/9] virtio: make virtio_queue_notify_vq static

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:01 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 2 +- > include/hw/virtio/virtio.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Acked-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 15:30:04 +0200 Paolo Bonzini wrote: > On 30/03/2016 15:23, Cornelia Huck wrote: > > > There is no need to run the handler one last time; the device is being > > > reset and it is okay to drop requests that are pending in the virtqueue. > > > > What about virtio_blk_save()? Co

Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:00 +0200 Paolo Bonzini wrote: > There is no need to run the handler one last time; the device is being > reset and it is okay to drop requests that are pending in the virtqueue. > By omitting this call, we dodge a possible cause of races between the > dataplane thread on

[Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests

2016-03-30 Thread Daniel P. Berrange
The LUKS block driver tests will require the ability to specify encryption secrets with block devices. This requires using the --object argument to qemu-img/qemu-io to create a 'secret' object. When the IMGKEYSECRET env variable is set, it provides the password to be associated with a secret calle

[Qemu-devel] [PATCH v7 0/3] Tests for LUKS driver

2016-03-30 Thread Daniel P. Berrange
This series contains the 3 test suite patches that had to be dropped from the v6 series during merge with the block tree: v6: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04935.html Changed in v7: - Avoid setting TEST_IMG_FILE when IMGPROTO=file in common.rc for traditional (not

[Qemu-devel] [PATCH v7 1/3] block: add support for --image-opts in block I/O tests

2016-03-30 Thread Daniel P. Berrange
Currently all block tests use the traditional syntax for images just specifying a filename. To support the LUKS driver without resorting to JSON, the tests need to be able to use the new --image-opts argument to qemu-img and qemu-io. This introduces a new env variable IMGOPTSSYNTAX. If this is set

[Qemu-devel] [PATCH v7 3/3] block: enable testing of LUKS driver with block I/O tests

2016-03-30 Thread Daniel P. Berrange
This adds support for testing the LUKS driver with the block I/O test framework. cd tests/qemu-io-tests ./check -luks A handful of test cases are modified to work with luks - 004 - whitelist luks format - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops - 048 - use TEST_IMG_FILE

  1   2   3   >