From: "Daniel P. Berrange"
It is important that the QEMU luks implementation retains 100%
compatibility with the reference implementation provided by
the combination of the linux kernel dm-crypt module and cryptsetup
userspace tools.
There is a matrix of tests to be performed with different sets
On 28.03.2016 17:25, Eric Blake wrote:
> On 03/26/2016 10:33 AM, Max Reitz wrote:
>
>>> We insert the new child to the head, not the tail...
>>
>> Well, the idea is that the order of children doesn't really matter; The
>> only thing that describes the behavior of a child is its role. For
>> instan
On 17.03.2016 10:56, Wen Congyang wrote:
> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
[...]
>> The children.0 notation is really confusing in the way that Berto
>> describes; I hit this a couple of months ago and it really doesn't
>> make sense.
>
> Do you mean: read from children.1 f
On 03/29/2016 08:37 AM, Alex Bligh wrote:
> Eric,
>
>> I guess what I need to add is that in transmission phase, most commands
>> have exactly one response per request; but commands may document
>> scenarios where there will be multiple responses to a single request.
>> NBD_CMD_READ uses the multi
On 03/29/2016 09:29 AM, Max Reitz wrote:
>
> In my opinion, the way the order is explicitly represented is through
> every child's role. For quorum, "children.${i}" comes before
> "children.${i+1}".
>
> The general block layer does not care about these generic children, it
> only cares about "fi
On 03/29/2016 01:31 AM, Sergey Fedorov wrote:
> On 29/03/16 01:12, Richard Henderson wrote:
>> On 03/24/2016 08:11 AM, Paolo Bonzini wrote:
>>> There is also a case where a TB jumps to itself; it then appears twice
>>> in the list with different values in the low bits, such as this:
>>>
>>> tb
On 03/29/2016 07:25 AM, Laurent Vivier wrote:
>
>
> Le 29/03/2016 16:01, cheng...@emindsoft.com.cn a écrit :
>> From: Chen Gang
>>
>> The restorer needs the return code address which is frame->retcode, not
>> frame itself.
>>
>> Signed-off-by: Chen Gang
>> ---
>> linux-user/signal.c | 2 +-
>>
On 29.03.2016 17:39, Eric Blake wrote:
> On 03/29/2016 09:29 AM, Max Reitz wrote:
>
>>
>> In my opinion, the way the order is explicitly represented is through
>> every child's role. For quorum, "children.${i}" comes before
>> "children.${i+1}".
>>
>> The general block layer does not care about th
On 03/29/2016 09:38 AM, Max Reitz wrote:
> On 17.03.2016 10:56, Wen Congyang wrote:
>> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
>
> [...]
>
>>> The children.0 notation is really confusing in the way that Berto
>>> describes; I hit this a couple of months ago and it really doesn't
>>>
From: Max Reitz
When passing -S 0 to qemu-img convert, the target image is supposed to
be fully allocated. Right now, this is not the case if the source image
contains areas which bdrv_get_block_status() reports as being zero.
This patch changes a zeroed area's status from BLK_ZERO to BLK_DATA
b
* Eric Blake (ebl...@redhat.com) wrote:
> On 03/29/2016 09:38 AM, Max Reitz wrote:
> > On 17.03.2016 10:56, Wen Congyang wrote:
> >> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
> >
> > [...]
> >
> >>> The children.0 notation is really confusing in the way that Berto
> >>> describes; I h
Am 24.03.2016 um 20:07 hat Max Reitz geschrieben:
> As I responded to:
> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html
> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.html
>
> I think a general solution for querying the block node tree would be
> nice
On 29.03.2016 17:44, Eric Blake wrote:
> On 03/29/2016 09:38 AM, Max Reitz wrote:
>> On 17.03.2016 10:56, Wen Congyang wrote:
>>> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
>>
>> [...]
>>
The children.0 notation is really confusing in the way that Berto
describes; I hit this a
On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
>> On 03/29/2016 09:38 AM, Max Reitz wrote:
>>> On 17.03.2016 10:56, Wen Congyang wrote:
On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
>>>
>>> [...]
>>>
> The children.0 notation is really
On 03/29/2016 04:17 PM, Cornelia Huck wrote:
> The ->set_host_notifier() callback is invoked whenever we want to
> switch from or to the generic ioeventfd handler. Currently, all
> transports deregister the ioeventfd backing and then re-register
> it. This opens a race window where we are without i
* Max Reitz (mre...@redhat.com) wrote:
> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
> > * Eric Blake (ebl...@redhat.com) wrote:
> >> On 03/29/2016 09:38 AM, Max Reitz wrote:
> >>> On 17.03.2016 10:56, Wen Congyang wrote:
> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote:
> >>>
> >
Hi,
Can I get a respond for this patch. Is it complete, or did I miss something?
On Thu, Mar 24, 2016 at 12:02 AM, Md Haris Iqbal wrote:
> Signed-off-by: Md Haris Iqbal
> ---
> linux-user/qemu.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/qemu.h b/l
On 29.03.2016 17:51, Kevin Wolf wrote:
> Am 24.03.2016 um 20:07 hat Max Reitz geschrieben:
>> As I responded to:
>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html
>> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05680.html
>>
>> I think a general solution for
On 29.03.2016 17:54, Dr. David Alan Gilbert wrote:
> * Max Reitz (mre...@redhat.com) wrote:
>> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
>>> * Eric Blake (ebl...@redhat.com) wrote:
On 03/29/2016 09:38 AM, Max Reitz wrote:
> On 17.03.2016 10:56, Wen Congyang wrote:
>> On 03/17/
On 03/28/2016 04:43 AM, Denis V. Lunev wrote:
> From: Pavel Borzenkov
>
> Add separate "Command flags" section to make it clear which flags are
> currently defined by the protocol.
>
> Signed-off-by: Pavel Borzenkov
> Reviewed-by: Roman Kagan
> Signed-off-by: Denis V. Lunev
> CC: Wouter Verhe
On 03/29/2016 10:01 AM, Eric Blake wrote:
> On 03/28/2016 04:43 AM, Denis V. Lunev wrote:
>> From: Pavel Borzenkov
>>
>> Add separate "Command flags" section to make it clear which flags are
>> currently defined by the protocol.
>>
>> Signed-off-by: Pavel Borzenkov
>> Reviewed-by: Roman Kagan
>>
* Max Reitz (mre...@redhat.com) wrote:
> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote:
> > * Max Reitz (mre...@redhat.com) wrote:
> >> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
> >>> * Eric Blake (ebl...@redhat.com) wrote:
> On 03/29/2016 09:38 AM, Max Reitz wrote:
> > On 17.
Hello, I've been using QEMU to run an executable with monitor, and
using singlestep mode.As far as I know singlestep mode translates one
instruction at a time (please correct me if Im wrong).
My question is, can QEMU/monitor execute the translated instructions
step by step? I mean something like gd
On 29.03.2016 18:03, Dr. David Alan Gilbert wrote:
> * Max Reitz (mre...@redhat.com) wrote:
>> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote:
>>> * Max Reitz (mre...@redhat.com) wrote:
On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
>> O
Am 29.03.2016 um 17:56 hat Max Reitz geschrieben:
> On 29.03.2016 17:51, Kevin Wolf wrote:
> > Am 24.03.2016 um 20:07 hat Max Reitz geschrieben:
> >> As I responded to:
> >> - http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html
> >> - http://lists.nongnu.org/archive/html/qemu-deve
On 29.03.2016 18:09, Kevin Wolf wrote:
> Am 29.03.2016 um 17:56 hat Max Reitz geschrieben:
>> On 29.03.2016 17:51, Kevin Wolf wrote:
>>> Am 24.03.2016 um 20:07 hat Max Reitz geschrieben:
As I responded to:
- http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg04464.html
- http
v2:
* Add VIRTIO_CONFIG_S_NEEDS_RESET notification for VIRTIO 1.0 [Cornelia]
(Note I've sent a Linux virtio_config.h patch to get the constant added to
the headers.)
* Split int -> unsigned int change into separate commit [Fam]
* Fix double "index" typo in commit description [Fam]
The vir
The patches fixes a single occurrence of a tab character that resulted
in mis-aligned indentation.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
---
hw/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 08275
If the avail ring index is bogus virtqueue_num_heads() must return
-EINVAL.
The only caller is virtqueue_get_avail_bytes(). Return saying no bytes
are available when virtqueue_num_heads() fails.
Signed-off-by: Stefan Hajnoczi
---
hw/virtio/virtio.c | 11 ---
1 file changed, 8 insertion
Errors can occur during virtqueue_pop(), especially in
virtqueue_map_desc(). In order to handle this we must unmap iov[]
before returning NULL. The caller will consider the virtqueue empty and
the virtio_error() call will have marked the device broken.
Signed-off-by: Stefan Hajnoczi
---
hw/vir
The virtio code uses int, unsigned int, and uint16_t for virtqueue
indices. The uint16_t is used for the low-level descriptor layout in
virtio_ring.h while code that isn't concerned with descriptor layout can
use unsigned int.
Use of int is problematic because it can result in signed/unsigned
com
Bring in the VIRTIO_CONFIG_S_NEEDS_RESET device status bit definition.
Signed-off-by: Stefan Hajnoczi
---
include/standard-headers/linux/virtio_config.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/standard-headers/linux/virtio_config.h
b/include/standard-headers/linux/virtio_c
Stop processing the vring if virtqueue_get_head() fetches an
out-of-bounds head index.
Signed-off-by: Stefan Hajnoczi
---
hw/virtio/virtio.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 8ffcddc..0dd
QEMU prints an error message and exits when the device enters an invalid
state. Terminating the process is heavy-handed. The guest may still be
able to function even if there is a bug in a virtio guest driver.
Moreover, exiting is a bug in nested virtualization where a nested guest
could DoS oth
If the vring is invalid, tell the caller no bytes are available and mark
the device broken.
Signed-off-by: Stefan Hajnoczi
---
hw/virtio/virtio.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index c07b451..a7459c2
On 25 March 2016 at 10:10, Fam Zheng wrote:
> The collision check does nothing and hasn't been used. Remove the
> variable together with related code.
>
> Signed-off-by: Fam Zheng
I would prefer it if we enabled the collision check and fixed
the things which weren't specifying overlap priorities
Stop processing the vring if an avail ring index is invalid.
Signed-off-by: Stefan Hajnoczi
---
hw/virtio/virtio.c | 45 -
1 file changed, 32 insertions(+), 13 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 07ce02b..de90824 10
Am 24.03.2016 um 23:33 hat Max Reitz geschrieben:
> Using -S 0 is supposed to allocate everything in the output image; or at
> least it is supposed to always explicitly write zeros even if the area
> in question is known to only contain zeros. That doesn't always work
> right now, so this series fi
The actual on-disk size of a file does not only depend on factors qemu
can control. Thus, we should not depend on this to determine whether a
file has indeed been fully allocated. Instead, use qemu-img map and hope
that if an area is referenced, it is indeed allocated, too.
Also, limit the support
On 29 March 2016 at 09:31, Sergey Fedorov wrote:
> On 29/03/16 01:12, Richard Henderson wrote:
>> On 03/24/2016 08:11 AM, Paolo Bonzini wrote:
>>> There is also a case where a TB jumps to itself; it then appears twice
>>> in the list with different values in the low bits, such as this:
>>>
>>>
On 03/29/2016 03:50 PM, Paolo Bonzini wrote:
>
>
> On 29/03/2016 13:45, Cornelia Huck wrote:
Hi Tu Bo,
please always include the assertion patch at
https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in
your tests. Can you include the backtrace from all t
On 03/29/2016 03:42 PM, Michael S. Tsirkin wrote:
> This works around races that data plane introduces
> simply by exiting immediately if we detect
> that dataplane is active.
>
> It's a small but ugly patch, it's only justification
> is that it's minimally intrusive, and that it clearly
> has no
On 24 March 2016 at 21:33, Paolo Bonzini wrote:
> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18'
> into staging (2016-03-18 17:18:41 +)
>
> are available in the git repository at:
>
>
On Tue, Mar 29, 2016 at 09:12:02AM -0600, Eric Blake wrote:
> On 03/29/2016 08:37 AM, Alex Bligh wrote:
> > Eric,
> >
> >> I guess what I need to add is that in transmission phase, most commands
> >> have exactly one response per request; but commands may document
> >> scenarios where there will b
On 25 March 2016 at 07:42, Jason Wang wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into
> staging (2016-03-24 16:24:02 +)
>
> are available in the git repository at:
>
> https://
On Tue, 29 Mar 2016 17:12:55 +0100
Stefan Hajnoczi wrote:
> QEMU prints an error message and exits when the device enters an invalid
> state. Terminating the process is heavy-handed. The guest may still be
> able to function even if there is a bug in a virtio guest driver.
>
> Moreover, exitin
On 28 March 2016 at 23:34, Alex Williamson wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into
> staging (2016-03-24 16:24:02 +)
>
> are available in the git repository at:
>
>
> g
* Max Reitz (mre...@redhat.com) wrote:
> On 29.03.2016 18:03, Dr. David Alan Gilbert wrote:
> > * Max Reitz (mre...@redhat.com) wrote:
> >> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote:
> >>> * Max Reitz (mre...@redhat.com) wrote:
> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote:
> >>>
On 29 Mar 2016, at 16:12, Eric Blake wrote:
>>
>> More a way of guaranteeing avoiding a fragmentation on 'simple' reads.
>> Perhaps a 'DF' bit (don't fragment)! If the server doesn't like it, it
>> can always error the command.
>
> Okay, that makes sense. Does reusing NBD_CMD_FLAG_FUA sound re
On 22.03.2016 20:36, Kevin Wolf wrote:
> We want to get rid of BlockDriverState.blk in order to allow multiple
> BlockBackends per BDS. Converting the device callbacks in block.c (which
> assume a single BlockBackend) to per-child callbacks gets us rid of the
> first few instances.
>
> Signed-off-
On 22.03.2016 20:36, Kevin Wolf wrote:
> In order to get rid of bs->blk for bdrv_get_device_name() and
> bdrv_get_device_or_node_name(), ask all parents for their name and
> simply pick the first one.
>
> Signed-off-by: Kevin Wolf
> ---
> block.c | 22 --
>
On 03/29/2016 11:34 AM, Alex Bligh wrote:
>
> On 29 Mar 2016, at 16:12, Eric Blake wrote:
>>>
>>> More a way of guaranteeing avoiding a fragmentation on 'simple' reads.
>>> Perhaps a 'DF' bit (don't fragment)! If the server doesn't like it, it
>>> can always error the command.
>>
>> Okay, that ma
Hi Eric,
Having read this in more detail now:
On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote:
> + The server MUST ensure that each read chunk lies within the original
> + offset and length of the original client request, MUST NOT send read
> + chunks that would cover the same offse
On 29/03/16 19:26, Peter Maydell wrote:
> On 29 March 2016 at 09:31, Sergey Fedorov wrote:
>> On 29/03/16 01:12, Richard Henderson wrote:
>>> On 03/24/2016 08:11 AM, Paolo Bonzini wrote:
There is also a case where a TB jumps to itself; it then appears twice
in the list with different val
On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote:
> On 03/29/2016 11:34 AM, Alex Bligh wrote:
> > I would agree. I think if it supports the structured reply semantics,
> > it should also support 'DF'. So if you know the server supports
> > structured replies, you know you can set DF on th
On 03/29/2016 12:03 PM, Wouter Verhelst wrote:
> On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote:
>> On 03/29/2016 11:34 AM, Alex Bligh wrote:
>>> I would agree. I think if it supports the structured reply semantics,
>>> it should also support 'DF'. So if you know the server supports
>>>
On 29 Mar 2016, at 19:03, Wouter Verhelst wrote:
> There are other ways to handle that; e.g., the server could have a
> "request too large for non-fragmented read" error message. The spec
> should give a minimum size that the server MUST support (which should be
> reasonably large), and should s
On 22.03.2016 20:36, Kevin Wolf wrote:
> The block jobs currently modify the target BB's error handling options
> and require that the source BB's iostatus is enabled in order to
> implement the per-job error options. It's obvious that this is something
> between ugly, adventurous and plain wrong,
On Tue, Mar 29, 2016 at 12:07:59PM -0600, Eric Blake wrote:
> On 03/29/2016 12:03 PM, Wouter Verhelst wrote:
> > On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote:
> >> Supporting DF merely transfers the burden of collection between server
> >> and client. I suspect that there are cases w
On 22.03.2016 20:36, Kevin Wolf wrote:
> Since virtio-blk implements request merging itself these days, the only
> remaining users are test cases for the function. That doesn't make the
> function exactly useful any more.
>
> Signed-off-by: Kevin Wolf
> ---
> block/block-backend.c | 14
On 03/29/2016 11:53 AM, Wouter Verhelst wrote:
> Hi Eric,
>
> Having read this in more detail now:
>
> On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote:
>> + The server MUST ensure that each read chunk lies within the original
>> + offset and length of the original client request, MUS
On 22.03.2016 20:36, Kevin Wolf wrote:
> We just want to know whether a BDS has at least one BB attached in order
> to avoid enumerating it twice. This doesn't depend on the exact BB that
> is attached and is still a valid question when more than one BB can be
> attached, so just answer it by check
On 22.03.2016 20:36, Kevin Wolf wrote:
> bdrv_move_feature_fields() and swap_feature_fields() are empty now, they
> can be removed.
>
> Signed-off-by: Kevin Wolf
> ---
> block.c | 30 --
> 1 file changed, 30 deletions(-)
Nice. :-)
Reviewed-by: Max Reitz
signatur
On 03/29/2016 12:19 PM, Wouter Verhelst wrote:
> On Tue, Mar 29, 2016 at 12:07:59PM -0600, Eric Blake wrote:
>> On 03/29/2016 12:03 PM, Wouter Verhelst wrote:
>>> On Tue, Mar 29, 2016 at 11:45:45AM -0600, Eric Blake wrote:
Supporting DF merely transfers the burden of collection between server
On 22.03.2016 20:36, Kevin Wolf wrote:
> We need to introduce a separate BdrvNextIterator struct that can keep
> more state than just the current BDS in order to avoid using the bs->blk
> pointer.
>
> Signed-off-by: Kevin Wolf
> ---
> block.c| 34 +
On Tue, Mar 29, 2016 at 12:23:31PM -0600, Eric Blake wrote:
> On 03/29/2016 11:53 AM, Wouter Verhelst wrote:
> > Hi Eric,
> >
> > Having read this in more detail now:
> >
> > On Mon, Mar 28, 2016 at 09:56:36PM -0600, Eric Blake wrote:
> >> + The server MUST ensure that each read chunk lies withi
On 22.03.2016 20:36, Kevin Wolf wrote:
> query-named-block-nodes should not return information that is related
> to the attached BlockBackend rather than the node itself, so throttling
> information needs to be removed from it.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qapi.c | 6 +++
On 29 March 2016 at 00:28, Samuel Thibault wrote:
> Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-03-21-tag'
> into staging (2016-03-22 17:39:48 +)
>
> are available in the git repository at:
>
> http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
>
> for y
On 22.03.2016 20:36, Kevin Wolf wrote:
> This patch removes the remaining users of bs->blk, which will allow us
> to have multiple BBs on top of a single BDS. All checks that are
> currently in place to prevent the user from creating such setups.
I think this sentence is missing a word or two.
>
On 28 March 2016 at 14:22, Dmitry Osipenko wrote:
> Hello Peter,
>
> 16.03.2016 17:36, Peter Maydell пишет:
>>
>> On 30 January 2016 at 16:43, Dmitry Osipenko wrote:
>>
>>> Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
>>
>>
>> So, where are we with this series? It looked from the mai
On 25 March 2016 at 09:46, Shannon Zhao wrote:
> From: Shannon Zhao
>
> KVM-ARM64 supports guest PMU now. This series add the support in machine
> virt so that guest could use PMU.
>
> Shannon Zhao (3):
> target-arm: kvm64: set guest PMUv3 feature bit if supported
> hw/arm/virt: Add PMU node
On Tue, Mar 29, 2016 at 08:51:57PM +0200, Wouter Verhelst wrote:
> On Tue, Mar 29, 2016 at 12:23:31PM -0600, Eric Blake wrote:
> > Unfortunately, I chose the design of 0 or more structured replies
> > followed by a normal reply, so that the normal reply is a reliable
> > indicator that the read is
On 29 Mar 2016, at 19:51, Wouter Verhelst wrote:
>>
>> But I was envisioning the opposite: the server must NOT send X bytes
>> unless it knows they are valid; if it encounters a read error at Z,
>> then it sends a structured read of Z-1 bytes before the final normal
>> message that reports over
On 26 March 2016 at 11:06, Jean-Christophe Dubois wrote:
> Split ARM on/off function from PSCI support code.
>
> This will allow to reuse these functions in other code.
>
> Signed-off-by: Jean-Christophe Dubois
> ---
>
> Changes since V1:
> * Not present on V1
>
> Changes since V2:
> * Not pres
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
[Sergey Fedorov: eliminate the field entirely in user-mode]
Signed-off-by: Sergey Fedorov
---
Notes:
Changes in v2:
* The field is eliminated entirely in user-mode
translate-all.c | 11 ---
1 file changed, 8 insertions(+), 3 d
On 26 March 2016 at 11:06, Jean-Christophe Dubois wrote:
> This patch series adds support for the Freescale i.MX6 processor.
>
> For now we only support the following devices:
> * up to 4 Cortex A9 cores
> * A9 MPCORE (SCU, GIC, TWD)
> * 5 i.MX UARTs
> * 2 EPIT timers
> * 1 GPT timer
> * 7 GPIO co
From: Sergey Fedorov
This patch series consists of various general TCG clean-up patches extracted
from Paolo's MTTCG tree [1] and Alex's MTTCG base enablement tree [2]. The idea
is to review and merge these patches separately from the MTTCG series to cut
the latter and make it easier to review.
On 29 March 2016 at 03:49, Jeff Cody wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into
> staging (2016-03-24 16:24:02 +)
>
> are available in the git repository at:
>
>
> g...@gi
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
[Alex Bennée: #ifndef replay code to match elided functions]
Signed-off-by: Alex Bennée
Signed-off-by: Sergey Fedorov
---
cpu-exec.c | 8
1 file changed, 8 insertions(+)
diff --git a/cpu-exec.c b/cpu-exec.c
index 44116f180859..5d1b4c9
From: Alex Bennée
Put some comments and improve code structure. This should help reading
the code.
Signed-off-by: Alex Bennée
[Sergey Fedorov: provide commit message; bring back resetting of
tb_invalidated_flag]
Signed-off-by: Sergey Fedorov
---
cpu-exec.c | 44 ---
Signed-off-by: Joscha Benz
---
hw/usb/hcd-ehci-sysbus.c | 175 ++---
hw/usb/hcd-ehci.c| 1 +
hw/usb/hcd-ehci.h| 31 ++
include/hw/register.h| 245 +++
4 files changed, 441 insertions(+), 11 deletion
racking branch 'remotes/cohuck/tags/s390x-20160324' into
> staging (2016-03-24 16:24:02 +)
>
> are available in the git repository at:
>
> git://github.com/lalrae/qemu.git tags/mips-20160329
>
> for you to fetch changes up to e9f517b73dab520de05b87135
On 29 March 2016 at 16:08, Kevin Wolf wrote:
> The following changes since commit b68a80139e37e806f004237e55311ebc42151434:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160324' into
> staging (2016-03-24 16:24:02 +)
>
> are available in the git repository at:
>
>
> git://
On 03/29/2016 01:39 PM, Alex Bligh wrote:
> I think we are paying too much attention to trying to keep NBD_RESPONSE
> intact. The justification for this was (I think) that it made it easier
> for existing protocol analysers. It doesn't, really, as all the data
> is going to come BEFORE the NBD_RESP
On 24 March 2016 at 02:55, Peter Xu wrote:
> Some more lines to make sure we allow NULL for 1st/3rd parameter.
>
> Signed-off-by: Peter Xu
> ---
> target-arm/kvm.c | 14 +-
> target-arm/kvm_arm.h | 6 --
> 2 files changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/ta
On 03/29/2016 12:48 PM, Sergey Fedorov wrote:
> From: Paolo Bonzini
>
> Signed-off-by: Paolo Bonzini
> [Sergey Fedorov: eliminate the field entirely in user-mode]
> Signed-off-by: Sergey Fedorov
> ---
>
> Notes:
> Changes in v2:
> * The field is eliminated entirely in user-mode
Revie
On 24 March 2016 at 02:55, Peter Xu wrote:
> This patch is to add ARM-specific command "query-gic-capability".
>
> The new command can report which kind of GIC device the host/QEMU
> support. The returned result is in the form of array.
>
> Sample command and output:
>
> {"execute": "query-gic-cap
29.03.2016 22:00, Peter Maydell пишет:
On 28 March 2016 at 14:22, Dmitry Osipenko wrote:
Hello Peter,
16.03.2016 17:36, Peter Maydell пишет:
On 30 January 2016 at 16:43, Dmitry Osipenko wrote:
Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
So, where are we with this series?
On 29 Mar 2016, at 21:00, Eric Blake wrote:
> I'm liking it - then we aren't sending a mandatory 0 error field on read
> chunks.
I'm writing it up as a strawman. I'll comment in a sec in further detail.
--
Alex Bligh
signature.asc
Description: Message signed with OpenPGP using GPGMail
On Tue, Mar 29, 2016 at 12:51 PM, wrote:
> Signed-off-by: Joscha Benz
Hello Joscha ,
Thanks for the patch. In future can you please use git send-email to
send the patches instead of attaching the patch file. You can find
more information on doing this at:
http://wiki.qemu.org/Contribute/Submit
On 03/29/2016 12:48 PM, Sergey Fedorov wrote:
> +while (tb) {
> if (tb->pc == pc &&
> tb->page_addr[0] == phys_page1 &&
> tb->cs_base == cs_base &&
> tb->flags == flags) {
> -/* check next page if needed */
> -if (tb->page_
On 03/29/2016 12:48 PM, Sergey Fedorov wrote:
> From: Alex Bennée
>
> Put some comments and improve code structure. This should help reading
> the code.
>
> Signed-off-by: Alex Bennée
> [Sergey Fedorov: provide commit message; bring back resetting of
> tb_invalidated_flag]
> Signed-off-by: Serg
Here's a strawman for the structured reply section. I haven't
covered negotation.
Signed-off-by: Alex Bligh
---
doc/proto.md | 114 +--
1 file changed, 111 insertions(+), 3 deletions(-)
diff --git a/doc/proto.md b/doc/proto.md
index aaae0a
Eric,
> I'm liking it - then we aren't sending a mandatory 0 error field on read
> chunks.
Straw man patch sent through. Alternatively at:
https://github.com/abligh/nbd/commit/3c40272704904ac74040ceb099fee0b44e355e1e
and in markdown format at:
https://github.com/abligh/nbd/blob/strawman-struct
On 03/28/2016 01:44 PM, Cao jin wrote:
Add param Error **errp, and change pci_add_capability() to
pci_add_capability2(), because pci_add_capability() report error, and
msi_init() is widely used in realize(), so it is not suitable for realize().
Hi,
The patch is looking good in my opinion, a fe
On Tue, Mar 29, 2016 at 09:39:43PM +0100, Alex Bligh wrote:
> Here's a strawman for the structured reply section. I haven't
> covered negotation.
LGTM, for the most part.
[...]
> +Each chunk consists of the following:
> +
> +S: 32 bits, 0x668e33ef, magic (`NBD_STRUCTURED_REPLY_MAGIC`)
> +S: 32 bi
Hi Alex,
On Tue, Mar 29, 2016 at 09:44:39PM +0100, Alex Bligh wrote:
> Eric,
> > For all remaining existing commands, that is just more overhead on the
> > wire. The existing non-structured replies do not send any data; they
> > are 16 bytes each (only NBD_CMD_READ sends more than 16 bytes in one
On 29 Mar 2016, at 21:57, Wouter Verhelst wrote:
>
> I understand why you do it this way (we don't need 2^16 reply types),
> but (in contrast to the flags in the request packet) this makes it
> harder to specify flags and command type as separate fields (there is no
> 24-bit integer on most syst
On 29 Mar 2016, at 22:05, Wouter Verhelst wrote:
>>> For all remaining existing commands, that is just more overhead on the
>>> wire. The existing non-structured replies do not send any data; they
>>> are 16 bytes each (only NBD_CMD_READ sends more than 16 bytes in one
>>> reply). But your pro
But unfortunately we do not know which patch fixed it, making an SRU
much more problematic. Someone who is able to reproduce the bug would
need to try to either bisect, or make educated guesses and test patch
cherrypicks.
--
You received this bug notification because you are a member of qemu-
de
1 - 100 of 349 matches
Mail list logo
