Re: [Qemu-devel] [PATCH RFC 00/14] vhost-user: shutdown and reconnection

2016-03-24 Thread Yuanhan Liu
On Thu, Nov 26, 2015 at 12:33:22PM +0200, Michael S. Tsirkin wrote: > On Wed, Sep 09, 2015 at 01:09:52AM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > In a previous series "Add feature to start QEMU without vhost-user > > backend", Tetsuya Mukawa proposed to allow

Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.

2016-03-24 Thread Jean-Christophe DUBOIS
Le 23/03/2016 15:48, Peter Maydell a écrit : On 19 March 2016 at 20:59, Jean-Christophe Dubois wrote: The sabrelite supports one SPI FLASH memory on SPI1 Signed-off-by: Jean-Christophe Dubois +{ +/* Add the sst25vf016b NOR FLASH memory to first SPI */ +Object *spi_dev; + +

Re: [Qemu-devel] [PATCH v4 1/6] ARM: Factor out ARM on/off PSCI control functions

2016-03-24 Thread Jean-Christophe DUBOIS
Le 23/03/2016 16:24, Peter Maydell a écrit : On 19 March 2016 at 20:59, Jean-Christophe Dubois wrote: Split ARM on/off function from PSCI support code. This will allow to reuse these functions in other code. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Wouter Verhelst
On Thu, Mar 24, 2016 at 10:16:19AM +0300, Pavel Borzenkov wrote: > So if no one objects, I'll send a patch correcting current spec > ambiguities and than patches with new proposed commands. Yes please. Thank you. -- < ron> I mean, the main *practical* problem with C++, is there's like a dozen

Re: [Qemu-devel] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Pavel Borzenkov
On Wed, Mar 23, 2016 at 09:14:10AM -0600, Eric Blake wrote: > On 03/23/2016 08:16 AM, Denis V. Lunev wrote: > > From: Pavel Borzenkov > > > > There exist some cases when a client knows that the data it is going to > > write is all zeroes. Such cases include mirroring or backing up a device > > im

[Qemu-devel] [PULL 3/3] spice: Disallow use of gl + TCP port

2016-03-24 Thread Gerd Hoffmann
From: Christophe Fergeau Currently, virgl support has to go through a local unix socket, trying to connect to a VM using -spice gl through spice://localhost:5900 will only result in a black screen. This commit errors out when the user tries to start a VM with both GL support and a port/tls-port s

[Qemu-devel] [PULL 2/3] input-linux: fix Coverity warning

2016-03-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 1458129049-12484-1-git-send-email-kra...@redhat.com --- ui/input-linux.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/input-linux.c b/ui/input-linux.c index 59d9348..6ddaa67 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -213,6 +2

[Qemu-devel] [PULL v2 0/3] ui: input-linux + spice fixes

2016-03-24 Thread Gerd Hoffmann
since commit 2538039f2c26d66053426fb547e4f25e669baf62: Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2016-03-18' into staging (2016-03-23 12:57:44 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20160324-1 for you to fetch cha

[Qemu-devel] [PULL 1/3] input-linux: switch over to -object

2016-03-24 Thread Gerd Hoffmann
This patches makes input-linux use -object instead of a new command line switch. So, instead of the switch ... -input-linux /dev/input/event$nr ... you must create an object this way: -object input-linux,id=$name,evdev=/dev/input/event$nr Bonus is that you can hot-add and hot-remove th

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: fix help menus

2016-03-24 Thread Gerd Hoffmann
Hi, > Yes; the cover letter doesn't appear to have reached me so it is > not in my queue. (In any case you'd have needed to redo it since > you forgot to fix up the broken author information that you get > from John's emails by default.) > > Can I get you to redo and resend, please (without the

Re: [Qemu-devel] [PATCH 03/12] block: Introduce BlockBackendPublic

2016-03-24 Thread Kevin Wolf
Am 23.03.2016 um 22:35 hat Eric Blake geschrieben: > On 03/23/2016 03:09 AM, Kevin Wolf wrote: > >>> +++ b/block/block-backend.c > >>> @@ -33,6 +33,7 @@ struct BlockBackend { > >>> DriveInfo *legacy_dinfo;/* null unless created by drive_new() */ > >>> QTAILQ_ENTRY(BlockBackend) link;

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-24 Thread tu bo
Hi Christian: On 03/23/2016 05:12 PM, Christian Borntraeger wrote: On 03/23/2016 10:08 AM, Paolo Bonzini wrote: On 23/03/2016 09:10, Cornelia Huck wrote: -/* Kick right away to begin processing requests already in vring */ -event_notifier_set(virtio_queue_get_host_notifier(s->vq)); +

Re: [Qemu-devel] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback

2016-03-24 Thread Kevin Wolf
Am 23.03.2016 um 22:29 hat Paolo Bonzini geschrieben: > > > On 22/03/2016 16:33, Kevin Wolf wrote: > > This removes the last part of I/O throttling from block/io.c and moves > > it to the BlockBackend. > > > > When draining the queue of a BlockDriverState, we must make sure that no > > new reque

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Wouter Verhelst
On Thu, Mar 24, 2016 at 10:57:06AM +0300, Pavel Borzenkov wrote: > On Wed, Mar 23, 2016 at 06:21:16PM +0100, Wouter Verhelst wrote: > > So, the semantics of your proposed WRITE_ZEROES are exactly the same as > > the WRITE command, except that no payload is sent? > > > > In that case, I think it's

[Qemu-devel] [PULL for-2.6 00/14] s390-ccw bios patches

2016-03-24 Thread Cornelia Huck
The following changes since commit 2538039f2c26d66053426fb547e4f25e669baf62: Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2016-03-18' into staging (2016-03-23 12:57:44 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-2016032

[Qemu-devel] [PULL for-2.6 01/14] pc-bios/s390-ccw: add more disk layout checks

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Experiments showed possibility of few more "misconfigurations" in disk layout. They are reported now. Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c

[Qemu-devel] [PULL for-2.6 02/14] pc-bios/s390-ccw: virtio_panic -> panic

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" This function has nothing to do with virtio. Reviewed-by: Cornelia Huck Reviewed-by: David Hildenbrand Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 8 pc-bios/s390-ccw/bootmap.h | 2 +- pc

[Qemu-devel] [PULL for-2.6 10/14] pc-bios/s390-ccw: add virtio-scsi implementation

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add virtio-scsi.[ch] with primary implementation of virtio-scsi. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio-scsi.c | 342 + pc-bios/s390-ccw/virtio-scsi.h | 72 +++

[Qemu-devel] [PULL for-2.6 05/14] pc-bios/s390-ccw: update virtio implementation to allow up to 3 vrings

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add ability to work with up to 3 vrings, which is required for virtio-scsi implementation. Implement the optional cookie to speed up processing of virtio notifications. Reviewed-by: Cornelia Huck Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia

[Qemu-devel] [PULL for-2.6 03/14] pc-bios/s390-ccw: add utility functions and "export" some others

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add several utility functions, make IPL_check and IPL_assert generally available, etc. Acked-by: Cornelia Huck Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.h | 18 -- pc-bios/s390-ccw/s39

[Qemu-devel] [PULL for-2.6 07/14] pc-bios/s390-ccw: make provisions for different backends

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add dispatching code to make room for non virtio-blk boot devices. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 4 +- pc-bios/s390-ccw/s390-ccw.h | 4 +- pc-bios/s390-ccw/virtio.c | 130

[Qemu-devel] [PULL for-2.6 04/14] pc-bios/s390-ccw: qemuize types

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Turn [the most of] existing declarations from struct type_name { ... }; into struct TypeName { ... }; typedef struct TypeName TypeName; and make use of them. Also switch u{8,16,32,64} to uint{8,16,32,64}_t. Acked-by: Cornelia Huck Signed-off-by: Eu

[Qemu-devel] [PULL for-2.6 13/14] pc-bios/s390-ccw: disambiguation of "No zIPL magic" message

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Don't indicate the same error message for different conditions. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/boo

[Qemu-devel] [PULL for-2.6 09/14] pc-bios/s390-ccw: add scsi definitions

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add scsi.h to provide basic definitions for SCSI. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/scsi.h | 184 1 file changed, 184 insertions(+) create mode 100644 p

[Qemu-devel] [PULL for-2.6 14/14] s390-ccw.img: rebuild image

2016-03-24 Thread Cornelia Huck
Contains the following changes: pc-bios/s390-ccw: add more disk layout checks pc-bios/s390-ccw: virtio_panic -> panic pc-bios/s390-ccw: add utility functions and "export" some others pc-bios/s390-ccw: qemuize types pc-bios/s390-ccw: update virtio implementation to allow up to 3 vrings pc-bios/s390

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Pavel Borzenkov
On Wed, Mar 23, 2016 at 06:21:16PM +0100, Wouter Verhelst wrote: > Hi, > > On Wed, Mar 23, 2016 at 05:16:01PM +0300, Denis V. Lunev wrote: > > From: Pavel Borzenkov > > > > There exist some cases when a client knows that the data it is going to > > write is all zeroes. Such cases include mirrori

[Qemu-devel] [PULL for-2.6 08/14] pc-bios/s390-ccw: add simplified virtio call

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add virtio_run(VirtioCmd) call to use simple declarative approach. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 17 + pc-bios/s390-ccw/virtio.h | 9 + 2 files changed, 26 insert

[Qemu-devel] [PULL for-2.6 06/14] pc-bios/s390-ccw: add vdev object to store all device details

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add VDev "object" as a container for all device-related items. The default object is static. Leverage dependency on many different device-related globals. Make them syntactically visible. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck -

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-24 Thread Cornelia Huck
On Thu, 24 Mar 2016 16:19:41 +0800 tu bo wrote: > Hi Christian: > > On 03/23/2016 05:12 PM, Christian Borntraeger wrote: > > On 03/23/2016 10:08 AM, Paolo Bonzini wrote: > >> > >> > >> On 23/03/2016 09:10, Cornelia Huck wrote: > -/* Kick right away to begin processing requests already i

Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-24 Thread Kevin Wolf
Am 23.03.2016 um 21:11 hat Max Reitz geschrieben: > On 18.03.2016 11:31, Kevin Wolf wrote: > > The call in hmp_drive_del() is dead code because blk_remove_bs() is > > called a few lines above. > > Ah, so that's why I didn't have it in v3. Thanks for solving that > mystery for me. :-) I could have

[Qemu-devel] [PULL for-2.6 11/14] pc-bios/s390-ccw: enable virtio-scsi

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Make the code added before to work. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 8 +--- pc-bios/s390-ccw/virtio.c | 113 +--

[Qemu-devel] [PULL for-2.6 12/14] pc-bios/s390-ccw: enhance bootmap detection

2016-03-24 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Improve the algorithm that tries to guess the disk layout: 1. Use CD-ROMs to read ISO only 2. Make explicit paths for -scsi and -blk virtio Acked-by: Maxim Samoylov Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bo

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Pavel Borzenkov
On Wed, Mar 23, 2016 at 07:14:54PM +0100, Kevin Wolf wrote: > Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben: > > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > > +The type of information required by the client is passed to server > > > in the > > > +command fl

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Wouter Verhelst
On Thu, Mar 24, 2016 at 11:25:52AM +0300, Pavel Borzenkov wrote: > On Wed, Mar 23, 2016 at 07:14:54PM +0100, Kevin Wolf wrote: > > Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben: > > > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > > > +the provisioning state of the

Re: [Qemu-devel] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-24 Thread Laurent Vivier
On 24/03/2016 06:35, David Gibson wrote: > On Tue, Mar 22, 2016 at 05:33:45PM +0100, Laurent Vivier wrote: >> Hi David, >> >> using kvm-unit-tests, I've found a side effect of your patches: the MSR >> is cleared (and perhaps some others). >> >> I was trying to test my patch on top of QEMU master:

Re: [Qemu-devel] [RFC] host and guest kernel trace merging

2016-03-24 Thread Peter Xu
On Fri, Mar 04, 2016 at 11:19:33AM +, Stefan Hajnoczi wrote: > On Thu, Mar 03, 2016 at 02:35:01PM -0500, Luiz Capitulino wrote: > > trace-cmd-server > > > > > > Everything I described could look like this: > > > > # trace-cmd server [ in the host ] > > # trace-cmd record

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Pavel Borzenkov
On Wed, Mar 23, 2016 at 06:58:34PM +0100, Wouter Verhelst wrote: > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > From: Pavel Borzenkov > > > > With the availability of sparse storage formats, it is often needed to > > query status of a particular LBA range and read only thos

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-24 Thread Cornelia Huck
On Thu, 24 Mar 2016 09:32:30 +0100 Cornelia Huck wrote: > I'll re-send my patches with some added interface doc in patch 1. Stay > tuned. Grr. Unfortunately, this fails for _me_ now (-EEXIST after reboot). Debugging.

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Dr. David Alan Gilbert
* Wei Yang (richard.weiy...@huawei.com) wrote: > On Wed, Mar 23, 2016 at 06:48:22AM +, Li, Liang Z wrote: > [...] > >> > 8. Pseudo code > >> > Dirty page logging should be enabled before getting the free page > >> > information from guest, this is important because during the process > >> > of

Re: [Qemu-devel] [PATCH qemu v14 17/18] vfio/spapr: Use VFIO_SPAPR_TCE_v2_IOMMU

2016-03-24 Thread Alexey Kardashevskiy
On 03/24/2016 11:03 AM, Alexey Kardashevskiy wrote: On 03/23/2016 05:03 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 02:06:36PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016 01:53 PM, David Gibson wrote: On Wed, Mar 23, 2016 at 01:12:59PM +1100, Alexey Kardashevskiy wrote: On 03/23/2016

Re: [Qemu-devel] [PATCH v7 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu

2016-03-24 Thread Sergey Fedorov
On 24/03/16 05:55, Peter Xu wrote: > Some more lines to make sure we allow NULL for 1st/3rd parameter. > > Signed-off-by: Peter Xu Acked-by: Sergey Fedorov Kind regards, Sergey > --- > target-arm/kvm.c | 14 +- > target-arm/kvm_arm.h | 6 -- > 2 files changed, 17 insertio

Re: [Qemu-devel] [PATCH v7 3/4] kvm: add kvm_device_supported() helper function

2016-03-24 Thread Sergey Fedorov
On 24/03/16 05:55, Peter Xu wrote: > This can be used when probing whether KVM support specific device. Here, > a raw vmfd is used. > > Signed-off-by: Peter Xu Acked-by: Sergey Fedorov Kind regards, Sergey > --- > include/sysemu/kvm.h | 9 + > kvm-all.c| 15 +

Re: [Qemu-devel] [PATCH v7 4/4] arm: implement query-gic-capabilities

2016-03-24 Thread Sergey Fedorov
On 24/03/16 05:55, Peter Xu wrote: > For emulated GIC capabilities, currently only gicv2 is supported. We > need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM > VM, we detect the capability bits by creating a scratch VM. > > Signed-off-by: Peter Xu Acked-by: Sergey Fedorov

Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets

2016-03-24 Thread Sergey Fedorov
On 23/03/16 20:20, Alex Bennée wrote: > diff --git a/configure b/configure > index b88d0db..ebf8a42 100755 > --- a/configure > +++ b/configure > @@ -1246,7 +1246,8 @@ Standard options: >--target-list=LIST set target list (default: build everything) > $(echo Available targets: $default_ta

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-24 Thread Cornelia Huck
On Thu, 24 Mar 2016 09:47:56 +0100 Cornelia Huck wrote: > On Thu, 24 Mar 2016 09:32:30 +0100 > Cornelia Huck wrote: > > > I'll re-send my patches with some added interface doc in patch 1. Stay > > tuned. > > Grr. Unfortunately, this fails for _me_ now (-EEXIST after reboot). > Debugging. Good

Re: [Qemu-devel] wiki: update missing info on "Enabling multi-queue" section of vhost-user

2016-03-24 Thread Marcel Apfelbaum
On 03/21/2016 12:10 PM, Lin Ma wrote: Hi Marcel, I found that the information on "Enabling multi-queue" in http://wiki.qemu.org/Features/vhost-user-ovs-dpdk are inaccurate. In ovs 2.5 or older, The option 'other_config:n-dpdk-rxqs' is used and there is no options:n_rxq. The n_rxq is available s

Re: [Qemu-devel] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 09:25, Kevin Wolf wrote: > I think your cancellation series (allows to) gets rid of most if not all > blk_drain() callers in the device emulation, so it becomes harder for > guests to trigger one. Ideally only the monitor should allow triggering > a drain. More precesely you still

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Michael S. Tsirkin
On Thu, Mar 24, 2016 at 01:19:40AM +, Li, Liang Z wrote: > > > > > 2. Why not use virtio-balloon > > > > > Actually, the virtio-balloon can do the similar thing by inflating > > > > > the balloon before live migration, but its performance is no good, > > > > > for an 8GB idle guest just boots,

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Wouter Verhelst
On Thu, Mar 24, 2016 at 11:43:18AM +0300, Pavel Borzenkov wrote: > On Wed, Mar 23, 2016 at 06:58:34PM +0100, Wouter Verhelst wrote: > > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote: > > > +2. Block dirtiness state > > > + > > > +Upon receiving an `NBD_CMD_GET_LBA_STATUS` c

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-24 Thread Pavel Butsykin
On 23.03.2016 23:34, Paolo Bonzini wrote: On 23/03/2016 11:26, Denis V. Lunev wrote: If the migration occurs after the IDE DMA has been set up but before it has been initiated, the state gets lost upon save/restore. Specifically, ->dma_cb callback gets cleared, so, when the guest eventually st

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Li, Liang Z
> * Wei Yang (richard.weiy...@huawei.com) wrote: > > On Wed, Mar 23, 2016 at 06:48:22AM +, Li, Liang Z wrote: > > [...] > > >> > 8. Pseudo code > > >> > Dirty page logging should be enabled before getting the free page > > >> > information from guest, this is important because during the > > >>

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-03-24 Thread Pavel Butsykin
On 23.03.2016 22:36, John Snow wrote: On 03/23/2016 06:26 AM, Denis V. Lunev wrote: From: Pavel Butsykin Restart of ATAPI DMA used to be unreachable, because the request to do so wasn't indicated in bus->error_status due to the lack of spare bits, and ide_restart_bh() would return early doin

[Qemu-devel] [PATCH] qdev property: cleanup

2016-03-24 Thread Cao jin
include: 1. remove unnecessary declaration of static function 2. fix inconsistency between comment and function name, and typo OOM->QOM 2. update comment of function Signed-off-by: Cao jin --- A question about legacy property: I don`t see legacy property is really used in the code, so, why still

Re: [Qemu-devel] [RFC] host and guest kernel trace merging

2016-03-24 Thread Stefan Hajnoczi
On Thu, Mar 24, 2016 at 04:42:42PM +0800, Peter Xu wrote: > On Fri, Mar 04, 2016 at 11:19:33AM +, Stefan Hajnoczi wrote: > > On Thu, Mar 03, 2016 at 02:35:01PM -0500, Luiz Capitulino wrote: > > > trace-cmd-server > > > > > > > > > Everything I described could look like this: >

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Li, Liang Z
> On Thu, Mar 24, 2016 at 01:19:40AM +, Li, Liang Z wrote: > > > > > > 2. Why not use virtio-balloon > > > > > > Actually, the virtio-balloon can do the similar thing by > > > > > > inflating the balloon before live migration, but its > > > > > > performance is no good, for an 8GB idle guest ju

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > * Wei Yang (richard.weiy...@huawei.com) wrote: > > > On Wed, Mar 23, 2016 at 06:48:22AM +, Li, Liang Z wrote: > > > [...] > > > >> > 8. Pseudo code > > > >> > Dirty page logging should be enabled before getting the free page > > > >> > information

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-24 Thread Michael S. Tsirkin
On Thu, Mar 24, 2016 at 10:16:47AM +, Li, Liang Z wrote: > > On Thu, Mar 24, 2016 at 01:19:40AM +, Li, Liang Z wrote: > > > > > > > 2. Why not use virtio-balloon > > > > > > > Actually, the virtio-balloon can do the similar thing by > > > > > > > inflating the balloon before live migration,

[Qemu-devel] [PATCH 2/5] hw/display: QOM'ify jazz_led.c

2016-03-24 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/jazz_led.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c i

[Qemu-devel] [PATCH 5/5] hw/display: QOM'ify pl110.c

2016-03-24 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/pl110.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.c index d58

[Qemu-devel] [PATCH 3/6] hw/display/jazz_led.c

2016-03-24 Thread xiaoqiang zhao
--- hw/display/jazz_led.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index 09dcdb4..e0a079a 100644 --- a/hw/display/jazz_led.c +++ b/hw/display/jazz_led.c @@ -267,16 +267,15 @@ static const GraphicHwOps jazz_led_op

[Qemu-devel] [PATCH 4/5] hw/display: QOM'ify milkymist-vgafb.c

2016-03-24 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/milkymist-vgafb.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/display/milkymist-vgafb.c b/hw/display/

[Qemu-devel] [PATCH 1/5] hw/display: QOM'ify exynos4210_fimd.c

2016-03-24 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/exynos4210_fimd.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/displ

[Qemu-devel] [PATCH 6/6] QOM hw/display/pl110.c

2016-03-24 Thread xiaoqiang zhao
--- hw/display/pl110.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.c index d589959..342e7ed 100644 --- a/hw/display/pl110.c +++ b/hw/display/pl110.c @@ -465,23 +465,17 @@ static const GraphicHwOps pl110_gfx_ops = {

[Qemu-devel] [PATCH 0/5] QOM'ify hw/display devices

2016-03-24 Thread xiaoqiang zhao
This patch set trys to QOM'ify hw/display files, see commit messages for more details xiaoqiang zhao (5): hw/display: QOM'ify exynos4210_fimd.c hw/display: QOM'ify jazz_led.c hw/display: QOM'ify milkymist-tmu2.c hw/display: QOM'ify milkymist-vgafb.c hw/display: QOM'ify pl110.c hw/displ

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Alex Bligh
On 24 Mar 2016, at 09:33, Wouter Verhelst wrote: > Now I'm not saying we > need to fully define what it means for a part of the backend to be > "dirty" or not. It's okay to leave part of the meaning in the dark, > leaving that implementation-defined. Well, the 3 possible states are: * unalloc

[Qemu-devel] [PATCH 5/6] hw/display/milkymist-vgafb.c

2016-03-24 Thread xiaoqiang zhao
--- hw/display/milkymist-vgafb.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/display/milkymist-vgafb.c b/hw/display/milkymist-vgafb.c index 19ca256..cc1245e 100644 --- a/hw/display/milkymist-vgafb.c +++ b/hw/display/milkymist-vgafb.c @@ -292,17 +292,16 @@ stat

[Qemu-devel] [PATCH 0/8] tcg: Direct block chaining clean-up

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov This series combines a set of patches which is meant to improve overall code structure and readability of direct block chaining mechanism. The other point is to make a step towards thread safety of TB chainig. The series' tree can be found in a public git repository [1]. [1

[Qemu-devel] [PATCH 1/8] tcg: Clean up direct block chaining data fields

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Briefly describe in a comment how direct block chaining is done. It should help in understanding of the following data fields. Rename some fields in TranslationBlock and TCGContext structures to better reflect their purpose (dropping excessive 'tb_' prefix in TranslationBloc

[Qemu-devel] [PATCH 6/8] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list()

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov tb_jmp_remove() was only used to remove the TB from a list of all TBs jumping to the same TB which is n-th jump destination of the given TB. Put a comment briefly describing the function behavior and rename it to better reflect its purpose. Signed-off-by: Sergey Fedorov Sig

[Qemu-devel] [PATCH 7/8] tcg: Extract removing of jumps to TB from tb_phys_invalidate()

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Move the code for removing jumps to a TB out of tb_phys_invalidate() to a separate static inline function tb_jmp_unlink(). This simplifies tb_phys_invalidate() and improves code structure. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- translate-all.c | 4

[Qemu-devel] [PATCH 5/8] tcg: Clarify "thread safaty" check in tb_add_jump()

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov The check does not give an absolute guarantee of thread safety because there still may be a race condition between two threads which both have just read zero from jmp_list_next[n] and proceed with list modification. Clarify this in the comment to attract here some attention.

[Qemu-devel] [PATCH 2/8] tcg: Use uintptr_t type for jmp_list_{next|first} fields of TB

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov These fields do not contain pure pointers to a TranslationBlock structure. So uintptr_t is the most appropriate type for them. Also put an assert to assure that the two least significant bits of the pointer are zero before assigning it to jmp_list_first. Signed-off-by: Serge

[Qemu-devel] [PATCH 4/8] tcg: Init TB's direct jumps before making it visible

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Initialize TB's direct jump list data fields and reset the jumps before tb_link_page() puts it into the physical hash table and the physical page list. So TB is completely initialized before it becomes visible. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --

[Qemu-devel] [PATCH 3/8] tcg: Rearrange tb_link_page() to avoid forward declaration

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- translate-all.c | 204 1 file changed, 101 insertions(+), 103 deletions(-) diff --git a/translate-all.c b/translate-all.c index 7c008927e3f3..ca01dd325

[Qemu-devel] [PATCH 8/8] tcg: Clean up tb_jmp_unlink()

2016-03-24 Thread sergey . fedorov
From: Sergey Fedorov Unify the code of this function with tb_jmp_remove_from_list(). Making these functions similar improves their readability. Also this could be a step towards making this function thread-safe. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- translate-all.c |

Re: [Qemu-devel] [PATCH v4 1/6] ARM: Factor out ARM on/off PSCI control functions

2016-03-24 Thread Peter Maydell
On 24 March 2016 at 07:10, Jean-Christophe DUBOIS wrote: > Le 23/03/2016 16:24, Peter Maydell a écrit : >> >> On 19 March 2016 at 20:59, Jean-Christophe Dubois >> wrote: >>> + >>> +/* >>> + * The newly brought CPU is requested to enter the exception level >>> + * "target_el" and be in

[Qemu-devel] tcg/ppc: maintainer's mail delivery failure

2016-03-24 Thread Sergey Fedorov
Hi Peter, Probably we don't have a maintainer for PPC TCG backend. PPC M: Vassili Karpov (malc) S: Maintained F: tcg/ppc/ F: disas/ppc.c Kind regards, Sergey Forwarded Message Subject:Delivery Status Notification (Failure) Date: Thu, 24 Mar 2016

[Qemu-devel] [PATCH 1/2] memory: remove unnecessary masking of MemoryRegion ram_addr

2016-03-24 Thread Paolo Bonzini
mr->ram_block->offset is already aligned to both host and target size (see qemu_ram_alloc_internal). Remove further masking as it is unnecessary. Signed-off-by: Paolo Bonzini --- exec.c | 21 +++-- memory.c | 5 ++--- migration/savevm.c | 4 ++-- translat

[Qemu-devel] [PATCH 2/2] memory: hide mr->ram_addr from qemu_get_ram_ptr users

2016-03-24 Thread Paolo Bonzini
Let users of qemu_get_ram_ptr and qemu_ram_ptr_length pass in an address that is relative to the MemoryRegion. This basically means what address_space_translate returns. invalidate_and_set_dirty has to add back mr->ram_addr, but reads do not need it at all. Signed-off-by: Paolo Bonzini --- exe

[Qemu-devel] [PATCH 0/2] memory: cleanup users of memory_region_get_ram_addr

2016-03-24 Thread Paolo Bonzini
The result of memory_region_get_ram_addr is often added in the caller of qemu_get_ram_ptr and then subtracted in qemu_get_ram_ptr; avoid the indirection. Prompted by mst's remark on confusion between hwaddr and ram_addr_t. Paolo Paolo Bonzini (2): memory: remove unnecessary masking of MemoryRe

Re: [Qemu-devel] [PATCH 1/4] adb.c: add support for QKeyCode

2016-03-24 Thread Peter Maydell
On 24 March 2016 at 01:16, Programmingkid wrote: > The old pc scancode translation is replaced with QEMU's QKeyCode. > > Signed-off-by: John Arbuckle > --- > hw/input/adb.c | 222 > + > 1 file changed, 176 insertions(+), 46 deletions(-) >

Re: [Qemu-devel] tcg/ppc: maintainer's mail delivery failure

2016-03-24 Thread Peter Maydell
On 24 March 2016 at 10:55, Sergey Fedorov wrote: > Hi Peter, > > Probably we don't have a maintainer for PPC TCG backend. > > PPC > M: Vassili Karpov (malc) > S: Maintained > F: tcg/ppc/ > F: disas/ppc.c Yes, malc has not been with the project for some years now. We should pr

Re: [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastructure

2016-03-24 Thread Michael S. Tsirkin
On Thu, Mar 17, 2016 at 11:01:28AM +0100, Cornelia Huck wrote: > Introduce a set of ioeventfd callbacks on the virtio-bus level > that can be implemented by the individual transports. At the > virtio-bus level, do common handling for host notifiers (which > is actually most of it). > > Two things

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 10:24, Pavel Butsykin wrote: >> For extra points, make ide_handle_rw_error convert IDE_DMA_* to >> IDE_RETRY_* so that the callers only need to pass in IDE_RETRY_DMA >> > You mean to do something like that: > > ide_handle_rw_error(s, -ret, s->dma_cmd | IDE_RETRY_DMA) Just ide_hand

Re: [Qemu-devel] [PATCH] qdev property: cleanup

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 11:14, Cao jin wrote: > include: > 1. remove unnecessary declaration of static function > 2. fix inconsistency between comment and function name, and typo OOM->QOM > 2. update comment of function > > Signed-off-by: Cao jin > --- > A question about legacy property: I don`t see lega

Re: [Qemu-devel] [PATCH RFC 1/6] virtio-bus: common ioeventfd infrastructure

2016-03-24 Thread Cornelia Huck
On Thu, 24 Mar 2016 13:20:34 +0200 "Michael S. Tsirkin" wrote: > On Thu, Mar 17, 2016 at 11:01:28AM +0100, Cornelia Huck wrote: > > Introduce a set of ioeventfd callbacks on the virtio-bus level > > that can be implemented by the individual transports. At the > > virtio-bus level, do common handl

Re: [Qemu-devel] [PATCH 5/8] tcg: Clarify "thread safaty" check in tb_add_jump()

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 11:39, sergey.fedo...@linaro.org wrote: > +/* FIXME: This test provides only some probablistic "thread safety" for > + * user-mode emulation; appropriate synchronization/locking scheme should > + * be implemented. > + */ There is appropriate locking. This code:

Re: [Qemu-devel] [PATCH 0/8] tcg: Direct block chaining clean-up

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 11:39, sergey.fedo...@linaro.org wrote: > From: Sergey Fedorov > > This series combines a set of patches which is meant to improve overall code > structure and readability of direct block chaining mechanism. The other point > is to make a step towards thread safety of TB chainig.

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-03-24 Thread Paolo Bonzini
On 23/03/2016 22:32, Dominik Dingel wrote: > -page_size = qemu_fd_getpagesize(fd); > -block->mr->align = page_size; > +alignment = MAX(qemu_fd_getpagesize(fd), QEMU_VMALLOC_ALIGN); > +block->mr->align = alignment; > > -if (memory < page_size) { > +if (memory < alignment)

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Pavel Borzenkov
On Thu, Mar 24, 2016 at 09:26:41AM +0100, Wouter Verhelst wrote: > On Thu, Mar 24, 2016 at 10:57:06AM +0300, Pavel Borzenkov wrote: > > On Wed, Mar 23, 2016 at 06:21:16PM +0100, Wouter Verhelst wrote: > > > So, the semantics of your proposed WRITE_ZEROES are exactly the same as > > > the WRITE comm

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Pavel Borzenkov
On Thu, Mar 24, 2016 at 09:41:29AM +0100, Wouter Verhelst wrote: > On Thu, Mar 24, 2016 at 11:25:52AM +0300, Pavel Borzenkov wrote: > > On Wed, Mar 23, 2016 at 07:14:54PM +0100, Kevin Wolf wrote: > > > Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben: > > > > On Wed, Mar 23, 2016 at 05:16:02P

Re: [Qemu-devel] [Nbd] [PATCH 1/2] NBD proto: add WRITE_ZEROES extension

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 09:26, Wouter Verhelst wrote: >> > >> > No, there is no specific reason. Looks like NBD_CMD_FLAG_ZEROES fits the >> > spec and implementations nicely. So I'll rewrite the extension and add >> > the flag instead of the whole command. > Actually, having given this some more thought..

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Paolo Bonzini
On 23/03/2016 18:58, Wouter Verhelst wrote: >> +To provide such class of information, `GET_LBA_STATUS` extension adds new >> +`NBD_CMD_GET_LBA_STATUS` command which returns a list of LBA ranges with >> +their respective states. >> + >> +* `NBD_CMD_GET_LBA_STATUS` (7) >> + >> +An LBA range sta

Re: [Qemu-devel] [PATCH v5 6/7] replay: fix error message

2016-03-24 Thread Kevin Wolf
Am 14.03.2016 um 08:45 hat Pavel Dovgalyuk geschrieben: > This patch fixes error message in saving loop of the asynchronous events > queue. > > Signed-off-by: Pavel Dovgalyuk > --- > replay/replay-events.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/replay/re

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Paolo Bonzini
On 24/03/2016 11:32, Alex Bligh wrote: >> > Now I'm not saying we >> > need to fully define what it means for a part of the backend to be >> > "dirty" or not. It's okay to leave part of the meaning in the dark, >> > leaving that implementation-defined. > Well, the 3 possible states are: > > * u

Re: [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions

2016-03-24 Thread Kevin Wolf
Am 14.03.2016 um 08:44 hat Pavel Dovgalyuk geschrieben: > This set of patches is related to the reverse execution and deterministic > replay of qemu execution. It includes recording and replaying of serial > devices > and block devices operations. > > With these patches one can record and determ

Re: [Qemu-devel] [PULL v2 00/29] Misc patches for QEMU 2.6 hard freeze

2016-03-24 Thread Peter Maydell
On 22 March 2016 at 21:55, Paolo Bonzini wrote: > The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' > into staging (2016-03-18 17:18:41 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets

2016-03-24 Thread Alex Bennée
Sergey Fedorov writes: > On 23/03/16 20:20, Alex Bennée wrote: >> diff --git a/configure b/configure >> index b88d0db..ebf8a42 100755 >> --- a/configure >> +++ b/configure >> @@ -1246,7 +1246,8 @@ Standard options: >>--target-list=LIST set target list (default: build everything) >> $(

Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets

2016-03-24 Thread Sergey Fedorov
On 24/03/16 15:05, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 23/03/16 20:20, Alex Bennée wrote: >>> diff --git a/configure b/configure >>> index b88d0db..ebf8a42 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -1246,7 +1246,8 @@ Standard options: >>>--target-list=LIST set

Re: [Qemu-devel] [Nbd] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension

2016-03-24 Thread Alex Bligh
On 24 Mar 2016, at 11:58, Paolo Bonzini wrote: > > On 24/03/2016 11:32, Alex Bligh wrote: Now I'm not saying we need to fully define what it means for a part of the backend to be "dirty" or not. It's okay to leave part of the meaning in the dark, leaving that implementation

  1   2   3   4   >