> Hi, Liang
>
> This is a very clear documentation of your work, I appreciated it a lot. Below
> are some of my personal opinion and question.
>
Thanks for your comments!
> On Tue, Mar 22, 2016 at 03:43:49PM +0800, Liang Li wrote:
> >I have sent the RFC version patch set for live migration opti
On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
From: Wen Congyang
Introduce a "xen-load-devices-state" QAPI command that can be used to
load the state of all devices, but not the RAM or the block devices of
the VM.
We only have hmp com
The error paths after a successful qdev_create/pci_bus_new
should contain a object_unref/object_unparent.
pxb_dev_init_common() did not yet, so add it.
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 8 +++-
1 file changed, 7 insertions(+), 1 del
Firstly, convert pxb_dev_init_common() to Error and rename
it to pxb_dev_realize_common().
Actually, pxb_register_bus() is converted as well.
And then,
convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error,
rename them to pxb_dev_realize() and pxb_pcie_dev_realize()
respectively.
Signed-off
v1 -> v2:
- Extract a separate bugfix patch
- Squash v1 patches 1-3 together
- Drop the period and exclamation mark
- Modify commit message
v1: cover-letter
The original patch named '[PATCH v3] PXB: convert to realize()'
was raised by Cao jin ,
and reviewed by Marcel Apfelbaum .
It conflicts w
On 03/23/2016 03:26 PM, Wei Jiangang wrote:
-static int pxb_dev_init_common(PCIDevice *dev, bool pcie)
+static void pxb_dev_realize_common(PCIDevice *dev, bool pcie, Error **errp)
{
PXBDev *pxb = convert_to_pxb(dev);
DeviceState *ds, *bds = NULL;
PCIBus *bus;
const c
From: Marcin Krzeminski
This patch adds only 4byte address mode (does not cover dummy cycles).
This mode is needed to access more than 16 MiB of flash.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 43 +--
1 fil
From: Marcin Krzeminski
Extend the width of the flags variable to support the already existing
(but unused) WR_1 flag, which is above the range of 8 bits.
This allows support of EEPROM emulation which requires the WR_1 feature.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
--
From: Marcin Krzeminski
V6: Currected VMSTATE entries to proper handle migration
(*_V fields are used)
V5: Changes after review
- Macrofication of registers values
- Numonyx is default value in switch for fast read family
V4:
- Fixed RNVCR command (needed bytes set to 2 instead of 1)
- Config reg
From: Marcin Krzeminski
Extend address mode allows to switch flash 16 MiB banks,
allowing user to access all flash sectors.
This access mode is used by u-boot.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
# Conflicts:
# hw/block/m25p80.c
---
hw/block/m25p80.c | 27 ++
From: Marcin Krzeminski
This patch adds both volatile and non volatile configuration registers
and commands to allow modify them. It is needed for proper handling
dummy cycles. Initialization of those registers and flash state
has been included as well.
Some of this registers are used by kernel.
From: Marcin Krzeminski
Use the setting from the volatile cfg register to correctly
set the number of dummy cycles.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/bloc
From: Marcin Krzeminski
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 124..ad91e70 100644
--- a/
From: Marcin Krzeminski
Implements FSR register, it is used for busy waits.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 1e615ca..479d4c5 1
From: Marcin Krzeminski
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index de24f42..124 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -246,8 +246,
From: Marcin Krzeminski
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 479d4c5..bdd87fa 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.
From: Marcin Krzeminski
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index bdd87fa..906b712 100644
--- a/hw/block/m25p80.c
+++ b/h
From: Marcin Krzeminski
Adds fast read and 4bytes commands family.
This work is based on Pawel Lenkow patch from v1.
Signed-off-by: Marcin Krzeminski
Reviewed-by: Peter Crosthwaite
---
hw/block/m25p80.c | 50 ++
1 file changed, 46 insertions(+),
On Tue, 22 Mar 2016 17:35:18 -0500
Michael Roth wrote:
> Quoting Greg Kurz (2016-03-22 02:49:35)
> > On Mon, 21 Mar 2016 12:28:26 -0500
> > Michael Roth wrote:
> >
> > > From: Greg Kurz
> > >
> > > Since QEMU 2.4, we have a configuration section in the migration stream.
> > > This must be s
On 23.03.2016 01:14, John Snow wrote:
>
> On 03/22/2016 03:41 AM, Isaac Lozano wrote:
>> qemu_hexdump() in util/hexdump.c has been changed to give also include a
>> ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have
>> been replaced with calls to qemu_hexdump(). This takes care
On Tue, 22 Mar 2016 19:05:09 +0100
Paolo Bonzini wrote:
> On 22/03/2016 13:52, Fam Zheng wrote:
> >> You're right. After unrealizing virtio_blk_data_plane_stop has set of
> >> vblk->dataplane_started = false, so that's covered. However, you still
> >> need an object_ref/object_object_unref pair
Hi Isaac,
thanks for taking care of this!
Comments below...
On 22.03.2016 08:41, Isaac Lozano wrote:
> qemu_hexdump() in util/hexdump.c has been changed to give also include a
> ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have
> been replaced with calls to qemu_hexdump(). Th
Cao jin writes:
> On 03/02/2016 05:13 PM, Markus Armbruster wrote:
>> This got lost over the Christmas break, sorry.
>>
>> Cc'ing Marcel for additional PCI expertise.
>>
>> Cao jin writes:
>>
>>> msi_init() is a supporting function in PCI device initialization,
>>> in order to convert .init() to
Tested with 1:2.2+dfsg-5expubuntu9.7~cloud2, and the fix works for me.
** Tags removed: verification-kilo-needed
** Tags added: verification-kilo-done
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/15
On 03/22/2016 09:15 PM, Peter Maydell wrote:
> On 22 March 2016 at 13:46, Bastian Koppelmann
> wrote:
>> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>>
>> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18'
>> into staging (2016-03-18 17:18:4
On 22.03.2016 21:49, Eric Blake wrote:
On 03/15/2016 02:04 PM, Vladimir Sementsov-Ogievskiy wrote:
This function stores block dirty bitmap to qcow2. If the bitmap with
the same name, size and granularity already exists, it will be
rewritten, if the bitmap with the same name exists but granularit
On 22.03.2016 21:27, Eric Blake wrote:
On 03/15/2016 02:04 PM, Vladimir Sementsov-Ogievskiy wrote:
Add simple test cases for testing persistent dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/160| 112 ++
test
Hi,
All.
I hope to work on the project, Jailhouse during the GSOC 2016
I have shared my proposal draft with Qemu, on the GSoc website.
I will be very glad to receive any kind of feedback from the
organization.
Enthusiastically awaiting to work on the project!!
Hi,
since i got no answer on the qemu-discuss mailing list, i post it here
maybe someone can help me or point me in the right direction
(copy-pasted from my previous mail)
Hi,
I have a strange issue with qemu-img convert which corrupts my images,
and found nothing relevant online.
Maybe someo
stream.git
tags/pull-tricore-20160323
for you to fetch changes up to 0d4c3b8010320a8ebb4061d88510e082b06ed2cc:
target-tricore: Add ftoi and itof instructions (2016-03-23 09:22:48 +0100)
TriCore FPU
This patch adds a file for all the FPU related helpers with all the includes,
useful defines, and a function to update the status bits. Additionally it adds
a mask for the rounding mode bits of PSW as well as all the opcodes for the
FPU instructions.
Reviewed-by: Richard Henderson
Signed-off-by:
Paolo Bonzini writes:
> On 21/03/2016 18:19, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 21/03/2016 16:13, Markus Armbruster wrote:
Before your patch, we leave finalization of the property to its
release() callback release_drive(), as we should. All we do here is
Paolo Bonzini writes:
> On 21/03/2016 18:39, Kevin Wolf wrote:
>> > When I wrote my review, I forgot that I expect x-blockdev-del to accept
>> > only backends created with blockdev-add. With that, my question is
>> > indeed moot.
>> >
>> > However, I've now tested my expectation, and it turned
On Wed, 2016-03-23 at 13:32 +0800, Peter Xu wrote:
> v6 changes:
> - patch 1 (squashed into patch 2)
> - explain more about the following in commit message: why we need
> this command, and what does the entries mean [Markus]
> - explain what GIC is [Eric]
> - squash this patch into patch
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
> >* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> >>From: Wen Congyang
> >>
> >>Introduce a "xen-load-devices-state" QAPI command that can be used to
> >>load the state of all devices,
On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote:
> * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
>> On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
>>> * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
From: Wen Congyang
Introduce a "xen-load-devices-state" QAPI com
Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben:
> On 22/03/2016 16:33, Kevin Wolf wrote:
> > This is another feature that was "logically" part of the BlockBackend, but
> > implemented as a BlockDriverState feature. It was always kept on top using
> > swap_feature_fields().
> >
> > This serie
On 03/18/2016 03:21 PM, Cornelia Huck wrote:
> A final round of patches for the s390-ccw bios that allow us to
> boot from virtio-scsi devices. They have been through our internal
> testing for some months now (so they should be stable), but I can
> only send them now due to factors beyond our cont
On 23/03/2016 09:10, Cornelia Huck wrote:
>> -/* Kick right away to begin processing requests already in vring */
>> -event_notifier_set(virtio_queue_get_host_notifier(s->vq));
>> +vblk->dataplane_started = true;
>>
>> -/* Get this show started by hooking up our callbacks */
>> +
Am 22.03.2016 um 22:53 hat Eric Blake geschrieben:
> On 03/22/2016 09:33 AM, Kevin Wolf wrote:
> > Some features, like I/O throttling, are implemented outside
> > block-backend.c, but still want to keep BlockBackends in a list. In
> > order to avoid exposing the whole struct layout in the public he
On 03/23/2016 10:08 AM, Paolo Bonzini wrote:
>
>
> On 23/03/2016 09:10, Cornelia Huck wrote:
>>> -/* Kick right away to begin processing requests already in vring */
>>> -event_notifier_set(virtio_queue_get_host_notifier(s->vq));
>>> +vblk->dataplane_started = true;
>>>
>>> -/* Ge
On Wed, Mar 23, 2016 at 09:54:03AM +0100, Andrea Bolognani wrote:
> On Wed, 2016-03-23 at 13:32 +0800, Peter Xu wrote:
> > v6 changes:
> > - patch 1 (squashed into patch 2)
> > - explain more about the following in commit message: why we need
> > this command, and what does the entries mean [
Paolo Bonzini writes:
> On 22/03/2016 11:25, Markus Armbruster wrote:
>> Regardless of how and when we create BlockBackend, we'll want to keep
>> the clean separation between frontend and backend internally and at the
>> user interface.
>
> This means that the BlockBackend should not own the Driv
Hi Alex,
Thanks for having pulling all that together!
About this patch the original author was Jan Kiszka
(https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03323.html)
This has probably been dropped during a rebase.
Thanks,
Fred
Le 18/03/2016 17:18, Alex Bennée a écrit :
From: KONRA
On 03/23/2016 04:12 PM, Markus Armbruster wrote:
Cao jin writes:
Really appreciate your review, I just finished reading all the
comments and discussion.
Seems pci_add_capability2()(commit cd9aa33e introduced) doesn`t follow
the new error reporting rule(report error while also return erro
On 23/03/2016 10:03, Kevin Wolf wrote:
> Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben:
>> On 22/03/2016 16:33, Kevin Wolf wrote:
>>> This is another feature that was "logically" part of the BlockBackend, but
>>> implemented as a BlockDriverState feature. It was always kept on top using
>>
Peter Xu writes:
> On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote:
>> Markus Armbruster writes:
>> >> +##
>> >> +# @GICCapability:
>> >> +#
>> >> +# This struct describes capability for a specific GIC version. These
>> >> +# bits are not only decided by QEMU/KVM software versi
On Thu, 03/17 11:01, Cornelia Huck wrote:
> As discussed in the virtio-blk dataplane start/stop thread, the
> various transports contain a lot of similar/identical boilerplate
> code for setting up ioeventfds. This makes the code hard to follow.
>
> Let's drag all of the common handling into the v
On 23/03/2016 09:35, Markus Armbruster wrote:
>> by that time you don't have anymore a QOM path to include in the event.
>
> I see. To delay DEVICE_DELETED, we'd have to save the QOM path, and
> that would be bothersome.
Not just that, the QOM path goes away at the time we currently raise
DEVIC
On 23/03/2016 10:18, Markus Armbruster wrote:
>> In Kevin's idea there would be no ownership either way. Until then, I
>> think my patch actually gets us closer to the ideal.
>
> I'm afraid it gets us closer to where we used to be six years ago :)
>
> Qdev drive properties used to point to a D
* Wen Congyang (we...@cn.fujitsu.com) wrote:
> On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote:
> > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> >> On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
> >>> * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> From: Wen Congyang
Peter Xu writes:
> On Tue, Mar 22, 2016 at 12:32:28PM -0600, Eric Blake wrote:
>> On 03/17/2016 09:27 PM, Peter Xu wrote:
>> > +##
>> > +# @GICCapability:
>> > +#
>> > +# This struct describes capability for a specific GIC version. These
>>
>> Might be nice to spell out what the acronym GIC mean
On Wed, Mar 23, 2016 at 07:18:57AM +, Li, Liang Z wrote:
>> Hi, Liang
>>
>> This is a very clear documentation of your work, I appreciated it a lot.
>> Below
>> are some of my personal opinion and question.
>>
>
>Thanks for your comments!
>
>> On Tue, Mar 22, 2016 at 03:43:49PM +0800, Liang
Peter Xu writes:
> On Tue, Mar 22, 2016 at 07:28:13PM +0100, Markus Armbruster wrote:
>> Peter Xu writes:
>> > diff --git a/scripts/qapi.py b/scripts/qapi.py
>> > index 6b2aa6e..716474e 100644
>> > --- a/scripts/qapi.py
>> > +++ b/scripts/qapi.py
>> > @@ -46,6 +46,7 @@ returns_whitelist = [
>>
Peter Xu writes:
> On Tue, Mar 22, 2016 at 12:42:42PM -0600, Eric Blake wrote:
>> On 03/17/2016 09:27 PM, Peter Xu wrote:
>> > This patch adds the command "query-gic-capabilities" but not implemnet
>>
>> s/not implemnet/does not implement/
>
> Yep, again. Thanks.
>
>>
>> > it. The command is AR
On 22.03.2016 21:06, Paolo Bonzini wrote:
On 22/03/2016 19:00, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Just a notice
for commit (near to master branch top)
commit 3666a97f78704b941c360dc917acb14c8774eca7
Author: Eric Blake
Date: Thu Mar 17 16:48:40 2016 -0600
qapi: Use anonymous
[ Cc: Stefan ]
Am 23.03.2016 um 10:28 hat Paolo Bonzini geschrieben:
> On 23/03/2016 10:03, Kevin Wolf wrote:
> > Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben:
> >> On 22/03/2016 16:33, Kevin Wolf wrote:
> >>> This is another feature that was "logically" part of the BlockBackend, but
> >>>
On Wed 23 Mar 2016 10:03:41 AM CET, Kevin Wolf wrote:
>> This series would mess up my own I/O throttling cleanups that have
>> been posted in February and have hardly seen a review for one month.
>
> Which cleanups? The ones that you hid in an I/O path locking series?
> Whose v2 didn't even inclu
Samuel Thibault writes:
> Hello,
>
> Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote:
>> > -# @net: #optional IP address and optional netmask
>> > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to
>> > disable IPv4 completely
>>
>> Long line.
>>
>> Syntax? Defa
v2 -> v3:
- Pass local *err to error_setg() in pxb_dev_realize_common()
v1 -> v2:
- Extract a separate bugfix patch
- Squash v1 patches 1-3 together
- Drop the period and exclamation mark
- Modify commit message
v1: cover-letter
The original patch named '[PATCH v3] PXB: convert to realize()'
w
The error paths after a successful qdev_create/pci_bus_new
should contain a object_unref/object_unparent.
pxb_dev_init_common() did not yet, so add it.
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 8 +++-
1 file changed, 7 insertions(+), 1 del
On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote:
* Wen Congyang (we...@cn.fujitsu.com) wrote:
On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote:
* Changlong Xie (xiecl.f...@cn.fuji
From: Chen Fan
For vfio pcie device, we could expose the extended capability on
PCIE bus. due to add a new pcie capability at the tail of the chain,
in order to avoid config space overwritten, we introduce a copy config
for parsing extended caps. and rebuild the pcie extended config space.
Signe
Firstly, convert pxb_dev_init_common() to Error and rename
it to pxb_dev_realize_common().
Actually, pxb_register_bus() is converted as well.
And then,
convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error,
rename them to pxb_dev_realize() and pxb_pcie_dev_realize()
respectively.
---
hw/pci
From: Chen Fan
v4-v5:
1. add back the common function 0 hotplug code in pci core.
2. fix a sporadic device stuck on D3 problem when doing aer recovery.
3. fix patches 5/12 ~ 9/12 as Alex sugguestion.
v3-v4:
1. rebase patchset to fit latest master branch.
2. modifying patches 5/10
From: Chen Fan
Due to all devices assigned to VM on the same way as host if enable
aer, so we can easily do the hot reset by selecting the function #0
to do the hot reset.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 14 ++
hw/vfio/pci.h | 1 +
2 files changed, 15 insertions(+)
di
From: Chen Fan
PCI hotplug requires that function 0 is added last to close the
slot. Since vfio supporting AER, we require that the VM bus
contains the same set of devices as the host bus to support AER,
we can perform an AER validation test whenever a function 0 in
the VM is hot-added.
Signed-
From: Chen Fan
the function is used to get affected devices by bus reset.
so here extract it, and can used for aer soon.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 66 +++
1 file changed, 48 insertions(+), 18 deletions(-)
diff --git a/h
From: Chen Fan
squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 75 +++
1 file changed, 44 insertions(+), 31 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
ind
From: Chen Fan
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, resulting in the qemu eventfd handler getting
invoked.
this patch is to pass the error to guest and let the guest driver
recover from the err
On Sun, Mar 20, 2016 at 12:39:14PM +0100, Samuel Thibault wrote:
> Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can
> setup IPv4-only and IPv6-only network environments.
I really don't like this kind of magic because it is totally invisible
to the user unless they read th
From: Chen Fan
Calling pcie_aer_init to initilize aer related registers for
vfio device, then reload physical related registers to expose
device capability.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 85 ---
hw/vfio/pci.h | 3 +++
2 fil
From: Chen Fan
When assigning a vfio device with AER enabled, we must check whether
the device supports a host bus reset (ie. hot reset) as this may be
used by the guest OS in order to recover the device from an AER
error. QEMU must therefore have the ability to perform a physical
host bus reset
From: Chen Fan
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 0516d94..5b23a86 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2060,14 +2060,27 @@ static void vfio_pci_po
From: Chen Fan
when function 0 is hot-added, we can check the vfio device
whether support hot bus reset.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 939b764..90447ac 100644
--- a/hw/vfio/pci.c
From: Chen Fan
when a physical device aer occurred, the device state probably
is not in D0 in a short time, if we recover the device quickly.
we may stuck in D3 state when force to change device state to D0.
we may need to wait for a short time to inject the error to guest.
Signed-off-by: Chen F
From: Chen Fan
add 'aer' property to let user able to decide whether expose
the aer capability. by default we should disable aer feature,
because it needs configuration restrictions.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/vfio/pci.c b
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> On 03/23/2016 05:41 PM, Dr. David Alan Gilbert wrote:
> >* Wen Congyang (we...@cn.fujitsu.com) wrote:
> >>On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote:
> >>>* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote:
> On 03/22/2016 08:22 PM,
This patch set fixes bugs in the IDE DMA and the IDE ATAPI on operations to
save/restore the state.
>From the user point of view this results in IDE timeouts in the guest
when the user reads from the DVD like the following:
[424332.169229] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6
From: Pavel Butsykin
ide_atapi_dma_restart() used to just complete the DMA with an error,
under the assumption that there isn't enough information to restart it.
However, as the contents of the ->io_buffer is preserved, it looks safe to
just re-evaluate it and dispatch the ATAPI command again.
From: Pavel Butsykin
Restart of ATAPI DMA used to be unreachable, because the request to do
so wasn't indicated in bus->error_status due to the lack of spare bits, and
ide_restart_bh() would return early doing nothing.
This patch makes use of the observation that not all bit combinations were
po
From: Pavel Butsykin
If the migration occurs after the IDE DMA has been set up but before it
has been initiated, the state gets lost upon save/restore. Specifically,
->dma_cb callback gets cleared, so, when the guest eventually starts bus
mastering, the DMA never completes, causing the guest to t
Hi Peter,
Stupid question: The subject says "SMP command". Did you mean "QMP
command" ?
Thanks,
-Christoffer
On Wed, Mar 23, 2016 at 01:32:29PM +0800, Peter Xu wrote:
> v6 changes:
> - patch 1 (squashed into patch 2)
> - explain more about the following in commit message: why we need
> th
Am 16.03.2016 um 15:16 hat Paolo Bonzini geschrieben:
> sheepdog has some calls to aio_poll that are hard to eliminate, for
> example in sd_sheepdog_goto's call to do_req. Since I don't have
> means to test sheepdog well, disable dataplane altogether for this
> driver.
>
> Reviewed-by: Fam Zheng
On 22/03/2016 04:26, David Gibson wrote:
>> > >...it might be simpler to replace both the iommu and
>> > >offset_within_address_space fields here with a pointer to the
>> > >MemoryRegionSection instead, which should give you all the info you
>> > >need.
>>
>>
>> MemoryRegionSection is allocated
On 23/03/2016 11:45, Kevin Wolf wrote:
> I wouldn't feel comfortable about ignoring this second part, but maybe
> we could get away with it if we have a plan how to fix it in the long
> run. The new op blockers should be able to do that, but I guess it will
> be well into the 2.7 development cycl
On Wed, Mar 23, 2016 at 11:32:06AM +0100, Christoffer Dall wrote:
> Hi Peter,
>
> Stupid question: The subject says "SMP command". Did you mean "QMP
> command" ?
It's for sure a good question... My fault. It should be QMP.
Thanks to point out.
-- peterx
On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote:
> >> Markus Armbruster writes:
> >> >> +##
> >> >> +# @GICCapability:
> >> >> +#
> >> >> +# This struct describes capability for a specif
On 23.03.2016 00:49, John Snow wrote:
On 03/15/2016 04:04 PM, Vladimir Sementsov-Ogievskiy wrote:
Add functions for load/store HBitmap to BDS, using clusters table:
Last level of the bitmap is splitted into chunks of 'cluster_size'
size. Each cell of the table contains offset in bds, to load/st
Cao jin writes:
> On 03/23/2016 03:26 PM, Wei Jiangang wrote:
>
>>
>> -static int pxb_dev_init_common(PCIDevice *dev, bool pcie)
>> +static void pxb_dev_realize_common(PCIDevice *dev, bool pcie, Error **errp)
>> {
>> PXBDev *pxb = convert_to_pxb(dev);
>> DeviceState *ds, *bds = NULL
Wei Jiangang writes:
> v1 -> v2:
>
> - Extract a separate bugfix patch
> - Squash v1 patches 1-3 together
> - Drop the period and exclamation mark
> - Modify commit message
>
> v1: cover-letter
>
> The original patch named '[PATCH v3] PXB: convert to realize()'
> was raised by Cao jin ,
> and re
On Wed, Mar 23, 2016 at 10:44:04AM +0100, Markus Armbruster wrote:
> Depends.
>
> The general rule is to keep separate things separate, and patches
> self-contained. The narrow sense of self-contained is each patch
> compiles and works. The wider sense is each patch makes sense to its
> readers
Wei Jiangang writes:
> Firstly, convert pxb_dev_init_common() to Error and rename
> it to pxb_dev_realize_common().
> Actually, pxb_register_bus() is converted as well.
>
> And then,
> convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error,
> rename them to pxb_dev_realize() and pxb_pcie_dev
On Wed, Mar 23, 2016 at 10:52:29AM +0100, Markus Armbruster wrote:
> The rule against returning non-dictionaries exists to avoid interfaces
> that cannot evolve. With a dictionary, you can evolve by adding
> members.
>
> The rule does *not* forbid returning lists of dictionaries. When a
> comman
Paolo Bonzini writes:
> On 23/03/2016 10:18, Markus Armbruster wrote:
>>> In Kevin's idea there would be no ownership either way. Until then, I
>>> think my patch actually gets us closer to the ideal.
>>
>> I'm afraid it gets us closer to where we used to be six years ago :)
>>
>> Qdev drive p
On Fri, Feb 5, 2016 at 6:47 PM, Prasanna Kumar Kalever
wrote:
>
> On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote:
> > Am 12.11.2015 um 23:36 hat Eric Blake geschrieben:
> > > On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote:
> > > > +static struct glfs *qemu_gluster_init(BlockdevOpt
Peter Xu writes:
> On Wed, Mar 23, 2016 at 10:33:09AM +0100, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > On Tue, Mar 22, 2016 at 07:41:17PM +0100, Markus Armbruster wrote:
>> >> Markus Armbruster writes:
>> >> >> +##
>> >> >> +# @GICCapability:
>> >> >> +#
>> >> >> +# This struct desc
On Wed, Mar 23, 2016 at 5:46 PM, Prasanna Kalever wrote:
> On Fri, Feb 5, 2016 at 6:47 PM, Prasanna Kumar Kalever
> wrote:
>>
>> On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote:
>> > Am 12.11.2015 um 23:36 hat Eric Blake geschrieben:
>> > > On 11/12/2015 03:22 AM, Prasanna Kumar Kalever
On 23/03/16 08:32, Peter Xu wrote:
> diff --git a/target-arm/kvm.c b/target-arm/kvm.c
> index 969ab0b..0a7f9a6 100644
> --- a/target-arm/kvm.c
> +++ b/target-arm/kvm.c
> @@ -62,13 +62,17 @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t
> *cpus_to_try,
> goto err;
> }
>
> +
On 23/03/16 08:32, Peter Xu wrote:
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index 6695fa7..8738fa1 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -306,6 +306,15 @@ void kvm_device_access(int fd, int group, uint64_t attr,
> */
> int kvm_create_device(KVM
1 - 100 of 243 matches
Mail list logo
