Re: [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 12:16, Peter Maydell wrote: >> > Using uint32_t is enough and avoids the need to include ioport.h >> > everywhere. >> > >> > Signed-off-by: Paolo Bonzini > I'm not hugely convinced by this patch -- I think it's nice > to have a typedef that indicates that you're dealing with an >

[Qemu-devel] [PATCH v4 10/17] blockdev: Split monitor reference from BB creation

2016-03-19 Thread Max Reitz
Before this patch, blk_new() automatically assigned a name to the new BlockBackend and considered it referenced by the monitor. This patch removes the implicit monitor_add_blk() call from blk_new() (and consequently the monitor_remove_blk() call from blk_delete(), too) and thus blk_new() (and relat

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-19 Thread Jaya Tiwari
On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini wrote: > > > On 18/03/2016 12:24, Pooja Dhannawat wrote: > > > > > > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > > wrote: > > > > > > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > > > >

[Qemu-devel] [PATCH v6 01/16] qapi: Assert in places where variants are not handled

2016-03-19 Thread Eric Blake
We are getting closer to the point where we could use one union as the base or variant type within another union type (as long as there are no collisions between any possible combination of member names allowed across all discriminator choices). But until we get to that point, it is worth assertin

[Qemu-devel] [PULL 22/40] ivshmem: Simplify rejection of invalid peer ID from server

2016-03-19 Thread Markus Armbruster
ivshmem_read() processes server messages. These are 64 bit signed integers. -1 is shared memory setup, 16 bit unsigned is a peer ID, anything else is invalid. ivshmem_read() rejects invalid negative messages right away, silently. Invalid positive messages get rejected only in resize_peers(), an

[Qemu-devel] [RFC] Use cpu_get_icount as cpu_get_host_ticks fallback

2016-03-19 Thread Christopher Covington
The previous increment-on-read fallback didn't increment fast enough for some versions of grub. https://bugs.launchpad.net/qemu-linaro/+bug/893208 Signed-off-by: Christopher Covington --- I unfortunately don't have the opportunity to fully test this right now, but I'm sending it out nevertheless

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Cornelia Huck
On Wed, 16 Mar 2016 14:10:29 +0100 Paolo Bonzini wrote: > On 16/03/2016 14:04, Cornelia Huck wrote: > > > No, it would not. ioeventfd=off,vhost=on would mean: "when vhost is > > > off, use vCPU thread notification". > > > > *confused* > > > > Is ioeventfd=off supposed to mean "don't talk to th

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/bcm2836: Wire up CPU timer interrupts correctly

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 13:37, Thomas Hanson wrote: > > On Mar 17, 2016 4:33 AM, "Peter Maydell" wrote: >> >> Wire up the CPU timer interrupts in the right order, with the >> nonsecure physical timer on cntpnsirq, the hyp timer on cnthpirq, >> and the secure physical timer on cntpsirq. (We did get th

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-19 Thread Paolo Bonzini
On 18/03/2016 14:49, Pooja Dhannawat wrote: > > > If it is greater than the accepted level, the on-stack > buffer is not > used and you allocate one that has the right size on the heap. > > Yes Okay. Thank you for the comments. > I had one mo

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Cornelia Huck
On Wed, 16 Mar 2016 12:59:37 +0100 Paolo Bonzini wrote: > On 16/03/2016 12:56, Cornelia Huck wrote: > > On Wed, 16 Mar 2016 12:48:22 +0100 > > Paolo Bonzini wrote: > > > >> > >> > >> On 16/03/2016 12:32, Cornelia Huck wrote: > >>> On Wed, 16 Mar 2016 12:09:02 +0100 > >>> Paolo Bonzini wrote: >

[Qemu-devel] [PULL 04/29] block: Use blk_next() in block-backend.c

2016-03-19 Thread Kevin Wolf
From: Max Reitz Instead of iterating directly through blk_backends, we can use blk_next() instead. This gives us some abstraction from the list itself which we can use to rename it, for example. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/block-backend.c | 12 ++-- 1

[Qemu-devel] [PULL 24/40] ivshmem: Plug leaks on unplug, fix peer disconnect

2016-03-19 Thread Markus Armbruster
close_peer_eventfds() cleans up three things: ioeventfd triggers if they exist, eventfds, and the array to store them. Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers when they don't exist (property ioeventfd=off, which is the default). Unfortunately, the fix also made it skip

[Qemu-devel] [Bug 1558175] Re: virtio: vm killed (Guest moved used index)

2016-03-19 Thread Laszlo Ersek (Red Hat)
(Bugfix for a similar SeaBIOS bug: 5f2d17d35b23.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1558175 Title: virtio: vm killed (Guest moved used index) Status in QEMU: New Bug description:

[Qemu-devel] [RFC v1 05/11] target-arm/psci.c: wake up sleeping CPUs

2016-03-19 Thread Alex Bennée
Testing with Alexander's bare metal syncronisation tests fails in MTTCG leaving one CPU spinning forever waiting for the second CPU to wake up. We simply need to poke the halt_cond once we have processed the PSCI power on call. Tested-by: Alex Bennée CC: Alexander Spyridakis Message-Id: <1439220

Re: [Qemu-devel] [PATCH v3 01/40] target-ppc: Document TOCTTOU in hugepage support

2016-03-19 Thread Marc-André Lureau
Hi On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > The code to find the minimum page size is is vulnerable to TOCTTOU. > Added in commit 2d103aa "target-ppc: fix hugepage support when using > memory-backend-file" (v2.4.0). Since I can't fix it myself right now, > add a FIXME comment.

[Qemu-devel] [PATCH 24/49] alpha: include cpu-qom.h in files that require AlphaCPU

2016-03-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/alpha/alpha_sys.h | 1 + hw/alpha/pci.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index e11025b..fcaeb2b 100644 --- a/hw/alpha/alpha_sys.h +++ b/hw/alpha/alpha_sys.h @@ -3,6 +3,7 @@ #i

Re: [Qemu-devel] commit 084a85e breaks build

2016-03-19 Thread Daniel P. Berrange
On Thu, Mar 17, 2016 at 04:25:56PM -0400, Gabriel L. Somlo wrote: > Hi Daniel, > > I get the error below when I try to build QEMU, and bisect claims it > started with commit 084a85e (crypto: add support for the cast5-128 > cipher algorithm). > > Sorry if this is already a known issue. Let me know

[Qemu-devel] [PATCH v4 07/13] docker: Add full test

2016-03-19 Thread Fam Zheng
This builds all available targets. Signed-off-by: Fam Zheng --- tests/docker/test-full | 17 + 1 file changed, 17 insertions(+) create mode 100755 tests/docker/test-full diff --git a/tests/docker/test-full b/tests/docker/test-full new file mode 100755 index 000..fd9b798 ---

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-19 Thread Stefan Hajnoczi
On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > @@ -170,8 +170,8 @@ static void net_socket_send(void *opaque) > s->index = 0; > s->packet_len = 0; > s->nc.link_down = true; > -memset(s->buf, 0, sizeof(s->buf)); This change is unrelated to alloc

[Qemu-devel] [PULL 16/29] block: Add blk_next_root_bs()

2016-03-19 Thread Kevin Wolf
From: Max Reitz This function iterates over all BDSs attached to a BB. We are going to need it when rewriting bdrv_next() so it no longer uses bdrv_states. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/block-backend.c | 24 include/sysemu/block

Re: [Qemu-devel] [Qemu-block] [PATCH 00/16] AioContext fine-grained locking, part 1 of 3, including bdrv_drain rewrite

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 14:44, Stefan Hajnoczi wrote: > > For example, each part will probably have an uncontroversial and > > generally useful prefix---for example patches 1-4 in this case, or the > > change to a single linux-aio context per iothread. You could merge > > those only, and for the rest, I w

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 13:22, Cornelia Huck wrote: >> > Yeah, it doesn't help that the functions are underdocumented (as in the >> > "assign" parameter above). > My understanding is: > > - 'assign': set up a new notifier (true) or disable it (false) > - 'set_handler': use our handler (true) or have it ha

Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list

2016-03-19 Thread Michael S. Tsirkin
On Wed, Mar 16, 2016 at 10:21:07AM -0500, Corey Minyard wrote: > On 03/15/2016 12:01 PM, Michael S. Tsirkin wrote: > >On Tue, Mar 15, 2016 at 11:36:39AM -0500, Corey Minyard wrote: > > > >>I've hit a bit of a snag here. For 0.11 and before, PCI option ROMs > >>were loaded via fw_cfg, not in the PC

Re: [Qemu-devel] [PATCH v3 0/5] Raspberry Pi framebuffer, DMA and Windows support

2016-03-19 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, 16 March 2016 9:54 AM > > On 8 March 2016 at 20:05, Andrew Baumann > wrote: > > This patch series adds support for the AUX (second UART), framebuffer > > and DMA controller on Raspberry Pi 2, and enables booting Windows on

Re: [Qemu-devel] [PATCH v2 4/5] spapr: check if cpu core is already present

2016-03-19 Thread Igor Mammedov
On Wed, 16 Mar 2016 10:38:33 +1100 David Gibson wrote: > On Tue, Mar 15, 2016 at 12:05:06PM +0100, Igor Mammedov wrote: > > On Tue, 15 Mar 2016 17:10:27 +1100 > > David Gibson wrote: > > > > > On Thu, Mar 10, 2016 at 11:39:46AM +0100, Igor Mammedov wrote: > > > > On Thu, 10 Mar 2016 11:32:4

[Qemu-devel] [PULL v2 09/13] crypto: import an implementation of the XTS cipher mode

2016-03-19 Thread Daniel P. Berrange
The XTS (XEX with tweaked-codebook and ciphertext stealing) cipher mode is commonly used in full disk encryption. There is unfortunately no implementation of it in either libgcrypt or nettle, so we need to provide our own. The libtomcrypt project provides a repository of crypto algorithms under a

Re: [Qemu-devel] [PULL 0/2] Block patches

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 11:08, Stefan Hajnoczi wrote: > The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: > > Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' > into staging (2016-03-17 08:52:58 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable

2016-03-19 Thread Fam Zheng
On Wed, 03/16 15:16, Stefan Hajnoczi wrote: > Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move > channel/transport functionality into wrapper class") stopped using the > local err variable in channel_event_cb(). > > This patch deletes the unused variable. > > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-19 Thread Pooja Dhannawat
On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi wrote: > On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > > @@ -170,8 +170,8 @@ static void net_socket_send(void *opaque) > > s->index = 0; > > s->packet_len = 0; > > s->nc.link_down = true; > > -

Re: [Qemu-devel] [Qemu-block] [PATCH 0/8] block: Introduce common read/write function

2016-03-19 Thread Stefan Hajnoczi
On Tue, Mar 08, 2016 at 01:47:45PM +0100, Kevin Wolf wrote: > BlockBackends support a few different interfaces for reads and writes. Until > now they used to forward the requests directly to the BDS layer, which > implemented wrappers around one central common read/write function that > contained t

[Qemu-devel] [PATCH v2 00/16] AioContext fine-grained locking, part 1 of 3, including bdrv_drain rewrite

2016-03-19 Thread Paolo Bonzini
Now that the current dataplane failure has been isolated to an unwanted reentrancy in virtio, I can post v2 of these patches. Please review, as I would like to get part 2 in QEMU 2.6 as well (I plan to send it out tomorrow, since I hope there will be no comments on this one and I have already test

[Qemu-devel] [PATCH v1 0/2] Fix build problems with nettle < 3.0.0

2016-03-19 Thread Daniel P. Berrange
This series fixes two build problems identified by people using 2.x series of nettle https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04420.html Daniel P. Berrange (2): crypto: add compat cast5_set_key with nettle < 3.0.0 crypto: fix cipher function signature mismatch with nettle

[Qemu-devel] [PATCH v5 7/7] block: drop support for using qcow[2] encryption with system emulators

2016-03-19 Thread Daniel P. Berrange
For a couple of releases we have been warning Encrypted images are deprecated Support for them will be removed in a future release. You can use 'qemu-img convert' to convert your image to an unencrypted one. This warning was issued by system emulators, qemu-img, qemu-nbd and qemu-io. Such a

[Qemu-devel] [PULL 0/2] Block patches

2016-03-19 Thread Stefan Hajnoczi
The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' into staging (2016-03-17 08:52:58 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

[Qemu-devel] [PULL 0/2] Machine Core queue, 2016-03-16

2016-03-19 Thread Eduardo Habkost
The following changes since commit d1f8764099022bc1173f2413331b26d4ff609a0c: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160316-1' into staging (2016-03-16 17:43:37 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/machine-pull

[Qemu-devel] [PULL 2/2] Revert "qed: Implement .bdrv_drain"

2016-03-19 Thread Stefan Hajnoczi
This reverts commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01. Note that commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01 included some unrelated hunks, possibly due to a merge failure or an overlooked squash. This only reverts the qed .bdrv_drain() implementation. The qed .bdrv_drain() implementa

[Qemu-devel] [PATCH v6 02/16] qapi: Fix command with named empty argument type

2016-03-19 Thread Eric Blake
The generator special-cased { 'command':'foo', 'data': {} } to avoid emitting a visitor variable, but failed to see that { 'struct':'NamedEmptyType, 'data': {} } { 'command':'foo', 'data':'NamedEmptyType' } needs the same treatment. There, the generator happily generates a visitor to get no

[Qemu-devel] [PATCH RFC 4/6] virtio-pci: convert to ioeventfd callbacks

2016-03-19 Thread Cornelia Huck
Convert to new interface. Signed-off-by: Cornelia Huck --- hw/virtio/virtio-pci.c | 124 - 1 file changed, 41 insertions(+), 83 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 0dadb66..b5e59c6 100644 --- a/hw/virtio

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 16:00, Stefan Hajnoczi wrote: >> > +data = g_new(VirtIOBlockStartData, 1); >> > +data->vblk = vblk; >> > +data->bh = aio_bh_new(s->ctx, virtio_blk_data_plane_start_bh_cb, >> > data); >> > +qemu_bh_schedule(data->bh); >> > +qemu_mutex_unlock(&s->start_stop_lock);

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

2016-03-19 Thread Paolo Bonzini
On 18/03/2016 12:24, Pooja Dhannawat wrote: > > > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > wrote: > > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-19 Thread Corey Bryant
** Changed in: cloud-archive/kilo Status: New => In Progress ** Changed in: cloud-archive/kilo Assignee: (unassigned) => Liang Chen (cbjchen) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Qemu-devel] [PATCH v2 06/16] block: add BDS field to count in-flight requests

2016-03-19 Thread Paolo Bonzini
Unlike tracked_requests, this field also counts throttled requests, and remains non-zero if an AIO operation needs a BH to be "really" completed. With this change, it is no longer necessary to have a dummy BdrvTrackedRequest for requests that are never serialising, and it is no longer necessary to

[Qemu-devel] [PULL v2 05/13] crypto: skip testing of unsupported cipher algorithms

2016-03-19 Thread Daniel P. Berrange
We don't guarantee that all crypto backends will support all cipher algorithms, so we should skip tests unless the crypto backend indicates support. Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- tests/test-crypto-cipher.c | 4 +++- 1 file changed, 3 inser

Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID

2016-03-19 Thread Marcel Apfelbaum
On 03/15/2016 07:27 PM, Paolo Bonzini wrote: On 13/03/2016 12:40, Marcel Apfelbaum wrote: According to the ACPI spec, each UID must be unique. Use the irq number as UID for GSI links. Suggested-by: Michael S. Tsirkin Signed-off-by: Marcel Apfelbaum This causes a warning from acpi-test. T

[Qemu-devel] [PATCH 2/2] log: move qemu_log_close/qemu_log_flush from header to log.c

2016-03-19 Thread Denis V. Lunev
There is no particular reason to keep these functions in the header. Suggested by Paolo. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- include/qemu/log.h | 22 +- util/log.c | 17 + 2 files changed, 22 insertions(+), 17 dele

Re: [Qemu-devel] [RFC PATCH v2 1/2] spapr: Add DRC count indexed hotplug identifier type

2016-03-19 Thread Michael Roth
Quoting Bharata B Rao (2016-03-14 23:38:55) > Add support for DRC count indexed hotplug ID type which is primarily > needed for memory hot unplug. This type allows for specifying the > number of DRs that should be plugged/unplugged starting from a given > DRC index. > > NOTE: This new hotplug iden

Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-19 Thread David Gibson
On Wed, Mar 16, 2016 at 01:16:50PM +0100, Thomas Huth wrote: > tl;dr: > This patch introduces an alternate way of handling the receive > buffers of the spapr-vlan device, resulting in much better > receive performance for the guest. > > Full story: > One of our testers recently discovered that the

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

2016-03-19 Thread Peter Xu
On Thu, Mar 17, 2016 at 01:17:30PM +0200, Aviv B.D. wrote: [...] > vtd_get_did_dev returns -1 if the device is not mapped to any domain > (generally, the CE is not present). > probably a better interface is to return whether the device has a domain or > not and returns the domain_id via the pointer

[Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model split

2016-03-19 Thread Markus Armbruster
Major issues addressed by this series: * The specification document is incomplete and vague. Rewritten. * When a peer goes away, and its ID gets reused for another one, interrupts don't work. * When configured for interrupts, we receive shared memory from the server some time after realize(

[Qemu-devel] [PATCH for-2.6 03/14] pc-bios/s390-ccw: add utility functions and "export" some others

2016-03-19 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add several utility functions, make IPL_check and IPL_assert generally available, etc. Acked-by: Cornelia Huck Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.h | 18 -- pc-bios/s390-ccw/s39

[Qemu-devel] [PULL 00/15] QAPI patches for 2016-03-18

2016-03-19 Thread Markus Armbruster
The following changes since commit 6741d38ad0f2405a6e999ebc9550801b01aca479: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-03-17 15:59:42 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-03-18 for you to

Re: [Qemu-devel] [PATCH V7 0/2] Introduce filter-redirector

2016-03-19 Thread Jason Wang
On 03/17/2016 04:16 PM, Zhang Chen wrote: > Filter-redirector is a netfilter plugin. > It gives qemu the ability to redirect net packet. > redirector can redirect filter's net packet to outdev. > and redirect indev's packet to filter. > > filter > + >

[Qemu-devel] [PATCH v2 16/16] aio: convert from RFifoLock to QemuRecMutex

2016-03-19 Thread Paolo Bonzini
It is simpler and a bit faster, and QEMU does not need the contention callbacks (and thus the fairness) anymore. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- async.c | 8 ++--- include/block/aio.h | 3 +- include/qemu/rfifolock.h | 54 -

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Michael S. Tsirkin
On Wed, Mar 16, 2016 at 07:35:09PM +0100, Laszlo Ersek wrote: > On 03/16/16 19:15, Gabriel L. Somlo wrote: > > On Wed, 16 Mar 2016 at 18:50:57 +0200, Michael S. Tsirkin wrote: > >> On Wed, Mar 16, 2016 at 05:29:45PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > Al

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Alberto Garcia
On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >> We should have the failure modes documented, and how you'll use it >> after failover etc Without that it's really difficult to tell if this >> naming is right. > > For COLO, children.0 is the real disk, children.1 is replication > driver.

[Qemu-devel] [PATCH 1/1] block: never cancel a streaming job without running stream_complete()

2016-03-19 Thread Alberto Garcia
We need to call stream_complete() in order to do all the necessary clean-ups, even if there's an early failure. At the moment it's only useful to make sure that s->backing_file_str is not leaked, but it will become more important if we introduce support for streaming to any intermediate node. Sign

Re: [Qemu-devel] [PATCH 06/17] ppc: Create cpu_ppc_set_papr() helper

2016-03-19 Thread Cédric Le Goater
On 03/17/2016 03:34 AM, David Gibson wrote: > On Mon, Mar 14, 2016 at 05:56:29PM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> And move the code adjusting the MSR mask and calling kvmppc_set_papr() >> to it. This allows us to add a few more things such as disabling setting >

[Qemu-devel] [PULL v1 09/13] crypto: import an implementation of the XTS cipher mode

2016-03-19 Thread Daniel P. Berrange
The XTS (XEX with tweaked-codebook and ciphertext stealing) cipher mode is commonly used in full disk encryption. There is unfortunately no implementation of it in either libgcrypt or nettle, so we need to provide our own. The libtomcrypt project provides a repository of crypto algorithms under a

[Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR

2016-03-19 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The masks weren't chosen nor applied properly. The architecture specifies that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0. The writes to UAMOR are masked by AMOR for HV=0 Signed-off-by: Benjamin Herrenschmidt [clg: moved gen_spr_amr() proto

[Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt power button

2016-03-19 Thread Shannon Zhao
From: Shannon Zhao There is a problem for power button that it will not work if an early system_powerdown request happens before guest gpio driver loads. Here we add the emulation of gpio_key and use it for ARM virt power button. Shannon Zhao (2): hw/gpio: Add the emulation of gpio_key ARM:

[Qemu-devel] [PULL 2/5] input-linux: fix Coverity warning

2016-03-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 1458129049-12484-1-git-send-email-kra...@redhat.com --- ui/input-linux.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/input-linux.c b/ui/input-linux.c index 59d9348..6ddaa67 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -213,6 +2

[Qemu-devel] [PATCH v4 04/13] docker: Add test runner

2016-03-19 Thread Fam Zheng
It's better to have a launcher for all tests, to make it easier to initialize and manage the environment. If "DEBUG=1" a shell prompt will show up before the test runs. Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/run | 58

Re: [Qemu-devel] [PATCH v5 7/7] block: drop support for using qcow[2] encryption with system emulators

2016-03-19 Thread Kevin Wolf
Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > For a couple of releases we have been warning > > Encrypted images are deprecated > Support for them will be removed in a future release. > You can use 'qemu-img convert' to convert your image to an unencrypted one. > > This warni

[Qemu-devel] [PULL v3 04/13] crypto: add support for anti-forensic split algorithm

2016-03-19 Thread Daniel P. Berrange
The LUKS format specifies an anti-forensic split algorithm which is used to artificially expand the size of the key material on disk. This is an implementation of that algorithm. Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs|

[Qemu-devel] [PULL 11/15] qapi: Drop unused c_null()

2016-03-19 Thread Markus Armbruster
From: Eric Blake Now that we are always bulk-initializing a QAPI C struct to 0 (whether by g_malloc0() or by 'Type arg = {0};'), we no longer have any clients of c_null() in the generator for per-element initialization. This patch is easy enough to revert if we find a use in the future, but in t

Re: [Qemu-devel] [Bug 1558175] Re: virtio: vm killed (Guest moved used index)

2016-03-19 Thread Stefan Hajnoczi
On Thu, Mar 17, 2016 at 03:56:42PM -, Laszlo Ersek (Red Hat) wrote: > Stefan, I too had the same immediate idea upon seeing this bug report. > But, after I skimmed the DPDK code briefly, I think it does reset the > virtio-net device correctly, before it tries to use it. > > Instead, at least b

[Qemu-devel] [PATCH 28/49] explicitly include qom/cpu.h

2016-03-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/acpi/piix4.c | 1 + hw/arm/collie.c | 1 + hw/cpu/a9mpcore.c| 1 + hw/isa/lpc_ich9.c| 1 + include/hw/ppc/openpic.h | 1 + 5 files changed, 5 insertions(+) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 16abdf1..b3e3bb3

[Qemu-devel] [PATCH 1/6] hw/char: QOM'ify escc.c

2016-03-19 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/char/escc.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/char/escc.c b/hw/char/escc.c index c7a24ac..370e6b1 100644 --- a/hw/char/escc.c +++ b/hw/char/escc.c @@ -98

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-19 Thread Daniel P. Berrange
On Wed, Mar 16, 2016 at 02:11:31PM +0100, Paolo Bonzini wrote: > > > On 16/03/2016 14:09, Denis V. Lunev wrote: > > really interesting approach with a good place to get in. > > But we will need to modify this a infrastructure a bit. > > Af far as I can see only data from VM to outside world > > i

[Qemu-devel] [PULL 04/15] qapi: Adjust names of implicit types

2016-03-19 Thread Markus Armbruster
From: Eric Blake The original choice of ':obj-' as the prefix for implicit types made it obvious that we weren't going to clash with any user-defined names, which cannot contain ':'. But now we want to create structs for implicit types, to get rid of special cases in the generators, and our use

[Qemu-devel] [PULL 08/21] i.MX: Remove CCM useless clock computation handling.

2016-03-19 Thread Peter Maydell
From: Jean-Christophe Dubois Most clocks supported by the CCM are useless to the qemu framework. Only clocks related to timers (EPIT, GPT, PWM, WATCHDOG, ...) are usefull to QEMU code. Therefore this patch removes clock computation handling for all clocks but: * CLK_NONE, * CLK_IPG, * CLK_32k

[Qemu-devel] [PATCH 0/6] QOM'ify hw/char devices

2016-03-19 Thread xiaoqiang zhao
This patch set trys to QOM'ify hw/char files, see commit messages for more details xiaoqiang zhao (6): hw/char: QOM'ify escc.c hw/char: QOM'ify etraxfs_ser.c hw/char: QOM'ify lm32_juart.c hw/char: QOM'ify lm32_uart.c hw/char: QOM'ify sclpconsole-lm.c hw/char: QOM'ify sclpconsole.c hw

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 07:25 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 03/17/2016 06:07 PM, Alberto Garcia wrote: > >>> On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: > > We should have the failure m

Re: [Qemu-devel] [PATCH v3] Sort the fw_cfg file list

2016-03-19 Thread Corey Minyard
On 03/17/2016 02:58 PM, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:41:45AM -0500, Corey Minyard wrote: On 03/17/2016 11:02 AM, Michael S. Tsirkin wrote: On Wed, Mar 16, 2016 at 01:47:08PM -0500, miny...@acm.org wrote: From: Gerd Hoffmann Entries are inserted in filename order inste

[Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

2016-03-19 Thread Thomas Huth
tl;dr: This patch introduces an alternate way of handling the receive buffers of the spapr-vlan device, resulting in much better receive performance for the guest. Full story: One of our testers recently discovered that the performance of the spapr-vlan device is very poor compared to other NICs,

[Qemu-devel] [PULL v3 06/13] crypto: add support for the cast5-128 cipher algorithm

2016-03-19 Thread Daniel P. Berrange
A new cipher algorithm 'cast-5-128' is defined for the Cast-5 algorithm with 128 bit key size. Smaller key sizes are supported by Cast-5, but nothing in QEMU should use them, so only 128 bit keys are permitted. The nettle and gcrypt cipher backends are updated to support the new cipher and a test

[Qemu-devel] ODP: [PATCH v4 11/11] block: m25p80: at25128a/at25256a models

2016-03-19 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 17.03.2016 o 18:39, Peter Crosthwaite pisze: > On Mon, Feb 22, 2016 at 12:03 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m

[Qemu-devel] CPU topology and hyperthreading

2016-03-19 Thread Mohammed Gamal
Hi All, I have a question regarding the way CPU topology is exposed to the guest. On a 4-core Amazon AWS VM I can see the CPU topology exposed to the guest in the following manner: # lstopo Machine (7480MB) Socket L#0 + L3 L#0 (25MB) L2 L#0 (256KB) + L1d L#0 (32KB) + L1i L#0 (32KB) + Core

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

2016-03-19 Thread Jason Wang
On 03/17/2016 02:18 PM, Wen Congyang wrote: >>> >> +s->state = 0; >>> >> +/* FIXME: do something ? */ > > This needs some thought, but at least reset the fd handler and state > is > needed. >>> >> Maybe we can re

[Qemu-devel] [PULL 09/21] i.MX: Add the CLK_IPG_HIGH clock

2016-03-19 Thread Peter Maydell
From: Jean-Christophe Dubois EPIT, GPT and other i.MX timers are using "abstract" clocks among which a CLK_IPG_HIGH clock. On i.MX25 and i.MX31 CLK_IPG and CLK_IPG_HIGH are mapped to the same clock but on other SOC like i.MX6 they are mapped to distinct clocks. This patch add the CLK_IPG_HIGH t

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

2016-03-19 Thread Gerd Hoffmann
On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote: > Currently, virgl support has to go through a local unix socket, trying > to connect to a VM using -spice gl through spice://localhost:5900 will > only result in a black screen. > This commit errors out when the user tries to start a VM w

[Qemu-devel] [PULL v2 12/13] crypto: add block encryption framework

2016-03-19 Thread Daniel P. Berrange
Add a generic framework for supporting different block encryption formats. Upon instantiating a QCryptoBlock object, it will read the encryption header and extract the encryption keys. It is then possible to call methods to encrypt/decrypt data buffers. There is also a mode whereby it will create/

Re: [Qemu-devel] Request for help with Qemu GDB for big-endian instructions (R4)

2016-03-19 Thread Peter Maydell
On 16 March 2016 at 10:06, Paul, Kaustav Kumar wrote: > The firmware is compiled for Cortex-R4, runs ThreadX OS and is configured to > use both instructions and data in big-endian (BE32 ?) format. The Cortex-R4 is an ARMv7 CPU, and so only supports BE8. > The code is > compiled with GHS toolchai

[Qemu-devel] [PATCH 07/20] block: blockdev_init(): Call blk_set_enable_write_cache() explicitly

2016-03-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- blockdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index b18861e..70c3add 100644 --- a/blockdev.c +++ b/blockdev.c @@ -467,6 +467,7 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts,

[Qemu-devel] [PATCH v2 15/16] qemu-thread: introduce QemuRecMutex

2016-03-19 Thread Paolo Bonzini
GRecMutex is new in glib 2.32, so we cannot use it. Introduce a recursive mutex in qemu-thread instead, which will be used instead of RFifoLock. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/qemu/thread-posix.h | 6 ++ include/qemu/thread-win32.h | 10 ++ include

[Qemu-devel] [PATCH v5 10/28] migration: add reporting of errors for outgoing migration

2016-03-19 Thread Daniel P. Berrange
Currently if an application initiates an outgoing migration, it may or may not, get an error reported back on failure. If the error occurs synchronously to the 'migrate' command execution, the client app will see the error message. This is the case for DNS lookup failures. If the error occurs async

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-03-19 Thread Wei Xu
On 2016年03月17日 14:47, Jason Wang wrote: On 03/15/2016 05:17 PM,w...@redhat.com wrote: From: Wei Xu Fixed issues based on rfc patch v2: 1. Removed big param list, replace it with 'NetRscUnit' 2. Different virtio header size 3. Modify callback function to direct call. 4. Needn't check the fail

Re: [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log

2016-03-19 Thread Denis V. Lunev
On 03/14/2016 05:28 PM, Paolo Bonzini wrote: On 14/03/2016 12:21, Denis V. Lunev wrote: /* In case -D is given do not redirect stderr to /dev/null */ -if (!qemu_logfile) { +if (!qemu_logfile || qemu_logfile == stderr) { dup2(fd, 2); This relies on knowle

[Qemu-devel] [PULL 23/40] ivshmem: Disentangle ivshmem_read()

2016-03-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-24-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 173 +++--- 1 file changed, 87 insertions(+), 86 deletions(-) diff --git a/hw/misc/ivshmem.c

[Qemu-devel] [PATCH 29/49] explicitly include hw/qdev-core.h

2016-03-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- bootdevice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bootdevice.c b/bootdevice.c index 2e83ff0..bb9c08e 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -28,6 +28,7 @@ #include "qapi/visitor.h" #include "qemu/error-report.h" #include "hw/hw.h" +#incl

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 11/16] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2016-03-19 Thread Alexey Kardashevskiy
On 03/17/2016 05:10 PM, David Gibson wrote: On Thu, Mar 17, 2016 at 04:04:29PM +1100, Alexey Kardashevskiy wrote: On 03/15/2016 04:42 PM, David Gibson wrote: On Tue, Mar 15, 2016 at 01:53:48PM +1100, Alexey Kardashevskiy wrote: On 03/03/2016 05:30 PM, David Gibson wrote: On Tue, Mar 01, 2016

[Qemu-devel] [PULL 05/29] block: Add blk_commit_all()

2016-03-19 Thread Kevin Wolf
From: Max Reitz Later, we will remove bdrv_commit_all() and move its contents here, and in order to replace bdrv_commit_all() calls by calls to blk_commit_all() before doing so, we need to add it as an alias now. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf ---

Re: [Qemu-devel] [PATCH v3 08/10] ppc: Add POWER8 IAMR register

2016-03-19 Thread Thomas Huth
On 16.03.2016 18:57, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > With appropriate AMR-like masks. Not actually used by the translation > logic at that point > > Signed-off-by: Benjamin Herrenschmidt > [clg: changed spr_register_hv(SPR_IAMR) to spr_register_kvm_hv(SPR_IAMR) >

[Qemu-devel] [PATCH v2 08/16] blockjob: introduce .drain callback for jobs

2016-03-19 Thread Paolo Bonzini
This is required to decouple block jobs from running in an AioContext. With multiqueue block devices, a BlockDriverState does not really belong to a single AioContext. The solution is to first wait until all I/O operations are complete; then loop in the main thread for the block job to complete e

[Qemu-devel] [PATCH 5/6] hw/char: QOM'ify sclpconsole-lm.c

2016-03-19 Thread xiaoqiang zhao
Drop the DO_UPCAST macro Signed-off-by: xiaoqiang zhao --- hw/char/sclpconsole-lm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c index 7d4ff81..3dcc5a5 100644 --- a/hw/char/sclpconsole-lm.c +++ b/hw/char/sc

[Qemu-devel] [PULL 05/40] event_notifier: Make event_notifier_init_fd() #ifdef CONFIG_EVENTFD

2016-03-19 Thread Markus Armbruster
Event notifiers are designed for eventfd(2). They can fall back to pipes, but according to Paolo, event_notifier_init_fd() really requires the real thing, and should therefore be under #ifdef CONFIG_EVENTFD. Do that. Its only user is ivshmem, which is currently CONFIG_POSIX. Narrow it to CONFIG

[Qemu-devel] [PATCH for-2.6 07/14] pc-bios/s390-ccw: make provisions for different backends

2016-03-19 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add dispatching code to make room for non virtio-blk boot devices. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 4 +- pc-bios/s390-ccw/s390-ccw.h | 4 +- pc-bios/s390-ccw/virtio.c | 130

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Corey Minyard
On 03/15/2016 09:58 AM, Michael S. Tsirkin wrote: On Tue, Mar 15, 2016 at 03:54:36PM +0100, Paolo Bonzini wrote: On 15/03/2016 15:25, Michael S. Tsirkin wrote: Do you look at all warnings all your software prints? Yes. I also try to understand them, and if they seem useless I propose a patch

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-19 Thread Bharata B Rao
On Thu, Mar 17, 2016 at 09:03:43PM +1100, David Gibson wrote: > On Wed, Mar 16, 2016 at 04:48:50PM +0100, Igor Mammedov wrote: > > On Wed, 16 Mar 2016 09:18:03 +0530 > > Bharata B Rao wrote: > > > > > On Mon, Mar 14, 2016 at 10:47:28AM +0100, Igor Mammedov wrote: > > > > On Fri, 11 Mar 2016 10:24

Re: [Qemu-devel] [RFC PATCH v2 7/9] spapr: CPU hotplug support

2016-03-19 Thread Igor Mammedov
On Wed, 16 Mar 2016 16:19:33 +1100 David Gibson wrote: > On Fri, Mar 11, 2016 at 10:24:36AM +0530, Bharata B Rao wrote: > > Set up device tree entries for the hotplugged CPU core and use the > > exising RTAS event logging infrastructure to send CPU hotplug notification > > to the guest. > > > >

  1   2   3   4   5   6   7   8   >