Re: [Qemu-devel] [PATCH V3 3/3] tests/test-filter-redirector: Add unit test for filter-redirector

2016-03-07 Thread Jason Wang
On 03/04/2016 08:01 PM, Zhang Chen wrote: > In this unit test,we will test the filter redirector function. > > Case 1, tx traffic flow: > > qemu side | test side >| > +-+| +---+ > | backend <---+ sock0 | > +++

Re: [Qemu-devel] [PATCH V3 1/3] net/filter-mirror: Change filter_mirror_send interface

2016-03-07 Thread Zhang Chen
On 03/07/2016 03:29 PM, Jason Wang wrote: On 03/04/2016 08:01 PM, Zhang Chen wrote: Change filter_mirror_send interface to make it easier to used by other filter Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- net/filter-mirror.c | 10 +- 1 file changed, 5 insertions(+

Re: [Qemu-devel] [PATCH v9 0/7] Allow hotplug of s390 CPUs

2016-03-07 Thread Christian Borntraeger
On 03/04/2016 06:34 PM, Matthew Rosato wrote: Series is Tested-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH] net.c: Moved large array in nc_sendv_compat from the stack to the heap

2016-03-07 Thread Paolo Bonzini
On 05/03/2016 21:39, Nikos Filippakis wrote: > Hello everyone! I am interested in getting to know the codebase a little > better > so that I can eventually apply for a GSOC position. > This is my first attempt at posting a patch to a mailing list, any feedback > is greatly appreciated. > > Sign

Re: [Qemu-devel] broken socket events on win32 qemu

2016-03-07 Thread Paolo Bonzini
On 07/03/2016 08:23, Andrew Baumann wrote: > Without having looked very closely at the code, I suspect the problem > may be that we've lost the special-case treatment of socket handles as > distinct from file descriptors on Win32 (they are different namespaces, > and different APIs are needed). T

Re: [Qemu-devel] [PATCH V3 2/3] net/filter-mirror:Add filter-redirector func

2016-03-07 Thread Li Zhijian
On 03/07/2016 03:56 PM, Jason Wang wrote: On 03/04/2016 08:01 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter.

Re: [Qemu-devel] [RFC PATCH v1 05/10] cpu: Abstract CPU core type

2016-03-07 Thread Bharata B Rao
On Mon, Mar 07, 2016 at 02:36:55PM +1100, David Gibson wrote: > On Fri, Mar 04, 2016 at 07:07:20PM +0100, Igor Mammedov wrote: > > On Fri, 4 Mar 2016 16:32:53 +0530 > > Bharata B Rao wrote: > > > > > On Fri, Mar 04, 2016 at 11:38:45AM +0100, Igor Mammedov wrote: > > > > On Fri, 4 Mar 2016 12:24:

Re: [Qemu-devel] [PATCH v2 0/7] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate

2016-03-07 Thread Laszlo Ersek
(CC Janosch) Hi, On 03/01/16 07:18, Fam Zheng wrote: > v2: In the optimization patch, factor out section_covers_addr() and use it. > [Paolo, Peter] > Check "ram_block == NULL" in patch 3. [Gonglei] > Add Gonglei's rev-by in patches 1, 2, 4 and 5. > > The first four patches drop ram_a

Re: [Qemu-devel] [PATCH v2 0/7] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate

2016-03-07 Thread Fam Zheng
On Mon, 03/07 09:53, Laszlo Ersek wrote: > (CC Janosch) > > Hi, > > On 03/01/16 07:18, Fam Zheng wrote: > > v2: In the optimization patch, factor out section_covers_addr() and use it. > > [Paolo, Peter] > > Check "ram_block == NULL" in patch 3. [Gonglei] > > Add Gonglei's rev-by in pa

Re: [Qemu-devel] [PATCH V3 2/3] net/filter-mirror:Add filter-redirector func

2016-03-07 Thread Jason Wang
On 03/07/2016 04:26 PM, Li Zhijian wrote: > > > On 03/07/2016 03:56 PM, Jason Wang wrote: >> >> >> On 03/04/2016 08:01 PM, Zhang Chen wrote: >>> Filter-redirector is a netfilter plugin. >>> It gives qemu the ability to redirect net packet. >>> redirector can redirect filter's net packet to outdev

Re: [Qemu-devel] [PATCH v10 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-07 Thread Changlong Xie
On 03/06/2016 02:13 AM, Max Reitz wrote: On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 ++-- block/quorum.c| 122 ++

Re: [Qemu-devel] [PATCH v10 3/3] qmp: add monitor command to add/remove a child

2016-03-07 Thread Changlong Xie
On 03/06/2016 02:33 AM, Max Reitz wrote: On 16.02.2016 10:37, Changlong Xie wrote: From: Wen Congyang The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So i

Re: [Qemu-devel] [PATCH V3 2/3] net/filter-mirror:Add filter-redirector func

2016-03-07 Thread Zhang Chen
On 03/07/2016 03:56 PM, Jason Wang wrote: On 03/04/2016 08:01 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter.

Re: [Qemu-devel] [PATCH V3 3/3] tests/test-filter-redirector: Add unit test for filter-redirector

2016-03-07 Thread Zhang Chen
On 03/07/2016 04:10 PM, Jason Wang wrote: On 03/04/2016 08:01 PM, Zhang Chen wrote: In this unit test,we will test the filter redirector function. Case 1, tx traffic flow: qemu side | test side | +-+| +---+ | backend <---

[Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-07 Thread Fam Zheng
Signed-off-by: Fam Zheng --- This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or squashed into it if we want strict synchronization). --- scripts/dump-guest-memory.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dump-guest-memory.py b/scripts/d

[Qemu-devel] [PATCH] Whitelist sysinfo call

2016-03-07 Thread mrezanin
From: Miroslav Rezanina Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call so qemu using rbd image hang after start when run in sandbox mode. To allow using rbd images in sandbox mode we have to whitelist it. Signed-off-by: Miroslav Rezanina --- qemu-seccomp.c | 1 + 1 file

Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-07 Thread Laszlo Ersek
On 03/07/16 10:17, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > > This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or > squashed into it if we want strict synchronization). > --- > scripts/dump-guest-memory.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-07 Thread Fam Zheng
On Mon, 03/07 10:37, Laszlo Ersek wrote: > On 03/07/16 10:17, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > > > --- > > > > This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or > > squashed into it if we want strict synchronization). > > --- > > scripts/dump-guest-memory.

Re: [Qemu-devel] [PATCH] kvm/irqchip: use bitmap utility for gsi tracking

2016-03-07 Thread Paolo Bonzini
On 06/03/2016 02:57, Wei Yang wrote: > By using utilities in bitops and bitmap, this patch tries to make it more > friendly to audience. No functional change. > > Signed-off-by: Wei Yang > --- > kvm-all.c | 34 ++ > 1 file changed, 10 insertions(+), 24 deletions(-

[Qemu-devel] [PATCH] net/filter-mirror: Change filter_mirror_send interface

2016-03-07 Thread Zhang Chen
Change filter_mirror_send interface to make it easier to used by other filter Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Signed-off-by Li Zhijian --- net/filter-mirror.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/filter-mirror.c b/net/filt

Re: [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command

2016-03-07 Thread Andrea Bolognani
On Mon, 2016-03-07 at 12:23 +0800, Peter Xu wrote: > v3 changes: > - patch 2: remove func declaration, add qmp header [Drew] > - patch 3: being able to detect KVM GIC capabilities even without >   kvm enabled [Andrea]: this is a little bit hacky, need some more >   review on this. >  > v2 changes:

Re: [Qemu-devel] [Qemu-arm] [PATCH] Fix bug: SRS instructions would trap to EL3 in Secure EL1 even if specified mode was not monitor mode.

2016-03-07 Thread Sergey Fedorov
On 07.03.2016 00:14, Peter Maydell wrote: On 7 March 2016 at 02:04, Sergey Fedorov wrote: On 23.02.2016 01:25, Ralf-Philipp Weinmann wrote: According to the ARMv8 Architecture reference manual [F6.1.203], ALL of the following conditions need to be met for SRS to trap to EL3: * It is executed a

Re: [Qemu-devel] [PATCH V3 2/3] net/filter-mirror:Add filter-redirector func

2016-03-07 Thread Li Zhijian
On 03/07/2016 05:09 PM, Jason Wang wrote: On 03/07/2016 04:26 PM, Li Zhijian wrote: On 03/07/2016 03:56 PM, Jason Wang wrote: On 03/04/2016 08:01 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect fil

Re: [Qemu-devel] [PATCH v8 6/7] s390x/cpu: Add error handling to cpu creation

2016-03-07 Thread David Hildenbrand
> > After all the discussions about > > -device-add s390-cpu,id=XX > > > > As substitute/addition in the future for hotplug it is the straightforward > > approach to allow setting the id as property. Nobody knows what crazy new > > hotplug method we will come up with. But doing it the device way

[Qemu-devel] [PATCH] net/filter: rename qemu_netfilter_pass_to_next() to qemu_netfilter_iterate()

2016-03-07 Thread Zhang Chen
This API will iterate the filters attached to netdev Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang Signed-off-by: Li Zhijian --- include/net/filter.h | 10 +- net/filter-buffer.c | 2 +- net/filter.c | 12 ++-- 3 files changed, 12 insertions(+), 12 deletions(-

Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-07 Thread Laszlo Ersek
On 03/07/16 10:45, Fam Zheng wrote: > On Mon, 03/07 10:37, Laszlo Ersek wrote: >> On 03/07/16 10:17, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng >>> >>> --- >>> >>> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or >>> squashed into it if we want strict synchronization). >>

Re: [Qemu-devel] [PATCH v8 6/7] s390x/cpu: Add error handling to cpu creation

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 11:02:11 +0100 David Hildenbrand wrote: > > > After all the discussions about > > > -device-add s390-cpu,id=XX > > > > > > As substitute/addition in the future for hotplug it is the straightforward > > > approach to allow setting the id as property. Nobody knows what crazy new

Re: [Qemu-devel] broken socket events on win32 qemu

2016-03-07 Thread Daniel P. Berrange
On Mon, Mar 07, 2016 at 07:23:12AM +, Andrew Baumann wrote: > Hi Daniel, > > This commit ("char: convert from GIOChannel to QIOChannel"): > https://github.com/qemu/qemu/commit/9894dc0cdcc397ee5b26370bc53da6d360a363c2 > ... appears to have broken socket events for character devices on Win32. >

Re: [Qemu-devel] [RFC PATCH v1 05/10] cpu: Abstract CPU core type

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 14:36:55 +1100 David Gibson wrote: > On Fri, Mar 04, 2016 at 07:07:20PM +0100, Igor Mammedov wrote: > > On Fri, 4 Mar 2016 16:32:53 +0530 > > Bharata B Rao wrote: > > > > > On Fri, Mar 04, 2016 at 11:38:45AM +0100, Igor Mammedov wrote: > > > > On Fri, 4 Mar 2016 12:24:16

Re: [Qemu-devel] [RFC PATCH v1 05/10] cpu: Abstract CPU core type

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 14:01:55 +0530 Bharata B Rao wrote: > On Mon, Mar 07, 2016 at 02:36:55PM +1100, David Gibson wrote: > > On Fri, Mar 04, 2016 at 07:07:20PM +0100, Igor Mammedov wrote: > > > On Fri, 4 Mar 2016 16:32:53 +0530 > > > Bharata B Rao wrote: > > > > > > > On Fri, Mar 04, 2016 at

Re: [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro

2016-03-07 Thread Cédric Le Goater
On 03/05/2016 12:41 PM, Corey Minyard wrote: > On 03/02/2016 04:14 AM, Cédric Le Goater wrote: >> Most IPMI command handlers in the BMC simulator start with a call to >> the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of >> arguments expected by the command are indeed available.

Re: [Qemu-devel] [Xen-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-03-07 Thread Wei Liu
On Mon, Mar 07, 2016 at 08:21:46AM +0100, Juergen Gross wrote: > Hi Wei, > > On 15/02/16 14:44, Wei Liu wrote: > > On Mon, Feb 15, 2016 at 02:33:05PM +0100, Juergen Gross wrote: > >> On 15/02/16 14:16, Wei Liu wrote: > >>> On Mon, Feb 15, 2016 at 09:07:13AM +, Paul Durrant wrote: > > > >>>

Re: [Qemu-devel] [Xen-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-03-07 Thread Juergen Gross
On 07/03/16 11:51, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:21:46AM +0100, Juergen Gross wrote: >> Hi Wei, >> >> On 15/02/16 14:44, Wei Liu wrote: >>> On Mon, Feb 15, 2016 at 02:33:05PM +0100, Juergen Gross wrote: On 15/02/16 14:16, Wei Liu wrote: > On Mon, Feb 15, 2016 at 09:07:13AM +0

Re: [Qemu-devel] [Xen-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests

2016-03-07 Thread Wei Liu
On Mon, Mar 07, 2016 at 11:56:15AM +0100, Juergen Gross wrote: > On 07/03/16 11:51, Wei Liu wrote: > > On Mon, Mar 07, 2016 at 08:21:46AM +0100, Juergen Gross wrote: > >> Hi Wei, > >> > >> On 15/02/16 14:44, Wei Liu wrote: > >>> On Mon, Feb 15, 2016 at 02:33:05PM +0100, Juergen Gross wrote: >

Re: [Qemu-devel] [RFC PATCH v1 08/10] spapr: CPU hotplug support

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 11:59:42 +0530 Bharata B Rao wrote: > On Mon, Mar 07, 2016 at 02:49:06PM +1100, David Gibson wrote: > > On Fri, Mar 04, 2016 at 12:24:19PM +0530, Bharata B Rao wrote: > > > Set up device tree entries for the hotplugged CPU core and use the > > > exising EPOW event infrastruct

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: > Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to > do this?) I already said I was fine with it, yes, and submitted a MAINTAINERS patch towards that, without any response. Samuel

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > - Lots of checkpatch warnings, let's try to silent it. They are indentation issues, yes. They are already existing in slirp/ . Whenever new code was added we sticked with the qemu style, but for patched code we prefered to stick to the existi

Re: [Qemu-devel] [PATCHv2 1/3] target-ppc: Split out SREGS get/put functions

2016-03-07 Thread Thomas Huth
On 07.03.2016 03:26, David Gibson wrote: > Currently the getting and setting of Power MMU registers (sregs) take up > large inline chunks of the kvm_arch_get_registers() and > kvm_arch_put_registers() functions. Especially since there are two > variants (for Book-E and Book-S CPUs), only one of wh

Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote: > > +switch (ip6->ip_nh) { > > +#if 0 > > +case IPPROTO_TCP: > > +tcp_input(m, hlen, (struct socket *)NULL); > > +break; > > +case IPPROTO_UDP: > > +udp_input(m, hlen); > > +break; > > +#endif > > Thi

[Qemu-devel] [PATCH] win32: fix socket_error() to work with Mingw64

2016-03-07 Thread Daniel P. Berrange
Historically QEMU has had a socket_error() macro that was defined to map to WSASocketError(). The os-win32.h header file would define errno constants that mapped to the WSA error constants. This worked fine with Mingw32 since its header files never defined any errno values, nor did it even provide

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote: > Part of the codes looks duplicated with ipv4 version. Any chances to > merge them like tcp? The duplication is actually quite small: accessing the ip length is different, filling the address is different, etc. So there are differences all al

Re: [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 15:02:53 +0800, wrote: > On 02/23/2016 03:28 AM, Samuel Thibault wrote: > > From: Guillaume Subiron > > > > No code change. > > > > Signed-off-by: Guillaume Subiron > > Signed-off-by: Samuel Thibault > > Reviewed-by: Thomas Huth > > --- > > slirp/tcp_input.c | 9

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: > Please do unnecessary changes like this since it will cause extra effort > for git blame and other things. Which is exactly why we avoided to fix all the checkpatch warnings by leaving existing non-qemu-style indentation. Samuel

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 06:49:19AM +, Li, Liang Z wrote: > > > No. And it's exactly what I mean. The ballooned memory is still > > > processed during live migration without skipping. The live migration code > > > is > > in migration/ram.c. > > > > So if guest acknowledged VIRTIO_BALLOON_F_MUS

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 15:05:05 +0800, wrote: > Please do unnecessary changes like this since it will cause extra effort > for git blame and other things. Ok. I just do hope that no other reviewer will come and say that we should fix the alignment of the parameters. Samuel

Re: [Qemu-devel] [PATCH v8 6/7] s390x/cpu: Add error handling to cpu creation

2016-03-07 Thread Cornelia Huck
On Mon, 7 Mar 2016 11:12:14 +0100 Igor Mammedov wrote: > On Mon, 7 Mar 2016 11:02:11 +0100 > David Hildenbrand wrote: > > > > > After all the discussions about > > > > -device-add s390-cpu,id=XX > > > > > > > > As substitute/addition in the future for hotplug it is the > > > > straightforward

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > - the series does not build on w32: > In file included from ./slirp/slirp.h:126:0, > from stubs/slirp.c:3: > ./slirp/ip6.h:9:24: fatal error: netinet/in.h: No such file or directory Is it the only issue? Does it build if you

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Thomas Huth
On 07.03.2016 12:19, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: >> - Lots of checkpatch warnings, let's try to silent it. > > They are indentation issues, yes. They are already existing in slirp/ > . Whenever new code was added we sticked with the qemu style, bu

Re: [Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-07 Thread Igor Mammedov
On Sun, 6 Mar 2016 14:17:56 +0200 Marcel Apfelbaum wrote: > Legacy Windows operating systems like Windows XP and Windows 2003 > require _DIS method to be present for all interrupt links. > > PC machines already have a no-op implemented for GSI links, add > it also in Q35. Maybe I don't see but

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Jan Kiszka
On 2016-03-07 12:09, Samuel Thibault wrote: > Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: >> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to >> do this?) > > I already said I was fine with it, yes, and submitted a MAINTAINERS > patch towards that, without any res

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Samuel Thibault
Jan Kiszka, on Mon 07 Mar 2016 13:06:20 +0100, wrote: > On 2016-03-07 12:09, Samuel Thibault wrote: > > Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: > >> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to > >> do this?) > > > > I already said I was fine with it, yes,

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-07 Thread Jan Kiszka
On 2015-08-06 13:10, Samuel Thibault wrote: > Signed-off-by: Samuel Thibault > > --- > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit : >> On 2015-07-29 00:12, Samuel Thibault wrote: >>> Hello, >>> >>> Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : Of course, I'm fine with

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Thomas Huth
On 07.03.2016 13:06, Jan Kiszka wrote: > On 2016-03-07 12:09, Samuel Thibault wrote: >> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: >>> Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to >>> do this?) >> >> I already said I was fine with it, yes, and submitted a MAIN

Re: [Qemu-devel] [PATCH v5 5/5] nvdimm acpi: add _CRS

2016-03-07 Thread Igor Mammedov
On Thu, 3 Mar 2016 16:48:55 +0200 "Michael S. Tsirkin" wrote: > On Thu, Mar 03, 2016 at 10:05:31PM +0800, Xiao Guangrong wrote: > > > > > > On 03/03/2016 09:29 PM, Michael S. Tsirkin wrote: > > >On Wed, Mar 02, 2016 at 07:50:41PM +0800, Xiao Guangrong wrote: > > >>As Igor suggested that we

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Jan Kiszka
On 2016-03-07 13:14, Thomas Huth wrote: > On 07.03.2016 13:06, Jan Kiszka wrote: >> On 2016-03-07 12:09, Samuel Thibault wrote: >>> Jason Wang, on Mon 07 Mar 2016 13:03:11 +0800, wrote: Btw, do you want to be the maintainer of slirp? (Or maybe Tohmas want to do this?) >>> >>> I already sa

Re: [Qemu-devel] [PATCH v5 5/5] nvdimm acpi: add _CRS

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 01:16:48PM +0100, Igor Mammedov wrote: > On Thu, 3 Mar 2016 16:48:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Mar 03, 2016 at 10:05:31PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 03/03/2016 09:29 PM, Michael S. Tsirkin wrote: > > > >On Wed, Mar 02, 201

[Qemu-devel] [PATCH] block: Fix snapshot=on cache modes

2016-03-07 Thread Kevin Wolf
Since commit 91a097e, we end up with a somewhat weird cache mode configuration with snapshot=on: The commit broke the cache mode inheritance for the snapshot overlay so that it is opened as writethrough instead of unsafe now. The following bdrv_append() call to put it on top of the tree swaps the W

Re: [Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 01:06:43PM +0100, Igor Mammedov wrote: > On Sun, 6 Mar 2016 14:17:56 +0200 > Marcel Apfelbaum wrote: > > > Legacy Windows operating systems like Windows XP and Windows 2003 > > require _DIS method to be present for all interrupt links. > > > > PC machines already have a

[Qemu-devel] [PATCH] ich9lpc: fix typo

2016-03-07 Thread Cao jin
change some "rbca" to "rcrb"(root complex register block) while the other to "rcba"(root complex base address). Bonus: add more comments and fix some indentation. Signed-off-by: Cao jin --- hw/isa/lpc_ich9.c | 35 ++- include/hw/i386/ich9.h | 4 ++-- 2 files

Re: [Qemu-devel] [Xen-devel] [Patch V1 3/3] xen: add pvUSB backend

2016-03-07 Thread Juergen Gross
Sorry, I just found time now to continue with this series. On 27/10/15 19:54, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 03, 2015 at 12:45:13PM +0200, Juergen Gross wrote: >> Add a backend for para-virtualized USB devices for xen domains. >> >> The backend is using host-libusb to forward USB reque

Re: [Qemu-devel] broken socket events on win32 qemu

2016-03-07 Thread Paolo Bonzini
On 07/03/2016 11:19, Daniel P. Berrange wrote: > On Mon, Mar 07, 2016 at 07:23:12AM +, Andrew Baumann wrote: >> Hi Daniel, >> >> This commit ("char: convert from GIOChannel to QIOChannel"): >> https://github.com/qemu/qemu/commit/9894dc0cdcc397ee5b26370bc53da6d360a363c2 >> ... appears to have

Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-03-07 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > From: "Denis V. Lunev" > > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'inf

Re: [Qemu-devel] [PATCH v9 6/7] s390x/cpu: Add error handling to cpu creation

2016-03-07 Thread David Hildenbrand
> Check for and propogate errors during s390 cpu creation. > > Signed-off-by: Matthew Rosato Looks good to me. Reviewed-by: David Hildenbrand David

[Qemu-devel] strange crash in tracked_request_begin

2016-03-07 Thread Christian Borntraeger
Folks, I had a crash of a qemu guest in tracked_request_begin. The testcase was a guest with ramdisk/kernel that reboots in a loop. (about 10 times per second) with a single null-co disk attached. No idea how to reproduce this, seems to be a lucky hit. (gdb) bt #0 0x101db5ba in tracked

Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-07 Thread Paolo Bonzini
On 07/03/2016 10:17, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > > This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or > squashed into it if we want strict synchronization). > --- > scripts/dump-guest-memory.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

2016-03-07 Thread Paolo Bonzini
On 06/03/2016 03:42, Huaicheng Li (coperd) wrote: > >> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini > > wrote: >> >> This is done >> because the worker threads only care about the queued request list, not >> about active or completed requests. > > Do you think it would

Re: [Qemu-devel] [PATCH 01/38] exec: Fix memory allocation when memory path names new file

2016-03-07 Thread Paolo Bonzini
On 04/03/2016 19:50, Markus Armbruster wrote: > There's another one in ivshmem_server.c, functionally identical and > wrapped in CONFIG_LINUX. Not quite identical, since it returns -1 for non-hugetlbfs. It should return getpagesize(). > Here's exec.c's: > > #define HUGETLBFS_MAGIC 0

Re: [Qemu-devel] [PATCH v9 0/7] Allow hotplug of s390 CPUs

2016-03-07 Thread Cornelia Huck
On Fri, 4 Mar 2016 12:34:28 -0500 Matthew Rosato wrote: > As discussed in the KVM call, we will go ahead with cpu_add for > s390x to get cpu hotplug functionality in s390x now, until > architectures that require a more robust hotplug interface > settle on a design. > > To configure a guest wit

Re: [Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-07 Thread Marcel Apfelbaum
On 03/07/2016 02:36 PM, Michael S. Tsirkin wrote: On Mon, Mar 07, 2016 at 01:06:43PM +0100, Igor Mammedov wrote: On Sun, 6 Mar 2016 14:17:56 +0200 Marcel Apfelbaum wrote: Legacy Windows operating systems like Windows XP and Windows 2003 require _DIS method to be present for all interrupt lin

Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-03-07 Thread Paolo Bonzini
On 07/03/2016 13:49, Dr. David Alan Gilbert wrote: >b) The harder problem is that there's a race where qemu_bh_delete > segs, and I'm not 100% sure why yet - it only does it sometime > (i.e. run virt-test and leave it and it occasionally does it). > From the core it looks li

Re: [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending

2016-03-07 Thread Samuel Thibault
Jason Wang, on Mon 07 Mar 2016 14:55:52 +0800, wrote: > On 02/23/2016 03:28 AM, Samuel Thibault wrote: > > From: Yann Bordenave > > > > Disambiguation : icmp_error is renamed into icmp_send_error, since it > > doesn't manage errors, but only sends ICMP Error messages. > > > > Adding icmp6_send_err

Re: [Qemu-devel] strange crash in tracked_request_begin

2016-03-07 Thread Paolo Bonzini
On 07/03/2016 13:29, Christian Borntraeger wrote: > Folks, > > I had a crash of a qemu guest in tracked_request_begin. > The testcase was a guest with ramdisk/kernel that reboots in a > loop. (about 10 times per second) with a single null-co disk > attached. Does it use a separate iothread?

Re: [Qemu-devel] [PATCHv2 2/3] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-07 Thread Greg Kurz
On Mon, 7 Mar 2016 13:26:25 +1100 David Gibson wrote: > When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) > pointer updated by a write to the SDR1 register we need to update some > derived variables. Likewise, when the cpu is configured for an external > HPT (one not in the g

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-07 Thread Samuel Thibault
Thomas Huth, on Mon 07 Mar 2016 13:00:48 +0100, wrote: > On 07.03.2016 12:19, Samuel Thibault wrote: > > Jason Wang, on Mon 07 Mar 2016 14:48:16 +0800, wrote: > >> - I expects a unit-test for this. You may want to have a look at the > >> pxe-test in tests/, I think it could be extended to test ipv6

Re: [Qemu-devel] strange crash in tracked_request_begin

2016-03-07 Thread Christian Borntraeger
On 03/07/2016 02:35 PM, Paolo Bonzini wrote: > > > On 07/03/2016 13:29, Christian Borntraeger wrote: >> Folks, >> >> I had a crash of a qemu guest in tracked_request_begin. >> The testcase was a guest with ramdisk/kernel that reboots in a >> loop. (about 10 times per second) with a single null-c

Re: [Qemu-devel] [PATCHv2 3/3] target-ppc: Eliminate kvmppc_kern_htab global

2016-03-07 Thread Greg Kurz
On Mon, 7 Mar 2016 13:26:26 +1100 David Gibson wrote: > fa48b43 "target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM" > purports to remove a hack in the handling of hash page tables (HPTs) > managed by KVM instead of qemu. However, it actually went in the wrong > direction. > > Tha

[Qemu-devel] [PATCH] block: Fix cache mode defaults in bds_tree_init()

2016-03-07 Thread Kevin Wolf
Without setting explicit defaults in the options, blockdev-add without an ID ended up defaulting to writethrough. It should be writeback as documented. Signed-off-by: Kevin Wolf --- blockdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index eecd78d..1824c

Re: [Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 03:21:44PM +0200, Marcel Apfelbaum wrote: > On 03/07/2016 02:36 PM, Michael S. Tsirkin wrote: > >On Mon, Mar 07, 2016 at 01:06:43PM +0100, Igor Mammedov wrote: > >>On Sun, 6 Mar 2016 14:17:56 +0200 > >>Marcel Apfelbaum wrote: > >> > >>>Legacy Windows operating systems like

Re: [Qemu-devel] [PATCH] kvm/irqchip: use bitmap utility for gsi tracking

2016-03-07 Thread Wei Yang
On Mon, Mar 07, 2016 at 10:47:53AM +0100, Paolo Bonzini wrote: >On 06/03/2016 02:57, Wei Yang wrote: >> By using utilities in bitops and bitmap, this patch tries to make it more >> friendly to audience. No functional change. >> >> Signed-off-by: Wei Yang >> --- >> kvm-all.c | 34 ++--

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-07 Thread Samuel Thibault
From: Samuel Thibault Signed-off-by: Samuel Thibault --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2f5a338..a316bc3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1217,6 +1217,7 @@ F: scripts/qmp/ T: git git://repo.or.cz/qemu/armbru.git qap

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-07 Thread Samuel Thibault
The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e52f: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-04' into staging (2016-03-06 11:53:27 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git for you to fet

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

2016-03-07 Thread Huaicheng Li (coperd)
> On Mar 5, 2016, at 8:42 PM, Huaicheng Li (coperd) wrote: > > >> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini > > wrote: >> >> This is done >> because the worker threads only care about the queued request list, not >> about active or completed requests. > > Do you th

Re: [Qemu-devel] [PATCH v5 5/5] nvdimm acpi: add _CRS

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 14:22:38 +0200 "Michael S. Tsirkin" wrote: > On Mon, Mar 07, 2016 at 01:16:48PM +0100, Igor Mammedov wrote: > > On Thu, 3 Mar 2016 16:48:55 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Mar 03, 2016 at 10:05:31PM +0800, Xiao Guangrong wrote: > > > > > > > > >

Re: [Qemu-devel] [PATCH v8 6/7] s390x/cpu: Add error handling to cpu creation

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 12:49:27 +0100 Cornelia Huck wrote: > On Mon, 7 Mar 2016 11:12:14 +0100 > Igor Mammedov wrote: > > > On Mon, 7 Mar 2016 11:02:11 +0100 > > David Hildenbrand wrote: > > > > > > > After all the discussions about > > > > > -device-add s390-cpu,id=XX > > > > > > > > > > As s

Re: [Qemu-devel] [PATCH v1 01/10] qdict: implement a qdict_crumple method for un-flattening a dict

2016-03-07 Thread Daniel P. Berrange
On Sat, Mar 05, 2016 at 04:15:59PM +0100, Max Reitz wrote: > On 03.03.2016 12:01, Daniel P. Berrange wrote: > > On Wed, Mar 02, 2016 at 05:13:59PM +0100, Max Reitz wrote: > >> On 19.02.2016 17:47, Daniel P. Berrange wrote: > >>> The qdict_flatten() method will take a dict whose elements are > >>> f

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-07 Thread Li, Liang Z
> Cc: Roman Kagan; Dr. David Alan Gilbert; ehabk...@redhat.com; > k...@vger.kernel.org; quint...@redhat.com; linux-ker...@vger.kernel.org; > qemu-devel@nongnu.org; linux...@kvack.org; amit.s...@redhat.com; > pbonz...@redhat.com; a...@linux-foundation.org; > virtualizat...@lists.linux-foundation.org

[Qemu-devel] [Bug 1553999] [NEW] OpenGL support is disabled

2016-03-07 Thread Lafa
Public bug reported: $ qemu-system-x86_64 -enable-kvm -display sdl,gl=on -vga qxl SDL1 display code has no opengl support. Please recompile qemu with SDL2, using ./configure --enable-sdl --with-sdlabi=2.0 qemu-system-x86_64: OpenGL support is disabled Can you please recompile qemu with support f

Re: [Qemu-devel] [PATCH v5 5/5] nvdimm acpi: add _CRS

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 03:49:47PM +0100, Igor Mammedov wrote: > On Mon, 7 Mar 2016 14:22:38 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Mar 07, 2016 at 01:16:48PM +0100, Igor Mammedov wrote: > > > On Thu, 3 Mar 2016 16:48:55 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

[Qemu-devel] [Bug 1553999] Re: OpenGL support is disabled

2016-03-07 Thread Lafa
This feature allows for the guest OS to have opengl 2 support, that is require for several 3d applications. It also opens the way for supporting acceleration on windows and Linux guest systems. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-07 Thread Igor Mammedov
On Mon, 7 Mar 2016 15:21:44 +0200 Marcel Apfelbaum wrote: > On 03/07/2016 02:36 PM, Michael S. Tsirkin wrote: > > On Mon, Mar 07, 2016 at 01:06:43PM +0100, Igor Mammedov wrote: > >> On Sun, 6 Mar 2016 14:17:56 +0200 > >> Marcel Apfelbaum wrote: > >> > >>> Legacy Windows operating systems li

Re: [Qemu-devel] [RFC] host and guest kernel trace merging

2016-03-07 Thread Stefan Hajnoczi
On Fri, Mar 04, 2016 at 08:23:11AM -0500, Steven Rostedt wrote: > The problem I have with the guest server, and something that we may be > able to fix later on, but should always keep it in the back of our > minds, is the security issue. For this to work, the guest server needs > to run as root. It

[Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API

2016-03-07 Thread Igor Mammedov
Simplify bios_linker API by adding filei name + blob tracking so user would have to suppily less arguments which reduces chances of mistake by using wrong blob pointer with not related file. And also refactor API to take file offsets, as it's what actually API were doing only internally, instead of

[Qemu-devel] [PATCH 4/6] tpm: apci: cleanup TCPA table initialization

2016-03-07 Thread Igor Mammedov
At the time build_tpm_tcpa() is called the tcpalog size is always 0, so log_area_start_address which is actually offset from the start of ACPI_BUILD_TPMLOG_FILE is always 0. More over if tcpalog would be not 0 sized at build_tpm_tcpa() calling time it would make tcpa->log_area_start_address point t

[Qemu-devel] [PATCH 3/6] acpi: cleanup bios_linker_loader_cleanup()

2016-03-07 Thread Igor Mammedov
bios_linker_loader_cleanup() is called only from one place and returned value is immediately freed wich makes returning pointer from bios_linker_loader_cleanup() useless. Cleanup bios_linker_loader_cleanup() by freeing data there so that caller won't have to free it. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH 1/6] acpi: convert linker from GArray to BOISLinker structure

2016-03-07 Thread Igor Mammedov
Patch just changes type of of linker variables to a structure, there aren't any functional changes. Converting linker to a structure will allow to extend it functionality in follow up patch adding sanity blob checks. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 5 ++-

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-07 Thread Paolo Bonzini
On 12/02/2016 15:45, Peter Maydell wrote: > This patchset adds some more secure-only devices to the virt board: > (1) a 16MB secure-only RAM > (2) the first flash device is secure-only > > The second of these is strictly speaking a breaking change, but I don't > expect it in practice to break

[Qemu-devel] [PATCH 6/6] acpi: make bios_linker_loader_add_checksum() API offset based

2016-03-07 Thread Igor Mammedov
It should help to make clear that bios_linker works in terms of offsets within a file. Also it should prevent mistakes where user passes as arguments pointers to unrelated to file blobs. While at it, considering that it's a ACPI checksum and it's initial value must be 0, move checksum field zeroin

[Qemu-devel] [PATCH 5/6] acpi: make bios_linker_loader_add_pointer() API offset based

2016-03-07 Thread Igor Mammedov
cleanup bios_linker_loader_add_pointer() API by switching arguments to taking offsets relative to corresponding files instead of doing pointer arithmetic on behalf of user which were confusing. Also make offset inside of source file explicit in API so that user won't have to manually set it in des

Re: [Qemu-devel] [PATCH v10 1/3] Add new block driver interface to add/delete a BDS's child

2016-03-07 Thread Max Reitz
On 07.03.2016 05:16, Changlong Xie wrote: > On 03/06/2016 01:27 AM, Max Reitz wrote: >> Sorry that I wasn't so pedantic last time; or maybe I should rather be >> sorry that I'm so pedantic this time. > > Hi Max > Welcome all your comments : ) Good :-) >> On 16.02.2016 10:37, Changlong Xie wr

Re: [Qemu-devel] [PATCH 0/6] acpi: simplify bios_linker API

2016-03-07 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 04:19:02PM +0100, Igor Mammedov wrote: > Simplify bios_linker API by adding filei name + blob tracking > so user would have to suppily less arguments which > reduces chances of mistake by using wrong blob pointer > with not related file. > And also refactor API to take file

  1   2   3   4   >