[Qemu-devel] [PATCH v4 08/11] block: m25p80: Fast read and 4bytes commands

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Adds fast read and 4bytes commands family. This work is based on Pawel Lenkow patch from v1. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/hw/b

[Qemu-devel] [PATCH v4 01/11] block: m25p80: Removed unused variable

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index de24f42..124 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -246,8 +246,

[Qemu-devel] [PATCH v4 09/11] block: m25p80: Implemented FSR register

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Implements FSR register, it is used for busy waits. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 4acc79a..bc0dadb 100644 --- a/hw/block/m25p80.c +++ b/

[Qemu-devel] [PATCH v4 07/11] block: m25p80: Dummy cycles for N25Q256/512

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski This patch handles dummy cycles. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 9d5a071..aff28f3 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -56

[Qemu-devel] [PATCH v4 03/11] block: m25p80: Widen flags variable

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Extend the width of the flags variable to support the already existing (but unused) WR_1 flag, which is above the range of 8 bits. This allows support of EEPROM emulation which requires the WR_1 feature. Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --

[Qemu-devel] [PATCH v4 02/11] block: m25p80: RESET_ENABLE and RESET_MEMORY commnads

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 124..06b0af3 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p8

[Qemu-devel] [PATCH v4 11/11] block: m25p80: at25128a/at25256a models

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 2b7d19f..987fe07 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -99,6 +99,12 @@ static const Fla

[Qemu-devel] [PATCH v4 00/11] Support for N25Q256/512 and AT25128/256

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski V4: - Fixed RNVCR command (needed bytes set to 2 instead of 1) - Config registers are configured only for micron flash devices - Move config registers initialization to reset_memory function - Removed clearing reset_enable flag when chip was selcted by CS signal V3: - Chec

[Qemu-devel] [PATCH v4 10/11] block: m25p80: n25q256a/n25q512a models

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index bc0dadb..2b7d19f 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.

[Qemu-devel] [PATCH v4 06/11] block: m25p80: Add configuration registers

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski This patch adds both volatile and non volatile configuration registers and commands to allow modify them. It is needed for proper handling dummy cycles. Initialization of those registers and flash state has been included as well. Some of this registers are used by kernel.

[Qemu-devel] [PATCH v4 05/11] block: m25p80: 4byte address mode

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski This patch adds only 4byte address mode (does not cover dummy cycles). This mode is needed to access more than 16 MiB of flash. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 41 +++-- 1 file changed, 35 insertions(+), 6 del

Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device

2016-02-22 Thread Bharata B Rao
On Mon, Feb 22, 2016 at 07:44:40AM +0100, Andreas Färber wrote: > Am 22.02.2016 um 06:01 schrieb Bharata B Rao: > > sPAPR CPU core device is a container of CPU thread devices. CPU hotplug is > > performed in the granularity of CPU core device by setting the "realized" > > property of this device to

[Qemu-devel] [PATCH v4 04/11] block: m25p80: Extend address mode

2016-02-22 Thread marcin . krzeminski
From: Marcin Krzeminski Extend address mode allows to switch flash 16 MiB banks, allowing user to access all flash sectors. This access mode is used by u-boot. Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 27 +++ 1 file change

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-22 Thread Markus Armbruster
Max Reitz writes: > On 17.02.2016 17:20, Kevin Wolf wrote: >> Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: >>> On 17.02.2016 11:53, Kevin Wolf wrote: Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: > The monitor does hold references to some BlockBackends so it should have >>>

[Qemu-devel] [PULL 1/1] gtk: fix uninitialized temporary VirtualConsole

2016-02-22 Thread Gerd Hoffmann
From: Paolo Bonzini Only the echo field is used in the temporary VirtualConsole, so the damage was limited. But still, if echo was incorrectly set to true, the result would be some puzzling output in VTE monitor and serial consoles. Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd Cc: Gerd Hoffm

[Qemu-devel] [PULL 0/1] gtk: fix uninitialized temporary VirtualConsole

2016-02-22 Thread Gerd Hoffmann
/qemu tags/pull-ui-20160222-1 for you to fetch changes up to 327d83ba717c879f5640b41c15af3ce56a7922eb: gtk: fix uninitialized temporary VirtualConsole (2016-02-22 08:38:42 +0100) gtk: fix uninitialized temporary VirtualConsole

Re: [Qemu-devel] [PATCH] gtk: implement set_echo

2016-02-22 Thread Gerd Hoffmann
On So, 2016-02-21 at 21:36 +0100, Jan Kiszka wrote: > On 2016-02-17 15:05, Paolo Bonzini wrote: > > > > > > On 17/02/2016 14:53, Kevin Wolf wrote: > >> Waiting didn't fix the bug, so I tried a git bisect now and it pointed > >> me to this commit. > >> > >> I'm using HMP with the default vc backen

[Qemu-devel] [PATCH v2 0/3] memory: an optimization

2016-02-22 Thread Gonglei
Perf top tells me qemu_get_ram_ptr consume some cpu cycles. Before this optimization: 1.26% qemu-kvm [.] qemu_get_ram_ptr 0.89% qemu-kvm [.] qemu_get_ram_block Applied the patch set: 0.87% qemu-kvm [.] qemu_get_ram_ptr And Paolo suggested

[Qemu-devel] [PATCH v2 3/3] memory: Remove the superfluous code

2016-02-22 Thread Gonglei
Signed-off-by: Gonglei --- include/exec/memory.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 1cf2e51..4e5a145 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1400,8 +1400,6 @@ static inline bool memory_access_is_direc

[Qemu-devel] [PATCH v2 1/3] exec: store RAMBlock pointer into memory region

2016-02-22 Thread Gonglei
Each RAM memory region has a unique corresponding RAMBlock. In the current realization, the memory region only stored the ram_addr which means the offset of RAM address space, We need to qurey the global ram.list to find the ram block by ram_addr if we want to get the ram block, which is very expen

[Qemu-devel] [PATCH v2 2/3] memory: optimize qemu_get_ram_ptr and qemu_ram_ptr_length

2016-02-22 Thread Gonglei
these two functions consume too much cpu overhead to find the RAMBlock by ram address. After this patch, we can pass the RAMBlock pointer to them so that they don't need to find the RAMBlock anymore most of the time. We can get better performance in address translation processing. Signed-off-by:

Re: [Qemu-devel] [PATCH] tusb6010: move from hw/timer to hw/usb

2016-02-22 Thread Gerd Hoffmann
On Fr, 2016-02-19 at 12:03 +, Peter Maydell wrote: > The TUSB6010 is a USB controller (as the name suggests). Move it from > hw/timer (where it was accidentally filed in 2013 when we moved > everything out of hw/) to hw/usb. Added to usb queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 0/2] usb: check RNDIS offsets & length

2016-02-22 Thread Gerd Hoffmann
On Mi, 2016-02-17 at 00:23 +0530, P J P wrote: > From: Prasad J Pandit > > Hello, > > When processing remote NDIS control message packets, the USB Net > device emulator uses a fixed length(4096) data buffer. The incoming > packet length could exceed that OR informationBufferOffset & Length > com

[Qemu-devel] [PATCH] ohci: allocate timer only once.

2016-02-22 Thread Gerd Hoffmann
Allocate timer once, at init time, instead of allocating/freeing it all the time when starting/stopping the bus. Simplifies the code, also fixes bugs (memory leak) due to missing checks whenever the time is already allocated or not. Cc: Prasad J Pandit Reported-by: Zuozhi Fzz Signed-off-by: Ger

Re: [Qemu-devel] [PATCH v7 0/8] Make qemu-img/qemu-nbd/qemu-io CLI more flexible

2016-02-22 Thread Kevin Wolf
Am 17.02.2016 um 11:10 hat Daniel P. Berrange geschrieben: > This series of patches expands the syntax of the qemu-img, > qemu-nbd and qemu-io commands to make them more flexible. > > v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html > v1: https://lists.gnu.org/archive/ht

Re: [Qemu-devel] [PATCH v3] usb: add pid check at the first of uhci_handle_td()

2016-02-22 Thread Gerd Hoffmann
Hi, > [Also fixed BZ 1070027] Which bugzilla instance is this? Better cut+paste the full bug URL into the commit message. Patch added to usb queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v6] i2c-tiny-usb: a small usb to i2c bridge

2016-02-22 Thread Gerd Hoffmann
On Di, 2016-02-16 at 16:55 +0100, Tim Sander wrote: > Oh my, so many stupid little errors. Due to firewall impairment i am sending > these > patches manually. Last time i forgot to disable the newline breaks which made > the > patch v5 unusable. Sorry for this inconvenience. Didn't work again:

Re: [Qemu-devel] [PATCH v3] usb: add pid check at the first of uhci_handle_td()

2016-02-22 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, February 22, 2016 4:55 PM > > Hi, > > > [Also fixed BZ 1070027] > > Which bugzilla instance is this? > https://bugzilla.redhat.com/show_bug.cgi?id=1070027 > Better cut+paste the full bug URL into

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 02/20/2016 10:28 PM, Max Reitz wrote: > >On 19.02.2016 12:24, Alberto Garcia wrote: > >>On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang > >>wrote: > >> > >If quorum has two children(A, B). A do flush sucessfully, but B > >flush fail

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-22 Thread Markus Armbruster
David Gibson writes: > On Fri, Feb 19, 2016 at 10:51:11AM +0100, Markus Armbruster wrote: >> David Gibson writes: >> >> > On Thu, Feb 18, 2016 at 11:37:39AM +0100, Igor Mammedov wrote: >> >> On Thu, 18 Feb 2016 14:39:52 +1100 >> >> David Gibson wrote: >> >> >> >> > On Tue, Feb 16, 2016 at 11:

Re: [Qemu-devel] [PATCH v3] usb: add pid check at the first of uhci_handle_td()

2016-02-22 Thread Gerd Hoffmann
Hi, > https://bugzilla.redhat.com/show_bug.cgi?id=1070027 > > Yes, can you rebase and change the commit message? Done. cheers, Gerd

Re: [Qemu-devel] [PATCH] block: Fix -incoming with snapshot=on

2016-02-22 Thread Kevin Wolf
Am 19.02.2016 um 17:12 hat Paolo Bonzini geschrieben: > > > On 19/02/2016 16:52, Kevin Wolf wrote: > > The BDRV_O_INACTIVE flag should only be set for images explicitly opened > > by the user. snapshot=on needs to create a new qcow2 image and write > > some metadata to it. This is not a problem b

[Qemu-devel] [PATCH v3 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-22 Thread Denis V. Lunev
With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is the following. Windows checks HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE bit in CPUID. The presence of this bit is eno

Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-22 Thread Denis V. Lunev
On 02/18/2016 08:17 AM, Amit Shah wrote: Can someone from the block team please give this a review? Thanks, guys? On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: There is a possibility to hit an assert in qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM

[Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread xiaoqiang zhao
assign DeviceClass::vmsd instead of using vmstate_register function Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index 3c683aa..b0cf79d 100644 --- a/hw/timer/m48t59.c +++ b/hw/tim

Re: [Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning

2016-02-22 Thread Denis V. Lunev
On 02/10/2016 11:49 AM, Vladimir Sementsov-Ogievskiy wrote: v7: 02: Reviewed-by: Igor Mammedov 04: object instead of dimm 05: arror_abort instead of NULL for getting size property, remove superfluous include v6: add stubbed pc_dimm_build_list, fix compilation for !CONFIG_MEM_

Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010

2016-02-22 Thread Peter Maydell
On 22 February 2016 at 03:15, xiaoqiang zhao wrote: > Move majority of old SysBus init's work the into instance_init. > > Note: > musb_init must be called in SysBus's init, otherwise it will > break "make check" with error message as follows: > > qom/object.c:1576:object_get_canonical_path_compone

Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010

2016-02-22 Thread hitmoon
在 2016年02月22日 17:18, Peter Maydell 写道: On 22 February 2016 at 03:15, xiaoqiang zhao wrote: Move majority of old SysBus init's work the into instance_init. Note: musb_init must be called in SysBus's init, otherwise it will break "make check" with error message as follows: qom/object.c:1576:ob

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread Peter Maydell
On 22 February 2016 at 09:11, xiaoqiang zhao wrote: > assign DeviceClass::vmsd instead of using vmstate_register function > > Signed-off-by: xiaoqiang zhao > --- > hw/timer/m48t59.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c

[Qemu-devel] [PATCH] block migration: Activate image on destination before writing to it

2016-02-22 Thread Kevin Wolf
When using 'migrate -b', we must make sure to take ownership of the image before writing to it. Otherwise metadata would be thrown away on migration completion; this was caught by the assertions introduced in commit 09e0c771. Reported-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- migration/bl

Re: [Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-22 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Fri, Jan 29, 2016 at 5:23 PM, Markus Armbruster wrote: >>> marcandre.lur...@redhat.com writes: >>> From: Marc-André Lureau Simplify the interrupt handling by having a single callback on irq&msi cases. Re

Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-22 Thread Amit Shah
On (Thu) 18 Feb 2016 [15:54:28], Paolo Bonzini wrote: > > > On 18/02/2016 09:03, Denis V. Lunev wrote: > > On 02/18/2016 08:17 AM, Amit Shah wrote: > >> Can someone from the block team please give this a review? > > > > Paolo, can you pls bless this? I think that the fix comes from the > > infras

Re: [Qemu-devel] [RFC PATCH v0 1/8] cpu: Store CPU typename in MachineState

2016-02-22 Thread David Gibson
On Mon, Feb 22, 2016 at 10:31:18AM +0530, Bharata B Rao wrote: > Storing CPU typename in MachineState lets us to create CPU threads > for all architectures in uniform manner from arch-neutral code. > > TODO: Touching only sPAPR target for now > > Signed-off-by: Bharata B Rao As noted elsewhere,

[Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush operation

2016-02-22 Thread Changlong Xie
Keep flush interface the same logic as quorum read/write, Otherwise in following scenario, we'll encounter unexpected errors. Quorum has two children(A, B). A do flush sucessfully, but B flush failed. This cause the filesystem of guest become read-only with following errors: end_request: I/O erro

[Qemu-devel] [PATCH v3 0/1] modify vote rules for flush operation

2016-02-22 Thread Changlong Xie
ChangLog: v3: *Note* that, the codes logic is different from what we talked in v2. I just keep flush interface the same logic as quorum read/write, and think it's reasoned. [Ref] http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg05342.htm Changlong Xie (1): quorum: modify vote rules fo

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Changlong Xie
On 02/22/2016 05:02 PM, Dr. David Alan Gilbert wrote: * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: On 02/20/2016 10:28 PM, Max Reitz wrote: On 19.02.2016 12:24, Alberto Garcia wrote: On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: If quorum has two children(A, B). A do flush s

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > On 02/22/2016 05:02 PM, Dr. David Alan Gilbert wrote: > >* Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > >>On 02/20/2016 10:28 PM, Max Reitz wrote: > >>>On 19.02.2016 12:24, Alberto Garcia wrote: > On Fri 19 Feb 2016 09:26:53 AM CET, Wen

[Qemu-devel] [PATCH] qemu-options.hx: add missing chardev id in example of vhost-user

2016-02-22 Thread Lin Ma
Signed-off-by: Lin Ma --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2f0465e..6afa612 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2063,7 +2063,7 @@ Example: @example qemu -m 512 -object memory-backend-f

Re: [Qemu-devel] [PATCH] hw/arm/virt: Assume EL3 boot rom will handle PSCI if one is provided

2016-02-22 Thread Laszlo Ersek
On 02/20/16 12:31, Peter Maydell wrote: > On 19 February 2016 at 21:58, Laszlo Ersek wrote: >> On 02/19/16 22:41, Ard Biesheuvel wrote: >>> On 19 February 2016 at 22:03, Laszlo Ersek wrote: Ard, any opinion on this? >>> >>> I agree with Peter. Note that this is strictly about emulation,

Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:31PM -0700, Eric Blake wrote: > Commit d0d7708b forgot to parse logging for spice chardevs and > virtual consoles. This requires making qemu_chr_parse_common() > non-static. While at it, use a temporary variable to make the > code shorter, as well as reduce the churn w

Re: [Qemu-devel] [PATCH 01/17] chardev: Properly initialize ChardevCommon components

2016-02-22 Thread Paolo Bonzini
On 20/02/2016 01:19, Eric Blake wrote: > Commit d0d7708b forgot to parse logging for spice chardevs and > virtual consoles. This requires making qemu_chr_parse_common() > non-static. While at it, use a temporary variable to make the > code shorter, as well as reduce the churn when a later patch >

Re: [Qemu-devel] [PATCH 03/17] util: Shorten references into SocketAddress

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:33PM -0700, Eric Blake wrote: > An upcoming patch will alter how simple unions, like SocketAddress, > are laid out, which will impact all lines of the form 'addr->u.XXX'. > To minimize the impact of that patch, use C99 initialization or a > temporary variable to reduce

[Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-22 Thread Paolo Bonzini
The xsave and xrstor helpers are accessing the x86_ext_save_areas array using a bit mask instead of a bit position. Provide two sets of XSTATE_* definitions and use XSTATE_*_BIT when a bit position is requested. Signed-off-by: Paolo Bonzini --- target-i386/cpu.c| 29 ++--

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-22 Thread Samuel Thibault
Hello, Thomas Huth, on Mon 22 Feb 2016 08:56:59 +0100, wrote: > would it maybe be applicable to use the > TCPIPHDR_DELTA macro here instead? No, because that includes a round up, while here we need an exact difference. Samuel

Re: [Qemu-devel] [PATCH v2 0/3] memory: an optimization

2016-02-22 Thread Paolo Bonzini
On 22/02/2016 09:34, Gonglei wrote: > Perf top tells me qemu_get_ram_ptr consume some cpu cycles. > > Before this optimization: > 1.26% qemu-kvm [.] qemu_get_ram_ptr > 0.89% qemu-kvm [.] qemu_get_ram_block > > Applied the patch set: > 0.87% qemu-kvm

Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:32PM -0700, Eric Blake wrote: > An upcoming patch will alter how simple unions, like ChardevBackend, > are laid out, which will impact all lines of the form 'backend->u.XXX'. > To minimize the impact of that patch, use a temporary variable to > reduce the number of lin

Re: [Qemu-devel] [PATCH 04/17] ui: Shorten references into InputEvent

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:34PM -0700, Eric Blake wrote: > An upcoming patch will alter how simple unions, like InputEvent, > are laid out, which will impact all lines of the form 'evt->u.XXX'. > To minimize the impact of that patch, use a temporary variable to > reduce the number of lines needi

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread hitmoon
在 2016年02月22日 17:24, Peter Maydell 写道: On 22 February 2016 at 09:11, xiaoqiang zhao wrote: assign DeviceClass::vmsd instead of using vmstate_register function Signed-off-by: xiaoqiang zhao --- hw/timer/m48t59.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ti

[Qemu-devel] [PATCH] hpet: remove unnecessary code from post_load callback

2016-02-22 Thread Paolo Bonzini
The flags are already specified on the command line, so it is not necessary to get them back from the migration stream. They should be already equal on the source and destination machine, unless the destination machine is configured incorrectly. Signed-off-by: Paolo Bonzini --- hw/timer/hpet.c

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Kevin Wolf
Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben: > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > > On 02/20/2016 10:28 PM, Max Reitz wrote: > > >On 19.02.2016 12:24, Alberto Garcia wrote: > > >>On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang > > >>wrote: > > >> > > >If q

Re: [Qemu-devel] [PATCH 05/17] qapi: Avoid use of 'data' member of qapi unions

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:35PM -0700, Eric Blake wrote: > qapi code generators currently create a 'void *data' member as > part of the anonymous union embedded in the C struct corresponding > to a qapi union. However, directly assigning to this member of > the union feels a bit fishy, when we

Re: [Qemu-devel] Memory mapping on MIPS

2016-02-22 Thread Leon Alrae
On 22/02/16 06:56, Igor R wrote: > Here is an excerpt from r4k_map_address(), related to addresses >= 0x8000. > Actually, it maps 0x8010 and 0xA010 to the same physical > address. What's the idea behind that? 0x8010 is kseg0 whereas 0xA010 is kseg1, both segments are unmapped t

[Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

2016-02-22 Thread Markus Schade
The upstream fix for the kernel should be backported to trusty ** Project changed: qemu => linux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1494350 Title: QEMU: causes vCPU steal time overflow

Re: [Qemu-devel] [PATCH 06/17] chardev: Drop useless ChardevDummy type

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:36PM -0700, Eric Blake wrote: > Commit d0d7708b made ChardevDummy be an empty wrapper type around > ChardevCommon. But there is no technical reason for this indirection, > so simplify the code by directly using the base type. > > Also change the fallback assignment t

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-22 Thread Xiao Guangrong
On 02/19/2016 04:43 PM, Dan Williams wrote: On Fri, Feb 19, 2016 at 12:08 AM, Michael S. Tsirkin wrote: On Thu, Feb 18, 2016 at 11:05:23AM +0100, Igor Mammedov wrote: On Thu, 18 Feb 2016 12:03:36 +0800 Xiao Guangrong wrote: On 02/18/2016 01:26 AM, Michael S. Tsirkin wrote: On Wed, Feb 17

Re: [Qemu-devel] [PATCH 07/17] qapi: Drop useless 'data' member of unions

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:37PM -0700, Eric Blake wrote: > Now that we no longer have any clients of the 'void *data' > member injected into unions, we can drop it. Update the > testsuite to drop the negative test union-clash-data, and > replace it with a positive test in qapi-schema-test that

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 22.02.2016 um 10:02 hat Dr. David Alan Gilbert geschrieben: > > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: > > > On 02/20/2016 10:28 PM, Max Reitz wrote: > > > >On 19.02.2016 12:24, Alberto Garcia wrote: > > > >>On Fri 19 Feb 2016 09:26:53 AM CET,

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-22 Thread Xiao Guangrong
On 02/19/2016 04:08 PM, Michael S. Tsirkin wrote: On Thu, Feb 18, 2016 at 11:05:23AM +0100, Igor Mammedov wrote: On Thu, 18 Feb 2016 12:03:36 +0800 Xiao Guangrong wrote: On 02/18/2016 01:26 AM, Michael S. Tsirkin wrote: On Wed, Feb 17, 2016 at 10:04:18AM +0800, Xiao Guangrong wrote: As fo

Re: [Qemu-devel] [PATCH 1/9] dma-helpers: Expose the sg mapping logic

2016-02-22 Thread Paolo Bonzini
On 19/02/2016 12:50, Alex Pyrgiotis wrote: > QEMU/Hardware space: > 5. The SCSI controller code will create a QEMUSGList that points to >the memory regions of the SCSI request. This QEMUSGList will also >include the MMIO regions. > 6. The QEMU device implementation, e.g. scsi-block, choos

Re: [Qemu-devel] [PATCH 12/17] qapi: Don't special-case simple union wrappers

2016-02-22 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 05:19:42PM -0700, Eric Blake wrote: > Simple unions were carrying a special case that hid their 'data' > QMP member from the resulting C struct, via the hack method > QAPISchemaObjectTypeVariant.simple_union_type(). But using the > work we started by unboxing flat union and

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread Peter Maydell
On 22 February 2016 at 10:28, hitmoon wrote: > 在 2016年02月22日 17:24, Peter Maydell 写道: >> Just noticed this won't work as it is -- the vmstate >> struct is for the M48t59State*, but the ISA and >> Sysbus wrappers have their own structs which are >> what the dc->vmsd will be wanting to operate on. >

Re: [Qemu-devel] [V6 0/4] AMD IOMMU

2016-02-22 Thread David Kiarie
On Mon, Feb 22, 2016 at 10:29 AM, Jan Kiszka wrote: > On 2016-02-22 06:57, David Kiarie wrote: >> On Sun, Feb 21, 2016 at 11:20 PM, Jan Kiszka wrote: >>> On 2016-02-21 19:10, David Kiarie wrote: Hello there, Repost, AMD IOMMU patches version 6. Changes since version 5 >>>

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-22 Thread Kevin Wolf
Am 20.02.2016 um 08:11 hat Pavel Dovgalyuk geschrieben: > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 16.02.2016 um 12:20 hat Pavel Dovgalyuk geschrieben: > > > > Coroutine Repl

Re: [Qemu-devel] [PATCH RFC V5 0/9] Implement GIC-500 from GICv3 family for arm64

2016-02-22 Thread Peter Maydell
On 21 February 2016 at 15:32, Peter Maydell wrote: > On 21 February 2016 at 12:30, Shlomo Pongratz > wrote: >> Working of re-basing the GICv3 I've noticed in the mailing list Pavel's >> patch series named "GICv3 live migration support". This patch series >> modifies GICv3 structures. I can see t

Re: [Qemu-devel] [V6 0/4] AMD IOMMU

2016-02-22 Thread Jan Kiszka
On 2016-02-22 12:05, David Kiarie wrote: > On Mon, Feb 22, 2016 at 10:29 AM, Jan Kiszka wrote: >> On 2016-02-22 06:57, David Kiarie wrote: >>> On Sun, Feb 21, 2016 at 11:20 PM, Jan Kiszka wrote: On 2016-02-21 19:10, David Kiarie wrote: > Hello there, > > Repost, AMD IOMMU patches

Re: [Qemu-devel] [V6 4/4] hw/pci-host: Emulate AMD IOMMU

2016-02-22 Thread Marcel Apfelbaum
On 02/21/2016 08:11 PM, David Kiarie wrote: Add AMD IOMMU emulation support to q35 chipset Signed-off-by: David Kiarie --- hw/pci-host/piix.c| 1 + hw/pci-host/q35.c | 14 -- include/hw/i386/intel_iommu.h | 1 + 3 files changed, 14 insertions(+), 2 del

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread xiaoqiang zhao
>> 在 2016年2月22日,19:03,Peter Maydell 写道: >> >>> On 22 February 2016 at 10:28, hitmoon wrote: >>> 在 2016年02月22日 17:24, Peter Maydell 写道: >>> Just noticed this won't work as it is -- the vmstate >>> struct is for the M48t59State*, but the ISA and >>> Sysbus wrappers have their own structs which ar

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-22 Thread xiaoqiang zhao
>> 在 2016年2月22日,19:03,Peter Maydell 写道: >> >>> On 22 February 2016 at 10:28, hitmoon wrote: >>> 在 2016年02月22日 17:24, Peter Maydell 写道: >>> Just noticed this won't work as it is -- the vmstate >>> struct is for the M48t59State*, but the ISA and >>> Sysbus wrappers have their own structs which ar

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-22 Thread Alexey Kardashevskiy
On 02/22/2016 05:26 PM, David Gibson wrote: On Mon, Feb 22, 2016 at 05:09:39PM +1100, Alexey Kardashevskiy wrote: Since a788f227 "memory: Allow replay of IOMMU mapping notifications" when new VFIO listener is added, all existing IOMMU mappings are replayed. However there is a problem that the ba

Re: [Qemu-devel] [PULL 0/1] gtk: fix uninitialized temporary VirtualConsole

2016-02-22 Thread Peter Maydell
lients (2016-02-20 > 00:17:48 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-ui-20160222-1 > > for you to fetch changes up to 327d83ba717c879f5640b41c15af3ce56a7922eb: > > gtk: fix uninitia

Re: [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable

2016-02-22 Thread Cornelia Huck
On Thu, 18 Feb 2016 22:44:12 +0100 Sascha Silbe wrote: > When trying to instantiate an alias that points to a device class that > doesn't exist, the error message looks like qemu misunderstood the > request: > > $ s390x-softmmu/qemu-system-s390x -device virtio-gpu > qemu-system-s390x: -device vi

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-22 Thread Vladimir Sementsov-Ogievskiy
Hi, Marc! Am I right, that this patch is necessary to reproduce your results from "QEMU fw_cfg DMA interface"? QEMU commit 2be4f242b50a8 and SeaBIOS commit 908a58c1d5ff QEMU startup time: .078 BIOS startup time: .060 Kernel setup time: .578 Total time: .716 QEMU with this patch series and Se

Re: [Qemu-devel] [PATCH v2 2/3] qdev-monitor: sort alias table by typename

2016-02-22 Thread Cornelia Huck
On Thu, 18 Feb 2016 22:44:13 +0100 Sascha Silbe wrote: > Sort the alias table by typename so it's easier to see which aliases > exist. > > Signed-off-by: Sascha Silbe > --- > v1->v2: Added comment asking devs to keep table sorted > --- > qdev-monitor.c | 15 --- > 1 file changed, 8

Re: [Qemu-devel] Memory mapping on MIPS

2016-02-22 Thread Igor R
> > Here is an excerpt from r4k_map_address(), related to addresses >= 0x8000. > > Actually, it maps 0x8010 and 0xA010 to the same physical > > address. What's the idea behind that? > > 0x8010 is kseg0 whereas 0xA010 is kseg1, both segments are > unmapped thus both refer to the

Re: [Qemu-devel] Memory mapping on MIPS

2016-02-22 Thread Igor R
> > Here is an excerpt from r4k_map_address(), related to addresses >= 0x8000. > > Actually, it maps 0x8010 and 0xA010 to the same physical > > address. What's the idea behind that? > > 0x8010 is kseg0 whereas 0xA010 is kseg1, both segments are > unmapped thus both refer to the

Re: [Qemu-devel] [PATCH v2 3/3] qdev-monitor: add missing aliases for virtio device classes

2016-02-22 Thread Cornelia Huck
On Thu, 18 Feb 2016 22:44:14 +0100 Sascha Silbe wrote: > virtio-{blk,balloon,net,serial} are aliases for their actual, > architecture-dependent implementations (*-ccw on s390x, *-pci on other > architectures supporting virtio). This makes it a lot easier to craft > qemu invocations that work on a

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-22 Thread David Gibson
On Mon, Feb 22, 2016 at 10:36:19PM +1100, Alexey Kardashevskiy wrote: > On 02/22/2016 05:26 PM, David Gibson wrote: > >On Mon, Feb 22, 2016 at 05:09:39PM +1100, Alexey Kardashevskiy wrote: > >>Since a788f227 "memory: Allow replay of IOMMU mapping notifications" > >>when new VFIO listener is added,

Re: [Qemu-devel] [PATCH v9 3/5] acpi: pc: add fw_cfg device node to dsdt

2016-02-22 Thread Igor Mammedov
On Fri, 19 Feb 2016 13:20:27 -0500 "Gabriel L. Somlo" wrote: > Add a fw_cfg device node to the ACPI DSDT. While the guest-side > firmware can't utilize this information (since it has to access > the hard-coded fw_cfg device to extract ACPI tables to begin with), > having fw_cfg listed in ACPI wil

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-22 Thread Igor Mammedov
On Fri, 19 Feb 2016 13:20:24 -0500 "Gabriel L. Somlo" wrote: Gerd, if you are going to apply it, you'll need to update expected tables for acpi test (rebuild-expected-aml.sh) as a commit on top of this series. > Generate an ACPI DSDT node for fw_cfg on pc and arm guests. > > New since v8: > >

Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000

2016-02-22 Thread Amit Shah
On (Thu) 11 Feb 2016 [14:04:06], Paolo Bonzini wrote: > > > On 05/02/2016 14:56, Amit Shah wrote: > > Commit 8304402033e8dbe8e379017d51ed1dd8344f1dce changed the name of the > > e1000-82540em device to e1000. This was flagged: > > > >Section "e1000-82540em" does not exist in dest > > > > A

[Qemu-devel] [PATCH RFC] fw-cfg: support writeable blobs

2016-02-22 Thread Michael S. Tsirkin
Useful to send guest data back to QEMU. The write interface is restricted to DMA. Suggested-by: Kevin O'Connor Signed-off-by: Michael S. Tsirkin --- hw/lm32/lm32_hwsetup.h| 2 +- include/hw/loader.h | 4 ++-- include/hw/nvram/fw_cfg.h | 3 ++- hw/arm/virt-acpi-build.c | 2 +- hw

Re: [Qemu-devel] [PATCH 1/4] qemu-img: Fix preallocation with -S 0 for convert

2016-02-22 Thread Kevin Wolf
Am 20.02.2016 um 18:39 hat Max Reitz geschrieben: > When passing -S 0 to qemu-img convert, the target image is supposed to > be fully allocated. Right now, this is not the case if the source image > contains areas which bdrv_get_block_status() reports as being zero. > > This patch introduces a new

Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-22 Thread Christian Borntraeger
On 02/19/2016 04:18 PM, Wei Yang wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang > CC: Cornelia Huck > CC: Christian Born

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Alberto Garcia
On Sat 20 Feb 2016 03:28:03 PM CET, Max Reitz wrote: >> That said, I'm not very convinced of the current logics of the Quorum >> flush code either, so it's not even a problem with your patch... it >> seems to me that the code should follow the same logics as in the >> read/write case: if the numb

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-22 Thread Alberto Garcia
On Mon 22 Feb 2016 02:31:30 PM CET, Alberto Garcia wrote: >> Anyway, regardless of that, if we do take the threshold into account, >> we should not use the exact error value for voting but just whether >> an error occurred or not. If all but one children fail to flush (all >> for different reasons)

Re: [Qemu-devel] [PATCH v2 00/17] throttle: Allow I/O bursts for a user-defined period of time

2016-02-22 Thread Kevin Wolf
Am 18.02.2016 um 11:26 hat Alberto Garcia geschrieben: > Hi, > > here's a new version of the series that adds support for performing > I/O bursts for a user-defined period of time. Please follow the link > to the first version of the series for a complete description. > > There are two important

Re: [Qemu-devel] [RFC PATCH 00/16] Qemu Bit Map (QBM) - an overlay format for persistent dirty bitmap

2016-02-22 Thread Kevin Wolf
Am 26.01.2016 um 11:38 hat Fam Zheng geschrieben: > This series introduces a simple format to enable support of persistence of > block dirty bitmaps. Block dirty bitmap is the tool to achieve incremental > backup, and persistence of block dirty bitmap makes incrememtal backup > possible > across V

Re: [Qemu-devel] [PATCH RFC] fw-cfg: support writeable blobs

2016-02-22 Thread Gerd Hoffmann
On Mo, 2016-02-22 at 14:41 +0200, Michael S. Tsirkin wrote: > Useful to send guest data back to QEMU. Use case? cheers, Gerd

Re: [Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush operation

2016-02-22 Thread Alberto Garcia
On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote: > -winner = quorum_get_vote_winner(&error_votes); > -result = winner->value.l; > - > +if (success_count >= s->threshold) > +result = 0; > +else { > +winner = quorum_get_vote_winner(&error_votes); > +res

[Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts

2016-02-22 Thread Paolo Bonzini
In short, this patch gets rid of blockdev_mark_auto_del and blockdev_auto_del. With these patches, it is possible to create a new -drive with the same id as soon as the DEVICE_DELETED event is delivered (which equals to unrealize). I'm sorry I'm not able to explain the history (and probably do no

  1   2   3   4   >