Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-19 Thread Greg Kurz
On Fri, 19 Feb 2016 11:11:47 +1100 David Gibson wrote: > On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent unconditionally. > > > > We assume that QEMU 2.3 is more dep

[Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-02-19 Thread Michael S. Tsirkin
The following changes since commit a5af12871fd4601c44f08d9e49131e9ca13ef102: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2016-02-12' into staging (2016-02-12 17:36:12 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_up

[Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked

2016-02-19 Thread Michael S. Tsirkin
commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen") inadvertently enabled the xen-specific logic unconditionally. Limit it to only when xen is enabled. Additionally, msix data should be read with pci_get_log since the format is pci little-endian. Reported-by: "Daniel P. Be

[Qemu-devel] [PULL 01/13] virtio-net: use the backend cross-endian capabilities

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz When running a fully emulated device in cross-endian conditions, including a virtio 1.0 device offered to a big endian guest, we need to fix the vnet headers. This is currently handled by the virtio_net_hdr_swap() function in the core virtio-net code but it should actually be hand

[Qemu-devel] [PULL 03/13] virtio: move cross-endian helper to vhost

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() indeed returns the runtime state of the virtio device. However, it returns false unconditionally in the general case. This sounds a bit strange given the name of the function. This helper is only useful for

[Qemu-devel] [PULL 10/13] change type of pci_bridge_initfn() to void

2016-02-19 Thread Michael S. Tsirkin
From: Cao jin Since it can`t fail. Also modify the callers. Signed-off-by: Cao jin Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum --- include/hw/pci/pci_bridge.h| 2 +- hw/pci-bridge/i82801b11.c

[Qemu-devel] [PULL 05/13] vhost: simplify vhost_needs_vring_endian()

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz After the call to virtio_vdev_has_feature(), we only care for legacy devices, so we don't need the extra check in virtio_is_big_endian(). Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN may only happen on a virtio_load() path that cannot lead here), so we

[Qemu-devel] [PULL 02/13] vhost-net: revert support of cross-endian vnet headers

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz Cross-endian is now handled by the core virtio-net code. This patch reverts: commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness and commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56 net: set endianness on all bac

[Qemu-devel] [PULL 06/13] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro and the virtio_access_is_big_endian() helper to have a branchless fast path in the virtio memory accessors for targets that don't switch endian. This was considered as a strong requirement at the time.

[Qemu-devel] [PULL 04/13] vhost: move virtio 1.0 check to cross-endian helper

2016-02-19 Thread Michael S. Tsirkin
From: Greg Kurz Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Reviewed-by: Cornelia Huck Signed-off-by: Greg Kurz Reviewed-by: M

[Qemu-devel] [PULL 13/13] tests/vhost-user-bridge: add scattering of incoming packets

2016-02-19 Thread Michael S. Tsirkin
From: Victor Kaplansky This patch adds to the vubr test the scattering of incoming packets to the chain of RX buffer. Also, this patch corrects the size of the header preceding the packet in RX buffers. Note that this patch doesn't add the support for mergeable buffers. Signed-off-by: Victor K

[Qemu-devel] [PULL 08/13] tests: add pxe e1000 and virtio-pci tests

2016-02-19 Thread Michael S. Tsirkin
From: Victor Kaplansky The test is based on bios-tables-test.c. It creates a file with the boot sector image and loads it into a guest using PXE and TFTP functionality. Cc: Jason Wang Signed-off-by: Victor Kaplansky Suggested-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin Signed-off

Re: [Qemu-devel] [PATCH] fw_cfg: unbreak migration compatibility for 2.4 and earlier machines

2016-02-19 Thread Alexandre DERUMIER
>>... but some actual migration testing would be great indeed. I have sent a patched version build to proxmox users for testing, I'm waiting for their results - Mail original - De: "kraxel" À: "Laszlo Ersek" Cc: "qemu-devel" , "Marc Mar?" , "aderumier" , "qemu-stable" Envoyé: Vendred

[Qemu-devel] [PULL 09/13] dec: convert to realize()

2016-02-19 Thread Michael S. Tsirkin
From: Cao jin Also because pci_bridge_initfn() can`t fail. Signed-off-by: Cao jin Reviewed-by: Markus Armbruster Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/dec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-19 Thread Michael S. Tsirkin
On Thu, Feb 18, 2016 at 11:05:23AM +0100, Igor Mammedov wrote: > On Thu, 18 Feb 2016 12:03:36 +0800 > Xiao Guangrong wrote: > > > On 02/18/2016 01:26 AM, Michael S. Tsirkin wrote: > > > On Wed, Feb 17, 2016 at 10:04:18AM +0800, Xiao Guangrong wrote: > > > As for the rest could that commands

[Qemu-devel] [PULL 11/13] rules: filter out irrelevant files

2016-02-19 Thread Michael S. Tsirkin
It's often handy to make executables depend on each other, e.g. make a test depend on a helper. This doesn't work now, as linker will attempt to use the helper as an object. To fix, filter only relevant file types before linking an executable. Signed-off-by: Michael S. Tsirkin --- rules.mak | 2

[Qemu-devel] [PULL 12/13] vhost-user interrupt management fixes

2016-02-19 Thread Michael S. Tsirkin
From: Victor Kaplansky Since guest_mask_notifier can not be used in vhost-user mode due to buffering implied by unix control socket, force use_mask_notifier on virtio devices of vhost-user interfaces, and send correct callfd to the guest at vhost start. Using guest_notifier_mask function in vhos

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-19 Thread Wen Congyang
On 02/18/2016 11:16 PM, Alberto Garcia wrote: > On Tue 16 Feb 2016 03:15:44 AM CET, Changlong Xie > wrote: >> If quorum has two children(A, B). A do flush sucessfully, but B flush >> failed. We MUST choice A as winner rather than just pick anyone of >> them. Otherwise the filesystem of guest wil

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Feb 18, 2016 at 01:39:39PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This is another attempt to remove old q35 machine code. Now I am >> > also removing unused compat code to demonstrate the benefit of >> > throwing away the old code th

Re: [Qemu-devel] [PATCH v11 03/15] qapi: Forbid 'any' inside an alternate

2016-02-19 Thread Markus Armbruster
Eric Blake writes: > On 02/18/2016 10:03 AM, Markus Armbruster wrote: > Could use a test for alternate member of alternate type. >>> >>> One step ahead of you: commit 3d0c4829 added the test >>> alternate-nested.json, and commits 44bd1276 and dd883c6f fixed the >>> parser to reject it (first

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Jan Kiszka
On 2016-02-19 08:43, Peter Xu wrote: > Hi, Jan, > > On Fri, Feb 19, 2016 at 07:46:26AM +0100, Jan Kiszka wrote: >> Hi Peter, >> >> On 2016-02-19 04:30, Peter Xu wrote: >>> This patchset provide very basic functionalities for interrupt >>> remapping (IR) support of the emulated Intel IOMMU device.

Re: [Qemu-devel] [PATCH v15 7/9] Introduce new APIs to do replication operation

2016-02-19 Thread Hailiang Zhang
Hi, On 2016/2/15 9:13, Wen Congyang wrote: On 02/15/2016 08:57 AM, Hailiang Zhang wrote: On 2016/2/5 12:18, Changlong Xie wrote: Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-cor

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-19 Thread Dan Williams
On Fri, Feb 19, 2016 at 12:08 AM, Michael S. Tsirkin wrote: > On Thu, Feb 18, 2016 at 11:05:23AM +0100, Igor Mammedov wrote: >> On Thu, 18 Feb 2016 12:03:36 +0800 >> Xiao Guangrong wrote: >> >> > On 02/18/2016 01:26 AM, Michael S. Tsirkin wrote: >> > > On Wed, Feb 17, 2016 at 10:04:18AM +0800, Xi

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-19 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 02/18 16:41, Stefan Hajnoczi wrote: >> On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: >> > On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy >> > wrote: >> > > On 16.02.2016 20:09, Stefan Hajnoczi wrote: >> > > >On Wed, Feb 10

Re: [Qemu-devel] [PATCH v15 7/9] Introduce new APIs to do replication operation

2016-02-19 Thread Wen Congyang
On 02/19/2016 04:41 PM, Hailiang Zhang wrote: > Hi, > > On 2016/2/15 9:13, Wen Congyang wrote: >> On 02/15/2016 08:57 AM, Hailiang Zhang wrote: >>> On 2016/2/5 12:18, Changlong Xie wrote: Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O from the client. But we still can't do I/O in size larger than s->msize. If you look at the client side (kernel 9p fs), you will find

Re: [Qemu-devel] SUMMARY: Re: [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-19 Thread Vladimir Sementsov-Ogievskiy
On 19.02.2016 10:12, Denis V. Lunev wrote: On 02/18/2016 08:23 PM, Denis V. Lunev wrote: On 02/18/2016 07:35 PM, Eric Blake wrote: On 02/18/2016 02:18 AM, Roman Kagan wrote: On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: On 02/17/2016 11:10 AM, Denis V. Lunev wrote: @@ -446,6 +4

Re: [Qemu-devel] [PATCH v5] vhost-user interrupt management fixes

2016-02-19 Thread Didier Pallard
Hi victor, I'm sorry, i didn't get time to work on this patch. Thanks for your work. didier On 02/18/2016 03:12 PM, Victor Kaplansky wrote: Since guest_mask_notifier can not be used in vhost-user mode due to buffering implied by unix control socket, force use_mask_notifier on virtio devices o

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-19 Thread Didier Pallard
On 02/10/2016 01:15 PM, Daniel P. Berrange wrote: On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote

Re: [Qemu-devel] SUMMARY: Re: [RFC 1/1] nbd (specification): add NBD_CMD_WRITE_ZEROES command

2016-02-19 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 10:12:09AM +0300, Denis V. Lunev wrote: > On 02/18/2016 08:23 PM, Denis V. Lunev wrote: > >On 02/18/2016 07:35 PM, Eric Blake wrote: > >>On 02/18/2016 02:18 AM, Roman Kagan wrote: > >>>On Wed, Feb 17, 2016 at 01:58:47PM -0700, Eric Blake wrote: > On 02/17/2016 11:10 AM,

[Qemu-devel] [PATCH v2 11/12] spice: add & use qemu_spice_gl_monitor_config

2016-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/spice-display.h | 1 + ui/spice-display.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h index dd9cf6f..f9388c2 100644 --- a/include/ui/spice-display.

[Qemu-devel] [PATCH v2 06/12] spice: add unblock timer

2016-02-19 Thread Gerd Hoffmann
Pure debug aid, print a warning in case unblocking doesn't happen within one second. Signed-off-by: Gerd Hoffmann --- include/ui/spice-display.h | 1 + ui/spice-display.c | 16 2 files changed, 17 insertions(+) diff --git a/include/ui/spice-display.h b/include/ui/spice

[Qemu-devel] [PATCH v2 02/12] configure: add dma-buf support detection.

2016-02-19 Thread Gerd Hoffmann
Set CONFIG_OPENGL_DMABUF in case both mesa and libepoxy are new enough to have support for dma-buf import/export. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- configure | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/configure b/config

[Qemu-devel] [PATCH v2 03/12] egl-helpers: add functions for render nodes and dma-buf passing

2016-02-19 Thread Gerd Hoffmann
Adds helpers to open a drm render node and create a opengl context for it. Also add a helper to export a texture as dma-buf. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/egl-helpers.h | 13 + ui/egl-helpers.c | 129

[Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

2016-02-19 Thread Gerd Hoffmann
Current spice client expects we create a primary surface, even if we do display updates using dma-bufs exclusively. So just do that to get things going. Not fully clear whenever that is intentional or a bug on the spice side, so I keep this as separate patch for now. I think this should either b

[Qemu-devel] [PATCH v2 07/12] spice: tweak debug messages.

2016-02-19 Thread Gerd Hoffmann
Adjust message levels, make messages more verbose. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index d6e31e4..242ab5f 100644 --- a/ui/spice-display.c +++ b/ui/spice-di

Re: [Qemu-devel] [PULL 08/17] block: Assert no write requests under BDRV_O_INCOMING

2016-02-19 Thread Kevin Wolf
Am 18.02.2016 um 17:03 hat Laurent Vivier geschrieben: > Hi, > > this commit breaks incoming migration case: > > qemu-system-ppc64 XXX -incoming tcp:0: > qemu-system-ppc64: .../qemu/block/io.c:1304: bdrv_co_do_pwritev: > Assertion `!(bs->open_flags & 0x0800)' failed. > > Without "-incoming",

[Qemu-devel] [PATCH v2 04/12] spice: reset cursor on resize

2016-02-19 Thread Gerd Hoffmann
From: Marc-André Lureau Spice server will clear the cursor on resize. QXL driver reset it after resize, however, virtio and other devices do not. Teach qemu to set it back. Signed-off-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 14 -- 1 file changed

[Qemu-devel] [PATCH v2 12/12] [fixup] spice: qemu_spice_gl_monitor_config + surface

2016-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index 34e6d51..806851f 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -922,6 +922,10 @@ static void spice_gl_switch(DisplayChangeListene

[Qemu-devel] [PATCH v2 05/12] spice: add opengl/virgl/dmabuf support

2016-02-19 Thread Gerd Hoffmann
This adds support for dma-buf passing to spice. This makes virtio-gpu with 3d acceleration work with spice. Workflow: * virglrenderer renders the guest command stream into a texture. * qemu exports the texture as dma-buf and passes on that dma-buf to spice-server. * spice-server passes the

[Qemu-devel] [PATCH v2 01/12] spice: init dcl before registering qxl interface

2016-02-19 Thread Gerd Hoffmann
Without this spice might callback into qemu before ssd->dcl.con is initialized, resulting in a segfault due to NULL pointer dereference. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-dis

[Qemu-devel] [PATCH v2 08/12] console: track gl_block state in QemuConsole

2016-02-19 Thread Gerd Hoffmann
Keep track of gl_block state (added in bba19b8 console: block rendering until client is done) in QemuConsole and allow to query it. This way we can avoid state inconsistencies in case different code paths make use of this. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include

[Qemu-devel] [PATCH v2 09/12] spice/gl: render DisplaySurface via opengl

2016-02-19 Thread Gerd Hoffmann
This switches over spice (in opengl mode) to render DisplaySurface updates into a opengl texture, using the helper functions in ui/console-gl.c. With this patch applied spice (with gl=on) will stop using qxl rendering ops, it will use dma-buf passing all the time, i.e. for bios/bootloader (before

[Qemu-devel] [PATCH v2 00/12] spice: add opengl/virgl/dmabuf support

2016-02-19 Thread Gerd Hoffmann
Hi, This patch series adds support for opengl and dma-buf passing to spice. With this in place you can use virtio-gpu in 3d (virgl) mode with spice. In v2 I've reordered the patches a bit, cherry-picked the forgotton monitor-config patch, addressed the review comments from Marc. Merge plan: P

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Peter Xu
On Fri, Feb 19, 2016 at 09:34:40AM +0100, Jan Kiszka wrote: > On 2016-02-19 08:43, Peter Xu wrote: > > Hi, Jan, > > > > On Fri, Feb 19, 2016 at 07:46:26AM +0100, Jan Kiszka wrote: > >> Hi Peter, > >> > >> On 2016-02-19 04:30, Peter Xu wrote: > >>> This patchset provide very basic functionalities f

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Greg, From: Jevon Qiao Date: Sun, 14 Feb 2016 15:11:08 +0800 Subject: [PATCH] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize. Per the previous implementation, iounit will be assigned to be 0 after the first if statement as (s->msize - P9_IOHDRSZ)

Re: [Qemu-devel] [PATCH v2 7/9] i.MX: Add i.MX6 SOC implementation.

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 06:32, Jean-Christophe DUBOIS wrote: > Le 18/02/2016 22:46, Peter Maydell a écrit : >> Does SMP work with EL3 not enabled, or is this a different bug? > > > If I set has_el3 to false, I can boot the 4 cores without problem. With > has_el3 set to true (default value) I am get

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 00:07, Peter Crosthwaite wrote: > On Thu, Feb 18, 2016 at 1:47 PM, Paolo Bonzini wrote: >> >> >> On 18/02/2016 10:56, Markus Armbruster wrote: >>> Alistair Francis writes: >>> If the device being added when running qdev_device_add() has a reset function, register it so t

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-19 Thread Markus Armbruster
David Gibson writes: > On Thu, Feb 18, 2016 at 11:37:39AM +0100, Igor Mammedov wrote: >> On Thu, 18 Feb 2016 14:39:52 +1100 >> David Gibson wrote: >> >> > On Tue, Feb 16, 2016 at 11:36:55AM +0100, Igor Mammedov wrote: >> > > On Mon, 15 Feb 2016 20:43:41 +0100 >> > > Markus Armbruster wrote: >>

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 10:29, Peter Xu wrote: > On Fri, Feb 19, 2016 at 09:34:40AM +0100, Jan Kiszka wrote: >> On 2016-02-19 08:43, Peter Xu wrote: >>> Actually there are several people within my working team knows that >>> I would be working on this, and I believe none of us do know your >>> work too...

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/02/2016 10:56, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> If the device being added when running qdev_device_add() has >>> a reset function, register it so that it can be called. >>> >>> Signed-off-by: Alistair Francis >>> --- >>> >>> qdev-monito

[Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Add property to specify rocker world. All ports will be assigned to this world. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c

[Qemu-devel] [patch qemu 1/3] rocker: forbid to change world type

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Port to world assignment should be permitted only by qemu user. Driver should not be able to do it, so forbid that possibility. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.c| 8 +++- hw/net/rocker/rocker_fp.c | 5 + hw/net/rocker/rocker_fp.h | 1 + 3 files c

[Qemu-devel] [patch qemu 0/3] rocker: prepare for easy addition of other worlds

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko This patchset does couple of small changes in order to prepare for smooth addition of other worlds, like P4 and BPF. qemu user will be able to request desired rocker world by "world=worldname" property. Jiri Pirko (3): rocker: forbid to change world type rocker: add name fie

[Qemu-devel] [patch qemu 2/3] rocker: add name field into WorldOps ale let world specify its name

2016-02-19 Thread Jiri Pirko
From: Jiri Pirko Also use this in world_name getter function. Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker_of_dpa.c | 1 + hw/net/rocker/rocker_world.c | 7 +-- hw/net/rocker/rocker_world.h | 1 + 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/net/rocker/rocker_o

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Jan Kiszka
On 2016-02-19 10:58, Paolo Bonzini wrote: > > > On 19/02/2016 10:29, Peter Xu wrote: >> On Fri, Feb 19, 2016 at 09:34:40AM +0100, Jan Kiszka wrote: >>> On 2016-02-19 08:43, Peter Xu wrote: Actually there are several people within my working team knows that I would be working on this, an

Re: [Qemu-devel] [PULL 08/17] block: Assert no write requests under BDRV_O_INCOMING

2016-02-19 Thread Laurent Vivier
On 19/02/2016 10:17, Kevin Wolf wrote: > Am 18.02.2016 um 17:03 hat Laurent Vivier geschrieben: >> Hi, >> >> this commit breaks incoming migration case: >> >> qemu-system-ppc64 XXX -incoming tcp:0: >> qemu-system-ppc64: .../qemu/block/io.c:1304: bdrv_co_do_pwritev: >> Assertion `!(bs->open_fl

[Qemu-devel] [PATCH v2 01/11] vfio: extract vfio_get_hot_reset_info as a single function

2016-02-19 Thread Cao jin
From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2 09/11] vfio: vote a device to do host bus reset

2016-02-19 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/vfio/pci.c | 57 + hw/vfio/pci.h | 1 + 2 files changed, 58 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 24848c9..8e902d2 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -

[Qemu-devel] [PATCH v2 00/11] vfio-pci: pass the aer error to guest, part2

2016-02-19 Thread Cao jin
From: Chen Fan v1-v2: 1. limit all devices on same bus in guest are on same bus in host in patch 5/11. 2. patch 05/11 ~ 09/11 has been changed. Chen Fan (11): vfio: extract vfio_get_hot_reset_info as a single function vfio: squeeze out vfio_pci_do_hot_reset for support bus reset vfi

[Qemu-devel] [PATCH v2 03/11] vfio: add pcie extended capability support

2016-02-19 Thread Cao jin
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. due to add a new pcie capability at the tail of the chain, in order to avoid config space overwritten, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signe

[Qemu-devel] [PATCH v2 02/11] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2016-02-19 Thread Cao jin
From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c ind

[Qemu-devel] [PATCH v2 06/11] pci: add a is_valid_func callback to check device if complete

2016-02-19 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/pci/pci.c | 39 +++ include/hw/pci/pci.h | 1 + 2 files changed, 40 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index d940f79..72650c5 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1836,6 +

[Qemu-devel] [PATCH v2 04/11] vfio: add aer support for vfio device

2016-02-19 Thread Cao jin
From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81 --- hw/vfio/pci.h | 3 +++ 2 fil

[Qemu-devel] [PATCH v2 05/11] vfio: add check host bus reset is support or not

2016-02-19 Thread Cao jin
From: Chen Fan when boot up a VM that assigning vfio devices with aer enabled, we must check the vfio device whether support host bus reset. because when one error occur. OS driver always recover the device by do a bus reset, in order to recover the vfio device, qemu must to do a host bus reset t

[Qemu-devel] [PATCH v2 07/11] vfio: add check aer functionality for hotplug device

2016-02-19 Thread Cao jin
From: Chen Fan Signed-off-by: Chen Fan --- hw/vfio/pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 0898e34..24848c9 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3034,6 +3034,20 @@ post_reset: vfio_pci_post_reset(vdev); }

[Qemu-devel] [PATCH v2 08/11] pci: introduce pci bus pre reset

2016-02-19 Thread Cao jin
From: Chen Fan in order to distinguish a hot reset with a normal reset. we add this pre reset call back to notice that we should do a hot reset for all devices. Signed-off-by: Chen Fan --- hw/core/qdev.c | 4 ++-- hw/pci/pci.c | 11 +++ hw/pci/pci_bridge.c |

Re: [Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18

2016-02-19 Thread Peter Maydell
On 18 February 2016 at 20:05, Alex Williamson wrote: > The following changes since commit dd5e38b19d7cb07d317e1285941d8245c01da540: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160218-1' into staging (2016-02-18 > 15:20:35 +) > > are available in the git repo

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 09:33, Paolo Bonzini wrote: > Any abstraction we have in QEMU should have at least a parallel (though > it need not be the same) in real hardware. Reset signals _do_ propagate > along buses, or at least along some buses, so "debusifying" reset seems > like a counterproducti

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread hitmoon
在 2016年02月18日 21:48, Peter Maydell 写道: On 16 February 2016 at 11:10, xiaoqiang zhao wrote: assign tusb6010_init to tusb6010_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao (Again, I didn't review this patch.) --- hw/time

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

2016-02-19 Thread Alberto Garcia
On Fri 19 Feb 2016 09:26:53 AM CET, Wen Congyang wrote: >>> If quorum has two children(A, B). A do flush sucessfully, but B >>> flush failed. We MUST choice A as winner rather than just pick >>> anyone of them. Otherwise the filesystem of guest will become >>> read-only with following errors: >>

[Qemu-devel] [PATCH] target-arm: Implement MDCR_EL3.TPM and MDCR_EL2.TPM traps

2016-02-19 Thread Peter Maydell
Implement the performance monitor register traps controlled by MDCR_EL3.TPM and MDCR_EL2.TPM. Most of the performance registers already have an access function to deal with the user-enable bit, and the TPM checks can be added there. We also need a new access function which only implements the TPM c

[Qemu-devel] Spice File Drag + Drop from / to guest does not work

2016-02-19 Thread Erik Rull
Hi all, I got a Windows 8.1 guest running on ubuntu 14.04 / qemu-kvm 2.0.0 including spice support. I can connect the spice client to the guest and the copy / paste of text from / to the client works (virtio serial port is running and the agent is running on Windows. But what I cannot get runnin

Re: [Qemu-devel] [RFC v7 16/16] target-arm: aarch64: add atomic instructions

2016-02-19 Thread Alex Bennée
Alvise Rigo writes: > Use the new LL/SC runtime helpers to handle the aarch64 atomic instructions > in softmmu_llsc_template.h. > > The STXP emulation required a dedicated helper to handle the paired > doubleword case. > > Suggested-by: Jani Kokkonen > Suggested-by: Claudio Fontana > Signed-of

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Peter Xu
On Fri, Feb 19, 2016 at 10:58:12AM +0100, Paolo Bonzini wrote: > > > On 19/02/2016 10:29, Peter Xu wrote: > > On Fri, Feb 19, 2016 at 09:34:40AM +0100, Jan Kiszka wrote: > >> On 2016-02-19 08:43, Peter Xu wrote: > >>> Actually there are several people within my working team knows that > >>> I wou

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 11:02, hitmoon wrote: > Hi: peter > After some debug, I found > > s->musb = musb_init(dev, 1); > > must be called in SysBus' init. Otherwise it will break the > "/arm/device/introspect/concrete" check test. Mmm, I thought this might be related to the MUSB code. I think th

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Peter Xu
On Fri, Feb 19, 2016 at 11:15:06AM +0100, Jan Kiszka wrote: > On 2016-02-19 10:58, Paolo Bonzini wrote: > > I think you're not verifying the SVT, SID and SQ fields in the IRTE. > > Exactly. > > > > > The source ID can be passed to the IOMMU using the MemTxAttrs mechanism. > > Ah, that's a nice

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Jan Kiszka
On 2016-02-19 12:34, Peter Xu wrote: > On Fri, Feb 19, 2016 at 10:58:12AM +0100, Paolo Bonzini wrote: >> >> The source ID can be passed to the IOMMU using the MemTxAttrs mechanism. > > I see that MemTxAttrs is not enabled yet? It's dropped in all the > accessors like memory_region_write_accessor()

Re: [Qemu-devel] [PATCH 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-02-19 Thread Jan Kiszka
On 2016-02-19 12:39, Peter Xu wrote: > On Fri, Feb 19, 2016 at 11:15:06AM +0100, Jan Kiszka wrote: >> On 2016-02-19 10:58, Paolo Bonzini wrote: >>> I think you're not verifying the SVT, SID and SQ fields in the IRTE. >> >> Exactly. >> >>> >>> The source ID can be passed to the IOMMU using the MemTx

Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation

2016-02-19 Thread Alex Bennée
Alvise Rigo writes: > This is the seventh iteration of the patch series which applies to the > upstream branch of QEMU (v2.5.0-rc4). > > Changes versus previous versions are at the bottom of this cover letter. > > The code is also available at following repository: > https://git.virtualopensyste

Re: [Qemu-devel] [PATCH 1/9] dma-helpers: Expose the sg mapping logic

2016-02-19 Thread Alex Pyrgiotis
Hi Paolo, Sorry for the late reply and thanks for the review. See my comments inline: On 02/11/2016 01:17 PM, Paolo Bonzini wrote: > > > On 16/12/2015 17:55, Alex Pyrgiotis wrote: >> +/* >> + * Create a QEMUIOVector from a scatter-gather list. >> + * >> + * This function does not copy the data

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread xiaoqiang zhao
> 在 2016年2月19日,19:37,Peter Maydell 写道: > > Mmm, I thought this might be related to the MUSB code. > I think this device cannot be converted properly to current > QOM standards until the MUSB code which it relies on has > been converted first. Reasonable !

[Qemu-devel] %cpu used by qemu-kvm processes

2016-02-19 Thread Jean-Pierre Ribeauville
Hi, My Guest users ask me why , from Host point of view , there is a big difference interm of CPU % used by qemu-kvmcontrolling processs : Result of "top" on the host : For Windows guests: 8680 qemu 20 0 4939588 4.092g 9668 S 12.6 8.7 927:46.78 qemu-kvm 47377 qemu 20 0 290

Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation

2016-02-19 Thread alvise rigo
On Fri, Feb 19, 2016 at 12:44 PM, Alex Bennée wrote: > > Alvise Rigo writes: > >> This is the seventh iteration of the patch series which applies to the >> upstream branch of QEMU (v2.5.0-rc4). >> >> Changes versus previous versions are at the bottom of this cover letter. >> >> The code is also a

Re: [Qemu-devel] %cpu used by qemu-kvm processes

2016-02-19 Thread Daniel P. Berrange
On Fri, Feb 19, 2016 at 11:58:38AM +, Jean-Pierre Ribeauville wrote: > Hi, > > My Guest users ask me why , from Host point of view , there is a big > difference interm of CPU % used by qemu-kvmcontrolling processs : > > Result of "top" on the host : > > For Windows guests: > > 8680 qemu

[Qemu-devel] [PATCH] tusb6010: move from hw/timer to hw/usb

2016-02-19 Thread Peter Maydell
The TUSB6010 is a USB controller (as the name suggests). Move it from hw/timer (where it was accidentally filed in 2013 when we moved everything out of hw/) to hw/usb. Signed-off-by: Peter Maydell --- hw/timer/Makefile.objs | 1 - hw/usb/Makefile.objs | 2 ++ hw/{timer => usb}/tusb

Re: [Qemu-devel] %cpu used by qemu-kvm processes

2016-02-19 Thread Jean-Pierre Ribeauville
Hi, As I'm using a RHEV platform , most of these options are automatically adjusted by ovirt ( I presume) . Linux Guest: qemu 120443 1 1 Feb16 ?00:59:57 /usr/libexec/qemu-kvm -name VM_RHEL7-1 -S -machine rhel6.5.0,accel=kvm,usb=off -cpu SandyBridge -m 4096 -realtime mlock

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 08:00, Michael S. Tsirkin wrote: > The following changes since commit a5af12871fd4601c44f08d9e49131e9ca13ef102: > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2016-02-12' into > staging (2016-02-12 17:36:12 +) > > are available in the git repository at

[Qemu-devel] [PULL 02/15] qapi: Simplify excess input reporting in input visitors

2016-02-19 Thread Markus Armbruster
From: Eric Blake When reporting that an unvisited member remains at the end of an input visit for a struct, we were using g_hash_table_find() coupled with a callback function that always returns true, to locate an arbitrary member of the hash table. But if all we need is an arbitrary entry, we c

[Qemu-devel] [PULL 12/15] qapi-visit: Use common idiom in gen_visit_fields_decl()

2016-02-19 Thread Markus Armbruster
From: Eric Blake We have several instances of methods that do an early exit if output is not needed, then log that output is being generated, and finally produce the output; see qapi-types.py:gen_object() and qapi-visit.py:gen_visit_implicit_struct(). The odd man out was gen_visit_fields_decl();

[Qemu-devel] [PULL 01/15] qapi-visit: Honor prefix of discriminator enum

2016-02-19 Thread Markus Armbruster
From: Eric Blake When we added support for a user-specified prefix for an enum type (commit 351d36e), we forgot to teach the qapi-visit code to honor that prefix in the case of using a prefixed enum as the discriminator for a flat union. While there is still some on-list debate on whether we wan

[Qemu-devel] [PULL 09/15] qapi-visit: Less indirection in visit_type_Foo_fields()

2016-02-19 Thread Markus Armbruster
From: Eric Blake We were passing 'Foo **obj' to the internal helper function, but all uses within the helper were via reads of '*obj'. Refactor things to pass one less level of indirection, by having the callers dereference before calling. For an example of the generated code change: |-static

[Qemu-devel] [PULL 04/15] qapi: Forbid 'any' inside an alternate

2016-02-19 Thread Markus Armbruster
From: Eric Blake The whole point of an alternate is to allow some type-safety while still accepting more than one JSON type. Meanwhile, the 'any' type exists to bypass type-safety altogether. The two are incompatible: you can't accept every type, and still tell which branch of the alternate to

[Qemu-devel] [PULL 11/15] qapi: Emit structs used as variants in topological order

2016-02-19 Thread Markus Armbruster
From: Eric Blake Right now, we emit the branches of union types as a boxed pointer, and it suffices to have a forward declaration of the type. However, a future patch will swap things to directly use the branch type, instead of hiding it behind a pointer. For this to work, the compiler needs th

[Qemu-devel] [PULL 08/15] qapi-visit: Unify struct and union visit

2016-02-19 Thread Markus Armbruster
gen_visit_union() is now just like gen_visit_struct(). Rename it to gen_visit_object(), use it for structs, and drop gen_visit_struct(). Output is unchanged. Signed-off-by: Markus Armbruster Message-Id: <1453902888-20457-4-git-send-email-arm...@redhat.com> [split out variant handling, rebase to

[Qemu-devel] [PULL 03/15] qapi: Forbid empty unions and useless alternates

2016-02-19 Thread Markus Armbruster
From: Eric Blake Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We happen to inject a dummy 'void *data' member into the C unions that represent QAPI unions and alternates, but we want to get rid of that member (it pollutes the namespace

[Qemu-devel] [PULL 05/15] qapi: Add tests of complex objects within alternate

2016-02-19 Thread Markus Armbruster
From: Eric Blake Upcoming patches will adjust how we visit an object branch of an alternate; but we were completely lacking testsuite coverage. Rectify this, so that the future patches will be able to highlight the changes and still prove that we avoided regressions. In particular, the use of a

[Qemu-devel] [PULL 07/15] qapi: Visit variants in visit_type_FOO_fields()

2016-02-19 Thread Markus Armbruster
From: Eric Blake We initially created the static visit_type_FOO_fields() helper function for reuse of code - we have cases where the initial setup for a visit has different allocation (depending on whether the fields represent a stand-alone type or are embedded as part of a larger type), but wher

[Qemu-devel] [PULL 00/15] QAPI patches for 2016-02-19

2016-02-19 Thread Markus Armbruster
The following changes since commit dd5e38b19d7cb07d317e1285941d8245c01da540: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160218-1' into staging (2016-02-18 15:20:35 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016

[Qemu-devel] [PULL 15/15] qapi: Change visit_start_implicit_struct to visit_start_alternate

2016-02-19 Thread Markus Armbruster
From: Eric Blake After recent changes, the only remaining use of visit_start_implicit_struct() is for allocating the space needed when visiting an alternate. Since the term 'implicit struct' is hard to explain, rename the function to its current usage. While at it, we can merge the functionalit

  1   2   3   4   >