Re: [Qemu-devel] [PATCH 0/2] error: Documentation updates

2016-02-05 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Markus Armbruster writes: >>> This overlaps with parts of Lluís's "[RFC][PATCH v6 0/5] utils: Improve and document error reporting". Lluís, feel free to integrate my patches into a respin of your

Re: [Qemu-devel] [PATCH v2 07/11] block: m25p80: Dummy cycles for N25Q256/512

2016-02-05 Thread Cédric Le Goater
On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > This patch handles dummy cycles. > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index

[Qemu-devel] [PATCH 1/5] move get_current_ram_size to virtio-balloon.c

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
get_current_ram_size() is used only in virtio-balloon.c This patch moves it into virtio-balloon and make it static, to allow some balloon-specific tuning. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake --- hw/mem/pc-dimm.c| 26

[Qemu-devel] [PATCH 3/5] pc-dimm: add pc_dimm_build_list()

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
Like pc_dimm_build_list_sorted but not sorted - for cases where sorting is not necessary. Add stubbed version too - for targets without CONFIG_MEM_HOTPLUG. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/mem/pc-dimm.c| 15 +++ include/hw/mem/pc-dimm.h| 3 +

[Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size()

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
Use pc_dimm_built_list() instead of qmp_pc_dimm_device_list() Actually, Qapi is not related to this internal helper. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-balloon.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/hw/virtio/

[Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list()

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
s/pc_dimm_built_list/pc_dimm_build_list_sorted - need for add pc_dimm_build_list (not sorted) in the next patch - fix typo (built -> build) Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/mem/pc-dimm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mem/pc-dimm.c

[Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
For now there are only two dimm's: pc-dimm and nvdimm. This patch is actually needed to disable ballooning on nvdimm. But, to avoid future bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if someone adds new dimm which should be balloon-able, then this ability should be explicitly sp

[Qemu-devel] [PATCH 0/5] don't use NVDIMM for balooning

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
v6: add stubbed pc_dimm_build_list, fix compilation for !CONFIG_MEM_HOTPLUG targets - thx to Cornelia. v5: do not use qapi 0002-0004: new patches 0005: white list instead of black list v4: 0001: Reviewed-by: Eric Blake second patch is splitted to 0002 and 0003 0002: Add 'type' field inste

[Qemu-devel] [PATCH v6 0/5] don't use NVDIMM for balooning

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
Sorry for subject, it should be [PATCH v6 0/5] don't use NVDIMM for balooning On 05.02.2016 11:18, Vladimir Sementsov-Ogievskiy wrote: v6: add stubbed pc_dimm_build_list, fix compilation for !CONFIG_MEM_HOTPLUG targets - thx to Cornelia. v5: do not use qapi 0002-0004: new patches 0005:

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-05 Thread Hailiang Zhang
On 2016/2/5 15:40, Jason Wang wrote: On 02/05/2016 03:01 PM, Hailiang Zhang wrote: On 2016/2/5 14:19, Jason Wang wrote: On 02/01/2016 06:40 PM, Hailiang Zhang wrote: On 2016/2/1 17:42, Jason Wang wrote: On 02/01/2016 05:22 PM, Hailiang Zhang wrote: On 2016/2/1 17:04, Jason Wang wrote:

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

2016-02-05 Thread Paolo Bonzini
>>> It is already migrated as part of virtio_rng_save's call to virtio_save. >>> On the loading side, virtio_rng_process condenses all requests into one >>> and chr_read fills in as many virtqueue buffers as possible from the >>> single request. >> >> Thanks! So this looks broken. The contract be

[Qemu-devel] [PATCH v2] migration: fix bad string passed to error_report()

2016-02-05 Thread Greg Kurz
state->name does not contain a terminating '\0' and you may get: Machine type received is 'pseries-2.3y�?' and local is 'pseries-2.4' load of migration failed: Invalid argument Let's add a precision modifier to fix this. Reviewed-by: Amit Shah Signed-off-by: Greg Kurz --- v2: - added Amit's R-

[Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-05 Thread Greg Kurz
From: Brian W. Hart xics_alloc_block() does not return a clear error code when it fails to allocate a block of interrupts. Instead it returns the base interrupt number minus 1. This change updates it to return a clear -1 in case of failure (following the example of xics_alloc()). The two callers

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-05 Thread Fam Zheng
On Fri, 02/05 11:28, Denis V. Lunev wrote: > On 02/03/2016 11:14 AM, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty bitmaps. > >> > >>Vmwa

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-05 Thread Denis V. Lunev
On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. What is the advanta

Re: [Qemu-devel] [PULL 45/49] net: set endianness on all backend devices

2016-02-05 Thread Greg Kurz
On Thu, 4 Feb 2016 23:54:01 +0200 "Michael S. Tsirkin" wrote: > From: Laurent Vivier > > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 >vhost-net: tell tap backend about the vnet endianness > > makes vhost net to set the endianness of the device, but only for > the first device. > >

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-05 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Feb 04, 2016 at 03:16:17PM -0200, Eduardo Habkost wrote: >> On Thu, Feb 04, 2016 at 06:01:50PM +0200, Michael S. Tsirkin wrote: >> > On Sat, Jan 23, 2016 at 02:02:08PM -0200, Eduardo Habkost wrote: >> > > This is another attempt to remove old q35 machine cod

[Qemu-devel] [PATCH v10] spec: add qcow2 bitmaps extension specification

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such bitmaps: Dirty Tracking Bitmap, which just tracks virtual disk change

Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-05 Thread Jason Wang
On 02/02/2016 10:29 PM, P J P wrote: > From: Prasad J Pandit > > Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152) > bytes to process network packets. Four registers PSTART, > PSTOP, CURPAGE and BOUNDARY are used to control ring buffer > access. Setting these registers to invalid values coul

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-05 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Feb 04, 2016 at 05:09:44PM -0200, Eduardo Habkost wrote: >> On Thu, Feb 04, 2016 at 08:02:30PM +0200, Michael S. Tsirkin wrote: >> > On Thu, Feb 04, 2016 at 03:16:17PM -0200, Eduardo Habkost wrote: >> > > On Thu, Feb 04, 2016 at 06:01:50PM +0200, Michael S.

Re: [Qemu-devel] [PATCH] Adds keycode 86 to the hid_usage_keys translation table.

2016-02-05 Thread Gerd Hoffmann
On Do, 2016-02-04 at 16:03 -0300, Daniel Serpell wrote: > This key is present in international keyboards, between left shift and > the 'Z' key, ant is described in the HID usage tables as "Keyboard > Non-US \ and |": http://www.usb.org/developers/hidpage/Hut1_12v2.pdf > > This patch fixes the usb-

Re: [Qemu-devel] [PATCH v2 03/17] crypto: add support for PBKDF2 algorithm

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 03:14:10PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > +int qcrypto_pbkdf2(QCryptoHashAlgorithm hash, > > + const uint8_t *key, size_t nkey, > > + const uint8_t *salt, size_t nsalt, > > +

[Qemu-devel] [PATCH 00/12] tests: Introducing docker tests

2016-02-05 Thread Fam Zheng
v1: Since RFC, addressed comments from reviewers, and improved a lot of things. Thanks to Daniel, Eric, Paolo, Stefan, for the feedback. This series adds a new "docker" make target family to run tests in created docker containers. To begin with, this can be a place to store standard env/comma

[Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-05 Thread Fam Zheng
docker_run: A wrapper for "docker run" (or "sudo -n docker run" if necessary), which takes care of killing and removing the running container at SIGINT. docker_clean: A tool to tear down all the containers including inactive ones that are started by docker_run. docker_build: A tool to compare an

[Qemu-devel] [PATCH 05/12] docker: Add common.rc

2016-02-05 Thread Fam Zheng
"requires" checks the "FEATURE" environment for specified prerequisits, and skip the execution of test if not found. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 28 1 file changed, 28 insertions(+) create mode 100755 tests/docker/common.rc diff --git a/te

[Qemu-devel] [PATCH 02/12] Makefile: Rules for docker testing

2016-02-05 Thread Fam Zheng
This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown by "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make, scanni

[Qemu-devel] [PATCH 09/12] docker: Add travis tool

2016-02-05 Thread Fam Zheng
The script is not named test-travis.sh so it won't run with "make docker-run", because it can take too long. Run it with "make docker-run-travis.sh@ubuntu". Signed-off-by: Fam Zheng --- tests/docker/travis.py | 53 ++ tests/docker/travis.sh | 20 +

[Qemu-devel] [PATCH 04/12] docker: Add test runner

2016-02-05 Thread Fam Zheng
It's better to have a launcher for all tests, to make it easier to initialize and manage the environment. Signed-off-by: Fam Zheng --- tests/docker/run | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 tests/docker/run diff --git a/tests/docker/run b/tests/docke

[Qemu-devel] [PATCH 03/12] docker: Add images

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/centos6.docker | 5 + tests/docker/fedora.docker | 7 +++ tests/docker/ubuntu.docker | 9 + 3 files changed, 21 insertions(+) create mode 100644 tests/docker/centos6.docker create mode 100644 tests/docker/fedora.docker create mode 100

[Qemu-devel] [PATCH 12/12] MAINTAINERS: Add tests/docker

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6ed87a..f24a449 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1573,3 +1573,10 @@ Build system architecture M: Daniel P. Berrange S: Odd Fixes F: docs/build-sys

[Qemu-devel] [PATCH 10/12] docs: Add text for tests/docker in build-system.txt

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- docs/build-system.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/build-system.txt b/docs/build-system.txt index 5ea..2af1e66 100644 --- a/docs/build-system.txt +++ b/docs/build-system.txt @@ -438,6 +438,11 @@ top level Makefile, so anything defi

[Qemu-devel] [PATCH 06/12] docker: Add basic test

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-basic.sh | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 tests/docker/test-basic.sh diff --git a/tests/docker/test-basic.sh b/tests/docker/test-basic.sh new file mode 100755 index 000..c2b32ad --- /dev/null +++

[Qemu-devel] [PATCH 11/12] .gitignore: Ignore temporary dockerfile

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 88a80ff..a335b7b 100644 --- a/.gitignore +++ b/.gitignore @@ -109,3 +109,4 @@ cscope.* tags TAGS *~ +/tests/docker/*.docker.tmp -- 2.4.3

[Qemu-devel] [PATCH 07/12] docker: Add clang test

2016-02-05 Thread Fam Zheng
The configure options are suggested by John Snow . Signed-off-by: Fam Zheng --- tests/docker/test-clang.sh | 26 ++ 1 file changed, 26 insertions(+) create mode 100755 tests/docker/test-clang.sh diff --git a/tests/docker/test-clang.sh b/tests/docker/test-clang.sh new fi

[Qemu-devel] [PATCH 08/12] docker: Add mingw test

2016-02-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/test-mingw.sh | 34 ++ 1 file changed, 34 insertions(+) create mode 100755 tests/docker/test-mingw.sh diff --git a/tests/docker/test-mingw.sh b/tests/docker/test-mingw.sh new file mode 100755 index 000..22e7579 --- /d

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/7] target-arm: Fix typo in comment in arm_is_secure_below_el3()

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > Fix a typo where "EL2" was written but "EL3" intended. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index b8b3364..52284e9 100644 > --- a/target-a

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 04.02.2016 09:20, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> On 03.02.2016 18:42, Markus Armbruster wrote: Eric Blake writes: > On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: >> NVDIMM for now

Re: [Qemu-devel] [PATCH v2 05/11] block: m25p80: 4byte address mode

2016-02-05 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
Hello, > -Original Message- > From: EXT Cédric Le Goater [mailto:c...@fr.ibm.com] > Sent: Friday, February 05, 2016 8:53 AM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw); qemu-devel@nongnu.org > Cc: crosthwaitepe...@gmail.com; pawel.len...@itlen.com > Subject: Re: [PATCH v2 05/11] block: m

Re: [Qemu-devel] [PATCH v2 04/11] block: m25p80: Extend address mode

2016-02-05 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Cédric Le Goater [mailto:c...@fr.ibm.com] > Sent: Friday, February 05, 2016 8:58 AM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw); qemu-devel@nongnu.org > Cc: crosthwaitepe...@gmail.com; pawel.len...@itlen.com > Subject: Re: [PATCH v2 04/11] block: m25p80: E

Re: [Qemu-devel] [PATCH v2 03/17] crypto: add support for PBKDF2 algorithm

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 03:14:10PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > The LUKS data format includes use of PBKDF2 (Password-Based > > Key Derivation Function). The Nettle library can provide > > an implementation of this, but we don't want code directly

Re: [Qemu-devel] [PATCH v2 07/11] block: m25p80: Dummy cycles for N25Q256/512

2016-02-05 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Cédric Le Goater [mailto:c...@fr.ibm.com] > Sent: Friday, February 05, 2016 9:06 AM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw); qemu-devel@nongnu.org > Cc: crosthwaitepe...@gmail.com; pawel.len...@itlen.com > Subject: Re: [PATCH v2 07/11] block: m25p80:

Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 03:57:33PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > There are a number of different algorithms that can be used > > to generate initialization vectors for disk encryption. This > > introduces a simple internal QCryptoBlockIV object to

[Qemu-devel] [PATCH] net: netmap: implement virtio-net header probe

2016-02-05 Thread Vincenzo Maffione
Current implementation for netmap backend does not really probe the netmap kernel module to know whether virtio-net header is supported for a specific netmap port. This is only correct for VALE ports, but it is not correct for hardware ports, pipes, etc. This patch properly implements the missing

[Qemu-devel] [PATCH] net: netmap: probe netmap interface for virtio-net header

2016-02-05 Thread Vincenzo Maffione
Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. did not really probe for virtio-net header support for the netmap interface attached to the backend. These callbacks were correct for VALE ports, but incorrect for hardware NICs, pipes, monitors, etc. This patch fixes the imp

[Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-05 Thread Greg Kurz
This series brings some improvements to the cross-endian support in the virtio and vhost code: - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, so that backend cross-endian capabilities benefit to both emulated and vhost accelerated devices - optimize virtio_access_is_b

[Qemu-devel] [PATCH v4 1/6] virtio-net: use the backend cross-endian capabilities

2016-02-05 Thread Greg Kurz
When running a fully emulated device in cross-endian conditions, including a virtio 1.0 device offered to a big endian guest, we need to fix the vnet headers. This is currently handled by the virtio_net_hdr_swap() function in the core virtio-net code but it should actually be handled by the net bac

[Qemu-devel] [PATCH v4 2/6] vhost-net: revert support of cross-endian vnet headers

2016-02-05 Thread Greg Kurz
Cross-endian is now handled by the core virtio-net code. This patch reverts: commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness and commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56 net: set endianness on all backend devices Revi

[Qemu-devel] [PATCH v4 3/6] virtio: move cross-endian helper to vhost

2016-02-05 Thread Greg Kurz
If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() indeed returns the runtime state of the virtio device. However, it returns false unconditionally in the general case. This sounds a bit strange given the name of the function. This helper is only useful for vhost actually, wh

Re: [Qemu-devel] [PATCH v5 0/7] mips/kvm: Support FPU & SIMD (MSA) in MIPS KVM guests

2016-02-05 Thread James Hogan
On Thu, Feb 04, 2016 at 10:04:11AM +, Leon Alrae wrote: > On 03/02/16 17:16, James Hogan wrote: > > Here's a v5 refresh of my FPU/MSA patchset for v2.6. Thanks to all who > > have taken the time to review it so far. > > > > This patchset primarily adds support for FPU and MIPS SIMD Architectur

[Qemu-devel] [PATCH v4 4/6] vhost: move virtio 1.0 check to cross-endian helper

2016-02-05 Thread Greg Kurz
Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Reviewed-by: Cornelia Huck Signed-off-by: Greg Kurz --- hw/virtio/vhost.c |9 ++

[Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Greg Kurz
After the call to virtio_vdev_has_feature(), we only care for legacy devices, so we don't need the extra check in virtio_is_big_endian(). Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN may only happen on a virtio_load() path that cannot lead here), so we don't need the as

[Qemu-devel] [PATCH v4 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2016-02-05 Thread Greg Kurz
When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro and the virtio_access_is_big_endian() helper to have a branchless fast path in the virtio memory accessors for targets that don't switch endian. This was considered as a strong requirement at the time. Now we have added

[Qemu-devel] [PATCH] usb: check RNDIS buffer offsets & length

2016-02-05 Thread P J P
From: Prasad J Pandit When processing remote NDIS control message packets, the USB Net device emulator uses a fixed length(4096) data buffer. The incoming informationBufferOffset & Length combination could cross that range. Check control message buffer offsets and length to avoid it. Reported-by

[Qemu-devel] [PATCH 09/13] throttle: Add command-line settings to define the burst periods

2016-02-05 Thread Alberto Garcia
This patch adds all the throttling.*-max-length command-line parameters to define the length of the burst periods. Signed-off-by: Alberto Garcia --- blockdev.c | 37 + 1 file changed, 37 insertions(+) diff --git a/blockdev.c b/blockdev.c index c9e91ab..5a2a9b

[Qemu-devel] [PATCH 11/13] qapi: Add burst length fields to BlockDeviceInfo

2016-02-05 Thread Alberto Garcia
This patch adds the new bps_*_max_length and iops_*_max_length parameters to the BlockDeviceInfo struct. Signed-off-by: Alberto Garcia --- block/qapi.c | 20 qapi/block-core.json | 39 +-- 2 files changed, 53 insertions(+), 6 delet

[Qemu-devel] [PATCH 05/13] throttle: Set always an average value when setting a maximum value

2016-02-05 Thread Alberto Garcia
When testing the ranges of valid values, set_cfg_value() creates sometimes invalid throttling configurations by setting bucket.max while leaving bucket.avg uninitialized. While this doesn't break the current tests, it will as soon as we unify all functions that check the validity of the throttling

[Qemu-devel] [PATCH 04/13] throttle: Make throttle_is_valid() set errp

2016-02-05 Thread Alberto Garcia
The caller does not need to set it, and this will allow us to refactor this function later. Signed-off-by: Alberto Garcia --- blockdev.c | 4 +--- include/qemu/throttle.h | 2 +- tests/test-throttle.c | 2 +- util/throttle.c | 5 - 4 files changed, 7 insertions(+), 6 d

[Qemu-devel] [PATCH 13/13] throttle: Test throttle_compute_wait() during bursts

2016-02-05 Thread Alberto Garcia
This test simulates an I/O burst for more than two seconds and checks that it works as expected. Signed-off-by: Alberto Garcia --- tests/test-throttle.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/test-throttle.c b/tests/test-throttle.c index 11ede23..2501d6

[Qemu-devel] [PATCH 12/13] throttle: Check that burst_level leaks correctly

2016-02-05 Thread Alberto Garcia
This patch expands test_leak_bucket() to check that burst_level leaks correctly. Signed-off-by: Alberto Garcia --- tests/test-throttle.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/test-throttle.c b/tests/test-throttle.c index cf81033..11ede23 100644 --- a/tests/t

[Qemu-devel] [PATCH 06/13] throttle: Merge all functions that check the configuration into one

2016-02-05 Thread Alberto Garcia
There's no need to keep throttle_conflicting(), throttle_is_valid() and throttle_max_is_missing_limit() as separate functions, so this patch merges all three into one. As a consequence, check_throttle_config() becomes redundant and can be replaced with throttle_is_valid(). Signed-off-by: Alberto

[Qemu-devel] [PATCH 10/13] qapi: Add burst length parameters to block_set_io_throttle

2016-02-05 Thread Alberto Garcia
This patch adds the new bps_*_max_length and iops_*_max_length parameters to the block_set_io_throttle command. Signed-off-by: Alberto Garcia --- blockdev.c | 31 +++ hmp.c| 12 qapi/block-core.json | 51 +

[Qemu-devel] [PATCH 01/13] throttle: Make throttle_compute_timer() static

2016-02-05 Thread Alberto Garcia
This function is only used internally in throttle.c Signed-off-by: Alberto Garcia --- include/qemu/throttle.h | 6 -- util/throttle.c | 8 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h index d0c98ed..52c98d9

[Qemu-devel] [PATCH 00/13] throttle: Allow I/O bursts for a user-defined period of time

2016-02-05 Thread Alberto Garcia
Hello everyone, the current throttling code in QEMU allows limiting the I/O rate on block devices. Limits can be set in operations per second (IOPS) or bytes per second, allowing separate limits for read and write operations on both cases. In its basic usage the user can set a limit of, say, 100

[Qemu-devel] [PATCH 03/13] throttle: Make throttle_max_is_missing_limit() set errp

2016-02-05 Thread Alberto Garcia
The caller does not need to set it, and this will allow us to refactor this function later. Signed-off-by: Alberto Garcia --- blockdev.c | 4 +--- include/qemu/throttle.h | 2 +- tests/test-throttle.c | 6 +++--- util/throttle.c | 5 - 4 files changed, 9 insertions(+),

[Qemu-devel] [PATCH 02/13] throttle: Make throttle_conflicting() set errp

2016-02-05 Thread Alberto Garcia
The caller does not need to set it, and this will allow us to refactor this function later. Signed-off-by: Alberto Garcia --- blockdev.c | 4 +--- include/qemu/throttle.h | 2 +- tests/test-throttle.c | 12 ++-- util/throttle.c | 11 +-- 4 files changed,

[Qemu-devel] [PATCH 07/13] throttle: Use throttle_config_init() to initialize ThrottleConfig

2016-02-05 Thread Alberto Garcia
We can currently initialize ThrottleConfig by zeroing all its fields, but this will change with the new fields to define the length of the burst periods. This patch introduces a new throttle_config_init() function and uses it to replace all memset() calls that initialize ThrottleConfig directly.

[Qemu-devel] [PATCH 08/13] throttle: Add support for burst periods

2016-02-05 Thread Alberto Garcia
This patch adds support for burst periods to the throttling code. With this feature the user can keep performing bursts as defined by the LeakyBucket.max rate for a configurable period of time. Signed-off-by: Alberto Garcia --- include/qemu/throttle.h | 41 +++ util/throt

Re: [Qemu-devel] [PATCH 2/7] target-arm: Implement MDCR_EL3 and SDCR

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > Implement the MDCR_EL3 register (which is SDCR for AArch32). > For the moment we implement it as reads-as-written. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h| 1 + > target-arm/helper.c | 24 > 2 files changed, 25 insertions(

Re: [Qemu-devel] [PATCH 2/7] target-arm: Implement MDCR_EL3 and SDCR

2016-02-05 Thread Peter Maydell
On 5 February 2016 at 11:13, Alex Bennée wrote: > Peter Maydell writes: >> Implement the MDCR_EL3 register (which is SDCR for AArch32). >> For the moment we implement it as reads-as-written. >> >> Signed-off-by: Peter Maydell >> +/* Some secure-only AArch32 registers trap to EL3 if used from >>

Re: [Qemu-devel] [PATCH v4 1/6] virtio-net: use the backend cross-endian capabilities

2016-02-05 Thread Cornelia Huck
On Fri, 05 Feb 2016 11:43:11 +0100 Greg Kurz wrote: > +static bool virtio_net_set_vnet_endian(VirtIODevice *vdev, NetClientState > *ncs, > + int queues, bool enable) You might consider adding a comment like "returns whether endianness handling needs to fall

Re: [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Cornelia Huck
On Fri, 05 Feb 2016 11:46:04 +0100 Greg Kurz wrote: > After the call to virtio_vdev_has_feature(), we only care for legacy > devices, so we don't need the extra check in virtio_is_big_endian(). > > Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN > may only happen on a vi

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-05 Thread Vladimir Sementsov-Ogievskiy
On 05.02.2016 12:53, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 04.02.2016 09:20, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 03.02.2016 18:42, Markus Armbruster wrote: Eric Blake writes: On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wr

Re: [Qemu-devel] [PATCH v2 05/17] crypto: add support for anti-forensic split algorithm

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 04:26:42PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > +++ b/crypto/afsplit.c > > @@ -0,0 +1,162 @@ > > +/* > > + * QEMU Crypto anti forensic information splitter > > + * > > + * Copyright (c) 2015-2016 Red Hat, Inc. > > + * > > + * Deriv

Re: [Qemu-devel] [PATCH v2 05/17] crypto: add support for anti-forensic split algorithm

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 04:26:42PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > The LUKS format specifies an anti-forensic split algorithm which > > is used to artificially expand the size of the key material on > > disk. This is an implementation of that algorit

Re: [Qemu-devel] [PATCH v2 06/17] crypto: add block encryption framework

2016-02-05 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 05:23:32PM -0700, Eric Blake wrote: > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > Add a generic framework for support different block encryption > > formats. Upon instantiating a QCryptoBlock object, it will read > > the encryption header and extract the encryption

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix max-cpus check

2016-02-05 Thread Shannon Zhao
2016年2月3日星期三,Andrew Jones 写道: > mach-virt doesn't yet support hotplug, but command lines specifying > -smp ,maxcpus= don't fail. Of course specifying > bigger-num as something bigger than the machine supports, e.g. > 8 > on a gicv2 machine, should fail though. This fix also makes mach- > virt's m

Re: [Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list()

2016-02-05 Thread Igor Mammedov
On Fri, 5 Feb 2016 11:18:58 +0300 Vladimir Sementsov-Ogievskiy wrote: > s/pc_dimm_built_list/pc_dimm_build_list_sorted > > - need for add pc_dimm_build_list (not sorted) in the next patch > - fix typo (built -> build) > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH 3/5] pc-dimm: add pc_dimm_build_list()

2016-02-05 Thread Igor Mammedov
On Fri, 5 Feb 2016 11:18:59 +0300 Vladimir Sementsov-Ogievskiy wrote: > Like pc_dimm_build_list_sorted but not sorted - for cases where sorting > is not necessary. Add stubbed version too - for targets without > CONFIG_MEM_HOTPLUG. It's not performance critical path, is there a reason why sorted

Re: [Qemu-devel] [PULL 06/49] virtio: move allocation to virtqueue_pop/vring_pop

2016-02-05 Thread Peter Maydell
On 4 February 2016 at 21:51, Michael S. Tsirkin wrote: > From: Paolo Bonzini > > The return code of virtqueue_pop/vring_pop is unused except to check for > errors or 0. We can thus easily move allocation inside the functions > and just return a pointer to the VirtQueueElement. > > The advantage

Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size()

2016-02-05 Thread Igor Mammedov
On Fri, 5 Feb 2016 11:19:00 +0300 Vladimir Sementsov-Ogievskiy wrote: > Use pc_dimm_built_list() instead of qmp_pc_dimm_device_list() > > Actually, Qapi is not related to this internal helper. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/virtio/virtio-balloon.c | 23 ++-

Re: [Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning

2016-02-05 Thread Igor Mammedov
On Fri, 5 Feb 2016 11:19:01 +0300 Vladimir Sementsov-Ogievskiy wrote: > For now there are only two dimm's: pc-dimm and nvdimm. This patch is > actually needed to disable ballooning on nvdimm. But, to avoid future > bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if > someone adds

Re: [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Laurent Vivier
On 05/02/2016 11:46, Greg Kurz wrote: > After the call to virtio_vdev_has_feature(), we only care for legacy > devices, so we don't need the extra check in virtio_is_big_endian(). > > Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN > may only happen on a virtio_load() pa

Re: [Qemu-devel] [PATCH v4 4/6] vhost: move virtio 1.0 check to cross-endian helper

2016-02-05 Thread Laurent Vivier
On 05/02/2016 11:45, Greg Kurz wrote: > Indeed vhost doesn't need to ask for vring endian fixing if the device is > virtio 1.0, since it is already handled by the in-kernel vhost driver. This > patch simply consolidates the logic into the existing helper. > > Reviewed-by: Cornelia Huck > Signed

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-05 Thread Laurent Vivier
On 05/02/2016 11:39, Greg Kurz wrote: > This series brings some improvements to the cross-endian support in the > virtio and vhost code: > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, > so that backend cross-endian capabilities benefit to both emulated and > vhost

Re: [Qemu-devel] [PATCH v1 1/3] target-arm: Add the pmceid0 and pmceid1 registers

2016-02-05 Thread Nathan Rossi
On Thu, Feb 4, 2016 at 10:34 AM, Alistair Francis wrote: > Signed-off-by: Alistair Francis Tested-by: Nathan Rossi > --- > > target-arm/cpu-qom.h | 2 ++ > target-arm/cpu.c | 2 ++ > target-arm/cpu64.c | 2 ++ > target-arm/helper.c | 8 > 4 files changed, 14 insertions(+) > >

Re: [Qemu-devel] [PATCH v1 2/3] target-arm: Add Some of the performance monitor registers

2016-02-05 Thread Nathan Rossi
On Thu, Feb 4, 2016 at 10:34 AM, Alistair Francis wrote: > This patch adds the following registers including read and write functions: > PMSELR, PMSELR_EL0, PMXEVCNTR, PMXEVCNTR_EL0, PMXEVTYPER and PMXEVTYPER_EL0. > > Signed-off-by: Alistair Francis Tested-by: Nathan Rossi > --- > > target-ar

Re: [Qemu-devel] [PATCH v1 3/3] target-arm: Add the pmovsclr_el0 and pmintenclr_el1 registers

2016-02-05 Thread Nathan Rossi
On Thu, Feb 4, 2016 at 10:34 AM, Alistair Francis wrote: > Signed-off-by: Alistair Francis Tested-by: Nathan Rossi > --- > > target-arm/helper.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 2e0018c..c3fa57d 100644 > -

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2016-02-05 Thread Prasanna Kumar Kalever
On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote: > Am 12.11.2015 um 23:36 hat Eric Blake geschrieben: > > On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > > > +static struct glfs *qemu_gluster_init(BlockdevOptionsGluster **gconf, > > > + const c

Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors

2016-02-05 Thread Daniel P. Berrange
On Fri, Feb 05, 2016 at 10:23:18AM +, Daniel P. Berrange wrote: > On Thu, Feb 04, 2016 at 03:57:33PM -0700, Eric Blake wrote: > > On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > > > There are a number of different algorithms that can be used > > > to generate initialization vectors for disk

Re: [Qemu-devel] [PATCH V2] quorum: fix segfault when read fails in fifo mode

2016-02-05 Thread Alberto Garcia
On Fri 05 Feb 2016 03:25:22 AM CET, Changlong Xie wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile

2016-02-05 Thread Alex Bennée
Eric Blake writes: > On 02/04/2016 03:26 PM, Richard Henderson wrote: >> On 02/05/2016 01:56 AM, Alex Bennée wrote: >>> +if (g_strrstr(filename, "%d")) { >>> +/* if we are going to format this we'd better validate first */ >>> +if (g_regex_match_simple("^[^%]+%d[^%]+$", filen

Re: [Qemu-devel] [PATCH v1 0/3] Extend the performance monitoring registers

2016-02-05 Thread Aaron Lindsay
On Feb 04 10:52, Alistair Francis wrote: > On Thu, Feb 4, 2016 at 5:39 AM, Aaron Lindsay wrote: > > Please add my > > Signed-off-by: Aaron Lindsay > > to all three. > > Ok, I wasn't sure what you wanted to do there. I'll add them all and > they will be there in the next version. I won't re-send

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/7] target-arm: Use access_trap_aa32s_el1() for SCR and MVBAR

2016-02-05 Thread Alex Bennée
Peter Maydell writes: > The registers MVBAR and SCR should have the behaviour of trapping to > EL3 if accessed from Secure EL1, but we were incorrectly implementing > them to UNDEF (which would trap to EL1). Fix this by using the new > access_trap_aa32s_el1() access function. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/2] error: Documentation updates

2016-02-05 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Markus Armbruster writes: > This overlaps with parts of Lluís's "[RFC][PATCH v6 0/5] utils: > Improve and document error reporting". Lluís, feel free to integrate >>

[Qemu-devel] [PULL 0/9] migration: small fixes

2016-02-05 Thread Amit Shah
The following changes since commit d38ea87ac54af64ef611de434d07c12dc0399216: all: Clean up includes (2016-02-04 17:41:30 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/migration-for-2.6-2 for you to fetch changes up to 15d616

[Qemu-devel] [PULL 1/9] ram: Split host_from_stream_offset() into two helper functions

2016-02-05 Thread Amit Shah
From: zhanghailiang Split host_from_stream_offset() into two parts: One is to get ram block, which the block idstr may be get from migration stream, the other is to get hva (host) address from block and the offset. Besides, we will do the check working in a new helper offset_in_ramblock(). Signe

[Qemu-devel] [PULL 2/9] migration: rename 'file' in MigrationState to 'to_dst_file'

2016-02-05 Thread Amit Shah
From: zhanghailiang Rename the 'file' member of MigrationState to 'to_dst_file' to be consistent with to_src_file, from_src_file and from_dst_file. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Message-Id: <1452829066-9764-3-git-send-email-zhang.zhang

[Qemu-devel] [PULL 3/9] savevm: Split load vm state function qemu_loadvm_state

2016-02-05 Thread Amit Shah
From: zhanghailiang qemu_loadvm_state is too long, and we can simplify it by splitting up with three helper functions. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Message-Id: <1452829066-9764-4-git-send-email-zhang.zhanghaili...@huawei.com> Signed-o

[Qemu-devel] [PULL 4/9] migration/ram: Fix some helper functions' parameter to use PageSearchStatus

2016-02-05 Thread Amit Shah
From: zhanghailiang Some helper functions use parameters 'RAMBlock *block' and 'ram_addr_t *offset', We can use 'PageSearchStatus *pss' directly instead, with this change, we can reduce the number of parameters for these helper function, also it is easily to add new parameters for these helper fu

[Qemu-devel] [PULL 6/9] qmp-commands.hx: Document the missing options for migration capability commands

2016-02-05 Thread Amit Shah
From: zhanghailiang Add the missing descriptions for the options of migration capability commands, and fix the example for query-migrate-capabilities command. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Message-Id: <1452829066-9764-7-git-send-email-

  1   2   3   >