[Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration

2016-02-02 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. The output of iotests 109 is updated because we now report

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 06:15 PM, Programmingkid wrote: >> No, keep filename as a const char * pointer. It's easy to avoid use of >> uninitialized memory. Try this: >> >> const char *filename; >> char bsd_path[MAXPATHLEN] = ""; >> ... >> if (strncmp("/dev/cdrom"...) { >>bsd_path = ... >> } >> ... >> i

Re: [Qemu-devel] [PATCH v5 03/10] qemu-nbd: add support for --object command line arg

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Allow creation of user creatable object types with qemu-nbd > via a new --object command line arg. This will be used to supply > passwords and/or encryption keys to the various block driver > backends via the recently added 'secret' object type. >

[Qemu-devel] [PATCH v2 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- hw/usb/ccid-card-emulated.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 869a63c..fe9ec5c 100644 --- a/hw/usb/ccid-card-emulated.c +++ b/hw/usb/ccid-card-emu

[Qemu-devel] [PATCH v2 0/2] CCID QOMify

2016-02-02 Thread Cao jin
v2 changelog 1. move macro definition to its home .c file Cao jin (2): Emulated CCID card: QOMify Passthru CCID card: QOMify hw/usb/ccid-card-emulated.c | 23 +-- hw/usb/ccid-card-passthru.c | 14 -- 2 files changed, 21 insertions(+), 16 deletions(-) -- 2.1.

[Qemu-devel] [PATCH v2 2/2] Passthru CCID card: QOMify

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- hw/usb/ccid-card-passthru.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c index 9f49c05..858e78e 100644 --- a/hw/usb/ccid-card-passthru.c +++ b/hw/usb/ccid-card-passthru.c @@

Re: [Qemu-devel] [PATCH v5 04/10] qemu-io: add support for --object command line arg

2016-02-02 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Allow creation of user creatable object types with qemu-io > via a new --object command line arg. This will be used to supply > passwords and/or encryption keys to the various block driver > backends via the recently added 'secret' object type. >

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Changlong Xie
On 02/02/2016 11:20 PM, Eric Blake wrote: On 01/13/2016 02:18 AM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 229

[Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-02 Thread Cao jin
Signed-off-by: Cao jin --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index abcdee8..42fa5db 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -221,7 +221,7 @@ typedef struct BusChild

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 04:33:27PM -0200, Eduardo Habkost wrote: > On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > > Hi, > > > > It seems to me we're getting rather bogged down in how to proceed with > > an improved CPU hotplug (and hot unplug) interface, both generically > > and f

Re: [Qemu-devel] [PATCH v2 00/14] QOM'ify hw/timer/*

2016-02-02 Thread
ping ... At 2016-01-27 10:54:34, "xiaoqiang zhao" wrote: >This patch series QOM'ify timer code under hw/timer directory. >Main idea is to split the initfn's work, some to TypeInfo.instance_init >and some is placed in DeviceClass::realize. >Drop the use of SysBusDeviceClass::init if possibl

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Eric Blake
On 02/02/2016 08:18 PM, Changlong Xie wrote: > On 02/02/2016 11:20 PM, Eric Blake wrote: >> On 01/13/2016 02:18 AM, Changlong Xie wrote: >>> From: Wen Congyang >>> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Gonglei >>> Signed-off-by: Changlong Xie >>> -

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Wen Congyang
On 02/03/2016 11:35 AM, Eric Blake wrote: > On 02/02/2016 08:18 PM, Changlong Xie wrote: >> On 02/02/2016 11:20 PM, Eric Blake wrote: >>> On 01/13/2016 02:18 AM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-b

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 9:30 PM, Eric Blake wrote: > On 02/02/2016 06:15 PM, Programmingkid wrote: > >>> No, keep filename as a const char * pointer. It's easy to avoid use of >>> uninitialized memory. Try this: >>> >>> const char *filename; >>> char bsd_path[MAXPATHLEN] = ""; >>> ... >>> if (strn

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Eric Blake
On 02/02/2016 09:21 PM, Programmingkid wrote: >>> #if defined(__APPLE__) && defined(__MACH__) >>>/* if a physical device experienced an error while being opened */ >>>if (strncmp((*bsd_path ? bsd_path : filename), "/dev/", 5) == 0) { >>>print_unmounting_directions(*bsd_

Re: [Qemu-devel] [PULL 00/17] Net patches

2016-02-02 Thread Jason Wang
On 02/02/2016 07:05 PM, Peter Maydell wrote: > On 2 February 2016 at 02:36, Jason Wang wrote: >> The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: >> >> hw: Clean up includes (2016-01-29 15:07:25 +) >> >> are available in the git repository at: >> >> https://gi

Re: [Qemu-devel] Migrating decrementer

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 11:41:40PM +, Mark Cave-Ayland wrote: > On 01/02/16 00:52, David Gibson wrote: > > >> Thanks for more pointers - I think I'm slowly getting there. My current > >> thoughts are that the basic migration algorithm is doing the right thing > >> in that it works out the numb

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread Bharata B Rao
On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > Hi, > > It seems to me we're getting rather bogged down in how to proceed with > an improved CPU hotplug (and hot unplug) interface, both generically > and for ppc in particular. > > So here's a somewhat more concrete suggestion of a

Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 03:37:12PM -0200, Eduardo Habkost wrote: > On Mon, Feb 01, 2016 at 01:33:09PM +1100, David Gibson wrote: > > On Fri, Jan 22, 2016 at 03:32:52PM +0100, Igor Mammedov wrote: > > > On Fri, 22 Jan 2016 15:21:05 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 22/01/2016 11:02

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: > On 02.02.2016 19:53, Markus Armbruster wrote: > > Lluís Vilanova writes: > ... > > >> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h > >> index 7ab2355..6c2f142 100644 > >> --- a/include/qemu/error-report.h > >

Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:14:15PM +0100, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > target-ppc/kvm.c|4 ++-- > target-ppc/kvm_ppc.h| 15 +-- > target-ppc/mmu-hash32.c |5 +++-- > target-ppc/mmu_helper.c |3 +-- > 4 files changed, 15 insert

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, February 03, 2016 1:11 AM > > On Tue, 2016-02-02 at 00:31 -0800, Neo Jia wrote: > > On Tue, Feb 02, 2016 at 08:18:44AM +, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:c...@nvidia.com] > > > > Sent: Tuesday, Febr

Re: [Qemu-devel] Migrating decrementer

2016-02-02 Thread Alexander Graf
> Am 03.02.2016 um 06:59 schrieb David Gibson : > >> On Tue, Feb 02, 2016 at 11:41:40PM +, Mark Cave-Ayland wrote: >> On 01/02/16 00:52, David Gibson wrote: >> Thanks for more pointers - I think I'm slowly getting there. My current thoughts are that the basic migration algorithm i

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Tuesday, February 02, 2016 5:25 PM > > On 2/2/2016 1:12 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > >> Sent: Tuesday, February 02, 2016 9:48 AM > >> > >> Resending this mail again, somehow my previous mail didn't reached every > >

Re: [Qemu-devel] [PATCH v4 6/6] MAINTAINERS: Add .travis.yml

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:08PM +, Alex Bennée wrote: > Signed-off-by: Alex Bennée Reviewed-by: David Gibson > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b6ed87a..426a735 100644 > --- a/MAINTAINERS > +++ b/MAINTAINE

Re: [Qemu-devel] [PATCH v4 4/6] .travis.yml: enable ccache for the builds

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:06PM +, Alex Bennée wrote: > Travis support ccache on a cache-per-branch basis. Given not much of the > build changes between pushes as well as the duplication in each build it > seems worthwhile enabling this. > > Signed-off-by: Alex Bennée Reviewed-by: David G

Re: [Qemu-devel] [PATCH v4 2/6] .travis.yml: run make check for all matrix targets

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:04PM +, Alex Bennée wrote: > We only ran make check once before it used to be an unreliable target. > It was only a stop gap measure and we should be able to revert it now. > This also stops us needing a large all-MMU build. > > We disable "make check" for a coupl

Re: [Qemu-devel] [PATCH v4 3/6] .travis.yml: enable each of the co-routine backends

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:05PM +, Alex Bennée wrote: > We disable "make check" for the gthread backend as it is broken. > > Signed-off-by: Alex Bennée Reviewed-by: David Gibson Tested-by: David Gibson > --- > .travis.yml | 15 ++- > 1 file changed, 14 insertions(+), 1 del

Re: [Qemu-devel] [PATCH v4 5/6] .travis.yml: reduce the test matrix a little

2016-02-02 Thread David Gibson
On Tue, Feb 02, 2016 at 05:34:07PM +, Alex Bennée wrote: > As we are now running "make check" on more of the matrix it is worth > making more of an effort to reduce the overall load on Travis. I've done > a few things: > > - Combining a number of the targets > - Building one target for eac

Re: [Qemu-devel] CPU hotplug

2016-02-02 Thread David Gibson
On Wed, Feb 03, 2016 at 10:33:48AM +0530, Bharata B Rao wrote: > On Mon, Feb 01, 2016 at 04:35:17PM +1100, David Gibson wrote: > > Hi, > > > > It seems to me we're getting rather bogged down in how to proceed with > > an improved CPU hotplug (and hot unplug) interface, both generically > > and for

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Tian, Kevin
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, February 02, 2016 4:56 PM > > Hi, > > > > I'd have qemu copy the data on 0xfc write then, so things continue to > > > work without updating seabios. So, the firmware has to allocate space, > > > reserve it etc., and programming

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > On 02/02/2016 01:04 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Commit 86f4b687 broke compilation on sparc, which has a preprocessor >>> pollution of '#define sparc 1'. Treat it the same way as we do for >>> the pollution with 'unix', so that QMP remains back

Re: [Qemu-devel] [PATCH v2 0/2] CCID QOMify

2016-02-02 Thread Michael Tokarev
Applied both to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] Fix inconsistency between comment and variable name

2016-02-02 Thread Michael Tokarev
03.02.2016 06:19, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/hw/qdev-core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index abcdee8..42fa5db 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-02 Thread Michael Tokarev
28.01.2016 21:22, Wei Huang wrote: > When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot > request will succeed; but the following shutdown/reboot requests > fail to trigger VMs to react. Notice that in mach-virt machine > model GPIO is defined as edge-triggered and active-high in ACP

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Markus Armbruster
Laszlo Ersek writes: > On 02/02/16 21:03, John Snow wrote: >> Recently, qemu iotest 013 has started to fail for me: >> >> Fedora release 22 (Twenty Two) >> >> 3.5.0-9.fc22 >> clang version 3.5.0 (tags/RELEASE_350/final) >> Target: x86_64-redhat-linux-gnu >> Thread model: posix >> >> >> +4 KiB

Re: [Qemu-devel] iotest 013 failure under clang -fsanitize=undefined

2016-02-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/02/2016 22:59, Eric Blake wrote: >> I'd be okay with this patch, if you want to make it a formal >> submission, and if no one else chimes in with any opinion other >> than disgust at clang's shenanigans. > > I'm not okay with the patch. What's wrong with > -fno-sani

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread Markus Armbruster
Thomas Huth writes: > On 02.02.2016 19:53, Markus Armbruster wrote: >> Lluís Vilanova writes: > ... > >>> diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h >>> index 7ab2355..6c2f142 100644 >>> --- a/include/qemu/error-report.h >>> +++ b/include/qemu/error-report.h >>> @@ -4

[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Janosch Frank
On kernels build without CONFIG_TRACING kvm_stat will bail out even when traces are not used. This is not very helpful, especially if the user can't install a new kernel. Instead, we should warn the user and fall back to debugfs statistics. These changes check if trace statistics were selected wit

[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Janosch Frank
The following patch fixes the access checking behavior changed in 7aa4ee5. Kvm_stat will now fall back to debugfs statistics if the tracefs ones were chosen but are not available. It will then print a warning and wait five seconds until it continues. Five seconds are not long, but I do not want to

Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix tracefs access checking

2016-02-02 Thread Paolo Bonzini
On 03/02/2016 08:41, Janosch Frank wrote: > The following patch fixes the access checking behavior changed in > 7aa4ee5. Kvm_stat will now fall back to debugfs statistics if the > tracefs ones were chosen but are not available. It will then print a > warning and wait five seconds until it continu

Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support

2016-02-02 Thread Gerd Hoffmann
On Di, 2016-02-02 at 19:16 +0100, Andreas Färber wrote: > Am 02.02.2016 um 14:36 schrieb Markus Armbruster: > > Gerd Hoffmann writes: > > > >> This patch marks usb-bot as hot-pluggable device, makes attached > >> property settable and turns off auto-attach in case the device > >> was hotplugged.

<    1   2   3   4