Re: [Qemu-devel] [PATCH 4/4] usb-uas: hotplug support

2016-02-02 Thread Markus Armbruster
Gerd Hoffmann writes: > Make attached property settable and turns off auto-attach in case the > device was hotplugged. Hotplugging works simliar to usb-bot now. > > Signed-off-by: Gerd Hoffmann Assuming we want this because we can't have a general solution now: Reviewed-by: Markus Armbruster

Re: [Qemu-devel] vl.c:main_loop() non-blocking TCG optimization still useful?

2016-02-02 Thread Jan Kiszka
On 2016-02-02 14:29, Stefan Hajnoczi wrote: > Hi Jan, > In 2011 the following patch was merged to optimize I/O vs vcpu scheduling: > > commit c9f711a5d31e22dac932c1c01e9c0f97caff0988 > Author: Jan Kiszka > Date: Mon Aug 22 17:46:02 2011 +0200 > > Poll main loop after I/O events were receiv

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread Markus Armbruster
James Hogan writes: > Hi Eric, > > On 18 November 2015 at 08:52, Eric Blake wrote: >> +# An enumeration of cpu types that enable additional information during >> +# @query-cpus. >> +# >> +# Since: 2.6 >> +## >> +{ 'enum': 'CpuInfoArch', >> + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'o

Re: [Qemu-devel] [PATCH 1/2] block: fix assert in qcow2_get_specific_info

2016-02-02 Thread Denis V. Lunev
On 02/02/2016 04:20 PM, Paolo Bonzini wrote: On 20/01/2016 08:12, Denis V. Lunev wrote: There is a possibility to hit assert qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration, and in the same ti

Re: [Qemu-devel] [PATCH v4 7/7] mips/kvm: Support MSA in MIPS KVM guests

2016-02-02 Thread Leon Alrae
On 02/02/16 12:39, James Hogan wrote: > I can use restore_msa_fp_status(env); here, and actually the FP one > above (in previous patch) can change to restore_fp_status(env); too, > since it does the same thing. This sounds good. > I've rebased and resolved the uint64 thing too, would you like a r

Re: [Qemu-devel] [PULL 14/49] scripts/kvm/kvm_stat: Improve debugfs access checking

2016-02-02 Thread Christian Borntraeger
On 01/26/2016 02:46 PM, Paolo Bonzini wrote: > From: Janosch Frank > > Access checking with F_OK was replaced with the better readable > os.path.exists(). > > On Linux exists() returns False when the user doesn't have sufficient > permissions for statting the directory. Therefore the error messa

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 01:15:49PM +, Peter Maydell wrote: > On 2 February 2016 at 12:59, Andrew Jones wrote: > > This actually doesn't matter for the v2 vs. v3 case. The gic-version > > property > > doesn't exist at all for v2-only QEMU. Although maybe the gic-version > > property > > shoul

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Tue, Feb 02, 2016 at 01:59:26PM +0100, Andrew Jones wrote: > On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > > > On Wed, Jan 06,

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 14:04, Andrew Jones wrote: > I agree we should have a good argument to justify messing with it, but > until we start versioning mach-virt, then I don't think anybody should > depend on mach-virt command lines working everywhere. Every time we add > a new property, and a user

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Gerd Hoffmann
Hi, > I don't remember discussing the topic of machine types when touching > fw_cfg DMA. Which means, it probably slipped amongst the other details. > But it is now merged and in stable, so it should probably be left as it > is now. We have to fix it, it breaks live migration. With fw_cfg_dma

Re: [Qemu-devel] [PULL 0/8] Ivshmem patches

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 12:43, wrote: > From: Marc-André Lureau > > The following changes since commit 10ae9d76388e3f4a31f6a1475b5e2d1f28404a10: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-20160201' > into staging (2016-02-02 09:13:10 +) > > are available in the git r

Re: [Qemu-devel] [PATCH 2/4] usb: add attached property

2016-02-02 Thread Gerd Hoffmann
Hi, > > USB devices in attached state are visible to the guest. > > If I read the code correctly: > > * ->attached is true between usb_device_attach() and usb_device_detach() > > * Attach and detach is automatic on realize and unrealize, but a device > can choose to suppress attach on reali

Re: [Qemu-devel] [PULL 14/49] scripts/kvm/kvm_stat: Improve debugfs access checking

2016-02-02 Thread Paolo Bonzini
On 02/02/2016 15:02, Christian Borntraeger wrote: >> > -if not os.access('/sys/kernel/debug', os.F_OK): >> > -print 'Please enable CONFIG_DEBUG_FS in your kernel' >> > +if not os.path.exists('/sys/kernel/debug'): >> > +sys.stderr.write('Please enable CONFIG_DEBUG_FS in your kernel.') >> >

Re: [Qemu-devel] [PATCH 1/2] block: fix assert in qcow2_get_specific_info

2016-02-02 Thread Paolo Bonzini
On 02/02/2016 14:49, Denis V. Lunev wrote: > > By the way, are you sitting next to Stefan too? :) No, I am not. :) > There is our set > [PATCH v4 00/11] simplify usage of tracepoints, and connect them to > logging > which was accepted by Stefan and still not merged. > We can have troubles as

[Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-02 Thread P J P
From: Prasad J Pandit Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152) bytes to process network packets. Four registers PSTART, PSTOP, CURPAGE and BOUNDARY are used to control ring buffer access. Setting these registers to invalid values could lead to infinite loop or OOB r/w access issues.

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-02-02 Thread Stefan Hajnoczi
On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: > On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: > > On Fri, Jan 29, 2016 at 11:13:42AM +0800, Changlong Xie wrote: > >> On 01/28/2016 11:15 PM, Stefan Hajnoczi wrote: > >>> On Thu, Jan 28, 2016 at 09:13:24AM +0800, Wen Congyang wrote: >

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 00:04 +, Kay, Allen M wrote: >  > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Sunday, January 31, 2016 9:42 AM > > To: Kay, Allen M; Gerd Hoffmann; David Woodhouse > > Cc: igv...@ml01.01.org; xen-de...@lists.xensourc

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 03:05:28PM +0100, Christoffer Dall wrote: > On Tue, Feb 02, 2016 at 01:59:26PM +0100, Andrew Jones wrote: > > On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > > > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > > > On Fri, Jan 22, 2

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Andreas Färber
Am 02.02.2016 um 13:57 schrieb Daniel P. Berrange: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). > > The HMP and main emulator startup code also share > further logic that extrac

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread Eric Blake
On 02/02/2016 05:25 AM, James Hogan wrote: > Hi Eric, > > On 18 November 2015 at 08:52, Eric Blake wrote: >> +# An enumeration of cpu types that enable additional information during >> +# @query-cpus. >> +# >> +# Since: 2.6 >> +## >> +{ 'enum': 'CpuInfoArch', >> + 'data': ['x86', 'sparc', 'ppc',

[Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Eric Blake
Commit 86f4b687 broke compilation on MIPS, which has a preprocessor pollution of '#define mips 1'. Treat it the same way as we do for the pollution with 'unix', so that QMP remains backwards compatible and only the C code needs to use the alternative 'q_mips' spelling. CC: James Hogan Signed-off

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-02 Thread Stefan Hajnoczi
On Fri, Jan 15, 2016 at 04:12:08PM +0100, Paolo Bonzini wrote: > @@ -120,9 +117,17 @@ Block layer code must therefore expect to run in an > IOThread and avoid using > old APIs that implicitly use the main loop. See the "How to program for > IOThreads" above for information on how to do that. >

Re: [Qemu-devel] [Xen-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 11:50 +, David Woodhouse wrote: > On Tue, 2016-02-02 at 06:42 +, Tian, Kevin wrote: > > > From: Kay, Allen M > > > Sent: Tuesday, February 02, 2016 8:04 AM > > > >  > > > > David notes in the latter commit above: > > > >  > > > > "We should be able to successfully assi

Re: [Qemu-devel] [PULL 0/1] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-02 Thread Peter Maydell
388e3f4a31f6a1475b5e2d1f28404a10: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-20160201' > into staging (2016-02-02 09:13:10 +) > > are available in the git repository at: > > > git://git.kraxel.org/

Re: [Qemu-devel] [PATCH v2] arm: virt-acpi: each MADT.GICC entry as enabled unconditionally

2016-02-02 Thread Peter Maydell
On 1 February 2016 at 10:48, Igor Mammedov wrote: > in current impl. condition > > build_madt() { > ... > if (test_bit(i, cpuinfo->found_cpus)) > > is always true since loop handles only present CPUs > in range [0..smp_cpus). > But to fill usless cpuinfo->found_cpus we do unnecessary > scan ov

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Marc Marí
El Tue, 02 Feb 2016 12:06:27 +0100 Gerd Hoffmann escribió: > Hi, > > > %.img: %.o > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e > > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 > > -Ttext 0 -e _start -s -o $@

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Marc Marí
El Tue, 02 Feb 2016 13:04:55 +0100 Gerd Hoffmann escribió: > On Di, 2016-02-02 at 12:06 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > %.img: %.o > > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e > > > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > > > + $(call quiet-command,$

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-02 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/02/2016 15:52, Stefan Hajnoczi wrote: >>> @@ -110,6 +111,8 @@ static void *test_acquire_thread(void >>> *opaque) qemu_mutex_lock(&data->start_lock); >>> qemu_mutex_unlock(&data->start_lock); >>> >>> +g_usleep(50); > Sleep? What abo

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Laszlo Ersek
On 02/02/16 15:23, Gerd Hoffmann wrote: > Hi, > >> I don't remember discussing the topic of machine types when touching >> fw_cfg DMA. Which means, it probably slipped amongst the other details. >> But it is now merged and in stable, so it should probably be left as it >> is now. > > We have to

Re: [Qemu-devel] [Xen-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread David Woodhouse
On Tue, 2016-02-02 at 07:54 -0700, Alex Williamson wrote: > > I first glance I like it, but there's a problem, it assumes there is a > host driver for the device that will permanently release the device from > the RMRR even after the device is unbound.  Currently we don't have a > requirement that

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread James Hogan
On Tue, Feb 02, 2016 at 07:51:41AM -0700, Eric Blake wrote: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Andrea Bolognani
On Tue, 2016-02-02 at 13:59 +0100, Andrew Jones wrote: > > > > Our introspection support in QOM only allows us to say that a property > > > > is a particular type (int / enum / str / whatever). We don't have any > > > > way to expose info about what subset of possible values for a type are > > > >

Re: [Qemu-devel] [PULL 0/1] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-02 Thread Laszlo Ersek
pull, >> Gerd >> >> The following changes since commit 10ae9d76388e3f4a31f6a1475b5e2d1f28404a10: >> >> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-20160201' >> into staging (2016-02-02 09:13:10 +) >> >> are availab

Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state

2016-02-02 Thread Wei Huang
On 02/02/2016 01:03 AM, Michael Tokarev wrote: > 01.02.2016 21:01, Peter Maydell wrote: >> On 1 February 2016 at 17:20, Wei Huang wrote: >>> This patch removes float_high field of PL061State, which doesn't seem >>> to be used anywhere. > [] >>> @@ -88,7 +87,6 @@ static const VMStateDescription v

Re: [Qemu-devel] [PATCH v3 3/7] STM32F2xx: Add the ADC device

2016-02-02 Thread Peter Maydell
On 19 January 2016 at 07:23, Alistair Francis wrote: > Add the STM32F2xx ADC device. This device randomly > generates values on each read. > > This also includes creating a hw/adc directory. > > Signed-off-by: Alistair Francis > +static uint32_t stm32f2xx_adc_generate_value(STM32F2XXADCState *s)

Re: [Qemu-devel] [PULL 0/1] audio: Clean up includes

2016-02-02 Thread Peter Maydell
/tags/ppc-for-2.6-20160201' > into staging (2016-02-02 09:13:10 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-audio-20160202-1 > > for you to fetch changes up to 6086a565b0efe3eb66c5bf65a715a2c8442

Re: [Qemu-devel] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer

2016-02-02 Thread Dmitry Osipenko
30.01.2016 19:43, Dmitry Osipenko пишет: Due to rounding down performed by ptimer_get_count, it returns counter - 1 for the active timer. That's incorrect because counter should decrement only after period been expired, not before. I.e. if running timer has been loaded with value X, then timer co

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

2016-02-02 Thread Eric Blake
On 01/13/2016 02:18 AM, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > --- > docs/block-replication.txt | 229 > + > 1 file changed

Re: [Qemu-devel] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer

2016-02-02 Thread Dmitry Osipenko
02.02.2016 18:19, Dmitry Osipenko пишет: There is possibility to return timer counter = limit + 1, if the following ptimer calls execute in less than 1ns. s/limit/delta/ -- Dmitry

Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo

2016-02-02 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > The field is needed to distinguish pc-dimm and nvdimm. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Xiao Guangrong > CC: "Michael S. Tsirkin" > CC: Igor Mammedov > CC: Eric Blake > CC: Mar

Re: [Qemu-devel] [PATCH v3 5/7] STM32F205: Connect the ADC devices

2016-02-02 Thread Peter Maydell
On 19 January 2016 at 07:23, Alistair Francis wrote: > Connect the ADC devices to the STM32F205 SoC. > > Signed-off-by: Alistair Francis > --- > V2: > - Fix up the device/devices commit message > > hw/arm/stm32f205_soc.c | 22 ++ > include/hw/arm/stm32f205_soc.h | 3

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-02 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > NVDIMM for now is planned to use as a backing store for DAX filesystem > in the guest and thus this memory is excluded from guest memory > management and LRUs. > > In this case libvirt running QEMU along with configured balloon almost > immediately inflates

Re: [Qemu-devel] [PATCH v3 4/7] STM32F2xx: Add the SPI device

2016-02-02 Thread Peter Maydell
On 19 January 2016 at 07:23, Alistair Francis wrote: > Add the STM32F2xx SPI device. > > Signed-off-by: Alistair Francis > --- > V2: > - Address Peter C's comments > > default-configs/arm-softmmu.mak | 1 + > hw/ssi/Makefile.objs| 1 + > hw/ssi/stm32f2xx_spi.c | 205 >

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Pavel Fedin
Hello! > Shouldn't the default be "host", to mean "whatever the host supports", > rather than a specific version based either on host or QEMU probing? No, because: 1) Older qemu, which does not support this option, uses v2. 2) It also depends on whether KVM or TCG is used. Currently we can have

Re: [Qemu-devel] [PATCH 2/4] usb: add attached property

2016-02-02 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > USB devices in attached state are visible to the guest. >> >> If I read the code correctly: >> >> * ->attached is true between usb_device_attach() and usb_device_detach() >> >> * Attach and detach is automatic on realize and unrealize, but a device >> can

[Qemu-devel] proposed schedule for 2.6 release

2016-02-02 Thread Peter Maydell
I've sketched out some proposed dates for QEMU 2.6's release schedule (also at http://wiki.qemu.org/Planning/2.6) 2016-02-23 Soft feature freeze. 2016-03-22 Hard feature freeze. Tag -rc0 2016-03-29 Tag v2.6.0-rc1 2016-04-05 Tag v2.6.0-rc2 2016-04-12 Tag v2.6.0-rc3 20

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 15:09, Andrea Bolognani wrote: > Hold on, so "gic-version=3" means "support all GIC versions up to 3", > not "support GIC version 3 only"? I thought the latter. In the current implemented syntax, it means "expose a version 3 GIC to the guest". You can't simultaneously give t

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Eric Blake
On 02/02/2016 07:05 AM, Christoffer Dall wrote: >> >> I'm not familiar enough with libvirt, nor the use of QMP, to really argue >> one way or another, but I find it a bit strange that we'd prefer libvirt >> to query two entities over one. And, why should the libvirt installed on >> a particular ho

Re: [Qemu-devel] [PULL 0/2] ui: gtk vc fix, adaptive sdl refresh.

2016-02-02 Thread Peter Maydell
c-for-2.6-20160201' > into staging (2016-02-02 09:13:10 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-ui-20160202-1 > > for you to fetch changes up to 56bdd4b69aa10bec274b1e812685bcf44dcb0c72: > > sdl: shorten th

Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-02-02 Thread Eduardo Habkost
On Sun, Jan 31, 2016 at 04:40:54PM +0300, Valentin Rakush wrote: > Hi Eduardo, > > I will try to answer some of your questions at this email and will answer > other questions later. > > > Can you clarify what you mean by "TYPE_DEVICE has its own > > properties"? TYPE_DEVICE properties are registe

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 12:43 +0100, Laszlo Ersek wrote: > On 02/02/16 05:15, Alex Williamson wrote: > > The proposed IGD OpRegion support in QEMU via vfio maps the host > > OpRegion into VM system memory at the address written to the ASL > > Storage register (0xFC).  The OpRegion contains a 16-byte

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Tue, Feb 2, 2016 at 4:52 PM, Eric Blake wrote: > On 02/02/2016 07:05 AM, Christoffer Dall wrote: > >>> >>> I'm not familiar enough with libvirt, nor the use of QMP, to really argue >>> one way or another, but I find it a bit strange that we'd prefer libvirt >>> to query two entities over one. A

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-02 Thread Laszlo Ersek
On 02/02/16 16:56, Alex Williamson wrote: > On Tue, 2016-02-02 at 12:43 +0100, Laszlo Ersek wrote: >> On 02/02/16 05:15, Alex Williamson wrote: >>> The proposed IGD OpRegion support in QEMU via vfio maps the host >>> OpRegion into VM system memory at the address written to the ASL >>> Storage regis

[Qemu-devel] [RFC][PATCH v6 0/5] utils: Improve and document error reporting

2016-02-02 Thread Lluís Vilanova
Adds leaner error-reporting functions for simple cases, and documents the purpose of the different facilities available in QEMU. Although not all printf+exit/abort are replaced with the proper functions, a few are ported as an example. Changes in v6 = * Rebase on 074d1cc [David Gibs

[Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-02 Thread Lluís Vilanova
Provide two lean functions to report error messages that fatal/abort QEMU. Signed-off-by: Lluís Vilanova --- include/qemu/error-report.h | 19 +++ util/qemu-error.c | 33 + 2 files changed, 52 insertions(+) diff --git a/include/qemu/

qemu-devel@nongnu.org

2016-02-02 Thread Lluís Vilanova
Replaces all direct uses of 'error_setg(&error_fatal/abort)' with 'error_report_fatal/abort'. Also reimplements the former on top of the latter. Signed-off-by: Lluís Vilanova --- hw/block/fdc.c |6 +++--- hw/ppc/spapr.c |8 hw/ppc/spapr_drc.c |2 +- util/error.c

[Qemu-devel] [PATCH v6 3/5] util: [ppc] Use new error_report_fatal() instead of exit()

2016-02-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-ppc/kvm.c|5 +-- target-ppc/translate.c |7 ++-- target-ppc/translate_init.c | 80 +-- 3 files changed, 44 insertions(+), 48 deletions(-) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c i

[Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort()

2016-02-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-ppc/kvm.c|4 ++-- target-ppc/kvm_ppc.h| 15 +-- target-ppc/mmu-hash32.c |5 +++-- target-ppc/mmu_helper.c |3 +-- 4 files changed, 15 insertions(+), 12 deletions(-) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c ind

[Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-02 Thread Lluís Vilanova
Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 37 + 1 file changed, 37 insertions(+) diff --git a/HACKING b/HACKING index 12fbc8a..b738bce 100644 --- a/HACKING +++ b/HACKING @@ -157,3 +157,40 @@ pain

Re: [Qemu-devel] [PATCH 2/6] i.MX: simplify CCM to only handle clock required by timers.

2016-02-02 Thread Peter Maydell
On 26 January 2016 at 21:44, Jean-Christophe Dubois wrote: > Various i.MX timers (GPT, EPIT, PWM, ...) are only requesting 4 clocks > from the system. > * CLK_NONE, > * CLK_IPG, > * CLK_IPG_HIGH, > * CLK_32k > > Other "clocks" are not required by the qemu framework so far. This patch confuses me

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to use the alternative 'q_mips' spelling.

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Kevin O'Connor
On Tue, Feb 02, 2016 at 09:56:20AM +0100, Gerd Hoffmann wrote: > Hi, > > > > I'd have qemu copy the data on 0xfc write then, so things continue to > > > work without updating seabios. So, the firmware has to allocate space, > > > reserve it etc., and programming the 0xfc register. Qemu has to

Re: [Qemu-devel] [PATCH 3/6] i.MX: Add i.MX6 CCM and ANALOG device.

2016-02-02 Thread Peter Maydell
On 26 January 2016 at 21:45, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > +static uint32_t imx6_analog_get_pll2_clk(IMX6CCMState *dev) > +{ > +uint32_t freq = 2400; > + > +if (EXTRACT(dev->analog[CCM_ANALOG_PLL_SYS], DIV_SELECT)) { > +freq *= 22; >

Re: [Qemu-devel] [PATCH 4/6] i.MX: Add i.MX6 System Reset Controller device.

2016-02-02 Thread Peter Maydell
On 26 January 2016 at 21:45, Jean-Christophe Dubois wrote: > This controller is also present in i.MX5X devices but they are not > yet emulated by Qemu. QEMU is all-caps. > Signed-off-by: Jean-Christophe Dubois > --- > hw/misc/Makefile.objs | 1 + > hw/misc/imx6_src.c | 353 > +

Re: [Qemu-devel] [PATCH 6/6] i.MX: Add sabrelite i.MX6 emulation.

2016-02-02 Thread Peter Maydell
On 26 January 2016 at 21:45, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > hw/arm/Makefile.objs | 2 +- > hw/arm/sabrelite.c | 93 > > 2 files changed, 94 insertions(+), 1 deletion(-) > create mode 100644

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Laszlo Ersek
Including Igor & MST Thanks Laszlo On 02/02/16 17:31, Kevin O'Connor wrote: > On Tue, Feb 02, 2016 at 09:56:20AM +0100, Gerd Hoffmann wrote: >> Hi, >> I'd have qemu copy the data on 0xfc write then, so things continue to work without updating seabios. So, the firmware has to allocate

Re: [Qemu-devel] [PATCH 5/6] i.MX: Add i.MX6 SOC implementation.

2016-02-02 Thread Peter Maydell
On 26 January 2016 at 21:45, Jean-Christophe Dubois wrote: > For now we only support the following devices: > * up to 4 Cortex A9 cores > * A9 MPCORE (SCU, GIC, TWD) > * 5 i.MX UARTs > * 2 EPIT timers > * 1 GPT timer > * 7 GPIO controllers > * 6 SDHC controllers > * 1 CCM device > * 1 SRC device

Re: [Qemu-devel] [PATCH 0/6] Add i.MX6 (Single/Dual/Quad) support

2016-02-02 Thread Peter Maydell
On 28 January 2016 at 19:22, Jean-Christophe DUBOIS wrote: > Sabrelite uses uart2 for console but on qemu, this is uart1 that is wired to > the default stdout. Consequently, I changed stdout-path in "chosen" to > uart1. This I find a bit awkward: we'd like to get eventually to the point where yo

Re: [Qemu-devel] [PULL v1 0/3] Misc fixes for crypto/ code

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 13:15, Daniel P. Berrange wrote: > The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: > > hw: Clean up includes (2016-01-29 15:07:25 +) > > are available in the git repository at: > > git://github.com/berrange/qemu tags/pull-qcrypto-next-2016

Re: [Qemu-devel] [PATCH v2 1/2] block: set device_list.tqe_prev to NULL on BDS removal

2016-02-02 Thread Max Reitz
On 02.02.2016 02:33, Jeff Cody wrote: > This fixes a regression introduced with commit 3f09bfbc7. Multiple > bugs arise in conjunction with live snapshots and mirroring operations > (which include active layer commit). > > After a live snapshot occurs, the active layer and the base layer both > h

Re: [Qemu-devel] [PATCH v2 2/2] block: qemu-iotests - add test for snapshot, commit, snapshot bug

2016-02-02 Thread Max Reitz
On 02.02.2016 02:33, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/143 | 114 > + > tests/qemu-iotests/143.out | 24 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 139 insertions(+) > create mode 1007

Re: [Qemu-devel] [PATCH v1 07/22] migration: introduce a new QEMUFile impl based on QIOChannel

2016-02-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Introduce a new QEMUFile implementation that is based on > the QIOChannel objects. This impl is different from existing > impls in that there is no file descriptor that can be made > available, as some channels may be based on higher level > proto

Re: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix

2016-02-02 Thread Max Reitz
On 02.02.2016 02:33, Jeff Cody wrote: > Changes from v1: > > * Rather than allow insertion when bs->device_listtqe_prev points to > a NULL entry, make sure than we follow the block scheme of enforcing > bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!) > > Bug #1300209 is a regre

[Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
https://patchwork.ozlabs.org/patch/570128/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Alex Williamson
On Tue, 2016-02-02 at 00:31 -0800, Neo Jia wrote: > On Tue, Feb 02, 2016 at 08:18:44AM +, Tian, Kevin wrote: > > > From: Neo Jia [mailto:c...@nvidia.com] > > > Sent: Tuesday, February 02, 2016 4:13 PM > > >  > > > On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > > > >   Hi, > >

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote: > https://patchwork.ozlabs.org/patch/570128/ > > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message

Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration

2016-02-02 Thread Max Reitz
On 13.01.2016 03:50, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > The out

Re: [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown

2016-02-02 Thread Stefan Hajnoczi
On Fri, Jan 15, 2016 at 04:12:03PM +0100, Paolo Bonzini wrote: > This is the infrastructure part of the aio_context_acquire/release pushdown, > which in turn is the first step towards a real multiqueue block layer in > QEMU. The next step is to touch all the drivers and move calls to the > aio_con

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 14:51, Eric Blake wrote: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to use the alt

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 12:16 PM, Daniel P. Berrange wrote: > On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote: >> https://patchwork.ozlabs.org/patch/570128/ >> >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear

Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend

2016-02-02 Thread Stefan Hajnoczi
On Fri, Jan 29, 2016 at 04:07:48PM +, Stefan Hajnoczi wrote: > The GThread coroutine backend was a portable coroutine implementation. > Over the years all platforms got their own optimized coroutine > implementations and nothing uses the GThread backend anymore. > > In fact, ./configure mentio

Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend

2016-02-02 Thread Stefan Hajnoczi
On Mon, Feb 01, 2016 at 12:17:14PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Fri, Jan 29, 2016 at 04:41:41PM +, Alex Bennée wrote: > >> > >> Stefan Hajnoczi writes: > >> > >> > The GThread coroutine backend was a portable coroutine implementation. > >> > Over the years

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 12:28:24PM -0500, Programmingkid wrote: > > On Feb 2, 2016, at 12:16 PM, Daniel P. Berrange wrote: > > > On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote: > >> https://patchwork.ozlabs.org/patch/570128/ > >> > >> Mac OS X can be picky when it comes to allowi

[Qemu-devel] [PATCH v4 0/6] Travis updates

2016-02-02 Thread Alex Bennée
Hi, Here is v4 of the Travis updates. The first patch remains reviewed and signed off but following feedback on the others I've tried harder to reduce the load on the Travis build farm after defaulting "make check". This breaks down into two things: - enabling ccache - reducing the build matr

[Qemu-devel] [PATCH v4 3/6] .travis.yml: enable each of the co-routine backends

2016-02-02 Thread Alex Bennée
We disable "make check" for the gthread backend as it is broken. Signed-off-by: Alex Bennée --- .travis.yml | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 16be23f..021eec7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -94,6 +94

[Qemu-devel] [PATCH v4 4/6] .travis.yml: enable ccache for the builds

2016-02-02 Thread Alex Bennée
Travis support ccache on a cache-per-branch basis. Given not much of the build changes between pushes as well as the duplication in each build it seems worthwhile enabling this. Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.y

[Qemu-devel] [PULL v2 01/50] block: Add blk_dev_has_tray()

2016-02-02 Thread Max Reitz
Pull out the check whether a block device has a tray from blk_dev_is_tray_open() into its own function so both attributes (whether there is a tray vs. whether that tray is open) can be queried independently. Cc: qemu-stable Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto G

[Qemu-devel] [PATCH v4 5/6] .travis.yml: reduce the test matrix a little

2016-02-02 Thread Alex Bennée
As we are now running "make check" on more of the matrix it is worth making more of an effort to reduce the overall load on Travis. I've done a few things: - Combining a number of the targets - Building one target for each ancillary build Signed-off-by: Alex Bennée --- .travis.yml | 42

[Qemu-devel] [PATCH v4 1/6] .travis.yml: migrate to container builds

2016-02-02 Thread Alex Bennée
This moves the Travis tests from the legacy VM infrastructure (which only seems to run 5-6 jobs at once) to the new container based approach. The principle difference is there is no sudo in the containers so all packages are installed using the apt add-on. This means one of the build combinations

[Qemu-devel] [PATCH v4 2/6] .travis.yml: run make check for all matrix targets

2016-02-02 Thread Alex Bennée
We only ran make check once before it used to be an unreliable target. It was only a stop gap measure and we should be able to revert it now. This also stops us needing a large all-MMU build. We disable "make check" for a couple of the extra config targets which are currently broken. Signed-off-b

[Qemu-devel] [PULL v2 06/50] iotests: Limit supported formats for 118

2016-02-02 Thread Max Reitz
Image formats used in test 118 need to support image creation. Reported-by: Markus Armbruster Signed-off-by: Max Reitz Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- tests/qemu-iotests/118 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/

[Qemu-devel] [PULL v2 04/50] block/qapi: Emit tray_open only if there is a tray

2016-02-02 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Message-id: 1454096953-31773-5-git-send-email-mre...@redhat.com --- block/qapi.c | 2 +- qapi/block-core.json | 4 ++-- tests/qemu-iotests/067.out | 4 3 files changed, 3 insertions(+), 7 delet

[Qemu-devel] [PULL v2 00/50] Block patches

2016-02-02 Thread Max Reitz
This pull request supersedes Kevin's pull request from Friday (http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg06026.html). The following changes since commit d2ea854c382d4d080de1f149167e60290108f79b: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-next-2016-02-02-

[Qemu-devel] [PATCH v4 6/6] MAINTAINERS: Add .travis.yml

2016-02-02 Thread Alex Bennée
Signed-off-by: Alex Bennée --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6ed87a..426a735 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1566,6 +1566,11 @@ L: qemu-bl...@nongnu.org S: Supported F: tests/image-fuzzer/ +Build and test a

[Qemu-devel] [PULL v2 05/50] vmdk: Fix converting to streamOptimized

2016-02-02 Thread Max Reitz
From: Fam Zheng Commit d62d9dc4b8 lifted streamOptimized images's version to 3, but we now refuse to open version 3 images read-write. We need to make streamOptimized an exception to allow converting to it. This fixes the accidentally broken iotests case 059 for the same reason. Signed-off-by:

[Qemu-devel] [PULL v2 02/50] blockdev: Fix 'change' for slot devices

2016-02-02 Thread Max Reitz
'change' and related operations did not work when used on guest devices featuring removable media but no actual tray, because blk_dev_is_tray_open() always returned false for them and the blockdev-{insert,remove}-medium commands required it to return true. Fix this by making blockdev-{insert,remov

[Qemu-devel] [PULL v2 11/50] iotests: Make _filter_nbd drop log lines

2016-02-02 Thread Max Reitz
The NBD log lines ("/your/source/dir/nbd/xyz.c:function():line: error") should not be converted to empty lines but removed altogether. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/083.out | 10 -- tests/qemu-iotests/common.filt

[Qemu-devel] [PULL v2 07/50] nbd: client_close on error in nbd_co_client_start

2016-02-02 Thread Max Reitz
Use client_close() if an error in nbd_co_client_start() occurs instead of manually inlining parts of it. This fixes an assertion error on the server side if nbd_negotiate() fails. Signed-off-by: Max Reitz Acked-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- nbd/server

[Qemu-devel] [PULL v2 03/50] Revert "hw/block/fdc: Implement tray status"

2016-02-02 Thread Max Reitz
This reverts the changes that commit 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c; also, an additional case of drv->media_inserted use has crept in since, which is replaced by a call to blk_is_inserted(). That commit changed tests/fdc-test.c, too, because after it, one less T

[Qemu-devel] [PULL v2 12/50] iotests: Make _filter_nbd support more URL types

2016-02-02 Thread Max Reitz
This function should support URLs of the "nbd://" format (without swallowing the export name), and for "nbd:///" URLs it should replace "?socket=$TEST_DIR" by "?socket=TEST_DIR" because putting the Unix socket files into the test directory makes sense. Signed-off-by: Max Reitz Reviewed-by: John S

<    1   2   3   4   >