Re: [Qemu-devel] [PATCH v3 0/3] Travis updates

2016-02-02 Thread Michael Tokarev
31.01.2016 11:43, Alex Bennée wrote: > Michael Tokarev writes: >> 28.01.2016 17:23, Alex Bennée wrote: >>> Hi, >>> >>> The first patch has been reviewed and signed off. Long term I think >>> it is worth applying but it look like the performance increase it >>> negligible compared to the old style

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Gerd Hoffmann
Hi, > And for UUID, I remember Alex had a concern on using it in kernel. > Honestly speaking I don't have a good idea here. In Xen side there is a VM ID > which can be easily used as the index. But for KVM, what would be the best > identifier to associate with a VM? The vgpu code doesn't need

Re: [Qemu-devel] [PATCH v2] ES1370: QOMify

2016-02-02 Thread Michael Tokarev
Sorry I replied to the wrong email. I actually applied this one :) /mjt

Re: [Qemu-devel] [PATCH v2] ES1370: QOMify

2016-02-02 Thread Cao jin
Thanks mjt:) On 02/02/2016 04:00 PM, Michael Tokarev wrote: Sorry I replied to the wrong email. I actually applied this one :) /mjt -- Yours Sincerely, Cao jin

Re: [Qemu-devel] [PATCH 0/2] CCID QOMify

2016-02-02 Thread Cao jin
Hi mjt, I guess these two are suitable for trivial too;) but I forget to cc trivial at first... On 02/01/2016 02:53 PM, Cao jin wrote: As each commit says Cao jin (2): Emulated CCID card: QOMify Passthru CCID card: QOMify hw/usb/ccid-card-emulated.c | 20 +--- h

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Neo Jia
On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > Hi, > > > And for UUID, I remember Alex had a concern on using it in kernel. > > Honestly speaking I don't have a good idea here. In Xen side there is a VM > > ID > > which can be easily used as the index. But for KVM, what would

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Michael Tokarev
01.02.2016 09:53, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/usb/ccid-card-emulated.c | 20 +--- > hw/usb/ccid.h | 4 > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c > inde

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Tuesday, February 02, 2016 4:13 PM > > On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > And for UUID, I remember Alex had a concern on using it in kernel. > > > Honestly speaking I don't have a good idea here. In Xe

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
On 02/02/2016 04:15 PM, Michael Tokarev wrote: 01.02.2016 09:53, Cao jin wrote: Signed-off-by: Cao jin --- hw/usb/ccid-card-emulated.c | 20 +--- hw/usb/ccid.h | 4 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/usb/ccid-card-emulat

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Gerd Hoffmann
On Di, 2016-02-02 at 00:13 -0800, Neo Jia wrote: > On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > And for UUID, I remember Alex had a concern on using it in kernel. > > > Honestly speaking I don't have a good idea here. In Xen side there is a > > > VM ID > > >

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Michael Tokarev
02.02.2016 11:25, Cao jin wrote: > On 02/02/2016 04:15 PM, Michael Tokarev wrote: >> Why did you move the type definition from .c to .h file? >> It is only referenced in .c, no? [] > Yes, that type definition is referred only in .c for now, but we are not sure > about it in the future, for better

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Neo Jia
On Tue, Feb 02, 2016 at 08:18:44AM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Tuesday, February 02, 2016 4:13 PM > > > > On Tue, Feb 02, 2016 at 09:00:43AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > And for UUID, I remember Alex had a concern on using

Re: [Qemu-devel] [PATCH v2 1/8] ivshmem: no need for opaque argument

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 3/8] ivshmem-test: leak fixes

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Add a cleanup_vm() function to free QPCIDevice & QPCIBus when cleaning > up the IVState. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 5/8] ivshmem-test: test both msi & irq cases

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Recent commit 660c97ee introduced a regression in irq case, make > sure this code path is also tested. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Simplify the interrupt handling by having a single callback on irq&msi > cases. Remove usage of CharDriver, replace it with > qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the > eventfd. > > Before this patch,

Re: [Qemu-devel] [PATCH v2 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Call ivshmem_setup_interrupts() with or without MSI, always allocate > msi_vectors that is going to be used in all case in the following patch. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 26 -

Re: [Qemu-devel] [PATCH v2 4/8] libqos: remove some leaks

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > qpci_device_find() returns allocated data, don't leak it. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 8/8] char: remove qemu_chr_open_eventfd

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Broken since d0d7708ba29cbc, since the backend is NULL. > > And now no longer needed by ivshmem. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 0/8] ivshmem: test msi=off, fix regressions, remove CharDriver

2016-02-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This is a ivshmem series with various bits: > - add a test for msi=off regression (the fix is included in the series > but was sent separatly to cc -stable) > - get rid of CharDriver usage for eventfd & fix regression introduced

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

2016-02-02 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: >>> The existing users pass a func that saves dev, and free the saved dev >>> later. Works as long as we call func() at most once. If multiple >>> devices match, all b

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread Gerd Hoffmann
Hi, > > I'd have qemu copy the data on 0xfc write then, so things continue to > > work without updating seabios. So, the firmware has to allocate space, > > reserve it etc., and programming the 0xfc register. Qemu has to make > > sure the opregion appears at the address written by the firmwar

Re: [Qemu-devel] [PATCH 1/2] Emulated CCID card: QOMify

2016-02-02 Thread Cao jin
On 02/02/2016 04:30 PM, Michael Tokarev wrote: 02.02.2016 11:25, Cao jin wrote: On 02/02/2016 04:15 PM, Michael Tokarev wrote: Why did you move the type definition from .c to .h file? It is only referenced in .c, no? [] Yes, that type definition is referred only in .c for now, but we are no

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > On 02/01/2016 06:07 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> No backend was setting an error when ending an implicit struct, >>> or when iterating a list. >> >> Perhaps "when ending the visit of a list or implicit struct, or when >> moving to the next list

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-02 Thread Kirti Wankhede
On 2/2/2016 1:12 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Tuesday, February 02, 2016 9:48 AM Resending this mail again, somehow my previous mail didn't reached every to everyone's inbox. On 2/2/2016 3:16 AM, Kirti Wankhede wrote: Design for vGPU Driver:

Re: [Qemu-devel] [PATCH 00/16] aio: first part of aio_context_acquire/release pushdown

2016-02-02 Thread Paolo Bonzini
On 15/01/2016 16:12, Paolo Bonzini wrote: > This is the infrastructure part of the aio_context_acquire/release pushdown, > which in turn is the first step towards a real multiqueue block layer in > QEMU. The next step is to touch all the drivers and move calls to the > aio_context_acquire/releas

Re: [Qemu-devel] [PATCH v4 0/3] don't use NVDIMM for balooning

2016-02-02 Thread Denis V. Lunev
On 01/28/2016 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: v4: 0001: Reviewed-by: Eric Blake second patch is splitted to 0002 and 0003 0002: Add 'type' field instead of 'balloonable' to PCDIMMDeviceInfo 0003: chec 'type' instead of 'balloonable' v3: - do not use additional class v

Re: [Qemu-devel] [PATCH 0/2] fixes for bdrv_invalidate_cache

2016-02-02 Thread Denis V. Lunev
On 01/20/2016 10:12 AM, Denis V. Lunev wrote: Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Paolo Bonzini guys?

Re: [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E)

2016-02-02 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> Based on qemu.git master. No pending prerequisites >> >> Also available as a tag at this location: >> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv10e >> >> and will soon be part of my branch with the rest of the v5 series, at: >> htt

Re: [Qemu-devel] [PATCH v4 7/7] mips/kvm: Support MSA in MIPS KVM guests

2016-02-02 Thread Leon Alrae
Hi James, On 18/12/15 10:46, James Hogan wrote: > @@ -611,17 +664,51 @@ static int kvm_mips_get_fpu_registers(CPUState *cs) > restore_flush_mode(env); > } > > -/* Floating point registers */ > -for (i = 0; i < 32; ++i) { > -if (env->CP0_Status &

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-02 Thread Igor Mammedov
On Sun, 31 Jan 2016 18:22:13 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jan 29, 2016 at 12:13:59PM +0100, Igor Mammedov wrote: > > On Thu, 28 Jan 2016 14:59:25 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jan 28, 2016 at 01:03:16PM +0100, Igor Mammedov wrote: > > > > On Thu, 28

Re: [Qemu-devel] [PATCH v4 05/10] qemu-io: allow specifying image as a set of options args

2016-02-02 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 03:26:51PM +0100, Kevin Wolf wrote: > Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben: > > -if ((argc - optind) == 1) { > > +if (imageOpts) { > > +char *file; > > +qopts = qemu_opts_parse_noisily(&file_opts, argv[optind], false); > > +

Re: [Qemu-devel] [PATCH] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-02 Thread Gerd Hoffmann
On Mo, 2016-02-01 at 09:35 +0100, Laszlo Ersek wrote: > Gerd, > > On 02/01/16 06:57, vladislav.vovche...@sk.com wrote: > >> -Original Message- > >> From: Laszlo Ersek [mailto:ler...@redhat.com] > >> Sent: 27 January 2016 02:21 > >> To: qemu-devel@nongnu.org > >> Cc: Keith Busch; Kevin Wolf

Re: [Qemu-devel] [PATCH v2 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-02 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Call ivshmem_setup_interrupts() with or without MSI, always allocate > > msi_vectors that is going to be used in all case in the following patch. > > > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PULL 00/40] ppc-for-2.6 queue 20160201

2016-02-02 Thread Peter Maydell
On 1 February 2016 at 02:30, David Gibson wrote: > The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: > > hw: Clean up includes (2016-01-29 15:07:25 +) > > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160201 > >

Re: [Qemu-devel] [PATCH v4 02/10] qemu-img: add support for --object command line arg

2016-02-02 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 02:26:53PM +0100, Kevin Wolf wrote: > Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben: > > Allow creation of user creatable object types with qemu-img > > via a new --object command line arg. This will be used to supply > > passwords and/or encryption keys to the v

Re: [Qemu-devel] [PATCH] target-mips: Stop using uint_fast*_t types in r4k_tlb_t struct

2016-02-02 Thread Leon Alrae
On 25/01/16 17:40, Peter Maydell wrote: > The r4k_tlb_t structure uses the uint_fast*_t types. Most of these > uses are in bitfields and are thus pointless, because the bitfield > itself specifies the width of the type; just use 'unsigned int' > instead. (On glibc uint_fast16_t is defined as either

Re: [Qemu-devel] [PULL 00/17] Net patches

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 02:36, Jason Wang wrote: > The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: > > hw: Clean up includes (2016-01-29 15:07:25 +) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Gerd Hoffmann
Hi, > %.img: %.o > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s -o $@ > $<," Building $(TARGET_DIR)$@") > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 -Ttext 0 -e > _start -s -o $@ $<," Building $(TARGET_DIR)$@") Hmm, that breaks the windows cros

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2016 at 10:59:53AM +0100, Igor Mammedov wrote: > On Sun, 31 Jan 2016 18:22:13 +0200 > "Michael S. Tsirkin" wrote: > > > On Fri, Jan 29, 2016 at 12:13:59PM +0100, Igor Mammedov wrote: > > > On Thu, 28 Jan 2016 14:59:25 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Th

Re: [Qemu-devel] [PATCH v2 0/5] KVM: Hyper-V VMBus hypercalls

2016-02-02 Thread Andrey Smetanin
ping On 01/21/2016 05:01 PM, Andrey Smetanin wrote: The patch implements userspace exit 'KVM_EXIT_HYPERV' for Hyper-V VMBus hypercalls(postmsg, signalevent) to handle these hypercalls by QEMU. Changes v2: * use KVM_EXIT_HYPERV for hypercalls Signed-off-by: Andrey Smetanin Reviewed-by: Roman K

Re: [Qemu-devel] [PATCH v3 1/2] build: [linux-user] Rename "syscall.h" to "target_syscall.h" in target directories

2016-02-02 Thread Peter Maydell
On 1 February 2016 at 18:38, Lluís Vilanova wrote: > This fixes double-definitions in linux-user builds when using the UST > tracing backend (which indirectly includes the system's "syscall.h"). > > Signed-off-by: Lluís Vilanova > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v4 03/10] qemu-nbd: add support for --object command line arg

2016-02-02 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 02:57:51PM +0100, Kevin Wolf wrote: > Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben: > > Allow creation of user creatable object types with qemu-nbd > > via a new --object command line arg. This will be used to supply > > passwords and/or encryption keys to the v

Re: [Qemu-devel] [PATCH v4 07/10] qemu-img: allow specifying image as a set of options args

2016-02-02 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 03:30:29PM +0100, Kevin Wolf wrote: > Am 26.01.2016 um 14:34 hat Daniel P. Berrange geschrieben: > > Currently qemu-img allows an image filename to be passed on the > > command line, but unless using the JSON format, it does not have > > a way to set any options except the f

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-02 Thread Laszlo Ersek
On 02/02/16 05:15, Alex Williamson wrote: > The proposed IGD OpRegion support in QEMU via vfio maps the host > OpRegion into VM system memory at the address written to the ASL > Storage register (0xFC). The OpRegion contains a 16-byte signature > followed by a 4-byte size field. Therefore SeaBIOS

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Christoffer Dall
On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > > That's correct, having a QMP command that lists the values gic-version > > > can have on the current ho

Re: [Qemu-devel] [Xen-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-02 Thread David Woodhouse
On Tue, 2016-02-02 at 06:42 +, Tian, Kevin wrote: > > From: Kay, Allen M > > Sent: Tuesday, February 02, 2016 8:04 AM > > > > > > David notes in the latter commit above: > > > > > > "We should be able to successfully assign graphics devices to guests too, > > > as > > > long as the initial h

Re: [Qemu-devel] [PATCH v2 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Call ivshmem_setup_interrupts() with or without MSI, always allocate >> > msi_vectors that is going to be used in all case in the following patch. >>

Re: [Qemu-devel] [PATCH v2 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-02 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > Call ivshmem_setup_interrupts() with or without MSI, always allocate > >> > msi_vectors that is g

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Gerd Hoffmann
On Di, 2016-02-02 at 12:06 +0100, Gerd Hoffmann wrote: > Hi, > > > %.img: %.o > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s -o $@ > > $<," Building $(TARGET_DIR)$@") > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 -Ttext 0 -e > > _start -s -o $@ $<

Re: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices

2016-02-02 Thread Marcel Apfelbaum
On 01/19/2016 10:04 AM, Marcel Apfelbaum wrote: On 01/18/2016 08:16 PM, Laszlo Ersek wrote: On 01/18/16 19:08, Peter Maydell wrote: On 18 January 2016 at 15:27, Marcel Apfelbaum wrote: PCI devices can't be plugged directly into PCI extra root bridges because their resources can't be computed

Re: [Qemu-devel] [PATCH v4 0/3] target-arm: Add a few more S2 MMU input checks

2016-02-02 Thread Peter Maydell
On 27 January 2016 at 22:16, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > This adds the inputsize > pamax check and also fixes the > startlevel checks to apply to the 64bit translations. > > Comments welcome! Thanks, applied to target-arm.next. -- PMM

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Daniel P. Berrange
On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > > On 6 January 2016 at 12:49, Andrea Bolognani wrote: > > > > That's correct, having a QMP

Re: [Qemu-devel] [PATCH v3 1/2] cpu: Add callback to check architectural watchpoint match

2016-02-02 Thread Peter Maydell
On 31 January 2016 at 16:15, Sergey Fedorov wrote: > When QEMU watchpoint matches, that is not definitely an architectural > watchpoint match yet. If it is a stop-before-access watchpoint then that > is hardly possible to ignore it after throwing a TCG exception. > > A special callback is introduc

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2016-02-02 Thread James Hogan
Hi Eric, On 18 November 2015 at 08:52, Eric Blake wrote: > +# An enumeration of cpu types that enable additional information during > +# @query-cpus. > +# > +# Since: 2.6 > +## > +{ 'enum': 'CpuInfoArch', > + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] } > + ... > +## > +# @Cp

Re: [Qemu-devel] [PATCH v3 0/4] Netfilter: Add each netdev a default filter

2016-02-02 Thread Hailiang Zhang
Hi Hongyang, On 2016/2/2 11:11, Yang Hongyang wrote: If we have to add a default filter, then I have a suggestion only for this series: 1. Add a nop filter. filter-nop.c I'm not quite sure if we really need to add a new type 'nop' filter, because it is only a special case for buffer-filter, wh

Re: [Qemu-devel] [PATCH v4 7/7] mips/kvm: Support MSA in MIPS KVM guests

2016-02-02 Thread James Hogan
Hi Leon, On Tue, Feb 02, 2016 at 09:58:46AM +, Leon Alrae wrote: > Hi James, > > On 18/12/15 10:46, James Hogan wrote: > > @@ -611,17 +664,51 @@ static int kvm_mips_get_fpu_registers(CPUState *cs) > > restore_flush_mode(env); > > } > > > > -/* Floating point re

[Qemu-devel] [PULL 1/8] ivshmem: no need for opaque argument

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- hw/misc/ivshmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index d5c89ae..358df24 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshme

[Qemu-devel] [PULL 0/8] Ivshmem patches

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 10ae9d76388e3f4a31f6a1475b5e2d1f28404a10: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-20160201' into staging (2016-02-02 09:13:10 +) are available in the git repository at: g...@github.com:elmarco/qemu.git t

[Qemu-devel] [PULL 5/8] ivshmem-test: test both msi & irq cases

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Recent commit 660c97ee introduced a regression in irq case, make sure this code path is also tested. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/ivshmem-test.c | 53 1 file changed, 37 i

[Qemu-devel] [PULL 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Call ivshmem_setup_interrupts() with or without MSI, always allocate msi_vectors that is going to be used in all case in the following patch. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- hw/misc/ivshmem.c | 23 --- 1 file chan

[Qemu-devel] [PULL 4/8] libqos: remove some leaks

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau qpci_device_find() returns allocated data, don't leak it. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/libqos/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c index 4e630c2..80b1a21 100644

[Qemu-devel] [PULL 3/8] ivshmem-test: leak fixes

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Add a cleanup_vm() function to free QPCIDevice & QPCIBus when cleaning up the IVState. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/ivshmem-test.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --

[Qemu-devel] [PULL 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Simplify the interrupt handling by having a single callback on irq&msi cases. Remove usage of CharDriver, replace it with qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the eventfd. Before this patch, ivshmem writes the first byte received to s->intrst

[Qemu-devel] [PULL 2/8] ivshmem: remove redundant assignment, fix crash with msi=off

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in this case) Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- hw/misc/ivshmem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 35

[Qemu-devel] [PULL 8/8] char: remove qemu_chr_open_eventfd

2016-02-02 Thread marcandre . lureau
From: Marc-André Lureau Broken since d0d7708ba29cbc, since the backend is NULL. And now no longer needed by ivshmem. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- include/sysemu/char.h | 3 --- qemu-char.c | 13 - 2 files changed, 16 deletions(-)

Re: [Qemu-devel] [PATCH v2 2/5] qapi: switch x-input-send-event from console to device+head

2016-02-02 Thread Markus Armbruster
Gerd Hoffmann writes: > Use display device qdev id and head number instead of console index to > specify the QemuConsole. This makes things consistent with input > devices (for input routing) and vnc server configuration, which both use > display and head too. > > Signed-off-by: Gerd Hoffmann >

[Qemu-devel] [PULL 0/1] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-02 Thread Gerd Hoffmann
pc-for-2.6-20160201' into staging (2016-02-02 09:13:10 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-fwcfg-20160202-1 for you to fetch changes up to a907ec52cc1aefc820768b6e341b56f8f3caaca7: nvme: generate OpenFirmware device path in the "bo

Re: [Qemu-devel] [PATCH v2 1/5] console: add & use qemu_console_lookup_by_device_name

2016-02-02 Thread Markus Armbruster
With the trivial doc fix in PATCH 2, series Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible

2016-02-02 Thread Daniel P. Berrange
This series of patches expands the syntax of the qemu-img, qemu-nbd and qemu-io commands to make them more flexible. v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html v2: https://lists.gnu.org/archi

[Qemu-devel] [PATCH v5 05/10] qemu-io: allow specifying image as a set of options args

2016-02-02 Thread Daniel P. Berrange
Currently qemu-io allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-io https://127.0.0.1/images/centos7.iso qemu-io /home/berrange/demo.qcow2 This adds a --image-opts arg that indicate

[Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Daniel P. Berrange
The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). The HMP and main emulator startup code also share further logic that extracts the qom-type & id values from a qdict. We soon need to use

[Qemu-devel] [PULL 1/1] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-02 Thread Gerd Hoffmann
From: Laszlo Ersek Background on QEMU boot indices --- Normally, the "bootindex" property is configured for bootable devices with: DEVICE_instance_init() device_add_bootindex_property(..., "bootindex", ...) object_property_add(..., device_get_bootindex,

[Qemu-devel] [PATCH v5 08/10] qemu-nbd: don't overlap long option values with short options

2016-02-02 Thread Daniel P. Berrange
When defining values for long options, the normal practice is to start numbering from 256, to avoid overlap with the range of valid values for short options. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(

[Qemu-devel] [PATCH v5 02/10] qemu-img: add support for --object command line arg

2016-02-02 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-img via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-img info --object

[Qemu-devel] [PATCH v5 06/10] qemu-nbd: allow specifying image as a set of options args

2016-02-02 Thread Daniel P. Berrange
Currently qemu-nbd allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-nbd https://127.0.0.1/images/centos7.iso qemu-nbd /home/berrange/demo.qcow2 This adds a --image-opts arg that i

[Qemu-devel] [PATCH v5 09/10] qemu-nbd: use no_argument/required_argument constants

2016-02-02 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 47 --- 1 file changed, 24 insertions(+), 2

[Qemu-devel] [PATCH v5 10/10] qemu-io: use no_argument/required_argument constants

2016-02-02 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-io.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) di

[Qemu-devel] [PATCH v5 03/10] qemu-nbd: add support for --object command line arg

2016-02-02 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-nbd via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-nbd --object secr

[Qemu-devel] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args

2016-02-02 Thread Daniel P. Berrange
Currently qemu-img allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --image-opts arg that indicates that the positional file

[Qemu-devel] [PATCH v5 04/10] qemu-io: add support for --object command line arg

2016-02-02 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-io via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-io --object secret

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Andrew Jones
On Tue, Feb 02, 2016 at 12:10:10PM +, Daniel P. Berrange wrote: > On Tue, Feb 02, 2016 at 12:49:33PM +0100, Christoffer Dall wrote: > > On Fri, Jan 22, 2016 at 02:44:32PM +, Daniel P. Berrange wrote: > > > On Wed, Jan 06, 2016 at 01:30:16PM +, Peter Maydell wrote: > > > > On 6 January 2

[Qemu-devel] [PULL 1/1] audio: Clean up includes

2016-02-02 Thread Gerd Hoffmann
From: Peter Maydell Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Peter Maydell Message-id: 1453138432-8324-1-git-send-email-peter.mayd...@linaro.org Signed-off-by:

Re: [Qemu-devel] [PATCH 1/4] usb: make USBDevice->attached bool

2016-02-02 Thread Markus Armbruster
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL 0/1] audio: Clean up includes

2016-02-02 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-audio-20160202-1 for you to fetch changes up to 6086a565b0efe3eb66c5bf65a715a2c84425e47f: audio: Clean up includes (2016-02-02 13:57:31 +0100) audio: Clean u

[Qemu-devel] [PULL 2/2] sdl: shorten the GUI refresh interval when mouse or keyboard is active

2016-02-02 Thread Gerd Hoffmann
From: Jindřich Makovička Signed-off-by: Jindřich Makovička Signed-off-by: Gerd Hoffmann --- include/ui/sdl2.h | 1 + ui/sdl.c | 22 ++ ui/sdl2.c | 23 +++ 3 files changed, 46 insertions(+) diff --git a/include/ui/sdl2.h b/include/ui/sd

[Qemu-devel] [PULL 1/2] gtk: use qemu_chr_alloc() to allocate CharDriverState

2016-02-02 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The gd_vc_handler() callback is using g_malloc0() to allocate the CharDriverState struct. As a result the logfd field is getting initialized to 0, instead of -1 when no logfile is requested. The result is that when running $ qemu-system-i386 -nodefaults -chardev vc,i

[Qemu-devel] [PULL 0/2] ui: gtk vc fix, adaptive sdl refresh.

2016-02-02 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-ui-20160202-1 for you to fetch changes up to 56bdd4b69aa10bec274b1e812685bcf44dcb0c72: sdl: shorten the GUI refresh interval when mouse or keyboard is active (2016-02-02 14:05:07 +0100) -

[Qemu-devel] [PULL v1 0/3] Misc fixes for crypto/ code

2016-02-02 Thread Daniel P. Berrange
The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: hw: Clean up includes (2016-01-29 15:07:25 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-next-2016-02-02-1 for you to fetch changes up to c0377a7cc6cb46aba295b744d2

[Qemu-devel] [PULL v1 3/3] crypto: ensure qcrypto_hash_digest_len is always defined

2016-02-02 Thread Daniel P. Berrange
The qcrypto_hash_digest_len method was accidentally inside a CONFIG_GNUTLS_HASH block, even though it doesn't depend on gnutls. Re-arrange it to be unconditionally defined. Reviewed-by: Fam Zheng Signed-off-by: Daniel P. Berrange --- crypto/hash.c | 30 +- 1 file cha

[Qemu-devel] [PULL v1 1/3] crypto: fix description of @errp parameter initialization

2016-02-02 Thread Daniel P. Berrange
The "Error **errp" parameters must be NULL initialized not uninitialized. Signed-off-by: Daniel P. Berrange --- include/crypto/cipher.h | 8 include/crypto/hash.h | 12 ++-- include/crypto/tlssession.h | 8 3 files changed, 14 insertions(+), 14 deletions(-)

[Qemu-devel] [PULL v1 2/3] crypto: register properties against the class instead of object

2016-02-02 Thread Daniel P. Berrange
This converts the tlscredsx509, tlscredsanon and secret objects to register their properties against the class rather than object. Signed-off-by: Daniel P. Berrange --- crypto/secret.c | 60 +++ crypto/tlscreds.c | 36 ++--

Re: [Qemu-devel] [libvirt] ARM KVM GICv3 Support

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 12:59, Andrew Jones wrote: > This actually doesn't matter for the v2 vs. v3 case. The gic-version property > doesn't exist at all for v2-only QEMU. Although maybe the gic-version property > should be reworked. Instead of gic-version=, we could > create > one boolean property

Re: [Qemu-devel] [PATCH 1/2] block: fix assert in qcow2_get_specific_info

2016-02-02 Thread Paolo Bonzini
On 20/01/2016 08:12, Denis V. Lunev wrote: > There is a possibility to hit assert qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The pro

[Qemu-devel] [PULL 2/2] ehci: update irq on reset

2016-02-02 Thread Gerd Hoffmann
After clearing the status register we also have to update the irq line status. Otherwise a irq which happends to be pending at reset time causes a interrupt storm. And the guest can't stop as the status register doesn't indicate any pending interrupt. Both NetBSD and FreeBSD hang on shutdown bec

[Qemu-devel] [PULL 0/2] usb: two ehci fixes.

2016-02-02 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20160202-1 for you to fetch changes up to 5a8660741a8aa19fbf8a5e8a2b3aac88664f4e66: ehci: update irq on reset (2016-02-02 14:11:01 +0100) usb: two

[Qemu-devel] [PULL 1/2] usb: check page select value while processing iTD

2016-02-02 Thread Gerd Hoffmann
From: Prasad J Pandit While processing isochronous transfer descriptors(iTD), the page select(PG) field value could lead to an OOB read access. Add check to avoid it. Reported-by: Qinghao Tang Signed-off-by: Prasad J Pandit Message-id: 1453233406-12165-1-git-send-email-ppan...@redhat.com Signe

[Qemu-devel] vl.c:main_loop() non-blocking TCG optimization still useful?

2016-02-02 Thread Stefan Hajnoczi
Hi Jan, In 2011 the following patch was merged to optimize I/O vs vcpu scheduling: commit c9f711a5d31e22dac932c1c01e9c0f97caff0988 Author: Jan Kiszka Date: Mon Aug 22 17:46:02 2011 +0200 Poll main loop after I/O events were received This was back in the days of CONFIG_IOTHREAD. Things ha

Re: [Qemu-devel] [PATCH 2/4] usb: add attached property

2016-02-02 Thread Markus Armbruster
Suggest to say usb: Add QOM property "attached" The quotes make more obvious that "attached" is a property name, not an adjective tacked to property. Gerd Hoffmann writes: > USB devices in attached state are visible to the guest. If I read the code correctly: * ->attached is true between

Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support

2016-02-02 Thread Markus Armbruster
Gerd Hoffmann writes: > This patch marks usb-bot as hot-pluggable device, makes attached > property settable and turns off auto-attach in case the device > was hotplugged. > > Hot-plugging a usb-bot device with one or more scsi devices can be > done this way now: > > (1) device-add usb-bot,id=f

  1   2   3   4   >