Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Denis V. Lunev
On 01/19/2016 09:11 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function

Re: [Qemu-devel] [PATCH v2 3/9] ipmi: replace *_MAXCMD defines

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:48 +0100 Cédric Le Goater wrote: > ARRAY_SIZE() is simple to use and removes the need to pre-define > the size of the command arrays. > > Signed-off-by: Cédric Le Goater > --- Much nicer ! Reviewed-by: Greg Kurz > hw/ipmi/ipmi_bmc_sim.c | 21 -

[Qemu-devel] [PATCH] net: walk through filters reversely if traffic is outgress

2016-01-22 Thread Li Zhijian
Previously, if the netdev has more than one filters, the ingress or outgress traffic pass the filter in the same order. this patch is to make the outgress pass the filter in a reverse order Signed-off-by: Wen Congyang Signed-off-by: Li Zhijian --- include/net/net.h | 4 +++- net/filter.c

Re: [Qemu-devel] [PATCH 2/2] net: netmap: avoid mmap() when ports use the same shared memory area

2016-01-22 Thread Vincenzo Maffione
No, you're right, nm_mmap() is not defined for all netmap versions. It will take a while for us to decide how to manage this. Would it be possible to go ahead with patch 1/2 only (I will reissue the patch series)? Cheers, Vincenzo 2016-01-14 4:25 GMT+01:00 Jason Wang : > > > On 01/08/2016 09:1

[Qemu-devel] [PATCH RFC 7/7] net/filter: prevent the default filter to be deleted

2016-01-22 Thread zhanghailiang
Signed-off-by: zhanghailiang --- net/filter.c | 8 1 file changed, 8 insertions(+) diff --git a/net/filter.c b/net/filter.c index a126a3b..4aafff0 100644 --- a/net/filter.c +++ b/net/filter.c @@ -323,11 +323,19 @@ static void netfilter_finalize(Object *obj) g_free(nf->netdev_id);

[Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-22 Thread zhanghailiang
This series is a prerequisite for COLO, here we add each netdev a default buffer filter, it is disabled by default, and has no side effect for delivering packets in net layer. Besides, patch 1 fixes the ouput information of 'info network' command for filter. zhanghailiang (7): net/filter: Fix t

[Qemu-devel] [PATCH RFC 2/7] net/filter: Add a 'status' property for filter object

2016-01-22 Thread zhanghailiang
With this property, users can control if this filter is 'enable' or 'disable'. The default behavior for filter is enabled. Signed-off-by: zhanghailiang --- include/net/filter.h | 1 + net/filter.c | 36 2 files changed, 37 insertions(+) diff --git a

[Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network'

2016-01-22 Thread zhanghailiang
The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not updated, because it got the old information through nf->info_str, it will not be updated while we change the value of netfilter's property. Here we split a the helper function

[Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets

2016-01-22 Thread zhanghailiang
If the filter is disabled, don't go through it. Signed-off-by: zhanghailiang --- include/net/filter.h | 5 + net/net.c| 4 2 files changed, 9 insertions(+) diff --git a/include/net/filter.h b/include/net/filter.h index 9ed5ec6..d797ee4 100644 --- a/include/net/filter.h +++

[Qemu-devel] [PATCH RFC 4/7] net/filter: Introduce a helper to add a filter to the netdev

2016-01-22 Thread zhanghailiang
Signed-off-by: zhanghailiang --- include/net/filter.h | 5 + net/filter.c | 63 2 files changed, 68 insertions(+) diff --git a/include/net/filter.h b/include/net/filter.h index d797ee4..c7bd8f9 100644 --- a/include/net/filter.h ++

[Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval

2016-01-22 Thread zhanghailiang
We may want to accept zero interval when VM FT solutions like MC or COLO use this filter to release packets on demand. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang --- net/filter-buffer.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-

[Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev

2016-01-22 Thread zhanghailiang
We add each netdev a default buffer filter, which the name is 'nop', and the default buffer filter is disabled, so it has no side effect for packets delivering in qemu net layer. The default buffer filter can be used by COLO or Micro-checkpoint, The reason we add the default filter is we hope to s

Re: [Qemu-devel] [PATCH 0/6] Some improvements and small fixes for migration

2016-01-22 Thread Hailiang Zhang
ping ? On 2016/1/15 11:37, zhanghailiang wrote: Patch 1 ~ patch 4 are picked from COLO and live memory snapshot series, They are just small improvements for migration codes and have been reviewed by Dave. Patch 5, 6 are small fixes for migration releated documention. Please review. zhanghaili

Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-22 Thread Hailiang Zhang
Cc: Dr. David Alan Gilbert On 2016/1/22 16:36, zhanghailiang wrote: This series is a prerequisite for COLO, here we add each netdev a default buffer filter, it is disabled by default, and has no side effect for delivering packets in net layer. Besides, patch 1 fixes the ouput information of 'i

Re: [Qemu-devel] [PATCH] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-01-22 Thread Laszlo Ersek
On 01/22/16 07:15, Jason Wang wrote: > > > On 01/22/2016 02:11 PM, Michael Tokarev wrote: >> 22.01.2016 06:09, Jason Wang wrote: >>> On 01/19/2016 09:17 PM, Laszlo Ersek wrote: The start_xmit() and e1000_receive_iov() functions implement DMA transfers iterating over a set of descriptors

Re: [Qemu-devel] [PATCH v2 03/13] block: Move block dirty bitmap code to separate files

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 09:11, Fam Zheng wrote: The only change is making bdrv_dirty_bitmap_truncate public. It is used in block.c. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block.c | 339 --- block/Makefile.objs | 2 +- b

[Qemu-devel] [PATCH v2] qom, qmp, hmp, qapi: create qom-type-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P. Berr

[Qemu-devel] [PATCH v3] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P. Berran

Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets

2016-01-22 Thread Wen Congyang
On 01/22/2016 04:36 PM, zhanghailiang wrote: > If the filter is disabled, don't go through it. > > Signed-off-by: zhanghailiang > --- > include/net/filter.h | 5 + > net/net.c| 4 > 2 files changed, 9 insertions(+) > > diff --git a/include/net/filter.h b/include/net/filter.

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-22 Thread Alberto Garcia
On Thu 21 Jan 2016 05:58:42 PM CET, Eric Blake wrote: In general, what do you do to make sure that the data in a new Quorum child is consistent with that of the rest of the array? >>> >>> Quorum can have more than one child when it starts. But we don't do >>> the similar check. So I don'

Re: [Qemu-devel] [PATCH v2 4/4] block/qapi: Emit tray_open only if there is a tray

2016-01-22 Thread Alberto Garcia
On Wed 20 Jan 2016 07:29:21 PM CET, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qapi.c | 2 +- > qapi/block-core.json | 4 ++-- > tests/qemu-iotests/067.out | 4 > 3 files changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH v3 0/3] target-arm: Add a few more S2 MMU input checks

2016-01-22 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds the inputsize > pamax check and also fixes the startlevel checks to apply to the 64bit translations. Comments welcome! Cheers, Edgar ChangeLog: v2 -> v3: * Document pamax arg to check_s2_startlevel v1 -> v2: * inputsize > pmax check only applies to AArch64

[Qemu-devel] [PATCH v3 1/3] target-arm: Apply S2 MMU startlevel table size check to AArch64

2016-01-22 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The S2 starting level table size check applies to both AArch32 and AArch64. Move it to common code. Reviewed-by: Alex Bennée Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 3/3] target-arm: Implement the S2 MMU inputsize > pamax check

2016-01-22 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Implement the inputsize > pamax check for Stage 2 translations. We have multiple choices for how to respond to errors and choose to fault. Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v3 2/3] target-arm: Make pamax an argument to check_s2_startlevel

2016-01-22 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make pamax an argument to check_s2_startlevel in preparation for future reuse. No functional change. Reviewed-by: Alex Bennée Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target

Re: [Qemu-devel] [PATCH v2 2/4] blockdev: Fix 'change' for slot devices

2016-01-22 Thread Alberto Garcia
On Wed 20 Jan 2016 07:29:19 PM CET, Max Reitz wrote: > @@ -2424,6 +2442,15 @@ static void qmp_blockdev_insert_anon_medium(const char > *device, > > blk_insert_bs(blk, bs); > > +if (!blk_dev_has_tray(blk)) { > +/* For tray-less devices, blockdev-close-tray is a no-op (or may no

Re: [Qemu-devel] [PATCH] linux-user: add option to intercept execve() syscalls

2016-01-22 Thread Petros Angelatos
>> diff --git a/linux-user/main.c b/linux-user/main.c >> index ee12035..5951279 100644 >> --- a/linux-user/main.c >> +++ b/linux-user/main.c >> @@ -79,6 +79,7 @@ static void usage(int exitcode); >> >> static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX; >> const char *qemu_uname_release;

Re: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base

2016-01-22 Thread Igor Mammedov
On Thu, 21 Jan 2016 12:37:51 +1100 David Gibson wrote: > The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that > it exists in the abstract address space of RAM regions. > > However, the actual usage of this field indicates that it is a concrete > physical address (it's passe

Re: [Qemu-devel] [PATCH v3] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 12:26:52PM +0300, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. > > Signed-off-by: Valentin Rakush > Cc: Luiz Capitulino >

Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote: > This series is a prerequisite for COLO, here we add each netdev > a default buffer filter, it is disabled by default, and has > no side effect for delivering packets in net layer. Why can't whatever is launching QEMU just setup filte

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Paolo Bonzini
On 24/12/2015 10:33, Andrey Smetanin wrote: > Lately tsc page was implemented but filled with empty > values. This patch setup tsc page scale and offset based > on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value. > > The valid tsc page drops HV_X64_MSR_TIME_REF_COUNT msr > reads count to

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Andrey Smetanin
On 01/22/2016 01:08 PM, Paolo Bonzini wrote: On 24/12/2015 10:33, Andrey Smetanin wrote: Lately tsc page was implemented but filled with empty values. This patch setup tsc page scale and offset based on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value. The valid tsc page drops HV_X64_

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: Implement the S2 MMU inputsize > pamax check

2016-01-22 Thread Alex Bennée
Edgar E. Iglesias writes: > From: "Edgar E. Iglesias" > > Implement the inputsize > pamax check for Stage 2 translations. > We have multiple choices for how to respond to errors and > choose to fault. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 16 > 1

Re: [Qemu-devel] [PATCH] linux-user: add option to intercept execve() syscalls

2016-01-22 Thread Laurent Vivier
Le 22/01/2016 11:01, Petros Angelatos a écrit : >>> diff --git a/linux-user/main.c b/linux-user/main.c >>> index ee12035..5951279 100644 >>> --- a/linux-user/main.c >>> +++ b/linux-user/main.c >>> @@ -79,6 +79,7 @@ static void usage(int exitcode); >>> >>> static const char *interp_prefix = CONFI

Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-22 Thread Hailiang Zhang
On 2016/1/22 18:07, Daniel P. Berrange wrote: On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote: This series is a prerequisite for COLO, here we add each netdev a default buffer filter, it is disabled by default, and has no side effect for delivering packets in net layer. Why can't

Re: [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 06:35:48PM +0800, Hailiang Zhang wrote: > On 2016/1/22 18:07, Daniel P. Berrange wrote: > >On Fri, Jan 22, 2016 at 04:36:44PM +0800, zhanghailiang wrote: > >>This series is a prerequisite for COLO, here we add each netdev > >>a default buffer filter, it is disabled by defaul

Re: [Qemu-devel] [Minios-devel] [PATCH v8 0/] Begin to disentangle libxenctrl and provide some stable libraries

2016-01-22 Thread Ian Campbell
On Tue, 2016-01-19 at 15:44 +, Ian Campbell wrote: > On Fri, 2016-01-15 at 13:22 +, Ian Campbell wrote: > >   > > Therefore needing attention from Ian and/or Wei are: > > > > tools/libs/foreignmemory: Mention restrictions on fork in docs. > > N tools/libs/evtchn: Use uint32_t for dom

Re: [Qemu-devel] [PATCH] linux-user: add option to intercept execve() syscalls

2016-01-22 Thread Peter Maydell
On 22 January 2016 at 10:33, Laurent Vivier wrote: > Le 22/01/2016 11:01, Petros Angelatos a écrit : >> This was my initial approach too, but argv[0] can be just the filename >> like "qemu-arm-static". And while I could add extra logic to look this >> up in the PATH, someone could run it from a co

Re: [Qemu-devel] [PATCH v2 4/9] ipmi: introduce a struct ipmi_sdr_compact

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:49 +0100 Cédric Le Goater wrote: > Currently, sdr attributes are identified using byte offsets and this > can be a bit confusing. > > This patch adds a struct ipmi_sdr_compact conforming to the IPMI specs > and replaces byte offsets with names. It also introduces and us

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-01-22 Thread Gerd Hoffmann
Hi, > > > I wonder whether we should just bite the bullet and ask management to > > > maintain the physical memory map for us, instead of trying to give us > > > hints. > > > > I doubt this simplified things, given the backward compatibility > > constrains we have. > > > > cheers, > > Gerd >

Re: [Qemu-devel] [PATCH v2 5/9] ipmi: fix SDR length value

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:50 +0100 Cédric Le Goater wrote: > The IPMI BMC simulator populates the SDR table with a set of initial > SDRs. The length of each SDR is taken from the record itself (byte 4) > which does not include the size of the header. But, the full length > (header + data) is requi

[Qemu-devel] [PATCH] seabios: fix submodule

2016-01-22 Thread Gerd Hoffmann
Commit "36f96c4 target-i386: Add support to migrate vcpu's TSC rate" updates roms/seabios, appearently by mistake. Revert this. Signed-off-by: Gerd Hoffmann --- roms/seabios | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/seabios b/roms/seabios index 33fbe13..01a84be 16

Re: [Qemu-devel] [PATCH] linux-user: add option to intercept execve() syscalls

2016-01-22 Thread Laurent Vivier
Le 22/01/2016 11:47, Peter Maydell a écrit : > On 22 January 2016 at 10:33, Laurent Vivier wrote: >> Le 22/01/2016 11:01, Petros Angelatos a écrit : >>> This was my initial approach too, but argv[0] can be just the filename >>> like "qemu-arm-static". And while I could add extra logic to look th

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Paolo Bonzini
On 22/01/2016 11:15, Andrey Smetanin wrote: >> >> - unless KVM can use a master clock, it is incorrect to set up the TSC >> page this way; the sequence needs to be 0x in that case > 0x is not an invalid value for tsc page, > see https://lkml.org/lkml/2015/11/2/655 oh, I see now.

Re: [Qemu-devel] [PATCH v2 6/9] ipmi: add get and set SENSOR_TYPE commands

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:51 +0100 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > Acked-by: Corey Minyard > --- Reviewed-by: Greg Kurz Just two nits below. > hw/ipmi/ipmi_bmc_sim.c | 45 - > 1 file changed, 44 insertions(+), 1 deleti

Re: [Qemu-devel] [PATCH v2 7/9] ipmi: add GET_SYS_RESTART_CAUSE chassis command

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:52 +0100 Cédric Le Goater wrote: > This is a simulator. Just return an unknown cause (0). > > Signed-off-by: Cédric Le Goater > Acked-by: Corey Minyard > --- Reviewed-by: Greg Kurz > hw/ipmi/ipmi_bmc_sim.c | 16 +++- > 1 file changed, 15 insertions(+),

Re: [Qemu-devel] [PATCH v2 4/9] ipmi: introduce a struct ipmi_sdr_compact

2016-01-22 Thread Cédric Le Goater
On 01/22/2016 11:49 AM, Greg Kurz wrote: > On Thu, 21 Jan 2016 18:18:49 +0100 > Cédric Le Goater wrote: > >> Currently, sdr attributes are identified using byte offsets and this >> can be a bit confusing. >> >> This patch adds a struct ipmi_sdr_compact conforming to the IPMI specs >> and replaces

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Andrey Smetanin
On 01/22/2016 02:02 PM, Paolo Bonzini wrote: On 22/01/2016 11:15, Andrey Smetanin wrote: - unless KVM can use a master clock, it is incorrect to set up the TSC page this way; the sequence needs to be 0x in that case 0x is not an invalid value for tsc page, see https://lkml.

Re: [Qemu-devel] [PATCH v2 6/9] ipmi: add get and set SENSOR_TYPE commands

2016-01-22 Thread Cédric Le Goater
On 01/22/2016 12:07 PM, Greg Kurz wrote: > On Thu, 21 Jan 2016 18:18:51 +0100 > Cédric Le Goater wrote: > >> Signed-off-by: Cédric Le Goater >> Acked-by: Corey Minyard >> --- > > Reviewed-by: Greg Kurz > > Just two nits below. > >> hw/ipmi/ipmi_bmc_sim.c | 45 ++

Re: [Qemu-devel] [PATCH v2 5/9] ipmi: fix SDR length value

2016-01-22 Thread Cédric Le Goater
On 01/22/2016 11:56 AM, Greg Kurz wrote: > On Thu, 21 Jan 2016 18:18:50 +0100 > Cédric Le Goater wrote: >> The IPMI BMC simulator populates the SDR table with a set of initial >> SDRs. The length of each SDR is taken from the record itself (byte 4) >> which does not include the size of the header.

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: Implement the S2 MMU inputsize > pamax check

2016-01-22 Thread Edgar E. Iglesias
On Fri, Jan 22, 2016 at 10:28:43AM +, Alex Bennée wrote: > > Edgar E. Iglesias writes: > > > From: "Edgar E. Iglesias" > > > > Implement the inputsize > pamax check for Stage 2 translations. > > We have multiple choices for how to respond to errors and > > choose to fault. > > > > Signed-of

Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()

2016-01-22 Thread Paolo Bonzini
On 21/01/2016 18:01, Stefano Stabellini wrote: > -XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg > 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n", > - j, > ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), > -

Re: [Qemu-devel] [PULL 12/17] qcow2: Implement .bdrv_inactivate

2016-01-22 Thread Paolo Bonzini
On 20/01/2016 17:25, Kevin Wolf wrote: > +ret = qcow2_cache_flush(bs, s->refcount_block_cache); > +if (ret) { > +result = ret; > +error_report("Failed to flush the refcount block cache: %s", > + strerror(-ret)); > +} > + > +if (result == 0) { >

Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:53 +0100 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > > Changes since v1: > - added ACPI to command names. > > hw/ipmi/ipmi_bmc_sim.c | 49 + > 1 file changed, 49 insertions(+) > > diff --git a/hw

[Qemu-devel] [PATCH] qemu-sockets: simplify error handling

2016-01-22 Thread Paolo Bonzini
Just go always through the err label. (Noticed because Coverity complains that peer is always non-NULL in the error cleanup code, but removing the "if" is arguably more prone to introducing the opposite bug in the future). Signed-off-by: Paolo Bonzini --- util/qemu-sockets.c | 6 +++--- 1 file

Re: [Qemu-devel] [PATCH v2 9/9] ipmi: add SET_SENSOR_READING command (tentative try)

2016-01-22 Thread Greg Kurz
On Thu, 21 Jan 2016 18:18:54 +0100 Cédric Le Goater wrote: > SET_SENSOR_READING is a complex IPMI command (IPMI spec : "35.17 Set > Sensor Reading And Event Status Command"). Here is a very minimum > framework fitting the Open PowerNV platform needs. This command is > used on this platform to set

Re: [Qemu-devel] [PATCH] qemu-sockets: simplify error handling

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 12:28:33PM +0100, Paolo Bonzini wrote: > Just go always through the err label. (Noticed because Coverity > complains that peer is always non-NULL in the error cleanup code, > but removing the "if" is arguably more prone to introducing the > opposite bug in the future). > >

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Andrey Smetanin
On 01/22/2016 02:02 PM, Paolo Bonzini wrote: On 22/01/2016 11:15, Andrey Smetanin wrote: - unless KVM can use a master clock, it is incorrect to set up the TSC page this way; the sequence needs to be 0x in that case 0x is not an invalid value for tsc page, see https://lkml.

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 09:11, Fam Zheng wrote: The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 51 include/block/dirty-bitmap.h | 9 2 files chan

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: Implement the S2 MMU inputsize > pamax check

2016-01-22 Thread Alex Bennée
Edgar E. Iglesias writes: > On Fri, Jan 22, 2016 at 10:28:43AM +, Alex Bennée wrote: >> >> Edgar E. Iglesias writes: >> >> > From: "Edgar E. Iglesias" >> > >> > Implement the inputsize > pamax check for Stage 2 translations. >> > We have multiple choices for how to respond to errors and >>

Re: [Qemu-devel] [PATCH v2 09/13] block: Add two dirty bitmap getters

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 09:11, Fam Zheng wrote: For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/dirty-bitmap.c | 10 ++ include/block/dirty-bitmap.h | 2 ++ 2 files changed, 12 insertions(+) diff --

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Paolo Bonzini
On 22/01/2016 12:31, Andrey Smetanin wrote: >> >> Sometimes the TSC is detected to be unstable and Linux switches to >> another clocksource. At least in that case you can get a write to the >> TSC page while the guest is running. > Sorry, now I got it, you mean host TSC is unstable and we should

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 09:11, Fam Zheng wrote: The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 51 include/block/dirty-bitmap.h | 9 2 files chan

Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands

2016-01-22 Thread Cédric Le Goater
On 01/22/2016 12:24 PM, Greg Kurz wrote: > On Thu, 21 Jan 2016 18:18:53 +0100 > Cédric Le Goater wrote: > >> Signed-off-by: Cédric Le Goater >> --- >> >> Changes since v1: >> - added ACPI to command names. >> >> hw/ipmi/ipmi_bmc_sim.c | 49 >> +

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

2016-01-22 Thread Andrey Smetanin
On 01/22/2016 02:53 PM, Paolo Bonzini wrote: On 22/01/2016 12:31, Andrey Smetanin wrote: Sometimes the TSC is detected to be unstable and Linux switches to another clocksource. At least in that case you can get a write to the TSC page while the guest is running. Sorry, now I got it, you m

Re: [Qemu-devel] [PATCH] seabios: fix submodule

2016-01-22 Thread Peter Maydell
On 22 January 2016 at 10:59, Gerd Hoffmann wrote: > Commit "36f96c4 target-i386: Add support to migrate vcpu's TSC rate" > updates roms/seabios, appearently by mistake. Revert this. > > Signed-off-by: Gerd Hoffmann > --- > roms/seabios | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 22.01.2016 14:58, Vladimir Sementsov-Ogievskiy wrote: On 20.01.2016 09:11, Fam Zheng wrote: The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 51

Re: [Qemu-devel] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work

2016-01-22 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 19:13, Vladimir Sementsov-Ogievskiy wrote: I'll try to rebase my series on this and run tests. Now failed because of iterators for meta bitmaps are unsupported, see answers to [PATCH v2 08/13]. Wait for v3. On 20.01.2016 09:11, Fam Zheng wrote: v2: Various changes addressing

[Qemu-devel] [PATCH 4/6] scripts/dump-guest-memory.py: Cleanup functions

2016-01-22 Thread Janosch Frank
Increase readability by adding newlines and comments, as well as removing wrong whitespaces and C style braces around conditionals and loops. Reviewed-by: Laszlo Ersek Signed-off-by: Janosch Frank --- scripts/dump-guest-memory.py | 75 +--- 1 file changed

[Qemu-devel] [PATCH 3/6] scripts/dump-guest-memory.py: Improve python 3 compatibility

2016-01-22 Thread Janosch Frank
This commit does not make the script python 3 compatible, it is a preparation that fixes the easy and common incompatibilities. Print is a function in python 3 and therefore needs braces around its arguments. Range does not cast a gdb.Value object to int in python 3, we have to do it ourselves.

[Qemu-devel] [PATCH 5/6] scripts/dump-guest-memory.py: Introduce multi-arch support

2016-01-22 Thread Janosch Frank
By modelling the ELF with ctypes we not only gain full python 3 support but can also create dumps for different architectures more easily. Tested-by: Andrew Jones Acked-by: Laszlo Ersek Signed-off-by: Janosch Frank --- scripts/dump-guest-memory.py | 486

[Qemu-devel] [PATCH 0/6] scripts/dump-guest-memory.py: Add multi-arch support

2016-01-22 Thread Janosch Frank
The dump guest memory script for extracting a Linux core from a qemu core is currently limited to amd64 and python 2. With this series we add support for python 3 (while maintaining python 2 support) and add the possibility to extract dumps from VMs with the most common architectures. Tested on X

[Qemu-devel] [PATCH 6/6] scripts/dump-guest-memory.py: Fix module docstring

2016-01-22 Thread Janosch Frank
The module docstring is changed into a multi-line comment to comply with pep 257. The comment about the docstring that gets used by gdb to print the help is moved to the location of the docstring. Signed-off-by: Janosch Frank --- scripts/dump-guest-memory.py | 35 ++-

[Qemu-devel] [PATCH 1/6] scripts/dump-guest-memory.py: Move constants to the top

2016-01-22 Thread Janosch Frank
The constants bloated the class definition and were therefore moved to the top. Reviewed-by: Laszlo Ersek Signed-off-by: Janosch Frank --- scripts/dump-guest-memory.py | 126 +-- 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/scripts/dump

[Qemu-devel] [PATCH 2/6] scripts/dump-guest-memory.py: Make methods functions

2016-01-22 Thread Janosch Frank
The functions dealing with qemu components rarely used parts of the class, so they were moved out of the class. As the uintptr_t variable is needed both within and outside the class, it was made a constant and moved to the top. Reviewed-by: Laszlo Ersek Signed-off-by: Janosch Frank --- scripts

[Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Valentin Rakush
This patch adds support for qom-type-prop-list command to list object class properties. A later patch will use this functionality to implement x86_64-cpu properties. Signed-off-by: Valentin Rakush Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Cc: Andreas Färber Cc: Daniel P. Berran

[Qemu-devel] [PATCH 03/10] s390x/sclp: add device to the sysbus in sclp_realize

2016-01-22 Thread Cornelia Huck
From: David Hildenbrand The init of a device should have no side effects. Therefore move registering of the event facility into the realize function, so multiple instances of the SCLP device can be created e.g. for introspection. Add some more detail as to why we have to add it to the sysbus at

[Qemu-devel] [PATCH 01/10] s390x/skeys: Fix instance and class size

2016-01-22 Thread Cornelia Huck
From: Christian Borntraeger fix a typo that messes up instance and class size. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-skeys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-skeys.c

[Qemu-devel] [PATCH 00/10] Next round of s390x patches

2016-01-22 Thread Cornelia Huck
Hi, here's the next round of s390x patches. Mostly bugfixes and small improvements; and the gdb target.xml patch. Want to send a pullreq next week. Bo Tu (2): watchdog: introduction of get_watchdog_action watchdog/diag288: don't reset for action=none|debug|pause Christian Borntraeger (2):

[Qemu-devel] [PATCH 06/10] watchdog: introduction of get_watchdog_action

2016-01-22 Thread Cornelia Huck
From: Bo Tu Add get_watchdog_action(void) to allow access to the configured action. Reviewed-by: David Hildenbrand Signed-off-by: Bo Tu Signed-off-by: Cornelia Huck --- hw/watchdog/watchdog.c| 14 +- include/sysemu/watchdog.h | 10 ++ 2 files changed, 15 insertions(+)

[Qemu-devel] [PATCH 05/10] s390x: fix generation of event information crw

2016-01-22 Thread Cornelia Huck
From: Song Shan Gong Only one channel report word (crw) may be pending if there is event-information pending. This patch introduces a bool-type field 'sei_pending' for the channel subsystem, which indicates whether there are pending events. It is set when event information is made pending and th

[Qemu-devel] [PATCH 02/10] s390x/machine: make addon register fields static

2016-01-22 Thread Cornelia Huck
From: Christian Borntraeger No need to have them as global symbol. Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- target-s390x/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-s390x/machine.c b/target-s390

[Qemu-devel] [PATCH 04/10] s390x/ioinst: set type and len for SEI response

2016-01-22 Thread Cornelia Huck
From: Pierre Morel If no event information is pending, the return code is set to 0x0005 and the length of the response is set to 8 bytes. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Reviewed-by: Song Shan Gong Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck --- target-s39

[Qemu-devel] [PATCH v2 0/6] virtio-gpu: fixes and spice preparation

2016-01-22 Thread Gerd Hoffmann
Hi, This patch series brings some minor opengl bug fixes and also some virtio-gpu preparations for spice support. v2: address review comments from Marc-André Lureau (mostly patch #4) Gerd Hoffmann (6): zap qemu_egl_has_ext in include/ui/egl-helpers.h console: block rendering until client i

[Qemu-devel] [PATCH v2 1/6] zap qemu_egl_has_ext in include/ui/egl-helpers.h

2016-01-22 Thread Gerd Hoffmann
Drop leftover prototype which sneaked in by mistake Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/egl-helpers.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h index 5ad5dc3..8c84398 100644 --- a/include/ui/egl-

[Qemu-devel] [PATCH 09/10] gdb: provide the name of the architecture in the target.xml

2016-01-22 Thread Cornelia Huck
From: David Hildenbrand This patch provides the name of the architecture in the target.xml if available. This allows the remote gdb to detect the target architecture on its own - so there is no need to specify it manually (e.g. if gdb is started without a binary) using "set arch *arch_name*". T

[Qemu-devel] [PATCH 10/10] s390x: s390_cpu_get_phys_page_debug has to return -1

2016-01-22 Thread Cornelia Huck
From: David Hildenbrand If translation fails, we have to return -1. For now, we would simply return the value last stored to raddr (if any). This way, reading invalid memory via gdb will return values, although it shouldn't. Reviewed-by: Christian Borntraeger Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH 08/10] s390x/css: fix control flags during csch

2016-01-22 Thread Cornelia Huck
From: Halil Pasic >From the beginning, css support contained an error in csch handling: instead of setting the clear bit in the function control bits twice, we need to set the clear pending bit in the activity control bits. Let's fix this. Cc: qemu-sta...@nongnu.org Reviewed-by: Cornelia Huck S

[Qemu-devel] [PATCH v2 6/6] virtio-gpu: block any rendering until client (ui) is done

2016-01-22 Thread Gerd Hoffmann
Wire up gl_block callback, so ui code can request to stop virtio-gpu rendering. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 5 + hw/display/virtio-gpu.c| 11 +++ hw/display/virtio-vga.c| 10 ++ include/hw/virtio/virtio-gpu.h | 1 + 4 fi

[Qemu-devel] [PATCH v2 3/6] virtio-gpu: fix memory leak in error path

2016-01-22 Thread Gerd Hoffmann
Found by Coverity Scan, buf not freed on error. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 28dccfd..d2af327 100644

[Qemu-devel] [PATCH 07/10] watchdog/diag288: don't reset for action=none|debug|pause

2016-01-22 Thread Cornelia Huck
From: Bo Tu If the watchdog expires and the guest is not notified (NONE, DEBUG, PAUSE), we must not reset the watchdog device, otherwise watchdog_ping() and watchdog_stop() will fail when triggered by the guest. This reset behavior matches to the z/VM behavior when a custom command is to be execu

[Qemu-devel] [PATCH v2 5/6] virtio-gpu: add support to enable/disable command processing

2016-01-22 Thread Gerd Hoffmann
So we can stop rendering for a while in case we have to. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-3d.c | 3 ++- hw/display/virtio-gpu.c| 5 - include/hw/virtio/virtio-gpu.h | 2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) dif

[Qemu-devel] [PATCH v2 2/6] console: block rendering until client is done

2016-01-22 Thread Gerd Hoffmann
Allow gl user interfaces to block display device gl rendering. The ui code might want to do that in case it takes a little longer to bring things to screen, for example because we'll hand over a dma-buf to another process (spice will do that). Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André

[Qemu-devel] [PATCH v2 4/6] virtio-gpu: maintain command queue

2016-01-22 Thread Gerd Hoffmann
We'll go take out the commands we receive out of the virt queue and put them into a linked list, to decouple virtio queue handling from actual command processing. Also move cmd processing to new virtio_gpu_handle_ctrl func, so we can easily kick it from different places. Signed-off-by: Gerd Hoffm

Re: [Qemu-devel] [PATCH 0/6] scripts/dump-guest-memory.py: Add multi-arch support

2016-01-22 Thread Paolo Bonzini
On 22/01/2016 13:08, Janosch Frank wrote: > The dump guest memory script for extracting a Linux core from a qemu > core is currently limited to amd64 and python 2. > > With this series we add support for python 3 (while maintaining python > 2 support) and add the possibility to extract dumps fro

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: Implement the S2 MMU inputsize > pamax check

2016-01-22 Thread Edgar E. Iglesias
On Fri, Jan 22, 2016 at 11:45:57AM +, Alex Bennée wrote: > > Edgar E. Iglesias writes: > > > On Fri, Jan 22, 2016 at 10:28:43AM +, Alex Bennée wrote: > >> > >> Edgar E. Iglesias writes: > >> > >> > From: "Edgar E. Iglesias" > >> > > >> > Implement the inputsize > pamax check for Stage

Re: [Qemu-devel] [PATCH v2 2/9] ipmi: replace goto by a return statement

2016-01-22 Thread Corey Minyard
On 01/21/2016 11:18 AM, Cédric Le Goater wrote: Each routine using the IPMI_ADD_RSP_DATA, IPMI_CHECK_CMD_LEN or IPMI_CHECK_RESERVATION macros needs to define a goto label 'out' to handle hidden errors. Using directly a return statement as the same Using a return statement directly has the same..

Re: [Qemu-devel] [PATCH v9 21/37] qapi: Document visitor interfaces, add assertions

2016-01-22 Thread Markus Armbruster
Eric Blake writes: > On 01/21/2016 01:08 PM, Markus Armbruster wrote: >> All right, this one's a bear. Not because the patch is bad, but because >> what it tries to do is bloody difficult. > > Is there any reasonable split (such as adding some of the assertions in > earlier patches) that would m

Re: [Qemu-devel] [PATCH v4] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 03:15:55PM +0300, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. > > Signed-off-by: Valentin Rakush > Cc: Luiz Capitulino >

Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands

2016-01-22 Thread Corey Minyard
On 01/21/2016 11:18 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Changes since v1: - added ACPI to command names. Thanks. Acked-by: Corey Minyard hw/ipmi/ipmi_bmc_sim.c | 49 + 1 file changed, 49 insertions(+) dif

  1   2   3   >