[Qemu-devel] [PATCH 1/1] vl: change QEMU state machine for system reset

2016-01-19 Thread Denis V. Lunev
This patch implements proposal from Paolo to handle system reset when the guest is not running. "After a reset, main_loop_should_exit should actually transition to VM_STATE_PRELAUNCH (*not* RUN_STATE_PAUSED) for *all* states except RUN_STATE_INMIGRATE, RUN_STATE_SAVE_VM (which I think cannot happe

Re: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices

2016-01-19 Thread Marcel Apfelbaum
On 01/18/2016 08:16 PM, Laszlo Ersek wrote: On 01/18/16 19:08, Peter Maydell wrote: On 18 January 2016 at 15:27, Marcel Apfelbaum wrote: PCI devices can't be plugged directly into PCI extra root bridges because their resources can't be computed by firmware before the ACPI tables are loaded. S

Re: [Qemu-devel] [RFC PATCH v2 00/10] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-01-19 Thread Dmitry Fleytman
> On 19 Jan 2016, at 05:48 AM, Jason Wang wrote: > > > > On 01/19/2016 01:35 AM, Leonid Bloch wrote: >> Hello All, >> >> This series is the latest code of the e1000e device emulation being >> developed. >> >> Changes since v1: >> >> 1. Added support for all the device features: >> - Inter

Re: [Qemu-devel] Status of my hacks on the MTTCG WIP branch

2016-01-19 Thread alvise rigo
On Mon, Jan 18, 2016 at 8:09 PM, Alex Bennée wrote: > > > Alex Bennée writes: > > > alvise rigo writes: > > > >> On Fri, Jan 15, 2016 at 4:25 PM, Alex Bennée > >> wrote: > >>> > >>> alvise rigo writes: > >>> > On Fri, Jan 15, 2016 at 3:51 PM, Alex Bennée > wrote: > > > > a

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2016-01-19 Thread Hailiang Zhang
Hi Jason, Thanks for your review. On 2016/1/19 11:19, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: We add each netdev (except vhost-net) a default filter-buffer, which will be used for COLO or Micro-checkpoint to buffer VM's packets. The name of default filter-buffer is 'no

Re: [Qemu-devel] [PATCH COLO-Frame v13 35/39] filter-buffer: Accept zero interval

2016-01-19 Thread Hailiang Zhang
On 2016/1/19 11:21, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: For default buffer filter, its 'interval' value is zero, so here we should accept zero interval. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang Cc: Jason Wang --- v12: - Add Reviewed-by tag v11: - A

Re: [Qemu-devel] [PATCH COLO-Frame v13 36/39] filter-buffer: Introduce a helper function to enable/disable default filter

2016-01-19 Thread Hailiang Zhang
On 2016/1/19 11:35, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: The default buffer filter doesn't buffer packets in default, but we need to buffer packets for COLO or Micro-checkpoint, Here we add a helper function to enable/disable filter's buffer capability. Signed-off-by

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 07:27, Markus Armbruster wrote: > Peter Maydell writes: > >> On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >>> I think even guest-agent code & tests could include it in order to >>> get clean includes, even if they don't use any of the QEMU functions >>> defined in

Re: [Qemu-devel] [PATCH v1 1/1] arm_gic: Update ID registers based on revision

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 01:33, Alistair Francis wrote: > Update the GIC ID registers (registers above 0xfe0) based on the GIC > revision instead of using the sames values for all GIC implementations. > > Signed-off-by: Alistair Francis > Tested-by: Sören Brinkmann > --- > > hw/intc/arm_gic.c | 29

Re: [Qemu-devel] [RE-RESEND PATCH] pci: Adjust PCI config limit based on bus topology

2016-01-19 Thread Marcel Apfelbaum
On 01/19/2016 01:06 AM, Alex Williamson wrote: A conventional PCI bus does not support config space accesses above the standard 256 byte configuration space. PCIe-to-PCI bridges are not permitted to forward transactions if the extended register address field is non-zero and must handle it as an

Re: [Qemu-devel] [PATCH 1/1] nvdimm: disable balloon

2016-01-19 Thread Xiao Guangrong
On 01/18/2016 07:42 PM, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy NVDIMM for now is planned to use as a backing store for DAX filesystem in the guest and thus this memory is excluded from guest memory management and LRUs. In this case libvirt running QEMU along with configured

Re: [Qemu-devel] [PATCH v8 00/35] qapi visitor cleanups (post-introspection cleanups subset E)

2016-01-19 Thread Markus Armbruster
Eric Blake writes: > Based on qemu.git master. Pending prerequisites: > + Not a strong dependency, but for qapi-tests to consistently pass, > I needed a race fixed: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html > > Also available as a tag at this location: > git fetch git:

Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification

2016-01-19 Thread Vladimir Sementsov-Ogievskiy
On 19.01.2016 00:16, Eric Blake wrote: preserving semantics of those extra_data bytes). We have enough room for future extension, and that's good e Ok, so, what should go to the spec? Current wording is ok? Just delete "Type-specific": + +20 - 23:extra_data_size +

Re: [Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

2016-01-19 Thread Chen Fan
On 01/17/2016 02:34 AM, Michael S. Tsirkin wrote: On Tue, Jan 12, 2016 at 10:43:01AM +0800, Cao jin wrote: From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually user want to know what error oc

Re: [Qemu-devel] [PATCH v16 13/14] vfio-pci: pass the aer error to guest

2016-01-19 Thread Chen Fan
On 01/18/2016 06:45 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting M

Re: [Qemu-devel] [PATCH v3 ] doc: Introduce coding style for errors

2016-01-19 Thread Thomas Huth
On 18.01.2016 21:26, Eric Blake wrote: > On 01/15/2016 06:54 AM, Lluís Vilanova wrote: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 36 >> 1 file changed, 36 insertions(+) ... >> +Func

Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-19 Thread Daniel P. Berrange
On Mon, Jan 18, 2016 at 12:48:56PM -0700, Eric Blake wrote: > On 01/14/2016 05:16 AM, Daniel P. Berrange wrote: > > >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use > >>> +# > >> > >> Well, the only reason to use it would be to read data off an old > >> insecurely-encrypted qcow

Re: [Qemu-devel] [PATCH v16 05/14] vfio: add pcie extanded capability support

2016-01-19 Thread Chen Fan
On 01/17/2016 09:22 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Hi, I noticed a type in the subject, extanded -> extended For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid config space broken, we introduce a

Re: [Qemu-devel] [PATCH v4 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Markus Armbruster
Fam Zheng writes: > v4: Add Max's rev-by in both patches, while fixing the "maxs" typo. > > v3: Address comments: > - Add test for large value; [Berto] > - Fix typos "negative" & "caught"; [Eric, Berto] > - Use "LL" suffix to the upper limit constant. [Berto] > > v2: Check the value r

Re: [Qemu-devel] [PATCH v16 07/14] vfio: add aer support for vfio device

2016-01-19 Thread Chen Fan
On 01/18/2016 05:12 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 8

Re: [Qemu-devel] [PATCHv2 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

2016-01-19 Thread Alexey Kardashevskiy
On 01/19/2016 03:30 PM, David Gibson wrote: rtas_st_buffer() appears in spapr.h as though it were a widely used helper, but in fact it is only used for saving data in a format used by rtas_ibm_get_system_parameter(). This changes it to a local helper more specifically for that function. While w

[Qemu-devel] cgroup blkio weight has no effect for qemu

2016-01-19 Thread 陈博
Hi folks, Could you please enlighten me about how to achieve proportional IO sharing by using cgroup, instead of qemu? My qemu config is like: -drive file=$DISKFILe,if=none,format=qcow2,cache=none,aio=native Test command inside vm is like: dd if=/dev/vdc of=/dev/null iflag=direct Cgroup blki

[Qemu-devel] cgroup blkio weight has no effect on qemu

2016-01-19 Thread 陈博
Hi folks, Could you enlighten me about how to achieve proportional IO sharing by using cgroup, instead of qemu? My qemu config is like: -drive file=$DISKFILe,if=none,format=qcow2,cache=none,aio=native Test command inside vm is like: dd if=/dev/vdc of=/dev/null iflag=direct Cgroup blkio weigh

Re: [Qemu-devel] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 13:25:19 +1100 David Gibson wrote: > On Fri, Jan 15, 2016 at 04:00:38PM +0100, Greg Kurz wrote: > > Altivec registers are 128-bit wide. They are stored in memory as two > > 64-bit values that must be byteswapped when the guest is little-endian. > > Let's reuse the ppc_maybe_bs

Re: [Qemu-devel] [PATCH v16 08/14] vfio: add check host bus reset is support or not

2016-01-19 Thread Chen Fan
On 01/18/2016 06:32 PM, Marcel Apfelbaum wrote: On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Hi, I think the subject should be rephrased. when init vfio devices done, we should test all the devices supported aer whether conflict with others. For each one, get the hot reset info

Re: [Qemu-devel] [PATCH v16 10/14] pci: introduce pci bus pre reset

2016-01-19 Thread Chen Fan
On 01/15/2016 04:36 AM, Alex Williamson wrote: On Tue, 2016-01-12 at 10:43 +0800, Cao jin wrote: From: Chen Fan avoid repeat bus reset, here introduce a sequence ID for each time bus hot reset, so each vfio device could know whether they've already been reset for that sequence ID. Signed-off

Re: [Qemu-devel] [PATCH] hw/misc: slavepci_passthru driver

2016-01-19 Thread Francesco Zuliani
Hi Alex, On 01/18/2016 05:41 PM, Alex Williamson wrote: On Mon, 2016-01-18 at 10:16 -0500, Marc-André Lureau wrote: Hi - Original Message - Hi there, I'd like to submit this new pci driver ( hw/misc )for inclusion, if you think it could be useful to other as well as ourself. The d

Re: [Qemu-devel] [PATCH 2/2] migration/virtio: Remove simple .get/.put use

2016-01-19 Thread Dr. David Alan Gilbert
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote: > Dear David, > > "Dr. David Alan Gilbert" writes: > > > +/* a variable length array (i.e. _type *_field) but we know the > > + * length > > + */ > > +#define VMSTATE_STRUCT_VARRAY_POINTER_KNOWN(_field, _state, _num, > > _version, _vmsd, _type) {

[Qemu-devel] [PATCH v3 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible

2016-01-19 Thread Daniel P. Berrange
This series of patches expands the syntax of the qemu-img, qemu-nbd and qemu-io commands to make them more flexible. v0: http://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html v2: https://lists.gnu.org/archiv

[Qemu-devel] [PATCH v3 01/10] qom: add helpers for UserCreatable object types

2016-01-19 Thread Daniel P. Berrange
The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). The HMP and main emulator startup code also share further logic that extracts the qom-type & id values from a qdict. We soon need to use

[Qemu-devel] [PATCH v3 02/10] qemu-img: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-img via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-img info --object

Re: [Qemu-devel] [RFC PATCH v2 02/10] pci: Introduce function for PCI PM capability creation

2016-01-19 Thread Marcel Apfelbaum
On 01/18/2016 07:35 PM, Leonid Bloch wrote: From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pci.c | 21 + include/hw/pci/pci.h | 2 ++ include/hw/pci/pci_regs.h | 1 + 3 files changed, 24 insertions(+) d

[Qemu-devel] [PATCH v3 04/10] qemu-io: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-io via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-io --object secret

[Qemu-devel] [PATCH v3 06/10] qemu-nbd: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-nbd allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-nbd https://127.0.0.1/images/centos7.iso qemu-nbd /home/berrange/demo.qcow2 This adds a --image-opts arg that i

[Qemu-devel] [PATCH v3 03/10] qemu-nbd: add support for --object command line arg

2016-01-19 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-nbd via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-nbd --object secr

[Qemu-devel] [PATCH v3 07/10] qemu-img: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-img allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --image-opts arg that indicates that the positional file

[Qemu-devel] [PATCH v3 10/10] qemu-io: use no_argument/required_argument constants

2016-01-19 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-io.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) di

[Qemu-devel] [PATCH v3 05/10] qemu-io: allow specifying image as a set of options args

2016-01-19 Thread Daniel P. Berrange
Currently qemu-io allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-io https://127.0.0.1/images/centos7.iso qemu-io /home/berrange/demo.qcow2 This adds a --image-opts arg that indicate

[Qemu-devel] [PATCH v3 08/10] qemu-nbd: don't overlap long option values with short options

2016-01-19 Thread Daniel P. Berrange
When defining values for long options, the normal practice is to start numbering from 256, to avoid overlap with the range of valid values for short options. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > The functions for migrating the hash page table on pseries machine type > > (htab_save_setup() and htab_load()) can report some errors with an > > explicit fprintf() before returning an appropriate err

Re: [Qemu-devel] usb-storage assertions

2016-01-19 Thread Andrey Korolyov
On Tue, Jan 19, 2016 at 10:13 AM, Gerd Hoffmann wrote: > On Di, 2016-01-19 at 02:49 +0300, Andrey Korolyov wrote: >> On Mon, Jan 18, 2016 at 4:55 PM, Gerd Hoffmann wrote: >> > Hi, >> > >> >> > ok. Had no trouble with freebsd, will go fetch netbsd images. What >> >> > arch is this? i386? x86

Re: [Qemu-devel] [RFC 0/3] Draft implementation of HPT resizing (qemu side)

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 01:18:17PM +0530, Bharata B Rao wrote: > On Mon, Jan 18, 2016 at 04:44:38PM +1100, David Gibson wrote: > > Here is a draft qemu implementation of my proposed PAPR extension for > > allowing runtime resizing of a KVM/ppc64 guest's hash page table. > > That in turn will allow

[Qemu-devel] [PATCH v3 09/10] qemu-nbd: use no_argument/required_argument constants

2016-01-19 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 47 --- 1 file changed, 24 insertions(+), 2

[Qemu-devel] [PATCH v4 3/4] char: don't assume telnet initialization will not block

2016-01-19 Thread Daniel P. Berrange
The current code for doing telnet initialization is writing to a socket without checking the return status. While it is highly unlikely to be a problem when writing to a bare socket, as the buffers are large enough to prevent blocking, this cannot be assumed safe with TLS sockets. So write the teln

[Qemu-devel] [PATCH v4 4/4] char: introduce support for TLS encrypted TCP chardev backend

2016-01-19 Thread Daniel P. Berrange
This integrates support for QIOChannelTLS object in the TCP chardev backend. If the 'tls-creds=NAME' option is passed with the '-chardev tcp' argument, then it will setup the chardev such that the client is required to establish a TLS handshake when connecting. There is no support for checking the

[Qemu-devel] [PATCH v4 0/4] Convert chardevs to QIOChannel & add TLS support

2016-01-19 Thread Daniel P. Berrange
This is an update of patches previously shown in an RFC posting RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04222.html v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03823.html v3: ht

[Qemu-devel] [PATCH v4 1/4] char: remove fixed length filename allocation

2016-01-19 Thread Daniel P. Berrange
A variety of places were snprintf()ing into a fixed length filename buffer. Some of the buffers were stack allocated, while another was heap allocated with g_malloc(). Switch them all to heap allocated using g_strdup_printf() avoiding arbitrary length restrictions. This also facilitates later patc

[Qemu-devel] [PATCH v4 2/4] char: convert from GIOChannel to QIOChannel

2016-01-19 Thread Daniel P. Berrange
In preparation for introducing TLS support to the TCP chardev backend, convert existing chardev code from using GIOChannel to QIOChannel. This simplifies the chardev code by removing most of the OS platform conditional code for dealing with file descriptor passing. Signed-off-by: Daniel P. Berrang

Re: [Qemu-devel] [PATCH 1/2] 9pfs: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 17:35:25 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Signed-off-by: Greg Kurz > > --- I agree to all your suggestions. Thanks ! > > hw/9pfs/9p-handle.c |5 +++-- > > hw/9pfs/9p-local.c | 15 --- > > hw/9pfs/9p-proxy.c | 12 ++--

Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
On Mon, 18 Jan 2016 17:39:28 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Hi, > > > > This series moves all the 9pfs/fsdev code to use error_report(), with the > > notable exception of virtfs-proxy-helper, which doesn't need it. > > > > Markus, > > > > Should this patches go through

Re: [Qemu-devel] usb-storage assertions

2016-01-19 Thread Gerd Hoffmann
Hi, > Probably not enough with driver subsystem to point even at the obvious > issue in the EHCI driver. I`d start with slowing down an emulated CPU > 10...100 times via its thread cg, leaving emulator code hanging with > enough CPU cycles and check if the issue is still here. If roots of > the

[Qemu-devel] [PATCH] ehci: update irq on reset

2016-01-19 Thread Gerd Hoffmann
After clearing the status register we also have to update the irq line status. Otherwise a irq which happends to be pending at reset time causes a interrupt storm. And the guest can't stop as the status register doesn't indicate any pending interrupt. Both NetBSD and FreeBSD hang on shutdown bec

Re: [Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 05:51, John Snow wrote: > +/* Only RESET is allowed to an ATAPI device while BSY and/or DRQ are > set. */ > +if (s->status & (BUSY_STAT|DRQ_STAT)) { > +if (!(val == WIN_DEVICE_RESET) && (s->drive_kind == IDE_CD)) { I was going to complain about Pascal-ish parenthes

[Qemu-devel] [PATCH] hw/arm/virt: Add always-on property to the virt board timer

2016-01-19 Thread Christoffer Dall
The virt board has an arch timer, which is always on. Emit the "always-on" property to indicate to Linux that it can switch off the periodic timer and reduces the amount of interrupts injected into a guest. Signed-off-by: Christoffer Dall --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Daniel P. Berrange
When nbd_negotiate() fails, nbd_co_client_start() is directly calling client->close(). This eventually ends up calling nbd_client_put(), which does an assert(client->closing). Unfortunately we have not set the 'closing' flag, so the code now aborts. This bug was accidentally introduced in commit

Re: [Qemu-devel] [PATCH 3/5] ide: move buffered DMA cancel to core

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 05:51, John Snow wrote: > Buffered DMA cancellation was added to ATAPI devices and implemented > for the BMDMA HBA. Move the code over to common IDE code and allow > it to be used for any HBA. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 45 +++

[Qemu-devel] [PATCH] cpu: cpu_save/cpu_load is no more

2016-01-19 Thread Paolo Bonzini
Everything has been converted to vmstate. Signed-off-by: Paolo Bonzini --- exec.c| 6 -- include/qemu-common.h | 6 -- 2 files changed, 12 deletions(-) diff --git a/exec.c b/exec.c index 0d8ca3f..35705a1 100644 --- a/exec.c +++ b/exec.c @@ -628,12 +628,6 @@ void cpu_exec

Re: [Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 12:50, Daniel P. Berrange wrote: > When nbd_negotiate() fails, nbd_co_client_start() is > directly calling client->close(). This eventually > ends up calling nbd_client_put(), which does an > assert(client->closing). Unfortunately we have not > set the 'closing' flag, so the code no

Re: [Qemu-devel] [PATCH 2/2] migration/virtio: Remove simple .get/.put use

2016-01-19 Thread Dr. David Alan Gilbert
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote: > Dear David, > > "Dr. David Alan Gilbert" writes: > > > Can you try this and let me know if it fixes it for you; I've > > still not managed to persuade x86-64 to fail. > > With Conny's hint re. virtio-1 (thanks!) I managed to make it fail on >

Re: [Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

2016-01-19 Thread Greg Kurz
On Tue, 19 Jan 2016 11:55:10 +1100 David Gibson wrote: > On Mon, Jan 18, 2016 at 09:51:56AM +0100, Greg Kurz wrote: > > On Mon, 18 Jan 2016 13:16:44 +1100 > > David Gibson wrote: > > > > > On Fri, Jan 15, 2016 at 04:00:12PM +0100, Greg Kurz wrote: > > > > On VSX capable CPUs, the 32 FP regi

Re: [Qemu-devel] [PATCH 01/10] virtio: move VirtQueueElement at the beginning of the structs

2016-01-19 Thread Cornelia Huck
On Fri, 15 Jan 2016 13:41:49 +0100 Paolo Bonzini wrote: > The next patch will make virtqueue_pop/vring_pop allocate memory for a s/will make/will make it possible for/ ? I had to spend some time grepping through the code to find that blk and scsi (and gpu, which already had elem at the beginni

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-19 Thread Gerd Hoffmann
Hi, > > > +if (fw_cfg_dma_enabled(fw_cfg)) { > > > +option_rom[nb_option_roms].name = "linuxboot_dma.bin"; > > > +option_rom[nb_option_roms].bootindex = 0; > > > +} else { > > > +option_rom[nb_option_roms].name = "linuxboot.bin"; > > > +option_rom[nb_optio

Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Markus Armbruster
Greg Kurz writes: > On Mon, 18 Jan 2016 17:39:28 +0100 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > Hi, >> > >> > This series moves all the 9pfs/fsdev code to use error_report(), with the >> > notable exception of virtfs-proxy-helper, which doesn't need it. >> > >> > Markus, >> >

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread Markus Armbruster
David Gibson writes: > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: >> David Gibson writes: >> >> > The functions for migrating the hash page table on pseries machine type >> > (htab_save_setup() and htab_load()) can report some errors with an >> > explicit fprintf() befor

Re: [Qemu-devel] [PATCH 02/10] virtio: move allocation to virtqueue_pop/vring_pop

2016-01-19 Thread Cornelia Huck
On Fri, 15 Jan 2016 13:41:50 +0100 Paolo Bonzini wrote: > The return code of virtqueue_pop/vring_pop is unused except to check for > errors or 0. We can thus easily move allocation inside the functions > and just return a pointer to the VirtQueueElement. Like this change. > > The advantage is

Re: [Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr

2016-01-19 Thread Markus Armbruster
David Gibson writes: > Another spin of my patches to clean up a bunch of error reporting in > the pseries machine type and target-ppc code, to better use the error > API. > > Once reviewed, I hope to merge this into ppc-for-2.6 shortly. Thanks for helping with error cleanup. > Changes in v4: >

Re: [Qemu-devel] [PATCH 03/10] virtio: introduce qemu_get/put_virtqueue_element

2016-01-19 Thread Cornelia Huck
On Fri, 15 Jan 2016 13:41:51 +0100 Paolo Bonzini wrote: > Move allocation to virtio functions also when loading/saving a > VirtQueueElement. This will also let the load/save functions > keep backwards compatibility when the VirtQueueElement layout > is changed. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add always-on property to the virt board timer

2016-01-19 Thread Andrew Jones
On Tue, Jan 19, 2016 at 12:49:18PM +0100, Christoffer Dall wrote: > The virt board has an arch timer, which is always on. Emit the > "always-on" property to indicate to Linux that it can switch off the > periodic timer and reduces the amount of interrupts injected into a > guest. > > Signed-off-b

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-01-19 Thread Eduardo Habkost
On Fri, Jan 08, 2016 at 01:58:03PM +0100, Gerd Hoffmann wrote: > This patch extends the functionality of the max-ram-below-4g option > to also allow increasing lowmem. Use case: Give as much memory as > possible to legacy non-PAE guests. > > While being at it also rework the lowmem calculation lo

Re: [Qemu-devel] [PATCH 04/10] virtio: introduce virtqueue_alloc_element

2016-01-19 Thread Cornelia Huck
On Fri, 15 Jan 2016 13:41:52 +0100 Paolo Bonzini wrote: > Allocate the arrays for in_addr/out_addr/in_sg/out_sg outside the > VirtQueueElement. For now, virtqueue_pop and vring_pop keep > allocating a very large VirtQueueElement. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio/dataplane/vr

Re: [Qemu-devel] [PATCH] hw/arm/virt: Add always-on property to the virt board timer

2016-01-19 Thread Christoffer Dall
On Tue, Jan 19, 2016 at 01:37:16PM +0100, Andrew Jones wrote: > On Tue, Jan 19, 2016 at 12:49:18PM +0100, Christoffer Dall wrote: > > The virt board has an arch timer, which is always on. Emit the > > "always-on" property to indicate to Linux that it can switch off the > > periodic timer and reduc

[Qemu-devel] [PATCH v2 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
This v2 does the following: - addresses Markus Ambruster's comments for patch 1 - capitalized some messages in patch 1 - added R-b tags I've pushed this series to my 9p-next branch. Thanks ! -- Greg --- Greg Kurz (2): 9pfs: use error_report() instead of fprintf(stderr) fsdev: use e

[Qemu-devel] [PATCH v2 2/2] fsdev: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
Only fix the code that gets built into QEMU. Reviewed-by: Markus Armbruster Signed-off-by: Greg Kurz --- fsdev/qemu-fsdev.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c index ccfec139ab2b..55e2f7a0fb58 100644 --- a/fsdev/q

[Qemu-devel] [PATCH v2 1/2] 9pfs: use error_report() instead of fprintf(stderr)

2016-01-19 Thread Greg Kurz
Reviewed-by: Markus Armbruster Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c |5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c|2 +- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/hw/9pfs/9p-handle.c b

Re: [Qemu-devel] RFC: running the user interface in a thread ...

2016-01-19 Thread Kevin Wolf
Am 18.01.2016 um 10:54 hat Gerd Hoffmann geschrieben: > Hi folks, > > I'm starting to investigate if and how we can move the user interface > code into its own thread instead of running it in the iothread and > therefore avoid blocking the guest in case some UI actions take a little > longer. >

Re: [Qemu-devel] RFC: running the user interface in a thread ...

2016-01-19 Thread Gerd Hoffmann
Hi, > That, and so the UI can use localization without corrupting other > threads that MUST use the C locale (QMP parsing/output of floating point > is particularly important to get right with '.' instead of ',' for a > decimal separator). A quick look at the setlocale manpage doesn't make clea

[Qemu-devel] [PATCH v17 1/9] acpi: extend ACPI interface to provide access to ACPI registers and SCI irq

2016-01-19 Thread Igor Mammedov
so that we don't have to always add proxy wrappers in piix4pm/ich9 to access ACPI regs and SCI kept in piix4pm/lcp_ich9 devices and call acpi_foo() API directly. Signed-off-by: Igor Mammedov --- hw/acpi/piix4.c | 17 + hw/isa/lpc_ich9.c| 1

[Qemu-devel] [PATCH v17 0/9] Virtual Machine Generation ID

2016-01-19 Thread Igor Mammedov
It's respin of v14* series which uses a PCI BAR to map VGID page in guest AS. Changes since v14: - statically reserve used BAR resources in SSDT, so that Windows won't claim them during PCI rebalancing - support VGID page in high mem in addition to low mem - add QMP/HMP interfaces to get

[Qemu-devel] [PATCH v17 3/9] pc: add a Virtual Machine Generation ID device

2016-01-19 Thread Igor Mammedov
Based on Microsoft's specifications (paper can be downloaded from http://go.microsoft.com/fwlink/?LinkId=260709, easily found by "Virtual Machine Generation ID" keywords), add a PCI device with corresponding description in SSDT ACPI table. The GUID is set using "vmgenid.uuid" property. Example of

[Qemu-devel] [PATCH v17 6/9] qmp/hmp: add set-vm-generation-id commands

2016-01-19 Thread Igor Mammedov
Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "uuid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } } HMP command example: set-vm-generation-id 324e6e

[Qemu-devel] [PATCH v17 4/9] tests: add a unit test for the vmgenid device.

2016-01-19 Thread Igor Mammedov
* test that guest can read UUID provided on CLI from buffer accessing it at HPA which is available via 'vmgid-addr' property when device is inintialized. * test setting UUID at runtime and check that it's updated at expected HPA. Signed-off-by: Gal Hammer Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH v17 2/9] docs: vm generation id device's description

2016-01-19 Thread Igor Mammedov
From: Gal Hammer Signed-off-by: Gal Hammer Signed-off-by: Igor Mammedov --- docs/specs/vmgenid.txt | 36 1 file changed, 36 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode

[Qemu-devel] [PATCH v17 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2016-01-19 Thread Igor Mammedov
Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov --- hmp-commands-info.hx | 13 + hmp.c| 9 + hmp.h

[Qemu-devel] [PATCH v17 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment

2016-01-19 Thread Igor Mammedov
currently slot for PIIX3 bridge is selected dynamically but it's always in slot 1 for existing machine types. However it's easy to regress if another PCI device were added before PIIX3 is created and also requires passing around devfn of the created bridge. Replace dynamic slot assignment with a st

[Qemu-devel] [PATCH v17 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge

2016-01-19 Thread Igor Mammedov
it will save a PCI slot that would be used otherwise. Signed-off-by: Igor Mammedov Suggested-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 12 hw/i386/pc_q35.c | 12 include/hw/i386/ich9.h | 3 ++- include/hw/i386/pc.h | 1 + 4 files changed, 27 inserti

[Qemu-devel] [PATCH v17 7/9] add MachineClass->default_props for setting default device properties

2016-01-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- include/hw/boards.h | 1 + vl.c| 4 2 files changed, 5 insertions(+) diff --git a/include/hw/boards.h b/include/hw/boards.h index 0f30959..d495611 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -90,6 +90,7 @@ struct MachineClas

[Qemu-devel] [PATCH v3 02/13] nbd: convert qemu-nbd server to use I/O channels for connection setup

2016-01-19 Thread Daniel P. Berrange
This converts the qemu-nbd server to use the QIOChannelSocket class for initial listener socket setup and accepting of client connections. Actual I/O is still being performed against the socket file descriptor using the POSIX socket APIs. In this initial conversion though, all I/O is still actuall

[Qemu-devel] [PATCH v3 03/13] nbd: convert blockdev NBD server to use I/O channels for connection setup

2016-01-19 Thread Daniel P. Berrange
This converts the blockdev NBD server to use the QIOChannelSocket class for initial listener socket setup and accepting of client connections. Actual I/O is still being performed against the socket file descriptor using the POSIX socket APIs. Signed-off-by: Daniel P. Berrange --- blockdev-nbd.c

[Qemu-devel] [PATCH v3 07/13] nbd: make client request fixed new style if advertized

2016-01-19 Thread Daniel P. Berrange
If the server advertizes support for the fixed new style negotiation, the client should in turn enable new style. This will allow the client to negotiate further NBD options besides the export name. Signed-off-by: Daniel P. Berrange --- nbd/client.c | 27 +-- 1 file chang

[Qemu-devel] [PATCH v3 00/13] Implement TLS support to QEMU NBD server & client

2016-01-19 Thread Daniel P. Berrange
This is an update of the series previously posted: v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06126.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01580.html This series of patches implements support for TLS in the QEMU NBD server and client code. It is i

[Qemu-devel] [PATCH v3 06/13] nbd: make server compliant with fixed newstyle spec

2016-01-19 Thread Daniel P. Berrange
If the client does not request the fixed new style protocol, then we should only accept NBD_OPT_EXPORT_NAME. All other options are only valid when fixed new style has been activated. The qemu-nbd client doesn't currently request fixed new style protocol, but this change won't break qemu-nbd, becau

[Qemu-devel] [PATCH v3 08/13] nbd: allow setting of an export name for qemu-nbd server

2016-01-19 Thread Daniel P. Berrange
The qemu-nbd server currently always uses the old style protocol since it never sets any export name. This is a problem because future TLS support will require use of the new style protocol negotiation. This adds a "--exportname NAME" argument to qemu-nbd which allows the user to set an explicit e

[Qemu-devel] [PATCH v3 01/13] nbd: convert block client to use I/O channels for connection setup

2016-01-19 Thread Daniel P. Berrange
This converts the NBD block driver client to use the QIOChannelSocket class for initial connection setup. The NbdClientSession struct has two pointers, one to the master QIOChannelSocket providing the raw data channel, and one to a QIOChannel which is the current channel used for I/O. Initially the

[Qemu-devel] [PATCH v3 05/13] nbd: invert client logic for negotiating protocol version

2016-01-19 Thread Daniel P. Berrange
The nbd_receive_negotiate() method takes different code paths based on whether 'name == NULL', and then checks the expected protocol version in each branch. This patch inverts the logic, so that it takes different code paths based on what protocol version it receives and then checks if name is NUL

[Qemu-devel] [PATCH v3 13/13] nbd: enable use of TLS with nbd-server-start command

2016-01-19 Thread Daniel P. Berrange
This modifies the nbd-server-start QMP command so that it is possible to request use of TLS. This is done by adding a new optional parameter "tls-creds" which provides the ID of a previously created QCryptoTLSCreds object instance. TLS is only supported when using an IPv4/IPv6 socket listener. Si

[Qemu-devel] [PATCH v3 04/13] nbd: convert to using I/O channels for actual socket I/O

2016-01-19 Thread Daniel P. Berrange
Now that all callers are converted to use I/O channels for initial connection setup, it is possible to switch the core NBD protocol handling core over to use QIOChannel APIs for actual sockets I/O. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 19 +++ blockdev-nbd.c | 6

[Qemu-devel] [PATCH v3 10/13] nbd: implement TLS support in the protocol negotiation

2016-01-19 Thread Daniel P. Berrange
This extends the NBD protocol handling code so that it is capable of negotiating TLS support during the connection setup. This involves requesting the STARTTLS protocol option before any other NBD options. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 12 +++-- blockdev-nbd.c

[Qemu-devel] [PATCH] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-01-19 Thread Laszlo Ersek
The start_xmit() and e1000_receive_iov() functions implement DMA transfers iterating over a set of descriptors that the guest's e1000 driver prepares: - the TDLEN and RDLEN registers store the total size of the descriptor area, - while the TDH and RDH registers store the offset (in whole tx / r

[Qemu-devel] [PATCH v3 12/13] nbd: enable use of TLS with qemu-nbd server

2016-01-19 Thread Daniel P. Berrange
This modifies the qemu-nbd program so that it is possible to request the use of TLS with the server. It simply adds a new command line option --tls-creds which is used to provide the ID of a QCryptoTLSCreds object previously created via the --object command line option. For example qemu-nbd --o

[Qemu-devel] [PATCH v3 09/13] nbd: pick first exported volume if no export name is requested

2016-01-19 Thread Daniel P. Berrange
The NBD client is currently only capable of using the new style protocol negotiation if an explicit export name is provided. This is a problem, because TLS support will require use of the new style protocol in all cases, and we wish to keep the export name as an optional request for backwards compa

  1   2   3   4   >