On 01/08/2016 09:18 PM, Corey Minyard wrote:
> The way the SDR and sensors are handled currently in the code I wrote
> is far from ideal, it's not scalable. In my mind, the BMC in qemu would
> never be a very elaborate one, you would use an external BMC for that.
Yes. I agree. It is a simulator
On 01/08/2016 09:20 PM, Corey Minyard wrote:
> On 01/06/2016 02:14 AM, Cédric Le Goater wrote:
>> On 01/05/2016 08:59 PM, Eric Blake wrote:
>>> On 01/05/2016 10:29 AM, Cédric Le Goater wrote:
>>>
>>> [meta-comment] Your messages were not marked in-reply-to: the 0/8 cover
>>> letter, but came throug
On 11.01.2016 21:56, John Snow wrote:
On 01/11/2016 10:40 AM, Vladimir Sementsov-Ogievskiy wrote:
On 04.01.2016 13:27, Fam Zheng wrote:
Upon each bit toggle, the corresponding bit in the meta bitmap will be
set.
Signed-off-by: Fam Zheng
---
include/qemu/hbitmap.h | 8 +++
util/hbit
This RFC PATCH tries to solve the problem of lost interrupts
from a slow back-end. Didier could you test it?
Thanks, Victor
When interrupts are unmasked, it could take some undefined time
to the back-end to start routing events to guest_notifier. Till
that the events will continue flow to masked_
On 11.01.2016 20:07, John Snow wrote:
On 01/11/2016 07:20 AM, Vladimir Sementsov-Ogievskiy wrote:
Are you sure? What about creation\last change dates, file links, user
data, etc?
For now, formally, current "For now, as no extra data is defined,
extra_data_size is reserved and must be zero." is
Yes, Linux VM update to a 3.18 kernel.
The RHEL7.2 default kernel (should be 3.10) VM don't boot up with IGD
pass-through, and Windows can't boot up either.
Thanks,
-Xudong
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, January 11, 2016 6:32 PM
> T
Luiz Capitulino writes:
> On Thu, 17 Dec 2015 18:10:59 +0530 (IST)
> P J P wrote:
>
>>Hello,
>>
>> An OOB write issue was reported by Mr Ling Liu, CC'd here. It occurs while
>> processing the 'sendkey' command, if the command argument was longer than
>> the 'keyname_buf[16]' buffer.
>
> Ma
Wolfgang Bumiller writes:
> On Sun, Jan 10, 2016 at 10:56:55AM +0300, Michael Tokarev wrote:
>> So, what's the status of this issue now?
>> (it is CVE-2015-8619 btw, maybe worth to mention this in the commit message)
>
> Seems we concluded it's best to keep keyname_len around and simply check
> i
On 12/01/2016 01:36, John Snow wrote:
> Instead of relying on peeking at bs->job, we want to explicitly get
> a reference to the job that was involved in this notifier callback.
>
> Extend the Notifier to include a job pointer, and include a reference
> to the job registering the callback. This
OK - it's possible that this patch
commit 349a3b1cc9023f67f8fa336cb3c4a8f21a4aaaf3
Author: Cao jin
Date: Sat Jan 2 16:02:20 2016 +0800
igd-passthrough: fix use of host_pci_config_read
is required for older guests.
This patch just went it - could you test lat
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote:
>
>
> On 01/11/2016 08:50 PM, Dr. David Alan Gilbert wrote:
> >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote:
> >>
> >>On 01/08/2016 08:08 PM, Dr. David Alan Gilbert wrote:
> >>>* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote:
> From
2016-01-12 15:57 GMT+08:00 Dmitry Fleytman :
>
>> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote:
>>
>> Hi Dmitry,
>>
>> 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman :
>>>
On 12 Jan 2016, at 04:38 AM, Miao Yan wrote:
Turning debug printfs to trace points for register access
>>>
>>> Hell
On 12 January 2016 at 00:24, Alistair Francis
wrote:
> On Mon, Jan 11, 2016 at 8:04 AM, Peter Maydell
> wrote:
>> There are a couple of problems you're running into:
>>
>> (1) machine->ram_size is a ram_addr_t so might be 32 bit; you
>> can do what virt.c does to avoid the warning and use a loca
* Alexey (aluka...@alukardd.org) wrote:
> Hi David.
>
> On 2016-01-11 22:51, Dr. David Alan Gilbert wrote:
> >* Alexey (aluka...@alukardd.org) wrote:
> >>Hello.
> >
> >Hi,
> >
> >>I have two servers between which I need have live migration.
> >>
> >>First server have QEMU emulator version 2.3.0
>
> On January 12, 2016 at 9:45 AM Markus Armbruster wrote:
>
> Wolfgang Bumiller writes:
>
> > When processing 'sendkey' command, hmp_sendkey routine null
> > terminates the 'keyname_buf' array. This results in an OOB
>
> Well, it technically doesn't terminate,
It does for combined keys where
With latest qemu 7b8a354d4716, RHEL7.2 (with default kernel) VM still can't
boot up with IGD.
Thanks,
-Xudong
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Tuesday, January 12, 2016 4:48 PM
> To: Hao, Xudong
> Cc: Gerd Hoffmann ; Stefano Stabellini
>
Marcelo Tosatti writes:
> On Fri, Dec 18, 2015 at 09:01:33PM +0100, Markus Armbruster wrote:
>> Marcelo Tosatti writes:
>>
>> > Gerd,
>> >
>> > commit df5b2adb7398d71016ee469f71e52075ed95e04e
>> > Author: Gerd Hoffmann
>> > Date: Tue Nov 25 14:54:17 2014 +0100
>> >
>> > input: move input
> -Original Message-
> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> Sent: Monday, January 11, 2016 6:46 PM
> To: Hao, Xudong
> Cc: Stefano Stabellini ; Lars Kurth
> ; Lars Kurth ; Cao jin
> ; xen-de...@lists.xensource.com; Stefano Stabellini
> ; qemu-devel@nongnu.
Hello,
On 2016-01-12 12:19, Dr. David Alan Gilbert wrote:
* Alexey (aluka...@alukardd.org) wrote:
Hi David.
On 2016-01-11 22:51, Dr. David Alan Gilbert wrote:
>* Alexey (aluka...@alukardd.org) wrote:
>>Hello.
>
>Hi,
>
>>I have two servers between which I need have live migration.
>>
>>First se
* Alexey (aluka...@alukardd.org) wrote:
> Hello,
>
> On 2016-01-12 12:19, Dr. David Alan Gilbert wrote:
> >* Alexey (aluka...@alukardd.org) wrote:
> >>Hi David.
> >>
> >>On 2016-01-11 22:51, Dr. David Alan Gilbert wrote:
> >>>* Alexey (aluka...@alukardd.org) wrote:
> Hello.
> >>>
> >>>Hi,
> >>
Am 12.01.2016 um 06:38 hat Denis V. Lunev geschrieben:
> On 01/11/2016 08:31 PM, Kevin Wolf wrote:
> >Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben:
> >>From: Olga Krishtal
> >>
> >>While opening the image we want to be sure that we are the
> >>one who works with image, anf if it is not tr
Keith Busch writes:
> On Mon, Jan 11, 2016 at 05:35:50PM +0100, Markus Armbruster wrote:
>> Tom Yan writes:
>> > Public bug reported:
>> >
>> > I am not exactly sure if this is a bug, but I don't see why the option
>> > "serial" should be required for -device nvme like the option "drive".
>> > T
On Tue, 12 Jan 2016 01:23:56 +0100
Laurent Vivier wrote:
> On 11/01/2016 17:13, Greg Kurz wrote:
> > Indeed vhost doesn't need to ask for vring endian fixing if the device is
> > virtio 1.0, since it is already handled by the in-kernel vhost driver. This
> > patch simply consolidates the logic in
On 2016-01-12 13:04, Dr. David Alan Gilbert wrote:
* Alexey (aluka...@alukardd.org) wrote:
Hello,
On 2016-01-12 12:19, Dr. David Alan Gilbert wrote:
>* Alexey (aluka...@alukardd.org) wrote:
>>Hi David.
>>
>>On 2016-01-11 22:51, Dr. David Alan Gilbert wrote:
>>>* Alexey (aluka...@alukardd.org)
On Di, 2016-01-12 at 09:50 +, Hao, Xudong wrote:
> With latest qemu 7b8a354d4716, RHEL7.2 (with default kernel) VM still can't
> boot up with IGD.
There is another bug, using pci_default_write_config() doesn't fly as
this checks writes against wmask and the registers in question are not
white
Public bug reported:
1.
[qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is
used before limits check.
while (!IsValid(elements[low]) && (low < high)) ++low;
2.
[qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle'
is used before limits check.
while (!IsV
Hi,
> Where "the latter" refers to "IIRC the question was [whether] we'll
> leave it as-is (console=), or [whether] we'll do something like
> display=,head= instead." Oh joy, third addressing scheme.
No, that isn't a third, that is what the command line actually uses, and
'' is the qdev id of
On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote:
>
> On 31/12/2015 19:13, Ilya Lesokhin wrote:
> > I was able to overcome this issue by calling object_unparent on my
> > device but I’m not sure that the correct way of fixing it.
>
> Yes, it's definitely the right way to fix it.
Sorry for
Pass the return code from kvm_emulate_hypercall on to the caller,
in order to allow it to indicate to the userspace that
the hypercall has to be handled there.
Also adjust all the existing code paths to return 1 to make sure the
hypercall isn't passed to the userspace without setting kvm_run
appro
Rename HV_X64_HV_NOTIFY_LONG_SPIN_WAIT
by HV_X64_HCALL_NOTIFY_LONG_SPIN_WAIT. So
the name better reflects hypercall codes accessory.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Gleb Natapov
CC: Paolo Bonzini
CC: Joerg Roedel
CC: "K. Y. Srinivasan"
CC: Haiyang Zhang
CC: Roman
Currently we do not support Hyper-V hypercall continuation
so reject it.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Gleb Natapov
CC: Paolo Bonzini
CC: Joerg Roedel
CC: "K. Y. Srinivasan"
CC: Haiyang Zhang
CC: Roman Kagan
CC: Denis V. Lunev
CC: qemu-devel@nongnu.org
---
a
The patch implements KVM_EXIT_HV_HCALL functionality
for Hyper-V VMBus hypercalls: HV_X64_HCALL_POST_MESSAGE,
HV_X64_HCALL_SIGNAL_EVENT.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Gleb Natapov
CC: Paolo Bonzini
CC: Joerg Roedel
CC: "K. Y. Srinivasan"
CC: Haiyang Zhang
CC: R
The patch implements userspace exit 'KVM_EXIT_HYPERV_HCALL'
for Hyper-V VMBus hypercalls(postmsg, signalevent)
to handle these hypercalls by QEMU.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Gleb Natapov
CC: Paolo Bonzini
CC: Joerg Roedel
CC: "K. Y. Srinivasan"
CC: Haiyang Zh
VMBus hypercall codes inside Hyper-V UAPI header will
be used by QEMU to implement VMBus host devices support.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Gleb Natapov
CC: Paolo Bonzini
CC: Joerg Roedel
CC: "K. Y. Srinivasan"
CC: Haiyang Zhang
CC: Roman Kagan
CC: Denis V. L
This is a simple test which performs the
following:
* setup hypecall page
* do some hypercalls and output their results
Signed-off-by: Andrey Smetanin
CC: Paolo Bonzini
CC: Marcelo Tosatti
CC: Roman Kagan
CC: Denis V. Lunev
CC: qemu-devel@nongnu.org
---
config/config-x86-common.mak | 4 ++
On Fri, Jan 08, 2016 at 10:05:44AM +0100, Paolo Bonzini wrote:
>
>
> On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> > +{
> > +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
>
> Off by one. The check should be >=, not >.
>
> Paolo
Corey, can you look into this pleas
This patch just for completeness, this changes
should be received by scripts/update-linux-headers.sh
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkost
CC: "Andreas Färber"
CC: Marcelo Tosatti
CC: Roman Kagan
CC: Denis V. Lun
The patches adds blank handlers for Hyper-V
VMBus hypercalls routed by KVM_EXIT_HYPERV_HCALL KVM exit.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkost
CC: "Andreas Färber"
CC: Marcelo Tosatti
CC: Roman Kagan
CC: Denis V. L
Add Hyper-V VMBus hypercalls blank handlers which
just returns error code - HV_STATUS_INVALID_HYPERCALL_CODE.
Signed-off-by: Andrey Smetanin
Reviewed-by: Roman Kagan
CC: Paolo Bonzini
CC: Richard Henderson
CC: Eduardo Habkost
CC: "Andreas Färber"
CC: Marcelo Tosatti
CC: Roman Kagan
CC: Den
Paolo,
Could you please force these patches applied
during current merge window. We need them
very, because they are last patches for KVM which
are required to start development of Hyper-V
VMBus devices in QEMU side.
P.S.:
We have created our public repo (based on current kvm/queue) to fetch
our
On 11 January 2016 at 19:33, John Snow wrote:
> The following changes since commit 7b8a354d4716ab2c201fad04c22b8d4a16a1b8c6:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20160111-1' into staging (2016-01-11
> 16:09:50 +)
>
> are available in the git repository
On Tue, 01/12 11:10, Kevin Wolf wrote:
>
> The problem is that libvirt already takes a lock, as Dan mentioned in
> another reply in this thread, so we can't enable locking in qemu by
> default. It would always fail when run under libvirt.
>
> Unless I'm seriously mistaken, this means that flock()
libvixl is not part of QEMU proper, but is an upstream library which we
use (as documented in disas/libvixl/README). If you want to suggest
coding style changes to it I would recommend reporting them to the
upstream project: https://github.com/armvixl/vixl .
QEMU just takes the most recent releas
This is a formal posting of patches that were previously
previewed at:
FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html
The primary goal of this series of patches is to support TLS on the
migration data channel. The bulk of the work in this series though,
is converting t
On Mon, 01/11 15:00, Paolo Bonzini wrote:
>
>
> On 11/01/2016 04:36, Fam Zheng wrote:
> >
> > +aio_set_fd_handler(ctx, client->sock, true,
> > + nbd_negotiate_continue,
> > + nbd_negotiate_continue, data->co);
> > TRACE("Beginning negotiation
The s390 skeys monitor command needs to write out a plain text
file. Currently it is using the QEMUFile class for this. There
is no real benefit to this, and the downside is that it needs to
snprintf via an intermediate buffer. Switching to regular FILE
objects simplifies the code.
Signed-off-by:
The QEMUFileOps struct contains the I/O subsystem callbacks
and the migration stage hooks. Split the hooks out into a
separate QEMUFileHooks struct to make it easier to refactor
the I/O side of QEMUFile without affecting the hooks.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-fil
The QEMUFile writev_buffer / put_buffer functions are expected
to write out the full set of requested data, blocking until
complete. The qemu_fflush() caller does not expect to deal with
partial writes. Clarify the function comments and add a sanity
check to the code to catch mistaken implementatio
The post-copy code does some I/O to/from an intermediate
in-memory buffer rather than direct to the underlying
I/O channel. Switch this code to use QIOChannelBuffer
instead of QEMUSizedBuffer.
Signed-off-by: Daniel P. Berrange
---
docs/migration.txt | 4 ++--
include/sysemu/sysemu.h | 2 +
Some of the test-vmstate.c test cases use a temporary file
while others use a memory buffer. To facilitate the future
removal of the qemu_bufopen() function, convert all the tests
to use a temporary file.
Signed-off-by: Daniel P. Berrange
---
tests/Makefile | 2 +-
tests/test-vmstate.c |
Instead of relying on the default QEMUFile I/O blocking flag
state, explicitly turn on blocking I/O for outgoing migration
since it takes place in a background thread.
Signed-off-by: Daniel P. Berrange
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migrat
Remove the assumption that every QEMUFile implementation has
a file descriptor available by introducing a new function
in QEMUFileOps to change the blocking state of a QEMUFile.
If not set, it will fallback to the original code using
the get_fd method.
Signed-off-by: Daniel P. Berrange
---
incl
This extends the TCP migration backend so that it can make use
of QIOChannelTLS to provide transparent TLS encryption. To
trigger enablement the URI on the incoming and outgoing sides
should have 'tls-creds=ID' appended, eg
tcp:$HOST:$PORT,tls-creds=ID
where ID is the object identifier of a se
Introduce a new QEMUFile implementation that is based on
the QIOChannel objects. This impl is different from existing
impls in that there is no file descriptor that can be made
available, as some channels may be based on higher level
protocols such as TLS.
Although the QIOChannel based implementat
Convert the tcp socket migration protocol driver to use
QIOChannel and QEMUFileChannel, instead of plain sockets
APIs.
While this now looks pretty similar to the migration/unix.c
file from the previous patch, it was decided not to merge
the two, because when TLS is added to the TCP impl later,
thi
Convert the unix socket migration protocol driver to use
QIOChannel and QEMUFileChannel, instead of plain sockets
APIs. It can be unconditionally built, since the socket
impl of QIOChannel will report a suitable error on platforms
where UNIX sockets are unavailable.
Signed-off-by: Daniel P. Berran
Convert the fd socket migration protocol driver to use
QIOChannel and QEMUFileChannel, instead of plain sockets
APIs. It can be unconditionally built because the
QIOChannel APIs it uses will take care to report suitable
error messages if needed.
Signed-off-by: Daniel P. Berrange
---
migration/Ma
Convert the exec savevm code to use QIOChannel and QEMUFileChannel,
instead of the stdio APIs.
Signed-off-by: Daniel P. Berrange
---
migration/savevm.c | 8 +---
tests/Makefile | 4 ++--
tests/test-vmstate.c | 11 ++-
3 files changed, 17 insertions(+), 6 deletions(-)
diff
Convert the exec socket migration protocol driver to use
QIOChannel and QEMUFileChannel, instead of the stdio
popen APIs. It can be unconditionally built because the
QIOChannelCommand class can report suitable error messages
on platforms which can't fork processes.
Signed-off-by: Daniel P. Berrang
All the remaining QEMUFile implementations provide an iovec
based write handler, so the put_buffer callback can be removed
to simplify the code.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-file.h | 9 -
migration/qemu-file.c | 36
Now that we don't have have a buffer based QemuFile
implementation, the QEMUSizedBuffer code is also
unused and can be deleted. A simpler buffer class
also exists in util/buffer.c which other code can
used as needed.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-file.h | 16 --
i
Now that the tcp, unix and fd migration backends have converted
to use the QIOChannel based QEMUFile, there is no user remaining
for the sockets based QEMUFile impl and it can be deleted.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-file.h | 2 -
migration/Makefile.objs |
Now that the memory buffer based QEMUFile impl is gone, there
is no need for any backend to be accessing internals of the
QEMUFile struct, so it can be moved back into qemu-file.c
Signed-off-by: Daniel P. Berrange
---
migration/qemu-file-internal.h | 54 --
Now that there is a set_blocking callback in QEMUFileOps,
and all users needing non-blocking support have been
converted to QIOChannel, there is no longer any codepath
requiring the qemu_get_fd() method for QEMUFile. Remove it
to avoid further code being introduced with an expectation
of direct fil
- Original Message -
> From: "Thomas Huth"
> To: "Jason Wang" , "Jan Kiszka"
> , qemu-devel@nongnu.org
> Cc: "Paolo Bonzini" , avocado-de...@redhat.com, "Markus
> Armbruster"
> Sent: Tuesday, January 12, 2016 5:26:36 AM
> Subject: Re: [Qemu-devel] [PATCH] net/slirp: Tell the users whe
On Tue, 12 Jan 2016 11:43:55 +
"Daniel P. Berrange" wrote:
> The s390 skeys monitor command needs to write out a plain text
> file. Currently it is using the QEMUFile class for this. There
> is no real benefit to this, and the downside is that it needs to
> snprintf via an intermediate buffer
From: "Dr. David Alan Gilbert"
This allows you to do:
./config.status --the-option-you-forgot
Signed-off-by: Dr. David Alan Gilbert
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 44ac9ab..9a9e978 100755
--- a/configure
+++ b/conf
BTW, also available at
https://github.com/berrange/qemu/tree/io-channel-migration-1
On Tue, Jan 12, 2016 at 11:43:54AM +, Daniel P. Berrange wrote:
> This is a formal posting of patches that were previously
> previewed at:
>
> FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/ms
On 12/01/2016 11:44, Knut Omang wrote:
> On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote:
>>
>> On 31/12/2015 19:13, Ilya Lesokhin wrote:
>>> I was able to overcome this issue by calling object_unparent on my
>>> device but I’m not sure that the correct way of fixing it.
>>
>> Yes, it's de
Hi,
> In my libvirt domain I have option .
Why?
cheers,
Gerd
On Tue, Jan 12, 2016 at 12:58:10PM +0100, Cornelia Huck wrote:
> On Tue, 12 Jan 2016 11:43:55 +
> "Daniel P. Berrange" wrote:
>
> > The s390 skeys monitor command needs to write out a plain text
> > file. Currently it is using the QEMUFile class for this. There
> > is no real benefit to this,
On 12/01/2016 12:06, Michael S. Tsirkin wrote:
>>> > > +{
>>> > > +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2]))
>>> > > {
>> >
>> > Off by one. The check should be >=, not >.
>> >
>> > Paolo
> Corey, can you look into this please?
>
He already posted some fixes ye
On Tue, 12 Jan 2016 12:01:21 +
"Daniel P. Berrange" wrote:
> On Tue, Jan 12, 2016 at 12:58:10PM +0100, Cornelia Huck wrote:
> > On Tue, 12 Jan 2016 11:43:55 +
> > "Daniel P. Berrange" wrote:
> >
> > > The s390 skeys monitor command needs to write out a plain text
> > > file. Currently i
On 12/01/2016 08:22, Cao jin wrote:
> Thanks for your time. I almost forget this one...
>
> On 01/11/2016 05:20 PM, Paolo Bonzini wrote:
>>
>>
>> On 11/01/2016 09:32, Michael Tokarev wrote:
>
> +assert(size > 0);
> +assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset);
> +
On 01/12/2016 09:26 AM, Victor Kaplansky wrote:
This RFC PATCH tries to solve the problem of lost interrupts
from a slow back-end. Didier could you test it?
Thanks, Victor
When interrupts are unmasked, it could take some undefined time
to the back-end to start routing events to guest_notifier.
On Wed, 01/06 18:53, Max Reitz wrote:
> On 05.01.2016 09:46, Fam Zheng wrote:
> > The "pnum < nb_sectors" condition in deciding whether to actually copy
> > data is unnecessarily strict, and the qiov initialization is
> > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
> >
> > Rewrit
* Alexey (aluka...@alukardd.org) wrote:
>
>
> On 2016-01-12 13:04, Dr. David Alan Gilbert wrote:
> >* Alexey (aluka...@alukardd.org) wrote:
> >>Hello,
> >>
> >>On 2016-01-12 12:19, Dr. David Alan Gilbert wrote:
> >>>* Alexey (aluka...@alukardd.org) wrote:
> Hi David.
>
> On 2016-01-1
The qemu_bufopen() method is no longer used, so the memory
buffer based QEMUFile backend can be deleted entirely.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-file.h | 6 ---
migration/qemu-file-buf.c | 96 ---
2 files changed, 102 del
Peter Maydell writes:
> On 11 January 2016 at 20:16, Lluís Vilanova wrote:
>> Great! I implemented a similar thing long time ago. In my case the machinery
>> is
>> completely hidden under the concept of "value promises" in TCG (i.e., the
>> user
>> does not need to know about TCG internals like
Now that the exec migration backend and savevm have converted
to use the QIOChannel based QEMUFile, there is no user remaining
for the stdio based QEMUFile impl and it can be deleted.
Signed-off-by: Daniel P. Berrange
---
include/migration/qemu-file.h | 2 -
migration/Makefile.objs | 2
>If you want to suggest coding style changes to it I would recommend reporting
>them to the upstream project:
Thanks. Done here:
https://github.com/armvixl/vixl/issues
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.l
On 01/12/2016 02:33 PM, Fam Zheng wrote:
On Tue, 01/12 11:10, Kevin Wolf wrote:
The problem is that libvirt already takes a lock, as Dan mentioned in
another reply in this thread, so we can't enable locking in qemu by
default. It would always fail when run under libvirt.
Unless I'm seriously mi
This converts the RDMA code to provide a subclass of
QIOChannel that uses RDMA for the data transport.
The RDMA code would be much better off it it could
be split up in a generic RDMA layer, a QIOChannel
impl based on RMDA, and then the RMDA migration
glue. This is left as a future exercise for th
Am 12.01.2016 um 12:33 hat Fam Zheng geschrieben:
> On Tue, 01/12 11:10, Kevin Wolf wrote:
> >
> > The problem is that libvirt already takes a lock, as Dan mentioned in
> > another reply in this thread, so we can't enable locking in qemu by
> > default. It would always fail when run under libvirt.
We have two places needing this, and a third one will come shortly.
So create a helper function for that so we don't diplicate code.
Signed-off-by: Gerd Hoffmann
---
include/ui/console.h | 2 ++
ui/console.c | 23 +++
2 files changed, 25 insertions(+)
diff --git a/i
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 09756cd..95ef3bd 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3725,19 +3725,12 @@ void vnc_display_open(const char *id, Error **errp)
device_
Signed-off-by: Gerd Hoffmann
---
ui/input.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/ui/input.c b/ui/input.c
index 006667b..1409e01 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -81,19 +81,12 @@ void qemu_input_handler_bind(QemuInputHandlerState *s,
Lowercase them.
Signed-off-by: Gerd Hoffmann
---
qapi-schema.json | 5 +
qmp-commands.hx | 4 ++--
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 511702f..35ef71c 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3672,12 +3672
With all fixups being in place now, we can promote input-send-event
to stable abi by removing the x- prefix.
Signed-off-by: Gerd Hoffmann
---
qapi-schema.json | 12 +++-
qmp-commands.hx | 14 +++---
ui/input.c | 6 +++---
3 files changed, 13 insertions(+), 19 deletions(-)
Use display device qdev id and head number instead of console index to
specify the QemuConsole. This makes things consistent with input
devices (for input routing) and vnc server configuration, which both use
display and head too.
Signed-off-by: Gerd Hoffmann
---
qapi-schema.json | 32 +
All lowercase, use-dash instead of CamelCase.
Signed-off-by: Gerd Hoffmann
---
hw/input/hid.c | 4 ++--
hw/input/ps2.c | 4 ++--
hw/input/virtio-input-hid.c | 4 ++--
monitor.c | 2 +-
qapi-schema.json| 5 +
qmp-commands.hx
On Tue, Jan 12, 2016 at 01:29:33PM +0100, Gerd Hoffmann wrote:
> We have two places needing this, and a third one will come shortly.
> So create a helper function for that so we don't diplicate code.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: http:/
On Tue, Jan 12, 2016 at 01:29:34PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> ui/input.c | 15 ---
> 1 file changed, 4 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: http://berrange.com -o-http://www.flickr.co
On Tue, Jan 12, 2016 at 01:29:35PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> ui/vnc.c | 15 ---
> 1 file changed, 4 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: http://berrange.com -o-http://www.flickr.com/p
On Tue, Jan 12, 2016 at 01:29:36PM +0100, Gerd Hoffmann wrote:
> Use display device qdev id and head number instead of console index to
> specify the QemuConsole. This makes things consistent with input
> devices (for input routing) and vnc server configuration, which both use
> display and head t
On Tue, Jan 12, 2016 at 01:29:37PM +0100, Gerd Hoffmann wrote:
> All lowercase, use-dash instead of CamelCase.
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/input/hid.c | 4 ++--
> hw/input/ps2.c | 4 ++--
> hw/input/virtio-input-hid.c | 4 ++--
> monitor.c
On Tue, Jan 12, 2016 at 01:29:38PM +0100, Gerd Hoffmann wrote:
> Lowercase them.
>
> Signed-off-by: Gerd Hoffmann
> ---
> qapi-schema.json | 5 +
> qmp-commands.hx | 4 ++--
> 2 files changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: http://b
On Tue, Jan 12, 2016 at 01:29:39PM +0100, Gerd Hoffmann wrote:
> With all fixups being in place now, we can promote input-send-event
> to stable abi by removing the x- prefix.
>
> Signed-off-by: Gerd Hoffmann
> ---
> qapi-schema.json | 12 +++-
> qmp-commands.hx | 14 +++---
> u
This pointer should be cleared in vnc_display_close()
otherwise a use-after-free can happen when when using the
old style 'x509' and 'tls' options rather than a persistent
tls-creds -object, by issuing monitor commands to change
the vnc server like so:
Start with: -vnc unix:test.socket,x509,tls
Th
On 2016/1/11 21:16, Markus Armbruster wrote:
Hailiang Zhang writes:
On 2015/12/19 17:27, Markus Armbruster wrote:
zhanghailiang writes:
Guest will enter this state when paused to save/restore VM state
under colo checkpoint.
Cc: Eric Blake
Cc: Markus Armbruster
Signed-off-by: zhanghailia
1 - 100 of 290 matches
Mail list logo
