Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

2016-01-11 Thread Wolfgang Bumiller
On Sun, Jan 10, 2016 at 10:56:55AM +0300, Michael Tokarev wrote: > So, what's the status of this issue now? > (it is CVE-2015-8619 btw, maybe worth to mention this in the commit message) Seems we concluded it's best to keep keyname_len around and simply check it against the sizeof(keyname_buf). H

Re: [Qemu-devel] [PATCH] PCI Bonito: QOMify

2016-01-11 Thread Michael Tokarev
05.01.2016 13:57, Cao jin wrote: > Also clear the code Applied to -trivial. Thanks, /mjt

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

2016-01-11 Thread Michael Tokarev
30.12.2015 22:54, Sitsofe Wheeler wrote: > Indented lines in the texi meant the perlpod produced interpreted the > paragraph as being verbatim (thus formatting codes were not > interpreted). Fix this by un-indenting problem lines. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

2016-01-11 Thread Michael Tokarev
11.01.2016 11:07, Michael Tokarev wrote: > 30.12.2015 22:54, Sitsofe Wheeler wrote: >> Indented lines in the texi meant the perlpod produced interpreted the >> paragraph as being verbatim (thus formatting codes were not >> interpreted). Fix this by un-indenting problem lines. > > Applied to -trivi

Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

2016-01-11 Thread Michael Tokarev
18.12.2015 15:59, Peter Maydell wrote: > The checkpatch.pl script has a special case to permit the following > operators to have no spaces around them: > << >> & ^ | + - * / % > > QEMU style prefers all operators to consistently have spacing around > them, so remove this special case han

Re: [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h

2016-01-11 Thread Michael Tokarev
04.12.2015 20:34, Peter Maydell wrote: > Our use of glib is now pervasive across QEMU. Move the include of > glib-compat.h > from qemu-common.h to osdep.h so that it is more widely accessible and doesn't > get forgotten by accident. (Failure to include it will result in build failure > on old vers

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

2016-01-11 Thread P J P
+-- On Mon, 11 Jan 2016, Wolfgang Bumiller wrote --+ | Seems we concluded it's best to keep keyname_len around and simply check it | against the sizeof(keyname_buf). | | Here's a full new version as I haven't seen one yet. (With an adapted commit | message and the CVE id added.) Sorry, i thou

Re: [Qemu-devel] QEMU/KVM performance gets worser - high load - high interrupts - high context switches

2016-01-11 Thread Paolo Bonzini
On 09/01/2016 17:46, Gerhard Wiesinger wrote: > > # Positive consequences via munin monitoring: > # Reduced fork rate: 40 => 13 > # process states: running 15 => <1 > # CÜU temperature: (core dependant) 65-70°C => 56-64°C > # CPU usage: system: 47% => 15%, user: 76% => 50% > # Context Switches:

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-01-11 Thread Gerd Hoffmann
On Fr, 2016-01-08 at 19:32 +0100, Laszlo Ersek wrote: > On 01/08/16 18:45, Igor Mammedov wrote: > > On Fri, 8 Jan 2016 13:58:03 +0100 > > Gerd Hoffmann wrote: > > > >> This patch extends the functionality of the max-ram-below-4g option > >> to also allow increasing lowmem. Use case: Give as muc

Re: [Qemu-devel] [PATCH 0/4] Remove superfluous return statements

2016-01-11 Thread Michael Tokarev
10.11.2015 23:16, Thomas Huth wrote: > Some functions in QEMU have a "return;" statement at the > very end of a function with "void" return type, i.e. the > return statement is superfluous. This patch series removes > some of them. > > Thomas Huth (4): > hw/ide: Remove superfluous return stateme

Re: [Qemu-devel] [PATCH] PCI: add param check for api

2016-01-11 Thread Michael Tokarev
21.11.2015 10:45, Cao jin wrote: > add param check for pci_add_capability2, as it is a public API. > > Signed-off-by: Cao jin > --- > hw/pci/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 168b9cc..6938f64 100644 > --- a/hw/pci/pci.c > +++ b

Re: [Qemu-devel] [PATCH] block: acquire in bdrv_query_image_info

2016-01-11 Thread Paolo Bonzini
On 25/12/2015 02:51, Fam Zheng wrote: > On Wed, 12/23 11:48, Paolo Bonzini wrote: >> NFS calls aio_poll inside bdrv_get_allocated_size. This requires >> acquiring the AioContext. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/qapi.c | 9 +++-- >> 1 file changed, 7 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

2016-01-11 Thread Michael Tokarev
11.12.2015 14:29, Ashley Jonathan wrote: > I have experienced a minor difficulty using QEMU with the "-serial pty" > option: > > If a process opens the slave pts device, writes data to it, then immediately > closes it, the data doesn't reliably get delivered to the emulated serial > port. This

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

2016-01-11 Thread Paolo Bonzini
On 25/12/2015 02:55, Fam Zheng wrote: > On Wed, 12/23 11:48, Paolo Bonzini wrote: >> This is also needed in bdrv_drain_all, not just in bdrv_drain. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/io.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/block/io.c b/block/io.c >> inde

[Qemu-devel] Recall: [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Hao, Xudong
Hao, Xudong would like to recall the message, "[Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()".

[Qemu-devel] [PULL 07/19] xen/Makefile.objs: simplify

2016-01-11 Thread Michael Tokarev
From: Cao jin merge last two lines, keep alphabetic order. Signed-off-by: Cao jin Reviewed-by: Stefan Weil Reviewed-by: Stefano Stabellini Signed-off-by: Michael Tokarev --- hw/xen/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xen/Makefile.objs b/hw/

[Qemu-devel] [PULL 05/19] MAINTAINERS: Add the correct device_tree.h file

2016-01-11 Thread Michael Tokarev
From: Thomas Huth device_tree.h is not in the main directory, but under include/sysemu/ nowadays. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5a62ecd..de5439d 10

[Qemu-devel] [PULL 01/19] unicore32: convert get_sp_from_cpustate from macro to inline

2016-01-11 Thread Michael Tokarev
All other architectures define get_sp_from_cpustate as an inline function, only unicore32 uses a #define. With this, some usages are impossible, for example, enabling sigaltstack in linux-user/syscall.c results in linux-user/syscall.c: In function ‘do_syscall’: linux-user/syscall.c:8299:39: error

[Qemu-devel] [PULL 00/19] Trivial patches for 2016-01-11

2016-01-11 Thread Michael Tokarev
This is the first trivial-patches pull request for 2016 year, and the first one for qemu 2.6 series. With some old stuff in there, collecting missing patches since Nov-2015. There's nothing exciting in there, except of a possible fun patch enabling sigaltstack syscall. Please consider applying/p

[Qemu-devel] [PULL 08/19] configure: fix trace backend check

2016-01-11 Thread Michael Tokarev
From: Marc-André Lureau Found thanks to shellcheck! Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 83b40fc..44ac9ab 100755 --- a/configure ++

[Qemu-devel] [PULL 06/19] crypto: Fix typo in example

2016-01-11 Thread Michael Tokarev
From: Eric Blake The example code wouldn't even compile, since it did not use a consistent spelling for the Error ** parameter. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrange Signed-off-by: Michael Tokarev --- include/crypto/tlssession.h | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PULL 14/19] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

2016-01-11 Thread Michael Tokarev
From: Peter Maydell The checkpatch.pl script has a special case to permit the following operators to have no spaces around them: << >> & ^ | + - * / % QEMU style prefers all operators to consistently have spacing around them, so remove this special case handling. This avoids reviewers

[Qemu-devel] [PULL 09/19] hw/misc/edu: Convert to realize()

2016-01-11 Thread Michael Tokarev
From: Cao jin for educational PCI device Signed-off-by: Cao jin Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- hw/misc/edu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index fe50b42..43d5b18 100644 --- a/hw/misc/

[Qemu-devel] [PULL 15/19] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h

2016-01-11 Thread Michael Tokarev
From: Peter Maydell Our use of glib is now pervasive across QEMU. Move the include of glib-compat.h from qemu-common.h to osdep.h so that it is more widely accessible and doesn't get forgotten by accident. (Failure to include it will result in build failure on old versions of glib which is likely

[Qemu-devel] [PULL 04/19] iscsi: fix readcapacity error message

2016-01-11 Thread Michael Tokarev
From: Zhu Lingshan fix:The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure, fixed the error message. Signed-off-by: Zhu Lingshan Reviewed-by: John Snow Signed-off-by: Michael Tokarev --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [PULL 16/19] hw/ide: Remove superfluous return statements

2016-01-11 Thread Michael Tokarev
From: Thomas Huth The "return;" statements at the end of functions do not make much sense, so let's remove them. Cc: qemu-bl...@nongnu.org Signed-off-by: Thomas Huth Reviewed-by: John Snow Signed-off-by: Michael Tokarev --- hw/ide/atapi.c | 1 - hw/ide/macio.c | 2 -- 2 files changed, 3 dele

[Qemu-devel] [PULL 13/19] PCI Bonito: QOMify and cleanup

2016-01-11 Thread Michael Tokarev
From: Cao jin Also clear the code Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/pci-host/bonito.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 4139a2c..b477679 100644 --- a/hw/pci

Re: [Qemu-devel] [Qemu-block] [PATCH] send readcapacity10 when readcapacity16 failed

2016-01-11 Thread Peter Lieven
Am 07.01.2016 um 11:07 schrieb Paolo Bonzini: > > On 06/01/2016 18:57, John Snow wrote: >> Ronnie: Thanks for the explanation! >> >> Zhu: In light of this, can the patch be reworked slightly to explicitly >> check *why* READCAPACITY16 failed and only attempt the READCAPACITY10 as >> a fallback if i

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

2016-01-11 Thread Peter Lieven
Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: >> recent libnfs versions support logging debug messages. Add >> support for it in qemu through an URL parameter. >> >> Example: >> qemu -cdrom nfs://127.0.0.1/iso/my.iso?debug=2 >> >> S

[Qemu-devel] [PATCH v2] linux-user/syscall.c: Add SO_RCVTIMEO and SO_SNDTIMEO for getsockopt

2016-01-11 Thread chengang
From: Chen Gang Implement them according to the other features implementations. Signed-off-by: Chen Gang --- linux-user/syscall.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 44485f2..4c68800

Re: [Qemu-devel] [PATCH v2] linux-user: syscall: Add SO_LINGER for setsockopt

2016-01-11 Thread Laurent Vivier
Le 11/01/2016 07:47, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Just implement it according to the other features implementations. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 18 +- > linux-user/syscall_defs.h | 5 + > 2 files changed,

[Qemu-devel] [PULL 18/19] hw/core/qdev: Remove superfluous return statement

2016-01-11 Thread Michael Tokarev
From: Thomas Huth The "return;" statement at the end of device_set_realized() does not make much sense, so let's remove it. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/core/qdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index b3a

[Qemu-devel] [PULL 19/19] hw/s390x: Remove superfluous return statements

2016-01-11 Thread Michael Tokarev
From: Thomas Huth The "return;" statements at the end of functions do not make much sense, so let's remove them. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/s390x/css.c | 1 -

[Qemu-devel] [PULL 17/19] hw/acpi: Remove superfluous return statement

2016-01-11 Thread Michael Tokarev
From: Thomas Huth The "return;" statement at the end of acpi_memory_plug_cb() does not make much sense, so let's remove it. Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/acpi/memory_hotplug.c | 1 - 1 file changed, 1 deletion(-)

[Qemu-devel] [PATCH v2 1/3] linux-user/mmap.c: Set prot page flags for the correct region in mmap_frag()

2016-01-11 Thread chengang
From: Chen Gang mmap() size in mmap_frag() is qemu_host_page_size, but the outside calls page_set_flags() may be not with qemu_host_page_size. So after mmap(), call page_set_flags() in time. After this fix, for the next call for the same region, prot1 will be PAGE_VALID (not 0), so can avoid to

[Qemu-devel] [PATCH v2 3/3] linux-user/mmap.c: Use TARGET_PAGE_SIZE as the increasing step

2016-01-11 Thread chengang
From: Chen Gang Just like another areas have done. --- linux-user/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 51c381d..86c270b 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -151,7 +151,7 @@ static int mmap_fra

[Qemu-devel] [PATCH v2 2/3] linux-user/mmap.c: Remove useless variable p for mmap_frag

2016-01-11 Thread chengang
From: Chen Gang It is useless. Signed-off-by: Chen Gang --- linux-user/mmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 7807ed0..51c381d 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -158,10 +158,10 @@ stat

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Add SO_RCVTIMEO and SO_SNDTIMEO for getsockopt

2016-01-11 Thread Laurent Vivier
Le 11/01/2016 09:54, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Implement them according to the other features implementations. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > d

[Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue

2016-01-11 Thread Leonid Bloch
With automatically generated GUID, on minor version changes, an error occurred, stating that there is a problem with the installer. Now, a notification is shown, warning the user that another version of this product is already installed, and that configuration or removal of the existing version is

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 09:33, Michael Tokarev wrote: > 11.12.2015 14:29, Ashley Jonathan wrote: >> I have experienced a minor difficulty using QEMU with the "-serial pty" >> option: >> >> If a process opens the slave pts device, writes data to it, then immediately >> closes it, the data doesn't reliably

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

2016-01-11 Thread Paolo Bonzini
On 11/12/2015 12:29, Ashley Jonathan wrote: > I have experienced a minor difficulty using QEMU with the "-serial > pty" option: > > If a process opens the slave pts device, writes data to it, then > immediately closes it, the data doesn't reliably get delivered to the > emulated serial port. Thi

[Qemu-devel] [PULL 12/19] SH PCI Host: convert to realize()

2016-01-11 Thread Michael Tokarev
From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/sh4/sh_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index a2f6d9e..4509053 100644 --- a/hw/sh4/sh_pci.c +++ b/hw/sh4/sh_pci.c @@ -151,12 +151,11 @@ sta

[Qemu-devel] [PULL 10/19] Add missing syscall nrs. according to more recent Linux kernels

2016-01-11 Thread Michael Tokarev
From: Johan Ouwerkerk This change covers arm, aarch64, mips. Others to follow? The change was prompted by QEMU warning about a syscall 384 (get_random()) with Debian armhf binaries (ARMv7). Signed-off-by: Johan Ouwerkerk Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- linux-us

[Qemu-devel] [PULL 02/19] linux-user: enable sigaltstack for all architectures

2016-01-11 Thread Michael Tokarev
There is no reason to limit sigaltstack syscall to just a few architectures and pretend it is not implemented for others. If some architecture is not ready for this, that architecture should be fixed instead. This fixes LP#1516408. Signed-off-by: Michael Tokarev Reviewed-by: Peter Maydell ---

[Qemu-devel] [PULL 11/19] gt64120: convert to realize()

2016-01-11 Thread Michael Tokarev
From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/mips/gt64xxx_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index f76a9fd..c1f3c9c 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_

[Qemu-devel] [PULL 03/19] net: convert qemu_log to error_report, fix message

2016-01-11 Thread Michael Tokarev
From: Paolo Bonzini Ensure that the error is printed with the proper timestamp. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- net/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dump.c b/net/dump.c index ce16a4b..1c05f78 100644 --- a/net/dump.c

Re: [Qemu-devel] [PATCH] PCI: add param check for api

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 09:32, Michael Tokarev wrote: >> > >> > +assert(size > 0); >> > +assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset); >> > + > I'd like to see some ACKs/Reviews for this one, in particular why > size should be != 0. In fact it should be >= 2, because two bytes are always

[Qemu-devel] [PATCH v3 2/3] 9pfs: use V9fsBlob to transmit xattr

2016-01-11 Thread Wei Liu
And make v9fs_pack static function. Now we only need to export v9fs_{,un}marshal to device. Signed-off-by: Wei Liu --- v3: fix bug discovered by Aneesh --- fsdev/9p-iov-marshal.c | 4 ++-- fsdev/9p-iov-marshal.h | 3 --- hw/9pfs/9p.c | 21 + 3 files changed, 15 in

[Qemu-devel] [PATCH v3 0/3] 9pfs: disentangling virtio and generic code

2016-01-11 Thread Wei Liu
Hi all This is version 3 of this series. It is based on https://github.com/kvaneesh/qemu/commits/upstream-v9fs so it only contains patches that are not in that branch. These three patches were tested with Turex POSIX test suite 20080816 and 20090130-rc. It passed all tests in 20080816 and got

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

2016-01-11 Thread Ashley Jonathan
Apologies; I overlooked that detail: Signed-off-by: Ashley Jonathan Regards, -- Jon Ashley -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: 11 January 2016 09:16 To: Ashley Jonathan; qemu-devel@nongnu.org Cc: qemu-triv...@nongnu.or

[Qemu-devel] [PATCH v3 1/3] fsdev: 9p-marshal: introduce V9fsBlob

2016-01-11 Thread Wei Liu
Introduce a concept of blob. It will be used to pack / unpack xattr value. With this change there is no need to expose v9fs_pack to device code anymore. Signed-off-by: Wei Liu --- v3: use 'd' to encode / decode blob size --- fsdev/9p-iov-marshal.c | 26 ++ fsdev/9p-marsh

[Qemu-devel] [PATCH v3 3/3] 9pfs: introduce V9fsVirtioState

2016-01-11 Thread Wei Liu
V9fsState now only contains generic fields. Introduce V9fsVirtioState for virtio transport. Change virtio-pci and virtio-ccw to use V9fsVirtioState. Signed-off-by: Wei Liu --- v3: only include code to introduce V9fsVirtioState --- hw/9pfs/9p.c | 6 ++-- hw/9pfs/9p.h

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: disentangling virtio and generic code

2016-01-11 Thread Wei Liu
I forgot to mention -- this series can be pulled from: git://xenbits.xen.org/people/liuw/qemu.git wip.9pfs-refactor-v3 Wei.

Re: [Qemu-devel] [Qemu-block] [PATCH] send readcapacity10 when readcapacity16 failed

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 09:49, Peter Lieven wrote: > > +if (task != NULL && task->status == SCSI_STATUS_CHECK_CONDITION > > +&& task->sense.key == SCSI_SENSE_UNIT_ATTENTION) { > > +break; > > +} > > Paolo, Ronnie, do you know what Readcapacity(10) ret

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Hao, Xudong
Stefano, Patch http://marc.info/?l=qemu-devel&m=145137863501079 don't works for qemu at all, some conflict when git apply. Patch http://marc.info/?l=qemu-devel&m=145137863501079 is based on patch http://marc.info/?l=qemu-devel&m=145172165010604, right? I can boot up Linux VM with IGD pass-thr

Re: [Qemu-devel] [RFC v6 11/14] softmmu: Simplify helper_*_st_name, wrap MMIO code

2016-01-11 Thread Alex Bennée
Alvise Rigo writes: > Attempting to simplify the helper_*_st_name, wrap the MMIO code into an > inline function. > > Suggested-by: Jani Kokkonen > Suggested-by: Claudio Fontana > Signed-off-by: Alvise Rigo > --- > softmmu_template.h | 64 > +--

Re: [Qemu-devel] [RFC v6 11/14] softmmu: Simplify helper_*_st_name, wrap MMIO code

2016-01-11 Thread alvise rigo
On Mon, Jan 11, 2016 at 10:54 AM, Alex Bennée wrote: > > Alvise Rigo writes: > >> Attempting to simplify the helper_*_st_name, wrap the MMIO code into an >> inline function. >> >> Suggested-by: Jani Kokkonen >> Suggested-by: Claudio Fontana >> Signed-off-by: Alvise Rigo >> --- >> softmmu_temp

Re: [Qemu-devel] [PATCH v2 5/7] hw/arm/sysbus-fdt: helpers for clock node generation

2016-01-11 Thread Eric Auger
Hi David, On 01/11/2016 03:41 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:23PM +, Eric Auger wrote: >> Some passthrough'ed devices depend on clock nodes. Those need to be >> generated in the guest device tree. This patch introduces some helpers >> to build a clock node from informat

Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state

2016-01-11 Thread Denis V. Lunev
On 12/16/2015 05:47 PM, Denis V. Lunev wrote: On 12/16/2015 03:02 PM, Paolo Bonzini wrote: On 16/12/2015 10:50, Peter Krempa wrote: We check that the state is "paused" and continue the vCPUs only in that case. The panic devices will move the VM to 'crashed' state. The code that is issuing 'sys

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Gerd Hoffmann
Hi, > I can boot up Linux VM with IGD pass-through with latest qemu (without > any additional patch), guest run 3D "nexuiz" and get 180fps. That is a pretty recent linux guest I assume? Tried older kernels too, possibly even the old userspace xorg driver? Do windows guest work as well? cheers

Re: [Qemu-devel] [PATCH v2 3/7] device_tree: introduce qemu_fdt_node_path

2016-01-11 Thread Eric Auger
Hi David, On 01/11/2016 03:38 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:21PM +, Eric Auger wrote: >> This new helper routine returns the node path of a device >> referred to by its node name and compat string. > > What if there are multiple nodes matching the name and compat? The

Re: [Qemu-devel] [Qemu-block] [PATCH V5] block/nfs: add support for setting debug level

2016-01-11 Thread Jeff Cody
On Mon, Jan 11, 2016 at 09:51:39AM +0100, Peter Lieven wrote: > Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: > >> recent libnfs versions support logging debug messages. Add > >> support for it in qemu through an URL parameter. > >

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Stefano Stabellini
On Mon, 11 Jan 2016, Hao, Xudong wrote: > Stefano, > > Patch http://marc.info/?l=qemu-devel&m=145137863501079 don't works for qemu > at all, some conflict when git apply. > Patch http://marc.info/?l=qemu-devel&m=145137863501079 is based on patch > http://marc.info/?l=qemu-devel&m=1451721650106

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 10:46:20AM +, Stefano Stabellini wrote: > On Mon, 11 Jan 2016, Hao, Xudong wrote: > > Stefano, > > > > Patch http://marc.info/?l=qemu-devel&m=145137863501079 don't works for qemu > > at all, some conflict when git apply. > > Patch http://marc.info/?l=qemu-devel&m=145

Re: [Qemu-devel] [PATCH 12/25] target-sparc: Add MMU_REAL_IDX

2016-01-11 Thread Artyom Tarasenko
Hi Richard, first of all, this is a very nice series. I really enjoy reading it, thank you very much. It makes the code is more readable and likely to be more performant. A nitpick below. On Thu, Dec 17, 2015 at 9:57 PM, Richard Henderson wrote: > This gives us a trivial way to access physical a

Re: [Qemu-devel] [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

2016-01-11 Thread Eric Auger
Hi David, On 01/11/2016 03:45 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:25PM +, Eric Auger wrote: >> qemu_fdt_setprop self-exists in case of error hence no need to check >> the returned value. >> >> Signed-off-by: Eric Auger > > This change is fine, but in general I'm disincline

Re: [Qemu-devel] [PULL 00/11] Ide patches

2016-01-11 Thread Peter Maydell
On 9 January 2016 at 00:51, John Snow wrote: > The following changes since commit 38a762fec63fd5c035aae29ba9a77d357e21e4a7: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-crypto-fixes-2015-12-23-1' into staging > (2015-12-23 13:53:32 +) > > are available in the git reposito

Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 11:31, Denis V. Lunev wrote: >>> >>> IMO, after a reset, main_loop_should_exit should actually transition >>> to VM_STATE_PRELAUNCH (*not* RUN_STATE_PAUSED) for *all* states except >>> RUN_STATE_INMIGRATE, RUN_STATE_SAVE_VM (which I think cannot happen >>> there) and (of course) RUN

Re: [Qemu-devel] [PULL v2 00/59] acpi dsdt rework, misc fixes

2016-01-11 Thread Peter Maydell
On 9 January 2016 at 21:39, Michael S. Tsirkin wrote: > The following changes since commit 6bb9ead762bf749af11ea225fc2a74db1b93c105: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160108-1' into > staging (2016-01-08 12:50:19 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH 12/25] target-sparc: Add MMU_REAL_IDX

2016-01-11 Thread Artyom Tarasenko
On Mon, Jan 11, 2016 at 12:15 PM, Artyom Tarasenko wrote: > Hi Richard, > > first of all, this is a very nice series. > I really enjoy reading it, thank you very much. > It makes the code is more readable and likely to be more performant. > A nitpick below. > > On Thu, Dec 17, 2015 at 9:57 PM, Ric

Re: [Qemu-devel] [PATCH 0/2] checkpatch: Fixing two cases of false positives in checkpatch.pl

2016-01-11 Thread Markus Armbruster
Copying Paolo. Leonid Bloch writes: > This series addresses two cases where errors were printed if whitespaces > appeared in front of a square bracket in places where there should be no > problem with such placements (please see messages of individual commits). > > Leonid Bloch (2): > checkpat

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-01-11 Thread Laszlo Ersek
On 01/11/16 09:26, Gerd Hoffmann wrote: > On Fr, 2016-01-08 at 19:32 +0100, Laszlo Ersek wrote: >> On 01/08/16 18:45, Igor Mammedov wrote: >>> On Fri, 8 Jan 2016 13:58:03 +0100 >>> Gerd Hoffmann wrote: >>> This patch extends the functionality of the max-ram-below-4g option to also allow

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2016-01-11 Thread Vladimir Sementsov-Ogievskiy
On 05.01.2016 02:16, John Snow wrote: Since Max didn't offer a grammatical review, here's my attempt at some suggestions. On 12/23/2015 12:49 PM, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. I

Re: [Qemu-devel] [PATCH 1/2] create ga_run_program() helper for guest-set-user-password

2016-01-11 Thread Yuriy Pudgorodskiy
On 1/6/2016 4:50 PM, Denis V. Lunev wrote: hmmm Yur, it seems that you have re-invented the wheel with gboolean g_spawn_sync (/|const gchar *wor

[Qemu-devel] [PATCH] hw/pci: do not update the PCI mappings while Decode (I/O or memory) bit is not set in the Command register

2016-01-11 Thread Marcel Apfelbaum
Two reasons: - PCI Spec indicates that while the bit is not set the memory sizing is not finished. - pci_bar_address will return PCI_BAR_UNMAPPED and a previous value can be accidentally overridden if the command register is modified (and not the BAR). Signed-off-by: Marcel Apfelbaum -

Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-01-11 Thread Marcel Apfelbaum
On 01/08/2016 02:58 PM, Gerd Hoffmann wrote: This patch extends the functionality of the max-ram-below-4g option to also allow increasing lowmem. Use case: Give as much memory as possible to legacy non-PAE guests. While being at it also rework the lowmem calculation logic and add a longish comm

Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 08:23, P J P wrote: > Hello, > > +-- On Wed, 6 Jan 2016, P J P wrote --+ > | When processing firmware configurations, an OOB r/w access occurs > | if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x). > | Add a check to validate 's->cur_entry' to avoid such access. > |

Re: [Qemu-devel] [PULL 00/16] ppc-for-2.6 queue 20160111

2016-01-11 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160111 > > for you to fetch changes up to 87bbdd9cafe58ce50d462307394d51af98d50d74: > > hw/ppc/spapr: fix spapr->kvm_type leak (2016-01-11 15:29:05 +1100) > > ---

Re: [Qemu-devel] [PATCH] sdl: shorten the GUI refresh interval when mouse or keyboard is active

2016-01-11 Thread Markus Armbruster
Copying maintainer. You can find people to copy by feeding your patch to scripts/get_maintainer.pl. Jindřich Makovička writes: > Hi, > > some years ago, I submitted a patch improving the mouse response in SDL > ui, but it got lost under the sands of time. Here is an updated version > for both S

[Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription

2016-01-11 Thread Peter Maydell
This patchset updates target-sparc to use VMStateDescription rather than hand-written save/load functions. (SPARC is the very last target still using the old approach. Once this patchset gets in via the sparc tree I'll send out the patches to clean up the core QOM CPU code to remove the unused supp

[Qemu-devel] [PATCH v2 7/8] target-sparc: Use VMState arrays for SPARC64 TLB/MMU state

2016-01-11 Thread Peter Maydell
Use VMState arrays for SPARC64 TLB/MMU state. This is a migration-break for SPARC64 (but not for SPARC32), which is acceptable because currently migration does not work for any SPARC64 machines due to the lack of any migration of interrupt controller state. Signed-off-by: Peter Maydell --- This p

[Qemu-devel] [PATCH v2 6/8] target-sparc: Convert to VMStateDescription

2016-01-11 Thread Peter Maydell
From: Juan Quintela Convert the SPARC CPU from cpu_load/save functions to VMStateDescription. We preserve migration compatibility with the previous version (required for SPARC32 but not necessarily for SPARC64). Signed-off-by: Juan Quintela [PMM: * Rebase and update to apply to master * VMSTA

[Qemu-devel] [PATCH v4] qemu-char: add logfile facility to all chardev backends

2016-01-11 Thread Daniel P. Berrange
Typically a UNIX guest OS will log boot messages to a serial port in addition to any graphical console. An admin user may also wish to use the serial port for an interactive console. A virtualization management system may wish to collect system boot messages by logging the serial port, but also wis

Re: [Qemu-devel] [PATCH COLO-Frame v12 10/38] COLO: Implement colo checkpoint protocol

2016-01-11 Thread Markus Armbruster
Hailiang Zhang writes: > Hi Markus, > > On 2015/12/19 16:54, Markus Armbruster wrote: >> Jumping in at v12 for a bit of QAPI review (and whatever else catched my >> eye nearby), please pardon my ignorance of COLO in general, and previous >> review of this series in particular. >> > > Thanks all t

[Qemu-devel] [PATCH v2 2/8] vmstate: Introduce VMSTATE_VARRAY_MULTPLY

2016-01-11 Thread Peter Maydell
From: Juan Quintela This allows to send a partial array where the size is another structure field multiplied by a constant. Signed-off-by: Juan Quintela [PMM: updated to current master] Signed-off-by: Peter Maydell --- include/migration/vmstate.h | 11 +++ migration/vmstate.c

[Qemu-devel] [PATCH v2 3/8] vmstate: define vmstate_info_uinttl

2016-01-11 Thread Peter Maydell
From: Juan Quintela We are going to define arrays of this type, so we need the integer type. Signed-off-by: Juan Quintela [PMM: updated to apply on current QEMU; renamed to 'uinttl' rather than 'uinttls' to match other vmstate naming] Signed-off-by: Peter Maydell --- include/hw/hw.h | 2 ++

[Qemu-devel] [PATCH v2 1/8] vmstate: introduce CPU_DoubleU arrays

2016-01-11 Thread Peter Maydell
From: Juan Quintela Add vmstate support for migrating arrays of CPU_DoubleU via VMSTATE_CPUDOUBLE_ARRAY. Signed-off-by: Juan Quintela [PMM: rebased, since files have all moved since 2012; added VMSTATE_CPUDOUBLE_ARRAY_V for consistency with FLOAT64] Signed-off-by: Peter Maydell --- include/m

[Qemu-devel] [PATCH v2 4/8] target-sparc: Split cpu_put_psr into side-effect and no-side-effect parts

2016-01-11 Thread Peter Maydell
For inbound migration we really want to be able to set the PSR without having any side effects, but cpu_put_psr() calls cpu_check_irqs() which might try to deliver CPU interrupts. Split cpu_put_psr() into the no-side-effect and side-effect parts. This includes reordering the cpu_check_irqs() to th

[Qemu-devel] [PATCH v2 8/8] target-sparc: Migrate CWP and PIL for SPARC64

2016-01-11 Thread Peter Maydell
In SPARC32 the env->cwp and env->psrpil state is part of the PSR register, and gets migrated as part of that register. In SPARC64 this state is in separate CWP and PIL registers, but we were not doing anything to migrate those. Add the missing fields to the migration vmstate (which is a migration

[Qemu-devel] [PATCH v2 5/8] target-sparc: Don't flush TLB in cpu_load function

2016-01-11 Thread Peter Maydell
There's no need to flush the TLB in the SPARC cpu_load function: we're guaranteed to be loading state into a fresh clean configuration. Signed-off-by: Peter Maydell --- target-sparc/machine.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target-sparc/machine.c b/target-sparc/machine.c ind

Re: [Qemu-devel] [RFC PATCH v2 02/10] Jhash: add linux kernel jhashtable in qemu

2016-01-11 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 01/08/2016 08:08 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>From: zhangchen > >> > >>Jhash used by colo-proxy to save and lookup > >>net connection info > >> > >>Signed-off-by: zhangche

Re: [Qemu-devel] [PULL 00/24] Net patches

2016-01-11 Thread Peter Maydell
On 11 January 2016 at 05:30, Jason Wang wrote: > The following changes since commit 6bb9ead762bf749af11ea225fc2a74db1b93c105: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160108-1' into > staging (2016-01-08 12:50:19 +) > > are available in the git repository at: > > ht

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-11 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 01/08/2016 07:19 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>From: zhangchen > >> > >>Hi,all > >> > >>This patch add an colo-proxy object, COLO-Proxy is a part of COLO, > >>based on qemu

[Qemu-devel] [PATCH] spec: add qcow2 bitmaps extension specification

2016-01-11 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such bitmaps: Dirty Tracking Bitmap, which just tracks virtual disk change

Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

2016-01-11 Thread Riku Voipio
On torstaina 24. joulukuuta 2015 11.54.09 EET, Laurent Vivier wrote: Le 24/12/2015 02:07, cheng...@emindsoft.com.cn a écrit : From: Chen Gang In this case, real_end is larger than end, which may cause mmap_frag process the incorrect memory region. Signed-off-by: Chen Gang --- ... The frag

Re: [Qemu-devel] [PATCH] spec: add qcow2 bitmaps extension specification

2016-01-11 Thread Vladimir Sementsov-Ogievskiy
Sorry for this. Just ignore it, I'll resend with version number, to have consistent subjects in discussion. On 11.01.2016 16:00, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an abi

Re: [Qemu-devel] [PATCH v2 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone

2016-01-11 Thread Peter Maydell
Ping again (though I know Paolo said on IRC he'd put this on his list to look at). I have a rebased branch at https://git.linaro.org/people/peter.maydell/qemu-arm.git multi-ases-2 but the only differences are some minor fixes to conflicts in the virt board patches following the GPIO device going

[Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification

2016-01-11 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such bitmaps: Dirty Tracking Bitmap, which just tracks virtual disk change

[Qemu-devel] [PATCH] io: some fixes to handling of /dev/null when running commands

2016-01-11 Thread Daniel P. Berrange
The /dev/null file handle was leaked in a couple of places. There is also the possibility that both readfd and writefd point to the same /dev/null file handle, so care must be taken not to close the same file handle twice. Signed-off-by: Daniel P. Berrange --- io/channel-command.c | 22 +

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-11 Thread Peter Maydell
Ping for review, please? thanks -- PMM On 7 December 2015 at 16:23, Peter Maydell wrote: > We've had some discussion previously (on list and IRC) about adding an > include of "qemu/osdep.h" to everything. The basic idea is that every > .c file should include "qemu/osdep.h" as its first include;

  1   2   3   4   5   >