Re: [Qemu-devel] [PATCH 03/13] block: Move block dirty bitmap code to separate files

2016-01-05 Thread John Snow
On 01/04/2016 05:27 AM, Fam Zheng wrote: > The only change is making bdrv_dirty_bitmap_truncate public. It is used in > block.c. > > Signed-off-by: Fam Zheng > --- > block.c | 339 --- > block/Makefile.objs | 2 +- > block/dir

Re: [Qemu-devel] [PATCH 04/13] block: Remove unused typedef of BlockDriverDirtyHandler

2016-01-05 Thread John Snow
On 01/04/2016 05:27 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > include/block/block.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/block/block.h b/include/block/block.h > index 97e9b5e..0f42964 100644 > --- a/include/block/block.h > +++ b/include/block/block.h

Re: [Qemu-devel] [PATCH v8 14/35] qapi: Swap visit_* arguments for consistent 'name' placement

2016-01-05 Thread Eric Blake
On 01/05/2016 08:32 AM, Eric Blake wrote: >> >> However, docs/qapi-code-gen.txt should be updated in a follow-up patch. > > D'oh - I knew I'd forget something :) You're right, of course. For that matter, several recent patches have tweaked generated code without updating the docs, such as 9f08c

Re: [Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-05 Thread John Snow
Should we skip adding the typedef for HBitmapIter if we're just going to use this instead? On 01/04/2016 05:27 AM, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should be > hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying > HBi

Re: [Qemu-devel] [PATCH 08/17] isa: add an ISA DMA interface, and store it within the ISA bus

2016-01-05 Thread John Snow
On 12/29/2015 03:04 AM, Hervé Poussineau wrote: > This will permit to deprecate global DMA_*() functions. > > Signed-off-by: Hervé Poussineau > --- > hw/isa/isa-bus.c| 21 + > include/hw/isa/isa.h| 38 ++ > include/qemu/typede

[Qemu-devel] [PATCH v8 14.5/35] qapi: Update docs to match recent generator changes

2016-01-05 Thread Eric Blake
Several commits have been changing the generator, but not updating the docs to match (an obvious one is commit 9f08c8ec that made list types lazy, and thereby dropped UserDefOneList). Rework the example to show slightly more output (we don't want to show too much; that's what the testsuite is for)

[Qemu-devel] Clang -Werror build fails against spice-server-devel 0.12.6-1.fc22

2016-01-05 Thread John Snow
Just as a heads up: /home/bos/jhuston/src/qemu/hw/display/qxl.c:1071:6: error: 'set_mm_time' is deprecated [-Werror,-Wdeprecated-declarations] .set_mm_time = interface_set_mm_time, ^ /usr/include/spice-server/spice-qxl.h:162:12: note: 'set_mm_time' has been explicitly marked d

Re: [Qemu-devel] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-05 Thread John Snow
On 01/04/2016 05:27 AM, Fam Zheng wrote: > Upon each bit toggle, the corresponding bit in the meta bitmap will be > set. > > Signed-off-by: Fam Zheng > --- > include/qemu/hbitmap.h | 8 +++ > util/hbitmap.c | 61 > +- > 2 files chan

Re: [Qemu-devel] [PATCH v8 14.5/35] qapi: Update docs to match recent generator changes

2016-01-05 Thread Eric Blake
On 01/05/2016 05:01 PM, Eric Blake wrote: > Several commits have been changing the generator, but not updating > the docs to match (an obvious one is commit 9f08c8ec that made > list types lazy, and thereby dropped UserDefOneList). Rework the > example to show slightly more output (we don't want t

Re: [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/enum visit

2016-01-05 Thread Eric Blake
On 12/21/2015 10:08 AM, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the arg

Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups

2016-01-05 Thread Alistair Francis
On Tue, Jan 5, 2016 at 7:32 AM, Andrew Jones wrote: > On Tue, Jan 05, 2016 at 07:07:22AM -0700, Eric Blake wrote: >> On 01/05/2016 06:22 AM, Andrew Jones wrote: >> > (Found by grepping for broken PRI users.) >> > >> > Signed-off-by: Andrew Jones >> > --- >> > hw/dma/xilinx_axidma.c | 8

Re: [Qemu-devel] [PATCH v3 4/7] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2016-01-05 Thread Alistair Francis
On Thu, Dec 31, 2015 at 4:31 PM, Andrew Baumann wrote: > This device maintains all the non-CPU peripherals on bcm2835 (Pi1) > which are also present on bcm2836 (Pi2). It also implements the > private address spaces used for DMA and mailboxes. > > Signed-off-by: Andrew Baumann > --- > > Notes: >

Re: [Qemu-devel] [v15 12/15] vfio: add bus in reset flag

2016-01-05 Thread Chen Fan
On 01/06/2016 03:58 AM, Alex Williamson wrote: On Tue, 2016-01-05 at 09:20 +0800, Cao jin wrote: From: Chen Fan mark the host bus be in reset. avoid multiple devices trigger the host bus reset many times. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 6 ++ include/hw/vf

[Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init()

2016-01-05 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen_pt.c | 7 --- hw/xen/xen_pt.h | 2 +- hw/xen/xen_pt_config_init.c | 51 - 3 files changed, 32 insertions(+), 28 deletions(-) diff --git

[Qemu-devel] [PATCH v3 0/4] Convert to realize()

2016-01-05 Thread Cao jin
v3 changelog: 1. use following style when we want to check the returned error Error *err = NULL; foo(arg, &err); if (err) { handle the error... error_propagate(errp, err); } Cao jin (4): Add Error **errp for xen_host_pci_device_get() Add Error **errp for

[Qemu-devel] [PATCH v3 1/4] Add Error **errp for xen_host_pci_device_get()

2016-01-05 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen-host-pci-device.c | 106 +-- hw/xen/xen-host-pci-device.h | 5 +- hw/xen/xen_pt.c | 12 +++-- 3 files changed, 71 insertions(+), 52 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga()

2016-01-05 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin Reviewed-by: Stefano Stabellini --- hw/xen/xen_pt.c | 5 - hw/xen/xen_pt.h | 3 ++- hw/xen/xen_pt_graphics.c | 11 ++- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/xen/xen

[Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize()

2016-01-05 Thread Cao jin
Signed-off-by: Cao jin Reviewed-by: Stefano Stabellini --- hw/xen/xen_pt.c | 53 - 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 3787c26..b058f61 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xe

Re: [Qemu-devel] [PATCH v2] l2tpv3: fix cookie decoding

2016-01-05 Thread Jason Wang
On 01/05/2016 07:26 AM, Alexis Dambricourt wrote: > If a 32 bits l2tpv3 frame cookie MSB if set to 1, the cast to uint64_t > cookie will spread 1 to the four most significant bytes. > Then the condition (cookie != s->rx_cookie) becomes false. > > Signed-off-by: Alexis Dambricourt > --- > net/l2

Re: [Qemu-devel] qcow2 snapshot + resize

2016-01-05 Thread lihuiba
At 2016-01-05 21:55:56, "Eric Blake" wrote: >On 01/05/2016 05:10 AM, lihuiba wrote: > In our production environment, we need to extend a qcow2 image with snapshots in it. > >>> The thing is that one would need to update all the inactive L1 tables. I >>> don't think it should be too diffi

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-05 Thread Jason Wang
On 01/04/2016 07:17 PM, Zhang Chen wrote: > > > On 01/04/2016 05:46 PM, Jason Wang wrote: >> >> On 01/04/2016 04:16 PM, Zhang Chen wrote: >>> >>> On 01/04/2016 01:37 PM, Jason Wang wrote: On 12/31/2015 04:40 PM, Zhang Chen wrote: > On 12/31/2015 10:36 AM, Jason Wang wrote: >> On 12/2

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-05 Thread Jason Wang
On 01/05/2016 12:52 AM, Dr. David Alan Gilbert wrote: > * Jason Wang (jasow...@redhat.com) wrote: >> >> On 01/04/2016 04:16 PM, Zhang Chen wrote: >>> >>> On 01/04/2016 01:37 PM, Jason Wang wrote: On 12/31/2015 04:40 PM, Zhang Chen wrote: > On 12/31/2015 10:36 AM, Jason Wang wrote: >>

Re: [Qemu-devel] [PATCH v3 4/7] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2016-01-05 Thread Andrew Baumann
> From: Alistair Francis [mailto:alistai...@gmail.com] > Sent: Tuesday, 5 January 2016 18:14 > On Thu, Dec 31, 2015 at 4:31 PM, Andrew Baumann > wrote: > > This device maintains all the non-CPU peripherals on bcm2835 (Pi1) > > which are also present on bcm2836 (Pi2). It also implements the > > pri

[Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-05 Thread P J P
From: Prasad J Pandit When processing firmware configurations, an OOB r/w access occurs if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x). Add a check to validate 's->cur_entry' to avoid such access. Reported-by: Donghai Zdh Signed-off-by: Prasad J Pandit --- hw/nvram/fw_cfg.c | 1

Re: [Qemu-devel] [PATCH for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-05 Thread P J P
+-- On Tue, 5 Jan 2016, Stefan Weil wrote --+ | > -s->cur_offset < e->len) { | > +if (s->cur_entry != FW_CFG_INVALID | > +&& s->cur_entry & FW_CFG_WRITE_CHANNEL | > +&& e->callback | > +&& s->cur_offset < e->len) { | | I suggest to test e != NULL instead of s->c

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-05 Thread Gerd Hoffmann
On Di, 2016-01-05 at 15:44 +0100, sL1pKn07 SpinFlo wrote: > 2016-01-05 9:06 GMT+01:00 Jonathan Scruggs : > > I notice no bugs as of yet. > > Hi > I found one (if can call that) bug > > I use a physical USB switch for share the K/M with other PC > when switch to other pc, lost the signal. How doe

<    1   2   3