On Fri, 18 Dec 2015, Stefano Stabellini wrote:
> On Wed, 2 Dec 2015, Michael S. Tsirkin wrote:
> > On Wed, Dec 02, 2015 at 05:16:18PM +, Stefano Stabellini wrote:
> > > On Wed, 2 Dec 2015, Michael S. Tsirkin wrote:
> > > > On Wed, Dec 02, 2015 at 04:56:21PM +, Stefano Stabellini wrote:
> >
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> Rework the control flow of balloon_stats_get_all() to make it
> easier for a later patch to split visit_end_struct(). Also
> switch to the uint64 visitor to match the data type.
>
Looks like the i64 -> u64 change is safe. virtio_balloon_st
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> Our qapi visitor contract supports multiple integer visitors,
> but left the type_uint64 visitor as optional (falling back on
> type_int64); it also marks the type_size visitor as optional
> (falling back on type_uint64 or even type_int64).
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> C compilers are allowed to represent enums as a smaller type
> than int, if all enum values fit in the smaller type. There
> are even compiler flags that force the use of this smaller
> representation, and using them changes the ABI of a bi
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> Cache the visitor in a local variable instead of repeatedly
> calling the accessor. Pass NULL for the visit_start_struct()
> object (which matches the fact that we were already passing 0
> for the size argument, because we aren't using the
On 05/01/2016 14:20, Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones
> ---
> trace-events | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 6f036384a84f8..e42898d5659d5 100
From: Prasad J Pandit
Hello,
An OOB r/w access issue was reported by Mr Donghai Zdh, CC'd here. It occurs
while processing firmware configurations in Qemu versions prior to 2.4. The
OOB memory access crashes the Qemu process on the host.
Please see below a (tested)patch to fix this issue. Does
From: Prasad J Pandit
When processing firmware configurations, an OOB r/w access occurs
if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x).
Add a check to validate 's->cur_entry' to avoid such access.
Reported-by: Donghai Zdh
Signed-off-by: Prasad J Pandit
---
hw/nvram/fw_cfg.c | 1
On 01/05/2016 07:07 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> All other successful clients of visit_start_struct() were paired
>> with an unconditional visit_end_struct(); but the generated
>> code for events was relying on qmp_output_visitor_clea
On 01/05/2016 07:06 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> C compilers are allowed to represent enums as a smaller type
>> than int, if all enum values fit in the smaller type. There
>> are even compiler flags that force the use of this smalle
On Tue, Jan 05, 2016 at 03:54:48PM +0100, Laurent Vivier wrote:
>
>
> On 05/01/2016 14:20, Andrew Jones wrote:
> > Fixes compiling with --enable-trace-backends
> >
> > Signed-off-by: Andrew Jones
> > ---
> > trace-events | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
When building all targets, I get tons of warnings like below:
./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
./trace/generated-tracers.h:17551:25: warning: too many arguments for format
[-Wformat-extra-args]
, env, sc_psw_addr, env_psw_addr);
2016-01-04 14:19 GMT+01:00 Jonathan Scruggs :
> Oh. I just changed /dev/input/eventx (replace x with correct number for my
> devices) to permissions of 666 and it worked. I guess I had to change the
> conf file and change the permissions. Is there a way to make the devices
> work with qemu? The per
2016-01-04 11:10 GMT+01:00 Jonathan Scruggs :
> Hi,
>
> I tried these patches with qemu 2.5.0 on Gentoo and libvirt. I get the
> following error:
> Error starting domain: internal error: early end of file from monitor:
> possible problem:
> 2015-12-22T21:51:20.659520Z qemu-system-x86_64: -input-lin
> libvirt uses cgroups to restrict qemu. You can tweak cgroup_controllers
> in /etc/libvirt/qemu.conf, when you remove "devices" controller it
> should work (unless something else like selinux or apparmor applies
> additional restrictions).
>
> HTH,
> Gerd
like this?
# What cgroup controllers
On Tue, Jan 05, 2016 at 07:07:22AM -0700, Eric Blake wrote:
> On 01/05/2016 06:22 AM, Andrew Jones wrote:
> > (Found by grepping for broken PRI users.)
> >
> > Signed-off-by: Andrew Jones
> > ---
> > hw/dma/xilinx_axidma.c | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
>
2016-01-05 9:06 GMT+01:00 Jonathan Scruggs :
> I notice no bugs as of yet.
Hi
I found one (if can call that) bug
I use a physical USB switch for share the K/M with other PC
when switch to other pc, lost the signal. this is ok. but the VM start
stutter (the sounds and videos), and when is back, ca
On 01/05/2016 07:06 AM, Marc-André Lureau wrote:
> Reviewed-by: Marc-André Lureau Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> JSON uses "name":value, but many of our visitor interfaces were
>> called with visit_type_FOO(v, &value, name, errp). This can be
>> a bit confusing to h
On 01/05/2016 08:24 AM, Andrew Jones wrote:
>>
>> I think there are too many quotes. This looks more correct:
>>
>> "env=%p frame_addr=0x%"PRIx64
>
> You're right. The trailing null strings don't break compilation, but don't do
> anything either.
>
> I'll send a v2 with those removed.
>
No nee
Fixes compiling with --enable-trace-backends
Signed-off-by: Andrew Jones
---
v2: also remove trailing null strings [Laurent]
trace-events | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/trace-events b/trace-events
index 6f036384a84f8..98ec748270a39 100644
--- a/t
On 05/01/2016 16:37, Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones
> ---
> v2: also remove trailing null strings [Laurent]
>
>
> trace-events | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/trace-events
On 01/05/2016 08:37 AM, Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones
> ---
> v2: also remove trailing null strings [Laurent]
>
>
> trace-events | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Duplicate of:
https://lists.
On 01/05/2016 07:05 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> No backend was setting an error when ending the visit of a list
>> or implicit struct. Make the callers a bit easier to follow by
>> making this a part of the contract, and removing th
On Tue, 5 Jan 2016 08:52:39 -0700
Eric Blake wrote:
> On 01/05/2016 08:29 AM, Greg Kurz wrote:
> > When building all targets, I get tons of warnings like below:
> >
> > ./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
> > ./trace/generated-tracers.h:17551:25: warning:
In vfio_listener_region_add(), the code makes sure
that the offset in the section is lower than the size
of the section.
But the calculation uses size of the region instead of
the region's limit (size - 1).
This leads to Int128 overflow when the region has
been initialized to UINT64_MAX because in
On 01/05/2016 08:29 AM, Greg Kurz wrote:
> When building all targets, I get tons of warnings like below:
>
> ./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
> ./trace/generated-tracers.h:17551:25: warning: too many arguments for format
> [-Wformat-extra-args]
>
On 01/05/2016 07:05 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> Right now, qmp-output-visitor happens to produce a QNull result
>> if nothing is actually visited between the creation of the visitor
>> and the request for the resulting QObject. A st
Alvise Rigo writes:
> Add a new TLB flag to force all the accesses made to a page to follow
> the slow-path.
>
> In the case we remove a TLB entry marked as EXCL, we unset the
> corresponding exclusive bit in the bitmap.
>
> Suggested-by: Jani Kokkonen
> Suggested-by: Claudio Fontana
> Signed-
On 01/05/2016 07:04 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> And use it in qapi-types and qapi-event. Down the road, we may
>> want to lift our artificial restriction of no variants at the
>> top level of an event, at which point, inlining our c
On Tue, Jan 5, 2016 at 1:40 AM, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2016 at 07:11:25PM -0800, Alexander Duyck wrote:
>> >> The two mechanisms referenced above would likely require coordination with
>> >> QEMU and as such are open to discussion. I haven't attempted to address
>> >> them as
Hi Peter,
On 12/18/2015 03:36 PM, Peter Maydell wrote:
> On 17 December 2015 at 12:29, Eric Auger wrote:
>> Current qemu_fdt_getprop exits if the property is not found. It is
>> sometimes needed to read an optional property, in which case we do
>> not wish to exit but simply returns a null value.
Hi Peter,
On 12/18/2015 03:23 PM, Peter Maydell wrote:
> On 17 December 2015 at 12:29, Eric Auger wrote:
>> This new helper routine returns the node path of a device
>> referred to by its node name and compat string.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
>>
>> RFC -> v1:
>> - improve error ha
Cc'ing Peter because we'd like this patch to go directly to the master branch.
On Tue, 5 Jan 2016 16:37:35 +0100
Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones
> ---
> v2: also remove trailing null strings [Laurent]
>
>
Reviewed-by: Greg
On Wed, 30 Dec 2015 21:52:32 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Dec 30, 2015 at 04:55:54PM +0100, Igor Mammedov wrote:
> > On Mon, 28 Dec 2015 14:50:15 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Dec 28, 2015 at 10:39:04AM +0800, Xiao Guangrong wrote:
> > > >
> > > > H
Alvise Rigo writes:
> Allow each architecture to set the exclusive range at any LoadLink
> operation through a CPUClass hook.
nit: space or continue paragraph.
> This comes in handy to emulate, for instance, the exclusive monitor
> implemented in some ARM architectures (more precisely, the Exc
On Tue, Jan 05, 2016 at 05:30:25PM +0100, Igor Mammedov wrote:
> > > bios-linker-loader is a great interface for initializing some
> > > guest owned data and linking it together but I think it adds
> > > unnecessary complexity and is misused if it's used to handle
> > > device owned data/on device
On 12/18/2015 03:54 PM, Peter Maydell wrote:
> On 17 December 2015 at 12:29, Eric Auger wrote:
>> Some passthrough'ed devices depend on clock nodes. Those need to be
>> generated in the guest device tree. This patch introduces some helpers
>> to build a clock node from information retrieved in the
On 01/05/16 17:43, Michael S. Tsirkin wrote:
> On Tue, Jan 05, 2016 at 05:30:25PM +0100, Igor Mammedov wrote:
bios-linker-loader is a great interface for initializing some
guest owned data and linking it together but I think it adds
unnecessary complexity and is misused if it's used
On Mon, 4 Jan 2016 21:17:31 +0100
Laszlo Ersek wrote:
> Michael CC'd me on the grandparent of the email below. I'll try to add
> my thoughts in a single go, with regard to OVMF.
>
> On 12/30/15 20:52, Michael S. Tsirkin wrote:
> > On Wed, Dec 30, 2015 at 04:55:54PM +0100, Igor Mammedov wrote:
On 01/06/2016 12:43 AM, Michael S. Tsirkin wrote:
Yes - if address is static, you need to put it outside
the table. Can come right before or right after this.
Also if OperationRegion() is used, then one has to patch
DefOpRegion directly as RegionOffset must be Integer,
using variable names i
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> By sticking the next pointer first, we don't need a union with
> 64-bit padding for smaller types. On 32-bit platforms, this
> can reduce the size of uint8List from 16 bytes (or 12, depending
> on whether 64-bit ints can tolerate 4-byte ali
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> Returning a partial object on error is an invitation for a careless
> caller to leak memory. As no one outside the testsuite was actually
> relying on these semantics, it is cleaner to just document and
> guarantee that ALL pointer-based vi
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> We have two uses of list visits in the entire code base: one in
> spapr_drc (which completely avoids visit_next_list(), feeding in
> integers from a different source than uint8List), and one in
> qapi-visit.py (that is, all other list visito
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> As mentioned in previous patches, we want to call visit_end_struct()
> functions unconditionally, so that visitors can release resources
> tied up since the matching visit_start_struct() without also having
> to worry about error priority if
On 01/05/16 18:08, Igor Mammedov wrote:
> On Mon, 4 Jan 2016 21:17:31 +0100
> Laszlo Ersek wrote:
>
>> Michael CC'd me on the grandparent of the email below. I'll try to add
>> my thoughts in a single go, with regard to OVMF.
>>
>> On 12/30/15 20:52, Michael S. Tsirkin wrote:
>>> On Wed, Dec 30,
On Tue, Jan 5, 2016 at 5:10 PM, Alex Bennée wrote:
>
> Alvise Rigo writes:
>
>> Add a new TLB flag to force all the accesses made to a page to follow
>> the slow-path.
>>
>> In the case we remove a TLB entry marked as EXCL, we unset the
>> corresponding exclusive bit in the bitmap.
>>
>> Suggeste
The IPMI BMC simulator populates the SDR table with a set of initial
SDRs. The length of each SDR is taken from the record itself (byte 4)
which does not include the size of the header. But, the full length
(header + data) is required by the sdr_add_entry() routine.
Signed-off-by: Cédric Le Goater
This routine will let qemu platforms populate the sdr/sensor tables of
the IPMI BMC simulator with their customs needs.
The patch adds a compact sensor record typedef to ease definition of
sdrs. To be used in the code the following way:
static ipmi_sdr_compact_buffer my_init_sdrs[] = {
This is a simulator. Just return an unknown cause (0).
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 061db8437479..5db94491b130 100644
---
This patch provides a simplistic FRU support for the IPMI BMC
simulator. The FRU area contains 32 entries * 256 bytes which should
be enough to start some simulation.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 119 +
1 file chang
SET_SENSOR_READING is a complex IPMI command (IPMI spec : "35.17 Set
Sensor Reading And Event Status Command"). Here is a very minimum
framework fitting the Open PowerNV platform needs. This command is
used on this platform to set the "System Firmware Progress" sensor and
the "Boot Count" sensor.
It will be used to fill the message buffer with custom events expected
by some systems. Typically, an Open PowerNV platform guest is notified
with an OEM SEL message before a shutdown or a reboot.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 24
include/h
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 55 ++
1 file changed, 55 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 60586a67104e..c3a06d0ac7e4 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipm
Hi,
Here are a few patches adding a couple of IPMI commands to the BMC
simulator. The last patches provides an API to extend the initial SDRs
and generate events. These will be useful for the upcoming powernv
platform.
Based on 38a762fec63f and also available here :
https://github.com/legoate
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 51 --
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 559e1398d669..061db8437479 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+
On 01/05/2016 08:55 AM, Eric Blake wrote:
> On 01/05/2016 05:10 AM, lihuiba wrote:
>
In our production environment, we need to extend a qcow2 image with
snapshots in it.
>
>>> The thing is that one would need to update all the inactive L1 tables. I
>>> don't think it should be too dif
On 5 January 2016 at 16:20, Eric Auger wrote:
> Hi Peter,
> On 12/18/2015 03:36 PM, Peter Maydell wrote:
>> On 17 December 2015 at 12:29, Eric Auger wrote:
>>> Current qemu_fdt_getprop exits if the property is not found. It is
>>> sometimes needed to read an optional property, in which case we do
On 5 January 2016 at 16:20, Eric Auger wrote:
> Hi Peter,
> On 12/18/2015 03:23 PM, Peter Maydell wrote:
>> On 17 December 2015 at 12:29, Eric Auger wrote:
>>> This new helper routine returns the node path of a device
>>> referred to by its node name and compat string.
>>>
>>> Signed-off-by: Eric
On 01/05/2016 10:22 AM, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
>> Returning a partial object on error is an invitation for a careless
>> caller to leak memory. As no one outside the testsuite was actually
>> relying on these semantics, it is cleaner
+-- On Tue, 5 Jan 2016, P J P wrote --+
| An OOB r/w access issue was reported by Mr Donghai Zdh, CC'd here.
Mr Donghai CC'd now.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Monday, 4 January 2016 22:18
> On Mon, Jan 4, 2016 at 2:12 PM, Andrew Baumann
> wrote:
> >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> >> Sent: Thursday, 31 December 2015 21:38
> >> On Thu, Dec 31, 2015 at 1:4
alvise rigo writes:
> On Tue, Jan 5, 2016 at 5:10 PM, Alex Bennée wrote:
>>
>> Alvise Rigo writes:
>>
>>> Add a new TLB flag to force all the accesses made to a page to follow
>>> the slow-path.
>>>
>>> In the case we remove a TLB entry marked as EXCL, we unset the
>>> corresponding exclusive
> You can create a dummy device in guest for the duration of migration.
> Use guest agent to move IP address there and that should be enough to trick
> most guests.
If you are doing this - why not bond the physical NIC with an virtual device
and unplug the physical NIC?
The deleted file only contained V9fsConf which wasn't virtio specific.
Merge that to the general header of 9pfs.
Fixed header inclusions as I went along.
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p-device.c| 1 -
hw/9pfs/virtio-9p.h | 8 +++-
hw/virtio/virtio-pci.h|
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
---
hw/9pfs/{virtio-9p-local.c => 9p-local.c} | 3 +--
hw/9pfs/Makefile.objs | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
---
hw/9pfs/{virtio-9p-handle.c => 9p-handle.c} | 3 +--
hw/9pfs/Makefile.objs | 2 +-
2 files changed, 2 insertions(+), 3 deletio
These two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments
in header files.
Signed-off-by: Wei Liu
---
hw/9pfs/{virtio-9p-synth.c => 9p-synth.c} | 2 +-
hw/9pfs/{virtio-9p-synth.h => 9p-synth.h} | 6 +++---
hw/9p
Those two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments in
header files.
Signed-off-by: Wei Liu
---
hw/9pfs/Makefile.objs| 2 +-
hw/9pfs/codir.c | 2 +-
hw/9pfs/cofile.c
Those two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments
in header files.
Signed-off-by: Wei Liu
---
fsdev/virtfs-proxy-helper.c | 2 +-
hw/9pfs/{virtio-9p-proxy.c => 9p-proxy.c} | 5 ++---
hw/9pf
Some structures virtio-9p.h have been unused since 2011 when relevant
functions switched to use coroutines.
The declaration of pdu_packunpack and function do_pdu_unpack are
useless.
The function virtio_9p_set_fd_limit is unused.
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p.c | 11 -
hw
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
---
hw/9pfs/{virtio-9p-posix-acl.c => 9p-posix-acl.c} | 3 +--
hw/9pfs/Makefile.objs | 2 +-
2 files changed, 2 insertions(+
Hi all
Back in 2015 summer one of our OPW interns Linda Jacobson explored the
possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can
be reused.
This series refactors 9pfs related code:
1. Rename a bunch of files and functions to make clear they are generic.
2. Only export
These three files are not virtio specific. Rename them to generic
names.
Fix comments and header inclusion in various files.
Signed-off-by: Wei Liu
---
hw/9pfs/9p-handle.c | 2 +-
hw/9pfs/9p-local.c | 2 +-
hw/9pfs/9p-posix-acl.c
On Wed, 23 Dec 2015 17:28:23 +0100
Greg Kurz wrote:
> On Wed, 23 Dec 2015 15:47:00 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote:
> > > This series tries to rework cross-endian helpers for better clarity.
> > > It does not change behaviour,
On 12/22/2015 08:24 PM, Wen Congyang wrote:
> On 12/19/2015 06:02 PM, Markus Armbruster wrote:
>> Copying qemu-block because this seems related to generalising block jobs
>> to background jobs.
>>
>> zhanghailiang writes:
>>
>>> If some errors happen during VM's COLO FT stage, it's important to
Introduce a concept of blob. It will be used to pack / unpack xattr
value.
With this change there is no need to expose v9fs_pack to device code
anymore.
Signed-off-by: Wei Liu
---
fsdev/9p-marshal.c| 7 +++
fsdev/9p-marshal.h| 14 ++
fsdev/virtio-9p-marshal.c |
V9fsState now only contains generic fields. Introduce V9fsVirtioState
for virtio transport. Change virtio-pci and virtio-ccw to use
V9fsVirtioState. Handle transport enumeration in generic routines.
Signed-off-by: Wei Liu
---
hw/9pfs/9p.c | 41 +++-
hw/9pfs/9p.
This matches naming convention of pdu_marshal and pdu_unmarshal.
Signed-off-by: Wei Liu
---
This patch can be squashed if necessary.
---
hw/9pfs/virtio-9p.c | 88 ++---
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/hw/9pfs/virtio-
Signed-off-by: Wei Liu
---
hw/9pfs/9p.c | 95 ++
hw/9pfs/9p.h | 2 +
hw/9pfs/virtio-9p-device.c | 90 ---
3 files changed, 104 insertions(+), 83 deletions(-)
diff --git a/hw/9pfs/9p.c
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index db79a48..5475f29 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -63,6 +63,17 @@ ssize_t pdu_unmarsha
Break out some generic functions for marshaling 9p state. Pure code
motion plus minor fixes for build system.
Signed-off-by: Wei Liu
---
Makefile | 2 +-
fsdev/9p-marshal.c| 57
fsdev/9p-marshal.h| 84
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p-device.c | 12
hw/9pfs/virtio-9p.c| 8 +---
hw/9pfs/virtio-9p.h| 2 ++
3 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index d77247f..5cad654 100
V9fsState can be referenced by pdu->s. Initialise that in device
realization function.
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p-device.c | 1 +
hw/9pfs/virtio-9p.c| 98 +-
2 files changed, 46 insertions(+), 53 deletions(-)
diff --git a/hw
Factor out v9fs_iov_v{,un}marshal. Implement pdu_{,un}marshal with those
functions.
Signed-off-by: Wei Liu
---
fsdev/9p-iov-marshal.c | 42 ++
fsdev/9p-iov-marshal.h | 5 +
hw/9pfs/virtio-9p.c| 26 ++
hw/9pfs/virtio-9p.h
The vast majority of code in virtio-9p.c is actually generic code.
Rename that file to 9p.c and move virtio specific code to
virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
specific code to new virtio-9p.h.
Finally fix up virtio-pci.h header file inclusion.
Note that V9fsState
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p-device.c | 14 ++
hw/9pfs/virtio-9p.c| 6 ++
hw/9pfs/virtio-9p.h| 5 +
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index f3091cc..d77247f
And make v9fs_pack static function. Now we only need to export
v9fs_{,un}marshal to device.
Signed-off-by: Wei Liu
---
fsdev/virtio-9p-marshal.c | 4 ++--
fsdev/virtio-9p-marshal.h | 3 ---
hw/9pfs/virtio-9p.c | 21 +
3 files changed, 15 insertions(+), 13 deletions(-)
On 12/28/2015 10:32 PM, Zhu Lingshan wrote:
> When play with Dell MD3000 target, for sure it
> is a TYPE_DISK, but readcapacity16 would fail.
> Then we find that readcapacity10 succeeded. It
> looks like the target just support readcapacity10
> even through it is a TYPE_DISK or have some
> TYPE_R
And rename v9fs_marshal to v9fs_iov_marshal, v9fs_unmarshal to
v9fs_iov_unmarshal.
The rationale behind this change is that, this marshalling interface is
used both by virtio and proxy helper. Renaming files and functions to
reflect the true nature of this interface.
Xen transport is going to hav
On Tue, 2016-01-05 at 09:20 +0800, Cao jin wrote:
> From: Chen Fan
>
> mark the host bus be in reset. avoid multiple devices trigger the
> host bus reset many times.
>
> Signed-off-by: Chen Fan
> ---
> hw/vfio/pci.c | 6 ++
> include/hw/vfio/vfio-common.h | 1 +
> 2 files c
On 01/05/2016 10:29 AM, Cédric Le Goater wrote:
[meta-comment] Your messages were not marked in-reply-to: the 0/8 cover
letter, but came through as separate threads. This makes it harder to
follow, especially in mail clients that sort top-level threads by most
recent activity on the thread.
> Th
MMC devices:
READ CAPACITY 10 support is mandatory.
No support for READ CAPACITY 16
SBC devices:
READ CAPACITY 10 is mandatory
READ CAPACITY 16 support is only required when you have thin provisioning
or protection information (or if the device is >2^32 blocks)
Almost all, but apparently not all,
On 12/22/2015 03:43 PM, Eric Blake wrote:
> On 12/22/2015 09:46 AM, Kevin Wolf wrote:
>> So far, live migration with shared storage meant that the image is in a
>> not-really-ready don't-touch-me state on the destination while the
>> source is still actively using it, but after completing the mig
Am 05.01.2016 um 15:55 schrieb P J P:
> From: Prasad J Pandit
>
> When processing firmware configurations, an OOB r/w access occurs
> if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x).
> Add a check to validate 's->cur_entry' to avoid such access.
>
> Reported-by: Donghai Zdh
> Sign
On 01/04/2016 12:30 PM, Mark Cave-Ayland wrote:
> As the IDEState lba field is an int32_t, make sure we cast to int64_t before
> shifting to calculate the offset. Otherwise we end up with an overflow when
> trying to access sectors beyond 2GB as can occur when using DVD images.
>
> Signed-off-by
On Thu, Dec 24, 2015 at 1:33 AM, Andrey Smetanin
wrote:
> Lately tsc page was implemented but filled with empty
> values. This patch setup tsc page scale and offset based
> on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value.
>
> The valid tsc page drops HV_X64_MSR_TIME_REF_COUNT msr
> reads
Accidental duplicate send of patch #09 with minor differences in the
commit message... Assuming this one is the "correct" one and just
discarding the other.
On 12/29/2015 03:04 AM, Hervé Poussineau wrote:
> Rewrite the global DMA_*() functions to use the IsaDma interface.
> Note that these functio
On 12/29/2015 03:04 AM, Hervé Poussineau wrote:
> Floppy uses the DMA controller in rc4030 chipset, and not the i8259 from the
> ISA bus.
> It's better to disable DMA than to call the wrong DMA controller.
>
I'll trust that these platforms' FDCs are already terribly broken and
unusable, I've n
The Xilinx ZynqMP SoC and EP108 board supports three memory regions:
- A 2GB region starting at 0
- A 32GB region starting at 32GB
- A 256GB region starting at 768GB
This patch adds support for the first two memory regions, which is
automatically created based on the size specified by the QEMU
On 01/04/2016 05:27 AM, Fam Zheng wrote:
> Following patches to refactor and move block dirty bitmap code could use this.
>
> Signed-off-by: Fam Zheng
> ---
> include/qemu/typedefs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
>
101 - 200 of 226 matches
Mail list logo
