Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-04 Thread Zhang Chen
On 01/04/2016 01:37 PM, Jason Wang wrote: On 12/31/2015 04:40 PM, Zhang Chen wrote: On 12/31/2015 10:36 AM, Jason Wang wrote: On 12/22/2015 06:42 PM, Zhang Chen wrote: From: zhangchen Hi,all This patch add an colo-proxy object, COLO-Proxy is a part of COLO, based on qemu netfilter and i

Re: [Qemu-devel] [PULL v3 00/15] Tracing patches

2016-01-04 Thread Denis V. Lunev
On 11/13/2015 10:58 AM, Stefan Hajnoczi wrote: v3: * Include "exec/log.h" from translate-a64.c [Peter] v2: * Add missing log.py file [Peter] The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-

Re: [Qemu-devel] [PATCH] doc: Display i386 CPUID properties

2016-01-04 Thread Andreas Färber
Hi, First of all this should be "target-i386:" and CC'ing Eduardo, too. Also I think you meant "X86CPU properties". This is not documentation. Am 04.01.2016 um 08:18 schrieb Valentin Rakush: > When user invokes 'qemu -cpu help' all _features_ for CPUIDs are > printed in stdout. In case of target-

Re: [Qemu-devel] [PATCH v3] net: ne2000: fix bounds check in ioport operations

2016-01-04 Thread P J P
+-- On Mon, 4 Jan 2016, Jason Wang wrote --+ | > +if (addr < 32 | > +|| (addr >= NE2000_PMEM_START | > +&& addr + sizeof(uint32_t) - 1 < NE2000_MEM_SIZE)) { | > return ldl_le_p(s->mem + addr); | > } else { | > return 0x; | | Applied to my -net

Re: [Qemu-devel] [PATCH 0/7] target-ppc: endian fixes for KVM and gdbstub

2016-01-04 Thread Greg Kurz
On Fri, 18 Dec 2015 11:18:16 +0100 Greg Kurz wrote: > Hi, > > This series is a sequel to Anton's tentative at bringing VSX support in > our gdbstub: > > http://patchwork.ozlabs.org/patch/453758/ > > Indeed, FP, SPE and Altivec registers need to be copied to memory with > the appropriate orderin

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-04 Thread Jason Wang
On 01/04/2016 04:16 PM, Zhang Chen wrote: > > > On 01/04/2016 01:37 PM, Jason Wang wrote: >> >> On 12/31/2015 04:40 PM, Zhang Chen wrote: >>> >>> On 12/31/2015 10:36 AM, Jason Wang wrote: On 12/22/2015 06:42 PM, Zhang Chen wrote: > From: zhangchen > > Hi,all > > This pat

Re: [Qemu-devel] [PULL 49/57] Round up RAMBlock sizes to host page sizes

2016-01-04 Thread Dr. David Alan Gilbert
* Peter Crosthwaite (crosthwaitepe...@gmail.com) wrote: > On Tue, Nov 10, 2015 at 6:25 AM, Juan Quintela wrote: > > From: "Dr. David Alan Gilbert" > > > > RAMBlocks that are not a multiple of host pages in length > > cause problems for postcopy (I've seen an ACPI table on aarch64 > > be 5k in len

[Qemu-devel] [PATCH 01/13] backup: Use Bitmap to replace "s->bitmap"

2016-01-04 Thread Fam Zheng
"s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- bloc

[Qemu-devel] [PATCH 02/13] typedefs: Add BdrvDirtyBitmap and HBitmapIter

2016-01-04 Thread Fam Zheng
Following patches to refactor and move block dirty bitmap code could use this. Signed-off-by: Fam Zheng --- include/qemu/typedefs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index 78fe6e8..e83934e 100644 --- a/include/qemu/typedefs.h

[Qemu-devel] [PATCH 00/13] Dirty bitmap changes for migration/persistence work

2016-01-04 Thread Fam Zheng
Two major features are added to block dirty bitmap (and underlying HBitmap) in this series: meta bitmap and serialization, together with all other supportive patches. Both operations are common in dirty bitmap migration and persistence: they need to find whether and which part of the dirty bitmap

[Qemu-devel] [PATCH 09/13] block: Add two dirty bitmap getters

2016-01-04 Thread Fam Zheng
For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 10 ++ include/block/dirty-bitmap.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4314659..9c

[Qemu-devel] [PATCH 04/13] block: Remove unused typedef of BlockDriverDirtyHandler

2016-01-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/block/block.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index 97e9b5e..0f42964 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -320,8 +320,6 @@ BlockDriverState *check_to_replace_node(B

[Qemu-devel] [PATCH 10/13] block: Assert that bdrv_release_dirty_bitmap succeeded

2016-01-04 Thread Fam Zheng
This makes sure we don't leak a dirty bitmap in any case. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 9cac794..60ee965 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -297,

[Qemu-devel] [PATCH 11/13] hbitmap: serialization

2016-01-04 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bit

[Qemu-devel] [PATCH 08/13] block: Support meta dirty bitmap

2016-01-04 Thread Fam Zheng
The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 51 include/block/dirty-bitmap.h | 9 2 files changed, 60 insertions(+) diff --git a/block/d

[Qemu-devel] [PATCH 03/13] block: Move block dirty bitmap code to separate files

2016-01-04 Thread Fam Zheng
The only change is making bdrv_dirty_bitmap_truncate public. It is used in block.c. Signed-off-by: Fam Zheng --- block.c | 339 --- block/Makefile.objs | 2 +- block/dirty-bitmap.c | 366 +

[Qemu-devel] [PATCH 13/13] tests: Add test code for hbitmap serialization

2016-01-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/test-hbitmap.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index 19136e7..4f61961 100644 --- a/tests/test-hbitmap.c +++ b/tests/test-hbitmap.c @@ -14,6 +14

[Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-04 Thread Fam Zheng
HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be dyn

[Qemu-devel] [PATCH 07/13] tests: Add test code for meta bitmap

2016-01-04 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/test-hbitmap.c | 113 +++ 1 file changed, 113 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index abcea0c..19136e7 100644 --- a/tests/test-hbitmap.c +++ b/tests/test-hbitmap.c @@ -14,6 +14

[Qemu-devel] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-04 Thread Fam Zheng
Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 8 +++ util/hbitmap.c | 61 +- 2 files changed, 54 insertions(+), 15 deletions(-) diff --git a/include/q

[Qemu-devel] [PATCH 12/13] block: BdrvDirtyBitmap serialization interface

2016-01-04 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy [Add the "finish" parameters. - Fam] Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 37 +++

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Jonathan Scruggs
Hi, I tried these patches with qemu 2.5.0 on Gentoo and libvirt. I get the following error: Error starting domain: internal error: early end of file from monitor: possible problem: 2015-12-22T21:51:20.659520Z qemu-system-x86_64: -input-linux /dev/input/by-path/pci-:00:14.0-usb-0:12:1.0-event-k

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-04 Thread Zhang Chen
On 01/04/2016 05:46 PM, Jason Wang wrote: On 01/04/2016 04:16 PM, Zhang Chen wrote: On 01/04/2016 01:37 PM, Jason Wang wrote: On 12/31/2015 04:40 PM, Zhang Chen wrote: On 12/31/2015 10:36 AM, Jason Wang wrote: On 12/22/2015 06:42 PM, Zhang Chen wrote: From: zhangchen Hi,all This patch

Re: [Qemu-devel] [PATCH 0/3] ohci reset improvements

2016-01-04 Thread Gerd Hoffmann
On So, 2015-12-20 at 00:23 +0100, Hervé Poussineau wrote: > Hi, > > This small patchset adds different reset levels to OHCI USB controller. > The idea is from Benjamin Herrenschmidt. > Most significant change is that MacOS 9 doesn't try anymore to do some > DMA transfer to address 0, and boots a l

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Gerd Hoffmann
On Mo, 2016-01-04 at 10:10 +, Jonathan Scruggs wrote: > Hi, > > > I tried these patches with qemu 2.5.0 on Gentoo and libvirt. I get the > following error: > Error starting domain: internal error: early end of file from monitor: > possible problem: > 2015-12-22T21:51:20.659520Z qemu-system-x8

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2016-01-04 Thread Igor Mammedov
On Fri, 1 Jan 2016 09:17:48 +0530 Bharata B Rao wrote: > On Wed, Dec 16, 2015 at 04:46:37PM +0100, Andreas Färber wrote: > > Am 10.12.2015 um 13:35 schrieb Igor Mammedov: > > > wrt CLI can't we do something like this? > > > > > > -device some-cpu-model,socket=x[,core=y[,thread=z]] > > > > T

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Jonathan Scruggs
Hi, Thanks for the reply. I changed the conf to: cgroup_controllers = [ "cpu", "memory", "cpuset", "cpuacct" ] Also, cgroups are not mounted at /dev/cgroup I don't have selinux or apparmor. However, I still get this: Error starting domain: internal error: early end of file from monitor, possible

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-04 Thread Jonathan Scruggs
Oh. I just changed /dev/input/eventx (replace x with correct number for my devices) to permissions of 666 and it worked. I guess I had to change the conf file and change the permissions. Is there a way to make the devices work with qemu? The permission user is root and group of input for all the ev

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-04 Thread Stefano Stabellini
On Sat, 2 Jan 2016, Michael S. Tsirkin wrote: > On Sat, Jan 02, 2016 at 04:02:20PM +0800, Cao jin wrote: > > Fix the bug introduced by 595a4f07: function host_pci_config_read() should > > be > > pass-by-reference, not value. > > > > Signed-off-by: Cao jin > > --- > > v3 changelog: > > 1. Remove

Re: [Qemu-devel] [OpenBIOS] Emaculation bug reports

2016-01-04 Thread Mark Cave-Ayland
On 04/01/16 03:18, Programmingkid wrote: >> I did find out that the driver's init() and start() methods are never >> called. Using the ioreg command I can see the rtl8139 in the PCI slot. The >> NIC does work in Linux using the mac99 target. Note: I implemented your >> second set of patches for

Re: [Qemu-devel] [PATCH trivial v2] xen/Makefile.objs: simplify

2016-01-04 Thread Stefano Stabellini
On Tue, 29 Dec 2015, Stefan Weil wrote: > Am 29.12.2015 um 13:39 schrieb Cao jin: > > merge last two lines, keep alphabetic order. > > > > Signed-off-by: Cao jin > > --- > > hw/xen/Makefile.objs | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/hw/xen/Makefile.obj

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Stefano Stabellini
Unfortunately I don't have a setup to test this either. Maybe Lars can find out who should be involved on the Intel side on this. In any case, the patch looks good to me. It would be nice to get feedback from somebody at Intel before applying it, but if we don't get any to your next version of the

Re: [Qemu-devel] [PATCH v2 1/4] Add Error **errp for xen_host_pci_device_get()

2016-01-04 Thread Stefano Stabellini
On Sun, 27 Dec 2015, Cao jin wrote: > To catch the error msg. Also modify the caller > > Signed-off-by: Cao jin This looks much better, thanks. > hw/xen/xen-host-pci-device.c | 102 > --- > hw/xen/xen-host-pci-device.h | 5 ++- > hw/xen/xen_pt.c

Re: [Qemu-devel] [PATCH v2 2/4] Add Error **errp for xen_pt_setup_vga()

2016-01-04 Thread Stefano Stabellini
On Sun, 27 Dec 2015, Cao jin wrote: > To catch the error msg. Also modify the caller > > Signed-off-by: Cao jin Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 5 - > hw/xen/xen_pt.h | 3 ++- > hw/xen/xen_pt_graphics.c | 11 ++- > 3 files changed, 12 inser

[Qemu-devel] [PATCH v5 2/4] Introduce condition to notify waiters of completed command

2016-01-04 Thread Stefan Berger
From: Stefan Berger Introduce a lock and a condition to notify anyone waiting for the completion of the execution of a TPM command by the backend (thread). The backend uses the condition to signal anyone waiting for command completion. We need to place the condition in two locations: one is invok

[Qemu-devel] [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM

2016-01-04 Thread Stefan Berger
The following series of patches extends TPM support with an external TPM that offers a Linux CUSE (character device in userspace) interface. This TPM lets each VM access its own private vTPM. The CUSE TPM supports suspend/resume and migration. Much out-of-band functionality necessary to control the

[Qemu-devel] [PATCH v5 4/4] Add support for VM suspend/resume for TPM TIS

2016-01-04 Thread Stefan Berger
From: Stefan Berger Extend the TPM TIS code to support suspend/resume. In case a command is being processed by the external TPM when suspending, wait for the command to complete to catch the result. In case the bottom half did not run, run the one function the bottom half is supposed to run. This

[Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

2016-01-04 Thread Stefan Berger
From: Stefan Berger Rather than integrating TPM functionality into QEMU directly using the TPM emulation of libtpms, we now integrate an external emulated TPM device. This device is expected to implement a Linux CUSE interface (CUSE = character device in userspace). QEMU talks to the CUSE TPM us

Re: [Qemu-devel] [PATCH v2 3/4] Add Error **errp for xen_pt_config_init()

2016-01-04 Thread Stefano Stabellini
On Sun, 27 Dec 2015, Cao jin wrote: > To catch the error msg. Also modify the caller > > Signed-off-by: Cao jin > --- > hw/xen/xen_pt.c | 7 --- > hw/xen/xen_pt.h | 2 +- > hw/xen/xen_pt_config_init.c | 48 > ++--- > 3 files

[Qemu-devel] [PATCH v5 3/4] Introduce condition in TPM backend for notification

2016-01-04 Thread Stefan Berger
From: Stefan Berger TPM backends will suspend independently of the frontends. Also here we need to be able to wait for the TPM command to have been completely processed. Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 20 1 file changed, 20 insertions(+) diff

Re: [Qemu-devel] [PATCH v2 4/4] Xen PCI passthru: convert to realize()

2016-01-04 Thread Stefano Stabellini
On Sun, 27 Dec 2015, Cao jin wrote: > Signed-off-by: Cao jin Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 53 - > 1 file changed, 28 insertions(+), 25 deletions(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 3787c26..b

Re: [Qemu-devel] [PATCH v2 1/2] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Gerd Hoffmann
On Mi, 2015-12-23 at 16:49 +0800, Cao jin wrote: > Hi mst, > Ping > Or do I need to cc this to qemu-trivial? FYI: I have a pending series which reworks all these igd bits, fixing a bunch of other issues (beside error reporting) along the way. https://lists.gnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Stefano Stabellini
On Mon, 4 Jan 2016, Lars Kurth wrote: > On 04/01/2016 14:47, "Stefano Stabellini" > wrote: > > >Unfortunately I don't have a setup to test this either. Maybe Lars can > >find out who should be involved on the Intel side on this. > > I can certainly help to this and get back to you. What exactly

Re: [Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

2016-01-04 Thread Eric Blake
On 01/03/2016 08:07 AM, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has added the option to the runtime but does not add

Re: [Qemu-devel] [PATCH] i386: avoid null pointer dereference

2016-01-04 Thread P J P
+-- On Fri, 18 Dec 2015, P J P wrote --+ | A null pointer dereference issue was reported by Mr Ling Liu, CC'd here. It | occurs while doing I/O port write operations via hmp interface. In that, | 'current_cpu' remains null as it is not called from cpu_exec loop, which | results in the said issue.

Re: [Qemu-devel] [PATCH v3 19/24] pci-assign: Clean up "Failed to assign" error messages

2016-01-04 Thread Laszlo Ersek
On 12/18/15 16:35, Markus Armbruster wrote: > The arguments of error_setg() & friends should yield a short error > string without newlines. > > Two places try to append additional help to the error message by > embedding newlines in the error string. That's nice, but let's do it > the right way,

Re: [Qemu-devel] [Patch v12 resend 05/10] docs: block replication's description

2016-01-04 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Dec 02, 2015 at 01:31:46PM +0800, Wen Congyang wrote: > > +== Failure Handling == > > +There are 6 internal errors when block replication is running: > > +1. I/O error on primary disk > > +2. Forwarding primary write requests failed > > +3. B

[Qemu-devel] [PATCH v2] target-mips: Fix ALIGN instruction when bp=0

2016-01-04 Thread Miodrag Dinic
Hello Aurelien, thanks for your comments and review. Version 2 of the patch is in the attachment. Diff between versions 1 & 2 according to your comments is : diff --git a/target-mips/translate.c b/target-mips/translate.c index f20678c..d2443d3 100644 --- a/target-mips/translate.c +++ b/target-mi

Re: [Qemu-devel] [Patch v12 resend 00/10] Block replication for continuous checkpoints

2016-01-04 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 12/23/2015 06:04 PM, Stefan Hajnoczi wrote: > > On Thu, Dec 17, 2015 at 02:22:14PM +0800, Wen Congyang wrote: > >> Stefan:Ping... > >> > >> What about this feature? I have worked for it about 1 year, but it is > >> still in the > >> way... > > > >

[Qemu-devel] [PATCH v2 2/3] tpm: remove TPMState usage from backend

2016-01-04 Thread Stefan Berger
From: Stefan Berger Remove the direct TPMState usage from the TPM backend. This allows different frontends to use the backend. A few more parameters now need to be passed to the backend. Other frontends may need different TPMState structures if for example the device types they are using are not

[Qemu-devel] [PATCH v2 0/3] Add TPM support to ppc64

2016-01-04 Thread Stefan Berger
The following series of patches adds TPM support for ppc64. The CUSE TPM backend, which is part of the TPM passthrough backend, should be considered for providing a private vTPM to a VM. The series implementing support for this has been posted here: http://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [PATCH v2 3/3] tpm: Support TPM for ppc64 using CRQ based interface

2016-01-04 Thread Stefan Berger
From: Stefan Berger Implement support for TPM on ppc64 by implementing the vTPM CRQ interface (following PAPR) as a frontend. Have the frontend call the existing passthrough TPM device backend using data structures from the TPM TIS hardware interface emulation (tpm_tis.c). The TIS implements a s

[Qemu-devel] [PATCH v2 1/3] Enable PPC64 with TPM support

2016-01-04 Thread Stefan Berger
From: Stefan Berger Compile the TPM passthrough device emulation on ppc64. Signed-off-by: Stefan Berger CC: Alexander Graf CC: qemu-...@nongnu.org --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 83b40fc..82ca1b5 100755 --- a/conf

Re: [Qemu-devel] [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-04 Thread Max Reitz
On 29.12.2015 01:27, Programmingkid wrote: > I do realize you are busy Kevin, but I would > appreciate knowing my patch is in line > for review. Primarily, he's been on holiday since before christmas until next week. (I'm telling you so you don't wonder why nothing happens.) Max signature.as

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-04 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 01/04/2016 04:16 PM, Zhang Chen wrote: > > > > > > On 01/04/2016 01:37 PM, Jason Wang wrote: > >> > >> On 12/31/2015 04:40 PM, Zhang Chen wrote: > >>> > >>> On 12/31/2015 10:36 AM, Jason Wang wrote: > On 12/22/2015 06:42 PM, Zhang Chen wrote

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Lars Kurth
On 04/01/2016 14:47, "Stefano Stabellini" wrote: >Unfortunately I don't have a setup to test this either. Maybe Lars can >find out who should be involved on the Intel side on this. I can certainly help to this and get back to you. What exactly are we asking Intel to do? It is not clear to me f

Re: [Qemu-devel] [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-04 Thread Programmingkid
On Jan 4, 2016, at 11:35 AM, Max Reitz wrote: > On 29.12.2015 01:27, Programmingkid wrote: >> I do realize you are busy Kevin, but I would >> appreciate knowing my patch is in line >> for review. > > Primarily, he's been on holiday since before christmas until next week. > > (I'm telling you s

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2016-01-04 Thread Max Reitz
On 24.12.2015 06:41, Denis V. Lunev wrote: > On 12/24/2015 02:19 AM, Max Reitz wrote: >> So the benefits of a qcow2 flag are only minor ones. However, I >> personally believe that automatic unlock on crash is a very minor >> benefit as well. That should never happen in practice anyway, and a >> cra

Re: [Qemu-devel] [PATCH] hw/i386: fill in the CENTURY field of the FADT (FACP) ACPI table

2016-01-04 Thread Laszlo Ersek
On 12/10/15 19:53, Igor Mammedov wrote: > On Thu, 10 Dec 2015 18:25:34 +0100 > Laszlo Ersek wrote: > >> The ACPI specification (minimally versions 1.0b through 6.0) define >> the FADT.CENTURY field as: >> >> The RTC CMOS RAM index to the century of data value (hundred and >> thousand year dec

[Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Mark Cave-Ayland
As the IDEState lba field is an int32_t, make sure we cast to int64_t before shifting to calculate the offset. Otherwise we end up with an overflow when trying to access sectors beyond 2GB as can occur when using DVD images. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c |2 +- 1 file ch

[Qemu-devel] [PATCH] i2c-tiny-usb: add new usb to i2c bridge

2016-01-04 Thread Tim Sander
Version 3 with improvements suggested by Gerd Hoffmann Signed-off-by: Tim Sander i2c-tiny-usb is a small usb to i2c bridge:

Re: [Qemu-devel] [PATCH 2/6] device_tree: introduce load_device_tree_from_sysfs

2016-01-04 Thread Eric Auger
Hi Peter, On 12/18/2015 03:10 PM, Peter Maydell wrote: > On 17 December 2015 at 12:29, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/sys/firmware/devicetree/base). It uses a recursive function >> inspired from dtc read_fstree. >> >> Signed-off-by: Eric Auger

Re: [Qemu-devel] qcow2 snapshot + resize

2016-01-04 Thread Max Reitz
On 29.12.2015 10:38, lihuiba wrote: > Hi, > > In our production environment, we need to extend a qcow2 image with > snapshots in it. This feature, however, is not implemented yet. > > So I want to ask, if this feature is under active development? No, it is not. > How can I > help with this fea

Re: [Qemu-devel] could i using qemu-img covert && rebase -u to do qcow2 rollback?

2016-01-04 Thread Max Reitz
On 30.12.2015 12:31, Huan Zhang wrote: > Hi, > We are finding a way to do rollback for qcow2 in production environment, > But we can't ensure the below way will work well, and user data are safe. > > for example, > snap0.qcow2 -> snap1.qcow2 ->snap2.qcow2 -> active.qcow2 > > rollback to snap1 usi

Re: [Qemu-devel] could i using qemu-img covert && rebase -u to do qcow2 rollback?

2016-01-04 Thread Eric Blake
On 01/04/2016 10:45 AM, Max Reitz wrote: > On 30.12.2015 12:31, Huan Zhang wrote: >> Hi, >> We are finding a way to do rollback for qcow2 in production environment, >> But we can't ensure the below way will work well, and user data are safe. >> >> for example, >> snap0.qcow2 -> snap1.qcow2 ->snap2.

Re: [Qemu-devel] [PATCH v2] target-mips: Fix ALIGN instruction when bp=0

2016-01-04 Thread P J P
Hello Miodrag, +-- On Mon, 4 Jan 2016, Miodrag Dinic wrote --+ | thanks for your comments and review. | Version 2 of the patch is in the attachment. -> http://qemu-project.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment Generally it is preferred to have patches inline, instead of att

[Qemu-devel] [Bug 1399191] Re: Large VHDX image size

2016-01-04 Thread Max Reitz
Hi Jan, ls -l returns the length of the file; qemu-img info prints the size of the file (just like du does). Those are not necessarily the same, as you can see. On modern filesystems, files can have holes in them which do contribute to the file length, but which do not use any space on disk and th

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix unintended texi verbatim formatting

2016-01-04 Thread Eric Blake
On 12/30/2015 12:54 PM, Sitsofe Wheeler wrote: [meta-comment] When sending a patch series, it's best to also include a 0/2 cover letter that summarizes the series. Doable with 'git config format.coverLetter auto'. > Indented lines in the texi meant the perlpod produced interpreted the > paragrap

Re: [Qemu-devel] An RDMA race?

2016-01-04 Thread Dr. David Alan Gilbert
* Michael R. Hines (mhi...@digitalocean.com) wrote: > Adding such a control message would defeat the benefits of RDMA, as there > shouldn't be any signalling in the actual DMA path, or RDMA latency would > be too high. If you're sending control messages for individual writes, then > you need to cha

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Minor texi updates

2016-01-04 Thread Eric Blake
On 12/30/2015 12:57 PM, Sitsofe Wheeler wrote: > - Change some spacing. > - Remove duplicate entry for --format. > - Reword --discard documentation. > - Add --detect-zeroes documentation. > > Signed-off-by: Sitsofe Wheeler > --- > qemu-nbd.texi | 22 ++ > 1 file changed, 14 i

[Qemu-devel] [PATCH V6 4/8] introduce dpcd module

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This introduces dpcd module. It wires on a aux-bus and can be accessed by the driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 +

[Qemu-devel] [PATCH V6 3/8] i2c: implement broadcast write

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This does a write to every slaves when the I2C bus get a write to address 0. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 129 ++-

[Qemu-devel] [PATCH V6 1/8] i2cbus: remove unused dev field

2016-01-04 Thread fred . konrad
From: KONRAD Frederic The dev field in i2cbus is not used. So just drop it. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c ind

[Qemu-devel] [PATCH V6 2/8] introduce aux-bus

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C through AUX transactions. Signed-off-by: KONRAD Frederic Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 + hw/misc/Makefile.obj

[Qemu-devel] [PATCH V6 0/8] Xilinx DisplayPort.

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the 6th version of this patch-set of the implementation of the Xilinx DisplayPort and DPDMA. This 6th version fixes some minors issues. Second patch introduces an AUX bus needed by the DP to read the DPCD. It's also possible to connect an I2C device on it to to I2C

[Qemu-devel] [PATCH V6 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP platform. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/arm/xlnx-zynqmp.c | 30 ++ include/hw/arm/xlnx-zynqmp.h | 5 + 2 files changed, 35

[Qemu-devel] [PATCH V6 6/8] introduce xlnx-dpdma

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- hw/dma/Makefile.objs| 1 + hw/dma/xlnx_dpdma.c | 792 include/hw/dma/xlnx_dpdma.

[Qemu-devel] [PATCH V6 5/8] hw/i2c-ddc.c: Implement DDC I2C slave

2016-01-04 Thread fred . konrad
From: Peter Maydell Implement an I2C slave which implements DDC and returns the EDID data for an attached monitor. Signed-off-by: Peter Maydell - Rebased on the current master. - Modified for QOM. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- de

[Qemu-devel] [PATCH V6 7/8] introduce xlnx-dp

2016-01-04 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid. Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. Audio stream are connected to the channels 4 and 5. Signed-off-by: KONRAD Frederic Tested-By:

Re: [Qemu-devel] [PATCH v1] qemu-iotests: s390x: fix test 051

2016-01-04 Thread Max Reitz
On 04.01.2016 06:29, Bo Tu wrote: > From: Bo Tu > > Replace the remaining "-drive file..." > by "-drive file=...,if=none,id=$device_id", then x86 and s390x > can get the common output. > "if=ide, if=floppy, if=scsi" are not supported by s390x, > so these test cases are not executed for s390x pla

[Qemu-devel] [PATCH 1/6] pc: acpi: bump DSDT/SSDT compliance revision to v2

2016-01-04 Thread Xiao Guangrong
From: Igor Mammedov It turns on 64-bit integer handling in OSPM, which will be used for writing simpler/smaller AML code in following patch. Tested with Windows XP and Windows Server 2008, Linux: * XP doesn't care about revision and continues to use 32 integers and boots just fine with

[Qemu-devel] [PATCH 0/6] NVDIMM ACPI: introduce the framework of QEMU emulated DSM

2016-01-04 Thread Xiao Guangrong
This patchset is against commit 5530427f0ca (acpi: extend aml_and() to accept target argument) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-acpi-v1 This is the second part of vNVDIMM implementation which implements the BIOS patched dsm me

[Qemu-devel] [PATCH 6/6] nvdimm acpi: emulate dsm method

2016-01-04 Thread Xiao Guangrong
Emulate dsm method after IO VM-exit Currently, we only introduce the framework and no function is actually supported Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 2 +- hw/acpi/nvdimm.c| 83 - include/hw/acpi/aml-build.h

[Qemu-devel] [PATCH 3/6] nvdimm acpi: introduce patched dsm memory

2016-01-04 Thread Xiao Guangrong
The dsm memory is used to save the input parameters and store the dsm result which is filled by QEMU. The address of dsm memory is decided by bios and patched into int64 object returned by "MEMA" method Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 12 hw/acpi/nvd

[Qemu-devel] [PATCH 2/6] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-01-04 Thread Xiao Guangrong
IO port 0x0a18 - 0x0a20 in guest is reserved for NVDIMM ACPI emulation, the table, NVDIMM_DSM_MEM_FILE, will be patched into NVDIMM ACPI binary code OSPM uses this port to tell QEMU the final address of the DSM memory and notify QEMU to emulate the DSM method Signed-off-by: Xiao Guangrong --- h

Re: [Qemu-devel] [PATCH COLO-Frame v13 17/39] COLO: Load VMState into qsb before restore it

2016-01-04 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should not destroy the state of SVM (Secondary VM) until we receive the > whole > state from the PVM (Primary VM), in case the primary fails in the middle of > sending > the state, so, here we cache the device state in Secondary before

[Qemu-devel] [PATCH 4/6] acpi: allow using acpi named offset for OperationRegion

2016-01-04 Thread Xiao Guangrong
Extend aml_operation_region() to use named object Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 4 ++-- hw/i386/acpi-build.c| 7 --- include/hw/acpi/aml-build.h | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-

[Qemu-devel] [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method

2016-01-04 Thread Xiao Guangrong
If dsm memory is successfully patched, we let qemu fully emulate the dsm method This patch saves _DSM input parameters into dsm memory, tell dsm memory address to QEMU, then fetch the result from the dsm memory Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 27 ++ hw/a

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread P J P
+-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ | /* Calculate current offset */ | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; | +offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index; Maybe ((int64_t)s->lba << 11) ? No parenthesis around s->lba. -- - P J P 47AF CE6

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread Mark Cave-Ayland
On 04/01/16 19:04, P J P wrote: > +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ > | /* Calculate current offset */ > | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; > | +offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index; > > Maybe ((int64_t)s->lba << 11) ? No par

Re: [Qemu-devel] [PATCH v8 1/2] mirror: Rewrite mirror_iteration

2016-01-04 Thread Max Reitz
On 24.12.2015 04:15, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > Signed-

Re: [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command

2016-01-04 Thread Max Reitz
On 24.12.2015 04:25, Fam Zheng wrote: > On Thu, 12/24 01:53, Max Reitz wrote: >> On 23.12.2015 06:59, Fam Zheng wrote: >>> This will start a mirror job from a named device to another named >>> device, its relation with drive-mirror is similar with blockdev-backup >>> to drive-backup. >>> >>> In blo

Re: [Qemu-devel] [PATCH v4 4/5] qmp: Add blockdev-mirror command

2016-01-04 Thread Max Reitz
On 24.12.2015 05:45, Fam Zheng wrote: > This will start a mirror job from a named device to another named > device, its relation with drive-mirror is similar with blockdev-backup > to drive-backup. > > In blockdev-mirror, the target node should be prepared by blockdev-add, > which will be responsi

Re: [Qemu-devel] How to reserve guest physical region for ACPI

2016-01-04 Thread Laszlo Ersek
Michael CC'd me on the grandparent of the email below. I'll try to add my thoughts in a single go, with regard to OVMF. On 12/30/15 20:52, Michael S. Tsirkin wrote: > On Wed, Dec 30, 2015 at 04:55:54PM +0100, Igor Mammedov wrote: >> On Mon, 28 Dec 2015 14:50:15 +0200 >> "Michael S. Tsirkin" wrote

Re: [Qemu-devel] [Bug 1529859] [NEW] qemu 2.5.0 ivshmem segfault with msi=off option

2016-01-04 Thread Eric Blake
On 12/29/2015 06:38 AM, maquefel wrote: > Public bug reported: > > Launching qemu with "-device ivshmem,chardev=ivshmemid,msi=off -chardev > socket,path=/tmp/ivshmem_socket,id=ivshmemid" > > Causes segfault because, s->msi_vectors is not initialized and > s->msi_vectors == 0. > > Does ivshmem ex

Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

2016-01-04 Thread John Snow
On 01/04/2016 02:15 PM, Mark Cave-Ayland wrote: > On 04/01/16 19:04, P J P wrote: > >> +-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+ >> | /* Calculate current offset */ >> | -offset = (int64_t)(s->lba << 11) + s->io_buffer_index; >> | +offset = ((int64_t)(s->lba) << 11) + s->io

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

2016-01-04 Thread Konrad Rzeszutek Wilk
On Sun, Dec 13, 2015 at 01:28:09PM -0800, Alexander Duyck wrote: > This patch set is meant to be the guest side code for a proof of concept > involving leaving pass-through devices in the guest during the warm-up > phase of guest live migration. In order to accomplish this I have added a What doe

Re: [Qemu-devel] [PATCH v5 4/6] expose floppy drive geometry and CMOS type

2016-01-04 Thread John Snow
On 12/30/2015 03:11 PM, Roman Kagan wrote: > Make it possible to query the geometry and the CMOS type of a floppy > drive outside of the respective source files. > > It will be useful, in particular, when dynamically building ACPI tables, > and will allow to properly populate the corresponding A

Re: [Qemu-devel] [PATCH v4 11/14] vmdk: Return extent's file in bdrv_get_block_status

2016-01-04 Thread Max Reitz
On 24.12.2015 06:50, Fam Zheng wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index f5a56fd..b60a5af 100644 > --- a/block/vmdk.c > +++ b/bloc

[Qemu-devel] [PATCH v3 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-04 Thread Alistair Francis
The Xilinx ZynqMP SoC and EP108 board supports three memory regions: - A 2GB region starting at 0 - A 32GB region starting at 32GB - A 256GB region starting at 768GB This patch adds support for the first two memory regions, which is automatically created based on the size specified by the QEMU

  1   2   >