This removes some static/global variables, and we're now running only the
required controller (master or slave)
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 75 ++
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/hw/d
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index a3227a1..03d27de 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -86,7 +86,7 @@ enum {
static void i8257_dma_run(void *opaque);
-st
Signed-off-by: Hervé Poussineau
---
hw/audio/gus.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/hw/audio/gus.c b/hw/audio/gus.c
index e0c8a4e..b027eb5 100644
--- a/hw/audio/gus.c
+++ b/hw/audio/gus.c
@@ -57,6 +57,7 @@ typedef struct GUSState {
SWV
This will permit to deprecate global DMA_*() functions.
Signed-off-by: Hervé Poussineau
---
hw/isa/isa-bus.c| 21 +
include/hw/isa/isa.h| 38 ++
include/qemu/typedefs.h | 1 +
3 files changed, 60 insertions(+)
diff --git a/hw/
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 43 +++
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index 4d0b49d..f4fcf39 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -52,7 +52,7 @@ struct dma
Hi,
This patchset is a cleanup of the i8257/i82374 ISA DMA controllers.
Global DMA_* functions will be obsoleted and then deleted, and ISA devices will
not
be tied anymore to i8257 DMA device implementation.
This paves the way to fix support for floppy DMA operations on
sparc/sparc64/MIPS Magnu
i8257 DMA controller exists on one ISA bus, so let's specify it at
initialization.
Signed-off-by: Hervé Poussineau
---
hw/dma/i82374.c | 2 +-
hw/dma/i8257.c | 2 +-
hw/i386/pc.c| 2 +-
hw/mips/mips_fulong2e.c | 2 +-
hw/mips/mips_jazz.c | 2 +-
hw/mips/mips_mal
Signed-off-by: Hervé Poussineau
---
hw/audio/cs4231a.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c
index f96f561..d84f83f 100644
--- a/hw/audio/cs4231a.c
+++ b/hw/audio/cs4231a.c
@@ -69,6 +69,7 @@ typedef str
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 160 ++---
1 file changed, 107 insertions(+), 53 deletions(-)
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index 03d27de..20231d6 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -26,6 +26
Rewrite the global DMA_*() functions to use the IsaDma interface.
Note that they will be deleted in a few commits.
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 148 +
1 file changed, 117 insertions(+), 31 deletions(-)
diff --git a/
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 91 +-
1 file changed, 46 insertions(+), 45 deletions(-)
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index f4fcf39..aba4295 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -80,11 +80
Floppy uses the DMA controller in rc4030 chipset, and not the i8259 from the
ISA bus.
It's better to disable DMA than to call the wrong DMA controller.
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 5 +++--
hw/mips/mips_jazz.c| 3 ++-
include/hw/block/fdc.h | 2 +-
3 files ch
Rewrite the global DMA_*() functions to use the IsaDma interface.
Note that these functions will be deleted in a few commits.
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 148 +
1 file changed, 117 insertions(+), 31 deletions(-)
di
Signed-off-by: Hervé Poussineau
---
hw/audio/sb16.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c
index 995435f..9973e77 100644
--- a/hw/audio/sb16.c
+++ b/hw/audio/sb16.c
@@ -55,6 +55,8 @@ typedef struct SB16State {
Merge ISAi82374State fields into parent structure I82374State.
Signed-off-by: Hervé Poussineau
---
hw/dma/i82374.c | 58 +++--
1 file changed, 19 insertions(+), 39 deletions(-)
diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
index f630971..daa8
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform.
Disable the DMA in the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index
Keep only DMA_init function as a wrapper around DMA controllers creation.
Signed-off-by: Hervé Poussineau
---
hw/dma/i8257.c | 65
hw/sparc/sun4m.c | 22 --
hw/sparc64/sun4u.c | 22 --
include/hw/isa
All functions relative to DMA (DMA_*() functions) are stubs on sparc64 platform.
Disable the DMA of the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau
---
hw/sparc64/sun4u.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/s
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 63 ++
1 file changed, 46 insertions(+), 17 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 14891c1..3c3d046 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -534,6 +53
Signed-off-by: Cao jin
---
changelog v4:
1. strip the bugfix code, but I guess this patch should be applied after
that bugfix patch.
2. Other little fix as per previous review
Some explanation to previous review:
1. error_setg_errno() I use in this patch will print the strerror(errno), so I
All other architectures define get_sp_from_cpustate as an inline function,
only unicore32 uses a #define. With this, some usages are impossible, for
example, enabling sigaltstack in linux-user/syscall.c results in
linux-user/syscall.c: In function ‘do_syscall’:
linux-user/syscall.c:8299:39: error
There is no reason to limit sigaltstack syscall to just a few
architectures and pretend it is not implemented for others.
If some architecture is not ready for this, that architecture
should be fixed instead.
This fixes LP#1516408.
Signed-off-by: Michael Tokarev
---
This patch depends on a prev
merge three lines into one line
Signed-off-by: Cao jin
---
hw/xen/Makefile.objs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7e7..77806f0 100644
--- a/hw/xen/Makefile.objs
+++ b/hw/xen/Makefile.objs
@@ -1,6 +1,4 @@
Am 29.12.2015 um 11:13 schrieb Cao jin:
> merge three lines into one line
>
> Signed-off-by: Cao jin
> ---
> hw/xen/Makefile.objs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..77806f0 100644
> --- a/hw/xen/
On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao jin wrote:
> Signed-off-by: Cao jin
> ---
> changelog v4:
> 1. strip the bugfix code, but I guess this patch should be applied after
>that bugfix patch.
> 2. Other little fix as per previous review
>
> Some explanation to previous review:
> 1. err
CC the code author: Tiejun Chen
On 12/28/2015 12:42 PM, Cao jin wrote:
Fix the bug introduced by 595a4f07: Function host_pci_config_read() should be
passed by a reference, not a value, for the later pci_default_write_config().
And because value in PCI config space are little-endian, use cpu_to_
Oops, got following feedback 2nd time:
The following message to was undeliverable.
The reason for the problem:
5.1.0 - Unknown address error 550-'#5.1.0 Address rejected.'
I guess the author address is not available anymore
On 12/29/2015 07:54 PM, Cao jin wrote:
CC the code author: Tiejun Che
On 12/29/2015 06:28 PM, Stefan Weil wrote:
Am 29.12.2015 um 11:13 schrieb Cao jin:
merge three lines into one line
Signed-off-by: Cao jin
---
hw/xen/Makefile.objs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7
merge last two lines, keep alphabetic order.
Signed-off-by: Cao jin
---
hw/xen/Makefile.objs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
index a9ad7e7..d367094 100644
--- a/hw/xen/Makefile.objs
+++ b/hw/xen/Makefile.objs
@@ -2
Am 29.12.2015 um 13:39 schrieb Cao jin:
> merge last two lines, keep alphabetic order.
>
> Signed-off-by: Cao jin
> ---
> hw/xen/Makefile.objs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/xen/Makefile.objs b/hw/xen/Makefile.objs
> index a9ad7e7..d367094 100644
>
Agree with your review point. Since can`t get contact with author
tiejun.c...@intel.com, maybe only can ask for test help from Stefano, I
will send next version when we get in touch with stefano.
On 12/29/2015 07:25 PM, Michael S. Tsirkin wrote:
On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao ji
On Thu, 24 Dec 2015 09:59:53 +0800
Zhu Guihua wrote:
>
> On 12/17/2015 05:58 AM, Igor Mammedov wrote:
> > On Wed, 16 Dec 2015 16:46:37 +0100
> > Andreas Färber wrote:
> >
> >> Am 10.12.2015 um 13:35 schrieb Igor Mammedov:
> >>> wrt CLI can't we do something like this?
> >>>
> >>> -device some-c
On 29 December 2015 at 09:43, Michael Tokarev wrote:
> All other architectures define get_sp_from_cpustate as an inline function,
> only unicore32 uses a #define. With this, some usages are impossible, for
> example, enabling sigaltstack in linux-user/syscall.c results in
>
> linux-user/syscall.c
* Add missing % before PRIx64
* Remove unneeded "" at end of format string in modified lines
This fixes a regression introduced in commit
c8ee0a445a6a85635e962c0346bc7b1259c1a3f5.
Signed-off-by: Stefan Weil
---
The patch should also be used for v2.5.1.
Happy New Year!
Stefan
trace-events | 1
On Fri, 25 Dec 2015 18:04:08 +0300
Roman Kagan wrote:
> Windows on UEFI systems is only capable of detecting the presence and
> the type of floppy drives via corresponding ACPI objects.
>
> Those objects are added in the last patch of the series; the three
> preceding ones pave the way to it, by
Hi,
In our production environment, we need to extend a qcow2 image with snapshots
in it. This feature, however, is not implemented yet.
So I want to ask, if this feature is under active development? How can I help
with this feature?
It seems that, this feature is not too difficult as long
> -Original Message-
> From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Wednesday, December 23, 2015 3:25 AM
> To: Krzeminski, Marcin (Nokia - PL/Wroclaw); Cédric Le Goater
> Cc: qemu-devel@nongnu.org Developers; Lenkow, Pawel (Nokia -
> PL/Wroclaw)
> Subject: Re: [
Public bug reported:
Launching qemu with "-device ivshmem,chardev=ivshmemid,msi=off -chardev
socket,path=/tmp/ivshmem_socket,id=ivshmemid"
Causes segfault because, s->msi_vectors is not initialized and
s->msi_vectors == 0.
Does ivshmem exactly need this line ? :
s->msi_vectors[vector].pdev = pd
On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote:
> On Fri, 25 Dec 2015 18:04:08 +0300
> Roman Kagan wrote:
>
> > Windows on UEFI systems is only capable of detecting the presence and
> > the type of floppy drives via corresponding ACPI objects.
> >
> > Those objects are added in th
>>> Separated from previous "igd-passthru convert to realize" patch. Since
>>> these two don`t have dependency, can send it solely.
>>>
>>> Not test since it is easy to find out if reading carefully, just
>>> compiled.
This patch works but the added conversion to LE is conceptually wrong.
The conv
On Tue, 29 Dec 2015 19:17:46 +0300
Roman Kagan wrote:
> On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote:
> > On Fri, 25 Dec 2015 18:04:08 +0300
> > Roman Kagan wrote:
> >
> > > Windows on UEFI systems is only capable of detecting the presence and
> > > the type of floppy drives vi
On Tue, Dec 29, 2015 at 07:17:46PM +0300, Roman Kagan wrote:
> On Tue, Dec 29, 2015 at 03:09:36PM +0100, Igor Mammedov wrote:
> > On Fri, 25 Dec 2015 18:04:08 +0300
> > Roman Kagan wrote:
> >
> > > Windows on UEFI systems is only capable of detecting the presence and
> > > the type of floppy driv
On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote:
>
>
> On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote:
> >As long as you keep up this vague talk about performance during
> >migration, without even bothering with any measurements, this patchset
> >will keep going nowhere.
> >
>
> I m
On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote:
> On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote:
>>
>>
>> On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote:
>> >As long as you keep up this vague talk about performance during
>> >migration, without even bothering with any mea
On Tue, Dec 29, 2015 at 09:04:51AM -0800, Alexander Duyck wrote:
> On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote:
> > On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote:
> >>
> >>
> >> On 12/25/2015 8:11 PM, Michael S. Tsirkin wrote:
> >> >As long as you keep up this vague tal
This patch solves the few problems that needed to be solved in order for a
Mac OS 10.4 guest to use the rtl8139 nic.
The pci_dma_read() function would only return zero when a MemoryRegion object
was not enabled. Enabling the object makes the pci_dma_read() function work
correctly.
The Linux rtl8
Put the 0-640KiB range in the first node with memory. This also prevents
mem_len to underflow when node 0 size is 0. Tested with Linux.
Signed-off-by: Thadeu Lima de Souza Cascardo
---
hw/i386/acpi-build.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/i386/ac
On Tue, Dec 29, 2015 at 9:15 AM, Michael S. Tsirkin wrote:
> On Tue, Dec 29, 2015 at 09:04:51AM -0800, Alexander Duyck wrote:
>> On Tue, Dec 29, 2015 at 8:46 AM, Michael S. Tsirkin wrote:
>> > On Tue, Dec 29, 2015 at 01:42:14AM +0800, Lan, Tianyu wrote:
>> >>
>> >>
>> >> On 12/25/2015 8:11 PM, Mi
On 17/12/15 20:54, Richard Henderson wrote:
> The primary focus of this patch set is to reduce the number of
> helpers that modify TCG globals, and thus increase the lifetime
> of those globals within each TB, and thus decrease the number
> of times that tcg must spill and fill them from backing s
Markus Armbruster writes:
> Lluís Vilanova writes:
>> Adds a special error object that transforms error messages into
>> immediately reported warnings.
> Before I dive into details: my fundamental objection is that &error_warn
> is new infrastructure without a use. The new "this is how you shou
On 29/12/15 17:59, Programmingkid wrote:
> This patch solves the few problems that needed to be solved in order for a
> Mac OS 10.4 guest to use the rtl8139 nic.
>
> The pci_dma_read() function would only return zero when a MemoryRegion object
> was not enabled. Enabling the object makes the pci
On Dec 29, 2015, at 4:04 PM, Mark Cave-Ayland wrote:
> On 29/12/15 17:59, Programmingkid wrote:
>
>> This patch solves the few problems that needed to be solved in order for a
>> Mac OS 10.4 guest to use the rtl8139 nic.
>>
>> The pci_dma_read() function would only return zero when a MemoryReg
On Tue, Nov 10, 2015 at 6:25 AM, Juan Quintela wrote:
> From: "Dr. David Alan Gilbert"
>
> RAMBlocks that are not a multiple of host pages in length
> cause problems for postcopy (I've seen an ACPI table on aarch64
> be 5k in length - i.e. 5x target-page), so round RAMBlock sizes
> up to a host-p
On Dec 29, 2015, at 7:05 PM, Programmingkid wrote:
>
> On Dec 29, 2015, at 4:04 PM, Mark Cave-Ayland wrote:
>
>> On 29/12/15 17:59, Programmingkid wrote:
>>
>>> This patch solves the few problems that needed to be solved in order for a
>>> Mac OS 10.4 guest to use the rtl8139 nic.
>>>
>>> Th
From: Chen Gang
When mapping MAP_ANONYMOUS memory fragments, still need notice about to
set it zero, or it will cause issues.
Signed-off-by: Chen Gang
---
linux-user/mmap.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 7
From: Chen Gang
It is a temporary fix for i386 target system running Windows.
Also remove useless variable 'p'.
Signed-off-by: Chen Gang
---
linux-user/mmap.c | 22 +++---
1 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
i
Le 30/12/2015 02:10, cheng...@emindsoft.com.cn a écrit :
> From: Chen Gang
>
> When mapping MAP_ANONYMOUS memory fragments, still need notice about to
> set it zero, or it will cause issues.
>
> Signed-off-by: Chen Gang
> ---
> linux-user/mmap.c |4 +++-
> 1 files changed, 3 insertions(+
Hello all:
This patch is only for a discussion, I guess this patch is valuable for
i386 wine running Windows.
Theoretically, this patch is incorrect, we have to implement softmmu to
support different host and target pages (e.g. host 8KB, target 4KB):
- If host 8KB is mapped as PRIVATE | FIXED,
Hi Paolo
On 12/30/2015 12:25 AM, Paolo Bonzini wrote:
Separated from previous "igd-passthru convert to realize" patch. Since
these two don`t have dependency, can send it solely.
Not test since it is easy to find out if reading carefully, just
compiled.
This patch works but the added conversio
During nbd_send_negotiate, if the client simply doesn't respond, the function
will not return, and the whole event loop is blocked.
Make the I/O effectively asynchronous by using coroutine read/write, so that a
malicious or disappeared client cannot make a hang.
Fam
Fam Zheng (2):
nbd: Interf
In preparation for an async implementation, introduce a callback and
move the shutdown/close to the function.
Signed-off-by: Fam Zheng
---
blockdev-nbd.c | 5 ++---
include/block/nbd.h | 6 --
nbd.c | 20 +++-
qemu-nbd.c | 16 +---
4
Create a coroutine in nbd_client_new, so that nbd_send_negotiate doesn't
need qemu_set_block().
A handler is needed for csock fd in case the coroutine yields during
I/O.
With this, if the other end disappears in the middle of the negotiation,
we don't block the whole event loop.
Signed-off-by: F
From: Prasad J Pandit
While doing ioport r/w oprations, ne2000 device emulation suffers
from OOB r/w error. Update respective array bounds check to avoid
OOB access.
Reported-by: Ling Liu
Signed-off-by: Prasad J Pandit
---
hw/net/ne2000.c | 34 --
1 file change
From: Prasad J Pandit
Hello,
An OOB r/w issue in ne2000 device emulation was reported by Mr Ling Liu, CC'd
here. The issue occurs while doing ne2000 ioport r/w operations, due to
incorrect array bounds checks.
Below is a proposed (tested)patch to fix this issue. Does it look okay?
Thank you.
-
64 matches
Mail list logo
