[Qemu-devel] [PATCH] fixup! tests: Use proper functions types instead of void (*fn)

2015-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/libqtest.c | 5 +++-- tests/libqtest.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index c52ceb2..fa314e1 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -760,14 +760,15 @@ void qt

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2015-12-04 Thread Michael S. Tsirkin
On Fri, Dec 04, 2015 at 02:42:36PM +0800, Lan, Tianyu wrote: > > On 12/2/2015 10:31 PM, Michael S. Tsirkin wrote: > >>>We hope > >>>to find a better way to make SRIOV NIC work in these cases and this is > >>>worth to do since SRIOV NIC provides better network performance compared > >>>with PV NIC.

Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

2015-12-04 Thread Markus Armbruster
David Gibson writes: > On Thu, Dec 03, 2015 at 04:30:31PM +0100, Markus Armbruster wrote: >> 1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR >>connectors", the indexes were small integers: >> >>(qemu) info qom-tree >>/machine (pseries-2.4-machine) >>

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

2015-12-04 Thread Markus Armbruster
Eric Blake writes: > On 12/03/2015 04:54 PM, David Gibson wrote: >> On Thu, Dec 03, 2015 at 05:37:39PM +0100, Markus Armbruster wrote: >>> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't >>> visit anything. object_property_get_qobject() happily >>> object_property_get_qobjec

Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation

2015-12-04 Thread Aurelien Jarno
On 2015-12-03 13:19, Aurelien Jarno wrote: > On 2015-12-02 10:36, Richard Henderson wrote: > > On 12/01/2015 08:32 AM, Aurelien Jarno wrote: > > >On 2015-12-01 08:19, Richard Henderson wrote: > > >>If there are a lot of guest memory ops in the TB, the amount of > > >>code generated by tcg_out_tb_fi

Re: [Qemu-devel] [PATCH v2 1/5] vmxnet3: Change offsets of msi/msix pci capabilities

2015-12-04 Thread Jason Wang
On 12/02/2015 11:26 PM, Shmulik Ladkani wrote: > Place device reported PCI capabilities at the same offsets as placed by > the VMware virtual hardware: MSI at [84], MSI-X at [9c]. > > For compatability, preserve old offsets using 'x-old-msi-offsets' toggle. > > Signed-off-by: Shmulik Ladkani > -

Re: [Qemu-devel] [PATCH v2 4/5] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-04 Thread Jason Wang
On 12/02/2015 11:26 PM, Shmulik Ladkani wrote: > Report the 'express endpoint' capability if on a PCIE bus. > > The 'x-disable-pcie' property is used for backwards compatability. > > Signed-off-by: Shmulik Ladkani > --- > hw/net/vmxnet3.c| 55 > +

Re: [Qemu-devel] [PATCH] tests/vhost-user-test: Fix potential use-after-free

2015-12-04 Thread David Gibson
On Wed, Dec 02, 2015 at 05:36:49AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > ae31fb5 "vhost-user-test: wrap server in TestServer struct" cleaned up > > the handling of the test server in vhost-user-test. Unfortunately it > > introduced a subtle use-after-free if a

Re: [Qemu-devel] [RFC PATCH 7/9] net/colo-proxy: add packet enqueue and handle function

2015-12-04 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > Hi,Dave > > > On 12/03/2015 05:09 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>Hi,Dave > >> > >>On 12/02/2015 12:12 AM, Dr. David Alan Gilbert wrote: > >>>* Zhang Chen (zhangchen.f...@cn.fujitsu.

[Qemu-devel] [PATCH 2/2] net/vmxnet3: remove redundant VMW_SHPRN(...) definition

2015-12-04 Thread Miao Yan
Macro VMW_SHPRN(...) is already defined vmxnet3_debug.h, so remove the duplication Signed-off-by: Miao Yan --- hw/net/vmware_utils.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/net/vmware_utils.h b/hw/net/vmware_utils.h index 1099df6..c2c2f90 100644 --- a/hw/net/vm

[Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3

2015-12-04 Thread Miao Yan
Vmxnet3 uses the following debug macro style: #ifdef SOME_DEBUG # define debug(...) do{ printf(...); } while (0) # else # define debug(...) do{ } while (0) #endif If SOME_DEBUG is undefined, then format string inside the debug macro will never be checked by compiler. Code will likely to br

Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

2015-12-04 Thread David Gibson
On Fri, Dec 04, 2015 at 09:05:51AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > On Thu, Dec 03, 2015 at 04:30:31PM +0100, Markus Armbruster wrote: > >> 1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR > >>connectors", the indexes were small integers: > >> > >>

Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

2015-12-04 Thread Markus Armbruster
David Gibson writes: > On Fri, Dec 04, 2015 at 09:05:51AM +0100, Markus Armbruster wrote: >> David Gibson writes: >> >> > On Thu, Dec 03, 2015 at 04:30:31PM +0100, Markus Armbruster wrote: >> >> 1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR >> >>connectors", the indexes w

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-12-04 Thread Gerd Hoffmann
Hi, > btw some questions here: > > for non-gl and gl rendering in Qemu, are they based on dma-buf already? > once we can export guest framebuffer in dma-buf, is there additional work > required or just straightforward to integrate with SPICE? Right now we are busy integrating dma-buf support

Re: [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost

2015-12-04 Thread Cornelia Huck
On Fri, 4 Dec 2015 10:06:58 +0800 Jason Wang wrote: > The problem is for pci: without this patch, guest may always see modern > bar is "disable-modern=false". But with this patch, on an old kernel > that does not support VERSION_1, even "disable-modern=false" were > specified, guest can not see m

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-04 Thread 阎淼
2015-12-04 0:40 GMT+08:00 Markus Armbruster : > Eric Blake writes: > >> On 12/02/2015 10:08 PM, Miao Yan wrote: >>> Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). >>> This will cause build error when debug level is raised in >>> vmxnet3_debug.h (enable all VMXNET3_DEBUG

Re: [Qemu-devel] [PULL 0/3] ppc-for-2.5 queue 20151204

2015-12-04 Thread Peter Maydell
son/qemu.git tags/ppc-for-2.5-20151204 > > for you to fetch changes up to ab8bf1d735133df5b5847bef0b0bea496d614a5a: > > spapr_drc: Change value of property "fdt" from null back to {} (2015-12-04 > 16:50:59 +1100) > > > Peter, > > Not sure if you need a

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 07:30, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 September 2015 at 17:57, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 7 September 2015 at 17:40, Markus Armbruster wrote: > Peter Maydell writes: > >> Convert the pxa2xx_mmci

Re: [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data

2015-12-04 Thread Juan Quintela
Liang Li wrote: > This patch fixed the flaws in qemu_put_compression_data function. > and cleanup the code based on the change. Hi We are in hard freeze. My understanding is that this are "optimizations" that can wait for 2.6: - my understanding from commit from message one and from quick look

Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

2015-12-04 Thread Juan Quintela
Liang Li wrote: > There are some flaws in qemu_put_compression_data, this patch tries > to fix it. Now it can be used by other code. > > Signed-off-by: Liang Li > --- > migration/qemu-file.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/migration/qemu-file.c

Re: [Qemu-devel] Networking documentation for a Mac OS X guest

2015-12-04 Thread Mark Cave-Ayland
On 04/12/15 00:02, Peter Maydell wrote: > On 3 December 2015 at 23:24, Programmingkid wrote: >> I would like to make a little tutorial on how to make networking >> work for a Mac OS X guest. Where would you suggest I put such >> documentation? The qemu-doc file is what I was thinking about using.

Re: [Qemu-devel] [PULL for-2.5 0/9] Trivial patches for 2015-12-04

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 06:57, Michael Tokarev wrote: > Hello. > > During the freeze period, let me please add my trivial pull request too ;) > > There are just 9 patches this time, which are either (small) bugfixes, > or just prettifying one or another part of code to look nicely in the > release t

Re: [Qemu-devel] Networking documentation for a Mac OS X guest

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 11:36, Mark Cave-Ayland wrote: > Is it worth setting up per-arch homepages on the wiki? This is something > I've thought about recently since most of the information out on the > internet regarding QEMU's ability to run various systems is badly out of > date with regard to SP

Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 10:11, Markus Armbruster wrote: > If you want it to be null in 2.5, NAK "[PATCH for-2.5 2/3] spapr_drc: > Change value of property "fdt" from null back to {}". That commit is now in master, so if you don't want it you need to actively send a revert for it. thanks -- PMM

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-04 Thread Markus Armbruster
阎淼 writes: > 2015-12-04 0:40 GMT+08:00 Markus Armbruster : >> Eric Blake writes: >> >>> On 12/02/2015 10:08 PM, Miao Yan wrote: Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). This will cause build error when debug level is raised in vmxnet3_debug.h (ena

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2015-12-04 Thread Lan, Tianyu
On 12/4/2015 4:05 PM, Michael S. Tsirkin wrote: I haven't read it, but I would like to note you can't rely on research papers. If you propose a patch to be merged you need to measure what is its actual effect on modern linux at the end of 2015. Sure. Will do that.

[Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Paolo Bonzini
This is a first baby step towards removing widespread inclusion of cpu.h and compiling more devices once (so that arm, aarch64 and in the future target-multi can share the object files). Signed-off-by: Paolo Bonzini --- hw/dma/soc_dma.c | 37 - 1 file changed,

[Qemu-devel] [PATCH] arm: explicitly mark loads as little-endian

2015-12-04 Thread Paolo Bonzini
ARM softmmu is always compiled as little endian; BE8/BE32 can be done as part of CPU emulation. Thus, devices need not use the endian-dependent loads and swaps. Signed-off-by: Paolo Bonzini --- hw/display/omap_lcd_template.h | 4 ++-- hw/display/pxa2xx_lcd.c| 8 2 files changed

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:28, Paolo Bonzini wrote: > This is a first baby step towards removing widespread inclusion of > cpu.h and compiling more devices once (so that arm, aarch64 and > in the future target-multi can share the object files). > > Signed-off-by: Paolo Bonzini > --- > hw/dma/soc_d

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 13:33, Peter Maydell wrote: > On 4 December 2015 at 12:28, Paolo Bonzini wrote: >> This is a first baby step towards removing widespread inclusion of >> cpu.h and compiling more devices once (so that arm, aarch64 and >> in the future target-multi can share the object files). >> >>

[Qemu-devel] [PATCH v2] net: convert qemu_log to error_report, fix message

2015-12-04 Thread Paolo Bonzini
Ensure that the error is printed with the proper timestamp. Signed-off-by: Paolo Bonzini --- v1->v2: remove reference to -net dump, dumping can be a network filter --- net/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dump.c b/net/dump.c index ce16a4b..1c

Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

2015-12-04 Thread Amit Shah
On (Fri) 04 Dec 2015 [11:53:09], Liang Li wrote: > There are some flaws in qemu_put_compression_data, this patch tries > to fix it. Now it can be used by other code. Can you please write a better description here? What are the flaws? What is being fixed? What other users, and how is it now safer

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Markus Armbruster
Peter Maydell writes: > On 4 December 2015 at 07:30, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 September 2015 at 17:57, Markus Armbruster wrote: Peter Maydell writes: > On 7 September 2015 at 17:40, Markus Armbruster wrote: >> Peter Maydell writes:

Re: [Qemu-devel] [PATCH] arm: explicitly mark loads as little-endian

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:28, Paolo Bonzini wrote: > ARM softmmu is always compiled as little endian; BE8/BE32 can be > done as part of CPU emulation. Thus, devices need not use the > endian-dependent loads and swaps. The patch code is right, but I think the more significant point here is that th

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:50, Markus Armbruster wrote: > To finally answer your question: the proper owner of the property > connecting the backend is the frontend half of the split device. So, if > we have separate device models for controller and the block devices > connected to it, the block ba

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Markus Armbruster
Paolo Bonzini writes: > This is a first baby step towards removing widespread inclusion of > cpu.h and compiling more devices once (so that arm, aarch64 and > in the future target-multi can share the object files). Sounds like something that should be covered in http://qemu-project.org/CodeTrans

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

2015-12-04 Thread Markus Armbruster
Peter Maydell writes: > On 4 December 2015 at 12:50, Markus Armbruster wrote: >> To finally answer your question: the proper owner of the property >> connecting the backend is the frontend half of the split device. So, if >> we have separate device models for controller and the block devices >>

[Qemu-devel] [PATCH v2] scripts/gdb: Fix a python exception in mtree.py

2015-12-04 Thread Yang Wei
The following exception is threw: Python Exception name 'long' is not defined: Error occurred in Python command: name 'long' is not defined Python 2.4+, int()/long() have been unified, so replace long with int. Signed-off-by: Yang Wei --- scripts/qemugdb/mtree.py | 10 +- 1 file change

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:36, Paolo Bonzini wrote: > > > On 04/12/2015 13:33, Peter Maydell wrote: >> On 4 December 2015 at 12:28, Paolo Bonzini wrote: >>> This is a first baby step towards removing widespread inclusion of >>> cpu.h and compiling more devices once (so that arm, aarch64 and >>> in

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs

2015-12-04 Thread Kevin Wolf
Am 30.11.2015 um 15:51 hat Alberto Garcia geschrieben: > On Mon 23 Nov 2015 04:59:42 PM CET, Kevin Wolf wrote: > > > @@ -370,11 +371,22 @@ static void mirror_exit(BlockJob *job, void *opaque) > > if (s->to_replace) { > > to_replace = s->to_replace; > > } > > + > > +

Re: [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3

2015-12-04 Thread Eric Blake
On 12/04/2015 02:19 AM, Miao Yan wrote: > Vmxnet3 uses the following debug macro style: > When sending a patch series, it's best to include a 0/2 cover letter (some of the maintainer tooling works better if it can reply to the cover letter). Also, this patch depends on your earlier patch "net/vm

Re: [Qemu-devel] [PATCH] ivshmem: Store file descriptor for vhost-user negotiation

2015-12-04 Thread Marc-André Lureau
Hi On Fri, Dec 4, 2015 at 4:52 AM, Tetsuya Mukawa wrote: > If virtio-net driver allocates memory in vishmem shared memory, s/vishmem/ivshmem How can virtio-net allocate memory in ivshmem memory bar? What's the use case or test case? > vhost-net will work correctly, but vhost-user will not wor

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

2015-12-04 Thread Eric Blake
On 12/03/2015 10:55 AM, Markus Armbruster wrote: > I'm incapable of proof-reading anything I wrote myself %-} I know the feeling :) > > prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't > visit anything. object_property_get_qobject() happily calls > qmp_output_ge

Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic

2015-12-04 Thread Igor Mammedov
On Thu, 3 Dec 2015 15:16:21 -0200 Eduardo Habkost wrote: > On Thu, Dec 03, 2015 at 04:19:19PM +0100, Igor Mammedov wrote: > > On Wed, 2 Dec 2015 20:22:45 -0200 > > Eduardo Habkost wrote: > > > > > This series removes piix-specific and q35-specific code from > > > acpi-build.c, making it generi

Re: [Qemu-devel] [PATCH for 2.6 v3 1/1] qemu-char: append opt to stop truncation of serial file

2015-12-04 Thread Eric Blake
On 12/03/2015 11:42 PM, Denis V. Lunev wrote: > From: Olga Krishtal > > Our QA team wants to preserve serial output of the guest in between QEMU > runs to perform post-analysis. > > By default this behavior is off (file is truncated each time QEMU is > started or device is plugged). > > Signed-

Re: [Qemu-devel] [PATCH for 2.6 v3 1/1] qemu-char: append opt to stop truncation of serial file

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 07:42, Denis V. Lunev wrote: > From: Olga Krishtal > > Our QA team wants to preserve serial output of the guest in between QEMU > runs to perform post-analysis. > > By default this behavior is off (file is truncated each time QEMU is > started or device is plugged). > > Signed-o

[Qemu-devel] [PATCH v3 02/21] block: Fix reopen with semantically overlapping options

2015-12-04 Thread Kevin Wolf
This fixes bdrv_reopen() calls like the following one: qemu-io -c 'open -o overlap-check.template=all /tmp/test.qcow2' \ -c 'reopen -o overlap-check=none' The approach taken so far would result in an options QDict that has both "overlap-check.template=all" and "overlap-check=none", which

[Qemu-devel] [PATCH v3 10/21] block: reopen: Document option precedence and refactor accordingly

2015-12-04 Thread Kevin Wolf
The interesting part of reopening an image is from which sources the effective options should be taken, i.e. which options take precedence over which other options. This patch documents the precedence that will be implemented in the following patches. It also refactors bdrv_reopen_queue(), so that

[Qemu-devel] [PATCH v3 03/21] mirror: Error out when a BDS would get two BBs

2015-12-04 Thread Kevin Wolf
bdrv_replace_in_backing_chain() asserts that not both old and new BlockDdriverState have a BlockBackend attached to them because both would have to end up pointing to the new BDS and we don't support more than one BB per BDS yet. Before we can safely allow references to existing nodes as backing f

[Qemu-devel] [PATCH v3 01/21] qcow2: Add .bdrv_join_options callback

2015-12-04 Thread Kevin Wolf
qcow2 accepts a few driver-specific options that overlap semantically (e.g. "overlap-check" is an alias of "overlap-check.template", and any missing cache size option is derived from the given ones). When bdrv_reopen() merges the set of updated options with left out options that should be kept at

[Qemu-devel] [PATCH v3 07/21] block: Pass driver-specific options to .bdrv_refresh_filename()

2015-12-04 Thread Kevin Wolf
In order to decide whether a blkdebug: filename can be produced or a json: one is necessary, blkdebug checked whether bs->options had more options than just "config", "x-image" or "image" (the latter including nested options). That doesn't work well when generic block layer options are present. Th

[Qemu-devel] [PATCH v3 08/21] block: Keep "driver" in bs->options

2015-12-04 Thread Kevin Wolf
Instead of passing a separate drv argument to bdrv_open_common(), just make sure that a "driver" option is set in the QDict. This also means that a "driver" entry is consistently present in bs->options now. This is another step towards keeping all options in the QDict (which is the represenation o

[Qemu-devel] [PATCH v3 00/21] block: Cache mode for children etc.

2015-12-04 Thread Kevin Wolf
This is part three (or four, depending on whether you count the bdrv_swap removal) of what I had sent earlier as "[PATCH 00/34] block: Cache mode for children, reopen overhaul and more". Most of the patches were actually already reviewed in v1. This part contains the remaining functional changes t

[Qemu-devel] [PATCH v3 04/21] block: Allow references for backing files

2015-12-04 Thread Kevin Wolf
For bs->file, using references to existing BDSes has been possible for a while already. This patch enables the same for bs->backing. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 48 +--- block/mirror.c| 2 +- i

[Qemu-devel] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive

2015-12-04 Thread Kevin Wolf
Creating an empty drive while specifying 'format' doesn't make sense. The specified format driver would simply be ignored. Make a set 'format' option an indication that a non-empty drive should be created. This makes 'format' consistent with 'driver' and allows using it with a block driver that do

[Qemu-devel] [PATCH v3 06/21] block: Exclude nested options only for children in append_open_options()

2015-12-04 Thread Kevin Wolf
Some drivers have nested options (e.g. blkdebug rule arrays), which don't belong to a child node and shouldn't be removed. Don't remove all options with "." in their name, but check for the complete prefixes of actually existing child nodes. Signed-off-by: Kevin Wolf --- block.c

[Qemu-devel] [PATCH v3 05/21] block: Consider all block layer options in append_open_options

2015-12-04 Thread Kevin Wolf
The code already special-cased "node-name", which is currently the only option passed in the QDict that isn't driver-specific. Generalise the code to take all general block layer options into consideration. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Al

[Qemu-devel] [PATCH v3 17/21] block: Move cache options into options QDict

2015-12-04 Thread Kevin Wolf
This adds the cache mode options to the QDict, so that they can be specified for child nodes (e.g. backing.cache.direct=off). The cache modes are not removed from the flags at this point; instead, options and flags are kept in sync. If the user specifies both flags and options, the options take pr

[Qemu-devel] [PATCH v3 16/21] block: reopen: Extract QemuOpts for generic block layer options

2015-12-04 Thread Kevin Wolf
This patch adds a QemuOpts for generic block layer options to bdrv_reopen_prepare(). The only two options that currently exist (node-name and driver) cannot be changed, so the only thing we do is putting them right back into the QDict so that we check at the end that they are indeed unchanged. We

[Qemu-devel] [PATCH v3 09/21] block: Allow specifying child options in reopen

2015-12-04 Thread Kevin Wolf
If the child was defined in the same context (-drive argument or blockdev-add QMP command) as its parent, a reopen of the parent should work the same and allow changing options of the child. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c | 12 +

Re: [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost

2015-12-04 Thread Michael S. Tsirkin
On Fri, Dec 04, 2015 at 11:15:48AM +0100, Cornelia Huck wrote: > On Fri, 4 Dec 2015 10:06:58 +0800 > Jason Wang wrote: > > > The problem is for pci: without this patch, guest may always see modern > > bar is "disable-modern=false". But with this patch, on an old kernel > > that does not support V

[Qemu-devel] [PATCH v3 12/21] block: Split out parse_json_protocol()

2015-12-04 Thread Kevin Wolf
The next patch distinguishes options that were explicitly set and options that were derived. bdrv_fill_option() added options of both types: Options given by json: syntax should be counted as explicit, but the rest is derived. In preparation for the distinction, move json: parse to a separate func

[Qemu-devel] [PATCH v3 15/21] qemu-iotests: Remove cache mode test without medium

2015-12-04 Thread Kevin Wolf
Specifying the cache mode for a driver without a medium is not a useful thing to do: As long as there is no medium, the cache mode doesn't make a difference, and once the 'change' command is used to insert a medium, it ignores the old cache mode and makes the new medium use cache=writethrough. Lat

[Qemu-devel] [PATCH v3 11/21] block: Add infrastructure for option inheritance

2015-12-04 Thread Kevin Wolf
Options are not actually inherited from the parent node yet, but this commit lays the grounds for doing so. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 52 --- include/block/block_int.h | 3 ++- 2 files changed, 3

Re: [Qemu-devel] [PATCH 2/2] net/vmxnet3: remove redundant VMW_SHPRN(...) definition

2015-12-04 Thread Eric Blake
On 12/04/2015 02:19 AM, Miao Yan wrote: > Macro VMW_SHPRN(...) is already defined vmxnet3_debug.h, > so remove the duplication > > Signed-off-by: Miao Yan > --- > hw/net/vmware_utils.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Eric Blake > > diff --git a/hw/net

[Qemu-devel] [PATCH v3 18/21] blkdebug: Enable reopen

2015-12-04 Thread Kevin Wolf
Just reopening the children (as block.c does now) is enough. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block/blkdebug.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 48b0812..7132e2c 100644 --- a/bloc

[Qemu-devel] [PATCH v3 13/21] block: Introduce bs->explicit_options

2015-12-04 Thread Kevin Wolf
bs->options doesn't only contain options that the user explicitly requested, but also option that were derived from flags, the filename or inherited from the parent node. For reopen, it is important to know the difference because reopening the parent can change inherited values in child nodes, but

[Qemu-devel] [PATCH v3 21/21] qemu-iotests: Test reopen with node-name/driver options

2015-12-04 Thread Kevin Wolf
'node-name' and 'driver' should not be changed during a reopen operation. It is, however, valid to specify them with the same value as they already had. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/133 | 90 ++ tests/qem

[Qemu-devel] [PATCH v3 19/21] qemu-iotests: Try setting cache mode for children

2015-12-04 Thread Kevin Wolf
This is a basic test for specifying cache modes for child nodes on the command line. It doesn't take much time and works without O_DIRECT support. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/051 | 10 +++- tests/qemu-iotests/051.out | 60 +

[Qemu-devel] [PATCH v3 20/21] qemu-iotests: Test cache mode option inheritance

2015-12-04 Thread Kevin Wolf
This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen can specify options for child nodes and that cache modes are correctly inherited from parent nodes where they are not specified. Sig

Re: [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data

2015-12-04 Thread Li, Liang Z
> Hi > > We are in hard freeze. My understanding is that this are "optimizations" that > can wait for 2.6: > - my understanding from commit from message one and from quick look at > the code is that this change is not needed for current users, is that > correct? > - we avoid a copy at the begi

Re: [Qemu-devel] Linux vhost-user interrupt management fixes

2015-12-04 Thread Didier Pallard
On 12/03/2015 10:53 AM, Didier Pallard wrote: Hi, I recently did some stress tests of a vhost-user interface using an UDP traffic generator. Traffic generator was connected to 2 physical ports that are in turn connected to 2 virtio ports through a linux bridge, VM (running linux) doing routing t

[Qemu-devel] [PATCH] sdhci: Make device "sdhci-pci" unavailable with -device again

2015-12-04 Thread Markus Armbruster
We made it unavailable in commit 1910913 because its use of drive_get_next() instead of a property. Commit 5ec911c replaced drive_get_next() and made the device available, but the property isn't quite right, and the code dangerously ignores blk_attach_dev() failure. Disable it again before the pr

Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic

2015-12-04 Thread Eduardo Habkost
On Fri, Dec 04, 2015 at 02:24:41PM +0100, Igor Mammedov wrote: > On Thu, 3 Dec 2015 15:16:21 -0200 > Eduardo Habkost wrote: > > > On Thu, Dec 03, 2015 at 04:19:19PM +0100, Igor Mammedov wrote: > > > On Wed, 2 Dec 2015 20:22:45 -0200 > > > Eduardo Habkost wrote: > > > > > > > This series remove

Re: [Qemu-devel] [PATCH v3 6/8] hw/arm/virt-acpi-build: Add _E03 for Power Button

2015-12-04 Thread Igor Mammedov
On Mon, 16 Nov 2015 21:23:07 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Tested-by: Wei Huang > --- > hw/arm/virt-acpi-build.c | 13 ++

Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

2015-12-04 Thread Li, Liang Z
> > There are some flaws in qemu_put_compression_data, this patch tries to > > fix it. Now it can be used by other code. > > > > Signed-off-by: Liang Li > > --- > > migration/qemu-file.c | 10 +- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/migration/qemu-file.c

Re: [Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

2015-12-04 Thread Li, Liang Z
> On (Fri) 04 Dec 2015 [11:53:09], Liang Li wrote: > > There are some flaws in qemu_put_compression_data, this patch tries to > > fix it. Now it can be used by other code. > > Can you please write a better description here? What are the flaws? > What is being fixed? What other users, and how is

Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type by u32

2015-12-04 Thread Denis V. Lunev
On 12/02/2015 03:22 PM, Paolo Bonzini wrote: On 30/11/2015 17:22, Andrey Smetanin wrote: enum hv_message_type inside struct hv_message, hv_post_message is not size portable. Replace enum by u32. It's only non-portable inside structs. Okay to apply just these: @@ -172,7 +174,7 @@ union hv_mes

Re: [Qemu-devel] [PATCH] sdhci: Make device "sdhci-pci" unavailable with -device again

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 15:07, Markus Armbruster wrote: > We made it unavailable in commit 1910913 because its use of > drive_get_next() instead of a property. Commit 5ec911c replaced > drive_get_next() and made the device available, but the property isn't > quite right, and the code dangerously ignores b

Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type by u32

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 15:33, Denis V. Lunev wrote: > On 12/02/2015 03:22 PM, Paolo Bonzini wrote: >> >> On 30/11/2015 17:22, Andrey Smetanin wrote: >>> enum hv_message_type inside struct hv_message, hv_post_message >>> is not size portable. Replace enum by u32. >> It's only non-portable inside structs.

[Qemu-devel] [PATCH] xen_disk: treat "vhd" as "vpc"

2015-12-04 Thread Stefano Stabellini
The Xen toolstack uses "vhd" to specify a disk in VHD format, however the name of the driver in QEMU is "vpc". Replace "vhd" with "vpc", so that QEMU can find the right driver to use for it. Signed-off-by: Stefano Stabellini diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 267d8a8..3

[Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper

2015-12-04 Thread Denis V. Lunev
This would be useful in the next step when QMP version of this call will be introduced. Signed-off-by: Denis V. Lunev Reviewed-by: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 38 +++--- 1 file changed, 23 insertion

[Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

2015-12-04 Thread Denis V. Lunev
EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HMP for this operation. This create snapshot/delete snapshot sequence

[Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2015-12-04 Thread Denis V. Lunev
Unfortunately load_vmstate has a return code (int) and this code is checked in the other places. Thus we could not just rename it to qmp_loadvm as returns void. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 12

[Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-04 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Mar

[Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2015-12-04 Thread Denis V. Lunev
The patch also moves hmp_delvm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- hmp.c | 11 +

[Qemu-devel] [PATCH 4/5] migration: improve error reporting for load_vmstate

2015-12-04 Thread Denis V. Lunev
The patch adds Error ** parameter to load_vmstate call and fills error inside. The caller after that properly reports error either through monitor or via local stderr facility during VM start. This helper will be useful too for qmp_loadvm implementation. Signed-off-by: Denis V. Lunev CC: Juan Qu

Re: [Qemu-devel] [PATCH] ivshmem: Store file descriptor for vhost-user negotiation

2015-12-04 Thread Tetsuya Mukawa
2015-12-04 22:20 GMT+09:00 Marc-André Lureau : > Hi > > On Fri, Dec 4, 2015 at 4:52 AM, Tetsuya Mukawa wrote: >> If virtio-net driver allocates memory in vishmem shared memory, > > s/vishmem/ivshmem Thanks, I will fix it. > > How can virtio-net allocate memory in ivshmem memory bar? > > What's t

Re: [Qemu-devel] [PATCH v3 0/3] target-i386: add memory protection-key support

2015-12-04 Thread Eduardo Habkost
On Wed, Nov 18, 2015 at 10:20:14AM +0800, Huaitong Han wrote: > Changes in v3: > *Fix cpuid_7_0_ecx_feature_name error. > > Changes in v2: > *Fix memcpy error for xsave state. > *Fix TCG_7_0_ECX_FEATURES to 0. > *Make subjects more readable. > > The protection-key feature provides an additional m

Re: [Qemu-devel] [PATCH] sdhci: Make device "sdhci-pci" unavailable with -device again

2015-12-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 04/12/2015 15:07, Markus Armbruster wrote: >> We made it unavailable in commit 1910913 because its use of >> drive_get_next() instead of a property. Commit 5ec911c replaced >> drive_get_next() and made the device available, but the property isn't >> quite right, and th

[Qemu-devel] [PATCH v3 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-04 Thread Eduardo Habkost
target-i386/cpu.c:ext_save_area uses magic numbers for the xsave area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() uses offset macros and bit manipulation to access the xsave area. This series changes both to use C structs for those operations. I still need to figure out a way to

[Qemu-devel] [PATCH v3 2/3] target-i386: Use xsave structs for ext_save_area

2015-12-04 Thread Eduardo Habkost
This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduar

[Qemu-devel] [PATCH v3 1/3] target-i386: Define structs for layout of xsave area

2015-12-04 Thread Eduardo Habkost
Add structs that define the layout of the xsave areas used by Intel processors. Add some QEMU_BUILD_BUG_ON lines to ensure the structs match the XSAVE_* macros in target-i386/kvm.c and the offsets and sizes at target-i386/cpu.c:ext_save_areas. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2:

[Qemu-devel] [PATCH v3 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load

2015-12-04 Thread Eduardo Habkost
Instead of using offset macros and bit operations in a uint32_t array, use the X86XSaveArea struct to perform the loading/saving operations in kvm_put_xsave() and kvm_get_xsave(). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use uint8_t pointers when loading/saving xmm, ymmh, zmmh, ke

Re: [Qemu-devel] [PATCH QEMU-XEN v6 5/8] xen: Switch uses of xc_map_foreign_{pages, bulk} to use libxenforeignmemory API.

2015-12-04 Thread Stefano Stabellini
On Thu, 3 Dec 2015, Ian Campbell wrote: > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h > index 2cadd4f..8fbaf07 100644 > --- a/include/hw/xen/xen_common.h > +++ b/include/hw/xen/xen_common.h > @@ -41,6 +41,7 @@ static inline void *xc_map_foreign_bulk(int xc_handle, > uint

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-04 Thread Stefano Stabellini
On Thu, 3 Dec 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxenforeignmemory which provides access to > privileged foreign mappings

[Qemu-devel] [PATCH v6 2/4] kobject: export kset_find_obj() for module use

2015-12-04 Thread Gabriel L. Somlo
From: Gabriel Somlo Signed-off-by: Gabriel Somlo --- lib/kobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kobject.c b/lib/kobject.c index 7cbccd2..90d1be6 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -861,6 +861,7 @@ struct kobject *kset_find_obj(struct kset *kset, const c

[Qemu-devel] [PATCH v6 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-12-04 Thread Gabriel L. Somlo
From: Gabriel Somlo Remove fw_cfg hardware interface details from Documentation/devicetree/bindings/arm/fw-cfg.txt, and replace them with a pointer to the authoritative documentation in the QEMU source tree. Signed-off-by: Gabriel Somlo Cc: Laszlo Ersek Acked-by: Rob Herring Reviewed-by: Lasz

[Qemu-devel] [PATCH v6 3/4] firmware: create directory hierarchy for sysfs fw_cfg entries

2015-12-04 Thread Gabriel L. Somlo
From: Gabriel Somlo Each fw_cfg entry of type "file" has an associated 56-char, nul-terminated ASCII string which represents its name. While the fw_cfg device doesn't itself impose any specific naming convention, QEMU developers have traditionally used path name semantics (i.e. "etc/acpi/rsdp") t

[Qemu-devel] [PATCH v6 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

2015-12-04 Thread Gabriel L. Somlo
From: Gabriel Somlo Make fw_cfg entries of type "file" available via sysfs. Entries are listed under /sys/firmware/qemu_fw_cfg/by_key, in folders named after each entry's selector key. Filename, selector value, and size read-only attributes are included for each entry. Also, a "raw" attribute all

  1   2   >