Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-03 Thread Grundmann, Christian
Hi again, got a Segfault today without virtio :-( (one IDE Disk and one virtio-scsi) Core was generated by `/usr/libexec/qemu-kvm -name vmname -S -machine pc-i440fx-rhel7.2.0,accel='. Program terminated with signal 11, Segmentation fault. #0 0x7fb299cbd3ab in tcmalloc::ThreadCache::ReleaseT

Re: [Qemu-devel] [PATCH for-2.5 1/2] tests: Use proper functions types instead of void (*fn)

2015-12-03 Thread Markus Armbruster
Eric Blake writes: > On 12/02/2015 01:20 PM, Markus Armbruster wrote: >> We have several function parameters declared as void (*fn). This is >> just a stupid way to write void *, and the only purpose writing it >> like that could serve is obscuring the sin of bypassing the type >> system without

Re: [Qemu-devel] [PATCH COLO-Frame v11 15/39] COLO: Load PVM's dirty pages into SVM's RAM cache temporarily

2015-12-03 Thread Hailiang Zhang
On 2015/12/2 3:02, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should not load PVM's state directly into SVM, because there maybe some errors happen when SVM is receving data, which will break SVM. We need to ensure receving all data before load the

Re: [Qemu-devel] [PATCH COLO-Frame v11 16/39] ram/COLO: Record the dirty pages that SVM received

2015-12-03 Thread Hailiang Zhang
On 2015/12/2 3:36, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We record the address of the dirty pages that received, it will help flushing pages that cached into SVM. We record them by re-using migration dirty bitmap. Signed-off-by: zhanghailiang ---

Re: [Qemu-devel] [PATCH v6 02/23] qapi: Require int64/uint64 implementation

2015-12-03 Thread Markus Armbruster
Eric Blake writes: > On 11/27/2015 05:05 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that all visitors supply both type_int64() and type_uint64() >>> callbacks, we can drop the redundant type_int() callback (the >>> public interface visit_type_int() remains, but calls into >>>

Re: [Qemu-devel] [PATCH COLO-Frame v11 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2015-12-03 Thread Hailiang Zhang
On 2015/12/3 15:21, Yang Hongyang wrote: On 2015年12月03日 14:48, Hailiang Zhang wrote: On 2015/12/3 14:25, Wen Congyang wrote: On 12/03/2015 11:53 AM, Hailiang Zhang wrote: On 2015/12/3 9:17, Wen Congyang wrote: On 11/24/2015 05:25 PM, zhanghailiang wrote: We add each netdev a default filter

[Qemu-devel] [PATCH] mmap-alloc: tweak a comment on ppc64

2015-12-03 Thread Michael S. Tsirkin
The comment I put in mmap-alloc to document the ppc64 rules refers to the previous revision of the patch: we don't look at memory alignment anymore, we check the fs from which the fd is mapped, instead. It's also not clear what does "in this case" refer to, rearrange text to make it clearer. Sign

Re: [Qemu-devel] [RFC PATCH V2 02/10] Qemu/VFIO: Add new VFIO_GET_PCI_CAP_INFO ioctl cmd definition

2015-12-03 Thread Lan, Tianyu
On 12/3/2015 6:25 AM, Alex Williamson wrote: I didn't seen a matching kernel patch series for this, but why is the kernel more capable of doing this than userspace is already? The following link is the kernel patch. http://marc.info/?l=kvm&m=144837328920989&w=2 These seem like pointless ioctl

Re: [Qemu-devel] [PATCH COLO-Frame v11 18/39] COLO: Flush PVM's cached RAM into SVM's memory

2015-12-03 Thread Hailiang Zhang
On 2015/12/2 4:06, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM

[Qemu-devel] 答复: [RFC v1] virtio-crypto specification

2015-12-03 Thread Lingli Deng
Hi guys, I am curious about the status of this proposal at OASIS. When is it planned for release? Is there any running PoC for the proposal? Is it still open? Any plan for upstreamming? Thanks, Lingli -邮件原件- 发件人: Denis Crasta [mailto:denis.cra...@freescale.com] 发送时间: 2015年11月26日 10:44

Re: [Qemu-devel] [RFC PATCH V2 09/10] Qemu/VFIO: Add SRIOV VF migration support

2015-12-03 Thread Lan, Tianyu
On 12/3/2015 6:25 AM, Alex Williamson wrote: On Tue, 2015-11-24 at 21:35 +0800, Lan Tianyu wrote: This patch is to add SRIOV VF migration support. Create new device type "vfio-sriov" and add faked PCI migration capability to the type device. The purpose of the new capability 1) sync migration

Re: [Qemu-devel] [RFC PATCH V2 06/10] Qemu/PCI: Add macros for faked PCI migration capability

2015-12-03 Thread Lan, Tianyu
On 12/3/2015 6:25 AM, Alex Williamson wrote: This will of course break if the PCI SIG defines that capability index. Couldn't this be done within a vendor defined capability? Thanks, Yes, it should work and thanks for suggestion.

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-12-03 Thread Pavel Fedin
Hello! > > My device defines this BAR to be of 2M size. In this case qemu splits it > > up into three > > regions: > > 1) Region below the MSI-X table (it's called "mmap", for me it's empty > > because table offset > > is 0) > > 2) MSI-X table itself (20 vectors = 0x0140 bytes for me). >

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-03 Thread Dr. David Alan Gilbert
* Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: > Hi again, > got a Segfault today without virtio :-( (one IDE Disk and one virtio-scsi) > > Core was generated by `/usr/libexec/qemu-kvm -name vmname -S -machine > pc-i440fx-rhel7.2.0,accel='. Can you confirm the package version y

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-03 Thread Grundmann, Christian
Hi, qemu-img-ev-2.3.0-29.1.el7.x86_64 libvirt-daemon-driver-qemu-1.2.8-16.el7_1.4.x86_64 qemu-kvm-ev-2.3.0-29.1.el7.x86_64 qemu-kvm-common-ev-2.3.0-29.1.el7.x86_64 ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch qemu-kvm-tools-ev-2.3.0-29.1.el7.x86_64 it seems pc-i440fx-rhel7.2.0 is the default

Re: [Qemu-devel] [RFC PATCH 7/9] net/colo-proxy: add packet enqueue and handle function

2015-12-03 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > Hi,Dave > > On 12/02/2015 12:12 AM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >>From: zhangchen > >> > >>Add common packet handle function and enqueue > >>packet distinguished connection,then we

Re: [Qemu-devel] [PATCH for-2.5] virtio: handle non-virtio-1-capable backend

2015-12-03 Thread Christian Borntraeger
On 12/02/2015 05:43 PM, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 03:09:58PM +0100, Cornelia Huck wrote: >> If you run a qemu advertising VERSION_1 with an old kernel where >> vhost did not yet support VERSION_1, you'll end up with a device >> that is {modern pci|ccw revision 1} but does

Re: [Qemu-devel] [PATCH v5] bt: check struct sizes

2015-12-03 Thread Michael Tokarev
30.11.2015 12:57, Paolo Bonzini wrote: > See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical > reasons these do not use sizeof, and Coverity caught a mistake in > EVT_ENCRYPT_CHANGE_SIZE. ... Applied to -trivial. Oh well!.. :) Thanks, /mjt

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > Hi all, > > Does anyboday remember the similar issue post by hailiang months ago > http://patchwork.ozlabs.org/patch/454322/ > At least tow bugs about migration had been fixed since that. Yes, I wondered what happened to that. > And now we found

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Hailiang Zhang
On 2015/12/3 17:24, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: Hi all, Does anyboday remember the similar issue post by hailiang months ago http://patchwork.ozlabs.org/patch/454322/ At least tow bugs about migration had been fixed since that. Yes, I wondere

[Qemu-devel] vhost-user on qemu qemu-2.5.0-rc2 FAILS for multi-queue

2015-12-03 Thread Naredula Janardhana Reddy
Hi I am using the latest qemu-2.5.0-rc2 with vhost-user(with multi-queue, with 3 queues) to test multi-queue feature with vhost-user. In the guest vm, multi-queue feature flag is not getting enabled . On the backend, the backend(user space switch) is receving SET_VRING_ADDR message only for th

[Qemu-devel] Wiki account request (was: Re: Highlighting changes in QEMU 2.5)

2015-12-03 Thread Thomas Huth
> On (Tue) 24 Nov 2015 [10:28:25], Amit Shah wrote: >> Hello, >> >> The 2.5 release is close - and I'm collecting a list of notable >> changes and features once more. The video made for the 2.4 release >> [1] was popular, and I'm volunteering to make one for 2.5 as well. In >> addition, we need m

Re: [Qemu-devel] [PATCH v3 2/3] qemu-iotests: s390x: fix test 051

2015-12-03 Thread tu bo
Hi Max: On 12/02/2015 11:48 PM, Max Reitz wrote: On 01.12.2015 08:35, tu bo wrote: Hi Max: 在 2015/12/1 3:38, Max Reitz 写道: On 26.11.2015 10:53, Bo Tu wrote: From: Bo Tu The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s

Re: [Qemu-devel] [PATCH] mmap-alloc: tweak a comment on ppc64

2015-12-03 Thread Greg Kurz
On Thu, 3 Dec 2015 10:38:10 +0200 "Michael S. Tsirkin" wrote: > The comment I put in mmap-alloc to document the ppc64 rules > refers to the previous revision of the patch: > we don't look at memory alignment anymore, we check > the fs from which the fd is mapped, instead. > > It's also not clear

[Qemu-devel] blockcopy qemu fail and libvirt

2015-12-03 Thread Vasiliy Tolstov
Hi, i'm use qemu 2.4.0 and libvirt 1.2.16 and try blockcopy to migrate vm disk virsh -c qemu+ssh://root@xxx/system blockcopy domain sda /dev/nbd2 --wait --pivot libvirt says: Successfully pivoted 2015-12-01 14:37:18.188+: 18288: info : libvirt version: 1.2.16 2015-12-01 14:37:18.188+: 182

[Qemu-devel] [PATCH v4 0/3] Update tests/qemu-iotests failing cases for the s390 platform

2015-12-03 Thread Bo Tu
From: Bo Tu v4: 1. Remove 051.s390.out, and rollback the changes in Makefile to generate 051.s390-ccw-virtio.out 2. Use 051.out as the common output for any non-pc platform 3. Set device_id to "drive0", and replace every "-drive file..." by "-drive file=...,if=none,id=$device_id", then x86 and s

[Qemu-devel] [PATCH v4 3/3] qemu-iotests: s390x: fix test 068

2015-12-03 Thread Bo Tu
Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot loader. If the s390-virtio-ccw machine finds no device to load from and errors out, then emits a panic and exits the vm. This breaks test cases 068 for s390x. Adding the parameter of "-no-shutdown" for s390-ccw-virtio will pau

[Qemu-devel] [PATCH v4 1/3] qemu-iotests: refine common.config

2015-12-03 Thread Bo Tu
From: Bo Tu Replacing awk with sed, then it's easier to read. Replacing "[ ! -z "$default_alias_machine" ]" with "[[ $default_alias_machine ]]", then it's slightly shorter. Reviewed-by: Max Reitz Suggested-By: Sascha Silbe Reviewed-by: Sascha Silbe Reviewed-by: Eric Blake Signed-off-by: B

[Qemu-devel] [PATCH v4 2/3] qemu-iotests: s390x: fix test 051

2015-12-03 Thread Bo Tu
From: Bo Tu The tests for ide device should only be tested for the pc platform. Set device_id to "drive0", and replace every "-drive file..." by "-drive file=...,if=none,id=$device_id", then x86 and s390x can get the common output in the test of "Snapshot mode". Warning message expected for s390

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Li Zhijian
On 12/03/2015 05:24 PM, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: Hi all, Does anyboday remember the similar issue post by hailiang months ago http://patchwork.ozlabs.org/patch/454322/ At least tow bugs about migration had been fixed since that. Yes, I w

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Li Zhijian
On 12/03/2015 05:37 PM, Hailiang Zhang wrote: On 2015/12/3 17:24, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: Hi all, Does anyboday remember the similar issue post by hailiang months ago http://patchwork.ozlabs.org/patch/454322/ At least tow bugs about migr

Re: [Qemu-devel] [PULL 0/9] virtio,vhost,mmap fixes for 2.5

2015-12-03 Thread Peter Maydell
On 2 December 2015 at 20:39, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 10:35:18PM +0200, Michael S. Tsirkin wrote: >> The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into >> staging (2

Re: [Qemu-devel] Wiki account request (was: Re: Highlighting changes in QEMU 2.5)

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 09:43, Thomas Huth wrote: >> On (Tue) 24 Nov 2015 [10:28:25], Amit Shah wrote: >>> Hello, >>> >>> The 2.5 release is close - and I'm collecting a list of notable >>> changes and features once more. The video made for the 2.4 release >>> [1] was popular, and I'm volunteering

Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix

2015-12-03 Thread Peter Maydell
On 2 December 2015 at 20:20, Markus Armbruster wrote: > PATCH 1 cleans up unnecessary type punning. > > PATCH 2 plugs a massive memory leak in qom-test. I think it would be > nice to have in 2.5, but at this late stage, it's really up to the > maintainer. To go into 2.5 it needs to be reviewed a

Re: [Qemu-devel] [PATCH 04/13] block: add meta bitmaps

2015-12-03 Thread Fam Zheng
On Wed, 11/11 18:16, Vladimir Sementsov-Ogievskiy wrote: > Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks > changes (set/unset) of this BdrvDirtyBitmap. It is needed for live > migration of block dirty bitmaps. > > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogi

Re: [Qemu-devel] [PULL 0/2] Migration PULL request

2015-12-03 Thread Peter Maydell
git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20151203 > > for you to fetch changes up to a694ee343d13159d214823294bbda08e4bdac685: > > migration: do floating-point division (2015-12-03 00:03:00 +0100) > > --

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-03 Thread P J P
Hello Dmitry, +-- On Thu, 3 Dec 2015, Dmitry Fleytman wrote --+ | The patch is good. | Jason, would you apply is from attachment or should it be resent by "git send-email”? | | Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> Thank you. (/me makes a note to learn about git send-email.) --

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Juan Quintela
Li Zhijian wrote: > Hi all, > > Does anyboday remember the similar issue post by hailiang months ago > http://patchwork.ozlabs.org/patch/454322/ > At least tow bugs about migration had been fixed since that. > > And now we found the same issue at the tcg vm(kvm is fine), after > migration, the co

[Qemu-devel] [Minios-devel] [PATCH v6 0/] Begin to disentangle libxenctrl and provide some stable libraries

2015-12-03 Thread Ian Campbell
In <1431963008.4944.80.ca...@citrix.com> I proposed stabilising some parts of the libxenctrl API/ABI by disaggregating into separate libraries. This is v6 of that set of series against: xen qemu-xen qemu-xen-traditional mini-os NB: Samuel+minios-devel will only get the mini-os sid

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-12-03 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 12/03/2015 05:24 PM, Dr. David Alan Gilbert wrote: > >* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > >>Hi all, > >> > >>Does anyboday remember the similar issue post by hailiang months ago > >> http://patchwork.ozlabs.org/patch/454322/ >

[Qemu-devel] [PATCH QEMU-XEN v6 1/8] xen_console: correctly cleanup primary console on teardown.

2015-12-03 Thread Ian Campbell
All of the work in con_disconnect applies to the primary console case (when xendev->dev is NULL). Therefore remove the early check and bail and allow it to fall through. All of the existing code is correctly conditional already. The ->dev and ->gnttabdev handles are either both set or neither. For

[Qemu-devel] [PATCH QEMU-XEN v6 0/8] Begin to disentangle libxenctrl and provide some stable libraries

2015-12-03 Thread Ian Campbell
We intend to stabilise some parts of the libxenctrl interface by splitting out some functionality into separate stable libraries. This is the qemu-xen part of the first phase of that change. This mail is (or is intended to be) a reply to a "0/" super-intro mail covering all of the related patch s

[Qemu-devel] [PATCH QEMU-XEN v6 2/8] xen: Switch to libxenevtchn interface for compat shims.

2015-12-03 Thread Ian Campbell
In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenevtchn which provides access to event channels. In preparation for this switch the compatibility layer in xen_common.

[Qemu-devel] [PATCH QEMU-XEN v6 6/8] xen: Use stable library interfaces when they are available.

2015-12-03 Thread Ian Campbell
In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. Specifically libxenevtchn, libxengnttab and libxenforeignmemory. Previous patches have already laid the groundwork for using these by switching the

[Qemu-devel] [PATCH QEMU-XEN v6 8/8] xen: make it possible to build without the Xen PV domain builder

2015-12-03 Thread Ian Campbell
Until the previous patch this relied on xc_fd(), which was only implemented for Xen 4.0 and earlier. Given this wasn't working since Xen 4.0 I have marked this as disabled by default. Removing this support drops the use of a bunch of symbols from libxenctrl, specifically: - xc_domain_create

[Qemu-devel] [PATCH QEMU-XEN v6 3/8] xen: Switch to libxengnttab interface for compat shims.

2015-12-03 Thread Ian Campbell
In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxengnttab which provides access to grant tables. In preparation for this switch the compatibility layer in xen_common.h

[Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-03 Thread Ian Campbell
In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenforeignmemory which provides access to privileged foreign mappings and which will provide an interface equivalent to x

[Qemu-devel] [PATCH QEMU-XEN v6 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher.

2015-12-03 Thread Ian Campbell
Using an existing libxenctrl handle after a fork was never particularly safe (especially if foreign mappings existed at the time of the fork) and the xc fd has been unavailable for many releases. Reopen the handle after fork and therefore do away with xc_fd(). Signed-off-by: Ian Campbell Acked-b

[Qemu-devel] [PATCH QEMU-XEN v6 5/8] xen: Switch uses of xc_map_foreign_{pages, bulk} to use libxenforeignmemory API.

2015-12-03 Thread Ian Campbell
In Xen 4.7 we are refactoring parts libxenctrl into a number of separate libraries which will provide backward and forward API and ABI compatiblity. One such library will be libxenforeignmemory which provides access to privileged foreign mappings and which will provide an interface equivalent to x

[Qemu-devel] [PATCH] ui: vnc: avoid floating point exception

2015-12-03 Thread P J P
Hello Gerd, A floating point exception issue in the VNC server PNG compression support was reported by Mr Lian Yihan, CC'd here. Given below is a proposed (tested)patch to fix this issue. === From 1ca4818333d39fed6567e316e37f6a6516f59c69 Mon Sep 17 00:00:00 2001 From: Prasad J Pandit Dat

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: support QMP dump-guest-memory

2015-12-03 Thread Peter Maydell
On 25 November 2015 at 00:37, Andrew Jones wrote: > Add the support needed for creating prstatus elf notes. This > allows us to use QMP dump-guest-memory. > + > +if (is_a64(env)) { > +for (i = 0; i < 31; ++i) { > +note.prstatus.pr_reg.regs[i] = cpu_to_dump64(s, env->xregs[

Re: [Qemu-devel] [PULL for-2.5 0/4] Block patches

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 04:59, Stefan Hajnoczi wrote: > The following changes since commit cf22132367a188426ac07cf1805b214dd2d0cc80: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-12-02 17:05:34 +) > > are available in the git repository at: > > git:

Re: [Qemu-devel] MinGW build

2015-12-03 Thread Peter Maydell
On 29 November 2015 at 12:03, Juan Quintela wrote: > Peter Maydell wrote: >> Yes, I've reported it to them, and I agree we don't need to fix >> this for 2.5. (There are other warnings with this mingw compiler >> anyway.) > > For my compiler (F23 cross-compiler) and a fairly large configuration (*

Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix

2015-12-03 Thread Markus Armbruster
Peter Maydell writes: > On 2 December 2015 at 20:20, Markus Armbruster wrote: >> PATCH 1 cleans up unnecessary type punning. >> >> PATCH 2 plugs a massive memory leak in qom-test. I think it would be >> nice to have in 2.5, but at this late stage, it's really up to the >> maintainer. > > To go

Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception

2015-12-03 Thread Gerd Hoffmann
On Do, 2015-12-03 at 17:07 +0530, P J P wrote: >Hello Gerd, > > A floating point exception issue in the VNC server PNG compression support > was > reported by Mr Lian Yihan, CC'd here. Given below is a proposed (tested)patch > to fix this issue. > -vs->client_pf.rmax = red_max; > +

[Qemu-devel] [PATCH v2] gdb: provide the name of the architecture in the target.xml

2015-12-03 Thread Christian Borntraeger
From: David Hildenbrand This patch provides the name of the architecture in the target.xml if available. This allows the remote gdb to detect the target architecture on its own - so there is no need to specify it manually (e.g. if gdb is started without a binary) using "set arch *arch_name*". T

Re: [Qemu-devel] [PATCH for-2.5] tcg: Increase the highwater reservation

2015-12-03 Thread Aurelien Jarno
On 2015-12-02 10:36, Richard Henderson wrote: > On 12/01/2015 08:32 AM, Aurelien Jarno wrote: > >On 2015-12-01 08:19, Richard Henderson wrote: > >>If there are a lot of guest memory ops in the TB, the amount of > >>code generated by tcg_out_tb_finalize could be well more than 1k. > >>In the short t

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

2015-12-03 Thread Peter Maydell
On 25 November 2015 at 00:37, Andrew Jones wrote: > Also refactors note init code to avoid code duplication. Can you squash those parts down into the preceding patch? > > Signed-off-by: Andrew Jones > --- > target-arm/arch_dump.c | 161 > ++--- > 1

Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 12:11, Gerd Hoffmann wrote: > On Do, 2015-12-03 at 17:07 +0530, P J P wrote: >>Hello Gerd, >> >> A floating point exception issue in the VNC server PNG compression support >> was >> reported by Mr Lian Yihan, CC'd here. Given below is a proposed (tested)patch >> to fix t

Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix

2015-12-03 Thread Andreas Färber
Am 03.12.2015 um 13:06 schrieb Markus Armbruster: > Peter Maydell writes: > >> On 2 December 2015 at 20:20, Markus Armbruster wrote: >>> PATCH 1 cleans up unnecessary type punning. >>> >>> PATCH 2 plugs a massive memory leak in qom-test. I think it would be >>> nice to have in 2.5, but at this

Re: [Qemu-devel] [PATCH for-2.5 0/2] tests: A cleanup and a fix

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 12:57, Andreas Färber wrote: > P.S. Since Peter insists on a pull, I will prepare one to finally fix > the make test breakage Marc and me both pointed out to no effect. If you > desire changes beyond dropping my one cosmetic patch, do comment. I don't insist on a pull. I sai

Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception

2015-12-03 Thread P J P
Hello Peter, +-- On Thu, 3 Dec 2015, Peter Maydell wrote --+ | The patch doesn't apply to master. Can you produce a version | that does, please? Please see this new one, hope it works. === >From d4661b8d99f8c8439167d85165439c619553b933 Mon Sep 17 00:00:00 2001 From: Prasad J Pandit Date: Thu,

Re: [Qemu-devel] [PATCH v2 4/6] dump: allow target to set the physical base

2015-12-03 Thread Peter Maydell
On 25 November 2015 at 00:37, Andrew Jones wrote: > crash assumes the physical base in the kdump subheader of > makedumpfile formatted dumps is correct. Zero is not correct > for all architectures, so allow it to be changed. > > (No functional change.) > > Signed-off-by: Andrew Jones > --- Revie

Re: [Qemu-devel] [PATCH] ui: vnc: avoid floating point exception

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 13:24, P J P wrote: > Hello Peter, > > +-- On Thu, 3 Dec 2015, Peter Maydell wrote --+ > | The patch doesn't apply to master. Can you produce a version > | that does, please? > > Please see this new one, hope it works. > > === > From d4661b8d99f8c8439167d85165439c619553b933

Re: [Qemu-devel] vhost-user on qemu qemu-2.5.0-rc2 FAILS for multi-queue

2015-12-03 Thread Victor Kaplansky
On Thu, Dec 03, 2015 at 03:11:57PM +0530, Naredula Janardhana Reddy wrote: > Hi > I am using the latest qemu-2.5.0-rc2 with vhost-user(with multi-queue, > with 3 queues) to test multi-queue feature with vhost-user. In the guest > vm, multi-queue feature flag is not getting enabled . > > On the

[Qemu-devel] [PATCH 02/13] acpi: Remove unnecessary check for NULL pci_host

2015-12-03 Thread Eduardo Habkost
If acpi_get_i386_pci_host() returned NULL, acpi_get_pci_info() would crash before build_ssdt() gets called. Remove unnecessary check for NULL pci_host. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/i386/acpi-

[Qemu-devel] [PATCH 08/13] acpi: Always try to init PCI hotplug I/O base

2015-12-03 Thread Eduardo Habkost
Instead of making pcihp_io_base/pcihp_io_len initialization specific to piix4, just check if ACPI_PCIHP_IO_BASE_PROP property is present. No behavior is changed, as only piix4 initializes the ACPI_PCIHP_IO_BASE_PROP property today. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 16 ++

[Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic

2015-12-03 Thread Eduardo Habkost
This series removes piix-specific and q35-specific code from acpi-build.c, making it generic and without direct dependencies to piix and q35 code. This series needs to be applied after the following: * [PATCH v3 0/6] pc: Initialization and compat function cleanup * [PATCH V3 0/3] hw/pcie: Multi-ro

[Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field

2015-12-03 Thread Eduardo Habkost
This will allow us to avoid direct references to piix and q35 in acpi-build.c. Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 2 ++ hw/pci-host/piix.c | 1 + include/hw/i386/pc.h | 1 + 3 files changed, 4 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 0907746.

[Qemu-devel] [PATCH 04/13] acpi: Move DSDT info to PCMachineClass

2015-12-03 Thread Eduardo Habkost
Remove direct dependency on q35-acpi-dsdt.hex and acpi-dsdt.hex from acpi-build.c. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 35 +++ hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 include/hw/i386/pc.h | 2 ++ 4 files changed, 17 i

[Qemu-devel] [PATCH 09/13] acpi: Use PCMachineState::acpi_dev to get ACPI dev

2015-12-03 Thread Eduardo Habkost
Instead of calling piix4_pm_find() and ich9_lpc_find(), simply use PCMachineState::acpi_dev to get the object containing the ACPI-related properties. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/hw/i

[Qemu-devel] [PATCH 03/13] acpi: Eliminate acpi_get_i386_pci_host() function

2015-12-03 Thread Eduardo Habkost
We can simply use PCMachineState::pci_host directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 38 +++--- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 20a7066..a595575 100644 --- a

[Qemu-devel] [PATCH 05/13] acpi: Simplify s3/s4 property querying

2015-12-03 Thread Eduardo Habkost
object_property_get_bool() already returns false when the property is not present, there's no need to call object_property_get_qobject() manually. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 32 +--- 1 file changed, 9 insertions(+), 23 deletions(-) diff

[Qemu-devel] [PATCH 06/13] acpi: Use &error_abort when getting PCI hotplug properties

2015-12-03 Thread Eduardo Habkost
The properties must be present, so use &error_abort to ensure we don't ignore errors. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9a45a59..4f42e28 100644 --- a/

[Qemu-devel] [PATCH 13/13] acpi: Don't include q35 and piix headers

2015-12-03 Thread Eduardo Habkost
The ACPI code doesn't need to include q35 and piix headers anymore, as the code is generic have no piix-specific or q35-specific parts. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i3

[Qemu-devel] [PATCH 07/13] acpi: Use QOM property to get CPU hotplug I/O base

2015-12-03 Thread Eduardo Habkost
Instead of hardcoding the ich9 and piix I/O bases, use a QOM property, the same way we already do for PCI hotplug I/O base. Signed-off-by: Eduardo Habkost --- hw/acpi/cpu_hotplug.c | 3 +++ hw/acpi/ich9.c| 2 ++ hw/acpi/piix4.c | 2 ++ hw/i386/acpi-build.c

[Qemu-devel] [PATCH 10/13] acpi: Change acpi_pci_hotplug_enabled() argument to PCMachineState

2015-12-03 Thread Eduardo Habkost
Now that we just use PCMachineState::acpi_dev, we can change the argument to acpi_pci_hotplug_enabled(). Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 440d4e2..5

[Qemu-devel] [PATCH 12/13] intel_iommu.h: Missing sysbus.h include

2015-12-03 Thread Eduardo Habkost
intel_iommu.h uses SysBusDevice. This never caused any problems before because all files including intel_iommu.h were already including sysbus.h. Signed-off-by: Eduardo Habkost --- include/hw/i386/intel_iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/i386/intel_iommu.h b/i

Re: [Qemu-devel] MinGW build

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 11:58, Peter Maydell wrote: > On 29 November 2015 at 12:03, Juan Quintela wrote: >> Peter Maydell wrote: >>> Yes, I've reported it to them, and I agree we don't need to fix >>> this for 2.5. (There are other warnings with this mingw compiler >>> anyway.) >> >> For my compil

[Qemu-devel] [PATCH 11/13] acpi: Don't use find_i440fx() when setting bsel properties

2015-12-03 Thread Eduardo Habkost
Instead of checking for i440fx, the code can simply check if the machine has ACPI PCI hotplug enabled. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 585100f..04

[Qemu-devel] -device spapr-dr-connector crashes

2015-12-03 Thread Markus Armbruster
Watch this: $ qemu-system-ppc64 -nodefaults -S -display none -device spapr-dr-connector ** ERROR:/home/armbru/work/qemu/hw/ppc/spapr_drc.c:45:get_type_shift: assertion failed: (is_power_of_2(type)) Aborted (core dumped) It may not make sense, but it shouldn't crash. Should this

Re: [Qemu-devel] MinGW build

2015-12-03 Thread Juan Quintela
Peter Maydell wrote: > On 3 December 2015 at 11:58, Peter Maydell wrote: >> On 29 November 2015 at 12:03, Juan Quintela wrote: >>> Peter Maydell wrote: Yes, I've reported it to them, and I agree we don't need to fix this for 2.5. (There are other warnings with this mingw compiler

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Peter Maydell
On 30 November 2015 at 22:23, Andrew Baumann wrote: > Qemu does not generally perform alignment checks. However, the ARM ARM > requires implementation of alignment exceptions for a number of cases > including LDREX, and Windows-on-ARM relies on this. > > This change adds a helper function to raise

Re: [Qemu-devel] vhost-user on qemu qemu-2.5.0-rc2 FAILS for multi-queue

2015-12-03 Thread Victor Kaplansky
On Thu, Dec 03, 2015 at 03:11:57PM +0530, Naredula Janardhana Reddy wrote: > Hi > I am using the latest qemu-2.5.0-rc2 with vhost-user(with multi-queue, > with 3 queues) to test multi-queue feature with vhost-user. In the guest > vm, multi-queue feature flag is not getting enabled . > > On the

Re: [Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

2015-12-03 Thread Peter Maydell
On 2 December 2015 at 05:06, Jason Wang wrote: > It will go to 2.5. Plan to include this in my last pull request for 2.5. Are you planning to send that pullreq today? thanks -- PMM

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/pci: populate PCI DT in reverse order

2015-12-03 Thread Greg Kurz
On Tue, 1 Dec 2015 22:48:38 +0100 Thomas Huth wrote: > On 30/11/15 11:45, Greg Kurz wrote: > > Since commit 1d2d974244c6 "spapr_pci: enumerate and add PCI device tree", > > QEMU > > populates the PCI device tree in the opposite order compared to SLOF. > > > > Before 1d2d974244c6: > > > > Popul

Re: [Qemu-devel] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-12-03 Thread Wouter Verhelst
Hi all, On Fri, Nov 27, 2015 at 03:06:51PM +0100, Wouter Verhelst wrote: > I have been thinking of adding a message NBD_OPT_SELECT_EXPORT to > replace NBD_OPT_EXPORT_NAME, which would select an export but not end > negotiation. That would also require another message to end negotiation > and move

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2015-12-03 Thread Lan, Tianyu
On 12/2/2015 10:31 PM, Michael S. Tsirkin wrote: >We hope >to find a better way to make SRIOV NIC work in these cases and this is >worth to do since SRIOV NIC provides better network performance compared >with PV NIC. If this is a performance optimization as the above implies, you need to inclu

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Laurent Desnogues
On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell wrote: > On 30 November 2015 at 22:23, Andrew Baumann > wrote: >> Qemu does not generally perform alignment checks. However, the ARM ARM >> requires implementation of alignment exceptions for a number of cases >> including LDREX, and Windows-on-ARM re

[Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread Miao Yan
Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). This will cause build error when debug level is raised in vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). Use VMXNET_MF and VXMNET_MA instead. Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insert

[Qemu-devel] [PATCH] xen_pt: fix failure of attaching & detaching a PCI device to VM repeatedly

2015-12-03 Thread Jianzhong,Chang
From: jianzhong,Chang Add pci = [ '$VF_BDF', '$VF_BDF', '$VF_BDF'] in hvm guest configuration file. After the guest boot up, detach the VFs in sequence by "xl pci-detach $DOMID $VF_BDF", reattach the VFs by "xl pci-attach $VF_BDF" in sequence. An error message will be reported like this: "libxl:

[Qemu-devel] [PATCH 3/3] vhost-net: force guest_notifier_mask bypass in vhost-user case

2015-12-03 Thread Didier Pallard
Since guest_mask_notifier can not be used in vhost-user mode due to buffering implied by unix control socket, force VIRTIO_PCI_FLAG_USE_NOTIFIERMASK on virtio pci of vhost-user interfaces, and send correct callfd to the guest at vhost start. Signed-off-by: Didier Pallard Reviewed-by: Thibaut Coll

[Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-03 Thread Didier Pallard
unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as long as EAGAIN errno is set, but write_msgfds buffer is freed after first EAGAIN failure, causing message to be sent without proper fds attachment. In case unix_send_msgfds is call

[Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2015-12-03 Thread Didier Pallard
Using guest_notifier_mask function in vhost-user case may break interrupt mask paradigm, because mask/unmask is not really done when returning from guest_notifier_mask call, instead message is posted in a unix socket, and processed later. Add an option bit to disable the use of guest_notifier_mask

[Qemu-devel] Linux vhost-user interrupt management fixes

2015-12-03 Thread Didier Pallard
Hi, I recently did some stress tests of a vhost-user interface using an UDP traffic generator. Traffic generator was connected to 2 physical ports that are in turn connected to 2 virtio ports through a linux bridge, VM (running linux) doing routing to forward packets between the 2 virtio ports. Wh

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

2015-12-03 Thread Peter Maydell
On 3 December 2015 at 14:58, Laurent Desnogues wrote: > On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell > wrote: >> On 30 November 2015 at 22:23, Andrew Baumann >> wrote: >>> Qemu does not generally perform alignment checks. However, the ARM ARM >>> requires implementation of alignment exceptions

Re: [Qemu-devel] [PATCH v3 4/8] hw/acpi/aml-build: Add GPIO Connection Descriptor

2015-12-03 Thread Igor Mammedov
On Mon, 16 Nov 2015 21:23:05 +0800 shannon.z...@linaro.org wrote: > From: Shannon Zhao Subj can be shortened to: acpi: Add GPIO Connection Descriptor > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Tested-by: Wei Huang > --- > hw/acpi/aml-build.c | 61 > ++

Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic

2015-12-03 Thread Igor Mammedov
On Wed, 2 Dec 2015 20:22:45 -0200 Eduardo Habkost wrote: > This series removes piix-specific and q35-specific code from > acpi-build.c, making it generic and without direct dependencies > to piix and q35 code. we are conflicting reshuffling acpi-build.c at the same time could be cleanup done on

Re: [Qemu-devel] [RESEND RFC 2/6] device_tree: introduce load_device_tree_from_sysfs

2015-12-03 Thread Eric Auger
Hi Thomas, Alex, On 11/26/2015 11:57 AM, Thomas Huth wrote: > On 19/11/15 16:22, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/sys/firmware/devicetree/base). >> >> This has a runtime dependency on the dtc binary. This functionality >> is useful for platform de

Re: [Qemu-devel] [PATCH for 2.6 1/1] qemu-char: append opt to stop truncation of serial file

2015-12-03 Thread Eric Blake
On 12/02/2015 11:24 PM, Denis V. Lunev wrote: > From: Olga Krishtal > > Our QA teams wants to preserve serial output of the guest in between QEMU > runs to perform post-analysis. > > By default this behavior is off (file is truncated each time QEMU is started > or device is plugged). > > Signed

  1   2   3   >