Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Michael S. Tsirkin
On Mon, Nov 23, 2015 at 03:41:11PM +0800, Jason Wang wrote: > Currently, all virtio devices bypass IOMMU completely. This is because > address_space_memory is assumed and used during DMA emulation. This > patch converts the virtio core API to use DMA API. This idea is > > - introducing a new trans

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-23 Thread Ming Lin
On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: > > On 20/11/2015 01:20, Ming Lin wrote: > > One improvment could be to use google's NVMe vendor extension that > > I send in another thread, aslo here: > > https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=nvme-google-ext >

Re: [Qemu-devel] [PATCH for 2.5 1/1] parallels: dirty BAT properly for continuous allocations

2015-11-23 Thread Denis V. Lunev
On 11/17/2015 08:02 PM, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy This patch marks part of the BAT dirty properly. There is a possibility that multy-block allocation could have one block allocated on one BAT page and next block on the next page. The code without the patch could n

[Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

2015-11-23 Thread Markus Armbruster
qmp_query_memdev() has two error paths: * When object_get_objects_root() returns null. It never does, so simply drop the useless error handling. * When query_memdev() fails. It leaks err then. But any failure there is actually a programming error. Switch it to &error_abort, and drop the

Re: [Qemu-devel] [PATCH] vhost-user: set link down when the char device is closed

2015-11-23 Thread Jason Wang
On 11/20/2015 01:42 PM, Wen wrote: > To Jason Wang: > > I think this patch should be for qemu-2.5 > > Thanks > Wen Congyang Hi: I thought it was for vhost tree. Michael: Do you want to take this patch? > > On 11/11/2015 02:53 PM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> --- >>

Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

2015-11-23 Thread Stefan Hajnoczi
On Thu, Nov 19, 2015 at 10:39:05AM +0800, Xiao Guangrong wrote: > On 11/19/2015 04:44 AM, Michael S. Tsirkin wrote: > >On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote: > >>On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote: > >sorry, I'm busy with 2.5 now, and this is cl

[Qemu-devel] [PATCH v4 2/5] ssi: Move ssi.h into a separate directory

2015-11-23 Thread Alistair Francis
Move the ssi.h include file into the ssi directory. While touching the code also fix the typdef lines as checkpatch complains. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V2: - Change git patch to indicate rename hw/arm/pxa2xx.c | 2 +- hw/arm/spit

[Qemu-devel] [PATCH v4 0/5] Connect the SPI devices to ZynqMP

2015-11-23 Thread Alistair Francis
Connect the SPI devices to Xilinx's ZynqMP. I also need to make some changes to the actual SPI device to imporove the fuctionality, but for the time being this works. V4: - Rebase - Rename the SPI busses so that they can all be accessed from the SoC - Only create one SPI flash device V3: - Do

[Qemu-devel] [PATCH v4 5/5] xlnx-ep108: Connect the SPI Flash

2015-11-23 Thread Alistair Francis
Connect the sst25wf080 SPI flash to the EP108 board. Signed-off-by: Alistair Francis --- V4: - Only add one SPI flash V3: - Don't reach into the SoC V2: - Use sst25wf080 instead of m25p80 hw/arm/xlnx-ep108.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/arm/xlnx-ep

[Qemu-devel] [PATCH v4 1/5] m25p80.c: Add sst25wf080 SPI flash device

2015-11-23 Thread Alistair Francis
Add the sst25wf080 SPI flash device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index efc43dd..7b9f97c 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -

[Qemu-devel] [PATCH v4 4/5] xlnx-zynqmp: Connect the SPI devices

2015-11-23 Thread Alistair Francis
Connect the Xilinx SPI devices to the ZynqMP model. Signed-off-by: Alistair Francis --- V4: - Rename the SPI busses so that they can all be accessed from the SoC - Don't set the num-busses property V3: - Expose the SPI Bus as part of the SoC device V2: - Don't connect the SPI flash to the SoC

[Qemu-devel] [PATCH v4 3/5] xilinx_spips: Seperate the state struct into a header

2015-11-23 Thread Alistair Francis
Seperate out the XilinxSPIPS struct into a seperate header file. Signed-off-by: Alistair Francis --- V4: - Don't split off R_MOD_ID and hardcode R_MAX V2: - Only split out required #defines - Prefix XLNX_SPIPS_ hw/ssi/xilinx_spips.c | 46 +++ include/hw/ssi/xi

Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

2015-11-23 Thread Michael S. Tsirkin
On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: > qmp_query_memdev() has two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > * When query_memdev() fails. It leaks err then. But any failure >

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Wen Congyang
On 11/20/2015 05:59 PM, Fam Zheng wrote: > "s->bitmap" tracks done sectors, we only check bit states without using any > iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and > more memory efficient. > > Meanwhile, rename it to done_bitmap, to reflect the intention. > > Sign

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

2015-11-23 Thread Fam Zheng
On Mon, 11/23 08:33, Markus Armbruster wrote: > Fam Zheng writes: > > > Otherwise, a window flashes on my desktop (built with SDL). Add this as > > other cases have it. > > > > Signed-off-by: Fam Zheng > > > > --- > > v2: Fix 119 too. [Max] > > --- > > tests/qemu-iotests/119 | 2 +- > > tests/q

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Fam Zheng
On Mon, 11/23 17:01, Wen Congyang wrote: > On 11/20/2015 05:59 PM, Fam Zheng wrote: > > "s->bitmap" tracks done sectors, we only check bit states without using any > > iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and > > more memory efficient. > > > > Meanwhile, rename i

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Wen Congyang
On 11/23/2015 05:19 PM, Fam Zheng wrote: > On Mon, 11/23 17:01, Wen Congyang wrote: >> On 11/20/2015 05:59 PM, Fam Zheng wrote: >>> "s->bitmap" tracks done sectors, we only check bit states without using any >>> iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and >>> more me

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Cornelia Huck
On Mon, 23 Nov 2015 15:41:11 +0800 Jason Wang wrote: > Currently, all virtio devices bypass IOMMU completely. This is because > address_space_memory is assumed and used during DMA emulation. This > patch converts the virtio core API to use DMA API. This idea is > > - introducing a new transport

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Michael S. Tsirkin
On Mon, Nov 23, 2015 at 10:36:45AM +0100, Cornelia Huck wrote: > On Mon, 23 Nov 2015 15:41:11 +0800 > Jason Wang wrote: > > > Currently, all virtio devices bypass IOMMU completely. This is because > > address_space_memory is assumed and used during DMA emulation. This > > patch converts the virti

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Fam Zheng
On Mon, 11/23 17:24, Wen Congyang wrote: > On 11/23/2015 05:19 PM, Fam Zheng wrote: > > On Mon, 11/23 17:01, Wen Congyang wrote: > >> On 11/20/2015 05:59 PM, Fam Zheng wrote: > >>> "s->bitmap" tracks done sectors, we only check bit states without using > >>> any > >>> iterator which HBitmap is goo

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Wen Congyang
On 11/23/2015 05:55 PM, Fam Zheng wrote: > On Mon, 11/23 17:24, Wen Congyang wrote: >> On 11/23/2015 05:19 PM, Fam Zheng wrote: >>> On Mon, 11/23 17:01, Wen Congyang wrote: On 11/20/2015 05:59 PM, Fam Zheng wrote: > "s->bitmap" tracks done sectors, we only check bit states without using >

Re: [Qemu-devel] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov

2015-11-23 Thread Stefan Hajnoczi
On Thu, Jul 09, 2015 at 10:56:43AM +0100, Stefan Hajnoczi wrote: > v2: > * Default to IOV_MAX instead of INT_MAX [Peter Lieven] > > This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX elements". > > IOV_MAX has been hardcoded in several places since preadv()/pwritev()/etc > refus

Re: [Qemu-devel] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov

2015-11-23 Thread Stefan Hajnoczi
On Wed, Nov 18, 2015 at 03:51:29PM +0100, Kevin Wolf wrote: > Am 09.07.2015 um 11:56 hat Stefan Hajnoczi geschrieben: > > v2: > > * Default to IOV_MAX instead of INT_MAX [Peter Lieven] > > > > This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX > > elements". > > > > IOV_MAX has

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 07:41, Pavel Fedin wrote: > Hello! No news for a long time, we are at RC stage. Could we get this in? Yes, queued for -rc2. Paolo > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > >> -Original Message- >> From: qemu-devel-bounc

Re: [Qemu-devel] [PATCH] block/qapi: Plug memory leak on query-block error path

2015-11-23 Thread Kevin Wolf
Am 20.11.2015 um 13:53 hat Markus Armbruster geschrieben: > Spotted by Coverity. > > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 11:09, Paolo Bonzini wrote: > On 23/11/2015 07:41, Pavel Fedin wrote: >> Hello! No news for a long time, we are at RC stage. Could we get this in? > > Yes, queued for -rc2. ... doh, Eduardo applied it to the NUMA tree already. I missed that backends/hostmem* is under NUMA and no

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> >> Hash ivshmem been used in anger? If yes, how? >> >> Still the question to answer. > > I don't expect users to read this ML everyday (anybody > actually). Personally, I have no clue how widespread ivshmem usage is. > >> Beside

Re: [Qemu-devel] [PATCH for 2.5 1/1] parallels: dirty BAT properly for continuous allocations

2015-11-23 Thread Stefan Hajnoczi
On Tue, Nov 17, 2015 at 08:02:58PM +0300, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > This patch marks part of the BAT dirty properly. There is a possibility that > multy-block allocation could have one block allocated on one BAT page and > next block on the next page. The code

[Qemu-devel] [PATCH] linux-user,sh4: fix signal retcode address

2015-11-23 Thread Laurent Vivier
To return from a signal, setup_frame() puts an instruction to be executed in the stack. This sequence calls the syscall sigreturn(). The address of the instruction must be set in the PR register to be executed. This patch fixes this: the current code sets the register to the address of the instru

Re: [Qemu-devel] [PATCH] linux-user, sh4: fix signal retcode address

2015-11-23 Thread John Paul Adrian Glaubitz
On 11/23/2015 11:38 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz This patch fixes crashes of qemu-sh4* on amd64 for me [1]. I also haven't seen any regressions ever since. Cheers, Adrian > [1] https://bugs.launchpad.net/ubuntu/+source/qemu-lin

[Qemu-devel] [PATCH for-2.5] vhost-user: clarify start and enable

2015-11-23 Thread Michael S. Tsirkin
It seems that we currently have some duplication between started and enabled states. The actual reason is that enable is not documented correctly: what it does is connecting ring to the backend. This is important for MQ, because a Linux guest expects TX packets to be completed even if it disables

Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

2015-11-23 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: >> qmp_query_memdev() has two error paths: >> >> * When object_get_objects_root() returns null. It never does, so >> simply drop the useless error handling. >> >> * When query_memdev() fails. I

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

2015-11-23 Thread Peter Krempa
On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: > This patchset adds CPU hotplug support for sPAPR PowerPC guests using > device_add and device_del commands > > (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 Is there a reason why this uses 'device_add' rather than the 'cpu_add' comma

Re: [Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

2015-11-23 Thread Edgar E. Iglesias
On Fri, Nov 20, 2015 at 02:32:51PM +, Peter Maydell wrote: > In an LPAE format descriptor in ARMv8 the address field extends > up to bit 47, not just bit 39. Correct the masking so we don't > give incorrect results if the output address size is greater > than 40 bits, as it can be for AArch64.

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Marc-André Lureau
Hi - Original Message - > > >> qemu-doc documents role only with chardev. The code doesn't care. > > > > yeah, role is only really useful with a server. Another missing warning. > > I think it makes sense only when we can migrate the shared memory > contents out-of-band. Vaguely similar

Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling

2015-11-23 Thread Daniel P. Berrange
On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: > On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: > > + > > +static const char *base64_valid_chars = > > +"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/="; > > + > > +static int > > +qcrypto_secret_validate_base64(

[Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average

2015-11-23 Thread Kevin Wolf
'make check' failed to compile the test case for mingw because of undefined references. Pull in a few more dependencies so that it builds. Signed-off-by: Kevin Wolf --- tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index b937

[Qemu-devel] [PATCH for-2.5 0/2] Fix "make check" with mingw and Wine

2015-11-23 Thread Kevin Wolf
I tried to run "make check" on my mingw build and got two failures. Both of them are bugs in the test suite rather than qemu proper. They are easy enough to fix, so here are the fixes. Kevin Wolf (2): tests/Makefile: Add more dependencies for test-timed-average test-aio: Fix event notifier cle

[Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup

2015-11-23 Thread Kevin Wolf
One test case closed an event notifier (event_notifier_cleanup()) without first disabling it (set_event_notifier(..., NULL)). This resulted in a leftover handle 0 that was added to each subsequent WaitForMultipleObjects() call, causing the function to fail (invalid handle). Signed-off-by: Kevin Wo

Re: [Qemu-devel] [PATCH WIP 04/30] qcow2: add a 'keyid' parameter to qcow2 options

2015-11-23 Thread Daniel P. Berrange
On Fri, Nov 20, 2015 at 03:15:27PM -0700, Eric Blake wrote: > On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: > > Add a 'keyid' parameter that refers to the ID of a > > QCryptoSecret instance that provides the encryption key. > > > > $QEMU \ > > -object secret,id=sec0,filename=/home/berrange

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2015 at 11:11:28AM +0100, Paolo Bonzini wrote: > > > On 23/11/2015 11:09, Paolo Bonzini wrote: > > On 23/11/2015 07:41, Pavel Fedin wrote: > >> Hello! No news for a long time, we are at RC stage. Could we get this in? > > > > Yes, queued for -rc2. > > ... doh, Eduardo applied i

[Qemu-devel] [PULL 0/1] NUMA fix for -rc2

2015-11-23 Thread Eduardo Habkost
(I forgot to submit a pull request for this earlier, sorry.) The following changes since commit 541abd10a01da56c5f16582cd32d67114ec22a5c: Update version for v2.5.0-rc1 release (2015-11-20 17:43:46 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/numa-pu

[Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

2015-11-23 Thread Richard Henderson
From: John Clarke A simple typo in the variable to use when comparing vs the highwater mark. Reports are that qemu can in fact segfault occasionally due to this mistake. Signed-off-by: John Clarke Signed-off-by: Richard Henderson --- tcg/tcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PULL for-2.5] last minute tcg fix

2015-11-23 Thread Richard Henderson
: git://github.com/rth7680/qemu.git tags/pull-tcg-20151123 for you to fetch changes up to 644da9b39e477caa80bab69d2847dfcb468f0d33: tcg: Fix highwater check (2015-11-23 13:16:05 +0100) Last minute fix

Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine

2015-11-23 Thread Eduardo Habkost
Ping? Any thoughts on this approach? -rc2 is too late for this kind of change, maybe? On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo Habkost wrote: > This changes the qemu_hw_version() default to "2.5+" so we don't > make every machine class broken by default unless they set > hw_version. >

Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine

2015-11-23 Thread Michael S. Tsirkin
On Mon, Nov 23, 2015 at 10:53:39AM -0200, Eduardo Habkost wrote: > > Ping? Any thoughts on this approach? > > -rc2 is too late for this kind of change, maybe? > I queued this up for 2.5, will merge later this week unless anyone objects. > On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo Habko

[Qemu-devel] [PULL 1/1] hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-11-23 Thread Eduardo Habkost
From: Pavel Fedin Currently hostmem backend fails if CONFIG_NUMA is enabled in QEMU (the default) but NUMA is not supported by the kernel. This makes it impossible to use ivshmem in such configurations. This patch fixes the problem by ignoring ENOSYS error if policy is set to MPOL_DEFAULT. This

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

2015-11-23 Thread Christian Borntraeger
On 11/23/2015 12:54 PM, Peter Krempa wrote: > On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: >> This patchset adds CPU hotplug support for sPAPR PowerPC guests using >> device_add and device_del commands >> >> (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 > > Is there a reason why t

Re: [Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

2015-11-23 Thread Stefan Weil
Am 23.11.2015 um 13:45 schrieb Richard Henderson: > From: John Clarke > > A simple typo in the variable to use when comparing vs the highwater mark. > Reports are that qemu can in fact segfault occasionally due to this mistake. > > Signed-off-by: John Clarke > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH V5 7/8] introduce xlnx-dp

2015-11-23 Thread KONRAD Frederic
Le 20/11/2015 11:06, Alistair Francis a écrit : On Fri, Oct 16, 2015 at 7:11 PM, wrote: From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid. Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. A

Re: [Qemu-devel] [PATCH V5 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2015-11-23 Thread KONRAD Frederic
Le 20/11/2015 13:21, Alistair Francis a écrit : On Fri, Oct 16, 2015 at 7:11 PM, wrote: From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP platform. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/arm/xlnx-zynqmp.c |

Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default

2015-11-23 Thread Eduardo Habkost
On Sat, Nov 21, 2015 at 02:09:25AM +0100, Borislav Petkov wrote: > On Sat, Nov 21, 2015 at 12:11:35AM +0100, Andreas Färber wrote: > > Hi, > > > > CC'ing qemu-devel. > > Ah, thanks. > > > Am 21.11.2015 um 00:01 schrieb Borislav Petkov: > > > From: Borislav Petkov > > > > > > Software Error Rec

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> >> >> qemu-doc documents role only with chardev. The code doesn't care. >> > >> > yeah, role is only really useful with a server. Another missing warning. >> >> I think it makes sense only when we can migrate the shared memory >

[Qemu-devel] [PATCH] PCI Trivial: remove superfluous code

2015-11-23 Thread Cao jin
remove superfluous code in do_pci_register_device(). See its caller: pci_qdev_realize() Signed-off-by: Cao jin --- hw/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 168b9cc..4d16da0 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -878,7 +878,6 @@ s

[Qemu-devel] [PATCH v2 1/1] parallels: add format spec

2015-11-23 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi --- v2: add license info switch to offsets fr

Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling

2015-11-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: >> On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: >> > + >> > +static const char *base64_valid_chars = >> > +"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/="; >> > + >> > +static i

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Marc-André Lureau
Hi - Original Message - > > "role" was designed to only migrate the master. Ability to migrate a pool > > of > > peer would be a significant new feature. I am not aware of such request. > > I see. But how is this supposed to work? > > Before migration: one master and N peers connected t

Re: [Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

2015-11-23 Thread Richard Henderson
On 11/23/2015 02:16 PM, Stefan Weil wrote: Am 23.11.2015 um 13:45 schrieb Richard Henderson: From: John Clarke A simple typo in the variable to use when comparing vs the highwater mark. Reports are that qemu can in fact segfault occasionally due to this mistake. Signed-off-by: John Clarke Si

[Qemu-devel] [PATCH 0/2] Add basic "detach" support for dump-guest-memory

2015-11-23 Thread Peter Xu
Currently, dump-guest-memory supports synchronous operation only. This patch sets are adding "detach" support for it (just like "migrate -d" for migration). When "-d" is provided, dump-guest-memory command will return immediately without hanging user. This should be useful when the backend storage

[Qemu-devel] [PATCH 2/2] dump-guest-memory: add basic "detach" support.

2015-11-23 Thread Peter Xu
This will allow the user specify "-d" (just like command "migrate") when using "dump-guest-memory" command. When specified, one background thread is created to do the dump work. One flag is added to show whether there is a background dump work in progress. Signed-off-by: Peter Xu --- dump.c

[Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

2015-11-23 Thread Peter Xu
Currently, dump-guest-memory supports synchronous operation only. This patch sets are adding "detach" support for it (just like "migrate -d" for migration). When "-d" is provided, dump-guest-memory command will return immediately without hanging user. This should be useful when the backend storage

[Qemu-devel] [PATCH 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

2015-11-23 Thread Peter Xu
This patch only add the interfaces, but not implementing them. Signed-off-by: Peter Xu --- dump.c | 3 ++- hmp-commands.hx | 5 +++-- hmp.c| 3 ++- qapi-schema.json | 3 ++- qmp-commands.hx | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dump.c b

[Qemu-devel] [PATCH REPOST 2/2] dump-guest-memory: add basic "detach" support.

2015-11-23 Thread Peter Xu
This will allow the user specify "-d" (just like command "migrate") when using "dump-guest-memory" command. When specified, one background thread is created to do the dump work. One flag is added to show whether there is a background dump work in progress. Signed-off-by: Peter Xu --- dump.c

[Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

2015-11-23 Thread Peter Xu
This patch only add the interfaces, but not implementing them. Signed-off-by: Peter Xu --- dump.c | 3 ++- hmp-commands.hx | 5 +++-- hmp.c| 3 ++- qapi-schema.json | 3 ++- qmp-commands.hx | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dump.c b

[Qemu-devel] [Bug 1518969] [NEW] Instance of QEMU doesn't unplug virtio scsi disk after device_del and drive_del commands

2015-11-23 Thread Marian Horban
Public bug reported: device_del and drive_del commands don't cause virtio disk detaching Steps to reproduce: 1. Run instance 2. Attach virtio scsi disk 3. Reboot instance 4. Immediately after reboot detach disk with QEMU commands: device_del drive_del Expected result: Disk should be detached

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> > "role" was designed to only migrate the master. Ability to migrate a pool >> > of >> > peer would be a significant new feature. I am not aware of such request. >> >> I see. But how is this supposed to work? >> >> Before migra

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 09:17, Ming Lin wrote: > On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: >> >> On 20/11/2015 01:20, Ming Lin wrote: >>> One improvment could be to use google's NVMe vendor extension that >>> I send in another thread, aslo here: >>> https://git.kernel.org/cgit/linux/kernel/gi

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Marc-André Lureau
Hi - Original Message - > > > > You can't migrate the peers. > > Then explain the case N'=0 to me: how can you migrate the master so that > it's connected to a server afterwards? Dest qemu: -incoming.. -chardev socket,path=dest-server That is, start your destination qemu with a destina

Re: [Qemu-devel] [PATCH v5 0/6] fw_cfg: spec update, misc. cleanup, optimize read

2015-11-23 Thread Gabriel L. Somlo
Ping ? I can send out v6 and fix the commit blurb typo in patch 6/6 pointed out by Laszlo (unless the series is already winding its way toward eventually being applied). Please advise. Thanks, --Gabriel On Thu, Nov 05, 2015 at 09:32:46AM -0500, Gabriel L. Somlo wrote: > New since v4: > >

[Qemu-devel] [PATCH] [doc] Introduce coding style for errors

2015-11-23 Thread Lluís Vilanova
Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 52 ++ include/qapi/error.h | 12 util/error.c | 24 +-- 3 files changed, 82 insert

Re: [Qemu-devel] Is ivshmem's test for unix domain client socket valid?

2015-11-23 Thread Paolo Bonzini
On 20/11/2015 18:56, Markus Armbruster wrote: > Looks rather fishy: > > if (strncmp(s->server_chr->filename, "unix:", 5)) { > error_setg(errp, "chardev is not a unix client socket"); > return; > } > > Paolo, is this reliable? Yes, though by total chance

Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

2015-11-23 Thread Paolo Bonzini
On 20/11/2015 18:32, Eric Blake wrote: > > static void qlist_size_iter(QObject *obj, void *opaque) > > { > > size_t *count = opaque; > > (*count)++; > > } > > Yuck - we don't track size independently? Seems like it might make a > worthwhile addition, Would you change your mind, if I to

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Cornelia Huck
On Mon, 23 Nov 2015 11:52:50 +0200 "Michael S. Tsirkin" wrote: > On Mon, Nov 23, 2015 at 10:36:45AM +0100, Cornelia Huck wrote: > > On Mon, 23 Nov 2015 15:41:11 +0800 > > Jason Wang wrote: > > > > > Currently, all virtio devices bypass IOMMU completely. This is because > > > address_space_memor

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Peter Maydell
On 23 November 2015 at 14:34, Cornelia Huck wrote: > The mmio transport is a completely different beast; I'm afraid I don't > know enough about it to say how it interacts with iommus. Conceptually, it's just a device that does DMA, I think. You could in theory put it behind an IOMMU, but nobody d

Re: [Qemu-devel] [PATCH] virtio-blk: Move resetting of req->mr_next to virtio_blk_handle_rw_error

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 01:41, Fam Zheng wrote: > "werror=report" would free the req in virtio_blk_handle_rw_error, we > mustn't write to it in that case. > > Reported-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(

Re: [Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 13:39, Kevin Wolf wrote: > tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ > libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ > - stubs/notify-event.o stubs/replay.o > + stubs/notify-event.o stubs/replay.o stubs/mon-is-qmp.o > st

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> > >> > You can't migrate the peers. >> >> Then explain the case N'=0 to me: how can you migrate the master so that >> it's connected to a server afterwards? > > Dest qemu: -incoming.. -chardev socket,path=dest-server > > That is

Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 14:22, Eduardo Habkost wrote: > > Software Error Recovery, i.e. SER, is purely an Intel feature and it > > shouldn't be set by default. Enable it only on Intel. > > What happens when SER is enabled on an AMD CPU? If it really > should't be enabled, why is KVM returning it on > KVM_

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 10:55, Fam Zheng wrote: >>> Why? I think bitmap_set is a better match with bitmap_new below. >> >> set_bit() is quicker than bitmap_set() if you only set one bit. > > How much quicker is it? This doesn't sound convincing enough for me to lose > the > readability. Substantially.

Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 02:39:27PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: > >> On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: > >> > + > >> > +static const char *base64_valid_chars = > >> > +"ABCDEFGH

Re: [Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup

2015-11-23 Thread Paolo Bonzini
On 23/11/2015 13:39, Kevin Wolf wrote: > One test case closed an event notifier (event_notifier_cleanup()) > without first disabling it (set_event_notifier(..., NULL)). This > resulted in a leftover handle 0 that was added to each subsequent > WaitForMultipleObjects() call, causing the function t

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Marc-André Lureau
- Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> > > >> > You can't migrate the peers. > >> > >> Then explain the case N'=0 to me: how can you migrate the master so that > >> it's connected to a server afterwards? > > > > Dest qemu: -i

Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default

2015-11-23 Thread Borislav Petkov
+ Tony. On Mon, Nov 23, 2015 at 03:47:44PM +0100, Paolo Bonzini wrote: > On 23/11/2015 14:22, Eduardo Habkost wrote: > > > Software Error Recovery, i.e. SER, is purely an Intel feature and it > > > shouldn't be set by default. Enable it only on Intel. > > > > What happens when SER is enabled on a

[Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default)

2015-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2015 at 11:22:37AM -0200, Eduardo Habkost wrote: [...] > In the case of this code, it looks like it's already broken > because the resulting mcg_cap depends on host kernel capabilities > (the ones reported by kvm_get_mce_cap_supported()), and the data > initialized by target-i386/cp

Re: [Qemu-devel] [virtio-dev] [RFC v1] virtio-crypto specification

2015-11-23 Thread Cornelia Huck
On Fri, 20 Nov 2015 03:27:51 + "Gonglei (Arei)" wrote: > Hi guys, > > After initial discussion at this year's KVM forum, I post the RFC version of > virtio-crypto > device specification now. > > If you have any comments, please let me know, thanks. Some further comments from my side, but

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Markus Armbruster
Marc-André Lureau writes: > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> > >> >> > You can't migrate the peers. >> >> >> >> Then explain the case N'=0 to me: how can you migrate the master so that >> >> it's connected to a se

Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

2015-11-23 Thread Andrew Jones
On Mon, Nov 23, 2015 at 06:07:41PM +0800, Peter Xu wrote: > This patch only add the interfaces, but not implementing them. > > Signed-off-by: Peter Xu > --- > dump.c | 3 ++- > hmp-commands.hx | 5 +++-- > hmp.c| 3 ++- > qapi-schema.json | 3 ++- > qmp-commands.hx | 4 ++

Re: [Qemu-devel] [PATCH REPOST 2/2] dump-guest-memory: add basic "detach" support.

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 06:07:42PM +0800, Peter Xu wrote: > This will allow the user specify "-d" (just like command > "migrate") when using "dump-guest-memory" command. When > specified, one background thread is created to do the dump work. > One flag is added to show whether there is a background

[Qemu-devel] [PATCH v5 2/4] kobject: export kset_find_obj() for module use

2015-11-23 Thread Gabriel L. Somlo
From: Gabriel Somlo Signed-off-by: Gabriel Somlo --- lib/kobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kobject.c b/lib/kobject.c index 7cbccd2..90d1be6 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -861,6 +861,7 @@ struct kobject *kset_find_obj(struct kset *kset, const c

[Qemu-devel] [PATCH v5 4/4] devicetree: update documentation for fw_cfg ARM bindings

2015-11-23 Thread Gabriel L. Somlo
From: Gabriel Somlo Remove fw_cfg hardware interface details from Documentation/devicetree/bindings/arm/fw-cfg.txt, and replace them with a pointer to the authoritative documentation in the QEMU source tree. Signed-off-by: Gabriel Somlo Cc: Laszlo Ersek --- Documentation/devicetree/bindings/a

[Qemu-devel] [PATCH v5 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

2015-11-23 Thread Gabriel L. Somlo
From: Gabriel Somlo Make fw_cfg entries of type "file" available via sysfs. Entries are listed under /sys/firmware/qemu_fw_cfg/by_key, in folders named after each entry's selector key. Filename, selector value, and size read-only attributes are included for each entry. Also, a "raw" attribute all

[Qemu-devel] [PATCH v5 3/4] firmware: create directory hierarchy for sysfs fw_cfg entries

2015-11-23 Thread Gabriel L. Somlo
From: Gabriel Somlo Each fw_cfg entry of type "file" has an associated 56-char, nul-terminated ASCII string which represents its name. While the fw_cfg device doesn't itself impose any specific naming convention, QEMU developers have traditionally used path name semantics (i.e. "etc/acpi/rsdp") t

[Qemu-devel] [PATCH v2 02/21] block: Fix reopen with semantically overlapping options

2015-11-23 Thread Kevin Wolf
This fixes bdrv_reopen() calls like the following one: qemu-io -c 'open -o overlap-check.template=all /tmp/test.qcow2' \ -c 'reopen -o overlap-check=none' The approach taken so far would result in an options QDict that has both "overlap-check.template=all" and "overlap-check=none", which

[Qemu-devel] [PATCH v5 0/4] SysFS driver for QEMU fw_cfg device

2015-11-23 Thread Gabriel L. Somlo
Allow access to QEMU firmware blobs, passed into the guest VM via the fw_cfg device, through SysFS entries. Blob meta-data (e.g. name, size, and fw_cfg key), as well as the raw binary blob data may be accessed. The SysFS access location is /sys/firmware/qemu_fw_cfg/... and was selected based on ov

[Qemu-devel] [PATCH v2 07/21] block: Pass driver-specific options to .bdrv_refresh_filename()

2015-11-23 Thread Kevin Wolf
In order to decide whether a blkdebug: filename can be produced or a json: one is necessary, blkdebug checked whether bs->options had more options than just "config", "x-image" or "image" (the latter including nested options). That doesn't work well when generic block layer options are present. Th

[Qemu-devel] [PATCH v2 00/21] block: Cache mode for children etc.

2015-11-23 Thread Kevin Wolf
This is part three (or four, depending on whether you count the bdrv_swap removal) of what I had sent earlier as "[PATCH 00/34] block: Cache mode for children, reopen overhaul and more". Most of the patches were actually already reviewed in v1. This part contains the remaining functional changes t

[Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-23 Thread Kevin Wolf
Some drivers have nested options (e.g. blkdebug rule arrays), which don't belong to a child node and shouldn't be removed. Don't remove all options with "." in their name, but check for the complete prefixes of actually existing child nodes. Signed-off-by: Kevin Wolf --- block.c

[Qemu-devel] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive

2015-11-23 Thread Kevin Wolf
Creating an empty drive while specifying 'format' doesn't make sense. The specified format driver would simply be ignored. Make a set 'format' option an indication that a non-empty drive should be created. This makes 'format' consistent with 'driver' and allows using it with a block driver that do

[Qemu-devel] [PATCH v2 08/21] block: Keep "driver" in bs->options

2015-11-23 Thread Kevin Wolf
Instead of passing a separate drv argument to bdrv_open_common(), just make sure that a "driver" option is set in the QDict. This also means that a "driver" entry is consistently present in bs->options now. This is another step towards keeping all options in the QDict (which is the represenation o

[Qemu-devel] [PATCH v2 05/21] block: Consider all block layer options in append_open_options

2015-11-23 Thread Kevin Wolf
The code already special-cased "node-name", which is currently the only option passed in the QDict that isn't driver-specific. Generalise the code to take all general block layer options into consideration. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block.c |

  1   2   3   >