Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 09:26 PM, Vladimir Sementsov-Ogievskiy wrote: logic is changed: in old version gethugepagesize on statfs error generates exit(1) in new it returns getpagesize() in this case (through fd_getpagesize) (I think, fd_getpagesize should be fixed to handle error) Indeed. I wi

Re: [Qemu-devel] [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 10:04 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: Currently file_ram_alloc() is designed for hugetlbfs, however, the memory of nvdimm can come from either raw pmem device eg, /dev/pmem, or the file locates at DAX enabled filesystem So this

Re: [Qemu-devel] [PATCH v6 09/33] exec: allow file_ram_alloc to work on file

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 10:25 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: Currently, file_ram_alloc() only works on directory - it creates a file under @path and do mmap on it This patch tries to allow it to work on file directly, if @path is a directory it works

Re: [Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 11:27 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: Use the whole file size if @size is not specified which is useful if we want to directly pass a file to guest Signed-off-by: Xiao Guangrong --- backends/hostmem-file.c | 48 ++

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 11:54 PM, Eduardo Habkost wrote: On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: There are three places use the some logic to get the page size on the file path or file fd This patch introduces qemu_file_get_page_size() to unify the code Signed-off-by: Xiao Guan

Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 12:10 AM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: This patch is generated by this script: find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PC_DIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json"

Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 01:06 AM, Eric Blake wrote: On 10/29/2015 11:56 PM, Xiao Guangrong wrote: This patch is generated by this script: find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \ | xargs sed -i "s/PC_DIMM/DIMM/g" find ./ -name "*.[ch]" -o -name "*.json" -o -name "trac

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Xiao Guangrong
On 10/30/2015 11:54 PM, Eduardo Habkost wrote: On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: There are three places use the some logic to get the page size on the file path or file fd This patch introduces qemu_file_get_page_size() to unify the code Signed-off-by: Xiao Guan

Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address

2015-10-31 Thread Shannon Zhao
On 2015/10/22 1:52, Knut Omang wrote: > On Mon, 2015-10-12 at 12:14 +0100, Daniel P. Berrange wrote: >> If the port in the SocketAddress struct is NULL, it can allow >> the kernel to automatically select a free port. This is useful >> in particular in unit tests to avoid a race trying to find a >

Re: [Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 01:30 AM, Eduardo Habkost wrote: On Fri, Oct 30, 2015 at 01:56:05PM +0800, Xiao Guangrong wrote: Use the whole file size if @size is not specified which is useful if we want to directly pass a file to guest Signed-off-by: Xiao Guangrong --- backends/hostmem-file.c | 48 ++

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 31.10.2015 10:26, Xiao Guangrong wrote: On 10/30/2015 09:26 PM, Vladimir Sementsov-Ogievskiy wrote: logic is changed: in old version gethugepagesize on statfs error generates exit(1) in new it returns getpagesize() in this case (through fd_getpagesize) (I think, fd_getpagesize s

[Qemu-devel] [PATCH] ARM: ACPI: Fix MPIDR value in ACPI table

2015-10-31 Thread Shannon Zhao
From: Shannon Zhao Use mp_affinity of ARMCPU as the CPU MPIDR instead of the CPU index. Signed-off-by: Shannon Zhao --- This patch is based on below patch. http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg06919.html hw/arm/virt-acpi-build.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [Qemu-devel] [PATCH v6 16/33] pc-dimm: rename pc-dimm.c and pc-dimm.h

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: Rename: pc-dimm.c => dimm.c pc-dimm.h => dimm.h It prepares the work which abstracts dimm device type for both pc-dimm and nvdimm Signed-off-by: Xiao Guangrong --- hw/Makefile.objs | 2 +- hw/acpi/ich9.c

Re: [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag

2015-10-31 Thread Peter Maydell
On 31 October 2015 at 03:40, Peter Crosthwaite wrote: > On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell > wrote: >> On 30 October 2015 at 20:59, Peter Crosthwaite >> wrote: >>> On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell >>> wrote: Is it an error for the board to set secure_board_setup

Re: [Qemu-devel] [PATCH v2 03/16] sockets: allow port to be NULL when listening on IP address

2015-10-31 Thread Peter Maydell
On 31 October 2015 at 08:51, Shannon Zhao wrote: > On 2015/10/22 1:52, Knut Omang wrote: >> I just noticed that after a rebase a few minutes ago, all options I >> have that uses this type of port syntax: >> >> -serial telnet:ip:port >> -serial tcp:ip:port >> -qmp ip:port >> > And -monitor telnet::

Re: [Qemu-devel] [PATCH v6 17/33] dimm: abstract dimm device from pc-dimm

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: A base device, dimm, is abstracted from pc-dimm, so that we can build nvdimm device based on dimm in the later patch Signed-off-by: Xiao Guangrong --- default-configs/i386-softmmu.mak | 1 + default-configs/ppc64-softmmu.mak | 1 + default-con

Re: [Qemu-devel] [PATCH v6 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: Curretly, the memory region of backed memory is directly mapped to guest's address space, however, it is not true for nvdimm device This patch let dimm device realize this fact and use DIMMDeviceClass->get_memory_region method to get the mapped memory r

Re: [Qemu-devel] [PATCH v6 19/33] dimm: keep the state of the whole backend memory

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should protect the whole backend memory instead Signed-off-by: Xiao Guangrong ---

Re: [Qemu-devel] [PATCH v6 20/33] dimm: introduce realize callback

2015-10-31 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: nvdimm need check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong --- h

Re: [Qemu-devel] [RFC v2] target-arm: Add and use symbolic names for register banks

2015-10-31 Thread Edgar E. Iglesias
On Thu, Oct 29, 2015 at 01:16:06PM -0700, Soren Brinkmann wrote: > Add BANK_ #defines to index banked registers. > > Suggested-by: Peter Maydell > Signed-off-by: Soren Brinkmann Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias > --- > v2: > - move #defines from cpu.h to interna

Re: [Qemu-devel] [PULL] tilegx queued patch

2015-10-31 Thread Chen Gang
On 10/31/15 04:44, Richard Henderson wrote: > Just one mergable patch since the last update. > I guess this will be it before hard-freeze. > Thank you for your work. I have finished coding for the implementation of tilegx floating point instructions, at present, I am just testing and fixing the r

Re: [Qemu-devel] [PATCH v2] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt

2015-10-31 Thread Maciej W. Rozycki
On Mon, 19 Oct 2015, Leon Alrae wrote: > >> Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither > >> they require any particular mode for its FPU. This patch removes the checks > >> that may break a program that uses these instructions. > > > > That is correct. That said th

[Qemu-devel] [Bug 1511887] [NEW] USB device 1.1 not correctly passedthru from Linux host to Windows guest

2015-10-31 Thread Jiri Cejka
Public bug reported: I have USB Digital Oscilloscope which works great on pure Windows machine but not work on virtualized one. I tried passthru the device from my Debian Jessie (64bit) host machine to Windows 7 (32bit) guest machine but unfortunately it does not work very well. It looks that devi

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 05:37 PM, Vladimir Sementsov-Ogievskiy wrote: On 31.10.2015 10:26, Xiao Guangrong wrote: On 10/30/2015 09:26 PM, Vladimir Sementsov-Ogievskiy wrote: logic is changed: in old version gethugepagesize on statfs error generates exit(1) in new it returns getpagesize() in

Re: [Qemu-devel] [PATCH v6 18/33] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 06:52 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: Curretly, the memory region of backed memory is directly mapped to guest's address space, however, it is not true for nvdimm device This patch let dimm device realize this fact and use DIMMD

Re: [Qemu-devel] [PATCH v6 19/33] dimm: keep the state of the whole backend memory

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 07:05 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should protect the w

[Qemu-devel] [RESEND V10 1/3] sd.h: Move sd.h to include/hw/sd/

2015-10-31 Thread Sai Pavan Boddu
Create a sd directory under include/hw/ and move sd.h to include/hw/sd/ Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V10: Fix Commit Message. Changes for V9: None. Changes for V8: None Changes for V7: None Changes fo

[Qemu-devel] [RESEND V10 2/3] sdhci: Split sdhci.h for public and internal device usage

2015-10-31 Thread Sai Pavan Boddu
Split sdhci.h into pubilc version (i.e include/hw/sd/sdhci.h) and internal version (i.e hw/sd/sdhci-interna.h) based on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V10: None Changes

[Qemu-devel] [RESEND V10 3/3] target-arm: xlnx-zynqmp: Add sdhci support.

2015-10-31 Thread Sai Pavan Boddu
Add two SYSBUS_SDHCI devices for xlnx-zynqmp Signed-off-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite --- Changes for V10: Commit appended with target-arm Changes for V9: Fixed Commit message. Removed trailing backslash on long lines. Renamed the object name to sdhci form zy

[Qemu-devel] [PATCH v4 1/3] armv7-m: Return DeviceState* from armv7m_init()

2015-10-31 Thread Michael Davidsaver
Change armv7m_init to return the DeviceState* for the NVIC. This allows access to all GPIO blocks, not just the IRQ inputs. Move qdev_get_gpio_in() calls out of armv7m_init() into board code for stellaris and stm32f205 boards. --- hw/arm/armv7m.c| 9 ++--- hw/arm/stellaris.c | 29

[Qemu-devel] [RESEND V10 0/3] Move sdhci.h to include/hw/sd

2015-10-31 Thread Sai Pavan Boddu
Move sdhci.h splitting it into common and internal. Create a new directory for sd in include/hw/. Correct paths of sd.h in at every instance of #include. Add sdhci to xlnx-zynqmp SOC. Sai Pavan Boddu (3): sd.h: Move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device usa

[Qemu-devel] [PATCH v4 3/3] arm: stellaris: exit on external reset request

2015-10-31 Thread Michael Davidsaver
Add GPIO in for the stellaris board which calls qemu_system_reset_request() on reset request. --- hw/arm/stellaris.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 82a4ad5..0114e0a 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellar

[Qemu-devel] [PATCH v4 0/3] armv7-m: exit on external reset request

2015-10-31 Thread Michael Davidsaver
Resending patch set. The only change from v3 is to the message of #3. Changes armv7-m to implement the SYSRESETREQ register as GPIO. This necessitates some refactoring of armv7m_init() and the board code which calls it to allow the additional named GPIO to be used in board code. The Stellaris boa

[Qemu-devel] [PATCH v4 2/3] armv7-m: Implement SYSRESETREQ

2015-10-31 Thread Michael Davidsaver
Implement the SYSRESETREQ bit of the AIRCR register for armv7-m (ie. cortex-m3) to trigger a GPIO out. --- hw/intc/armv7m_nvic.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c index 3ec8408..6fc167e 100644 --- a/hw/intc/arm

Re: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

2015-10-31 Thread Sai Pavan Boddu
Hi Peter, I figured out that, this patch need few more patch to be pushed in first, to clearly apply. And I am planning to send the same. Thanks, SaI Pavan > -Original Message- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, October 08, 2015 9:22 PM > To:

Re: [Qemu-devel] [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path

2015-10-31 Thread Eduardo Habkost
On Sat, Oct 31, 2015 at 03:44:39PM +0800, Xiao Guangrong wrote: > On 10/30/2015 10:04 PM, Vladimir Sementsov-Ogievskiy wrote: > >On 30.10.2015 08:56, Xiao Guangrong wrote: > >>Currently file_ram_alloc() is designed for hugetlbfs, however, the memory > >>of nvdimm can come from either raw pmem devic

Re: [Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-31 Thread Eduardo Habkost
On Sat, Oct 31, 2015 at 04:46:05PM +0800, Xiao Guangrong wrote: > On 10/31/2015 01:30 AM, Eduardo Habkost wrote: > >On Fri, Oct 30, 2015 at 01:56:05PM +0800, Xiao Guangrong wrote: > >>Use the whole file size if @size is not specified which is useful > >>if we want to directly pass a file to guest >

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Eduardo Habkost
On Sat, Oct 31, 2015 at 04:09:56PM +0800, Xiao Guangrong wrote: > On 10/30/2015 11:54 PM, Eduardo Habkost wrote: > >On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: > >>There are three places use the some logic to get the page size on > >>the file path or file fd > >> > >>This patch

Re: [Qemu-devel] [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 09:55 PM, Eduardo Habkost wrote: On Sat, Oct 31, 2015 at 03:44:39PM +0800, Xiao Guangrong wrote: On 10/30/2015 10:04 PM, Vladimir Sementsov-Ogievskiy wrote: On 30.10.2015 08:56, Xiao Guangrong wrote: Currently file_ram_alloc() is designed for hugetlbfs, however, the memory of n

[Qemu-devel] [PATCH] target-tilegx: Implement floating point instructions

2015-10-31 Thread Chen Gang
>From 42733d085bfcb4882cfa4eb25a9387e3d953a64f Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 1 Nov 2015 00:50:33 +0800 Subject: [PATCH] target-tilegx: Implement floating point instructions It is implenented in a normal way, and passed unit tests (8 test cases). Signed-off-by: Chen Gang --

Re: [Qemu-devel] [PATCH v6 11/33] hostmem-file: use whole file size if possible

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 09:45 PM, Eduardo Habkost wrote: On Sat, Oct 31, 2015 at 04:46:05PM +0800, Xiao Guangrong wrote: On 10/31/2015 01:30 AM, Eduardo Habkost wrote: On Fri, Oct 30, 2015 at 01:56:05PM +0800, Xiao Guangrong wrote: Use the whole file size if @size is not specified which is useful if w

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-31 Thread Xiao Guangrong
On 10/31/2015 10:11 PM, Eduardo Habkost wrote: On Sat, Oct 31, 2015 at 04:09:56PM +0800, Xiao Guangrong wrote: On 10/30/2015 11:54 PM, Eduardo Habkost wrote: On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: There are three places use the some logic to get the page size on the

Re: [Qemu-devel] [PATCH v3 1/4] mirror: block all operations on the target image during the job

2015-10-31 Thread Max Reitz
On 23.10.2015 14:03, Alberto Garcia wrote: > There's nothing preventing the target image from being used by other > operations during the 'drive-mirror' job, so we should block them all > until the job is done. > > Signed-off-by: Alberto Garcia > --- > block/mirror.c | 4 > 1 file changed,

Re: [Qemu-devel] [RESEND V10 0/3] Move sdhci.h to include/hw/sd

2015-10-31 Thread Peter Crosthwaite
On Sat, Oct 31, 2015 at 8:03 AM, Sai Pavan Boddu wrote: > Move sdhci.h splitting it into common and internal. > Create a new directory for sd in include/hw/. > Correct paths of sd.h in at every instance of #include. > Add sdhci to xlnx-zynqmp SOC. > > Sai Pavan Boddu (3): > sd.h: Move sd.h to in

Re: [Qemu-devel] [PATCH for-2.5] MAINTAINERS: Add new qemu-arm mailing list to ARM related entries

2015-10-31 Thread Peter Crosthwaite
On Thu, Oct 29, 2015 at 7:41 AM, Peter Maydell wrote: > We now have a qemu-arm mailing list for ARM patches and discussion, > so add an L: entry for it to the various ARM related entries in > MAINTAINERS. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > I basically just

Re: [Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command

2015-10-31 Thread Max Reitz
On 23.10.2015 14:03, Alberto Garcia wrote: > This command is still experimental, hence the name. > > This is the companion to 'blockdev-add'. It allows deleting a > BlockBackend with its associated BlockDriverState tree, or a > BlockDriverState that is not attached to any backend. > > In either c

Re: [Qemu-devel] [Qemu-arm] [PATCH] ARM: ACPI: Fix MPIDR value in ACPI table

2015-10-31 Thread Peter Crosthwaite
On Sat, Oct 31, 2015 at 2:50 AM, Shannon Zhao wrote: > From: Shannon Zhao > > Use mp_affinity of ARMCPU as the CPU MPIDR instead of the CPU index. > > Signed-off-by: Shannon Zhao > --- > This patch is based on below patch. > http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg06919.html >

Re: [Qemu-devel] [PATCH v3 4/4] iotests: Add tests for the x-blockdev-del command

2015-10-31 Thread Max Reitz
On 23.10.2015 14:03, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/139 | 408 > + > tests/qemu-iotests/139.out | 5 + > tests/qemu-iotests/group | 1 + > 3 files changed, 414 insertions(+) > create mode 100

Re: [Qemu-devel] [Qemu-arm] [PATCH] ARM: ACPI: Fix MPIDR value in ACPI table

2015-10-31 Thread Peter Maydell
On 31 October 2015 at 18:53, Peter Crosthwaite wrote: > On Sat, Oct 31, 2015 at 2:50 AM, Shannon Zhao > wrote: >> From: Shannon Zhao >> >> Use mp_affinity of ARMCPU as the CPU MPIDR instead of the CPU index. >> >> Signed-off-by: Shannon Zhao >> --- >> This patch is based on below patch. >> htt

Re: [Qemu-devel] [PATCH] target-tilegx: Implement floating point instructions

2015-10-31 Thread Chen Gang
Oh, sorry, it can not pass gcc testsuite: the fdouble mul insns have issues (original temporary implementation had no this cases -- it skipped the outside mul operation). After it passes gcc testtsuite, I shall split it into several small patches, and send patch v2 (I shall try to finish today).