Replace most fprintf(stderr) calls on vl.c with error_report().
Multi-line messages were replaced by error_report() followed by
error_printf().
The following changes were made to the error messages:
* The "invalid date format" message was reworded to better fit
the new error_report()+error_pri
Suggested-by: Eric Blake
Signed-off-by: Eduardo Habkost
---
vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 44f9f54..5c7c91f 100644
--- a/vl.c
+++ b/vl.c
@@ -965,7 +965,7 @@ static struct bt_device_s *bt_device_add(const char *opt)
if (!strcmp(
Suggested-by: Andrew Jones
Signed-off-by: Eduardo Habkost
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index c417b06..2d48e22 100644
--- a/vl.c
+++ b/vl.c
@@ -3735,7 +3735,7 @@ int main(int argc, char **argv, char **envp)
break;
This usage of fprintf(stderr) can't be directly converted to
error_report() like the others, because a single error message is split
into multiple fprintf() calls. Make separate error_report() calls for
each case.
Suggested-by: Markus Armbruster
Reviewed-by: Markus Armbruster
Signed-off-by: Edua
Suggested-by: Andrew Jones
Signed-off-by: Eduardo Habkost
---
Changes series v2 -> v3:
* Converted two additional cases in the same patch:
"Cannot initialize crypto" and "curses support is disabled"
* Change from "fail to parse" to "failed to parse" will be done
in a separate patch
---
vl.c
Except for removing periods and exclamation points, no other changes
were made to the error messages (yet).
Suggested-by: Markus Armbruster
Signed-off-by: Eduardo Habkost
---
Changes series v2 -> v3:
* Remove exclamation points from some messages too
* Fix "No machine specified, and there is no
Signed-off-by: Eduardo Habkost
---
Changes series v2 -> v3:
* Use "support is disabled" instead of "support disabled"
* Suggested-by: Markus Armbruster
* Suggested-by: Andrew Jones
---
vl.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index e29
Suggested-by: Eric Blake
Signed-off-by: Eduardo Habkost
---
vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 3841ada..44f9f54 100644
--- a/vl.c
+++ b/vl.c
@@ -4168,12 +4168,12 @@ int main(int argc, char **argv, char **envp)
if (display_type
Suggested-by: Andrew Jones
Signed-off-by: Eduardo Habkost
---
vl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index ec677de..3841ada 100644
--- a/vl.c
+++ b/vl.c
@@ -2278,7 +2278,7 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts,
Error **errp
Simplify warnings about deprecated options by rewriting them as
"warning: ignoring deprecated option".
Suggested-by: Andrew Jones
Signed-off-by: Eduardo Habkost
---
Changes series v2 -> v3:
* No need to mention option name in error message, as it is already
present in the prefix printed by err
Signed-off-by: Eduardo Habkost
---
Changes series v2 -> v3:
* No need to mention option name in error message, as it is already
present in the prefix printed by error_report()
* Suggested-by: Markus Armbruster
---
vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/v
On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote:
[...]
> index 095de5d..0a08531 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -2,7 +2,51 @@
> #define HW_COMPAT_H
>
> #define HW_COMPAT_2_4 \
> -/* empty */
> +{\
> +.driver = "v
On 10/30/2015 01:52 AM, Markus Armbruster wrote:
I'm assuming you temporarily patched check-qjson to use larger constants
when you hit your ~100K token testing? Because I am definitely seeing a
lot of execution time spent on large_dict when running tests/check-qjson
by hand, i
On 30.10.2015 08:56, Xiao Guangrong wrote:
Use the whole file size if @size is not specified which is useful
if we want to directly pass a file to guest
Signed-off-by: Xiao Guangrong
---
backends/hostmem-file.c | 48
1 file changed, 44 inserti
On 30.10.2015 08:56, Xiao Guangrong wrote:
pc_existing_dimms_capacity() can be static since it is not used out of
pc-dimm.c and drop the pc_ prefix to prepare the work which abstracts
dimm device type from pc-dimm
Signed-off-by: Xiao Guangrong
---
hw/mem/pc-dimm.c | 73 +++
On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote:
> +int rfifolock_is_locked(RFifoLock *r);
Please use bool instead of int.
> diff --git a/util/rfifolock.c b/util/rfifolock.c
> index afbf748..8ac58cb 100644
> --- a/util/rfifolock.c
> +++ b/util/rfifolock.c
> @@ -48,7 +48,7 @@ void
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
Rather than slicing the end of a string, we can use python's
endswith(). And rather than creating a set of characters,
we can search for a character within a string.
Signed-off-by: Eric Blake
Message-Id: <1445898903-12082-3-git-send-email-ebl...@redhat.com>
Signed-off-by: Mark
On 10/30/2015 05:20 AM, Markus Armbruster wrote:
> For now, only high-level review.
>
> The main cost of sorting is interface complexity: we need to specify
> which things are sorted, and what the sorting order is (see your TODO
> below). Once we've done so, we can't go back.
>
> There's also im
On Wed, Oct 28, 2015 at 06:01:03PM +0300, Denis V. Lunev wrote:
> This helper is necessary to ensure locking constraints.
>
> Signed-off-by: Denis V. Lunev
> CC: Stefan Hajnoczi
> CC: Paolo Bonzini
> ---
> async.c | 5 +
> include/block/aio.h | 3 +++
> 2 files changed, 8 inser
The following changes since commit fdf927621a99711bf1a81712bce054794f2d44c3:
Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-10-30'
into staging (2015-10-30 09:41:15 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-10-30
From: Eric Blake
We generate a static visit_type_FOO_fields() for every type
FOO. However, sometimes we need a forward declaration. Split
the code to generate the forward declaration out of
gen_visit_implicit_struct() into a new gen_visit_fields_decl(),
and also prepare for a forward declaration
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
A previous patch (commit 1e6c1616) made it possible to
directly cast from a qapi flat union type to its base type.
However, it requires the use of a C cast, which turns off
compiler type-safety checks. Fortunately, no such casts
exist, just yet.
Regardless, add inline type-safe
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
We were using regular expressions to see if ret included
any earlier text that emitted a 'goto out;' line, to decide
whether we needed to output an 'out:' label. But this is
fragile, if the ret text can possibly combine more than one
generated function body, where the first func
From: Eric Blake
A future qapi patch will rework generated structs with a base
class to be unboxed. In preparation for that, change the code
that allocates then populates an info struct to instead merely
populate the fields of an info field passed in as a parameter
(renaming vnc_basic_info_get*
From: Eric Blake
Move code from gen_union() into gen_struct_fields() in order for
a later patch to share code when enumerating inherited fields
for struct types.
No change to generated code.
Signed-off-by: Eric Blake
Message-Id: <1445898903-12082-9-git-send-email-ebl...@redhat.com>
Signed-off-
From: Eric Blake
Add some testsuite coverage to ensure future patches are on
the right track:
Our current C representation of qapi arrays is done by appending
'List' to the element name; but we are not preventing the
creation of an object type with the same name. Add
reserved-type-list.json to
From: Eric Blake
c_name() produces names starting with 'q_' when protecting a
dictionary member name that would fail to directly compile, but
in doing so can cause clashes with any member name already
beginning with 'q-' or 'q_'. Likewise, we create a C name 'has_'
for any optional member that c
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
Rather than storing a base class as a pointer to a box, just
store the fields of that base class in the same order, so that
a child struct can be directly cast to its parent. This gives
less malloc overhead, less pointer dereferencing, and even less
generated code. Compare to t
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
Type names ending in 'List' can clash with qapi list types in
generated C. We don't currently use such names. It is easier to
outlaw them now than to worry about how to resolve such a clash
in the future. For precedence, see commit 4dc2e69, which did the
same for names ending in
From: Eric Blake
Now that we have separated union tag values from colliding with
non-variant C names, by naming the union 'u', we should reserve
this name for our use. Note that we want to forbid 'u' even in
a struct with no variants, because it is possible for a future
qemu release to extend QM
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
Rather than having all callers pass a name, type, and optional
flag, have them instead pass a QAPISchemaObjectTypeMember which
already has all that information.
No change to generated code.
Signed-off-by: Eric Blake
Message-Id: <1445898903-12082-25-git-send-email-ebl...@redhat
From: "Daniel P. Berrange"
Revert the qapi-schema.json change done in:
commit 0983f5e6af76d5df8c6346cbdfff9d8305fb6da0
Author: Daniel P. Berrange
Date: Tue Sep 1 14:46:50 2015 +0100
sockets: allow port to be NULL when listening on IP address
Switching "port" from mandatory to opti
On Wed, Oct 28, 2015 at 06:01:04PM +0300, Denis V. Lunev wrote:
> as described in the comment of the function
>
> Signed-off-by: Denis V. Lunev
> CC: Stefan Hajnoczi
> CC: Paolo Bonzini
> ---
> block/io.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/block/io.c
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
From: Eric Blake
We have two issues with our qapi union layout:
1) Even though the QMP wire format spells the tag 'type', the
C code spells it 'kind', requiring some hacks in the generator.
2) The C struct uses an anonymous union, which places all tag
values in the same namespace as all non-varia
On Wed, Oct 28, 2015 at 06:01:05PM +0300, Denis V. Lunev wrote:
> diff --git a/block/snapshot.c b/block/snapshot.c
> index 89500f2..f6fa17a 100644
> --- a/block/snapshot.c
> +++ b/block/snapshot.c
> @@ -259,6 +259,9 @@ void bdrv_snapshot_delete_by_id_or_name(BlockDriverState
> *bs,
> {
> int
From: Eric Blake
The code for visiting the base class of a child struct created
visit_type_Base_fields() which covers all fields of Base; while
the code for visiting the base class of a flat union created
visit_type_Union_fields() covering all fields of the base
except the discriminator. But sin
On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote:
> There are three places use the some logic to get the page size on
> the file path or file fd
>
> This patch introduces qemu_file_get_page_size() to unify the code
>
> Signed-off-by: Xiao Guangrong
[...]
> diff --git a/util/oslib-p
This one slipped through. Although we acquire AioContext when
committing all devices we don't for just a single device.
AioContext must be acquired before calling bdrv_*() functions to
synchronize access with other threads that may be using the AioContext.
Signed-off-by: Stefan Hajnoczi
---
bl
On Fri, Oct 30, 2015 at 03:57:41PM +, Stefan Hajnoczi wrote:
> This one slipped through. Although we acquire AioContext when
> committing all devices we don't for just a single device.
>
> AioContext must be acquired before calling bdrv_*() functions to
> synchronize access with other threads
On 30.10.2015 08:56, Xiao Guangrong wrote:
This patch is generated by this script:
find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
| xargs sed -i "s/PC_DIMM/DIMM/g"
find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
| xargs sed -i "s/PCDIMM/DIM
29.10.2015 17:28, Dmitry Osipenko пишет:
- Disable limiting for that host machine?
- Tune timer limit?
These tho variants seem too farfetched, since we don't distinguish the guest
software timer poll and some device internal ptimer_get_count() call. Just a note.
--
Dmitry
ble in the git repository at:
>
> git://github.com/otubo/qemu.git tags/pull-seccomp-20151030
>
> for you to fetch changes up to b1e1f0bbe7268d0bb8f63da220b41803b2e54081:
>
> seccomp: loosen library version dependency (2015-10-30 14:33:00 +0100)
>
> --
On 10/30/2015 06:54 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> We were previously creating all unions with an empty list for
>> local_members. However, it will make it easier to unify struct
>> and union generation if we include the generated tag member in
>> local_members. That way
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > In postcopy, the destination guest is running at the same time
> > as it's receiving pages; as we receive new pages we must put
> > them into the guests address space at
Eduardo Habkost writes:
> Changes v2 -> v3:
> * Removed patch: "vl.c: Convert error sentences to simpler phrases"
> * Removed patch: "vl.c: Reword -machine help error messages"
> * Removed patch: "vl.c: Reword fw_cfg name prefix warning"
> * Removed patch: "vl.c: Use US spelling for 'unrecognized
On 10/30/2015 07:01 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> These two methods are now close enough that we can finally merge
>> them, relying on the fact that simple unions now provide a
>> reasonable local_members. Change gen_struct() to gen_object()
>> that handles all forms of
Hi Yongbok,
On Tue, Oct 27, 2015 at 05:12:36PM +, Yongbok Kim wrote:
> The Global Interrupt Controller (GIC) is responsible for mapping each
> internal and external interrupt to the correct location for servicing.
>
> The internal representation of registers is different from the specificatio
On 23/10/15 14:56, Mark Cave-Ayland wrote:
> This is a rework of Cormac O'Brien's GSoC project to try and boot MacOS 9
> under
> QEMU, the original version of which was posted to the qemu-devel list at the
> end of August
> (https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02521.html).
>
On 26/10/15 09:48, Mark Cave-Ayland wrote:
> On 06/09/15 12:54, Mark Cave-Ayland wrote:
>
>> On 06/09/15 09:36, Alexander Graf wrote:
>>
>>> On 05.09.15 21:51, Mark Cave-Ayland wrote:
Commit 61964 "Add configuration section" broke the analyze-migration.py
script
which terminates d
On Wed, Oct 28, 2015 at 05:48:02PM +0200, Michael S. Tsirkin wrote:
> Use address_space_read to make sure we handle the case of an indirect
> descriptor crossing DIMM boundary correctly.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> Warning: compile-tested only.
>
> hw/virtio/dataplane/vring
On Thu, Oct 29, 2015 at 11:28:05AM +0100, Igor Mammedov wrote:
> On Wed, 28 Oct 2015 17:48:02 +0200
> "Michael S. Tsirkin" wrote:
> > -struct vring_desc *desc_ptr;
> > -MemoryRegion *mr;
> > -
> > /* Translate indirect descriptor */
> > -desc_ptr = vring_map(&mr,
>
On 10/29/2015 11:56 PM, Xiao Guangrong wrote:
> This patch is generated by this script:
>
> find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
> | xargs sed -i "s/PC_DIMM/DIMM/g"
>
> find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
> | xargs sed -
On 29.10.2015 19:04, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu-io from a bash subshell,
> in order to catch segfaults. This method is incompatible with the
> current valgrind_qemu_io() bash function.
>
> Move the valgrind usage into the exec subshell in _qemu_io_wrapper()
7bc8e0c967a4ef77657174d28af775691e18b4ce:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2015-10-29 09:49:52 +)
>
> are available in the git repository at:
>
> git://github.com/lalrae/qemu.git tags/mips-20151030
>
> for you to f
On Fri, Oct 30, 2015 at 01:07:51PM -0200, Eduardo Habkost wrote:
> Changes v2 -> v3:
> * Removed patch: "vl.c: Convert error sentences to simpler phrases"
> * Removed patch: "vl.c: Reword -machine help error messages"
> * Removed patch: "vl.c: Reword fw_cfg name prefix warning"
> * Removed patch: "
On 10/30/2015 01:13 AM, Bo Tu wrote:
> Be easier to read, and be slightly shorter.
You mentioned a very short "what" in the subject line (good), but the
"why" in the commit body ("easier to read, shorter") is rather terse and
subjective. It would be nicer to go into details (change the definition
On 30 October 2015 at 14:19, Markus Armbruster wrote:
> Peter Maydell writes:
>> I get an error on 64-bit ARM running the ivshmem tests:
>>
>> TEST: tests/ivshmem-test... (pid=22948)
>> /i386/ivshmem/single:OK
>> /i386/ivshmem/pair:
On Fri, Oct 30, 2015 at 05:23:27PM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > Changes v2 -> v3:
> > * Removed patch: "vl.c: Convert error sentences to simpler phrases"
> > * Removed patch: "vl.c: Reword -machine help error messages"
> > * Removed patch: "vl.c: Reword fw_cfg n
On Fri, Oct 30, 2015 at 01:56:05PM +0800, Xiao Guangrong wrote:
> Use the whole file size if @size is not specified which is useful
> if we want to directly pass a file to guest
>
> Signed-off-by: Xiao Guangrong
> ---
> backends/hostmem-file.c | 48 ---
On 29.10.2015 12:56, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
> subshell, in order to catch segfaults. Unfortunately, this means the
> process PID cannot be captured via '$!'. We stopped killing qemu and
> qemu-nbd processes, leaving a lot of orph
On Fri, Oct 30, 2015 at 06:37:34PM +0100, Max Reitz wrote:
> On 29.10.2015 12:56, Jeff Cody wrote:
> > Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
> > subshell, in order to catch segfaults. Unfortunately, this means the
> > process PID cannot be captured via '$!'. We s
On 10/29/2015 07:41 PM, Lan Tianyu wrote:
On 2015年10月30日 00:17, Alexander Duyck wrote:
On 10/29/2015 01:33 AM, Lan Tianyu wrote:
On 2015年10月29日 14:58, Alexander Duyck wrote:
Your code was having to do a bunch of shuffling in order to get things
set up so that you could bring the interface back
On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote:
> On 29.10.2015 19:04, Jeff Cody wrote:
> > Commit 934659c switched the iotests to run qemu-io from a bash subshell,
> > in order to catch segfaults. This method is incompatible with the
> > current valgrind_qemu_io() bash function.
> >
>
On 30.10.2015 19:04, Jeff Cody wrote:
> On Fri, Oct 30, 2015 at 06:16:29PM +0100, Max Reitz wrote:
>> On 29.10.2015 19:04, Jeff Cody wrote:
>>> Commit 934659c switched the iotests to run qemu-io from a bash subshell,
>>> in order to catch segfaults. This method is incompatible with the
>>> current
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy
> >
> > 'migration_in_postcopy' is provided for other sections to know if
> > they're in postc
On 29.10.2015 14:00, Alberto Garcia wrote:
> There are several sanity checks for the 'blockdev-snapshot' command,
> but none covers the use of a file BDS as the overlay node.
>
> { 'execute': 'blockdev-add', 'arguments':
> { 'options': { 'driver': 'qcow2',
>'n
2015-10-12'
> > into staging (2015-10-13 10:42:06 +0100)
> >
> > are available in the git repository at:
> >
> > git://github.com/otubo/qemu.git tags/pull-seccomp-20151030
> >
> > for you to fetch changes up to b1e1f0bbe7268d0bb8f63da220b41803b2e5408
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Where postcopy is preceeded by a period of precopy, the destination will
> > have received pages that may have been dirtied on the source after the
> > page was sent. T
The x86 change to make "check" mode be enabled by default made QEMU print a
warning in the default case if running in an Intel host:
$ qemu-system-x86_64 -machine pc,accel=kvm
warning: host doesn't support requested feature: CPUID.8001H:ECX.sse4a
[bit 6]
Fix this by not enabling sse4a in
This will allow us to define class-specific KVM defaults, instead of
defaults that apply to all CPU models.
If this table is starting to look like the global properties tables,
that's not a coincidence: in the future, we might convert this to
accelerator-specific code that simply register global p
We will need to call x86_cpu_change_kvm_default() for pc-2.4 too, so we
will need a pc_compat_2_4() function.
I plan to fix this by adding a kvm_defaults list to PCMachineClass
later, but while we don't have that, let's do it the easy way and add
the new function.
Signed-off-by: Eduardo Habkost
The x86 change to make "check" mode be enabled by default made QEMU print a
warning in the default case if running in an Intel host:
$ qemu-system-x86_64 -machine pc,accel=kvm
warning: host doesn't support requested feature: CPUID.8001H:ECX.sse4a
[bit 6]
Fix this by not enabling sse4a in
On Fri, Oct 30, 2015 at 05:00:57PM -0200, Eduardo Habkost wrote:
> The x86 change to make "check" mode be enabled by default made QEMU print a
> warning in the default case if running in an Intel host:
>
> $ qemu-system-x86_64 -machine pc,accel=kvm
> warning: host doesn't support requested fea
On 28.10.2015 14:43, Alberto Garcia wrote:
> 'block-commit' needs write access to two different nodes of the chain:
>
> - 'base', because that's where the data is written to.
> - the overlay of 'top', because it needs to update the backing file
> string to point to 'base' after the operation.
>
On 28.10.2015 14:43, Alberto Garcia wrote:
> The 'block-commit' command needs the overlay image of 'top' to
> be opened in read-write mode in order to update the backing file
> string. If 'top' is not the active layer or its backing file then its
> overlay needs to be reopened during the block job.
Changes from v2:
* Pulled patch 2 into this series
* Patch 1: Moved non-empty test conditionals inside
pid file existance check (thanks Max)
Added a fix in for patch 058, for its
self-launched qemu-nbd instance (thanks Max)
* Patch 2: Only print the valgrind log
Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
subshell, in order to catch segfaults. Unfortunately, this means the
process PID cannot be captured via '$!'. We stopped killing qemu and
qemu-nbd processes, leaving a lot of orphaned, running qemu processes
after executing i
Commit 934659c switched the iotests to run qemu-io from a bash subshell,
in order to catch segfaults. This method is incompatible with the
current valgrind_qemu_io() bash function.
Move the valgrind usage into the exec subshell in _qemu_io_wrapper(),
while making sure the original return value is
Stefan Hajnoczi writes:
> v2:
> * Use find(1) to catch all tracetool *.py files [Lluís]
>Note: I used find -name instead of find -path for better POSIX compliance
Looks great to me.
Thanks,
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the
Hi Drew,
On 10/30/2015 09:00 AM, Andrew Jones wrote:
> On Wed, Oct 28, 2015 at 03:12:55PM -0400, Christopher Covington wrote:
>> Calculate the numbers of cycles per instruction (CPI) implied by ARM
>> PMU cycle counter values. The code includes a strict checking facility
>> intended for the -icoun
This makes the purpose of the function clearer: it is not about the
version of QEMU that's running, but the version string exposed in the
emulated hardware.
Cc: Andrzej Zaborowski
Cc: Peter Maydell
Cc: John Snow
Cc: Paolo Bonzini
Reviewed-by: John Snow
Signed-off-by: Eduardo Habkost
---
hw/
In 2012, QEMU had a bug where it exposed QEMU version information
to the guest, meaning a QEMU upgrade would expose different
hardware to the guest OS even if the same machine-type is being
used.
The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4,
on all machines up to pc-1.0. Bu
In 2012, QEMU had a bug where it exposed QEMU version information to the
guest, meaning a QEMU upgrade would expose different hardware to the
guest OS even if the same machine-type is being used.
The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, on
all machines up to pc-1.0. Bu
Guest visible data shouldn't change with a simple QEMU upgrade, so use
qemu_hw_version() to ensure it won't change (as long as the machine
class being used has hw_version set).
Cc: Hannes Reinecke
Cc: Paolo Bonzini
Cc: qemu-bl...@nongnu.org
Reviewed-by: Hannes Reinecke
Acked-by: Laszlo Ersek
S
Hi Eric,
Thanks for your feedback, I’ve made the updates you suggested.
> Your diff doesn't include the usual '---' separator and diffstat
> provided by 'git send-email'; making it a bit harder to see at a glance
> what your patch touches.
OK, understood. I’ll will use git send-email going forwa
Loaded question in response to
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06988.html, but
posting as a new thread to call attention to it:
Libvirt uses libyajl to parse and format JSON. Would it be worth
dragging in yet another prerequisite library into qemu and reuse
libyajl's parse
On 30 October 2015 at 15:42, Markus Armbruster wrote:
> The following changes since commit fdf927621a99711bf1a81712bce054794f2d44c3:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-10-30'
> into staging (2015-10-30 09:41:15 +)
>
> are available in the git repository
Fix build failure on w32
Signed-off-by: Eric Blake
---
Hopefully, this is the only use of qapi union types hiding
behind #ifdefs (I relied on the compiler to tell me which spots
need conversion, but that doesn't work for spots that aren't
compiled in my setup)
qemu-char.c | 4 ++--
1 file chan
On 10/30/2015 01:47 PM, Peter Maydell wrote:
> On 30 October 2015 at 15:42, Markus Armbruster wrote:
>> char: Convert to new qapi union layout
> Hi; I'm afraid this doesn't build on w32:
>
> /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function
> ‘qmp_chardev_open_file’:
> /home/
> BTW it seems that I made a little stronger claim than it is actually -
> at least 3.18 works fine in all cases, so the issue was fixed a bit
> earlier than in 4.2.
Ok, it turns out that the fix was brought by
commit 447f05bb488bff4282088259b04f47f0f9f76760
Author: Akinobu Mita
Date: Thu Oct
101 - 200 of 240 matches
Mail list logo
