[Qemu-devel] [PATCH v1 3/4] qemu-iotests: s390x: fix test 068

2015-10-30 Thread Bo Tu
Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot loader. If the s390-virtio-ccw machine finds no device to load from and errors out, then emits a panic and exits the vm. This breaks test cases 068 for s390x. Adding the parameter of "-no-shutdown" for s390-ccw-virtio will pau

[Qemu-devel] [PATCH v1 4/4] qemu-iotests: disable VNC server for test 120

2015-10-30 Thread Bo Tu
Ever since qemu-iotest 120 was introduced, its expected output didn't include the output from the built-in VNC server: QA output created by 120 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 QMP_VERSION +VNC server running on `::1:5900' {"return": {}} wrote 65536/65536 bytes at offs

[Qemu-devel] [PATCH v1 2/4] qemu-iotests: s390x: fix test 051

2015-10-30 Thread Bo Tu
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

[Qemu-devel] [PATCH v1 1/4] qemu-iotests: refine common.config

2015-10-30 Thread Bo Tu
Be easier to read, and be slightly shorter. Suggested-By: Sascha Silbe Reviewed-by: Sascha Silbe Signed-off-by: Bo Tu --- tests/qemu-iotests/common.config | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.con

Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

2015-10-30 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 29 Oct 2015 17:23:43 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 29 Oct 2015 12:15:09 +0100 >> > Markus Armbruster wrote: >> > >> >> Leak introduced in commit 8a4f501..710aec9, v2.4.0. >> >> >> >> Signed-off-by: Markus Armbr

Re: [Qemu-devel] [PATCH 4/4] json-streamer: Limit number of tokens in addition to total size

2015-10-30 Thread Markus Armbruster
Eric Blake writes: > On 10/29/2015 12:27 PM, Markus Armbruster wrote: >>> Sounds like we have some quadratic (or worse) scaling in the parser. >>> Worth fixing some day, but I also agree that we don't have to tackle it >>> in this series. >> >> I believe it's linear with a criminally negligent c

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 06:52, Peter Crosthwaite wrote: > Ping^3 > > This has been on list for a very long time without 3rd party review. > Can I send a PULL? I would prefer not to take a new unreviewed feature in softfreeze for 2.5... thanks -- PMM

[Qemu-devel] [PULL v4 00/14] QMP and QObject patches

2015-10-30 Thread Markus Armbruster
The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-29 09:49:52 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-30 for you t

Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches

2015-10-30 Thread Markus Armbruster
Peter Maydell writes: > On 29 October 2015 at 14:32, Markus Armbruster wrote: >> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into >> staging (2015-10-29 09:49:52 +) >> >> are available in th

Re: [Qemu-devel] [PATCH for-2.5] MAINTAINERS: Add new qemu-arm mailing list to ARM related entries

2015-10-30 Thread Shannon Zhao
On 2015/10/29 22:41, Peter Maydell wrote: > We now have a qemu-arm mailing list for ARM patches and discussion, > so add an L: entry for it to the various ARM related entries in > MAINTAINERS. > > Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao > --- > I basically just added an L: ent

Re: [Qemu-devel] [PULL 00/12] Block patches

2015-10-30 Thread Peter Maydell
On 29 October 2015 at 18:09, Stefan Hajnoczi wrote: > The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-29 09:49:52 +) > > are available in the git repository at: > > git://

Re: [Qemu-devel] [PATCH v4] target-mips: fix updating XContext on mmu exception

2015-10-30 Thread Leon Alrae
On 29/10/15 17:17, Yongbok Kim wrote: > Correct updating XContext.Region field on mmu exceptions. > If Config3.CTXTC = 0 then the R field of XContext has to be updated > with the value of bits 63..62 of the virtual address upon a TLB > exception. > Also fixed the below line which overs 80 character

Re: [Qemu-devel] [PATCH 2/2] trace: add make dependencies on tracetool source

2015-10-30 Thread Stefan Hajnoczi
On Thu, Oct 29, 2015 at 04:28:49PM +0100, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > ## > > +# tracetool source files > > +# Every rule that invokes tracetool must depend on this so code is > > regenerated > > +# if trac

[Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies

2015-10-30 Thread Stefan Hajnoczi
v2: * Use find(1) to catch all tracetool *.py files [Lluís] Note: I used find -name instead of find -path for better POSIX compliance Issues with trace/Makefile.objs: 1. Generated code is not recreated when patches modify scripts/tracetool/*.py. Typically such patches also modify trace/*.

[Qemu-devel] [PATCH v2 1/2] trace: fix make foo-timestamp rules

2015-10-30 Thread Stefan Hajnoczi
The Makefile uses intermediate timestamp files to avoid rebuilding if tracetool output is unchanged. Timestamps are implemented incorrectly. This was fixed for rules.mak in commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup config generation rules") but never fixed in trace/Make

[Qemu-devel] [PATCH v2 2/2] trace: add make dependencies on tracetool source

2015-10-30 Thread Stefan Hajnoczi
Patches that change tracetool can break the build if old build output files are lying around. This happens because the Makefile does not specify dependencies on tracetool. The build will use old object files that do not match the current source code. Signed-off-by: Stefan Hajnoczi --- trace/Ma

Re: [Qemu-devel] [PATCH v4 3/3] aio: Introduce aio-epoll.c

2015-10-30 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 12:06:29PM +0800, Fam Zheng wrote: > To comply with aio_{disable,enable}_external, we always use ppoll when > aio_external_disabled() is true. All file descriptors are added to the epoll fd. Does that mean epoll will report the same fds again after we come out of ppoll()/a

Re: [Qemu-devel] [PATCH v6 27/33] nvdimm acpi: support function 0

2015-10-30 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 01:56:21PM +0800, Xiao Guangrong wrote: > static uint64_t > nvdimm_dsm_read(void *opaque, hwaddr addr, unsigned size) > { > -return 0; > +AcpiNVDIMMState *state = opaque; > +MemoryRegion *dsm_ram_mr = &state->ram_mr; > +NvdimmDsmIn *in; > +GArray *out;

Re: [Qemu-devel] [PATCH v6 00/33] implement vNVDIMM

2015-10-30 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 01:55:54PM +0800, Xiao Guangrong wrote: > This patchset can be found at: > https://github.com/xiaogr/qemu.git nvdimm-v6 > > It is based on pci branch on Michael's tree and the top commit is: > commit 6f96a31a06c2a1 (tests: re-enable vhost-user-test). > > Changelog in

Re: [Qemu-devel] [PULL v4 00/14] QMP and QObject patches

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 08:10, Markus Armbruster wrote: > The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-29 09:49:52 +) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

2015-10-30 Thread Gerd Hoffmann
Hi, [ context for spice folks: patch was added to qemu increasing usb-audio default buffer size ] > > What bothers me is that you have no qualms about making latency on > > everyone's system worse. > > How do you know it makes sound on other people's systems worse? If you have > actually do

[Qemu-devel] [PATCH 02/19] buffer: add buffer_init

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven --- include/qemu/buffer.h | 12 util/buffer.c | 11 +++ 2 files changed, 23 insertions(+) diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h index b380cec..0710e16 100644 --- a/include/qemu/buffer.h +++

[Qemu-devel] [PATCH 04/19] buffer: add buffer_move

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven --- include/qemu/buffer.h | 10 ++ util/buffer.c | 16 2 files changed, 26 insertions(+) diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h index f53ee9e..1358df1 100644 --- a/include/qemu/buffer.h +

[Qemu-devel] [PATCH 08/19] vnc: kill jobs queue buffer

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven --- ui/vnc-jobs.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 2e6c15f..329d13e 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -54,7 +54,6 @@ struct VncJobQueue { QemuCond cond; Qe

[Qemu-devel] [PATCH 05/19] buffer: add buffer_shrink

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/buffer.h | 10 ++ util/buffer.c | 20 +++- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h index 1358df1..0a69b3a 100644 --- a/include/qemu/buffer.h +++ b/inc

[Qemu-devel] [PATCH 03/19] buffer: add buffer_move_empty

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Lieven --- include/qemu/buffer.h | 10 ++ util/buffer.c | 14 ++ 2 files changed, 24 insertions(+) diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h index 0710e16..f53ee9e 100644 --- a/include/qemu/buffer.h +++

[Qemu-devel] [PATCH 01/19] buffer: make the Buffer capacity increase in powers of two

2015-10-30 Thread Gerd Hoffmann
From: Peter Lieven This makes sure the number of reallocs is in O(log N). Signed-off-by: Peter Lieven [ rebased to util/buffer.c ] Signed-off-by: Gerd Hoffmann --- util/buffer.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/util/buffer.c b/util/buffer.c index cedd0

[Qemu-devel] [PATCH 14/19] vnc: only alloc server surface with clients connected

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 12 1 file changed, 12 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee1266..c5bef47 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -721,6 +721,10 @@ static void vnc_update_server_surface(VncDisplay *vd) qemu_pixman_image_unref(vd->s

[Qemu-devel] [PATCH 07/19] vnc: attach names to buffers

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc-jobs.c | 3 +++ ui/vnc.c | 20 2 files changed, 23 insertions(+) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 22c9abc..2e6c15f 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -218,6 +218,8 @@ static int vnc_worker_thread_lo

[Qemu-devel] [PATCH 13/19] vnc: use vnc_{width, height} in vnc_set_area_dirty

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 61a8f2c..8ee1266 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -618,8 +618,12 @@ static int vnc_height(VncDisplay *vd) static void vnc_set_a

[Qemu-devel] [PATCH 15/19] vnc: fix local state init

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc-jobs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index fd9ed39..12389cc 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -185,6 +185,9 @@ void vnc_jobs_consume_buffer(VncState *vs) */ stati

[Qemu-devel] [PATCH 10/19] vnc: zap dead code

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 49e8f3a..cb1954c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -722,10 +722,6 @@ static void vnc_dpy_switch(DisplayChangeListener *dcl, w

[Qemu-devel] [PATCH 17/19] buffer: factor out buffer_req_size

2015-10-30 Thread Gerd Hoffmann
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann --- util/buffer.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index ae2907e..31f1d9f 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -24,6 +24,13 @@ #

[Qemu-devel] [PATCH 06/19] buffer: add tracing

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 6 ++ util/buffer.c | 18 ++ 2 files changed, 24 insertions(+) diff --git a/trace-events b/trace-events index bdfe79f..050d45b 100644 --- a/trace-events +++ b/trace-events @@ -1387,6 +1387,12 @@ ppc_tb_adjust(uint64_t offs1, u

[Qemu-devel] [PATCH 18/19] buffer: factor out buffer_adj_size

2015-10-30 Thread Gerd Hoffmann
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann --- util/buffer.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index 31f1d9f..fe5a44e 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -

[Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer

2015-10-30 Thread Gerd Hoffmann
From: Peter Lieven If the vs->output buffer is empty it will be dropped by the next qio_buffer_move_empty in vnc_jobs_consume_buffer anyway. So reuse the allocated buffer from this buffer in the worker thread where we otherwise would start with an empty (unallocated buffer). Signed-off-by: Peter

[Qemu-devel] [PATCH 12/19] vnc: factor out vnc_update_server_surface

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 283b93c..61a8f2c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -714,6 +714,17 @@ void *vnc_server_fb_ptr(VncDisplay *vd, int x, int y) re

[Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling

2015-10-30 Thread Gerd Hoffmann
Hi, This series has a bunch of improvements in the vnc buffer handling, to reduce the memory footprint. Some of the changes are applied to the buffer helper functions which Daniel separated out of the vnc code recently. Most patches have been on the list before, based on a older version of Dan

[Qemu-devel] [PATCH 11/19] vnc: add vnc_width+vnc_height helpers

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index cb1954c..283b93c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -605,6 +605,17 @@ static void framebuffer_update_request(VncState *vs, int incrementa

[Qemu-devel] [PATCH 09/19] vnc-jobs: move buffer reset, use new buffer move

2015-10-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc-jobs.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 329d13e..fd9ed39 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -29,6 +29,7 @@ #include "vnc.h" #include "vnc-jobs.h" #inclu

[Qemu-devel] [PATCH 19/19] buffer: allow a buffer to shrink gracefully

2015-10-30 Thread Gerd Hoffmann
From: Peter Lieven the idea behind this patch is to allow the buffer to shrink, but make this a seldom operation. The buffers average size is measured exponentionally smoothed with am alpha of 1/128. Signed-off-by: Peter Lieven Signed-off-by: Gerd Hoffmann --- include/qemu/buffer.h | 1 + ut

Re: [Qemu-devel] [PATCH v2 0/4] ui audio qxl usb: Use g_new() & friends where that makes obvious sense

2015-10-30 Thread Gerd Hoffmann
On Do, 2015-10-29 at 16:55 +0100, Markus Armbruster wrote: > v2: > * Trivially rebased > > Markus Armbruster (4): > ui: Use g_new() & friends where that makes obvious sense > audio: Use g_new() & friends where that makes obvious sense > qxl: Use g_new() & friends where that makes obvious sen

Re: [Qemu-devel] [PATCH v8 04/17] qapi-introspect: Guarantee particular sorting

2015-10-30 Thread Markus Armbruster
For now, only high-level review. The main cost of sorting is interface complexity: we need to specify which things are sorted, and what the sorting order is (see your TODO below). Once we've done so, we can't go back. There's also implementation complexity, but your patch shows it's low enough t

Re: [Qemu-devel] [PATCH v2 0/4] ui audio qxl usb: Use g_new() & friends where that makes obvious sense

2015-10-30 Thread Gerd Hoffmann
On Fr, 2015-10-30 at 12:13 +0100, Gerd Hoffmann wrote: > Do you want me pick this up or send a pull request yourself? Oh, I see you have trivial cc'ed. scratch the question then ;)

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-30 Thread James Hogan
On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote: > Hi Yongbok, > > On Tue, Oct 27, 2015 at 05:12:35PM +, Yongbok Kim wrote: > > Add part of GCR Block which Linux Kernel utilises and it is enough > > to bring the GIC up. > > It defines full 32 Kbytes address space allocated for GCR

Re: [Qemu-devel] [PATCH 01/19] buffer: make the Buffer capacity increase in powers of two

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:09:56PM +0100, Gerd Hoffmann wrote: > From: Peter Lieven > > This makes sure the number of reallocs is in O(log N). > > Signed-off-by: Peter Lieven > > [ rebased to util/buffer.c ] > > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Regards, Daniel

Re: [Qemu-devel] [PATCH for-2.5 v2 2/4] mips: add Global Config Register block (part)

2015-10-30 Thread Peter Maydell
On 30 October 2015 at 11:40, James Hogan wrote: > On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote: >> Hi Yongbok, >> >> > +case GCR_GIC_BASE_OFS: >> > +return gcr->gic_base; > > Note also, that this is a read-write register. It starts undefined and > the kernel will write t

Re: [Qemu-devel] [PATCH 02/19] buffer: add buffer_init

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:09:57PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Peter Lieven > --- > include/qemu/buffer.h | 12 > util/buffer.c | 11 +++ > 2 files changed, 23 insertions(+) Reviewed-by: Daniel P. Berrange Regards, Da

Re: [Qemu-devel] [PATCH 03/19] buffer: add buffer_move_empty

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:09:58PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Peter Lieven > --- > include/qemu/buffer.h | 10 ++ > util/buffer.c | 14 ++ > 2 files changed, 24 insertions(+) > > diff --git a/include/qemu/buffer.h b/incl

Re: [Qemu-devel] [PATCH 04/19] buffer: add buffer_move

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:09:59PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Peter Lieven > --- > include/qemu/buffer.h | 10 ++ > util/buffer.c | 16 > 2 files changed, 26 insertions(+) Reviewed-by: Daniel P. Berrange Regards,

Re: [Qemu-devel] [PATCH 05/19] buffer: add buffer_shrink

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:00PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > include/qemu/buffer.h | 10 ++ > util/buffer.c | 20 +++- > 2 files changed, 29 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange Regards, Daniel --

Re: [Qemu-devel] [PATCH 06/19] buffer: add tracing

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:01PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > trace-events | 6 ++ > util/buffer.c | 18 ++ > 2 files changed, 24 insertions(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-

Re: [Qemu-devel] [PATCH 07/19] vnc: attach names to buffers

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:02PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-jobs.c | 3 +++ > ui/vnc.c | 20 > 2 files changed, 23 insertions(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-ht

Re: [Qemu-devel] [PATCH 08/19] vnc: kill jobs queue buffer

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:03PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Peter Lieven > --- > ui/vnc-jobs.c | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr

Re: [Qemu-devel] [PATCH 09/19] vnc-jobs: move buffer reset, use new buffer move

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:04PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-jobs.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.c

Re: [Qemu-devel] [PATCH 10/19] vnc: zap dead code

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:05PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://

Re: [Qemu-devel] [PATCH 11/19] vnc: add vnc_width+vnc_height helpers

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:06PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com

Re: [Qemu-devel] [PATCH 12/19] vnc: factor out vnc_update_server_surface

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:07PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flic

Re: [Qemu-devel] [PATCH 13/19] vnc: use vnc_{width, height} in vnc_set_area_dirty

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:08PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flic

Re: [Qemu-devel] [PATCH 14/19] vnc: only alloc server surface with clients connected

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:09PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [Qemu-devel] [PATCH 15/19] vnc: fix local state init

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:10PM +0100, Gerd Hoffmann wrote: It isn't entirely obvious what bug is being fixed here, perhaps a little more info in the commit message would help. > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-jobs.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-

Re: [Qemu-devel] [PATCH 16/19] vnc: recycle empty vs->output buffer

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:11PM +0100, Gerd Hoffmann wrote: > From: Peter Lieven > > If the vs->output buffer is empty it will be dropped > by the next qio_buffer_move_empty in vnc_jobs_consume_buffer > anyway. So reuse the allocated buffer from this buffer > in the worker thread where we othe

Re: [Qemu-devel] [PATCH 17/19] buffer: factor out buffer_req_size

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:12PM +0100, Gerd Hoffmann wrote: > From: Peter Lieven > > Signed-off-by: Peter Lieven > Signed-off-by: Gerd Hoffmann > --- > util/buffer.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |:

Re: [Qemu-devel] [PATCH 18/19] buffer: factor out buffer_adj_size

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:13PM +0100, Gerd Hoffmann wrote: > From: Peter Lieven > > Signed-off-by: Peter Lieven > Signed-off-by: Gerd Hoffmann > --- > util/buffer.c | 25 ++--- > 1 file changed, 10 insertions(+), 15 deletions(-) Reviewed-by: Daniel P. Berrange Regard

Re: [Qemu-devel] [PATCH 19/19] buffer: allow a buffer to shrink gracefully

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:10:14PM +0100, Gerd Hoffmann wrote: > From: Peter Lieven > > the idea behind this patch is to allow the buffer to shrink, but > make this a seldom operation. The buffers average size is measured > exponentionally smoothed with am alpha of 1/128. s/am/an/ > > Signed-o

Re: [Qemu-devel] [PATCH 03/19] buffer: add buffer_move_empty

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 09:11:01PM +0900, Daniel P. Berrange wrote: > On Fri, Oct 30, 2015 at 12:09:58PM +0100, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Peter Lieven > > --- > > include/qemu/buffer.h | 10 ++ > > util/buffer.c | 14 ++ > >

Re: [Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling

2015-10-30 Thread Daniel P. Berrange
On Fri, Oct 30, 2015 at 12:09:55PM +0100, Gerd Hoffmann wrote: > Hi, > > This series has a bunch of improvements in the vnc buffer handling, > to reduce the memory footprint. Some of the changes are applied to > the buffer helper functions which Daniel separated out of the vnc code > recently.

Re: [Qemu-devel] [PATCH v8 04/54] Move configuration section writing

2015-10-30 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Tue) 29 Sep 2015 [09:37:28], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The vmstate_configuration is currently written > > in 'qemu_savevm_state_begin', move it to > > 'qemu_savevm_state_header' since it's got a h

Re: [Qemu-devel] [PATCH v8 05/17] qapi: Track simple union tag in object.local_members

2015-10-30 Thread Markus Armbruster
Eric Blake writes: > We were previously creating all unions with an empty list for > local_members. However, it will make it easier to unify struct > and union generation if we include the generated tag member in > local_members. That way, we can have a common code pattern: > visit the base (if

Re: [Qemu-devel] [PATCH v8 42/54] Postcopy: Use helpers to map pages during migration

2015-10-30 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > In postcopy, the destination guest is running at the same time > > as it's receiving pages; as we receive new pages we must put > > them into the guests address space at

Re: [Qemu-devel] [kvm-unit-tests PATCHv5 3/3] arm: pmu: Add CPI checking

2015-10-30 Thread Andrew Jones
On Wed, Oct 28, 2015 at 03:12:55PM -0400, Christopher Covington wrote: > Calculate the numbers of cycles per instruction (CPI) implied by ARM > PMU cycle counter values. The code includes a strict checking facility > intended for the -icount option in TCG mode but it is not yet enabled > in the con

Re: [Qemu-devel] [PATCH v8 06/17] qapi-types: Consolidate gen_struct() and gen_union()

2015-10-30 Thread Markus Armbruster
Eric Blake writes: > These two methods are now close enough that we can finally merge > them, relying on the fact that simple unions now provide a > reasonable local_members. Change gen_struct() to gen_object() > that handles all forms of QAPISchemaObjectType, and rename and > shrink gen_union()

Re: [Qemu-devel] RAM backend and guest ABI (was Re: [PATCH v2] pc: memhp: enforce minimal 128Mb) alignment for pc-dimm

2015-10-30 Thread Igor Mammedov
On Thu, 29 Oct 2015 16:16:57 -0200 Eduardo Habkost wrote: > (CCing Michal and libvir-list, so libvirt team is aware of this > restriction) > > On Thu, Oct 29, 2015 at 02:36:37PM +0100, Igor Mammedov wrote: > > On Tue, 27 Oct 2015 14:36:35 -0200 > > Eduardo Habkost wrote: > > > > > On Tue, Oct

Re: [Qemu-devel] [PATCH v6 27/33] nvdimm acpi: support function 0

2015-10-30 Thread Xiao Guangrong
On 10/30/2015 06:14 PM, Stefan Hajnoczi wrote: On Fri, Oct 30, 2015 at 01:56:21PM +0800, Xiao Guangrong wrote: static uint64_t nvdimm_dsm_read(void *opaque, hwaddr addr, unsigned size) { -return 0; +AcpiNVDIMMState *state = opaque; +MemoryRegion *dsm_ram_mr = &state->ram_mr;

Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size()

2015-10-30 Thread Vladimir Sementsov-Ogievskiy
logic is changed: in old version gethugepagesize on statfs error generates exit(1) in new it returns getpagesize() in this case (through fd_getpagesize) (I think, fd_getpagesize should be fixed to handle error) also, in new version for windows we have getpagesize(), when in old version t

Re: [Qemu-devel] [PATCH v2 07/16] vl.c: Use "%s support disabled" error messages consistently

2015-10-30 Thread Andrew Jones
On Thu, Oct 29, 2015 at 05:59:13PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Signed-off-by: Eduardo Habkost > > --- > > vl.c | 34 -- > > 1 file changed, 16 insertions(+), 18 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index d417dd9..f

Re: [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning

2015-10-30 Thread Andrew Jones
On Thu, Oct 29, 2015 at 06:10:17PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Signed-off-by: Eduardo Habkost > > --- > > vl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index af8d09c..67147e0 100644 > > --- a/vl.c > >

[Qemu-devel] [PULL 01/05] seccomp: add cacheflush to whitelist

2015-10-30 Thread Eduardo Otubo
From: Andrew Jones cacheflush is an arm-specific syscall that qemu built for arm uses. Add it to the whitelist. Signed-off-by: Andrew Jones Acked-by: Eduardo Otubo --- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index f9

[Qemu-devel] [PULL 00/05] seccomp branch queue

2015-10-30 Thread Eduardo Otubo
The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100) are available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccom

[Qemu-devel] [PULL 05/05] seccomp: loosen library version dependency

2015-10-30 Thread Eduardo Otubo
From: dann frazier Drop the libseccomp required version back to 2.1.0, restoring the ability to build w/ --enable-seccomp on Ubuntu 14.04. Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency on libseccomp from version 2.1.0 to 2.1.1. This broke building on Ubuntu 14.04, the

[Qemu-devel] [PULL 03/05] seccomp: add madvise, shmget, and shmctl to whitelist

2015-10-30 Thread Eduardo Otubo
From: Namsun Ch'o This patch introduces madvise, shmget, shmctl and its flags to the seccomp whitelist. This prevents Qemu to break in case of using -runas or chroot with sandbox enabled. Signed-off-by: Namsun Ch'o Acked-by: Eduardo Otubo --- Changelog: v1 - Created argument filters for the m

[Qemu-devel] [PULL 02/05] configure: arm/aarch64: allow enable-seccomp

2015-10-30 Thread Eduardo Otubo
From: Andrew Jones This is a revert of ae6e8ef11e6cb, but with a bit of refactoring, and also specifically adding arm/aarch64, rather than all architectures. Currently, libseccomp code appears to also support mips, ppc, and s390. We could therefore allow qemu to enable seccomp for those platforms

[Qemu-devel] [PULL 04/05] seccomp: add setuid, setgid, chroot and setgroups to whitelist

2015-10-30 Thread Eduardo Otubo
From: Namsun Ch'o The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are needed for -runas to work. It also doesn't whitelist chroot, which is needed for the -chroot option. Unfortunately, QEMU enables seccomp before it drops privileges or chroots, so without these whitelis

Re: [Qemu-devel] [PATCH v6 08/33] exec: allow memory to be allocated from any kind of path

2015-10-30 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: Currently file_ram_alloc() is designed for hugetlbfs, however, the memory of nvdimm can come from either raw pmem device eg, /dev/pmem, or the file locates at DAX enabled filesystem So this patch let it work on any kind of path Signed-off-by: Xiao Guan

[Qemu-devel] [Bug 1511710] [NEW] unknown option --disable-modules

2015-10-30 Thread Guy
Public bug reported: MSYS64, Windows 7 x64 $ ./configure --target-list=i386-softmmu --static --prefix=/d/qemu/ --disable-system --disable-user --disable-linux-user --disable-bsd-user --disable-guest-base --disable-docs --disable-guest-agent --disable-guest-agent-msi --disable-pie --disable-mod

Re: [Qemu-devel] [PATCH v2 0/4] ui audio qxl usb: Use g_new() & friends where that makes obvious sense

2015-10-30 Thread Markus Armbruster
Gerd Hoffmann writes: > On Do, 2015-10-29 at 16:55 +0100, Markus Armbruster wrote: >> v2: >> * Trivially rebased >> >> Markus Armbruster (4): >> ui: Use g_new() & friends where that makes obvious sense >> audio: Use g_new() & friends where that makes obvious sense >> qxl: Use g_new() & fri

Re: [Qemu-devel] [PULL 00/12] Block patches

2015-10-30 Thread Markus Armbruster
Peter Maydell writes: > On 29 October 2015 at 18:09, Stefan Hajnoczi wrote: >> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into >> staging (2015-10-29 09:49:52 +) >> >> are available in the

Re: [Qemu-devel] [PATCH v6 09/33] exec: allow file_ram_alloc to work on file

2015-10-30 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: Currently, file_ram_alloc() only works on directory - it creates a file under @path and do mmap on it This patch tries to allow it to work on file directly, if @path is a directory it works as before, otherwise it treats @path as the target file then di

Re: [Qemu-devel] [PATCH v6 10/33] hostmem-file: clean up memory allocation

2015-10-30 Thread Vladimir Sementsov-Ogievskiy
On 30.10.2015 08:56, Xiao Guangrong wrote: - hostmem-file.c is compiled only if CONFIG_LINUX is enabled so that is unnecessary to do the same check in the source file - the interface, HostMemoryBackendClass->alloc(), is not called many times, do not need to check if the memory-region is in

[Qemu-devel] [PULL 0/9] target-mips queue

2015-10-30 Thread Leon Alrae
7; into staging (2015-10-29 09:49:52 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20151030 for you to fetch changes up to 60270f85cc93d2d34e45b7679c374b1d771f0eeb: target-mips: fix updating XContext on mmu exception (2015-10-30

[Qemu-devel] [PULL 1/9] target-mips: move the test for enabled interrupts to a separate function

2015-10-30 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/cpu.c| 4 +++- target-mips/cpu.h| 29 +++-- target-mips/helper.c | 3 ++- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/target-mips/cpu.c b/target-mips/cpu.c index 37880d2..bbfee45 100644 --- a/target-m

[Qemu-devel] [PULL 9/9] target-mips: fix updating XContext on mmu exception

2015-10-30 Thread Leon Alrae
From: Yongbok Kim Correct updating XContext.Region field on mmu exceptions. If Config3.CTXTC = 0 then the R field of XContext has to be updated with the value of bits 63..62 of the virtual address upon a TLB exception. Also fixed the below line which overs 80 characters. Signed-off-by: Yongbok K

[Qemu-devel] [PULL 2/9] target-mips: implement the CPU wake-up on non-enabled interrupts in R6

2015-10-30 Thread Leon Alrae
In Release 6, the behaviour of WAIT has been modified to make it a requirement that a processor that has disabled operation as a result of executing a WAIT will resume operation on arrival of an interrupt even if interrupts are not enabled. Signed-off-by: Leon Alrae --- target-mips/cpu.c | 7 +++

[Qemu-devel] [PULL 6/9] target-mips: add PC, XNP reg numbers to RDHWR

2015-10-30 Thread Leon Alrae
From: Yongbok Kim Add Performance Counter (4) and XNP (5) register numbers to RDHWR. Add check_hwrena() to simplify access control checkings. Add RDHWR support to microMIPS R6. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Signed-off-by: Leon Alrae --- target-mips/cpu.h | 1 + ta

[Qemu-devel] [PULL 5/9] hw/mips_malta: Fix KVM PC initialisation

2015-10-30 Thread Leon Alrae
From: James Hogan Commit 71c199c81d29 ("mips_malta: provide ememsize env variable to kernels") changed the meaning of loaderparams.ram_size to be the whole of RAM rather than just the low part below where the boot code is placed for KVM, but it didn't update the PC initialisation for KVM to use r

[Qemu-devel] [PULL 7/9] target-mips: Set Config5.XNP for R6 cores

2015-10-30 Thread Leon Alrae
From: Yongbok Kim Set Config5.XNP for R6 cores to indicate the extended LL/SC family of instructions NOT present. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Signed-off-by: Leon Alrae --- target-mips/translate_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PULL 3/9] target-mips: update writing to CP0.Status.KX/SX/UX in MIPS Release R6

2015-10-30 Thread Leon Alrae
Implement the relationship between CP0.Status.KX, SX and UX. It should not be possible to set UX bit if SX is 0, the same applies for setting SX if KX is 0. Signed-off-by: Leon Alrae --- target-mips/cpu.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target-mips/cpu.h

[Qemu-devel] [PULL 8/9] target-mips: add SIGRIE instruction

2015-10-30 Thread Leon Alrae
From: Yongbok Kim Add SIGRIE (Signal Reserved Instruction Exception) for both MIPS and microMIPS. The instruction allows to use the 16-bit code field for software use. This instruction is introduced by and required as of Release 6. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Signed-off-

[Qemu-devel] [PULL 4/9] target-mips: Add enum for BREAK32

2015-10-30 Thread Leon Alrae
From: Yongbok Kim Add enum for BREAK32 Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Reviewed-by: Aurelien Jarno Signed-off-by: Leon Alrae --- target-mips/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.c

[Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

2015-10-30 Thread Eduardo Habkost
Changes v2 -> v3: * Removed patch: "vl.c: Convert error sentences to simpler phrases" * Removed patch: "vl.c: Reword -machine help error messages" * Removed patch: "vl.c: Reword fw_cfg name prefix warning" * Removed patch: "vl.c: Use US spelling for 'unrecognized'" * New patch: "vl.c: Change 'fail

  1   2   3   >