[Qemu-devel] [PATCH v11 14/24] tests: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 20/24] memory: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 09/24] qapi: Prefer typesafe upcasts to qapi base classes

2015-10-26 Thread Eric Blake
A previous patch (commit 1e6c1616) made it possible to directly cast from a qapi flat union type to its base type. However, it requires the use of a C cast, which turns off compiler type-safety checks. Add inline type-safe wrappers named qapi_FOO_base() for any union type FOO that has a base, whic

[Qemu-devel] [PATCH v11 23/24] qapi: Reserve 'u' member name

2015-10-26 Thread Eric Blake
Now that we have separated union tag values from colliding with non-variant C names, by naming the union 'u', we should reserve this name for our use. Note that we want to forbid 'u' even in a struct with no variants, because it is possible for a future qemu release to extend QMP in a backwards-co

[Qemu-devel] [PATCH v11 11/24] qapi-visit: Remove redundant functions for flat union base

2015-10-26 Thread Eric Blake
The code for visiting the base class of a child struct created visit_type_Base_fields() which covers all fields of Base; while the code for visiting the base class of a flat union created visit_type_Union_fields() covering all fields of the base except the discriminator. But since the base class i

[Qemu-devel] [PATCH v11 21/24] tpm: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 16/24] sockets: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 05/24] qapi: Reserve 'q_*' and 'has_*' member names

2015-10-26 Thread Eric Blake
c_name() produces names starting with 'q_' when protecting a QMP member name that would fail to directly compile, but in doing so can cause clashes with any QMP name already beginning with 'q-' or 'q_'. Likewise, we create a C name 'has_' for any optional member, that can clash with any QMP name b

[Qemu-devel] [PATCH v11 10/24] qapi: Unbox base members

2015-10-26 Thread Eric Blake
Rather than storing a base class as a pointer to a box, just store the fields of that base class in the same order, so that a child struct can be directly cast to its parent. This gives less malloc overhead, less pointer dereferencing, and even less generated code. Compare to the earlier commit 1

[Qemu-devel] [PATCH v11 19/24] input: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 17/24] net: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 24/24] qapi: Simplify gen_struct_field()

2015-10-26 Thread Eric Blake
Rather than having all callers pass a name, type, and optional flag, have them instead pass a QAPISchemaObjectTypeMember which already has all that information. No change to generated code. Signed-off-by: Eric Blake --- v11: rebase to earlier changes v10: no change v9: rebase after kind/base cl

[Qemu-devel] [PATCH v11 18/24] char: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

[Qemu-devel] [PATCH v11 15/24] block: Convert to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

Re: [Qemu-devel] [PATCH 1/3] qemu-io: fix cvtnum lval types

2015-10-26 Thread Eric Blake
On 10/26/2015 04:06 PM, John Snow wrote: > cvtnum() returns int64_t: we should not be storing this > result inside of an int. > > In a few cases, we need an extra sprinkling of error handling > where we expect to pass this number on towards a function that > expects something smaller than int64_t.

[Qemu-devel] [PATCH v11 22/24] qapi: Finish converting to new qapi union layout

2015-10-26 Thread Eric Blake
We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This le

Re: [Qemu-devel] [Qemu-block] [PATCH 2/3] qemu-io: Check for trailing chars

2015-10-26 Thread Eric Blake
On 10/26/2015 04:44 PM, Eric Blake wrote: > On 10/26/2015 04:06 PM, John Snow wrote: >> Make sure there's not trailing garbage, e.g. >> "64k-whatever-i-want-here" >> >> Reported-by: Max Reitz >> Signed-off-by: John Snow >> --- >> qemu-io-cmds.c | 9 - >> 1 file changed, 8 insertions(+),

Re: [Qemu-devel] [PATCH 2/3] qemu-io: Check for trailing chars

2015-10-26 Thread Eric Blake
On 10/26/2015 04:06 PM, John Snow wrote: > Make sure there's not trailing garbage, e.g. > "64k-whatever-i-want-here" > > Reported-by: Max Reitz > Signed-off-by: John Snow > --- > qemu-io-cmds.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/qemu-io-cmds.c b/q

Re: [Qemu-devel] [PATCH 1/3] qemu-io: fix cvtnum lval types

2015-10-26 Thread Eric Blake
On 10/26/2015 04:40 PM, Eric Blake wrote: > On 10/26/2015 04:06 PM, John Snow wrote: >> cvtnum() returns int64_t: we should not be storing this >> result inside of an int. >> >> In a few cases, we need an extra sprinkling of error handling >> where we expect to pass this number on towards a functio

Re: [Qemu-devel] [PATCH 3/3] qemu-io: Correct error messages

2015-10-26 Thread John Snow
On 10/26/2015 06:54 PM, Eric Blake wrote: > On 10/26/2015 04:06 PM, John Snow wrote: >> Signed-off-by: John Snow >> --- >> qemu-io-cmds.c | 58 >> +- >> 1 file changed, 37 insertions(+), 21 deletions(-) >> >> diff --git a/qemu-io-cmds.c b

Re: [Qemu-devel] [PATCH 3/3] qemu-io: Correct error messages

2015-10-26 Thread Eric Blake
On 10/26/2015 04:06 PM, John Snow wrote: > Signed-off-by: John Snow > --- > qemu-io-cmds.c | 58 > +- > 1 file changed, 37 insertions(+), 21 deletions(-) > > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index e2477fc..92c6b87 100644 > --

[Qemu-devel] [PATCH] ide: remove hardcoded 2GiB transactional limit

2015-10-26 Thread John Snow
Not that you can request a >2GiB transaction, but that's why checking for it makes no sense anymore. With the newer 'limit' parameter to prepare_buf, we no longer need a static limit. The maximum limit is still 2GiB, but the limit parameter is set to the current transaction size, which cannot surp

[Qemu-devel] [PATCH v2 2/3] qemu-io: Check for trailing chars

2015-10-26 Thread John Snow
Make sure there's not trailing garbage, e.g. "64k-whatever-i-want-here" Reported-by: Max Reitz Signed-off-by: John Snow Reviewed-by: Eric Blake --- qemu-io-cmds.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 704db89..44d24e8

[Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-26 Thread John Snow
Reported-by: Max Reitz Signed-off-by: John Snow Reviewed-by: Eric Blake --- qemu-io-cmds.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 44d24e8..92c6b87 100644 --- a/qemu-io-cmds

[Qemu-devel] [PATCH v2 1/3] qemu-io: fix cvtnum lval types

2015-10-26 Thread John Snow
cvtnum() returns int64_t: we should not be storing this result inside of an int. In a few cases, we need an extra sprinkling of error handling where we expect to pass this number on towards a function that expects something smaller than int64_t. Reported-by: Max Reitz Signed-off-by: John Snow R

[Qemu-devel] [PATCH v2 0/3] qemu-io: clean up cvtnum usage

2015-10-26 Thread John Snow
cvtnum returns an int64_t, not an int, so correct the lvalue types wherever it is used. While we're at it, make the error messages more meaningful and hopefully less confusing. v2: - Squashed NSIG error-checking from patch 3 into patch 1 - Reported-by credits for Max and Reviewed-by from Eric ad

Re: [Qemu-devel] [PATCH v2 5/5] xlnx-ep108: Connect the SPI Flash

2015-10-26 Thread Alistair Francis
On Wed, Oct 14, 2015 at 12:25 PM, Peter Crosthwaite wrote: > On Thu, Oct 8, 2015 at 4:30 PM, Alistair Francis > wrote: >> On Wed, Oct 7, 2015 at 5:01 PM, Peter Crosthwaite >> wrote: >>> On Wed, Oct 7, 2015 at 2:34 PM, Alistair Francis >>> wrote: Connect the sst25wf080 SPI flash to the EP10

Re: [Qemu-devel] [PATCH v2 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-10-26 Thread haozhong . zhang
On Mon, Oct 26, 2015 at 04:41:22PM -0200, Eduardo Habkost wrote: > On Mon, Oct 26, 2015 at 10:09:13AM +0800, haozhong.zh...@intel.com wrote: > > On Fri, Oct 23, 2015 at 12:45:13PM -0200, Eduardo Habkost wrote: > > > On Fri, Oct 23, 2015 at 10:27:27AM +0800, Haozhong Zhang wrote: > > > > On Thu, Oct

Re: [Qemu-devel] 4k seq read splitting for virtio-blk - possible workarounds?

2015-10-26 Thread Fam Zheng
On Mon, 10/26 18:32, Paolo Bonzini wrote: > Having a "real" multiqueue model in the host (real = one I/O thread and > one AIO context per guest queue, with each I/O thread able to service > multiple disks; rather than a "fake" multiqueue where you still have one > I/O thread and AIO context per gue

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages

2015-10-26 Thread Eric Blake
On 10/26/2015 05:45 PM, John Snow wrote: > Reported-by: Max Reitz > Signed-off-by: John Snow > Reviewed-by: Eric Blake > --- > qemu-io-cmds.c | 53 ++--- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git a/qemu-io-cmds.c b/qemu-i

Re: [Qemu-devel] [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

2015-10-26 Thread Wen Congyang
On 10/16/2015 07:37 PM, Stefan Hajnoczi wrote: > On Fri, Oct 16, 2015 at 10:22:05AM +0800, Wen Congyang wrote: >> On 10/15/2015 10:55 PM, Stefan Hajnoczi wrote: >>> On Thu, Oct 15, 2015 at 10:19:17AM +0800, Wen Congyang wrote: On 10/14/2015 10:27 PM, Stefan Hajnoczi wrote: > On Tue, Oct 13

Re: [Qemu-devel] [PATCH] linux-user: manage SOCK_PACKET socket type.

2015-10-26 Thread Laurent Vivier
Le 26/10/2015 15:40, Peter Maydell a écrit : > On 6 October 2015 at 18:11, Laurent Vivier wrote: >> This is obsolete, but if we want to use dhcp with some distros (like debian >> ppc 8.2 jessie), we need it. >> >> At the bind level, we are not able to know the socket type so we try to >> guess i

[Qemu-devel] [PATCH v1 4/4] arm: allwinner-a10: Add SATA

2015-10-26 Thread Peter Crosthwaite
Add the Allwinner A10 AHCI controller module to the SoC. Signed-off-by: Peter Crosthwaite --- hw/arm/allwinner-a10.c | 11 +++ include/hw/arm/allwinner-a10.h | 4 2 files changed, 15 insertions(+) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index 43dc0a1.

[Qemu-devel] [PATCH v1 3/4] ahci: Add allwinner AHCI

2015-10-26 Thread Peter Crosthwaite
Add a Sysbus AHCI subclass for the Allwinner AHCI. It has a few extra vendor specific registers which are used for phy and power init. Signed-off-by: Peter Crosthwaite --- Changed since RFC: Dropped un-needed macros (Beniamino) Fixed VMSD section name (Beniamino) Fixed commit message grammar. Mov

[Qemu-devel] [PATCH v1 2/4] ahci: split realize and init

2015-10-26 Thread Peter Crosthwaite
Do the init level tasks asap and the realize later (mainly when num_ports is available). This allows sub-class realize routines to work with the device post-init. Signed-off-by: Peter Crosthwaite --- hw/ide/ahci.c | 36 +++- hw/ide/ahci.h | 3 ++- hw/ide/ich.c

[Qemu-devel] [PATCH v1 0/4] AHCI patches + Allwinner SATA

2015-10-26 Thread Peter Crosthwaite
This patch series adds bare-minimum Allwinner SATA support. P1 is a trivial to help debug AHCI. Changed since RFC: Addressed Beniamino review. Rebased to avoid bad deps (John Snow review) Regards, Peter Peter Crosthwaite (4): ahci: Add some MMIO debug printfs ahci: split realize and init

[Qemu-devel] [PATCH v1 1/4] ahci: Add some MMIO debug printfs

2015-10-26 Thread Peter Crosthwaite
These are useful for bringup of AHCI. Signed-off-by: Peter Crosthwaite --- hw/ide/ahci.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 21f76ed..ed74253 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -378,17 +378

[Qemu-devel] [PULL 01/10] net: cadence_gem: Set initial MAC address

2015-10-26 Thread Jason Wang
From: Sebastian Huber Set initial MAC address to the one specified by the command line. Signed-off-by: Sebastian Huber Reviewed-by: Jason Wang Reviewed-by: Peter Crosthwaite Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/net/c

[Qemu-devel] [PULL 00/10] Net patches

2015-10-26 Thread Jason Wang
The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into staging (2015-10-26 13:13:38 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request fo

[Qemu-devel] [PULL 04/10] net/dump: Separate the NetClientState from the DumpState

2015-10-26 Thread Jason Wang
From: Thomas Huth With the upcoming dumping-via-netfilter patch, the DumpState should not be related to NetClientState anymore, so move the related information to a new struct called DumpNetClient. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c

[Qemu-devel] [PULL 06/10] options: Add documentation for filter-dump

2015-10-26 Thread Jason Wang
From: Thomas Huth Add a short description for the filter-dump command line options. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-options.hx | 8 1 file changed, 8 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index edee5f4..949db7f 100644 --- a/qemu-o

[Qemu-devel] [PULL 02/10] net/dump: Add support for receive_iov function

2015-10-26 Thread Jason Wang
From: Thomas Huth Adding a proper receive_iov function to the net dump module. This will make it easier to support the dump filter feature for the -netdev option in later patches. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c | 24

[Qemu-devel] [PULL 10/10] net: free the string returned by object_get_canonical_path_component

2015-10-26 Thread Jason Wang
From: Yang Hongyang The value returned from object_get_canonical_path_component must be freed. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c

[Qemu-devel] [PULL 09/10] net: make iov_to_buf take right size argument in nc_sendv_compat()

2015-10-26 Thread Jason Wang
From: Yang Hongyang We want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a pointer, which is wrong. Thanks to Paolo for pointing it out. Signed-off-by: Yang Hongyang Cc: Jason Wang Cc: Paolo Bonzini Signed-off-by: Jason Wang --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 05/10] net/dump: Provide the dumping facility as a net-filter

2015-10-26 Thread Jason Wang
From: Thomas Huth Use the net-filter infrastructure to provide the dumping functions for netdev devices, too. Reviewed-by: Yang Hongyang Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/dump.c | 129 - vl.c | 7 +

[Qemu-devel] [PULL 03/10] net/dump: Rework net-dump init functions

2015-10-26 Thread Jason Wang
From: Thomas Huth Move the creation of the dump client from net_dump_init() into net_init_dump(), so we can later use the former function for dump via netfilter, too. Also rename net_dump_init() to net_dump_state_init() to make it easier distinguishable from net_init_dump(). Reviewed-by: Yang Ho

[Qemu-devel] [PULL 08/10] net: Remove duplicate data from query-rx-filter on multiqueue net devices

2015-10-26 Thread Jason Wang
From: Vladislav Yasevich When responding to a query-rx-filter command on a multiqueue netdev, qemu reports the data for each queue. The data, however, is not per-queue, but per device and the same data is reported multiple times. This causes confusion and may also cause extra unnecessary proces

[Qemu-devel] [PULL 07/10] vmxnet3: Do not fill stats if device is inactive

2015-10-26 Thread Jason Wang
From: Shmulik Ladkani Guest OS may issue VMXNET3_CMD_GET_STATS even before device was activated (for example in linux, after insmod but prior net-dev open). Accessing shared descriptors prior device activation is illegal as the VMXNET3State structures have not been fully initialized. As a resul

Re: [Qemu-devel] [Qemu-block] Dynamic reconfiguration

2015-10-26 Thread Markus Armbruster
Wen Congyang writes: > On 10/21/2015 04:27 PM, Markus Armbruster wrote: [...] >> Can we phrase the operation differently? Instead of "insert between A >> and B (silently replacing everything that is now between A and B)", >> say one of >> >> 1a. Replace node A by A <- blkdebug >> >> 1b. Replac

Re: [Qemu-devel] [Qemu-block] Dynamic reconfiguration

2015-10-26 Thread Wen Congyang
On 10/26/2015 03:24 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 10/21/2015 04:27 PM, Markus Armbruster wrote: > [...] >>> Can we phrase the operation differently? Instead of "insert between A >>> and B (silently replacing everything that is now between A and B)", >>> say one of >

Re: [Qemu-devel] [PATCH v10 09/25] qapi: Prefer typesafe upcasts to qapi base classes

2015-10-26 Thread Markus Armbruster
Eric Blake writes: > On 10/23/2015 09:30 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> A previous patch (commit 1e6c1616) made it possible to >>> directly cast from a qapi type to its base type. A future >>> patch will do likewise for structs. However, it requires >>> the client co

Re: [Qemu-devel] [RFC PATCH v3 1/4] hw/intc/arm_gicv3_common: Add state information

2015-10-26 Thread Pavel Fedin
Hello! I skipped many of comments because they are straightforward to address, decided to discuss only important ones. > So we're going to (potentially) emulate: > * non-system-register config > * non-affinity-routing config > > ? OK, but are we really sure we want to do that? Legacy config

[Qemu-devel] [PATCH v2] target-arm: Extract some external ARM CPU API

2015-10-26 Thread Pavel Fedin
Includes, which reside in target-arm, are very problematic to use from code which is considered target-independent by the build system (for example, hw/intc/something.c). It happens because they depend on config-target.h, which is unreachable in this case. This creates problems for example for GICv

Re: [Qemu-devel] [RFC PATCH v3 3/4] hw/intc/arm_gicv3_kvm: Implement get/put functions

2015-10-26 Thread Pavel Fedin
Hello! > > +reg = c->pendbaser & (GICR_PENDBASER_OUTER_CACHEABILITY_MASK | > > + GICR_PENDBASER_ADDR_MASK | > > + GICR_PENDBASER_SHAREABILITY_MASK | > > + GICR_PENDBASER_CACHEABILITY_MAS

[Qemu-devel] [PATCH v2 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-26 Thread Bharata B Rao
Accommodate enough space in hotplug memory region so that it will be possible to align memory in each slot to 256M. When PowerPC memory hotplug enables inter-dimm gaps, then we could end up having unused/unassigned 256M memory chucks between DIMMs in the hotplug memory region. Hence create DRC obje

[Qemu-devel] [PATCH v2 0/2] Enforce gaps between DIMMs

2015-10-26 Thread Bharata B Rao
The suggested way to work around the virtio bug reported here http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html is to introduce gaps between DIMMs. Igor's patchset changes the pc-dimm auto-address assignment to introduce gaps and ues the same from pc memhp. This patchset does

[Qemu-devel] [PATCH v2 2/2] spapr: Force gaps between DIMM's GPA

2015-10-26 Thread Bharata B Rao
Mapping DIMMs non contiguously allows to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html In this case guest kernel doesn't allocate buffers that can cross DIMM boundary keeping each buffer local to a DIMM. Suggested-by: Michael S. Tsirk

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

2015-10-26 Thread Li, Liang Z
Hi Amit, I am very glad that you are looking at this patchset. Looking forward to your comments. :) Liang > -Original Message- > From: Amit Shah [mailto:amit.s...@redhat.com] > Sent: Monday, October 26, 2015 2:10 PM > To: Li, Liang Z > Cc: 'qemu-devel@nongnu.org'; 'quint...@redhat.co

Re: [Qemu-devel] [PATCH v5 2/2] enable multi-function hot-add

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 11:29:18AM +0800, Cao jin wrote: > Enable pcie device multifunction hot, just ensure the function 0 > added last, then driver will got the notification to scan all the > function in the slot. > > Signed-off-by: Cao jin > --- > hw/pci/pci.c | 31 +++

[Qemu-devel] [PATCH] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-26 Thread Igor Mammedov
commit aa8580cd "pc: memhp: force gaps between DIMM's GPA" regressed memory hot-unplug for linux guests triggering following BUGON = kernel BUG at mm/memory_hotplug.c:703! ... [] acpi_memory_device_remove+0x79/0xa5 [] acpi_bus_trim+0x5a/0x8d [] acpi_device_hotplug+0x1b7/0x418 === BUG

[Qemu-devel] KVM call for agenda for 2015-10-27

2015-10-26 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Call details: By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ (Let me know if you have any problems wit

Re: [Qemu-devel] [PATCH] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-26 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 09:42:05AM +0100, Igor Mammedov wrote: > commit aa8580cd "pc: memhp: force gaps between DIMM's GPA" > regressed memory hot-unplug for linux guests triggering > following BUGON > = > kernel BUG at mm/memory_hotplug.c:703! This is in portable code. Does this imply anyon

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-26 Thread Markus Armbruster
Valerio Aimale writes: > On 10/23/15 12:55 PM, Eduardo Habkost wrote: >> On Thu, Oct 22, 2015 at 03:51:28PM -0600, Valerio Aimale wrote: >>> On 10/22/15 3:47 PM, Eduardo Habkost wrote: On Thu, Oct 22, 2015 at 01:57:13PM -0600, Valerio Aimale wrote: > On 10/22/15 1:12 PM, Eduardo Habkost

[Qemu-devel] [PATCH 02/11] trace: split trace_init_events out of trace_init_backends

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini This is cleaner and has two advantages. First, it improves error reporting with -daemonize. Second, multiple "-trace events" options now cumulate. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- trace/control.c | 5 ++--

[Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now

2015-10-26 Thread Denis V. Lunev
original idea to split calling locations was to trace tracing thread in the final child process according to commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad Author: Michael Mueller Date: Mon Sep 23 16:36:54 2013 +0200 os_daemonize is now on top of both locations. Drop unneeded ifs.

[Qemu-devel] [PATCH v2 00/11] simplify usage of tracepoints, and connect them to logging

2015-10-26 Thread Denis V. Lunev
This series does three things: 1) add a "-trace [enable=]foo" option to enable one or more trace events, and a "-trace help" option to show the list of tracepoints (patches 4-5) 2) change the stderr tracing backend so that it prints to the -D log file, and enable it by default. "-trace file=..."

[Qemu-devel] [PATCH 05/11] trace: add "-trace enable=..."

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini Allow enabling events without going through a file, for example: qemu-system-x86_64 -trace bdrv_aio_writev -trace bdrv_aio_readv or with globbing too: qemu-system-x86_64 -trace 'bdrv_aio_*' if an appropriate backend is enabled (simple, stderr, ftrace). Signed-off-by

[Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory

2015-10-26 Thread Denis V. Lunev
log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev --- Makefile.objs| 1 - util/Makefile.objs | 1 + qemu-log.c => util/log.c | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename qemu-log.c => util/log.c (100%) diff --gi

[Qemu-devel] [PATCH 01/11] trace: fix documentation

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini Mention the ftrace backend too. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- qemu-options.hx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index edee5f4

[Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- qemu-io.c | 2 +- trace/control.c | 17 - trace/control.h | 13 - trace/simp

[Qemu-devel] [PATCH 06/11] trace: add "-trace help"

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini Print a list of trace points Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- qemu-options.hx | 2 ++ trace/control.c | 21 - trace/control.h | 7 +++ 3 files changed, 29 insertions(+), 1 deletion(

[Qemu-devel] [PATCH 09/11] trace: convert stderr backend to log

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- configure | 4 ++-- include/qemu/log.h | 1 + scripts/tracetool/backend/{stderr.py => log.py} | 9 +--

[Qemu-devel] [PATCH 07/11] log: do not unnecessarily include qom/cpu.h

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini Split the bits that require it to exec/log.h. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- bsd-user/main.c | 1 + cpu-exec.c| 1 + exec.c| 1 + hw/acpi/cpu_ho

[Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN"

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini This is a bit easier to use than "-trace" if you are also enabling other kinds of logging. It is also more discoverable for experienced QEMU users, and accessible from user-mode emulators. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Bo

[Qemu-devel] [PATCH 10/11] trace: switch default backend to "log"

2015-10-26 Thread Denis V. Lunev
From: Paolo Bonzini This enables integration with other QEMU logging facilities. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Reviewed-by: Christian Borntraeger --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d803e67

Re: [Qemu-devel] [PATCH 0/3] QEMU logging improvements

2015-10-26 Thread Markus Armbruster
"Denis V. Lunev" writes: > The following is done: > - QMP/HMP events are now logged > - timestamp is added to the log message > - arguments of qemu_log/qemu_log_mask are not calculated now if the log > is disabled > > These patches are sent in the hope that it is not too late for QEMU 2.5. > >

Re: [Qemu-devel] [PATCH] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-26 Thread Igor Mammedov
On Mon, 26 Oct 2015 11:02:10 +0200 "Michael S. Tsirkin" wrote: > On Mon, Oct 26, 2015 at 09:42:05AM +0100, Igor Mammedov wrote: > > commit aa8580cd "pc: memhp: force gaps between DIMM's GPA" > > regressed memory hot-unplug for linux guests triggering > > following BUGON > > = > > kernel BUG

Re: [Qemu-devel] [PATCH v4 03/13] target-arm: Add support for AArch32 S2 negative t0sz

2015-10-26 Thread Edgar E. Iglesias
On Fri, Oct 23, 2015 at 04:29:35PM +0100, Peter Maydell wrote: > On 14 October 2015 at 23:55, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Add support for AArch32 S2 negative t0sz. In preparation for > > using 40bit IPAs on AArch32. > > > > Signed-off-by: Edgar E. Iglesias >

Re: [Qemu-devel] Reminder: we're now in softfreeze

2015-10-26 Thread Peter Maydell
On 26 October 2015 at 06:25, Peter Crosthwaite wrote: > On Thu, Oct 22, 2015 at 3:30 AM, Peter Maydell > wrote: >> For this release I'd like to try tracking known-issues on >> the wiki page: http://wiki.qemu.org/Planning/2.5 >> with a list of patch series or bugs which need to be fixed >> into t

Re: [Qemu-devel] [PULL v4 00/52] Ivshmem patches

2015-10-26 Thread Marc-André Lureau
Hi Peter, On Mon, Oct 19, 2015 at 5:57 PM, Peter Maydell wrote: > > What is happening here is that we are looping infinitely in > mktempshmem() because shm_open() returns -1 with errno ENOSYS, > and there's no code in the loop that stops the loop on anything > except shm_open succeeding, or even

Re: [Qemu-devel] [PATCH v4 06/13] target-arm: Add computation of starting level for S2 PTW

2015-10-26 Thread Edgar E. Iglesias
On Fri, Oct 23, 2015 at 05:26:52PM +0100, Peter Maydell wrote: > On 14 October 2015 at 23:55, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > The starting level for S2 pagetable walks is computed > > differently from the S1 starting level. Implement the S2 > > variant. > > > > S

Re: [Qemu-devel] Qemu.git Build Failed

2015-10-26 Thread Zhang, Xianda
I'd like to know whether you have fixed the problem and the commit id. Thank you. -Original Message- From: Peter Maydell [mailto:peter.mayd...@linaro.org] Sent: Friday, October 23, 2015 5:23 PM To: Zhang, Xianda Cc: qemu-devel@nongnu.org; Hu, Robert Subject: Re: [Qemu-devel] Qemu.git

Re: [Qemu-devel] [PATCH v4 06/13] target-arm: Add computation of starting level for S2 PTW

2015-10-26 Thread Edgar E. Iglesias
On Fri, Oct 23, 2015 at 05:26:52PM +0100, Peter Maydell wrote: > On 14 October 2015 at 23:55, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > The starting level for S2 pagetable walks is computed > > differently from the S1 starting level. Implement the S2 > > variant. > > > > S

Re: [Qemu-devel] [PULL 00/37] Block layer patches

2015-10-26 Thread Peter Maydell
On 23 October 2015 at 18:00, Kevin Wolf wrote: > The following changes since commit 1e700f4c6cddaf29ce1d205f0f8e8b9255481930: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-10-23-tag' > into staging (2015-10-23 15:55:50 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-10-26 Thread Mark Cave-Ayland
On 27/09/15 15:40, Peter Maydell wrote: > Ping^2 -- this is still confusing users, cf bug LP:1500175. > > thanks > -- PMM > > On 6 July 2015 at 11:38, Peter Maydell wrote: >> On 3 July 2015 at 09:22, Mark Cave-Ayland >> wrote: >>> On 19/05/15 21:29, Richard Henderson wrote: >>> And do no

[Qemu-devel] [PATCH v2] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

2015-10-26 Thread Igor Mammedov
commit aa8580cd "pc: memhp: force gaps between DIMM's GPA" regressed memory hot-unplug for linux guests triggering following BUGON = kernel BUG at mm/memory_hotplug.c:703! ... [] acpi_memory_device_remove+0x79/0xa5 [] acpi_bus_trim+0x5a/0x8d [] acpi_device_hotplug+0x1b7/0x418 === BUG

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-10-26 Thread Mark Cave-Ayland
On 06/09/15 12:54, Mark Cave-Ayland wrote: > On 06/09/15 09:36, Alexander Graf wrote: > >> On 05.09.15 21:51, Mark Cave-Ayland wrote: >>> Commit 61964 "Add configuration section" broke the analyze-migration.py >>> script >>> which terminates due to the unrecognised section. Fix the script by par

[Qemu-devel] [PATCH 4/7] kvm: Hyper-V SynIC irq routing support

2015-10-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasan" CC: Gleb Natapov CC: Paolo Bonzini CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org CC: virtualizat...@lists.linux-foundation.org --- include/sysem

[Qemu-devel] [PATCH 0/7] Hyper-V Synthetic interrupt controller

2015-10-26 Thread Andrey Smetanin
Hyper-V SynIC (synthetic interrupt controller) device implementation. The implementation contains: * msr's support * irq routing setup * irq injection * irq ack callback registration * event/message pages changes tracking at Hyper-V exit * Hyper-V test device to test SynIC by kvm-unit-tests Andre

[Qemu-devel] [PATCH 5/7] linux-headers/kvm: KVM_EXIT_HYPERV type and struct

2015-10-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasan" CC: Gleb Natapov CC: Paolo Bonzini CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org CC: virtualizat...@lists.linux-foundation.org --- linux-headers

[Qemu-devel] [PATCH 1/7] standard-headers/x86: add Hyper-V SynIC constants

2015-10-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasan" CC: Gleb Natapov CC: Paolo Bonzini CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org CC: virtualizat...@lists.linux-foundation.org --- include/stand

[Qemu-devel] [PATCH 2/7] target-i386/kvm: Hyper-V SynIC MSR's support

2015-10-26 Thread Andrey Smetanin
Hyper-V SynIC MSR's support and MSR's migration. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasan" CC: Gleb Natapov CC: Paolo Bonzini CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org CC: virtualizat

Re: [Qemu-devel] [PATCH v4 09/13] target-arm: Add ARMMMUFaultInfo

2015-10-26 Thread Edgar E. Iglesias
On Fri, Oct 23, 2015 at 05:53:09PM +0100, Peter Maydell wrote: > On 14 October 2015 at 23:55, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Introduce ARMMMUFaultInfo to propagate MMU Fault information > > across the MMU translation code path. This is in preparation for > > add

Re: [Qemu-devel] [PATCH v4 03/13] target-arm: Add support for AArch32 S2 negative t0sz

2015-10-26 Thread Peter Maydell
On 26 October 2015 at 09:20, Edgar E. Iglesias wrote: > Yes, sounds good. I've changed the patch to the following: > > @@ -6521,8 +6521,24 @@ static bool get_phys_addr_lpae(CPUARMState *env, > target_ulong address, > */ > int32_t t0sz = extract32(tcr->raw_tcr, 0, 6); > if (va_size

[Qemu-devel] [PATCH 3/7] linux-headers/kvm: add Hyper-V SynIC irq routing type and struct

2015-10-26 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasan" CC: Gleb Natapov CC: Paolo Bonzini CC: Roman Kagan CC: Denis V. Lunev CC: k...@vger.kernel.org CC: virtualizat...@lists.linux-foundation.org --- linux-headers

[Qemu-devel] [PATCH 6/7] target-i386/hyperv: Hyper-V SynIC SINT routing and vCPU exit

2015-10-26 Thread Andrey Smetanin
Hyper-V SynIC(synthetic interrupt controller) API for irq routing setup, irq injection, irq ack notifications and event/message pages changes tracking for future use. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Vitaly Kuznetsov CC: "K. Y. Srinivasa

[Qemu-devel] [PATCH 7/7] hw/misc: Hyper-V test device 'hyperv-testdev'

2015-10-26 Thread Andrey Smetanin
'hyperv-testdev' will be used by kvm-unit-tests to setup Hyper-V SynIC SINT's routing and to inject Hyper-V SynIC SINT's. Hyper-V test device is ISA type device that create 0x3000 IO memory region and catches write access into it. Every write operation data decoded into ctl code and parameters for

[Qemu-devel] [RFC PATCH v1] spapr: Memory hot-unplug support

2015-10-26 Thread Bharata B Rao
Add support to hot remove pc-dimm memory devices. TODO: In response to memory hot removal operation on a DIMM device, guest kernel might refuse to offline a few LMBs that are part of that device. In such cases, we will have a DIMM device that has some LMBs online and some LMBs offline. To avoid th

[Qemu-devel] [kvm-unit-tests PATCH] x86: hyperv_synic: Hyper-V SynIC test

2015-10-26 Thread Andrey Smetanin
Hyper-V SynIC is a Hyper-V synthetic interrupt controller. The test runs on every vCPU and performs the following steps: * read from all Hyper-V SynIC MSR's * setup Hyper-V SynIC evt/msg pages * setup SINT's routing * inject SINT's into destination vCPU by 'hyperv-synic-test-device' * wait for SIN

Re: [Qemu-devel] Reminder: we're now in softfreeze

2015-10-26 Thread Mark Cave-Ayland
On 26/10/15 09:27, Peter Maydell wrote: > On 26 October 2015 at 06:25, Peter Crosthwaite > wrote: >> On Thu, Oct 22, 2015 at 3:30 AM, Peter Maydell >> wrote: >>> For this release I'd like to try tracking known-issues on >>> the wiki page: http://wiki.qemu.org/Planning/2.5 >>> with a list of pat

  1   2   3   4   >