[Qemu-devel] Qemu.git Build Failed

2015-10-23 Thread Zhang, Xianda
Description: c2bea314f6a2870b847c79e2e11263c5f9334db7 is the first bad commit commit c2bea314f6a2870b847c79e2e11263c5f9334db7 Author: Marc-André Lureau Date: Fri Oct 9 17:17:23 2015 +0200 636f4dddfe48ccabaf5198bba440354d6a268d62 is OK for use. Steps: ./configure --target-list=x86_64-softmmu ma

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-23 Thread Paolo Bonzini
On 23/10/2015 06:41, Jordan Justen wrote: > On 2015-10-22 12:46:56, Paolo Bonzini wrote: >> >> On 22/10/2015 20:04, Kevin O'Connor wrote: >>> On Thu, Oct 22, 2015 at 10:40:08AM +0200, Paolo Bonzini wrote: On 21/10/2015 20:36, Jordan Justen wrote: > On 2015-10-20 11:14:00, Laszlo Ersek wr

Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts

2015-10-23 Thread Pavel Dovgaluk
Hi, Paolo! Will you pull these patches into 2.5? Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [RFH

Re: [Qemu-devel] fw_cfg DMA security

2015-10-23 Thread Paolo Bonzini
On 23/10/2015 08:56, Gerd Hoffmann wrote: >> > >> > So, for example, since Red Hat is working on SMM. Would a DMA to SMRAM >> > be protected? >> > >> > I haven't watched the fw_cfg DMA discussion too closely, but has this >> > been thought about? > Yes. That problem isn't new and it isn't spec

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

2015-10-23 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 23/10/2015 03:38, David Gibson wrote: > On Fri, Oct 16, 2015 at 03:16:11PM +0200, Paolo Bonzini wrote: >> These messages are disabled by default; a perfect usecase for >> tracepoints. Convert them over. >> >> Signed-off-by: Paolo Bonzini > >

Re: [Qemu-devel] [PATCH v4 2/2] enable multi-function hot-add

2015-10-23 Thread Cao jin
On 10/23/2015 02:50 PM, Michael S. Tsirkin wrote: On Fri, Oct 23, 2015 at 12:13:53PM +0800, Cao jin wrote: Hi Michael On 10/22/2015 10:37 PM, Michael S. Tsirkin wrote: On Thu, Oct 22, 2015 at 07:57:52PM +0800, Cao jin wrote: Enable pcie device multifunction hot, just ensure the function 0 a

Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts

2015-10-23 Thread Paolo Bonzini
On 23/10/2015 09:28, Pavel Dovgaluk wrote: > Hi, Paolo! > > Will you pull these patches into 2.5? Yes. Paolo

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-23 Thread Daniel P. Berrange
On Fri, Oct 23, 2015 at 08:35:15AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Oct 21, 2015 at 12:54:23PM +0200, Markus Armbruster wrote: > >> Valerio Aimale writes: > > [...] > >> > There's also a similar patch, floating around the internet, the uses > >> > shared me

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-23 Thread Daniel P. Berrange
On Thu, Oct 22, 2015 at 03:51:28PM -0600, Valerio Aimale wrote: > On 10/22/15 3:47 PM, Eduardo Habkost wrote: > >On Thu, Oct 22, 2015 at 01:57:13PM -0600, Valerio Aimale wrote: > >>On 10/22/15 1:12 PM, Eduardo Habkost wrote: > >>>On Wed, Oct 21, 2015 at 12:54:23PM +0200, Markus Armbruster wrote: >

[Qemu-devel] [PATCH v3 0/3] vhost-user mq sequel works

2015-10-23 Thread Yuanhan Liu
Patch 1 is basically reverts the patch does the rename, as it may break build for VHOST_RESET_OWNER is no longer defined. As Michael stated, reverting it is not enough, we need send it from the right place, and send SET_VRING_ENABLE at start/stop, which is something I will do late

[Qemu-devel] [PATCH v3 3/3] vhost-user-test: add multiple queue test

2015-10-23 Thread Yuanhan Liu
Setting VHOST_USER_PROTOCOL_F_MQ protocol feature bit to claim that we support MQ feature, and simply assume we support 2 queue pairs at most. Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Yuanhan Liu --- tests/vhost-user-test.c | 23 +-- 1 file changed, 21 insertion

[Qemu-devel] [PATCH v3 2/3] doc: vhost-user: request naming fix

2015-10-23 Thread Yuanhan Liu
They are VHOST_USER_XXX instead of VHOST_XXX messages. Also, add VHOST_USER_GET_QUEUE_NUM to the section that requries replies. Cc: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --

[Qemu-devel] [PATCH v3 1/3] vhost: rename VHOST_RESET_DEVICE back to VHOST_RESET_OWNER

2015-10-23 Thread Yuanhan Liu
It turned out that it breaks stuff (VHOST_RESET_OWNER is not defined), so revert it: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html CC: "Michael S. Tsirkin" Reported-by: Paolo Bonzini Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 4 ++-- hw/virtio/vho

Re: [Qemu-devel] Qemu.git Build Failed

2015-10-23 Thread Peter Maydell
On 23 October 2015 at 06:39, Zhang, Xianda wrote: > Steps: > > ./configure --target-list=x86_64-softmmu > > make -j20 > > > > Build log is as follows: > > /home/build/gitrepo/qemu/hw/virtio/vhost-user.c: In function > ‘vhost_set_log_base’: > > /home/build/gitrepo/qemu/hw/virtio/vhost-user.c:374: e

Re: [Qemu-devel] [PATCH] gdb command: qemu aios, qemu aiohandlers

2015-10-23 Thread Fam Zheng
On Tue, 10/20 12:05, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Two new gdb commands are added: > > qemu iohandlers > > that dumps the list of waiting iohandlers, this is particularly > useful for trying to figure out where an incoming migration is >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

2015-10-23 Thread Andreas Färber
Am 23.10.2015 um 03:38 schrieb David Gibson: > On Fri, Oct 16, 2015 at 03:16:11PM +0200, Paolo Bonzini wrote: >> These messages are disabled by default; a perfect usecase for tracepoints. >> Convert them over. >> >> Signed-off-by: Paolo Bonzini > > Looks good to me. Applied to ppc-next. Would'v

[Qemu-devel] [PULL 13/21] escc: add to input category

2015-10-23 Thread David Gibson
From: Laurent Vivier ESCC is a serial port controller, so add it to the input category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/char/escc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/escc.c b/hw/char/escc.c index ba653ef..981

[Qemu-devel] [PULL 06/21] spapr_iommu: Provide a function to switch a TCE table to allowing VFIO

2015-10-23 Thread David Gibson
Because of the way non-VFIO guest IOMMU operations are KVM accelerated, not all TCE tables (guest IOMMU contexts) can support VFIO devices. Currently, this is decided at creation time. To support hotplug of VFIO devices, we need to allow a TCE table which previously didn't allow VFIO devices to b

[Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023

2015-10-23 Thread David Gibson
The following changes since commit 6a6739de510706e1d337180d12be74ebbd0c7666: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151021' into staging (2015-10-22 18:01:53 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-next-2015102

[Qemu-devel] [PULL 07/21] spapr_pci: Allow VFIO devices to work on the normal PCI host bridge

2015-10-23 Thread David Gibson
The core VFIO infrastructure more or less allows VFIO devices to work on any normal guest PCI host bridge (PHB) without extra logic. However, the "spapr-pci-host-bridge" device (as opposed to the special "spapr-pci-vfio-host-bridge" device) breaks this by using a partially KVM accelerated implement

[Qemu-devel] [PULL 03/21] spapr: Add "slb-size" property to CPU device tree nodes

2015-10-23 Thread David Gibson
From: Thomas Huth According to a commit message in the Linux kernel (see here https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b60c31d85a2a for example), the name of the property that carries the information about the number of SLB entries should be called "slb-size", an

[Qemu-devel] [PULL 02/21] spapr: Abort when HTAB of requested size isn't allocated

2015-10-23 Thread David Gibson
From: Bharata B Rao Terminate the guest when HTAB of requested size isn't allocated by the host. When memory hotplug is attempted on a guest that has booted with less than requested HTAB size, the guest kernel will not be able to gracefully fail the hotplug request. This patch will ensure that w

[Qemu-devel] [PULL 08/21] hw/scsi/spapr_vscsi: Remove superfluous memset

2015-10-23 Thread David Gibson
From: Thomas Huth g_malloc0 already clears the memory, so no need for the additional memset here. Cc: Paolo Bonzini Cc: David Gibson Cc: Alexander Graf Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Signed-off-by: David Gibson --- hw/scsi/spapr_vscsi.c | 1 - 1 file changed, 1 deletio

[Qemu-devel] [PULL 18/21] macio: add to bridge category

2015-10-23 Thread David Gibson
From: Laurent Vivier macio is a bridge between the PCI bus and the Mac nvram, IDE controller and PIC, so add it to the bridge category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/misc/macio/macio.c | 1 + 1 file changed, 1 insertion(+) diff --g

[Qemu-devel] [PULL 04/21] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-10-23 Thread David Gibson
At present the PCI host bridge (PHB) for the pseries machine type has a fixed DMA window from 0..1GB (in PCI address space) which is mapped to real memory via the PAPR paravirtualized IOMMU. For better support of VFIO devices, we're going to want to allow for different configurations of the DMA wi

[Qemu-devel] [PULL 12/21] cmd646: add to storage category

2015-10-23 Thread David Gibson
From: Laurent Vivier cmd646 is an IDE controller, so add it to the storage category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/ide/cmd646.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 66fb9d9..27f

[Qemu-devel] [PULL 11/21] adb: add to input category

2015-10-23 Thread David Gibson
From: Laurent Vivier The Apple Desktop Bus is used to connect a keyboard and a mouse, so add it to the input category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/input/adb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/adb.c b/

[Qemu-devel] [PULL 15/21] cuda: add to bridge category

2015-10-23 Thread David Gibson
From: Laurent Vivier Cuda is a bridge between PowerMac system bus and the ADB controller, real-time clock, pram and the power management unit. So add it to the bridge category. Signed-off-by: Laurent Vivier Signed-off-by: David Gibson --- hw/misc/macio/cuda.c | 1 + 1 file changed, 1 inserti

[Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023

2015-10-23 Thread David Gibson
The following changes since commit 6a6739de510706e1d337180d12be74ebbd0c7666: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151021' into staging (2015-10-22 18:01:53 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-next-2015102

[Qemu-devel] [PULL 16/21] macio-ide: add to storage category

2015-10-23 Thread David Gibson
From: Laurent Vivier macio-ide is an IDE controller, so add it to the storage category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Reviewed-by: John Snow Signed-off-by: David Gibson --- hw/ide/macio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/macio.c b/hw/ide/ma

[Qemu-devel] [PULL 14/21] grackle: add to bridge category

2015-10-23 Thread David Gibson
From: Laurent Vivier Grackle is the PCI host controller of oldworld powermac, so add it to the bridge category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/pci-host/grackle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-host/grack

[Qemu-devel] [PULL 19/21] macio-nvram: add to misc category

2015-10-23 Thread David Gibson
From: Laurent Vivier The macio nvram is a non volatile RAM, so add it the misc category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/nvram/mac_nvram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c

[Qemu-devel] [PULL 20/21] openpic: add to misc category

2015-10-23 Thread David Gibson
From: Laurent Vivier openpic is a programmable interrupt controller, so add it to the misc category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/intc/openpic.c | 1 + hw/intc/openpic_kvm.c | 1 + 2 files changed, 2 insertions(+) diff --git a

[Qemu-devel] [PULL 21/21] prep: do not use CPU_LOG_IOPORT, convert to tracepoints

2015-10-23 Thread David Gibson
From: Paolo Bonzini These messages are disabled by default; a perfect usecase for tracepoints. Convert them over. Signed-off-by: Paolo Bonzini Signed-off-by: David Gibson --- hw/ppc/prep.c | 30 +++--- trace-events | 4 2 files changed, 7 insertions(+), 27 delet

[Qemu-devel] [PULL 01/21] spapr: Allocate HTAB from machine init

2015-10-23 Thread David Gibson
From: Bharata B Rao Allocate HTAB from ppc_spapr_init() so that we can abort the guest if requested HTAB size is't allocated by the host. However retain the htab reset call in spapr_reset_htab() so that HTAB gets reset (and not allocated) during machine reset. Signed-off-by: Bharata B Rao Signe

[Qemu-devel] [PULL 17/21] uninorth: add to bridge category

2015-10-23 Thread David Gibson
From: Laurent Vivier Uninorth is the mac99 PCI host controller, so add it to the bridge category. Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth Signed-off-by: David Gibson --- hw/pci-host/uninorth.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/pci-host/uninorth.c b

[Qemu-devel] [PULL 10/21] ppc/spapr: Add "ibm, pa-features" property to the device-tree

2015-10-23 Thread David Gibson
From: Benjamin Herrenschmidt LoPAPR defines a "ibm,pa-features" per-CPU device tree property which describes extended features of the Processor Architecture. This adds the property to the device tree. At the moment this is the copy of what pHyp advertises except "I=1 (cache inhibited) Large Page

[Qemu-devel] [PULL 09/21] ppc: Add mmu_model defines for arch 2.03 and 2.07

2015-10-23 Thread David Gibson
From: Benjamin Herrenschmidt This removes unused POWERPC_MMU_2_06a/POWERPC_MMU_2_06d. This replaces POWERPC_MMU_64B with POWERPC_MMU_2_03 for POWER5+ to be more explicit about the version of the PowerISA supported. This defines POWERPC_MMU_2_07 and uses it for the POWER8 CPU family. This will n

Re: [Qemu-devel] fw_cfg DMA security

2015-10-23 Thread Marc Marí
On Fri, 23 Oct 2015 08:56:26 +0200 Gerd Hoffmann wrote: > Hi, > > > One complication I thought of was that it might be tricky to deal > > with the implications of allowing this DMA to specify any old > > address to fill with fw_cfg data. > > > > So, for example, since Red Hat is working on SM

[Qemu-devel] [PULL 05/21] spapr_iommu: Rename vfio_accel parameter

2015-10-23 Thread David Gibson
The vfio_accel parameter used when creating a new TCE table (guest IOMMU context) has a confusing name. What it really means is whether we need the TCE table created to be able to support VFIO devices. VFIO is relevant, because when available we use in-kernel acceleration of the TCE table, but th

Re: [Qemu-devel] [PATCH] gdb command: qemu aios, qemu aiohandlers

2015-10-23 Thread Stefan Hajnoczi
On Fri, Oct 23, 2015 at 10:32 AM, Fam Zheng wrote: > On Tue, 10/20 12:05, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Two new gdb commands are added: >> >> qemu iohandlers >> >> that dumps the list of waiting iohandlers, this is particularly >> useful f

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Sergey Fedorov
On 23.10.2015 00:28, Peter Maydell wrote: > On 22 October 2015 at 19:28, Sergey Fedorov wrote: >> Hi all, >> >> I am trying to understand what the difference should be between >> DISAS_JUMP and DISAS_UPDATE. Actually, these macros have comments in >> include/exec/exec-all.h which say that DISAS_JU

Re: [Qemu-devel] [PATCH v2 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-10-23 Thread Marcelo Tosatti
On Thu, Oct 22, 2015 at 04:45:21PM -0200, Eduardo Habkost wrote: > On Tue, Oct 20, 2015 at 03:22:51PM +0800, Haozhong Zhang wrote: > > This patchset enables QEMU to save/restore vcpu's TSC rate during the > > migration. When cooperating with KVM which supports TSC scaling, guest > > programs can ob

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

2015-10-23 Thread Bernhard Voelker
On 10/22/2015 05:55 PM, Eric Blake wrote: On 10/22/2015 09:47 AM, Bernhard Voelker wrote: Also I suspect the extra conditions involved in using longs for just the first 16 bytes would outweigh the benefits? I.E. the first simple loop probably breaks early, and if not has the added benefit of "p

Re: [Qemu-devel] [PATCH QEMU-XEN v4 2/9] xen: Switch to libxenevtchn interface for compat shims.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxenevtchn which provides access to event > channels. > > In preparati

Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxengnttab which provides access to grant > tables. > > In preparation

Re: [Qemu-devel] [PATCH QEMU-XEN v4 6/9] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxenforeignmemory which provides access to > privileged foreign mapping

Re: [Qemu-devel] [PATCH QEMU-XEN v4 4/9] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxenforeignmemory which provides access to > privileged foreign mapping

Re: [Qemu-devel] [PULL] vhost: build fix

2015-10-23 Thread Peter Maydell
On 22 October 2015 at 20:37, Michael S. Tsirkin wrote: > The following changes since commit 3c23402d4032f69af44a87fdb8019ad3229a4f31: > > hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT > (2015-10-22 14:39:09 +0300) > > are available in the git repository at: > > git://

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Peter Maydell
On 23 October 2015 at 11:14, Sergey Fedorov wrote: > Thanks, Peter. What if I am going to modify DISAS_JUMP and DISAS_UPDATE > usage in 32-bit ARM code and apply AArch64 semantics to them? No objection as long as it all still works :-) -- PMM

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > Until the previous patch this relied on xc_fd(), which was only > implemented for Xen 4.0 and earlier. > > Given this wasn't working since Xen 4.0 I have marked this as disabled > by default. > > Removing this support drops the use of a bunch of symbols

Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 12:06 +0100, Stefano Stabellini wrote: > On Wed, 21 Oct 2015, Ian Campbell wrote: > > In Xen 4.7 we are refactoring parts libxenctrl into a number of > > separate libraries which will provide backward and forward API and ABI > > compatiblity. > > > > One such library will be

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

2015-10-23 Thread Paolo Bonzini
On 23/10/2015 13:12, Pádraig Brady wrote: > On 22/10/15 20:47, Paolo Bonzini wrote: >> >> >> On 22/10/2015 19:39, Radim Krčmář wrote: >>> 2015-10-22 18:14+0200, Paolo Bonzini: On 22/10/2015 18:02, Eric Blake wrote: > I see a bug in there: Of course. You shouldn't have told me

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

2015-10-23 Thread Pádraig Brady
On 22/10/15 20:47, Paolo Bonzini wrote: > > > On 22/10/2015 19:39, Radim Krčmář wrote: >> 2015-10-22 18:14+0200, Paolo Bonzini: >>> On 22/10/2015 18:02, Eric Blake wrote: I see a bug in there: >>> >>> Of course. You shouldn't have told me what the bug was, I deserved >>> to look for it myse

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 12:12 +0100, Stefano Stabellini wrote: > @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" != "no"; then > >fi > > fi > > > > +if test "$xen_pv_domain_build" != "no"; then > > + if test "$xen_pv_domain_build" = "yes" && > > + test "$xen" != "yes"; then > > +

Re: [Qemu-devel] [PATCH QEMU-XEN v4 7/9] xen: Use stable library interfaces when they are available.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > Specifically libxenevtchn, libxengnttab and libxenforeignmemory. > > Previous patches have alread

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Stefano Stabellini
On Fri, 23 Oct 2015, Ian Campbell wrote: > On Fri, 2015-10-23 at 12:12 +0100, Stefano Stabellini wrote: > > @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" != "no"; then > > >fi > > > fi > > > > > > +if test "$xen_pv_domain_build" != "no"; then > > > + if test "$xen_pv_domain_build" =

[Qemu-devel] [PATCH] vhost-user-test: fix up rhel6 build

2015-10-23 Thread Michael S. Tsirkin
Build on RHEL6 fails: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42875 Apparently unnamed unions couldn't use C99 named field initializers. Let's just name the payload union field. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 18 +- 1 file changed, 9 insert

Re: [Qemu-devel] [PATCH v7 00/10] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end

2015-10-23 Thread Kevin Wolf
Am 23.10.2015 um 05:08 hat Fam Zheng geschrieben: > v7: Exclude bdrv_drain and bdrv_qed_drain patches, they'll follow the > bdrv_drain fix for bdrv_aio_flush. > Fix internal snapshot clean. > > v6: Add Kevin's rev-by in patches 1-3, 6-8, 10, 12. > Add Jeff's rev-by in patches 1, 2, 6-8

Re: [Qemu-devel] qemu-system-arm system support for big endian BE8

2015-10-23 Thread Peter Maydell
On 23 October 2015 at 12:11, sridhar kulkarni wrote: > Hi, > > Floating point exception error was the result of a divide by zero in the > application. That is now solved and I was able to progress pretty well with > Big Endinan code. > Currently QEMU crashes during handling interrupt controller. >

[Qemu-devel] [PATCH v3 0/4] Add 'x-blockdev-del' command

2015-10-23 Thread Alberto Garcia
This version uses op blockers for the target image in the drive-mirror job, but the implementation of 'x-blockdev-del' remains the same. I copy the description from the previous series: The semantics of 'x-blockdev-del' try to mirror the semantics of 'blockdev-add' as I discussed with Kevin in the

[Qemu-devel] [PATCH v3 1/4] mirror: block all operations on the target image during the job

2015-10-23 Thread Alberto Garcia
There's nothing preventing the target image from being used by other operations during the 'drive-mirror' job, so we should block them all until the job is done. Signed-off-by: Alberto Garcia --- block/mirror.c | 4 1 file changed, 4 insertions(+) diff --git a/block/mirror.c b/block/mirror

[Qemu-devel] [PATCH v3 2/4] block: Add blk_get_refcnt()

2015-10-23 Thread Alberto Garcia
This function returns the reference count of a given BlockBackend. For convenience, it returns 0 if the BlockBackend pointer is NULL. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/block-backend.c | 5 + include/sysemu/block-backend.h | 1 + 2 files changed, 6 inser

[Qemu-devel] [PATCH v3 4/4] iotests: Add tests for the x-blockdev-del command

2015-10-23 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/139 | 408 + tests/qemu-iotests/139.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 414 insertions(+) create mode 100644 tests/qemu-iotests/139 create mode 100644 tests/qemu-io

Re: [Qemu-devel] [PULL v3 0/4] Misc fixes for crypto code module

2015-10-23 Thread Peter Maydell
On 22 October 2015 at 19:05, Daniel P. Berrange wrote: > The following changes since commit ca3e40e233e87f7b29442311736a82da01c0df7b: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-22 12:41:44 +0100) > > are available in the git repository at: > > htt

[Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command

2015-10-23 Thread Alberto Garcia
This command is still experimental, hence the name. This is the companion to 'blockdev-add'. It allows deleting a BlockBackend with its associated BlockDriverState tree, or a BlockDriverState that is not attached to any backend. In either case, the command fails if the reference count is greater

Re: [Qemu-devel] [PATCH v2 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-10-23 Thread Eduardo Habkost
On Fri, Oct 23, 2015 at 08:35:20AM -0200, Marcelo Tosatti wrote: > On Thu, Oct 22, 2015 at 04:45:21PM -0200, Eduardo Habkost wrote: > > On Tue, Oct 20, 2015 at 03:22:51PM +0800, Haozhong Zhang wrote: > > > This patchset enables QEMU to save/restore vcpu's TSC rate during the > > > migration. When c

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 12:35 +0100, Stefano Stabellini wrote: > On Fri, 23 Oct 2015, Ian Campbell wrote: > > On Fri, 2015-10-23 at 12:12 +0100, Stefano Stabellini wrote: > > > @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" != "no"; then > > > >fi > > > > fi > > > > > > > > +if test "$x

Re: [Qemu-devel] [PATCH QEMU-XEN v4 7/9] xen: Use stable library interfaces when they are available.

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 12:31 +0100, Stefano Stabellini wrote: > > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h > > index 2a5f27a..38293b4 100644 > > --- a/include/hw/xen/xen_common.h > > +++ b/include/hw/xen/xen_common.h > > @@ -6,6 +6,17 @@ > > #include > > #include >

[Qemu-devel] [PATCH] usb-host: fix usb3ep0quirk test

2015-10-23 Thread Gerd Hoffmann
usb->speed is the usb speed the device is actually running on in the qemu emulation (i.e. from the guests point of view). So when plugging usb3 devices into ehci hostadapter this is HIGH not SUPER. To figure whenever the host talks to the device with superspeed we have to check speedmask instead

Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > We are failing to detect a collision between a QMP member and > the implicit 'has_*' flag for another optional QMP member. The > easiest fix would be for a future patch to reserve the entire > "has[-_]" namespace for member names (the collision is also > possible for branch n

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Sergey Fedorov
On 23.10.2015 14:10, Peter Maydell wrote: > On 23 October 2015 at 11:14, Sergey Fedorov wrote: >> Thanks, Peter. What if I am going to modify DISAS_JUMP and DISAS_UPDATE >> usage in 32-bit ARM code and apply AArch64 semantics to them? > No objection as long as it all still works :-) Well, I made

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Peter Maydell
On 23 October 2015 at 13:35, Sergey Fedorov wrote: > On 23.10.2015 14:10, Peter Maydell wrote: >> On 23 October 2015 at 11:14, Sergey Fedorov wrote: >>> Thanks, Peter. What if I am going to modify DISAS_JUMP and DISAS_UPDATE >>> usage in 32-bit ARM code and apply AArch64 semantics to them? >> No

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Sergey Fedorov
On 23.10.2015 15:37, Peter Maydell wrote: > On 23 October 2015 at 13:35, Sergey Fedorov wrote: >> On 23.10.2015 14:10, Peter Maydell wrote: >>> On 23 October 2015 at 11:14, Sergey Fedorov wrote: Thanks, Peter. What if I am going to modify DISAS_JUMP and DISAS_UPDATE usage in 32-bit ARM

Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct

2015-10-23 Thread Eric Blake
On 10/23/2015 06:33 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We are failing to detect a collision between a QMP member and >> the implicit 'has_*' flag for another optional QMP member. The >> easiest fix would be for a future patch to reserve the entire >> "has[-_]" namespace for me

Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE

2015-10-23 Thread Peter Maydell
On 23 October 2015 at 13:39, Sergey Fedorov wrote: > On 23.10.2015 15:37, Peter Maydell wrote: >> On 23 October 2015 at 13:35, Sergey Fedorov wrote: >>> On 23.10.2015 14:10, Peter Maydell wrote: On 23 October 2015 at 11:14, Sergey Fedorov wrote: > Thanks, Peter. What if I am going to mo

Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 12:06 +0100, Stefano Stabellini wrote: > On Wed, 21 Oct 2015, Ian Campbell wrote: > > In Xen 4.7 we are refactoring parts libxenctrl into a number of > > separate libraries which will provide backward and forward API and ABI > > compatiblity. > > > > One such library will be

Re: [Qemu-devel] [PATCH v10 03/25] qapi: More robust conditions for when labels are needed

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > We were using regular expressions to see if ret included > any earlier text that emitted a 'goto out;' line, to decide > whether we needed to output an 'out:' label. But this is > fragile, if the ret text can possibly combine more than one > generated function body, where th

Re: [Qemu-devel] [PATCH v2 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-10-23 Thread Haozhong Zhang
On Fri, Oct 23, 2015 at 08:35:20AM -0200, Marcelo Tosatti wrote: > On Thu, Oct 22, 2015 at 04:45:21PM -0200, Eduardo Habkost wrote: > > On Tue, Oct 20, 2015 at 03:22:51PM +0800, Haozhong Zhang wrote: > > > This patchset enables QEMU to save/restore vcpu's TSC rate during the > > > migration. When c

Re: [Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023

2015-10-23 Thread Peter Maydell
git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-next-20151023 > > for you to fetch changes up to 659f7f65561e78d720986d61f3112c54a97b2b96: > > prep: do not use CPU_LOG_IOPORT, convert to tracepoints (2015-10-23 > 12:38:28 +1100) > > ---

Re: [Qemu-devel] [PATCH] hw/isa/lpc_ich9: inject the SMI on the VCPU that is writing to APM_CNT

2015-10-23 Thread Laszlo Ersek
On 10/23/15 09:26, Paolo Bonzini wrote: > > > On 23/10/2015 06:41, Jordan Justen wrote: >> On 2015-10-22 12:46:56, Paolo Bonzini wrote: >>> >>> On 22/10/2015 20:04, Kevin O'Connor wrote: On Thu, Oct 22, 2015 at 10:40:08AM +0200, Paolo Bonzini wrote: > On 21/10/2015 20:36, Jordan Justen w

Re: [Qemu-devel] [PATCH v10 04/25] qapi: Reserve '*List' type names for list types

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > Type names ending in 'List' can clash with qapi list types in > generated C. We don't currently use such names. It is easier to > outlaw them now than to worry about how to resolve such a clash > in the future. For precedence, see commit 4dc2e69, which did the > same for nam

[Qemu-devel] [PATCH] pc: memhp: do not emit inserting event for coldplugged DIMMs

2015-10-23 Thread Igor Mammedov
currently acpi_memory_plug_cb() sets is_inserting for cold- and hot-plugged DIMMs as result ASL MHPD.MSCN() method issues device check even for every coldplugged DIMM. There isn't much harm in it but if we try to unplug such DIMM, OSPM will issue device check intstead of device eject event. So OSPM

[Qemu-devel] [Bug 1509336] [NEW] USB passthru not work with Mac OS X El Capitan

2015-10-23 Thread Okra
Public bug reported: QEMU emulator version 2.4.50 with kernel kvm module from linux kernel 3.16.0 or 4.2.3 Since upgrading from Yosemite to El Capitan - USB passthru does not work. Note USB passthru worked perfectly with Maverick and Yosemite. I attempt to use different USB hosts. I found a patc

Re: [Qemu-devel] [PATCH] copy, dd: simplify and optimize NUL bytes detection

2015-10-23 Thread Pádraig Brady
On 22/10/15 20:47, Paolo Bonzini wrote: > > > On 22/10/2015 19:39, Radim Krčmář wrote: >> 2015-10-22 18:14+0200, Paolo Bonzini: >>> On 22/10/2015 18:02, Eric Blake wrote: I see a bug in there: >>> >>> Of course. You shouldn't have told me what the bug was, I deserved >>> to look for it myse

Re: [Qemu-devel] [PATCH v10 05/25] qapi: Reserve 'q_*' and 'has_*' member names

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > c_name() produces names starting with 'q_' when protecting > a QMP member name that would fail to directly compile, but > in doing so can cause clashes with any QMP name already > beginning with 'q-' or 'q_'. Likewise, we create a C name > 'has_' for any optional member, tha

Re: [Qemu-devel] [PATCH v2] i386/acpi: add _HID to processor objects

2015-10-23 Thread Igor Mammedov
On Thu, 22 Oct 2015 22:03:24 +0200 Matthias Lange wrote: > This patch appends "ACPI0007" as the HID to each processor object. > > Until commit 20843d processor objects used to have a _HID. According > to the ACPI spec this is not required but removing it breaks systems Pls answer Michael's quest

Re: [Qemu-devel] [PATCH v9 04/17] vnc: hoist allocation of VncBasicInfo to callers

2015-10-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Oct 20, 2015 at 04:53:24PM -0600, Eric Blake wrote: >> On 10/20/2015 08:46 AM, Markus Armbruster wrote: >> > Gerd Hoffmann writes: >> > >> >> Hi, >> >> >> -static VncBasicInfo *vnc_basic_info_get(struct sockaddr_storage *sa, >> -

Re: [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > blockdev.c | 49 + > qapi/block-core.json | 23 +++ > qmp-commands.hx | 39 +++ > 3 files cha

Re: [Qemu-devel] [PATCH v3 08/21] block: Compute minimum, maximum and average I/O latencies

2015-10-23 Thread Stefan Hajnoczi
On Thu, Oct 22, 2015 at 11:11:18AM +0300, Alberto Garcia wrote: > +struct BlockAcctTimedStats { > +TimedAverage latency[BLOCK_MAX_IOTYPE]; > +unsigned interval_length; /* in seconds */ would be nice here so the units are clear. Or even interval_length_secs.

Re: [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > blockdev.c | 49 + > qapi/block-core.json | 23 +++ > qmp-commands.hx | 39 +++ > 3 files cha

Re: [Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl

2015-10-23 Thread Markus Armbruster
Eric Blake writes: > We generate a static visit_type_FOO_fields() for every type > FOO. However, sometimes we need a forward declaration. Split > the code to generate the forward declaration out of > gen_visit_implicit_struct() into a new gen_visit_fields_decl(), > and also prepare for a forward

[Qemu-devel] [PATCH] correct comment of option parse in main()

2015-10-23 Thread Cao jin
Signed-off-by: Cao jin --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 332d828..aa95172 100644 --- a/vl.c +++ b/vl.c @@ -3031,7 +3031,7 @@ int main(int argc, char **argv, char **envp) optind = 1; while (optind < argc) { if (argv[op

Re: [Qemu-devel] [PATCH v3 09/21] block: Add average I/O queue depth to BlockDeviceTimedStats

2015-10-23 Thread Alberto Garcia
On Fri 23 Oct 2015 03:31:38 PM CEST, Stefan Hajnoczi wrote: >> +uint64_t timed_average_sum(TimedAverage *ta, uint64_t *elapsed) >> +{ >> +TimedAverageWindow *w; >> +check_expirations(ta); >> +w = current_window(ta); >> +if (elapsed != NULL) { >> +int64_t remaining = w->exp

Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > And a helper function for that, which directly takes a pointer to the > BDS to be inserted instead of its node-name (which will be used for > implementing 'change' using blockdev-insert-medium). > > Signed-off-by: Max Reitz > --- > blockdev.c

Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium

2015-10-23 Thread Kevin Wolf
Am 21.10.2015 um 15:47 hat Max Reitz geschrieben: > On 21.10.2015 13:49, Alberto Garcia wrote: > > On Mon 19 Oct 2015 05:53:37 PM CEST, Max Reitz wrote: > >> And a helper function for that, which directly takes a pointer to the > >> BDS to be inserted instead of its node-name (which will be used fo

Re: [Qemu-devel] [PATCH v7 32/39] blockdev: Implement eject with basic operations

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Implement 'eject' by calling blockdev-open-tray and > blockdev-remove-medium. > > Signed-off-by: Max Reitz > --- > blockdev.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index

Re: [Qemu-devel] [PATCH v7 30/39] blockdev: Add blockdev-remove-medium

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz I assume that you'll fix the bdrv_states issues in blk_insert/remove_bs, so the blk_remove_bs() call in this patch will take care of it. If so, you can add: Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PULL 00/21] ppc-next-20151023 queue 20151023

2015-10-23 Thread Michael Roth
it repository at: > > git://github.com/dgibson/qemu.git tags/ppc-next-20151023 > > for you to fetch changes up to 659f7f65561e78d720986d61f3112c54a97b2b96: > > prep: do not use CPU_LOG_IOPORT, convert to tracepoints (2015-10-23 > 12:38:28 +1100) > > Peter, > >

Re: [Qemu-devel] [PATCH v7 29/39] blockdev: Add blockdev-close-tray

2015-10-23 Thread Kevin Wolf
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

  1   2   3   4   >