[Qemu-devel] [PATCH 00/12] block: bdrv_drained_begin/end for transactions on dataplane devices

2015-10-09 Thread Fam Zheng
External I/O requests mustn't come in while we're in the middle of a QMP transaction. This series adds bdrv_drained_begin and bdrv_drained_end around "prepare" and "cleanup" in the transaction actions to make sure that. Note that "backup" action already starts the block job coroutine in prepare, a

[Qemu-devel] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients

2015-10-09 Thread Fam Zheng
Signed-off-by: Fam Zheng --- aio-posix.c | 3 ++- aio-win32.c | 3 ++- async.c | 42 ++ include/block/aio.h | 30 ++ 4 files changed, 76 insertions(+), 2 deletions(-) diff --git a/aio-posix.c b/aio-

[Qemu-devel] [PATCH 03/12] nbd: Mark fd handlers client type as "external"

2015-10-09 Thread Fam Zheng
So we could distinguish it from internal used fds, thus avoid handling unwanted events in nested aio polls. Signed-off-by: Fam Zheng --- include/block/aio.h | 1 + nbd.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/block/aio.h b/include/block/aio

[Qemu-devel] [PATCH 07/12] block: Add "drained begin/end" for transactional external snapshot

2015-10-09 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. Signed-off-by: Fam Zheng --- blockdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 32b04b4..90f1e15 100644 --

[Qemu-devel] [PATCH 02/12] aio: Save fd client type to AioHandler

2015-10-09 Thread Fam Zheng
So it can be used by aio_poll later. Signed-off-by: Fam Zheng --- aio-posix.c | 2 ++ aio-win32.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/aio-posix.c b/aio-posix.c index 56f2bce..d25fcfc 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -25,6 +25,7 @@ struct AioHandler IOHandler

[Qemu-devel] [PATCH 04/12] dataplane: Mark host notifiers' client type as "external"

2015-10-09 Thread Fam Zheng
They will be excluded by type in the nested event loops in block layer, so that unwanted events won't be processed there. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 4 ++-- hw/scsi/virtio-scsi-dataplane.c | 16 2 files changed, 10 insertions(+), 10 deletions

Re: [Qemu-devel] [PATCH 1/5] hw/dma/pxa2xx: Remove superfluous memset

2015-10-09 Thread Thomas Huth
On 08/10/15 22:59, Eric Blake wrote: > On 10/08/2015 01:35 PM, Thomas Huth wrote: >> g_malloc0 already clears the memory, so no need for >> the additional memset here. >> >> Signed-off-by: Thomas Huth >> --- >> hw/dma/pxa2xx_dma.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/dma/

[Qemu-devel] [PATCH 11/12] block: Introduce BlockDriver.bdrv_drain callback

2015-10-09 Thread Fam Zheng
Drivers can have internal request sources that generates IO, like the need_check_timer in QED. Since we want quiesced periods that contain nested event loops in block layer, we need to have a way to disable such event sources. Block drivers must implement the "bdrv_drain" callback if it has any in

[Qemu-devel] [PATCH 01/12] aio: Introduce "type" in aio_set_fd_handler and aio_set_event_notifier

2015-10-09 Thread Fam Zheng
The parameter is added but not used. Signed-off-by: Fam Zheng --- aio-posix.c | 4 ++- aio-win32.c | 2 ++ async.c | 3 ++- block/curl.c| 14 +- block/iscsi.c | 9 +++ block/linu

[Qemu-devel] [PATCH 10/12] block: Add "drained begin/end" for internal snapshot

2015-10-09 Thread Fam Zheng
This ensures the atomicity of the transaction by avoiding processing of external requests such as those from ioeventfd. state->bs is assigned right after bdrv_drained_begin. Because it was used as the flag for deletion or not in abort, now we need a separate flag - InternalSnapshotState.created.

[Qemu-devel] [PULL 05/11] virtio-gpu: change licence from GPLv2 to GPLv2+

2015-10-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-pci.c | 4 ++-- hw/display/virtio-gpu.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c index 5bc62cf..eef137f 100644 --- a/hw/display/virtio-gpu-pci.c +++ b

[Qemu-devel] [RFC v1 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-09 Thread Bharata B Rao
Accommodate enough space in hotplug memory region so that it will be possible to align memory in each slot to 256M. When PowerPC memory hotplug enables inter-dimm gaps, then we could end up having unused/unassigned 256M memory chuck between DIMMs in the hotplug memory region. Hence create DRC objec

Re: [Qemu-devel] [PATCH] block: switch from g_slice allocator to malloc

2015-10-09 Thread Paolo Bonzini
On 08/10/2015 11:41, Kevin Wolf wrote: > Am 08.10.2015 um 10:54 hat Stefan Hajnoczi geschrieben: >> On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote: >>> Simplify memory allocation by sticking with a single API. GSlice >>> is not that fast anyway (tcmalloc/jemalloc are better). >>>

Re: [Qemu-devel] [PATCH] block: switch from g_slice allocator to malloc

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 09:49 hat Paolo Bonzini geschrieben: > On 08/10/2015 11:41, Kevin Wolf wrote: > > Am 08.10.2015 um 10:54 hat Stefan Hajnoczi geschrieben: > >> On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote: > >>> Simplify memory allocation by sticking with a single API. GSlice > >>

Re: [Qemu-devel] [PATCH 4/5] tests/i44fx-test: No need for zeroing memory before memset

2015-10-09 Thread Markus Armbruster
Laszlo Ersek writes: > On 10/08/15 21:35, Thomas Huth wrote: >> Change a g_malloc0 into g_malloc since the following >> memset fills the whole buffer anyway. >> >> Cc: Laszlo Ersek >> Signed-off-by: Thomas Huth >> --- >> tests/i440fx-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PULL 08/11] virtio-gpu: add cursor update tracepoint

2015-10-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu.c | 9 - trace-events| 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 0f8d35c..a836ce3 100644 --- a/hw/display/vir

[Qemu-devel] [PULL 02/11] sdl2: stop flickering

2015-10-09 Thread Gerd Hoffmann
Optimizing updates by copying the dirty rectangle only do not work because of double-buffering. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Reviewed-by: Max Reitz --- ui/sdl2-2d.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c ind

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot to the seccomp sandbox

2015-10-09 Thread Markus Armbruster
namn...@sigaint.org writes: >> ps.: the threads are still being broken by your emails and it's a pain >> to track down all of them in order to read. Please fix it. > > I'm really sorry, I am not able to sign up to Google because I don't have a > cell number. I'll try using Sigaint. Does it work no

[Qemu-devel] [PULL 00/11] virtio-gpu+gtk: add 3d rendering support

2015-10-09 Thread Gerd Hoffmann
Hi, Here comes the 3d rendering support for virtio-gpu, together with the support bits in the gtk ui. There are also some ui bugfixes. sdl2 is expected to follow shortly, once we've pinned down one remaining display issue, so it'll be there for 2.5 too. spice support is next in the queue, but

[Qemu-devel] [PULL 03/11] ui/console: add opengl context and scanout support interfaces.

2015-10-09 Thread Gerd Hoffmann
Add callbacks for opengl context management and scanout texture configuration to DisplayChangeListenerOps. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/console.h | 37 + ui/console.c | 67 +

[Qemu-devel] [PULL 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov

2015-10-09 Thread Gerd Hoffmann
For symmetry reasons: virtio_gpu_create_mapping_iov() allocates it so virtio_gpu_cleanup_mapping_iov() should free it, otherwise it's easy to miss a free() needed and leak memory. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- hw/display/virtio-gpu.c | 3 +-- 1 file changed, 1 insertio

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-09 Thread Greg Kurz
On Wed, 07 Oct 2015 14:20:28 +0530 "Aneesh Kumar K.V" wrote: > Stefan Hajnoczi writes: > > > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: > >> If the user tries to hot unplug a virtio-9p device, it seems to succeed but > >> in fact: > >> - virtio-9p coroutines thread pool and asyn

[Qemu-devel] [PULL 11/11] gtk/opengl: add opengl context and scanout support (GtkGLArea)

2015-10-09 Thread Gerd Hoffmann
This allows virtio-gpu to render in 3d mode. Uses native opengl support which is present in gtk versions 3.16 and newer. Signed-off-by: Gerd Hoffmann --- configure| 8 ++ include/ui/gtk.h | 23 ++ ui/Makefile.objs | 5 ++ ui/gtk-gl-area.c | 223 ++

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

2015-10-09 Thread Li, Liang Z
> > Some cleanup operations take long time during the pause and copy > > stage, especially with the KVM patch 3ea3b7fa9af067, do these > > operations after the completion of live migration can help to reduce VM > downtime. > > > > Ony the first patch changes the behavior, the rest 3 patches are for

[Qemu-devel] [PULL 09/11] opengl: add egl-context.[ch] helpers

2015-10-09 Thread Gerd Hoffmann
Add helper functions to manage opengl contexts using egl. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/egl-context.h | 14 ++ ui/Makefile.objs | 1 + ui/egl-context.c | 34 ++ 3 files changed, 49 insertio

[Qemu-devel] [PULL 06/11] virtio-gpu: update headers for virgl/3d

2015-10-09 Thread Gerd Hoffmann
Sync with linux kernel headers with virgl/3d patches applied. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/standard-headers/linux/virtio_gpu.h | 112 +++- 1 file changed, 111 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/l

[Qemu-devel] Stick to loops (was: [PATCH v3 1/5] qom: introduce object_property_foreach method)

2015-10-09 Thread Markus Armbruster
Eric Blake writes: > On 10/08/2015 08:09 AM, Daniel P. Berrange wrote: >> Some users of QOM need to be able to iterate over properties >> defined against an object instance. Currently they are just >> directly using the QTAIL macros against the object properties >> data structure. >> >> This is

[Qemu-devel] [PATCH v3 09/16] block: Split bdrv_move_feature_fields()

2015-10-09 Thread Kevin Wolf
After bdrv_swap(), some fields must be moved back to their original BDS to compensate for the effects that a swap of the contents of the objects has while keeping the old addresses. Other fields must be moved back because they should logically be moved and must stay on top When replacing bdrv_swap

[Qemu-devel] [PATCH v3 01/16] block: Introduce BDS.file_child

2015-10-09 Thread Kevin Wolf
Store the BdrvChild for bs->file. At this point, bs->file_child->bs just duplicates the bs->file pointer. Later, it will completely replace it. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block.c | 12 +---

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2015-10-09 Thread Peter Maydell
On 9 October 2015 at 10:15, Stefan Hajnoczi wrote: > The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151007.0' > into staging (2015-10-08 16:50:34 +0100) > > are available in the git repository at

[Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

2015-10-09 Thread Pavel Fedin
This allows to override default affinity IDs on a per-machine basis, and possibility to retrieve IDs will be used by vGICv3 live migration code. Signed-off-by: Pavel Fedin --- Since this popped up several times on the mailing list, i decided to publish this early. --- target-arm/cpu.c | 1 + 1

[Qemu-devel] [PATCH v3 14/16] blockjob: Store device name at job creation

2015-10-09 Thread Kevin Wolf
Some block jobs change the block device graph on completion. This means that the device that owns the job and originally was addressed with its device name may no longer be what the corresponding BlockBackend points to. Previously, the effects of bdrv_swap() ensured that the job was (at least part

[Qemu-devel] [PATCH v3 00/16] block: Get rid of bdrv_swap()

2015-10-09 Thread Kevin Wolf
bdrv_swap() has always been an ugly hack that we would rather have avoided. When it was introduced, we simply didn't have the infrastructure to update pointers instead of transplanting the contents of BDS object, so we grudgingly added bdrv_swap() as a quick solution. Meanwhile, most of the infras

Re: [Qemu-devel] [PATCH 0/4] AMD IOMMU v1

2015-10-09 Thread David kiarie
On Fri, Oct 9, 2015 at 10:17 AM, Valentine Sinitsyn wrote: > Hi David, > > Thanks for your efforts. > > > On 09.10.2015 07:53, David Kiarie wrote: >> >> David (4): >>hw/core: Add iommu to machine properties >>hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs >>hw/i386: Introduce AMD IOMMU

[Qemu-devel] [PATCH v3 15/16] block: Add and use bdrv_replace_in_backing_chain()

2015-10-09 Thread Kevin Wolf
This cleans up the mess we left behind in the mirror code after the previous patch. Instead of using bdrv_swap(), just change pointers. The interface change of the mirror job that callers must consider is that after job completion, their local BDS pointers still point to the same node now. qemu-im

[Qemu-devel] [PATCH v3 02/16] vmdk: Use BdrvChild instead of BDS for references to extents

2015-10-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block/vmdk.c | 99 +++- 1 file changed, 51 insertions(+), 48 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index be0d640..970

Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-10-09 Thread Stefan Hajnoczi
On Wed, Oct 07, 2015 at 10:43:40PM +0800, Xiao Guangrong wrote: > > > On 10/07/2015 10:02 PM, Stefan Hajnoczi wrote: > >On Wed, Aug 26, 2015 at 06:49:35PM +0800, Xiao Guangrong wrote: > >>On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote: > >>>On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong

[Qemu-devel] [Bug 1504528] [NEW] qemu shows glib-warning with the new glib2 2.46

2015-10-09 Thread Tom Yan
Public bug reported: qemu shows the following warning with glib2 2.46.0: [tom@localhost ~]$ qemu-system-x86_64 (process:4222): GLib-WARNING **: gmem.c:482: custom memory allocation vtable not supported fwiw process 4222 is qemu-system-x86_64 ** Affects: qemu Importance: Undecided

Re: [Qemu-devel] [PATCH 0/4] AMD IOMMU v1

2015-10-09 Thread David kiarie
On Fri, Oct 9, 2015 at 3:24 PM, Valentine Sinitsyn wrote: > On 09.10.2015 17:22, David kiarie wrote: >> >> On Fri, Oct 9, 2015 at 10:17 AM, Valentine Sinitsyn >> wrote: >>> >>> Hi David, >>> >>> Thanks for your efforts. >>> >>> >>> On 09.10.2015 07:53, David Kiarie wrote: David (4)

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-09 Thread Greg Kurz
On Fri, 9 Oct 2015 10:36:56 +0300 "Michael S. Tsirkin" wrote: > On Fri, Oct 09, 2015 at 09:23:49AM +0200, Greg Kurz wrote: > > On Wed, 07 Oct 2015 14:20:28 +0530 > > "Aneesh Kumar K.V" wrote: > > > > > Stefan Hajnoczi writes: > > > > > > > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz w

[Qemu-devel] [PATCH v3 07/16] block: Convert bs->backing_hd to BdrvChild

2015-10-09 Thread Kevin Wolf
This is the final step in converting all of the BlockDriverState pointers that block drivers use to BdrvChild. After this patch, bs->children contains the full list of child nodes that are referenced by a given BDS, and these children are only referenced through BdrvChild, so that updating the poi

[Qemu-devel] [PATCH 0/2] Hyper-V synthetic interrupt controller

2015-10-09 Thread Denis V. Lunev
This patchset implements the KVM part of the synthetic interrupt controller (synic) which is a building block of the Hyper-V paravirtualized device bus (vmbus). Synic is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each can

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Paolo Bonzini
On 09/10/2015 14:45, Marc-André Lureau wrote: > Hi > > - Original Message - >> Hello! >> >>> file_ram_alloc() only allocates with temporary files, even when using >>> share=true. >> >> Yes. I wonder, what's the purpose of share=true then. > > Paolo added it, I am not sure either. It i

[Qemu-devel] [PATCH v3 11/16] block-backend: Add blk_set_bs()

2015-10-09 Thread Kevin Wolf
It allows changing the BlockDriverState that a BlockBackend points to. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block/block-backend.c | 17 + include/block/block_int.h | 2 ++ 2 files changed, 19 insertions(+)

Re: [Qemu-devel] [PATCH v2 1/2] update-linux-headers: Rename SW_MAX to SW_MAX_

2015-10-09 Thread Gerd Hoffmann
On Do, 2015-10-08 at 18:11 +0200, Markus Armbruster wrote: > The next commit will compile hw/input/virtio-input.c and > hw/input/virtio-input-hid.c even when CONFIG_LINUX is off. These > files include both "include/standard-headers/linux/input.h" and > then. Doesn't work, because both define SW_

Re: [Qemu-devel] [PATCH v2 05/16] block: Convert bs->file to BdrvChild

2015-10-09 Thread Kevin Wolf
Am 08.10.2015 um 12:23 hat Fam Zheng geschrieben: > On Thu, 10/01 15:13, Kevin Wolf wrote: > > @@ -1935,6 +1932,11 @@ void bdrv_close(BlockDriverState *bs) > > bdrv_unref(backing_hd); > > } > > > > +if (bs->file != NULL) { > > +bdrv_unref_child(bs, bs->fi

Re: [Qemu-devel] [PATCH v10 00/10] Block replication for continuous checkpoints

2015-10-09 Thread Stefan Hajnoczi
On Wed, Oct 07, 2015 at 02:39:51PM +0800, Wen Congyang wrote: > Ping... Added to my todo list. Will review on Monday. Stefan

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Fix CPU breakpoint handling

2015-10-09 Thread Sergey Fedorov
On 08.10.2015 21:40, Peter Maydell wrote: > On 28 September 2015 at 11:07, Sergey Fedorov wrote: >> A QEMU breakpoint match is not definitely an architectural breakpoint >> match. If an exception is generated unconditionally during translation, >> it is hardly possible to ignore it in the debug ex

Re: [Qemu-devel] [PATCH v2 07/16] block: Convert bs->backing_hd to BdrvChild

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 03:39 hat Fam Zheng geschrieben: > On Thu, 10/01 15:13, Kevin Wolf wrote: > > This is the final step in converting all of the BlockDriverState > > pointers that block drivers use to BdrvChild. > > > > After this patch, bs->children contains the full list of child nodes > > that ar

[Qemu-devel] [PULL 3/5] virtio dataplane: adapt dataplane for virtio Version 1

2015-10-09 Thread Stefan Hajnoczi
From: Pierre Morel Let dataplane allocate different region for the desc/avail/used ring regions. Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail rings accordingly. Signed-off-by: Pierre Morel Tested-by: Greg Kurz Signed-off-by: Greg Kurz Message-id: 1441625636-23773-1-git

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Fix CPU breakpoint handling

2015-10-09 Thread Sergey Fedorov
On 09.10.2015 17:00, Peter Maydell wrote: > On 9 October 2015 at 14:53, Sergey Fedorov wrote: >> On 08.10.2015 21:40, Peter Maydell wrote: >>> On 28 September 2015 at 11:07, Sergey Fedorov wrote: A QEMU breakpoint match is not definitely an architectural breakpoint match. If an exceptio

Re: [Qemu-devel] [PATCH v7 09/14] qapi: Track owner of each object member

2015-10-09 Thread Markus Armbruster
Eric Blake writes: > Future commits will migrate semantic checking away from parsing > and over to the various QAPISchema*.check() methods. But to > report an error message about an incorrect semantic use of a > member of an object type, it helps to know which type, command, > or event owns the

[Qemu-devel] [PATCH v3 06/16] block: Remove bdrv_open_image()

2015-10-09 Thread Kevin Wolf
It is unused now. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block.c | 34 -- include/block/block.h | 4 2 files changed, 38 deletions(-) diff --git a/block.c b/block.c index 8fd3

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! I have merged this PULL into our local repository and my colleague gave it a try. It seems to work, but looks like ivshmem + memdev + hugetlbfs doesn't do the right thing. Memdev does attach itself to a hugetlb, but we cannot actually share data with it. Our command line was: --- cut

Re: [Qemu-devel] [PATCH 02/12] aio: Save fd client type to AioHandler

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben: > So it can be used by aio_poll later. > > Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > file_ram_alloc() only allocates with temporary files, even when using > share=true. Yes. I wonder, what's the purpose of share=true then. > We could teach it to use an existing file instead. This is an additional > feature that could be > considered after this series, since it's not

Re: [Qemu-devel] [PULL 00/25] virtio,pc features, fixes

2015-10-09 Thread Peter Maydell
Adding Marc-André to the cc list since the mail probably hasn't got through our list server yet... On 9 October 2015 at 12:05, Peter Maydell wrote: > On 8 October 2015 at 22:16, Michael S. Tsirkin wrote: >> The following changes since commit 1d27b91723c252d9a97151dc1959cfd89c5816cb: >> >> Mer

[Qemu-devel] [PATCH v3 08/16] block: Manage backing file references in bdrv_set_backing_hd()

2015-10-09 Thread Kevin Wolf
This simplifies the code somewhat, especially when dropping whole backing file subchains. The exception is the mirroring code that does adventurous things with bdrv_swap() and in order to keep it working, I had to duplicate most of bdrv_set_backing_hd() locally. We'll get rid again of this uglines

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Marc-André Lureau
Hi - Original Message - > Hello! > > I have merged this PULL into our local repository and my colleague gave it a > try. > It seems to work, but looks like ivshmem + memdev + hugetlbfs doesn't do the > right thing. Memdev does attach itself to a hugetlb, but we cannot actually > shar

Re: [Qemu-devel] [PATCH v7 09/14] qapi: Track owner of each object member

2015-10-09 Thread Eric Blake
On 10/09/2015 07:17 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Future commits will migrate semantic checking away from parsing >> and over to the various QAPISchema*.check() methods. But to >> report an error message about an incorrect semantic use of a >> member of an object type, i

[Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller

2015-10-09 Thread Denis V. Lunev
From: Andrey Smetanin Synic is a lapic extension, which is controlled via MSRs and maintains for each vCPU - 16 synthetic interrupt "lines" (SINT's); each can be configured to trigger a specific interrupt vector optionally with auto-EOI semantics - a message page in the guest memory with

Re: [Qemu-devel] [PATCH 0/4] AMD IOMMU v1

2015-10-09 Thread Valentine Sinitsyn
On 09.10.2015 17:27, David kiarie wrote: On Fri, Oct 9, 2015 at 3:24 PM, Valentine Sinitsyn wrote: On 09.10.2015 17:22, David kiarie wrote: On Fri, Oct 9, 2015 at 10:17 AM, Valentine Sinitsyn wrote: Hi David, Thanks for your efforts. On 09.10.2015 07:53, David Kiarie wrote: David (4)

Re: [Qemu-devel] [PATCH/] checkpatch: port fix from kernel "## is not a valid modifier"

2015-10-09 Thread Paolo Bonzini
On 08/10/2015 10:05, Christian Borntraeger wrote: > From: Andy Whitcroft > > checkpatch currently loops on fpu/softfloat.c > Turns out this is fixed in the Linux version of checkpatch. > > So this is a port of Andy Whitcrofts fix from Linux, > Original commit was commit 89a883530fe7 ("checkpatch

Re: [Qemu-devel] [PATCH 4/5] tests/i44fx-test: No need for zeroing memory before memset

2015-10-09 Thread Thomas Huth
On 08/10/15 22:24, Laszlo Ersek wrote: > On 10/08/15 21:35, Thomas Huth wrote: >> Change a g_malloc0 into g_malloc since the following >> memset fills the whole buffer anyway. >> >> Cc: Laszlo Ersek >> Signed-off-by: Thomas Huth >> --- >> tests/i440fx-test.c | 2 +- >> 1 file changed, 1 insertio

Re: [Qemu-devel] [PATCH v2 2/2] target-arm: Fix CPU breakpoint handling

2015-10-09 Thread Sergey Fedorov
On 08.10.2015 21:40, Peter Maydell wrote: > Annoying corner case which I don't think we need to handle necessarily: > if you set a breakpoint on a 32-bit Thumb instruction which spans a page > boundary, and the second page is not present, we will end up taking the > page fault when I think we shoul

[Qemu-devel] [PATCH v3 10/16] block/io: Make bdrv_requests_pending() public

2015-10-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Fam Zheng --- block/io.c| 2 +- include/block/block_int.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index bf907cf..bf026a4 100644 --- a/b

[Qemu-devel] [PULL v3 07/12] libqtest: Clean up unused QTestState member sigact_old

2015-10-09 Thread Markus Armbruster
Unused since commit d766825. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <144368-12182-6-git-send-email-arm...@redhat.com> Reviewed-by: Thomas Huth --- tests/libqtest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index e51

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > Yeah, I wish to solve this quickly. Unfortunately, Andreas didn't reply to my > proposal. Tbh, I > am really tempted to just change the copyright lines, resend, and call it a > day (I could even > give him authorship after all ;) I didn't read the whole thing thoroughly, but IIRC he

[Qemu-devel] [PULL v3 03/12] memory: allow destroying a non-empty MemoryRegion

2015-10-09 Thread Markus Armbruster
From: Paolo Bonzini This is legal; the MemoryRegion will simply unreference all the existing subregions and possibly bring them down with it as well. However, it requires a bit of care to avoid an infinite loop. Finalizing a memory region cannot trigger an address space update, but memory_region_

[Qemu-devel] [PULL 4/5] block: switch from g_slice allocator to malloc

2015-10-09 Thread Stefan Hajnoczi
From: Paolo Bonzini Simplify memory allocation by sticking with a single API. GSlice is not that fast anyway (tcmalloc/jemalloc are better). Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/io.c| 4 ++-- block/mirror.c| 4 ++-- block/raw-posix.c |

[Qemu-devel] [PATCH v3 13/16] block: Implement bdrv_append() without bdrv_swap()

2015-10-09 Thread Kevin Wolf
Remember all parent nodes and just change the pointers there instead of swapping the contents of the BlockDriverState. Handling of snapshot=on must be moved further down in bdrv_open() because *pbs (which is the bs pointer in the BlockBackend) must already be set before bdrv_append() is called. Ot

Re: [Qemu-devel] [PULL 00/25] virtio,pc features, fixes

2015-10-09 Thread Peter Maydell
On 9 October 2015 at 12:05, Peter Maydell wrote: > /home/petmay01/qemu/util/memfd.c: In function ‘memfd_create’: > /home/petmay01/qemu/util/memfd.c:57:20: error: ‘__NR_memfd_create’ > undeclared (first use in this function) > return syscall(__NR_memfd_create, name, flags); >

Re: [Qemu-devel] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > +void aio_disable_enable_clients(AioContext *ctx, int clients_mask, > +bool is_disable) > +{ > +int i = 1; > +int n = 0; > +aio_context_acquire(ctx); > + > +while (client

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Pavel Fedin
Hello! > It is needed for use with vhost-user. If the file descriptor you pass > to the vhost-user server is mapped with MAP_PRIVATE, the vhost-user > server will not get the guest's memory contents. At least I think so. :) Aha, so it actually tested only when file descriptor is passed from o

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-10-09 Thread Li Chengyuan
Bader, We don't see this problem after the patch is applied. I think we can close this case. Regards, CY. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1465935 Title: kvm_irqchip_commit_routes:

Re: [Qemu-devel] [PATCH v7 10/14] qapi: Detect collisions in C member names

2015-10-09 Thread Markus Armbruster
Eric Blake writes: > Detect attempts to declare two object members that would result > in the same C member name, by keying the 'seen' dictionary off > of the C name rather than the qapi name. It also requires passing > info through some of the check() methods. > > This fixes two previously-brok

[Qemu-devel] [PULL 03/20] MAINTAINERS: Specify QAPI include and test files

2015-10-09 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <144317-29831-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f9a46ec..9bd2b8f 100644 --- a/MAINTAIN

Re: [Qemu-devel] [PATCH 3/5] hw/input/tsc210x: Remove superfluous memset

2015-10-09 Thread Thomas Huth
On 09/10/15 01:34, Eric Blake wrote: > On 10/08/2015 01:35 PM, Thomas Huth wrote: >> g_malloc0 already clears the memory, so no need for additional >> memsets here. And while we're at it, let's also remove the >> superfluous typecasts for the return values of g_malloc0. >> >> Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH 3/4] hw/i386: Introduce AMD IOMMU

2015-10-09 Thread David kiarie
On Thu, Oct 8, 2015 at 9:24 PM, Marcel Apfelbaum wrote: > On 10/09/2015 05:53 AM, David Kiarie wrote: >> >> From: David >> >> Introduce basic AMD IOMMU emulation in Qemu. IOMMU implements event >> logging and >> host translation which should allow nested PCI passthrough.It also >> implemented >>

[Qemu-devel] [PATCH 1/3] armv7-m: exit on external reset request

2015-10-09 Thread Michael Davidsaver
Implement the SYSRESETREQ bit of the AIRCR register for armv7-m (ie. cortex-m3). --- hw/intc/armv7m_nvic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c index 3ec8408..a671d84 100644 --- a/hw/intc/armv7m_nvic.c +++ b/hw/intc/

[Qemu-devel] [PULL v3 12/12] Revert "qdev: Use qdev_get_device_class() for -device , help"

2015-10-09 Thread Markus Armbruster
This reverts commit 31bed5509dfcbdfc293154ce81086a4dbd7a80b6. The reverted commit changed qdev_device_help() to reject abstract devices and devices that have cannot_instantiate_with_device_add_yet set, to fix crash bugs like -device x86_64-cpu,help. Rejecting abstract devices makes sense: they're

Re: [Qemu-devel] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients

2015-10-09 Thread Kevin Wolf
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > aio-posix.c | 3 ++- > aio-win32.c | 3 ++- > async.c | 42 ++ > include/block/aio.h | 30 ++ > 4 files changed, 7

[Qemu-devel] [PULL 15/20] qapi: Consistent generated code: prefer common labels

2015-10-09 Thread Markus Armbruster
From: Eric Blake We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch names the goto

Re: [Qemu-devel] [PULL 01/19] Add .dir-locals.el file to configure emacs coding style

2015-10-09 Thread Marc-André Lureau
Hi Similar to this file, I proposed a clang-format file. I also use emacs, but clang-format is way better at dealing with reformating, especially on a given region without touching the rest: https://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg01278.html On Thu, Oct 8, 2015 at 6:52 PM, Mi

[Qemu-devel] [PULL v3 06/12] tests: Fix how qom-test is run

2015-10-09 Thread Markus Armbruster
We want to run qom-test for every architecture, without having to manually add it to every architecture's list of tests. Commit 3687d53 accomplished this by adding it to every architecture's list automatically. However, some architectures inherit their tests from others, like this: check-qte

[Qemu-devel] [PULL v3 09/12] device-introspect-test: New, covering device introspection

2015-10-09 Thread Markus Armbruster
The test doesn't check that the output makes any sense, only that QEMU survives. Useful since we've had an astounding number of crash bugs around there. In fact, we have a bunch of them right now: a few devices crash or hang, and some leave dangling pointers behind. The test skips testing the br

[Qemu-devel] [RFC v1 2/2] spapr: Force gaps between DIMM's GPA

2015-10-09 Thread Bharata B Rao
Mapping DIMMs non contiguously allows to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html In this case guest kernel doesn't allocate buffers that can cross DIMM boundary keeping each buffer local to a DIMM. Suggested-by: Michael S. Tsirk

[Qemu-devel] [PULL 09/20] qapi: Avoid assertion failure on union 'type' collision

2015-10-09 Thread Markus Armbruster
From: Eric Blake The previous commit added two tests that triggered an assertion failure. It's fairly straightforward to avoid the failure by just outright forbidding the collision between a union's tag values and its discriminator name (including the implicit name 'kind' supplied for simple unio

[Qemu-devel] [PULL v3 05/12] macio: move DBDMA_init from instance_init to realize

2015-10-09 Thread Markus Armbruster
From: Paolo Bonzini DBDMA_init is not idempotent, and calling it from instance_init breaks a simple object_new/object_unref pair. Work around this, pending qdev-ification of DBDMA, by moving the call to realize. Reported-by: Markus Armbruster Signed-off-by: Paolo Bonzini Reviewed-by: Thomas H

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-09 Thread Marc-André Lureau
Hi - Original Message - > Hello! > > > file_ram_alloc() only allocates with temporary files, even when using > > share=true. > > Yes. I wonder, what's the purpose of share=true then. Paolo added it, I am not sure either. > > We could teach it to use an existing file instead. This is

[Qemu-devel] [PULL v3 10/12] qmp: Fix device-list-properties not to crash for abstract device

2015-10-09 Thread Markus Armbruster
Broken in commit f4eb32b "qmp: show QOM properties in device-list-properties", v2.1. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Andreas Färber Message-Id: <144368-12182-9-git-send-email-arm...@redhat.com> --- qmp.c

[Qemu-devel] [PULL 17/20] qapi: Consistent generated code: minimize push_indent() usage

2015-10-09 Thread Markus Armbruster
From: Eric Blake We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch reduces the num

[Qemu-devel] [PULL v3 02/12] virtio-input: Fix device introspection on non-Linux hosts

2015-10-09 Thread Markus Armbruster
When CONFIG_LINUX is off, devices "virtio-keyboard-device", "virtio-mouse-device", "virtio-tablet-device" and "virtio-input-host-device" aren't compiled in, yet "virtio-keyboard-pci", "virtio-mouse-pci", "virtio-tablet-pci" and "virtio-input-host-pci" still are. Attempts to introspect them crash,

[Qemu-devel] [PULL 07/11] virtio-gpu: add 3d mode and virgl rendering support.

2015-10-09 Thread Gerd Hoffmann
Add virglrenderer library detection. Add 3d mode to virtio-gpu, wire up virglrenderer library. When in 3d mode render using the new context management and texture scanout callbacks. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- configure | 32 +++ hw/display/Ma

[Qemu-devel] [PULL v3 11/12] qdev: Protect device-list-properties against broken devices

2015-10-09 Thread Markus Armbruster
Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commit f4eb32b "qmp: s

[Qemu-devel] [PULL 13/20] qapi: Consistent generated code: prefer error 'err'

2015-10-09 Thread Markus Armbruster
From: Eric Blake We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch consistently na

[Qemu-devel] [PULL 07/20] qapi: Clean up qapi.py per pep8

2015-10-09 Thread Markus Armbruster
From: Eric Blake Silence pep8, and make pylint a bit happier. Just style cleanups, plus killing a useless comment in camel_to_upper(); no semantic changes. Signed-off-by: Eric Blake Message-Id: <1443565276-4535-5-git-send-email-ebl...@redhat.com> Signed-off-by: Markus Armbruster --- scripts/

Re: [Qemu-devel] [PATCH 0/4] AMD IOMMU v1

2015-10-09 Thread Valentine Sinitsyn
On 09.10.2015 17:22, David kiarie wrote: On Fri, Oct 9, 2015 at 10:17 AM, Valentine Sinitsyn wrote: Hi David, Thanks for your efforts. On 09.10.2015 07:53, David Kiarie wrote: David (4): hw/core: Add iommu to machine properties hw/pci-host: Add AMD IOMMU to PIIX and Q35 pcs hw/

[Qemu-devel] [PATCH v8 07/27] util: add fallback for qemu_memfd_alloc()

2015-10-09 Thread marcandre . lureau
From: Marc-André Lureau Add an open/unlink/mmap fallback for system that do not support memfd (only available since 3.17, ~1y ago). This patch may require additional SELinux policies to work for enforced systems, but should fail gracefully in this case. Signed-off-by: Marc-André Lureau --- ut

[Qemu-devel] [PULL 06/20] qapi: Invoke exception superclass initializer

2015-10-09 Thread Markus Armbruster
From: Eric Blake pylint recommends that every exception class should explicitly invoke the superclass __init__, even though things seem to work fine without it. Signed-off-by: Eric Blake Message-Id: <1443565276-4535-4-git-send-email-ebl...@redhat.com> Signed-off-by: Markus Armbruster --- scri

  1   2   3   >