Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Markus Armbruster
No trace of IO_READ_PROTO and IO_WRITE_PROTO in the patch. Did you mean to send this patch with this subject? Nutan Shinde writes: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 28 +++ > hw/audio/es1370.c | 60 +-

Re: [Qemu-devel] How to build the latest Qemu on Mac OS X 10.11 (El Capitan ) ?

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 05:23, Aaron Elkins wrote: > Hi all, > > I am currently working on Mac OS X 10.11 (El Capitan), and > I want to know if I can build Qemu on it? and how? Haven't tested 10.11, but it should work (10.10 definitely does). Check the 'how to build' documentation: http://qemu.weiln

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:54 hat John Snow geschrieben: > > > On 10/06/2015 04:57 AM, Kevin Wolf wrote: > > Am 05.10.2015 um 23:15 hat John Snow geschrieben: > >> > >> > >> On 09/21/2015 08:25 AM, Peter Lieven wrote: > >>> PIO read requests on the ATAPI interface used to be sync blk requests. > >>> Thi

Re: [Qemu-devel] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-10-07 Thread Kevin Wolf
Am 06.10.2015 um 17:49 hat Alberto Garcia geschrieben: > On Tue 06 Oct 2015 05:30:07 PM CEST, Kevin Wolf wrote: > >> -options = qdict_new(); > >> -if (has_snapshot_node_name) { > >> -qdict_put(options, "node-name", > >> - qstring_from_str(snapshot_node_name)); > >>

Re: [Qemu-devel] How to get started with the source code of Qemu?

2015-10-07 Thread Thomas Huth
On 06/10/15 16:17, Aaron Elkins wrote: > Hi all, > > I am new to Qemu, and I’m extremely interested in understanding how the > source code of Qemu work. But after > I downloaded the whole project, I just lost in it, the project is too large > for me to get started. A very rough survey: - The m

Re: [Qemu-devel] [PATCH 1/4] replay: generalize ptimer event to bottom halves

2015-10-07 Thread Pavel Dovgaluk
This one is ok. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 1/4] replay: generalize ptimer

Re: [Qemu-devel] [PATCH] qobject: Replace property list with GHashTable

2015-10-07 Thread Pavel Fedin
Hello! > Hmm.. modifying a child object internally should be fine, shouldn't > it? IIUC only trying to remove it, change the key or the pointer to > the value should be problematic. The glib documentation says that "Modifying the hash table after calling this function invalidates the returned

[Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Pavel Fedin
Knock-knock! PM: I remember we had a talk that we should settle down on migration data format. Isn't it right time? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mai

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 08:57, Pavel Fedin wrote: > Knock-knock! > > PM: I remember we had a talk that we should settle down on migration data > format. Isn't it right > time? I think Christoffer has a patchset which specifies the userspace API for KVM for this, which is probably the right place

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Pavel Fedin
> I think Christoffer has a patchset which specifies the > userspace API for KVM for this, which is probably the > right place to start. Christoffer? I haven't seen anything from him, BTW, i also posted already 4 versions of this... http://www.spinics.net/lists/kvm-arm/msg16219.html http://www.s

Re: [Qemu-devel] [PATCH 2/4] more replay fixes

2015-10-07 Thread Pavel Dovgaluk
This one is ok too. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 2/4] more replay fixes >

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru > Subject: [PATCH 3/4] why is runstate_is_running needed? > > It doesn't seem correct to call it for all checkp

Re: [Qemu-devel] PING: [RFC PATCH 0/4] GICv3 live migration support

2015-10-07 Thread Christoffer Dall
On Wed, Oct 07, 2015 at 09:02:47AM +0100, Peter Maydell wrote: > On 7 October 2015 at 08:57, Pavel Fedin wrote: > > Knock-knock! > > > > PM: I remember we had a talk that we should settle down on migration data > > format. Isn't it right > > time? > > I think Christoffer has a patchset which s

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Nutan Shinde
> > Hi, > The change was to remove macros defined as IT_WRITE_PROTO and > IT_READ_PROTO. These macros were used for function definitions. So, I have > replaced these macros with actual function definitions. >

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Stefan Hajnoczi
On Tue, Oct 6, 2015 at 6:42 PM, Nutan Shinde wrote: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 28 +++ > hw/audio/es1370.c | 60 +- > hw/audio/gus.c| 26 +++--- > hw/audio/sb16.c | 66 >

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > > It is not clear what separates REPLAY_ASYNC_EVENT_BH from other async > events. It seems to be an ordering issue, but then why do input events > not have to be looked up in the queue? It would be much simple

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:14, Pavel Dovgaluk wrote: > > It doesn't seem correct to call it for all checkpoints, but why > > is it right for timerlist_run_timers? > > Because replaying shouldn't proceed when machine is stopped. Right, but VIRTUAL and VIRTUAL_RT do not proceed when the machine is stopped.

Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf

2015-10-07 Thread Daniel Fahlgren
Hi, On Mon, 2015-09-14 at 22:07 +0200, Daniel Fahlgren wrote: > This patch adds support to emulate the watchdog functionality on the > Winbond w83627thf chip. The other features of the chip are not emulated. > It has been tested with Ubuntu 6.06, 14.04 and 15.04 as guests using the > w83627hf_wdt

Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-07 Thread Aneesh Kumar K.V
Stefan Hajnoczi writes: > On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote: >> If the user tries to hot unplug a virtio-9p device, it seems to succeed but >> in fact: >> - virtio-9p coroutines thread pool and async queue are leaked >> - QEMU crashes in virtio_vmstate_change() if the user

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:21, Pavel Dovgaluk wrote: > There are two kinds of events: > - read from the log and injected immediately (user input, network input) > - read from the log and wait for corresponding event in the queue (BH) > > We cannot inject BH event immediately because we do not have any inf

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Peter Krempa
On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currenly VM Image on gluster volume is specified like thi

Re: [Qemu-devel] [PATCH] watchdog: add support to emulate winbond w83627thf

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:49, Daniel Fahlgren wrote: > Hi, > > On Mon, 2015-09-14 at 22:07 +0200, Daniel Fahlgren wrote: >> This patch adds support to emulate the watchdog functionality on the >> Winbond w83627thf chip. The other features of the chip are not emulated. >> It has been tested with Ubuntu 6.

Re: [Qemu-devel] [PATCH v2] target-tilegx: Implement v2sh* instructions

2015-10-07 Thread Richard Henderson
On 10/04/2015 10:01 PM, gang.chen.5...@gmail.com wrote: From: Chen Gang It is just according to v1sh* instructions implementation. Signed-off-by: Chen Gang Applied all, with tweeks. r~

Re: [Qemu-devel] [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly

2015-10-07 Thread Richard Henderson
On 10/04/2015 10:13 PM, Chen Gang wrote: From 0f53a45b3c29e3355cc6b2183ee084e62b86e5fe Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 4 Oct 2015 13:34:33 +0800 Subject: [PATCH v2] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly For some cases,

Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register

2015-10-07 Thread Richard Henderson
On 10/04/2015 10:15 PM, Chen Gang wrote: From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 4 Oct 2015 17:34:17 +0800 Subject: [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register Or it will cause i

Re: [Qemu-devel] [PATCH v6] target-tilegx: Support iret instruction and related special registers

2015-10-07 Thread Richard Henderson
On 10/07/2015 10:21 AM, Chen Gang wrote: From fa0950e403bbb98989117f632215ae0e698457d7 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sun, 4 Oct 2015 17:41:14 +0800 Subject: [PATCH v6] target-tilegx: Support iret instruction and related special registers EX_CONTEXT_0_0 is used for jumping addr

Re: [Qemu-devel] [PATCH v2] temp-floating-point: Use make_float32/64 and float32/64_val for the input register values

2015-10-07 Thread Richard Henderson
On 10/07/2015 01:56 AM, Chen Gang wrote: From 3655bbab04063bc0878510ab260832c7a6a2a925 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Tue, 6 Oct 2015 21:45:11 +0800 Subject: [PATCH v2] temp-floating-point: Use make_float32/64 and float32/64_val for the input register values Original implementa

[Qemu-devel] [PULL 01/19] target-tilegx: Tidy simd_helper.c

2015-10-07 Thread Richard Henderson
Using the V1 macro when we want to replicate a byte across the 8 elements of the word. Using deposit and extract for manipulating specific elements. Signed-off-by: Richard Henderson --- target-tilegx/simd_helper.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/t

[Qemu-devel] [PULL 02/19] target-tilegx: Implement v*shl, v*shru, and v*shrs instructions

2015-10-07 Thread Richard Henderson
From: Chen Gang v2sh* are implemented with helper functions; v4sh* are implmeneted with inline code. Signed-off-by: Chen Gang Message-Id: <1442872055-2836-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/helper.h | 3 +++ target-tilegx/simd_h

[Qemu-devel] [PULL 07/19] target-tilegx: Implement complex multiply instructions

2015-10-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/helper.c| 40 target-tilegx/helper.h| 3 +++ target-tilegx/translate.c | 31 ++- 3 files changed, 73 insertions(+), 1 deletion(-) diff --git a/target-tilegx/helper.c b

[Qemu-devel] [PULL 06/19] target-tilegx: Implement table index instructions

2015-10-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 3e5a8ea..9f86fd3 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/translate.c @@ -627,12 +627,2

[Qemu-devel] [PULL 00/19] Collected tilegx patches

2015-10-07 Thread Richard Henderson
85bf7: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-10-06 13:42:33 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tile-20151007 for you to fetch changes up to fec7daab3d63b7b2ca61581fffc40142b22b

[Qemu-devel] [PULL 03/19] target-tilegx: Implement v*add and v*sub instructions

2015-10-07 Thread Richard Henderson
From: Chen Gang [rth: Implement everything inline; handle v1addi and v2addi as well.] Signed-off-by: Chen Gang Message-Id: <1442873918-3394-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 137 +++--

[Qemu-devel] [PULL 04/19] target-tilegx: Implement v1multu instruction

2015-10-07 Thread Richard Henderson
From: Chen Gang Signed-off-by: Chen Gang Reviewed-by: Richard Henderson Message-Id: <1442874414-3578-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 13 + target-tilegx/translate.c

[Qemu-devel] [PULL 09/19] linux-user/syscall_defs.h: Sync the latest si_code from Linux kernel

2015-10-07 Thread Richard Henderson
From: Chen Gang They content several new macro members, also contents TARGET_N*. Signed-off-by: Chen Gang Message-Id: <1443240605-2924-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 11 +++ 1 file changed, 11 insertions(+)

[Qemu-devel] [PULL 12/19] target-tilegx: Use TILEGX_EXCP_SIGNAL instead of TILEGX_EXCP_SEGV

2015-10-07 Thread Richard Henderson
Consolidate signal handling under a single exception. Signed-off-by: Richard Henderson --- linux-user/main.c | 41 +++-- target-tilegx/cpu.c | 7 ++- target-tilegx/cpu.h | 3 +-- 3 files changed, 30 insertions(+), 21 deletions(-) diff --git a/linux-us

[Qemu-devel] [PULL 19/19] target-tilegx: Support iret instruction and related special registers

2015-10-07 Thread Richard Henderson
From: Chen Gang EX_CONTEXT_0_0 is used for jumping address, and EX_CONTEXT_0_1 is for INTERRUPT_CRITICAL_SECTION, which should only be 0 or 1 in user mode, or it will cause target SIGILL (and the patch doesn't support system mode). Signed-off-by: Chen Gang Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 15/19] target-tilegx: Implement v2sh* instructions

2015-10-07 Thread Richard Henderson
From: Chen Gang It is just according to v1sh* instructions implementation. Signed-off-by: Chen Gang Message-Id: <1443956491-26850-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 18 +- 1 file changed, 17 insertions(+)

[Qemu-devel] [PULL 05/19] target-tilegx: Implement crc instructions

2015-10-07 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/helper.c| 19 +++ target-tilegx/helper.h| 2 ++ target-tilegx/translate.c | 8 +++- 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/target-tilegx/helper.c b/target-tilegx/helper.c index a01bb8d..cad5da

[Qemu-devel] [PULL 13/19] target-tilegx: Fix a typo for mnemonic about "ld_add"

2015-10-07 Thread Richard Henderson
From: Chen Gang Signed-off-by: Chen Gang Message-Id: <1443562720-3008-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translat

Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?

2015-10-07 Thread Pavel Dovgaluk
I checked this patch. Let's leave it without runstate_is_running() call. If it will be needed later, we'll find it out. Pavel Dovgalyuk > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, October 06, 2015 11:01 PM > T

[Qemu-devel] [PULL 08/19] target-tilegx: Let x1 pipe process bpt instruction only

2015-10-07 Thread Richard Henderson
From: Chen Gang According to the related document, bpt can be only in x1 pipe. Signed-off-by: Chen Gang Message-Id: <1443224574-2718-1-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 8 +++- 1 file changed, 7 insertions(+), 1 delet

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Kevin Wolf
Am 07.10.2015 um 11:09 hat Peter Krempa geschrieben: > On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > >driver => 'gluster' (protocol name) > >volname => name of gluster volume where our VM image resides > >image-path => is the absolute path of image

[Qemu-devel] [PULL 16/19] target-tilegx: Implement v?int_* instructions.

2015-10-07 Thread Richard Henderson
From: Chen Gang Signed-off-by: Chen Gang Message-Id: <1443956491-26850-2-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/helper.h | 5 + target-tilegx/simd_helper.c | 48 + target-tilegx/translate

[Qemu-devel] [PULL 11/19] target-tilegx: Decode ill pseudo-instructions

2015-10-07 Thread Richard Henderson
From: Chen Gang Notice raise and bpt, decoding the constants embedded in the nop addil instruction in the x0 slot. [rth: Generalize TILEGX_EXCP_OPCODE_ILL to TILEGX_EXCP_SIGNAL. Drop validation of signal values.] Signed-off-by: Chen Gang Message-Id: <1443243635-4886-1-git-send-email-gang.chen.

[Qemu-devel] [PULL 14/19] target-tilegx: Handle nofault prefetch instructions

2015-10-07 Thread Richard Henderson
These are mapped onto some of the normal load instructions, when the destination is the zero register. Other load insns do fault even when targeting the zero register. Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 40 ++-- 1 file changed, 2

[Qemu-devel] [PULL 00/26] Do away with TB retranslation

2015-10-07 Thread Richard Henderson
0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20151007 for you to fetch changes up to 126d89e8cdfa3be15d51f76906eaccbcd0023f98: tcg: Adjust CODE_GEN_AVG_BLOCK_SIZE (2015-10-07 20:4

[Qemu-devel] [PULL 01/26] tcg: Rename debug_insn_start to insn_start

2015-10-07 Thread Richard Henderson
With an eye toward making it mandatory. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 2 +- target-arm/translate.c| 2 +- target-cris/translate.c | 4 ++-- target-c

[Qemu-devel] [PULL 05/26] tcg: Allow extra data to be attached to insn_start

2015-10-07 Thread Richard Henderson
With an eye toward having this data replace the gen_opc_* arrays that each target collects in order to enable restore_state_from_tb. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 52 --

[Qemu-devel] [PULL 18/19] target-tilegx: Use TILEGX_EXCP_OPCODE_UNKNOWN and TILEGX_EXCP_OPCODE_UNIMPLEMENTED correctly

2015-10-07 Thread Richard Henderson
From: Chen Gang For some cases, they are for TILEGX_EXCP_OPCODE_UNKNOWN, not for TILEGX_EXCP_OPCODE_UNIMPLEMENTED. Also for some cases, they are for TILEGX_EXCP_OPCODE_UNIMPLEMENTED, not for TILEGX_EXCP_OPCODE_UNKNOWN. When analyzing issues, the correct printing information is necessary, e.g. g

Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 08:20, Denis V. Lunev wrote: > > All calls of this hook will be from ram_save_pending(). > > At the first call of this hook we need to save the initial > size of VM memory and put the migration thread to sleep for > decent period (downtime for example). During this period > guest

[Qemu-devel] [PULL 03/26] target-*: Increment num_insns immediately after tcg_gen_insn_start

2015-10-07 Thread Richard Henderson
This does tidy the icount test common to all targets. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 ++-- target-arm/translate-a64.c| 6 +++--- target-arm/translate.c| 7 --- target-cris/translate.c

[Qemu-devel] [PULL 04/26] target-*: Introduce and use cpu_breakpoint_test

2015-10-07 Thread Richard Henderson
Reduce the boilerplate required for each target. At the same time, move the test for breakpoint after calling tcg_gen_insn_start. Note that arm and aarch64 do not use cpu_breakpoint_test, but still move the inline test down after tcg_gen_insn_start. Reviewed-by: Aurelien Jarno Reviewed-by: Pete

[Qemu-devel] [PULL 17/19] target-tilegx: Implement v2mults instruction

2015-10-07 Thread Richard Henderson
From: Chen Gang Signed-off-by: Chen Gang Message-Id: <1443956491-26850-3-git-send-email-gang.chen.5...@gmail.com> Signed-off-by: Richard Henderson --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 15 +++ target-tilegx/translate.c | 4 3 files changed, 2

[Qemu-devel] [PULL 08/26] target-mips: Add delayed branch state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-mips/cpu.h | 1 + target-mips/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index ec5f991..532b39e 100644 --- a/tar

[Qemu-devel] [PULL 06/26] target-arm: Add condexec state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-arm/cpu.h | 1 + target-arm/translate-a64.c | 2 +- target-arm/translate.c | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h

[Qemu-devel] [PULL 11/26] target-cris: Mirror gen_opc_pc into insn_start

2015-10-07 Thread Richard Henderson
This perhaps isn't ideal in terms of (ab)using the "pc" field to encode both pc and ppc + delay branch state, as one has to be aware of this when examining opcode dumps. But it preserves existing logic, which will be good for bisection, and it certainly does save storage space. Reviewed-by: Aurel

[Qemu-devel] [PULL 14/26] target-sparc: Remove gen_opc_jump_pc

2015-10-07 Thread Richard Henderson
Since jump_pc[1] is always npc + 4, we can infer after incrementing that jump_pc[1] == pc + 4. Because of that, we can encode the branch destination into a single word, and store that in npc. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sp

[Qemu-devel] [PULL 02/26] target-*: Unconditionally emit tcg_gen_insn_start

2015-10-07 Thread Richard Henderson
While we're at it, emit the opcode adjacent to where we currently record data for search_pc. This puts gen_io_start et al on the "correct" side of the marker. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 6 ++

[Qemu-devel] [PULL 09/26] target-s390x: Add cc_op state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-s390x/cpu.h | 1 + target-s390x/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 5acd54c..b927c66 100644 --- a/

[Qemu-devel] [PULL 17/26] target-*: Drop cpu_gen_code define

2015-10-07 Thread Richard Henderson
This symbol no longer exists. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/cpu.h | 1 - target-arm/cpu.h| 1 - target-cris/cpu.h | 1 - target-i386/cpu.h | 1 - target-lm32/cpu.h | 1 - target-m68k/cpu.h

[Qemu-devel] [PULL 10/26] target-sh4: Add flags state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sh4/cpu.h | 1 + target-sh4/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-sh4/cpu.h b/target-sh4/cpu.h index 6fb6321..145e5df 100644 --- a/target-s

[Qemu-devel] [PULL 07/26] target-i386: Add cc_op state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/cpu.h | 1 + target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 8926780..2b2a29d 100644 --- a/targ

Re: [Qemu-devel] [PATCH 6/8] migration: implementation of hook_ram_sync

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 08:20, Denis V. Lunev wrote: > +if (migrate_is_test()) { > +/* since no data is transfered during estimation all > + all measurements below will be incorrect. > + as well no need for delays. */ > +continue; > +} By

[Qemu-devel] [PULL 18/26] tcg: Add TCG_MAX_INSNS

2015-10-07 Thread Richard Henderson
Adjust all translators to respect it. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-arm/translate-a64.c| 3 +++ target-arm/translate.c| 6 +- target-cris/translate.c | 3 +++ t

[Qemu-devel] [PULL 12/26] target-sparc: Tidy gen_branch_a interface

2015-10-07 Thread Richard Henderson
We always pass pc2 == dc->npc and r_cond == cpu_cond, and always set is_br afterward. Infer all of that. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/translate.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deleti

[Qemu-devel] [PULL 26/26] tcg: Adjust CODE_GEN_AVG_BLOCK_SIZE

2015-10-07 Thread Richard Henderson
At present, the "average" guestimate of TB size is way too small, leading to many unused entries in the pre-allocated TB array. For a guest with 1GB ram, we're currently allocating 256MB for the array. Survey arm, alpha, aarch64, ppc, sparc, i686, x86_64 guests running on x86_64 and ppc64 hosts a

[Qemu-devel] [PULL 24/26] tcg: Allocate a guard page after code_gen_buffer

2015-10-07 Thread Richard Henderson
This will catch any overflow of the buffer. Add a native win32 alternative for alloc_code_gen_buffer; remove the malloc alternative. Signed-off-by: Richard Henderson --- translate-all.c | 210 1 file changed, 119 insertions(+), 91 deletio

[Qemu-devel] [PULL 22/26] tcg: Remove tcg_gen_code_search_pc

2015-10-07 Thread Richard Henderson
It's no longer used, so tidy up everything reached by it. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg.c | 59 +++ tcg/tcg.h | 2 -- 2 files changed, 19 insertions(+), 42 deletions(-

[Qemu-devel] [PULL 13/26] target-sparc: Split out gen_branch_n

2015-10-07 Thread Richard Henderson
Unify three copies of this code from different branch types. Fix the case when npc == DYNAMIC_PC, i.e. a branch within a delay slot. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/translate.c | 55 --

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 10:17, Nutan Shinde wrote: > > The change was to remove macros defined as IT_WRITE_PROTO and > IT_READ_PROTO. These macros were used for function definitions. So, > I have replaced these macros with actual function definitions. I think you have sent the wrong patch the

[Qemu-devel] [PULL 25/26] tcg: Check for overflow via highwater mark

2015-10-07 Thread Richard Henderson
We currently pre-compute an worst case code size for any TB, which works out to be 122kB. Since the average TB size is near 1kB, this wastes quite a lot of storage. Instead, check for overflow in between generating code for each opcode. The overhead of the check isn't measurable and wastage is mi

[Qemu-devel] [PULL 21/26] tcg: Remove gen_intermediate_code_pc

2015-10-07 Thread Richard Henderson
It is no longer used, so tidy up everything reached by it. This includes the gen_opc_* arrays, the search_pc parameter and the inline gen_intermediate_code_internal functions. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all.h

[Qemu-devel] [PULL 15/26] target-sparc: Add npc state to insn_start

2015-10-07 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-sparc/cpu.h | 1 + target-sparc/translate.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 053edd5..c68e480 100644 -

Re: [Qemu-devel] [PATCH v2 3/3] exec.c: Collect AddressSpace related fields into a CPUAddressSpace struct

2015-10-07 Thread Richard Henderson
On 10/02/2015 12:29 AM, Peter Maydell wrote: +cpu->cpu_ases = g_new0(CPUAddressSpace, 1); +cpu->cpu_ases[0].cpu = cpu; +cpu->cpu_ases[0].as = as; +cpu->cpu_ases[0].tcg_as_listener.commit = tcg_commit; +memory_listener_register(&cpu->cpu_ases[0].tcg_as_listener, as); } What

[Qemu-devel] [PULL 16/26] tcg: Merge cpu_gen_code into tb_gen_code

2015-10-07 Thread Richard Henderson
As it's only caller, this tidies things a bit. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 - translate-all.c | 131 ++-- 2 files changed, 59 insertions(+), 74 dele

[Qemu-devel] [PULL 23/26] tcg: Emit prologue to the beginning of code_gen_buffer

2015-10-07 Thread Richard Henderson
By putting the prologue at the end, we risk overwriting the prologue should our estimate of maximum TB size. Given the two different placements of the call to tcg_prologue_init, move the high water mark computation into tcg_prologue_init. Reviewed-by: Peter Maydell Signed-off-by: Richard Henders

[Qemu-devel] [PULL 19/26] tcg: Pass data argument to restore_state_to_opc

2015-10-07 Thread Richard Henderson
The gen_opc_* arrays are already redundant with the data stored in the insn_start arguments. Transition restore_state_to_opc to use data from the latter. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 +- target-a

Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

2015-10-07 Thread Richard Henderson
On 10/02/2015 10:24 PM, James Hogan wrote: Extend MIPS movcond implementation to support the SELNEZ/SELEQZ instructions introduced in MIPS r6 (where MOVN/MOVZ have been removed). Whereas the "MOVN/MOVZ rd, rs, rt" instructions have the following semantics: rd = [!]rt ? rs : rd The "SELNEZ/SEL

Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register

2015-10-07 Thread Chen Gang
On 10/7/15 17:19, Richard Henderson wrote: > On 10/04/2015 10:15 PM, Chen Gang wrote: >>> From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001 >> From: Chen Gang >> Date: Sun, 4 Oct 2015 17:34:17 +0800 >> Subject: [PATCH] target-tilegx: Let prefetch nop instructions return before

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Prasanna Kalever
Hi Peter & Kevin, Thanks for your detailed review comments. I shall try to incorporate these changes as a next patch-set. - Prasanna Kumar Kalever > On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the glus

[Qemu-devel] [PULL 20/26] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-10-07 Thread Richard Henderson
We can now restore state without retranslation. Reviewed-by: Aurelien Jarno Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 + tcg/tcg.c | 40 - tcg/tcg.h | 4 +- translate-all.c | 150

Re: [Qemu-devel] [PATCH v2] temp-floating-point: Use make_float32/64 and float32/64_val for the input register values

2015-10-07 Thread Chen Gang
On 10/7/15 17:29, Richard Henderson wrote: > On 10/07/2015 01:56 AM, Chen Gang wrote: >>> From 3655bbab04063bc0878510ab260832c7a6a2a925 Mon Sep 17 00:00:00 2001 >> From: Chen Gang >> Date: Tue, 6 Oct 2015 21:45:11 +0800 >> Subject: [PATCH v2] temp-floating-point: Use make_float32/64 and >> float32

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 11:50, Pavel Dovgaluk wrote: >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> On 07/10/2015 10:21, Pavel Dovgaluk wrote: >>> There are two kinds of events: >>> - read from the log and injected immediately (user input, network input) >>> - rea

[Qemu-devel] [PATCH 1/5] qga: drop guest_file_init helper and replace it with static initializers

2015-10-07 Thread Denis V. Lunev
This just makes code shorter and better. Signed-off-by: Denis V. Lunev Signed-off-by: Yuri Pudgorodskiy Reviewed-by: Michael Roth --- qga/commands-posix.c | 10 +++--- qga/commands-win32.c | 10 +++--- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [PATCH 4/5] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all()

2015-10-07 Thread Denis V. Lunev
From: Yuri Pudgorodskiy glib may return G_IO_STATUS_AGAIN which is actually not an error. Also fixed a bug when on incomplete write buf pointer was not adjusted. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev Reviewed-by: Michael Roth --- qga/channel-posix.c | 23 +++-

[Qemu-devel] [PATCH v3 0/5] simplified QEMU guest exec

2015-10-07 Thread Denis V. Lunev
This patchset provides simplified guest-exec functionality. The idea is simple. We drop original guest-pipe-open etc stuff and provides simple and dumb API: - spawn process (originally with stdin/stdout/stderr as /dev/null) - later simple buffer is added for this purpose That is all for now. Chan

Re: [Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-10-07 Thread Cornelia Huck
On Thu, 17 Sep 2015 18:42:57 +0200 Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > Reviewed-by: Greg Kurz > --- > v1->v2: make copyright explicit > --- > docs/virtio-migration.txt | 106 > ++ >

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/10/2015 11:50, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > >> Bonzini > >> On 07/10/2015 10:21, Pavel Dovgaluk wrote: > >>> There are two kinds of events: > >>> - read from the log a

Re: [Qemu-devel] [PATCH v5 22/38] block: Prepare for NULL BDS

2015-10-07 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > blk_bs() will not necessarily return a non-NULL value any more (unless > blk_is_available() is true or it can be assumed to otherwise, e.g. > because it is called immediately after a successful blk_new_with_bs() or > blk_new_open()). > > Signed-o

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 12:42, Pavel Dovgaluk wrote: >> > Ok, got it. I still want to understand exactly the need for the init >> > and reset checkpoints, and the placement of qemu_clock_warp calls, but >> > apart from that the patches are good to go for 2.5. Thanks for your >> > persistence! > Init chec

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 07/10/2015 12:42, Pavel Dovgaluk wrote: > >> > Ok, got it. I still want to understand exactly the need for the init > >> > and reset checkpoints, and the placement of qemu_clock_warp calls, but > >> > apart from that the patches are good to g

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-10-07 Thread Pavel Fedin
Hello! > Nudge -- have you reported this as a kernel bug against the > PCI generic driver yet? Sorry, stopped tracking this topic after option upstreaming. Just sent out patches, cc'ed to you. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [Qemu-devel] [PATCH qemu] kvm-all: Align to qemu_real_host_page_size in kvm_set_phys_mem

2015-10-07 Thread Paolo Bonzini
On 06/10/2015 05:30, Alexey Kardashevskiy wrote: > As the comment in kvm_set_phys_mem() says, KVM works in page size chunks. > However it uses hardcoded TARGET_PAGE_SIZE which is 4K on most platforms > while actual host may use different page size, for example, PPC64 hosts > use 64K system pages.

[Qemu-devel] [PATCH 5/5] qga: guest-exec simple stdin/stdout/stderr redirection

2015-10-07 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Implemented with base64-encoded strings in qga json protocol. Glib portable GIOChannel is used for data I/O. Optinal stdin parameter of guest-exec command is now used as stdin content for spawned subprocess. If capture-output bool flag is specified, guest-exec redirects

Re: [Qemu-devel] [PATCH 1/1] migration: fix expected_downtime

2015-10-07 Thread Dr. David Alan Gilbert
* Igor Redko (red...@virtuozzo.com) wrote: > On 28.09.2015 22:22, Dr. David Alan Gilbert wrote: > >* Denis V. Lunev (d...@openvz.org) wrote: > >>From: Igor Redko > >> > >>To get this estimation we must divide pending_size by bandwidth > >>according to description of expected-downtime ("qmp-command

[Qemu-devel] [PATCH 2/5] qga: guest exec functionality

2015-10-07 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Guest-exec rewriten in platform-independant style with glib spawn. Child process is spawn asynchroneously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we will add ability to spe

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 07/10/2015 10:21, Pavel Dovgaluk wrote: > > There are two kinds of events: > > - read from the log and injected immediately (user input, network input) > > - read from the log and wait for corresponding event

[Qemu-devel] [PATCH 2/2] qga: set file descriptors in qmp_guest_file_open non-blocking on Win32

2015-10-07 Thread Denis V. Lunev
From: Olga Krishtal Set fd non-blocking to avoid common use cases (like reading from a named pipe) from hanging the agent. This was missed in the original code. Restore compatibility with Posix implementation. The patch adds Win32 specific implementation of qemu_set_nonblock. On Windows OS the

[Qemu-devel] [PATCH 1/2] qga: drop hand-made guest_file_toggle_flags helper

2015-10-07 Thread Denis V. Lunev
We'd better use generic qemu_set_nonblock directly. Signed-off-by: Denis V. Lunev Reviewed-by: Yuri Pudgorodskiy CC: Michael Roth --- qga/commands-posix.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.

  1   2   3   >