Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-05 Thread Michael Tokarev
05.10.2015 08:18, Markus Armbruster wrote: > Michael Tokarev writes: > >> 25.09.2015 11:37, Shraddha Barke wrote: >>> Compress lines and remove the variable . >> >> Applied to -trivial, removing this piece of commit message: >> >> --- >>> Change made using Coccinelle script [..snip..] >> --- > >

Re: [Qemu-devel] [PATCH 21/36] misc: spelling

2015-10-05 Thread Michael Tokarev
05.10.2015 08:09, Markus Armbruster пишет: > Michael Tokarev writes: > >> 25.09.2015 19:08, Eric Blake wrote: >>> On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau [] >>> Reviewed-by: Eric Blake >> >> Note there's no S-o-b line in the original patch (whole

Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 08:18, Michael Tokarev wrote: > 05.10.2015 08:18, Markus Armbruster wrote: >> Why? I like having the semantic patch in the commit message when >> there's any chance we'll want do the same mechanical change again later. >> >> You could save space and include it by reference, t

Re: [Qemu-devel] [PATCH v5 20/48] ivshmem: simplify a bit the code

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use some more explicit variables to simplify the code. > > Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana > --- > hw/misc/ivshmem.c | 28 ++-- > 1 file changed, 14 in

Re: [Qemu-devel] [PATCH v4] linux-user/syscall.c: malloc()/calloc() to g_malloc()/g_try_malloc()/g_new0()

2015-10-05 Thread Stefan Hajnoczi
On Mon, Oct 5, 2015 at 4:32 AM, Harmandeep Kaur wrote: > Convert malloc()/calloc() calls to g_malloc()/g_try_malloc()/g_new0() > in linux-user/syscall.c file > > Signed-off-by: Harmandeep Kaur > --- > v1->v2 convert the free() call in host_to_target_semarray() > to g_free() and calls g_try_mallo

Re: [Qemu-devel] [PATCH 1/3] block: prohibit migration during BlockJobs

2015-10-05 Thread Kevin Wolf
Am 02.10.2015 um 20:17 hat John Snow geschrieben: > On 10/01/2015 02:03 PM, Paolo Bonzini wrote: > > On 01/10/2015 18:34, John Snow wrote: > >> Unless we can prove this to be safe for specific cases, > >> the default should be to prohibit migration during BlockJobs. > > > > Block jobs do not affec

Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot tothe seccomp sandbox

2015-10-05 Thread Daniel P. Berrange
On Mon, Oct 05, 2015 at 07:20:58AM +0200, Markus Armbruster wrote: > "Namsun Ch'o" writes: > > >> If we intend seccomp to protect against flaws during QEMU setup, then > >> having > >> it earlier is neccessary. eg QEMU opening a corrupt qcow2 image which might > >> exploit QEMU before the guest

Re: [Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal

2015-10-05 Thread Thomas Knauth
Hi Amit, On Tue, Sep 15, 2015 at 12:39 PM, Amit Shah wrote: > Could you please include a file in the docs/ directory that documents > how this works, so it's easier to comment on the general idea? sure, we will add this. > From 'checkpointing', I was afraid this was going to use some > checkpoi

[Qemu-devel] implement smbios support for mach-virt: triggers usual QEMU makefile bug

2015-10-05 Thread Claudio Fontana
Hi Peter, The commit "smbios: implement smbios support for mach-virt" seems to cause the usual problem in QEMU's makefiles to trigger: hw/arm/virt.c:892: undefined reference to `smbios_set_defaults' hw/arm/virt.c:895: undefined reference to `smbios_get_tables' This is IIRC the consequence of ad

[Qemu-devel] [RFC v0 2/2] spapr: Force gaps between DIMM's GPA

2015-10-05 Thread Bharata B Rao
Mapping DIMMs non contiguously allows to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html In this case guest kernel doesn't allocate buffers that can cross DIMM boundary keeping each buffer local to a DIMM. Suggested-by: Michael S. Tsirk

[Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-05 Thread Bharata B Rao
Size hotplug memory region assuming a 256MB max alignment every slot. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fc5e7d6..2ec509b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1792,6 +1792,9

[Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs

2015-10-05 Thread Bharata B Rao
The suggested way to work around the virtio bug reported here http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html is to introduce gaps between DIMMs. Igor's patchset changes the pc-dimm auto-address assignment to introduce gaps and ues the same from pc memhp. This patchset does

Re: [Qemu-devel] [PATCH 2/2] pc: memhp: force gaps between DIMM's GPA

2015-10-05 Thread Bharata B Rao
On Mon, Sep 28, 2015 at 11:13:42AM +0200, Igor Mammedov wrote: > On Mon, 28 Sep 2015 10:09:26 +0530 > Bharata B Rao wrote: > > > On Sun, Sep 27, 2015 at 04:04:06PM +0200, Igor Mammedov wrote: > > > On Sun, 27 Sep 2015 16:11:02 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Sun, Sep 27

Re: [Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal

2015-10-05 Thread Amit Shah
On (Mon) 05 Oct 2015 [10:33:01], Thomas Knauth wrote: > Hi Amit, > > On Tue, Sep 15, 2015 at 12:39 PM, Amit Shah wrote: > > Could you please include a file in the docs/ directory that documents > > how this works, so it's easier to comment on the general idea? > > sure, we will add this. Thanks

Re: [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-05 Thread Igor Mammedov
On Mon, 5 Oct 2015 14:05:23 +0530 Bharata B Rao wrote: > Size hotplug memory region assuming a 256MB max alignment every slot. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index fc5e7d6..

[Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler

2015-10-05 Thread Greg Kurz
If the user tries to hot unplug a virtio-9p device, it seems to succeed but in fact: - virtio-9p coroutines thread pool and async queue are leaked - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate This patch brings hot unplug support to virtio-9p-device. It fixes both abo

[Qemu-devel] [PATCH 1/3] virtio-9p-coth: add release function and fix init error path

2015-10-05 Thread Greg Kurz
This is preliminary work to support hotplug/unplug of virtio-9p-device. Signed-off-by: Greg Kurz --- hw/9pfs/virtio-9p-coth.c | 13 + hw/9pfs/virtio-9p-coth.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/virtio-9p-coth.c b/hw/9pfs/virtio-9p-coth

[Qemu-devel] [PATCH 0/3] virtio-9p: hotplug and migration support

2015-10-05 Thread Greg Kurz
This series brings both hoplug and migration support to virtio-9p devices. Patch 1 is preliminary work. Patch 2 brings hotplug and fixes a QEMU crash. Patch 3 brings migration (of course it still depends on the 9p to be unmounted) --- Greg Kurz (3): virtio-9p-coth: add release function and

[Qemu-devel] [PATCH 3/3] virtio-9p: add savem handlers

2015-10-05 Thread Greg Kurz
We don't support migration of mounted 9p shares. This is handled by a migration blocker. One would expect, however, to be able to migrate if the share is unmounted. Unfortunately virtio-9p-device does not register savevm handlers at all ! Migration succeeds and leaves the guest with a dangling dev

Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-05 Thread Gerd Hoffmann
On Fr, 2015-10-02 at 09:40 -0400, Kevin O'Connor wrote: > On Fri, Oct 02, 2015 at 10:09:17AM +0200, Gerd Hoffmann wrote: > > > - read four bytes from under the fw_cfg selector QEMU_CFG_KERNEL_SIZE > > > (0x0008), > > > - if it is zero,return -1 --> no kernel boot requested, > > > - if it is n

Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-05 Thread Gerd Hoffmann
On Fr, 2015-10-02 at 09:38 -0400, Kevin O'Connor wrote: > On Fri, Oct 02, 2015 at 10:16:26AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > That's fine with me. Marc - I think qemu_vmlinux_setup() in SeaBIOS > > > with the following would work: > > > > > > void qemu_vmlinux_setup(void) > > > {

[Qemu-devel] [PATCH] target-mips: Add SIGRIE instruction

2015-10-05 Thread Yongbok Kim
Add SIGRIE (Signal Reserved Instruction Exception). The instruction allows to use the 16-bit code field for software use. This instruction is introduced by and required as of Release 6. Signed-off-by: Yongbok Kim --- target-mips/translate.c | 12 +++- 1 files changed, 11 insertions(+),

Re: [Qemu-devel] [PATCH v8 00/54] Postcopy implementation

2015-10-05 Thread Dr. David Alan Gilbert
* Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > On Mon, Sep 28, 2015 at 05:51:39PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This is the 8th cut of my version of postcopy. > > > > The userfaultfd linux kernel code is now in the upstream kernel

Re: [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server

2015-10-05 Thread Claudio Fontana
Hi, On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: David Marchand > > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-b

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Mark Rutland
On Sat, Oct 03, 2015 at 07:28:05PM -0400, Gabriel L. Somlo wrote: > From: "Gabriel Somlo" > > Allow access to QEMU firmware blobs, passed into the guest VM via > the fw_cfg device, through SysFS entries. Blob meta-data (e.g. name, > size, and fw_cfg key), as well as the raw binary blob data may b

Re: [Qemu-devel] implement smbios support for mach-virt: triggers usual QEMU makefile bug

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 09:34, Claudio Fontana wrote: > Hi Peter, > > The commit "smbios: implement smbios support for mach-virt" seems to cause > the usual problem in QEMU's makefiles to trigger: > > hw/arm/virt.c:892: undefined reference to `smbios_set_defaults' > hw/arm/virt.c:895: undefined refe

Re: [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Some misc improvements to ivshmem debug. > > Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana > --- > hw/misc/ivshmem.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >

Re: [Qemu-devel] [PATCH v5 32/48] ivshmem-client: check the number of vectors

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Check the number of vectors received from the server, to avoid > out of bound array access. > > Signed-off-by: Marc-André Lureau > --- > contrib/ivshmem-client/ivshmem-client.c | 5 + > 1 file changed, 5

Re: [Qemu-devel] [PATCH v5 36/48] ivshmem: add check on protocol version in QEMU

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: David Marchand > > Send a protocol version as the first message from server, clients must > close communication if they don't support this protocol version. Older > QEMUs should be fine with this change in the protocol since they >

Re: [Qemu-devel] [PATCH v5 43/48] ivshmem: use qemu_strtosz()

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use the common qemu utility function to parse the memory size. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 36 +--- > 1 file changed, 5 insertions(+), 31 d

Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Those are mostly useful for writing tests. > > Signed-off-by: Marc-André Lureau > --- > include/glib-compat.h | 61 > +++ > 1 file changed, 61 insertions(+) >

Re: [Qemu-devel] [PATCH v5 39/48] qtest: add qtest_add_abrt_handler()

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allow a test to add abort handlers, use GHook for all handlers. > > There is currently no way to remove a handler, but it could be > later added if needed. > > Signed-off-by: Marc-André Lureau Reviewed-by: C

[Qemu-devel] [PATCH] tests: Unique test path for /string-visitor/output

2015-10-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Newer GLib's want unique test paths, and thus moan at dupes. (Seen on Fedora 23 which has glib 2.46) Uniqueify the paths. Signed-off-by: Dr. David Alan Gilbert --- tests/test-string-output-visitor.c | 16 1 file changed, 8 insertions(+), 8 delet

Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-05 Thread Marc-André Lureau
Hi On Mon, Oct 5, 2015 at 12:56 PM, Claudio Fontana wrote: > Hi, I did not find g_assertion_message in any of the exported GLIB APIs. > In fact, I found it in glib/gtestutils.h under the section "internal ABI". > This is a hint that we should not be using it right? Good point, I didn't see that.

[Qemu-devel] [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for the input register value

2015-10-05 Thread Chen Gang
>From 6bb2ed5b7046cda545f6a12721b773fde40f07f1 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Mon, 5 Oct 2015 19:12:07 +0800 Subject: [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for  the input register value Original implementation use int*_to_float32 and float32_to_int*, which

Re: [Qemu-devel] [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for the input register value

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 12:21, Chen Gang wrote: > From 6bb2ed5b7046cda545f6a12721b773fde40f07f1 Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Mon, 5 Oct 2015 19:12:07 +0800 > Subject: [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for > the input register value > > Original imp

Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 12:56, Claudio Fontana wrote: > Hi, I did not find g_assertion_message in any of the exported GLIB APIs. > In fact, I found it in glib/gtestutils.h under the section "internal ABI". > This is a hint that we should not be using it right? Since this only matters for these pre-2.46 ve

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 12:00, Mark Rutland wrote: > Some of the keys in the example look like they'd come from other sources > (e.g. the *-tables entries), while others look like kernel/bootloader > configuration options (e.g. etc/boot-fail-wait, bootorder) -- I'm > concerned about redundancy here. The r

Re: [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server

2015-10-05 Thread Marc-André Lureau
Hi On Mon, Oct 5, 2015 at 11:40 AM, Claudio Fontana wrote: > I noticed only now, but this one puts the objects in the wrong place if > BUILD_DIR != SRC_PATH, > ie it puts the ivshmem-client.o and ivshmem-server.o in the source tree > instead of the build tree. > > What about a submake in contri

Re: [Qemu-devel] [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for the input register value

2015-10-05 Thread Chen Gang
> On 5 October 2015 at 12:21, Chen Gang wrote: >> +static float32 t_to_float32 (uint32_t a) >> +{ >> + CPU_FloatU r; >> + r.l = a; >> + return r.f; >> +} > > This appears to be reimplementing make_float32(). > OK, thanks. >> + >> +static uint32_t float32_to_t(float32 a) >> +{ >> + CPU_FloatU r;

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 07:49, Markus Armbruster wrote: > Peter Maydell writes: > >> On 2 October 2015 at 18:20, Markus Armbruster wrote: >>> QMP command device-list-properties regressed in 2.1: it can crash or >>> leave dangling pointers behind. >>> >>> -device FOO,help regressed in 2.2: it no lon

Re: [Qemu-devel] [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for the input register value

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 12:54, Chen Gang wrote: >> On 5 October 2015 at 12:21, Chen Gang wrote: >> Why is the helper for a single-precision operation taking a 64-bit >> argument anyway? >> > > Oh, the register are uint64_t, so I guess the input register value are > 64-bit, too. Usually for single

Re: [Qemu-devel] [PATCH v2 03/16] blkverify: Convert s->test_file to BdrvChild

2015-10-05 Thread Alberto Garcia
On Thu 01 Oct 2015 03:13:21 PM CEST, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] temp-floating-point: Use float32_to_t and t_to_float32 for the input register value

2015-10-05 Thread Chen Gang
> From: peter.mayd...@linaro.org > On 5 October 2015 at 12:54, Chen Gang wrote: >>> On 5 October 2015 at 12:21, Chen Gang wrote: >>> Why is the helper for a single-precision operation taking a 64-bit >>> argument anyway? >>> >> >> Oh, the register are uint64_t, so I guess the input register valu

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Mark Rutland
On Mon, Oct 05, 2015 at 01:48:52PM +0200, Paolo Bonzini wrote: > > > On 05/10/2015 12:00, Mark Rutland wrote: > > Some of the keys in the example look like they'd come from other sources > > (e.g. the *-tables entries), while others look like kernel/bootloader > > configuration options (e.g. etc/

Re: [Qemu-devel] [PATCH v2 05/16] block: Convert bs->file to BdrvChild

2015-10-05 Thread Alberto Garcia
On Thu 01 Oct 2015 03:13:23 PM CEST, Kevin Wolf wrote: > This patch removes the temporary duplication between bs->file and > bs->file_child by converting everything to BdrvChild. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Gabriel L. Somlo
On Mon, Oct 05, 2015 at 11:00:36AM +0100, Mark Rutland wrote: > On Sat, Oct 03, 2015 at 07:28:05PM -0400, Gabriel L. Somlo wrote: > > From: "Gabriel Somlo" > > > > Allow access to QEMU firmware blobs, passed into the guest VM via > > the fw_cfg device, through SysFS entries. Blob meta-data (e.g.

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Gabriel L. Somlo
On Mon, Oct 05, 2015 at 01:23:33PM +0100, Mark Rutland wrote: > On Mon, Oct 05, 2015 at 01:48:52PM +0200, Paolo Bonzini wrote: > > > > > > On 05/10/2015 12:00, Mark Rutland wrote: > > > Some of the keys in the example look like they'd come from other sources > > > (e.g. the *-tables entries), whi

[Qemu-devel] [PATCH] checkpatch: allow open braces on typedef lines

2015-10-05 Thread Paolo Bonzini
The style here seems to be split according to the maintainer, but traditionally open braces were placed on typedef lines. Suggested-by: Peter Maydell Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/ch

[Qemu-devel] [PATCH] target-mips: Add more reg numbers for RDHWR

2015-10-05 Thread Yongbok Kim
Add more register numbers for RDHWR Add check_hwrena() to simplify access control checkings. Add RDHWR support to microMIPS R6 Signed-off-by: Yongbok Kim --- target-mips/cpu.h |1 + target-mips/helper.h|2 + target-mips/op_helper.c | 63 +--

Re: [Qemu-devel] [PATCH v2 07/16] block: Convert bs->backing_hd to BdrvChild

2015-10-05 Thread Alberto Garcia
On Thu 01 Oct 2015 03:13:25 PM CEST, Kevin Wolf wrote: > This is the final step in converting all of the BlockDriverState > pointers that block drivers use to BdrvChild. > > After this patch, bs->children contains the full list of child nodes > that are referenced by a given BDS, and these children

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Mark Rutland
> > I'm not sure I follow what the difficulty with supporting DT in addition > > to ACPI is? It looks like all you need is a compatible string and a reg > > entry. > > Bearing in mind that I have almost no experience with arm: > > I started out by probing all possible port-io and mmio locations w

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Gabriel L. Somlo
On Mon, Oct 05, 2015 at 01:50:47PM +0100, Peter Maydell wrote: > On 5 October 2015 at 13:40, Gabriel L. Somlo wrote: > > In addition, Michael's comment earlier in the thread suggests that > > even my current acpi version isn't sufficiently "orthodox" w.r.t. > > ACPI, and I should be providing the

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 14:50, Peter Maydell wrote: > If you want to try to support "firmware might also be reading > fw_cfg at the same time as the kernel" this is a (painful) > problem regardless of how the kernel figures out whether a > fw_cfg device is present. I had assumed that one of the design > as

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Laurent Vivier
no more comments, it should mean it's ok ? Can someone merge this or just say "stop this, I don't want that"... Laurent On 14/09/2015 20:01, Laurent Vivier wrote: > This series allows to only display a given list of help sections. > > v5: introduce "-help[=LIST]", move help of help to the end "

Re: [Qemu-devel] [PATCHv3 5/7] memory: Allow replay of IOMMU mapping notifications

2015-10-05 Thread Paolo Bonzini
On 30/09/2015 04:13, David Gibson wrote: > When we have guest visible IOMMUs, we allow notifiers to be registered > which will be informed of all changes to IOMMU mappings. This is used by > vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. > > However, unlike with a memor

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Gabriel L. Somlo
On Mon, Oct 05, 2015 at 01:56:47PM +0100, Mark Rutland wrote: > On Mon, Oct 05, 2015 at 08:43:46AM -0400, Gabriel L. Somlo wrote: > > On Mon, Oct 05, 2015 at 01:23:33PM +0100, Mark Rutland wrote: > > > On Mon, Oct 05, 2015 at 01:48:52PM +0200, Paolo Bonzini wrote: > > > > > > > > > > > > On 05/10

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Mark Rutland
On Mon, Oct 05, 2015 at 08:43:46AM -0400, Gabriel L. Somlo wrote: > On Mon, Oct 05, 2015 at 01:23:33PM +0100, Mark Rutland wrote: > > On Mon, Oct 05, 2015 at 01:48:52PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 05/10/2015 12:00, Mark Rutland wrote: > > > > Some of the keys in the example l

Re: [Qemu-devel] [PATCH v2 08/16] block: Manage backing file references in bdrv_set_backing_hd()

2015-10-05 Thread Alberto Garcia
On Thu 01 Oct 2015 03:13:26 PM CEST, Kevin Wolf wrote: > @@ -2428,12 +2434,9 @@ int bdrv_drop_intermediate(BlockDriverState *active, > BlockDriverState *top, > BlockDriverState *intermediate; > BlockDriverState *base_bs = NULL; > BlockDriverState *new_top_bs = NULL; > -BlkInter

Re: [Qemu-devel] [PATCH v2 11/16] block-backend: Add blk_set_bs()

2015-10-05 Thread Alberto Garcia
On Thu 01 Oct 2015 03:13:29 PM CEST, Kevin Wolf wrote: > It allows changing the BlockDriverState that a BlockBackend points to. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-05 Thread Marc-André Lureau
glib comment is now fixed: https://git.gnome.org/browse/glib/commit/?id=dabf6627886c1d21b9fe03c897809eb64ef2ac54 On Mon, Oct 5, 2015 at 1:44 PM, Paolo Bonzini wrote: > > > On 05/10/2015 12:56, Claudio Fontana wrote: >> Hi, I did not find g_assertion_message in any of the exported GLIB APIs. >> I

Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 13:40, Gabriel L. Somlo wrote: > In addition, Michael's comment earlier in the thread suggests that > even my current acpi version isn't sufficiently "orthodox" w.r.t. > ACPI, and I should be providing the hardware access routine as > an ACPI/AML routine, to avoid race conditi

[Qemu-devel] [PATCH] target-mips: Set Config5.XNP for R6 cores

2015-10-05 Thread Yongbok Kim
Set Config5.XNP for R6 cores to indicate the extended LL/SC family of instructions NOT present. Signed-off-by: Yongbok Kim --- target-mips/translate_init.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c inde

Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure

2015-10-05 Thread Paolo Bonzini
On 03/10/2015 00:41, Peter Maydell wrote: > > What I meant to ask was, do you see any reason for cpu_get_ticks() to exist? > > If no architecture besides i386 wants to use it, perhaps the code should be > > moved there. > > OTOH various non-x86 things do use the closely related cpu_get_real_ticks

Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure

2015-10-05 Thread Peter Maydell
On 5 October 2015 at 15:09, Paolo Bonzini wrote: > > > On 03/10/2015 00:41, Peter Maydell wrote: >> > What I meant to ask was, do you see any reason for cpu_get_ticks() to >> > exist? >> > If no architecture besides i386 wants to use it, perhaps the code should be >> > moved there. >> >> OTOH var

Re: [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-10-05 Thread Paolo Bonzini
On 03/10/2015 02:25, Alexey Kardashevskiy wrote: >> I think this is the aim of VMSTATE_UINT64_EQUAL() ? > > We use it only for things which cannot be set via the command line > and ideally there should be no VMSTATE_*_EQUAL. If something can be > set via the command line, then the management sof

Re: [Qemu-devel] [PATCH] target-arm: Use common CPU cycle infrastructure

2015-10-05 Thread Paolo Bonzini
On 05/10/2015 16:11, Peter Maydell wrote: > > > OTOH various non-x86 things do use the closely related > > > cpu_get_real_ticks(), > > > and the implementation of cpu_get_ticks() is very closely related to > > > the other clock code in cpus.c. > > > > cpu_get_real_ticks() is returning the host c

Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-05 Thread Claudio Fontana
On 05.10.2015 15:35, Marc-André Lureau wrote: > glib comment is now fixed: > > https://git.gnome.org/browse/glib/commit/?id=dabf6627886c1d21b9fe03c897809eb64ef2ac54 > Good! > On Mon, Oct 5, 2015 at 1:44 PM, Paolo Bonzini wrote: >> >> >> On 05/10/2015 12:56, Claudio Fontana wrote: >>> Hi, I did

Re: [Qemu-devel] [PATCH v5 41/48] tests: add ivshmem qtest

2015-10-05 Thread Claudio Fontana
On 02.10.2015 21:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Adds 4 ivshmemtests: > - single qemu instance and basic IO > - pair of instances, check memory sharing > - pair of instances with server, and MSIX > - hot plug/unplug > > A temporary shm is created as well as a

Re: [Qemu-devel] [PATCH 1/3] block: prohibit migration during BlockJobs

2015-10-05 Thread Paolo Bonzini
On 02/10/2015 20:17, John Snow wrote: > > > On 10/01/2015 02:03 PM, Paolo Bonzini wrote: >> >> >> On 01/10/2015 18:34, John Snow wrote: >>> Unless we can prove this to be safe for specific cases, >>> the default should be to prohibit migration during BlockJobs. >> >> Block jobs do not affect th

[Qemu-devel] [PATCH 3/5] qga: handle possible SIGPIPE in guest-file-write

2015-10-05 Thread Denis V. Lunev
qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec(). Signed-off-by: Denis V. Lunev Signed-off-by: Yuri

[Qemu-devel] [PATCH v2 0/5] simplified QEMU guest exec

2015-10-05 Thread Denis V. Lunev
This patchset provides simplified guest-exec functionality. The idea is simple. We drop original guest-pipe-open etc stuff and provides simple and dumb API: - spawn process (originally with stdin/stdout/stderr as /dev/null) - later simple buffer is added for this purpose That is all for now. Chan

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Marc-André Lureau
Hi On Mon, Oct 5, 2015 at 3:20 PM, Laurent Vivier wrote: > no more comments, it should mean it's ok ? > Looks good to me, and works fine. However, libvirt will need to be updated to use -help=all differently. I guess it's fine, so Reviewed-by: Marc-André Lureau > Can someone merge this or ju

[Qemu-devel] [PATCH 4/5] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all()

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy glib may return G_IO_STATUS_AGAIN which is actually not an error. Also fixed a bug when on incomplete write buf pointer was not adjusted. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev Reviewed-by: Michael Roth --- qga/channel-posix.c | 23 +++-

[Qemu-devel] [PATCH 2/5] qga: guest exec functionality

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Guest-exec rewriten in platform-independant style with glib spawn. Child process is spawn asynchroneously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we will add ability to spe

Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-10-05 Thread Peter Lieven
Am 02.10.2015 um 09:36 schrieb Gerd Hoffmann: Hi, Please have a look at: https://github.com/plieven/qemu/tree/vnc-next-2.0 Moving code to buf_adj_size and buf_req_size should go to a separate patch. The avg_size logic needs some description. Please have a look at: https://github.com/pl

[Qemu-devel] [Bug 1502934] [NEW] QEMU does not start when kvm enabled (SMM issue?)

2015-10-05 Thread Alexandre Kandalintsev
Public bug reported: Hi! QEMU stopped working after "[355023f2010c4df619d88a0dd7012b4b9c74c12c] pc: add SMM property" on my server. It says "Guest has not initialized the display (yet)." and nothing happens. But only if I use -enable-kvm. However, the problem gone after I hardcoded pc_machine_is

[Qemu-devel] [PATCH 1/5] qga: drop guest_file_init helper and replace it with static initializers

2015-10-05 Thread Denis V. Lunev
This just makes code shorter and better. Signed-off-by: Denis V. Lunev Signed-off-by: Yuri Pudgorodskiy Reviewed-by: Michael Roth --- qga/commands-posix.c | 10 +++--- qga/commands-win32.c | 10 +++--- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Daniel P. Berrange
On Mon, Oct 05, 2015 at 05:08:50PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Oct 5, 2015 at 3:20 PM, Laurent Vivier wrote: > > no more comments, it should mean it's ok ? > > > > Looks good to me, and works fine. However, libvirt will need to be > updated to use -help=all differently. I gu

Re: [Qemu-devel] QEMU+Linux ARMv7A current state

2015-10-05 Thread John Snow
On 10/03/2015 05:31 PM, Peter Crosthwaite wrote: > Hi, > > I have done an audit of the ARMv7 boards to see what can boot a > vanilla linux kernel. The basic approach is to build ARM > multi_v7_defconfig kernel and boot QEMU using the DTBs built out by > the kernel. The intersection of what mainl

Re: [Qemu-devel] CharUDP - Connection refused

2015-10-05 Thread Paolo Bonzini
On 04/10/2015 17:01, poma wrote: > > qemu-system-x86_64 ... \ > -chardev > udp,id=charserial0,host=127.0.0.1,port=4555,localaddr=127.0.0.1,localport=4556 > \ > -device isa-serial,chardev=charserial0,id=serial0 > > > # netstat -an | grep 4555 > udp0 0 127.0.0.1:4556 127.

Re: [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region

2015-10-05 Thread Thomas Huth
On 05/10/15 10:35, Bharata B Rao wrote: > Size hotplug memory region assuming a 256MB max alignment every slot. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index fc5e7d6..2ec509b 100644 > -

[Qemu-devel] [Bug 1502934] Re: QEMU does not start when kvm enabled (SMM issue?)

2015-10-05 Thread Paolo Bonzini
This is a KVM bug, not a QEMU bug. It only happens with ept=1 and unrestricted_guest=0. A workaround is to disable SMM in QEMU (-machine smm=off) or to set kvm_intel's ept parameter to 0. I'm closing the bug here because it is the wrong tracker (also I know about it, can reproduce, and hope to pro

Re: [Qemu-devel] [PATCH v5 0/2] Improve -help

2015-10-05 Thread Paolo Bonzini
On 14/09/2015 20:01, Laurent Vivier wrote: > This series allows to only display a given list of help sections. > > v5: introduce "-help[=LIST]", move help of help to the end "all" section. > Remove typo fix (already included). > v4: as proposed by Eric, provide a list of sections, restore de

Re: [Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-10-05 Thread Eric Blake
On 10/03/2015 10:59 AM, Michael Tokarev wrote: > 25.09.2015 17:36, Shraddha Barke wrote: >> Compress lines and remove the variable. > > Applied to -trivial, removing the Coccinelle script > from the commit message. Why cripple the commit message? The coccinelle recipe is useful for someone trying

Re: [Qemu-devel] [PATCH] tests: Unique test path for /string-visitor/output

2015-10-05 Thread Eric Blake
On 10/05/2015 05:04 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Newer GLib's want unique test paths, and thus moan at dupes. > (Seen on Fedora 23 which has glib 2.46) > > Uniqueify the paths. Not sure if "Uniquify" is any better spelling for a made-up word? >

[Qemu-devel] [PATCH 5/5] qga: guest-exec simple stdin/stdout/stderr redirection

2015-10-05 Thread Denis V. Lunev
From: Yuri Pudgorodskiy Implemented with base64-encoded strings in qga json protocol. Glib portable GIOChannel is used for data I/O. Optinal stdin parameter of guest-exec command is now used as stdin content for spawned subprocess. If capture-output bool flag is specified, guest-exec redirects

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-10-05 Thread Christian Pinto
Hello Peter, thanks for your comments On 01/10/2015 18:26, Peter Crosthwaite wrote: On Tue, Sep 29, 2015 at 6:57 AM, Christian Pinto wrote: Hi all, This RFC patch-series introduces the set of changes enabling the architectural elements to model the architecture presented in a previous RFC l

[Qemu-devel] [PULL 1/3] qtest/ahci: fix redundant assertion

2015-10-05 Thread John Snow
Fixes https://bugs.launchpad.net/qemu/+bug/1497711 (!ncq || (ncq && lba48)) is the same as (!ncq || lba48). The intention is simply: "If a command is NCQ, it must also be LBA48." Signed-off-by: John Snow Message-id: 1442868929-1-1-git-send-email-js...@redhat.com --- tests/libqos/ahci.c | 2

[Qemu-devel] [PULL 0/3] Ide patches

2015-10-05 Thread John Snow
The following changes since commit c0b520dfb8890294a9f8879f4759172900585995: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-02 16:59:21 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fet

[Qemu-devel] [PULL 2/3] MAINTAINERS: Small IDE/FDC touchup

2015-10-05 Thread John Snow
libqos/ahci and tests/fdc-test are under my purview also, include them in the appropriate stanzas. Signed-off-by: John Snow Message-id: 1443117055-29240-1-git-send-email-js...@redhat.com --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e3e34fb

[Qemu-devel] [PULL 3/3] qtest/ide-test: ppc64be correction for ATAPI tests

2015-10-05 Thread John Snow
the 16bit ide data register is LE by definition. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1443461938-30039-1-git-send-email-js...@redhat.com --- tests/ide-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index

[Qemu-devel] [PULL 03/12] target-i386: Convert kvm_default_*features to property/value pairs

2015-10-05 Thread Eduardo Habkost
Convert the kvm_default_features and kvm_default_unset_features arrays into a simple list of property/value pairs that will be applied to X86CPU objects when using KVM. Acked-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 8 ++--- hw/i386/pc_q35.c | 4 +-- target-i3

[Qemu-devel] [PULL 08/12] Correctly re-init EFER state during INIT IPI

2015-10-05 Thread Eduardo Habkost
From: Bill Paul When doing a re-initialization of a CPU core, the default state is to _not_ have 64-bit long mode enabled. This means the LME (long mode enable) and LMA (long mode active) bits in the EFER model-specific register should be cleared. However, the EFER state is part of the CPU envir

[Qemu-devel] [PULL 06/12] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-10-05 Thread Eduardo Habkost
From: Amit Shah There's one report of migration breaking due to missing MSR_TSC_AUX save/restore. Fix this by adding a new subsection that saves the state of this MSR. https://bugzilla.redhat.com/show_bug.cgi?id=1261797 Reported-by: Xiaoqing Wei Signed-off-by: Amit Shah CC: Paolo Bonzini CC

[Qemu-devel] [PULL 07/12] target-i386: add ABM to Haswell* and Broadwell* CPU models

2015-10-05 Thread Eduardo Habkost
From: Paolo Bonzini ABM is only implemented as a single instruction set by AMD; all AMD processors support both instructions or neither. Intel considers POPCNT as part of SSE4.2, and LZCNT as part of BMI1, but Intel also uses AMD's ABM flag to indicate support for both POPCNT and LZCNT. It has t

[Qemu-devel] [PULL 11/12] cpu/apic: drop icc bus/bridge

2015-10-05 Thread Eduardo Habkost
From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by registering its reset handler after all device are initialized. Do so and drop ~30LOC of not needed anymore

[Qemu-devel] [PULL 09/12] apic: move APIC's MMIO region mapping into APIC

2015-10-05 Thread Eduardo Habkost
From: Chen Fan When ICC bus/bridge is removed, APIC MMIO will be left unmapped since it was mapped into system's address space indirectly by ICC bridge. Fix it by moving mapping into APIC code, so it would be possible to remove ICC bus/bridge code later. Signed-off-by: Chen Fan Signed-off-by: Z

Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring

2015-10-05 Thread Dmitry Osipenko
03.10.2015 16:11, Dmitry Osipenko пишет: 20.09.2015 20:48, Peter Crosthwaite пишет: On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite wrote: On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko wrote: 05.07.2015 23:26, Peter Crosthwaite пишет: Hi Dmitry, Based on my comment earlier, this is wh

[Qemu-devel] [PULL 12/12] icc_bus: drop the unused files

2015-10-05 Thread Eduardo Habkost
From: Zhu Guihua ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu

  1   2   >