[Qemu-devel] [PATCH 14/36] monitor: remove usage of generated marshal functions

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Once the middle mode is removed, the generated marshal functions will no longer be exported. Signed-off-by: Marc-André Lureau --- monitor.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 7e8ad0c..410c3a

[Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Move the examples in the json file with the rest of the documentation to avoid duplication. Signed-off-by: Marc-André Lureau --- docs/qmp/qmp-events.txt | 664 qapi/block-core.json| 59 - qapi/block.json

[Qemu-devel] [PATCH 16/36] qmp: register qapi commands (no middle mode)

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau The marshal functions are no longer exported, they are registered in the dispatch table instead. The following patches will make use of qmp_dispatch(). This patch temporarily breaks qmp/hmp commands. Signed-off-by: Marc-André Lureau --- Makefile | 2 +- qmp-

[Qemu-devel] [PATCH 13/36] build-sys: do not generate qmp-commands-old.h

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau It's static file now. Signed-off-by: Marc-André Lureau --- Makefile.target| 7 +- qmp-commands-old.h | 683 + qmp-commands.hx| 683 - 3 files changed, 685 i

[Qemu-devel] [PATCH 18/36] qapi: remove "middle" mode

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Now that the register function is always generated, we can remove the so-called "middle" mode to the generator script. Signed-off-by: Marc-André Lureau --- scripts/qapi-commands.py | 29 + 1 file changed, 5 insertions(+), 24 deletions(-) dif

[Qemu-devel] [PATCH 19/36] qmp: implement qmp_query_commands without qmp_cmds

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau So we can get rid of the static qmp_cmds table. Signed-off-by: Marc-André Lureau --- monitor.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index bfa0329..a2eb228 100644 --- a/monitor.c +++ b/monit

[Qemu-devel] [PATCH 25/36] qmp: introduce async command type

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Learn a new type of command, QmpCommandFuncAsync. They can return later thanks to QmpReturn. This commit introduces the new types and register functions. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/dispatch.h | 5 + qapi/qmp-dispatch.c | 3 +++ q

[Qemu-devel] [PATCH 17/36] qmp: use qmp_dispatch()

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Replace the old "middle mode" dispatch code using the manually maintained table by the one generated by qapi scripts. Signed-off-by: Marc-André Lureau --- monitor.c | 316 +++--- 1 file changed, 34 insertions(+), 2

[Qemu-devel] [PATCH 21/36] misc: spelling

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 4deef29..25f9608 100644 --- a/monitor.c +++ b/monitor.c @@ -306,7 +306,7 @@ static void monitor_flush_locked(Monitor *mon) return; }

[Qemu-devel] [PATCH 34/36] console: graphic_hw_update return true if async

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Let the caller know if the update is immediate or async. Signed-off-by: Marc-André Lureau --- hw/display/qxl-render.c | 5 +++-- hw/display/qxl.c| 8 hw/display/qxl.h| 2 +- include/ui/console.h| 3 ++- ui/console.c| 14 +

[Qemu-devel] [PATCH 20/36] qmp: remove old qmp-commands table

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau The table is no longer used. Signed-off-by: Marc-André Lureau --- monitor.c | 7 - qmp-commands-old.h | 554 - 2 files changed, 561 deletions(-) delete mode 100644 qmp-commands-old.h diff --git a/monitor.c

[Qemu-devel] [PATCH 24/36] qmp: add QmpClient

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Add a new QmpClient structure holding the dispatch return callback and the list of pending QmpReturns. When a client disconnects, call qmp_client_destroy(). This will remove all pending returns from the client list, and prevent a reply from being sent later to new clients

[Qemu-devel] [PATCH 22/36] qmp: teach qmp_dispatch() to take a pre-filled QDict

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau In order to prepare for the async support, give an optionnal qdict for the dispatch call to be used for the reply. The qemu monitor will have the request "id" pre-filled. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/dispatch.h | 2 +- monitor.c

[Qemu-devel] [PATCH 36/36] console: add screendump-async

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Learn a new async command to make a correct screendump. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1230527 Signed-off-by: Marc-André Lureau --- qapi-schema.json | 21 +++- ui/console.c | 59 +++

[Qemu-devel] [PATCH 26/36] qmp: check that async command have an 'id'

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau The async support mandates that request have an 'id' (see documentation in following patch). Signed-off-by: Marc-André Lureau --- qapi/qmp-dispatch.c | 5 + 1 file changed, 5 insertions(+) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 83ecab5..73ba3a

[Qemu-devel] [PATCH 30/36] tests: change /0.15/* tests to /qmp/*

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Presumably 0.15 was the version it was first introduced, but qmp keeps evolving. There is no point in having that version has test prefix, qmp makes more sense. Signed-off-by: Marc-André Lureau --- tests/test-qmp-commands.c | 10 +- 1 file changed, 5 insertions(

[Qemu-devel] [PULL 2/9] rtl8139: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH 28/36] scripts: ensure -async commands are declared async

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau We could have arbitrary async command name, but it make sense to use a specific name to avoid confusion. Signed-off-by: Marc-André Lureau --- scripts/qapi.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index 96901ab..d614673 100

[Qemu-devel] [PATCH 27/36] scripts: learn 'async' qapi commands

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Commands with the 'async' key will be registered as async type (see previous commit), and will allow a synchronous (in command cb) or asynchronous return (when ready, in idle etc). Ex: { 'command': 'foo-async, 'data': {'arg': 'str'}, async: true } Signed-off-by: Marc-And

[Qemu-devel] [PATCH 29/36] qapi: take 'id' from request

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Copy 'id' from request to reply dict. This can be done earlier, such as done by the monitor (because the qemu monitor may reply directly without qmp_dispatch), but is now done as well in qmp_dispatch() as convenience for other users such as QGA and tests. Signed-off-by: M

[Qemu-devel] [PULL 4/9] mips: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PULL 9/9] net: remove muldiv64()

2015-09-25 Thread Laurent Vivier
muldiv64() is used to convert nanoseconds to microseconds. x = muldiv64(qemu_clock_get_ns(..), 100, get_ticks_per_sec()); As get_ticks_per_sec() is 10^9, it can be replaced by: x = qemu_clock_get_us(..); Signed-off-by: Laurent Vivier Reviewed-by: Stefan Hajnoczi --- net/dump.c |

[Qemu-devel] [PATCH 31/36] tests: add /qmp/dispatch_cmd_async test

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Check that async disaptch works. Signed-off-by: Marc-André Lureau --- tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 5 +++ tests/test-qmp-commands.c | 61 + 3 files changed, 68 i

[Qemu-devel] [PATCH 23/36] qmp: use a return callback for the command reply

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Introduce QmpDispatchReturn, a callback called when a command reply is ready to be sent. Future patches will extend the concept to allow async replies. QmpReturn and associated functions is used internally for sync fonctions, but will be the basis of a async context (the

[Qemu-devel] [PULL 8/9] bt: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds. As get

[Qemu-devel] [PATCH 35/36] console: add graphic_hw_update_done()

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Add a function to be called when an async graphic update is done. Signed-off-by: Marc-André Lureau --- hw/display/qxl-render.c | 9 +++-- include/ui/console.h| 1 + ui/console.c| 4 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH 32/36] qmp: update qmp-spec about async capability

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/qmp/qmp-spec.txt | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/docs/qmp/qmp-spec.txt b/docs/qmp/qmp-spec.txt index 4c28cd9..f1af7f7 100644 --- a/docs/qmp/qmp-spec.txt +++ b/docs/qmp/qmp-sp

[Qemu-devel] [PULL 7/9] hpet: remove muldiv64()

2015-09-25 Thread Laurent Vivier
hpet defines a clock period in femtoseconds but then converts it to nanoseconds to use the internal timers. We can define the period in nanoseconds and use it directly, this allows to remove muldiv64(). We only need to convert the period to femtoseconds to put it in internal hpet capability regis

[Qemu-devel] [PATCH 33/36] monitor: add 'async' capability

2015-09-25 Thread marcandre . lureau
From: Marc-André Lureau Existing clients may not handle async replies very well. In order to avoid the potential issues, let's introduce a capability that the client must declare in order to make use of async commands. Eventually, client should already handle unexpected events after a command is

Re: [Qemu-devel] [PATCH 05/16] block: Convert bs->file to BdrvChild

2015-09-25 Thread Alberto Garcia
On Thu 17 Sep 2015 03:48:09 PM CEST, Kevin Wolf wrote: > @@ -1929,6 +1925,11 @@ void bdrv_close(BlockDriverState *bs) > bdrv_unref(backing_hd); > } > > +if (bs->file != NULL) { > +bdrv_unref(bs->file->bs); > +bs->file = NULL; > +} >

[Qemu-devel] [PULL 3/9] pcnet: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PULL 0/9] muldiv64 queue

2015-09-25 Thread Laurent Vivier
The following changes since commit 8a47d575dfac0f6675e2ac56c5921cc520d021a6: Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20150924' into staging (2015-09-24 22:09:41 +0100) are available in the git repository at: g...@github.com:vivier/qemu.git tags/pull-muldiv64-201

Re: [Qemu-devel] [PATCH 0/2] sheepdog driver update

2015-09-25 Thread Jeff Cody
On Tue, Sep 01, 2015 at 12:03:08PM +0900, Hitoshi Mitake wrote: > This patchset has two patches. The first one is a defensive purpose > for rare cases. It is an improvement of the previous commit > 96b14ff85acf. The second one is refining discard operation caused by > fstrim command, etc. Current s

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-25 Thread Markus Armbruster
Jason Wang writes: > On 09/24/2015 07:52 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 2bada60..546500a 100644 > --- a/qapi-sch

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

2015-09-25 Thread Eric Blake
On 09/25/2015 02:08 AM, Yang Hongyang wrote: > This patchset addressed Markus comment on netfilter patch > series, most of them are comment fixes. > > It is based on jason's net tree: > https://github.com/jasowang/qemu/tree/net If that tree is not yet merged mainline, wouldn't it be better to squ

[Qemu-devel] [PULL 1/9] i6300esb: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

2015-09-25 Thread Markus Armbruster
Thomas Huth writes: > On 24/09/15 20:57, Markus Armbruster wrote: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> >> This breaks at least device-list-properties, because >> qmp_device_list_properties()

[Qemu-devel] [PATCH 0/2] ps: memhp: enforce gaps between DIMMs

2015-09-25 Thread Igor Mammedov
it's a simplier way suggested by Michael S. Tsirkin to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html where virtio can't handle buffer that crosses border between 2 DIMM's (i.e. 2 MemoryRegions). idea is to leave gaps between DIMMs, ma

Re: [Qemu-devel] [RFC 0/6] Throttle event VSERPORT_CHANGE separately by "id"

2015-09-25 Thread Marc-André Lureau
Hi On Fri, Sep 25, 2015 at 4:00 PM, Markus Armbruster wrote: > VSERPORT_CHANGE is emitted when the guest opens or closes a > virtio-serial port. The event's member "id" identifies the port. > > When several events arrive quickly, throttling drops all but the last > of them. Because of that, a Q

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-25 Thread Eric Blake
On 09/25/2015 07:41 AM, Alberto Garcia wrote: > Disabling I/O limits from a BDS also drains all pending throttled > requests, so it should be done at the beginning of bdrv_close() with > the rest of the bdrv_drain() calls before the BlockDriver is closed. Can this be abused? If I have a guest runn

[Qemu-devel] [PATCH 1/2] memhp: extend address auto assignment to support gaps

2015-09-25 Thread Igor Mammedov
setting gap to non 0 value will make sparse DIMM address auto allocation, leaving gaps between a new DIMM address and preceeding existing DIMM. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 2 +- hw/mem/pc-dimm.c | 13 +++-- hw/ppc/spapr.c | 2 +- includ

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-25 Thread Alberto Garcia
On Fri 25 Sep 2015 04:22:26 PM CEST, Eric Blake wrote: >> Disabling I/O limits from a BDS also drains all pending throttled >> requests, so it should be done at the beginning of bdrv_close() with >> the rest of the bdrv_drain() calls before the BlockDriver is closed. > > Can this be abused? If I h

[Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

2015-09-25 Thread Christopher Covington
This should help clarify the purpose of the function that returns the host system's CPU cycle count. Signed-off-by: Christopher Covington --- bsd-user/main.c | 2 +- cpus.c| 6 +++--- hw/intc/xics.c| 2 +- hw/ppc/ppc.c | 4 ++-- include/

Re: [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing

2015-09-25 Thread Eric Blake
On 09/25/2015 06:39 AM, Andreas Färber wrote: > All integers would get parsed by strtoll(), not handling the case of > UINT64 properties with the most significient bit set. > > Implement a .type_uint64 visitor callback, reusing the existing > parse_str() code through a new argument, using strtoull

Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case

2015-09-25 Thread Eric Blake
On 09/25/2015 06:39 AM, Andreas Färber wrote: > In addition to -42 also parse the maximum int64. > > Signed-off-by: Andreas Färber > --- > tests/test-string-input-visitor.c | 8 > 1 file changed, 8 insertions(+) Shouldn't we also add tests of one-beyond-range, to have coverage of expec

Re: [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test

2015-09-25 Thread Eric Blake
On 09/25/2015 06:39 AM, Andreas Färber wrote: > Test parsing of decimal and hexadecimal uint64 numbers with most > significient bit set. s/significient/significant/ > > Signed-off-by: Andreas Färber > --- > tests/test-string-input-visitor.c | 23 +++ > 1 file changed, 23 in

[Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting

2015-09-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- docs/qmp/qmp-events.txt | 12 docs/qmp/qmp-spec.txt | 5 + 2 files changed, 17 insertions(+) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index d92cc48..d2f1ce4 100644 --- a/docs/qmp/qmp-events.txt +++ b/docs/qmp/qmp-even

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

2015-09-25 Thread Eric Blake
On 09/25/2015 06:39 AM, Andreas Färber wrote: > Add a test for parsing and setting a uint64 property. > > Signed-off-by: Andreas Färber > --- > MAINTAINERS | 1 + > tests/Makefile | 3 ++ > tests/check-qom-props.c | 120 >

Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature

2015-09-25 Thread Eric Blake
On 09/25/2015 06:39 AM, Andreas Färber wrote: > Instead of using int64_t for qemu_strtoll() and uiint64_t for s/uiint64/uint64/ > qemu_strtoull(), use long long and unsigned long long as their name > implies. > > The only affected callers are our test cases. > > This prepares for following chec

Re: [Qemu-devel] [PATCH 01/36] qapi: add comment block before ChardevDummy

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is mainly to please the doc generation that requires comment block > before the declaration. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 6 +- > 1 file changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH 02/36] qapi: add missing @

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qapi/block.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Adding qemu-trivial; this can be taken now through trivial tree without waiting for pending

Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection

2015-09-25 Thread Markus Armbruster
Andreas Färber writes: > Am 25.09.2015 um 12:17 schrieb Thomas Huth: >> On 24/09/15 20:57, Markus Armbruster wrote: >>> The test doesn't check that the output makes any sense, only that QEMU >>> survives. Useful since we've had an astounding number of crash bugs >>> around there. >>> >>> In fact

[Qemu-devel] [PULL 5/9] openrisc: remove muldiv64()

2015-09-25 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

2015-09-25 Thread Daniel P. Berrange
On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas Färber wrote: > Add a test for parsing and setting a uint64 property. > > Signed-off-by: Andreas Färber > --- > MAINTAINERS | 1 + > tests/Makefile | 3 ++ > tests/check-qom-props.c | 120 > ++

[Qemu-devel] [PULL 6/9] arm: clarify the use of muldiv64()

2015-09-25 Thread Laurent Vivier
muldiv64() is used to convert microseconds into CPU ticks. But it is not clear and not commented. This patch uses macro to clearly identify what is used: time, CPU frequency and ticks. For an elapsed time and a given frequency, we compute how many ticks we have. Signed-off-by: Laurent Vivier Re

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

2015-09-25 Thread Markus Armbruster
Yang Hongyang writes: > On 09/24/2015 05:12 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> This filter is to buffer/release packets, this feature can be used >>> when using MicroCheckpointing, or other Remus like VM FT solutions, you >> >> What's "Remus"? > > Remus is an opensource

Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This was initially done to add qmp_capabilities documentation to the > schema. Then I figured it would also help to get rid of the "middle > mode" monitor dispatch code. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

2015-09-25 Thread Markus Armbruster
Jason Wang writes: > On 09/25/2015 03:18 PM, Yang Hongyang wrote: >> >> >> On 09/24/2015 05:12 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: [...] +static ssize_t filter_buffer_receive_iov(NetFilterState *nf, + NetClientState *sender, >>

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Moving the remaining bits of documentation to the schema files. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 48 ++- > qmp-commands.hx | 62 > --

Re: [Qemu-devel] [PATCH 07/36] qapi: add some headings in docs

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add some missing double-#, the doc parser can't easily distinguish doc > comments from comments to be ignored otherwise. > > Also add some more section headings. > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCHv2 0/7] VFIO extensions to allow VFIO devices on spapr-pci-host-bridge

2015-09-25 Thread Laurent Vivier
On 25/09/2015 13:35, David Gibson wrote: > Hi Alex, > > Here are the parts of my recent series to allow VFIO devices on the > spapr-pci-host-bridge device which affect the core VFIO code. They've > been revised according to the comments from yourself and others. > > There's also one patch for

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

2015-09-25 Thread Marc-André Lureau
- Original Message - > On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Moving the remaining bits of documentation to the schema files. > > > > Signed-off-by: Marc-André Lureau > > --- > > qapi-schema.json | 48 +++

Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-09-25 Thread Ian Campbell
On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn't suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we can bene

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

2015-09-25 Thread Markus Armbruster
Programmingkid writes: > On Sep 24, 2015, at 2:57 AM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> On Sep 23, 2015, at 4:35 PM, Peter Maydell wrote: >>> On 17 September 2015 at 21:17, Programmingkid wrote: > Add "Mount Image File..." and a "Eject Image File" menu

Re: [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn a few more markups used for API documentation. > > Signed-off-by: Marc-André Lureau > --- > scripts/texi2pod.pl | 44 +++- > 1 file changed, 43 insertions(+),

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

2015-09-25 Thread Markus Armbruster
Thomas Huth writes: > On 25/09/15 10:03, Yang Hongyang wrote: >> >> >> On 09/24/2015 05:12 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >> [...] diff --git a/vl.c b/vl.c index ec589e2..3cf89d5 100644 --- a/vl.c +++ b/vl.c @@ -2794,7 +2794,12 @@ static bool ob

Re: [Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn to generate info/html/pdf/man documentation for QEMU and agent QMP > APIs. > > This allows to provide missing agent documentation, and should help "allows to" is not idiomatic English (it is missing a

[Qemu-devel] [PULL 1/7] block/nfs: fix calculation of allocated file size

2015-09-25 Thread Jeff Cody
From: Peter Lieven st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Message-id: 1440067607-14547-1-git-send-email...@kamp.de Sig

[Qemu-devel] [PULL 5/7] Backup: don't do copy-on-read in before_write_notifier

2015-09-25 Thread Jeff Cody
From: Wen Congyang We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we cannot do copy-on-read. The steps to reproduce it: 1. -drive copy-on-read=on,... // qemu option 2. drive_backup -f disk0 /path_to_backup.img // monitor command Signed-off-by: Wen Congy

[Qemu-devel] [PULL 6/7] sheepdog: use per AIOCB dirty indexes for non overlapping requests

2015-09-25 Thread Jeff Cody
From: Hitoshi Mitake In the commit 96b14ff85acf, requests for overlapping areas are serialized. However, it cannot handle a case of non overlapping requests. In such a case, min_dirty_data_idx and max_dirty_data_idx can be overwritten by the requests and invalid inode update can happen e.g. a cas

[Qemu-devel] [PULL 0/7] Block patches

2015-09-25 Thread Jeff Cody
The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 01:32:11 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-

[Qemu-devel] [PULL 4/7] block: Introduce a new API bdrv_co_no_copy_on_readv()

2015-09-25 Thread Jeff Cody
From: Wen Congyang In some cases, we need to disable copy-on-read, and just read the data. Signed-off-by: Wen Congyang Message-id: 1441682913-14320-2-git-send-email-we...@cn.fujitsu.com Signed-off-by: Jeff Cody --- block/io.c| 12 +++- include/block/block.h | 9 ++---

[Qemu-devel] [PULL 7/7] sheepdog: refine discard support

2015-09-25 Thread Jeff Cody
From: Hitoshi Mitake This patch refines discard support of the sheepdog driver. The existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which was introduced before fine grained reference counting on newer sheepdog. It doesn't care about relations of snapshots and clones and discards

Re: [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since some commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 10 ++ > 1

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

2015-09-25 Thread Eric Blake
On 09/25/2015 09:29 AM, Marc-André Lureau wrote: > > > - Original Message - >> On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> Moving the remaining bits of documentation to the schema files. >>> >>> Signed-off-by: Marc-André Lureau >>> ---

Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Clean-up qmp-commands.hx from examples. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 1128 +++- > qapi/block-core.json | 365 + > qapi/block.json | 32 + > qa

Re: [Qemu-devel] [PATCH 19/36] qmp: implement qmp_query_commands without qmp_cmds

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > So we can get rid of the static qmp_cmds table. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH 16/36] qmp: register qapi commands (no middle mode)

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The marshal functions are no longer exported, they are registered in the > dispatch table instead. The following patches will make use of > qmp_dispatch(). This patch temporarily breaks qmp/hmp commands. Sho

Re: [Qemu-devel] [PATCH 20/36] qmp: remove old qmp-commands table

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The table is no longer used. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 7 - > qmp-commands-old.h | 554 > - > 2 files changed,

Re: [Qemu-devel] [PATCH 21/36] misc: spelling

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > --- > monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Trivial, can be applied now without waiting for pending qapi patches. Reviewed-by: Eric Blake > > diff --git a/monitor.c b/monitor

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

2015-09-25 Thread Markus Armbruster
Yang Hongyang writes: > This patchset addressed Markus comment on netfilter patch > series, most of them are comment fixes. > > It is based on jason's net tree: > https://github.com/jasowang/qemu/tree/net > > Signed-off-by: Yang Hongyang I think we have enough issues to warrant a full respin.

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 16:06, Programmingkid wrote: > Removes the open dialog code that runs when no arguments > are supplied with QEMU. Not everyone needs a hard drive > or cdrom to boot their target. A user might only need to > use their target's bios to do work. With that said, > this patch re

[Qemu-devel] [PULL 3/7] sheepdog: add reopen support

2015-09-25 Thread Jeff Cody
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Message-id: 1440730438-24676-1-git-s

Re: [Qemu-devel] [PATCH 30/36] tests: change /0.15/* tests to /qmp/*

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Presumably 0.15 was the version it was first introduced, but > qmp keeps evolving. There is no point in having that version > has test prefix, qmp makes more sense. s/has/be the/ > > Signed-off-by: Marc-An

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-25 Thread John Snow
On 09/24/2015 02:34 AM, Markus Armbruster wrote: > John Snow writes: > > [...] >> Oh, I see: you're saying ... >> >> each action fetches the property, and if it's true, fail (for 2.5, at >> least) with e.g. a message saying "This property is not [yet?] supported >> for this action" > > Yes. >

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: > On 23 September 2015 at 16:06, Programmingkid > wrote: >> Removes the open dialog code that runs when no arguments >> are supplied with QEMU. Not everyone needs a hard drive >> or cdrom to boot their target. A user might only need to >> use t

Re: [Qemu-devel] [PATCH 18/36] qapi: remove "middle" mode

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Now that the register function is always generated, we can > remove the so-called "middle" mode to the generator script. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-commands.py | 29 +

Re: [Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

2015-09-25 Thread Sergey Fedorov
On 25.09.2015 17:42, Christopher Covington wrote: > This should help clarify the purpose of the function that returns > the host system's CPU cycle count. +1 Best regards, Sergey

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

2015-09-25 Thread Programmingkid
On Sep 23, 2015, at 4:35 PM, Peter Maydell wrote: > On 17 September 2015 at 21:17, Programmingkid > wrote: >> Add "Mount Image File..." and a "Eject Image File" menu items to >> cocoa interface. This patch makes sharing files between the >> host and the guest user-friendly. >> >> The "Mount Im

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

2015-09-25 Thread Marc-André Lureau
Hi - Original Message - > On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > I have grown a qapi branch during the past 2 months that was > > post-poned for review until the introspection and other fixes got > > merged or ready. >

Re: [Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Move the examples in the json file with the rest of the documentation to > avoid duplication. > > Signed-off-by: Marc-André Lureau > --- > docs/qmp/qmp-events.txt | 664 > -

[Qemu-devel] [PULL 2/7] block/nfs: cache allocated filesize for read-only files

2015-09-25 Thread Jeff Cody
From: Peter Lieven If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 09:12, Programmingkid wrote: > > On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: >> (Also, isn't a simple test on gArgc going to cause us to put up >> the dialog box even if qemu was started from the command line with >> no arguments?) > > I suppose you are right. Will m

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

2015-09-25 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > I have grown a qapi branch during the past 2 months that was > post-poned for review until the introspection and other fixes got > merged or ready. > > It could be splitted roughly in 3 parts, but since they depend on each

Re: [Qemu-devel] [PATCH 08/36] qapi: add qapi2texi script

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > As the name suggests, the qapi2texi script converts JSON QAPI > description into a standalone texi file suitable for different target > formats. > > It parses the following kind of blocks with some little va

Re: [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > Make the variables holding the event QDict instead of QObject. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/monitor.c b/

Re: [Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

2015-09-25 Thread Paolo Bonzini
On 25/09/2015 16:42, Christopher Covington wrote: > This should help clarify the purpose of the function that returns > the host system's CPU cycle count. > > Signed-off-by: Christopher Covington Acked-by: Paolo Bonzini Good idea! Paolo > --- > bsd-user/main.c | 2 +- > cpus.c

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: verify with user before quitting QEMU

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 17:57, Programmingkid wrote: > This patch prevents the user from accidentally quitting QEMU by pushing > Command-Q or by pushing the close button on the main window. When > the user does one of these two things, a dialog box appears verifying > with the user if he or she wa

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: prevent stuck key situation

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 18:21, Programmingkid wrote: > When the user puts QEMU in the background while holding > down a key, QEMU will not receive the keyup event when > the user lets go of the key. When the user goes back to > QEMU, QEMU will think the key is still down causing > stuck key sympto

Re: [Qemu-devel] [RFC 2/6] monitor: Simplify event throttling

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > The event throttling state machine is hard to understand. I'm not > sure it's entirely correct. Rewrite it in a more straightforward > manner: > > State 1: No event sent recently (less than evconf->rate ns ago) > > Invariant: evstate->timer

  1   2   3   >