Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay

2015-09-22 Thread Paolo Bonzini
On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > #endif > > +/* CPU thread can infinitely wait for event after > + missing the warp */ > +qemu_clock_warp(QEMU_CLOCK_VIRTUAL); > qemu_clock_run_all_timers(); It is still not clear to me why the call in timerlist_rearm is not suff

[Qemu-devel] [PATCH 2/9] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- hw/intc/apic.c

[Qemu-devel] [PATCH v4 0/9] hmp command IO- and Local APIC dump state

2015-09-22 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info lapic dumping local APIC state for CPU 0 LVT00x00010700 active-hi edge masked ExtINT (vec 0) LVT10x0400 act

[Qemu-devel] [PATCH 8/9] hmp: added io apic dump state

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info ioapic ioapic id=0x00 sel=0x26 (redir[11]) pin 0 0x0001 dest=0 vec=0 a

[Qemu-devel] [PATCH 7/9] ioapic_internal.h: added more constants

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- include/hw/i386/ioapic_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/incl

[Qemu-devel] [PATCH 4/9] apic_internal.h: fix formatting and drop unused consts

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färb

[Qemu-devel] [PATCH 9/9] hmp: implemented io apic dump state for TCG

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info ioapic" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- hw/intc/ioapic.c | 12 include/hw/i386/pc.h | 1 + target-i386/monitor.c | 2 ++ 3 files ch

[Qemu-devel] [PATCH 1/9] apic_internal.h: make some apic_get_* functions externally visible

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Move apic_get_bit(), apic_set_bit() to apic_internal.h, make the apic_get_ppr symbol external. It's necessary to work with isr, tmr, irr and ppr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- h

[Qemu-devel] [PATCH 3/9] apic_internal.h: added more constants

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin These constants are needed for optimal access to bit fields local apic registers without magic numbers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- include/hw/i386/apic_internal.h | 58

[Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. (qemu) info lapic dumping local APIC state for CPU 0 LVT00x00010700 active-hi edge masked ExtINT (vec 0) LVT10x000

[Qemu-devel] [PATCH 5/9] monitor: make monitor_fprintf and mon_get_cpu externally visible

2015-09-22 Thread Denis V. Lunev
From: Pavel Butsykin monitor_fprintf and mon_get_cpu will be used in the target-specific monitor, so it is advisable to make it external. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber --- disas.c | 10 -- includ

Re: [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 04:11:34PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 05, 2015 at 03:38:21PM +0100, Stefan Hajnoczi wrote: > > Hi Stefan, > > I get the following compiler warning in Fedora 22 > > (mingw32-headers-4.0.2-1.fc22): > > > > In file included from qemu/include/qemu-common.h:4

[Qemu-devel] [PATCH v6 2/4] block: support passing 'backing': '' to 'blockdev-add'

2015-09-22 Thread Alberto Garcia
Passing an empty string allows opening an image but not its backing file. This was already described in the API documentation, only the implementation was missing. This is useful for creating snapshots using images opened with blockdev-add, since they are not supposed to have a backing image befor

[Qemu-devel] [PATCH v6 4/4] block: add tests for the 'blockdev-snapshot' command

2015-09-22 Thread Alberto Garcia
Signed-off-by: Alberto Garcia Cc: Max Reitz --- tests/qemu-iotests/085 | 102 ++--- tests/qemu-iotests/085.out | 34 ++- 2 files changed, 128 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index

[Qemu-devel] [PATCH v6 1/4] block: rename BlockdevSnapshot to BlockdevSnapshotSync

2015-09-22 Thread Alberto Garcia
We will introduce the 'blockdev-snapshot' command that will require its own struct for the parameters, so we need to rename this one in order to avoid name clashes. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- blockdev.c | 2 +- qapi-schema.json

[Qemu-devel] [PATCH v6 0/4] Add 'blockdev-snapshot' command

2015-09-22 Thread Alberto Garcia
v6: - Update documentation and parameter names following Eric's suggestions: 'device' -> 'node', 'snapshot' -> 'overlay'. - Rebased on top of Max's "BlockBackend and media" v5 v5: https://lists.gnu.org/archive/html/qemu-block/2015-09/msg00483.html - Don't delete the 'backing' option if it contai

[Qemu-devel] [PATCH v6 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap b

Re: [Qemu-devel] [PATCH 13/14] MAINTAINERS: Add maintainer for ARM PrimeCell and integrated devices

2015-09-22 Thread Thomas Huth
On 22/09/15 11:56, Paolo Bonzini wrote: > Cc: Peter Maydell > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 28 > 1 file changed, 28 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4f4b523..0fe3fb7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS

[Qemu-devel] [PATCH] mingw: fix build on Fedora 22

2015-09-22 Thread Michael S. Tsirkin
mingw on Fedora 22 replaces localtime_r and gmtime_r macros with posix compliant functions in time.h. These conflict with QEMU supplied ones. Detect this and avoid overriding them. We also need to define POSIX_C_SOURCE before including time.h for the first time, to make sure these are available

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Thomas Huth
On 22/09/15 11:13, Markus Armbruster wrote: ... >> Full list of unmaintained files now: [...] > default-configs/aarch64-linux-user.mak > default-configs/aarch64-softmmu.mak > default-configs/alpha-linux-user.mak > default-configs/alpha-softmmu.mak > default-configs/arm-linux-user.mak > default-conf

Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 04:38:31PM +0300, Michael S. Tsirkin wrote: > mingw on Fedora 22 replaces localtime_r and gmtime_r > macros with posix compliant functions in time.h. > > These conflict with QEMU supplied ones. > > Detect this and avoid overriding them. > > We also need to define POSIX_C_

Re: [Qemu-devel] [PATCH v3 08/46] ivshmem: remove useless doorbell field

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 5e4b2cc..1b8204e 100644 > --- a/hw/misc/ivshmem

Re: [Qemu-devel] [PULL 0/4] update to 35c53797 to 4e03af8

2015-09-22 Thread Peter Maydell
On 22 September 2015 at 05:18, Gerd Hoffmann wrote: > On Di, 2015-09-15 at 12:25 +0200, Gerd Hoffmann wrote: >> On Do, 2015-09-03 at 14:32 +0100, Peter Maydell wrote: >> > On 3 September 2015 at 14:02, Gerd Hoffmann wrote: >> > > Hi, >> > > >> > > Here comes the ipxe update pull. Thanks to Ste

Re: [Qemu-devel] [PATCH v3 10/46] ivshmem: remove last exit(1)

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Failing to create a chardev shouldn't be fatal. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/

Re: [Qemu-devel] [PULL v1 00/21] Multi-arch queue

2015-09-22 Thread Paolo Bonzini
On 11/09/2015 16:45, Peter Crosthwaite wrote: > > Hi. This looks like it's a branch, not a gpg signed tag? > > I only take signed pullreqs these days... > > OK I'll take these patches then until you sort out the GPG signing (I see you have created a GPG key 96CF610A). Paolo

Re: [Qemu-devel] [PATCH v3 10/46] ivshmem: remove last exit(1)

2015-09-22 Thread Claudio Fontana
On 22.09.2015 15:55, Claudio Fontana wrote: > On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Failing to create a chardev shouldn't be fatal. >> >> Signed-off-by: Marc-André Lureau >> --- >> hw/misc/ivshmem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH v3 09/46] ivshmem: more qdev conversion

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use the latest qemu device modeling API, in particular, convert to > realize to fix the error handling; right now a botched device_add > ivhsmem command kills the VM. > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCH v3 10/46] ivshmem: remove last exit(1)

2015-09-22 Thread Marc-André Lureau
Hi - Original Message - > On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Failing to create a chardev shouldn't be fatal. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/misc/ivshmem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH v3 05/46] ivshmem: factor out the incoming fifo handling

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Make a new function fifo_update_and_get() that can be reused by other > functions (in next commits). > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 59 >

Re: [Qemu-devel] [PATCH v5 02/46] qapi: Clean up qapi.py per pep8

2015-09-22 Thread Markus Armbruster
Eric Blake writes: > Silence pep8, and make pylint a bit happier. Just style cleanups; > no semantic changes. I had planned to clean it up after resolving the TODO fold into QAPISchema, but I'm fine with doing it right away. I think we'll want to do a bit more for pylint, but limiting ourselve

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-22 Thread Star Chang
Thanks Marcel!!! After tailing the logs and basic troubleshooting, we finally can have 2 VMs to ping to each other. One dpdkvhostuser interface is for each VM and we have to new add flows based on dpdkvhostuser ofport numbers. Another issue we might post it to proper mail loop is that we run pktg

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-22 Thread Prasanna Kalever
> On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple backup volfile servers to the > > gluster > > block backend of QEMU with tcp|rdma transport types and their port numbers. > > > > > > > This patch gives a mechanism to provide all the server ad

Re: [Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the > fd. > Are you sure? (tested?) There is a specific comment that the dup is done because of the get_msgfds implementation, I checked tc

[Qemu-devel] No error report when using the qemu-img.exe to convert a disk to vmdk format which is saved on a disk that has no more space

2015-09-22 Thread Guangmu Zhu
Hi, I used the qemu-img.exe to convert a disk to vmdk format and the output file size could be 300 MB. However the left space of the disk the output file located on was about 200 MB. After a while, the left space had been zero but the program didn't stop or report any error. It was just going

Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 02:48:04PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 22, 2015 at 04:38:31PM +0300, Michael S. Tsirkin wrote: > > mingw on Fedora 22 replaces localtime_r and gmtime_r > > macros with posix compliant functions in time.h. > > > > These conflict with QEMU supplied ones. >

Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22

2015-09-22 Thread Denis V. Lunev
On 09/22/2015 04:48 PM, Daniel P. Berrange wrote: On Tue, Sep 22, 2015 at 04:38:31PM +0300, Michael S. Tsirkin wrote: mingw on Fedora 22 replaces localtime_r and gmtime_r macros with posix compliant functions in time.h. These conflict with QEMU supplied ones. Detect this and avoid overriding t

Re: [Qemu-devel] [PATCH v3 12/46] ivshmem: simplify around increase_dynamic_storage()

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Set the number of peers and array allocation in a single place. Rename > to better reflect the function content. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 27 +++

Re: [Qemu-devel] [PATCH v2] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-09-22 Thread Denis V. Lunev
On 09/08/2015 12:26 PM, Daniel P. Berrange wrote: The oslib-win32 file currently provides a localtime_r and gmtime_r replacement unconditionally. Some versions of Mingw64 would provide crude macros for localtime_r/gmtime_r which QEMU takes care to disable. Latest versions of Mingw64 now provide a

Re: [Qemu-devel] [PULL v1 00/21] Multi-arch queue

2015-09-22 Thread Peter Maydell
On 22 September 2015 at 06:58, Paolo Bonzini wrote: > > > On 11/09/2015 16:45, Peter Crosthwaite wrote: >> > Hi. This looks like it's a branch, not a gpg signed tag? >> > I only take signed pullreqs these days... >> >> OK > > I'll take these patches then until you sort out the GPG signing (I see >

Re: [Qemu-devel] [PATCH v3 14/46] ivshmem: remove useless ivshmem_update_irq() val argument

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > val isn't used in ivshmem_update_irq() function. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/misc/ivshme

Re: [Qemu-devel] [PATCH v3 15/46] ivshmem: initialize max_peer to -1

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > There is no peer when device is initialized, do not let doorbell for > inexisting peer 0. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

[Qemu-devel] [PATCH v2 REPOST] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-09-22 Thread Daniel P. Berrange
The oslib-win32 file currently provides a localtime_r and gmtime_r replacement unconditionally. Some versions of Mingw64 would provide crude macros for localtime_r/gmtime_r which QEMU takes care to disable. Latest versions of Mingw64 now provide actual functions for localtime_r/gmtime_r, but with a

Re: [Qemu-devel] [PATCH v3 11/46] ivshmem: limit maximum number of peers to G_MAXUINT16

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Limit the maximum number of peers to MAXUINT16. This is more realistic > and better matches the limit of the doorbell register. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 5 +++-- > 1 fi

Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 05:08:44PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 22, 2015 at 02:48:04PM +0100, Daniel P. Berrange wrote: > > > > I don't think this is right. There are three possibilities > > with mingw > > > > - No gmtime_r at all - need replacement > > - gmtime_r defined as

Re: [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > This structure will store some of the state of the root BDS if the BDS > tree is removed, so that state can be restored once a new BDS tree is > inserted. This is magic that is bound to bite us sooner or later. I see that we have to do this in or

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-22 Thread Alexandre DERUMIER
Hi, Ovs documentation say that 1GB hugepage are needed https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK.md is is true ? (as the wiki say 2M hugepages) - Mail original - De: "Star Chang" À: "Marcel Apfelbaum" Cc: "qemu-devel" Envoyé: Mardi 22 Septembre 2015 07:43:13 Objet:

Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Some misc improvements to ivshmem debug. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/hw/misc/ivshmem.c b

Re: [Qemu-devel] [PATCH v3 18/46] ivshmem: improve error

2015-09-22 Thread Claudio Fontana
Subject: ivshmem: improve error Seems an interrupted sentence... ... improve error handling? improve error messages? Ciao Claudio On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The test whether the chardev is an AF_UNIX socket rejects > "-chardev socket

Re: [Qemu-devel] [PATCH v3 19/46] ivshmem: print error on invalid peer id

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The server shouldn't send invalid peer id, so print an error if it's the > case. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/mis

Re: [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > If there is no BlockDriverState in a BlockBackend or if the tray of the > guest device is open, fail all requests (where that is possible) with > -ENOMEDIUM. > > The reason the status of the guest device is taken into account is > because once th

Re: [Qemu-devel] [PATCH v3 20/46] ivshmem: simplify a bit the code

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use some more explicit variables to simplify the code. > > nth_eventfd variable is the current eventfd to be manipulated. well maybe a silly question, but then why not call it current_eventfd? > Signed-off-by

Re: [Qemu-devel] [PATCH v5 20/38] block: Prepare remaining BB functions for NULL BDS

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > There are several BlockBackend functions which, in theory, cannot fail. > This patch makes them cope with the BlockDriverState pointer being NULL > by making them fall back to some default action like ignoring the value > in setters and returning

Re: [Qemu-devel] [PATCH v3 41/46] ivshmem: do not keep shm_fd open

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Remove shm_fd from device state, closing it as early as possible to avoid > leaks. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 14 +- > 1 file changed, 5 insertions(+), 9 del

Re: [Qemu-devel] [PATCH v2 REPOST] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-09-22 Thread Denis V. Lunev
On 09/22/2015 05:13 PM, Daniel P. Berrange wrote: The oslib-win32 file currently provides a localtime_r and gmtime_r replacement unconditionally. Some versions of Mingw64 would provide crude macros for localtime_r/gmtime_r which QEMU takes care to disable. Latest versions of Mingw64 now provide a

Re: [Qemu-devel] [PATCH v5 21/38] block: Add blk_insert_bs()

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > This function associates the given BlockDriverState with the given > BlockBackend. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Alberto Garcia > --- > block/block-backend.c | 16 > include/sy

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Eric Blake
On 09/18/2015 08:58 AM, Yuanhan Liu wrote: > From: Changchun Ouyang > > This patch is initially based a patch from Nikolay Nikolaev. > > This patch adds vhost-user multiple queue support, by creating a nc > and vhost_net pair for each queue. > > Qemu exits if find that the backend can't support

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-22 Thread Richard Henderson
On 09/21/2015 10:54 PM, Chen Gang wrote: > On 2015年09月19日 10:34, Richard Henderson wrote: >> >> There's a trick for this that's more efficient for 4 or more elements >> per vector (i.e. good for v2 and v1, but not v4): >> >>a + b = (a & 0x7f7f7f7f) + (b & 0x7f7f7f7f)) ^ ((a ^ b) & 0x80808080) >

Re: [Qemu-devel] [PATCH v3 40/46] tests: add ivshmem qtest

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Adds 4 ivshmemtests: > - single qemu instance and basic IO > - pair of instances, check memory sharing > - pair of instances with server, and MSIX > - hot plug/unplug > > A temporary shm is created as well as a

Re: [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > This series reworks a lot regarding BlockBackend and media. Basically, > it allows empty BlockBackends, that is BBs without a BDS tree. > > Before this series, empty drives are represented by a BlockBackend with > an empty BDS attached to it (a B

Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-22 Thread Eric Blake
On 09/18/2015 08:58 AM, Yuanhan Liu wrote: > From: Changchun Ouyang > > Add a new message, VHOST_USER_SET_VRING_ENABLE, to enable or disable > a specific virt queue, which is similar to attach/detach queue for > tap device. > > virtio driver on guest doesn't have to use max virt queue pair, it >

Re: [Qemu-devel] [PATCH v3 43/46] ivshmem: add hostmem backend

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:08, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Instead of handling allocation, teach ivshmem to use a memory backend. > This allows to use hugetlbfs backed memory now. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c| 84 > +

Re: [Qemu-devel] [PATCH 3/3] scripts/qemu-gdb: Add support for printing trace events

2015-09-22 Thread Paolo Bonzini
On 14/05/2015 18:43, Peter Maydell wrote: > Add two new commands to our gdb support: > qemu trace-enable eventname > qemu trace-disable eventname > > which allow dynamically enabling and disabling printing of QEMU > trace events during a debugging session. These work with the > "null" trace ba

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-22 Thread Marcel Apfelbaum
On 09/22/2015 05:17 PM, Alexandre DERUMIER wrote: Hi, Ovs documentation say that 1GB hugepage are needed https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK.md is is true ? (as the wiki say 2M hugepages) Not for this scenario :) . For this one 2M hugepages are enough (tested already

Re: [Qemu-devel] [PATCH v3 20/46] ivshmem: simplify a bit the code

2015-09-22 Thread Marc-André Lureau
- Original Message - > On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use some more explicit variables to simplify the code. > > > > nth_eventfd variable is the current eventfd to be manipulated. > > well maybe a silly question, but then wh

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Gerd Hoffmann
Hi, > > docs/usb-storage.txt > > docs/usb2.txt > > include/hw/usb.h > > include/hw/usb/ehci-regs.h > > include/hw/usb/uhci-regs.h > > include/ui/console.h > > include/ui/egl-helpers.h > > include/ui/gtk.h > > include/ui/input.h > > include/ui/pixel_ops.h > > include/ui/qemu-pixman.h > > include

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: > > > Markus Armbruster writes: > Different tack: what are the unmaintained files we actually change? > > Unmaintained files sorted by number of commits in the past yea

Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:08, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > No need to store an extra int for the vector number when it can be > computed easily by looking at the position in the array. > > Signed-off-by: Marc-André Lureau This one does not seem particularly valuable t

Re: [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState

2015-09-22 Thread Max Reitz
On 22.09.2015 16:17, Kevin Wolf wrote: > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: >> This structure will store some of the state of the root BDS if the BDS >> tree is removed, so that state can be restored once a new BDS tree is >> inserted. > > This is magic that is bound to bite us soon

Re: [Qemu-devel] [PATCH v5 02/46] qapi: Clean up qapi.py per pep8

2015-09-22 Thread Eric Blake
On 09/22/2015 08:00 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Silence pep8, and make pylint a bit happier. Just style cleanups; >> no semantic changes. > > I had planned to clean it up after resolving the TODO fold into > QAPISchema, but I'm fine with doing it right away. I think

Re: [Qemu-devel] [PATCH v3 41/46] ivshmem: do not keep shm_fd open

2015-09-22 Thread Marc-André Lureau
Hi - Original Message - > On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Remove shm_fd from device state, closing it as early as possible to avoid > > leaks. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/misc/ivshmem.c | 14 +-

Re: [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend

2015-09-22 Thread Max Reitz
On 22.09.2015 16:30, Kevin Wolf wrote: > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: >> If there is no BlockDriverState in a BlockBackend or if the tray of the >> guest device is open, fail all requests (where that is possible) with >> -ENOMEDIUM. >> >> The reason the status of the guest devi

[Qemu-devel] [PULL 02/48] qemu-nbd: convert to use the QAPI SocketAddress object

2015-09-22 Thread Paolo Bonzini
From: "Daniel P. Berrange" The qemu-nbd program currently uses a QemuOpts objects when setting up sockets. Switch it over to use the QAPI SocketAddress objects instead. Signed-off-by: Daniel P. Berrange Message-Id: <1442411543-28513-3-git-send-email-berra...@redhat.com> Signed-off-by: Paolo Bon

[Qemu-devel] [PULL 13/48] MAINTAINERS: add IPack section

2015-09-22 Thread Paolo Bonzini
Reviewed-by: Alberto Garcia Signed-off-by: Paolo Bonzini --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 599f7a7..b39e714 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -663,6 +663,12 @@ M: Peter Maydell S: Maintained F: hw/*/omap* +I

[Qemu-devel] [PULL 01/48] nbd: convert to use the QAPI SocketAddress object

2015-09-22 Thread Paolo Bonzini
From: "Daniel P. Berrange" The nbd block driver currently uses a QemuOpts object when setting up sockets. Switch it over to use the QAPI SocketAddress object instead. Signed-off-by: Daniel P. Berrange Message-Id: <1442411543-28513-2-git-send-email-berra...@redhat.com> Signed-off-by: Paolo Bonzi

[Qemu-devel] [PULL 14/48] MAINTAINERS: add more devices to the PC section

2015-09-22 Thread Paolo Bonzini
For chipset devices, I can co-maintain it with Michael. Reviewed-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b39e714..c042f59 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[Qemu-devel] [PULL 09/48] get_maintainer.pl: \C is deprecated

2015-09-22 Thread Paolo Bonzini
"Match a single C-language char (octet) even if that is part of a larger UTF-8 character. Thus it breaks up characters into their UTF-8 bytes, so you may end up with malformed pieces of UTF-8." Just use a period instead. Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 22 +

[Qemu-devel] [PULL 06/48] scsi-generic: let guests recognize readonly=on on passthrough devices

2015-09-22 Thread Paolo Bonzini
Passed-through SCSI devices can be opened with the readonly=on option. When this happens, Linux filters away write commands so that the guest cannot overwrite the contents of the device. However, the guest does not know that the device is read-only, and accepts writes. The writes only fail later

[Qemu-devel] [PULL 25/48] ioapic_internal.h: added more constants

2015-09-22 Thread Paolo Bonzini
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Färber Message-Id: <1442927901-1084-8-git-send-email-...@openvz.org> Signed-off-by: Paolo Bonzini --- in

[Qemu-devel] [PULL 29/48] linux-user: elfload: Provide default for elf_check_arch

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite For many arch's this macro is defined as the predicatable behaviour of checking the argument for eqaulity against ELF_ARCH. Provide a default define as such, so only archs with special handling (usually allowing multiple EM values) need to provide a def. Arches that do an

[Qemu-devel] [PULL 00/48] Misc patches for 2015-09-22

2015-09-22 Thread Paolo Bonzini
The following changes since commit 9e72681d16792d0ffc42bab634b1753ff299bdfd: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-09-21' into staging (2015-09-21 22:33:51 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 34/48] m68k: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The machine model bootloaders can just pass EM_68K directly, as that is architecture specific code. This removes another archit

[Qemu-devel] [PULL 48/48] ppc: Rename ELF_MACHINE to be PPC specific

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite Rename ELF_MACHINE to be PPC specific. This is used as-is by the various PPC bootloaders and is locally defined to ELF_MACHINE in linux user in PPC specific ifdeffery. This removes another architecture specific definition from the global namespace (as desired by multi-arc

[Qemu-devel] [PULL 22/48] apic_internal.h: fix formatting and drop unused consts

2015-09-22 Thread Paolo Bonzini
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas Fär

[Qemu-devel] [PULL 28/48] linux_user: elfload: Default ELF_MACHINE to ELF_ARCH

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite In most (but not all) cases, ELF_MACHINE and ELF_ARCH are safely the same. Default ELF_MACHINE to ELF_ARCH. This makes defining ELF_MACHINE optional for target-*/cpu.h when they are known to match. Reviewed-by: Richard Henderson Acked-By: Riku Voipio Signed-off-by: Pete

[Qemu-devel] [PULL 43/48] s390: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The bootloader can just pass EM_S390 directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Richard Henderson Cc: Alexander Graf Reviewed-by: Richard Henderson Acked-By: Riku Voipio Signed

[Qemu-devel] [PULL 35/48] cris: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The bootloader can just pass EM_CRIS directly, as that is architecture specific code. This removes another architecture specifi

Re: [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media

2015-09-22 Thread Max Reitz
On 22.09.2015 16:45, Kevin Wolf wrote: > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: >> This series reworks a lot regarding BlockBackend and media. Basically, >> it allows empty BlockBackends, that is BBs without a BDS tree. >> >> Before this series, empty drives are represented by a BlockBac

Re: [Qemu-devel] No error report when using the qemu-img.exe to convert a disk to vmdk format which is saved on a disk that has no more space

2015-09-22 Thread Kevin Wolf
Am 22.09.2015 um 08:09 hat Guangmu Zhu geschrieben: > I used the qemu-img.exe to convert a disk to vmdk format and the output file > size could be 300 MB. However the left space of the disk the output file > located on was about 200 MB. After a while, the left space had been zero but > the program

Re: [Qemu-devel] [PATCH v5 20/38] block: Prepare remaining BB functions for NULL BDS

2015-09-22 Thread Max Reitz
On 22.09.2015 16:35, Kevin Wolf wrote: > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: >> There are several BlockBackend functions which, in theory, cannot fail. >> This patch makes them cope with the BlockDriverState pointer being NULL >> by making them fall back to some default action like ig

[Qemu-devel] [PULL 37/48] unicore: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. This removes another architecture specific definition from the global namespace. Cc: Guan Xuetao Reviewed-by: Richard Henderso

[Qemu-devel] [PULL 40/48] tricore: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The bootloader can just pass EM_TRICORE directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Bastian Koppelmann Acked-By: Bastian Koppelmann Reviewed-by: Richard Henderson Acked-By: Riku

[Qemu-devel] [PULL 33/48] mb: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux-users' default behaviour or setting ELF_MACHINE to ELF_ARCH will handle this. The microblaze bootloader can just pass EM_MICROBLAZE directly, as that is architecture specific code. This removes another archit

[Qemu-devel] [PULL 24/48] hmp: added local apic dump state

2015-09-22 Thread Paolo Bonzini
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. (qemu) info lapic dumping local APIC state for CPU 0 LVT00x00010700 active-hi edge masked ExtINT (vec 0) LVT10x000

[Qemu-devel] [PULL 12/48] MAINTAINERS: Add more s390 files

2015-09-22 Thread Paolo Bonzini
Cc: Alexander Graf Reviewed-by: Christian Borntraeger Signed-off-by: Paolo Bonzini --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index af4952c..599f7a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -577,6 +577,7 @@ M: Cornelia Huck M: Christian

[Qemu-devel] [PULL 47/48] i386: Rename ELF_MACHINE to be x86 specific

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite Rename ELF_MACHINE to be I386 specific. This is used as-is by the multiboot loader. Linux-user previously used this definition but will not anymore, falling back to the default bahaviour of using ELF_ARCH as ELF_MACHINE. This removes another architecture specific definit

[Qemu-devel] [PULL 10/48] MAINTAINERS: there is no PPC64 TCG backend anymore

2015-09-22 Thread Paolo Bonzini
PPC32 and PPC64 were unified. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 71c652b..7c81848 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1142,11 +1142,6 @@ M: Vassili Karpov (malc) S: Maintained F: tcg/p

[Qemu-devel] [PULL 05/48] checkpatch: do not recommend qemu_strtok over strtok

2015-09-22 Thread Paolo Bonzini
If anything it should recommend strtok_r! Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 574334b..b6d71ea 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatc

Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben: > From: Eric Blake > > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a fir

[Qemu-devel] [PULL 41/48] xtensa: Remove ELF_MACHINE from cpu.h

2015-09-22 Thread Paolo Bonzini
From: Peter Crosthwaite The bootloaders can just pass EM_XTENSA directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Max Filippov Reviewed-by: Richard Henderson Acked-By: Riku Voipio Signed-off-by: Peter Crosthw

[Qemu-devel] [PULL 15/48] MAINTAINERS: add more devices to the PCI section

2015-09-22 Thread Paolo Bonzini
Reviewed-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c042f59..5317ce1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -692,7 +692,9 @@ PCI M: Michael S. Tsirkin S: Supported F: include

<    1   2   3   4   >