Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-22 Thread Marcel Apfelbaum
On 09/22/2015 08:43 AM, Star Chang wrote: Thanks Marcel!!! After tailing the logs and basic troubleshooting, we finally can have 2 VMs to ping to each other. One dpdkvhostuser interface is for each VM and we have to new add flows based on dpdkvhostuser ofport numbers. Hi, Good to hear this!

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Jason Wang
On 09/16/2015 08:16 PM, Yang Hongyang wrote: > qemu_deliver_packet_iov already have the compat delivery, we > can drop qemu_deliver_packet. > > Signed-off-by: Yang Hongyang > --- > include/net/net.h | 5 - > net/net.c | 40 +++- > net/queue.c

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Jason Wang
On 09/16/2015 08:16 PM, Yang Hongyang wrote: > From: Yang Hongyang > > add multiqueue support, if there's multiqueue, we add multi netfilter > objects, other netfilter objects is the child of the first added netfilter > object. So when we delete a netfilter, the other netfilter objects we > adde

Re: [Qemu-devel] [PATCH v11 00/12] Add a netfilter object and netbuffer filter

2015-09-22 Thread Jason Wang
On 09/16/2015 08:15 PM, Yang Hongyang wrote: > This patch add an netfilter abstract object, captures all network packets > on associated netdev. Also implement a concrete filter buffer based on > this abstract object. the "buffer" netfilter could be used by VM FT solutions > like MicroCheckpointi

Re: [Qemu-devel] [PATCH][TRIVIAL] spice: fix checking for surface bpp match

2015-09-22 Thread Michael Tokarev
17.09.2015 19:18, Léo Grange wrote: > Ping, as I had no feedback about this small patch. > Please tell me if I need to do anything else. Hello! I've seen initial version of your patch, thought it isn't exactly trivial ;), and hoped someone will comment. Only now I realized you sent it to -trivia

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Yang Hongyang
Hi Jason, Thanks for the review, On 09/22/2015 03:30 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: qemu_deliver_packet_iov already have the compat delivery, we can drop qemu_deliver_packet. Signed-off-by: Yang Hongyang --- include/net/net.h | 5 - net/net.c

[Qemu-devel] [PATCH v5 4/4] hmp: add monitor command to add/remove a child

2015-09-22 Thread Wen Congyang
The new command is blockdev_child_add and blockdev_child_del. It does the same thing as the QMP command x-blockdev-child-add and x-blockdev-child-del. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino --- hmp-commands.hx | 28 +

[Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-09-22 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake --- block.c | 50 +++ include/block/block

[Qemu-devel] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-09-22 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 6 ++--- block/quorum.c| 72 +-- include/block/block.h | 3 +++ 3 files changed, 76 insertions(+), 5 deletions(-) diff --git a/b

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Yang Hongyang
On 09/22/2015 03:36 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: From: Yang Hongyang add multiqueue support, if there's multiqueue, we add multi netfilter objects, other netfilter objects is the child of the first added netfilter object. So when we delete a netfilter, t

[Qemu-devel] [PATCH v5 0/4] qapi: child add/delete support

2015-09-22 Thread Wen Congyang
If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. It is based on the following patch: http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg04579.html ChangLog: v5: 1. Ad

[Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-09-22 Thread Wen Congyang
The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. It justs for adding/removing quorum's child now, and don't support all kinds of children, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v11 00/12] Add a netfilter object and netbuffer filter

2015-09-22 Thread Yang Hongyang
On 09/22/2015 03:39 PM, Jason Wang wrote: [...] Want to merge this. But have comments on patch 4 and multiqueue patches. I suggest to drop them in next version so I can merge to reduce the review iterations. Other optimizations and fixups could be done on top. Thanks a lot! I agree that

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-22 Thread David Hildenbrand
> No knowledge should be required for object_new(). Classes' instance_init > functions should have no side-effects outside the object itself. While this should theoretically be true, I can guarantee to you that this is not the case for all devices :) (especially as there are too many unwritten law

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Yang Hongyang
On 09/22/2015 03:36 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: From: Yang Hongyang add multiqueue support, if there's multiqueue, we add multi netfilter objects, other netfilter objects is the child of the first added netfilter object. So when we delete a netfilter, t

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-22 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Sep 21, 2015 at 10:30:50AM +0200, David Hildenbrand wrote: >> > Am 18.09.2015 um 14:00 schrieb Markus Armbruster: >> > > Several devices don't survive object_unref(object_new(T)): they crash >> > > or hang during cleanup, or they leave dangling pointers behind. >

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Jason Wang
On 09/22/2015 03:44 PM, Yang Hongyang wrote: > Hi Jason, > > Thanks for the review, > > On 09/22/2015 03:30 PM, Jason Wang wrote: >> >> >> On 09/16/2015 08:16 PM, Yang Hongyang wrote: >>> qemu_deliver_packet_iov already have the compat delivery, we >>> can drop qemu_deliver_packet. >>> >>> Sign

Re: [Qemu-devel] [PATCH] vmxnet3: Support reading IMR registers on bar0

2015-09-22 Thread Dmitry Fleytman
> On Sep 21, 2015, at 17:09 PM, Shmulik Ladkani > wrote: > > Instead of asserting, return the actual IMR register value. > This is aligned with what's returned on ESXi. > > Signed-off-by: Shmulik Ladkani > Tested-by: Dana Rubin > ACK. > --- > hw/net/vmxnet3.c | 6 +- > 1 file changed,

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-22 Thread Markus Armbruster
John Snow writes: > On 09/17/2015 12:43 PM, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >>> On Thu, Sep 17, 2015 at 01:20:43PM +0100, Peter Maydell wrote: On 17 September 2015 at 13:05, Daniel P. Berrange wrote: > On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Ma

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Yang Hongyang
On 09/22/2015 04:14 PM, Jason Wang wrote: On 09/22/2015 03:44 PM, Yang Hongyang wrote: Hi Jason, Thanks for the review, On 09/22/2015 03:30 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: qemu_deliver_packet_iov already have the compat delivery, we can drop qemu_d

Re: [Qemu-devel] [PATCH] hmp: Restore "info pci"

2015-09-22 Thread Markus Armbruster
Paolo Bonzini writes: > Dropped by commit da76ee76f78b9705e2a91e3c964aef28fecededb's > transition to hmp-commands-info.hx. > > Reported-by: Markus Armbruster > Signed-off-by: Paolo Bonzini I'll take this through my tree. Thanks!

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Jason Wang
On 09/22/2015 03:49 PM, Yang Hongyang wrote: > On 09/22/2015 03:36 PM, Jason Wang wrote: >> >> >> On 09/16/2015 08:16 PM, Yang Hongyang wrote: >>> From: Yang Hongyang >>> >>> add multiqueue support, if there's multiqueue, we add multi netfilter >>> objects, other netfilter objects is the child o

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Jason Wang
On 09/22/2015 04:07 PM, Yang Hongyang wrote: > On 09/22/2015 03:36 PM, Jason Wang wrote: >> >> >> On 09/16/2015 08:16 PM, Yang Hongyang wrote: >>> From: Yang Hongyang >>> >>> add multiqueue support, if there's multiqueue, we add multi netfilter >>> objects, other netfilter objects is the child o

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Yang Hongyang
On 09/22/2015 04:31 PM, Jason Wang wrote: [...] +/* setup filter */ +nfqc = NETFILTER_GET_CLASS(obj); +if (nfqc->setup) { +nfqc->setup(nfq, &local_err); +if (local_err) { +error_propagate(errp, local_err); +goto out

Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c

2015-09-22 Thread Markus Armbruster
Paolo Bonzini writes: [...] > (BTW, it's obvious that I don't scale to 100+ patches per month. Do you > still have that script of yours looking for unmaintained areas?). I'll follow up with up-to-date data.

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Yang Hongyang
On 09/22/2015 04:32 PM, Jason Wang wrote: On 09/22/2015 04:07 PM, Yang Hongyang wrote: On 09/22/2015 03:36 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: From: Yang Hongyang add multiqueue support, if there's multiqueue, we add multi netfilter objects, other netfilter

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Markus Armbruster
Paolo asked for an update. Markus Armbruster writes: > Markus Armbruster writes: > >> In my experience, too many files are not covered by MAINTAINERS. >> scripts/get_maintainer.pl falls back to git then, unless you say >> --no-git-fallback. Copies sent there tends to annoy their recipients >>

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Jason Wang
On 09/22/2015 04:21 PM, Yang Hongyang wrote: > > > On 09/22/2015 04:14 PM, Jason Wang wrote: >> >> >> On 09/22/2015 03:44 PM, Yang Hongyang wrote: >>> Hi Jason, >>> >>>Thanks for the review, >>> >>> On 09/22/2015 03:30 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Jason Wang
On 09/22/2015 04:35 PM, Yang Hongyang wrote: > > > On 09/22/2015 04:31 PM, Jason Wang wrote: > [...] > +/* setup filter */ > +nfqc = NETFILTER_GET_CLASS(obj); > +if (nfqc->setup) { > +nfqc->setup(nfq, &local_err); > +if (local_er

Re: [Qemu-devel] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Alberto Garcia
On Fri 18 Sep 2015 04:49:06 PM CEST, Eric Blake wrote: >> +# @BlockdevSnapshot >> +# >> +# @device: device or node name to generate the snapshot from. > > I'm still wondering if 'node' is a better name than 'device' here. I don't have a strong preference. Kevin, Max, ... any opinions? >> +# >>

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Yang Hongyang
On 09/22/2015 05:19 PM, Jason Wang wrote: [...] If we drop this patch, we will need to introduce 2 deliver func, which seems not clean and simple. Then you can probably skip the iov_to_buf() if iov_cnt is one in the above code? Seems like a good idea to avoid the extra memcpy, thank you! BTW

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Jason Wang
On 09/22/2015 04:43 PM, Yang Hongyang wrote: > On 09/22/2015 04:32 PM, Jason Wang wrote: >> >> >> On 09/22/2015 04:07 PM, Yang Hongyang wrote: >>> On 09/22/2015 03:36 PM, Jason Wang wrote: On 09/16/2015 08:16 PM, Yang Hongyang wrote: > From: Yang Hongyang > > add multi

Re: [Qemu-devel] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Kevin Wolf
Am 22.09.2015 um 11:21 hat Alberto Garcia geschrieben: > On Fri 18 Sep 2015 04:49:06 PM CEST, Eric Blake wrote: > > >> +# @BlockdevSnapshot > >> +# > >> +# @device: device or node name to generate the snapshot from. > > > > I'm still wondering if 'node' is a better name than 'device' here. > > I

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-22 Thread Jason Wang
On 09/22/2015 05:26 PM, Yang Hongyang wrote: > On 09/22/2015 05:19 PM, Jason Wang wrote: > [...] > > If we drop this patch, we will need to introduce 2 deliver func, > which > seems not clean and simple. Then you can probably skip the iov_to_buf() if iov_cnt is one in th

Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support

2015-09-22 Thread Yang Hongyang
On 09/22/2015 05:30 PM, Jason Wang wrote: [...] if (!nf->netdev_id) { error_setg(errp, "Parameter 'netdev' is required"); @@ -165,9 +174,6 @@ static void netfilter_complete(UserCreatable *uc, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "netdev",

Re: [Qemu-devel] [PATCH v10 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-09-22 Thread Jason Wang
On 09/18/2015 10:58 PM, Yuanhan Liu wrote: > This is for querying how many queues the backend supports if it has mq > support(when VHOST_USER_PROTOCOL_F_MQ flag is set from the quried > protocol features). > > vhost_net_get_max_queues() is the interface to export that value, and > to tell if the

[Qemu-devel] [PATCH 01/14] get_maintainer.pl: \C is deprecated

2015-09-22 Thread Paolo Bonzini
"Match a single C-language char (octet) even if that is part of a larger UTF-8 character. Thus it breaks up characters into their UTF-8 bytes, so you may end up with malformed pieces of UTF-8." Just use a period instead. Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 22 +

[Qemu-devel] [PATCH 03/14] MAINTAINERS: Add disassemblers to the various backends

2015-09-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- MAINTAINERS | 23 +++ 1 file changed, 23 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7c81848..af4952c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -77,6 +77,7 @@ S: Maintained F: target-alpha/ F: hw/alpha/ F: tests/tcg/alpha

[Qemu-devel] [PATCH 07/14] MAINTAINERS: add two devices to the e500 section

2015-09-22 Thread Paolo Bonzini
Cc: Alexander Graf Cc: Scott Wood Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1a9bfe4..1578db4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -708,6 +708,8 @@ M: Scott Wood L: qemu-...@nongnu.org S: Support

[Qemu-devel] [PATCH 00/14] Maintainers TLC

2015-09-22 Thread Paolo Bonzini
Add more files to MAINTAINERS, and avoid deprecation warnings in get_maintainer.pl. Paolo Bonzini (14): get_maintainer.pl: \C is deprecated MAINTAINERS: there is no PPC64 TCG backend anymore MAINTAINERS: Add disassemblers to the various backends MAINTAINERS: Add more Xen files MAINTAINER

[Qemu-devel] [PATCH 02/14] MAINTAINERS: there is no PPC64 TCG backend anymore

2015-09-22 Thread Paolo Bonzini
PPC32 and PPC64 were unified. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 71c652b..7c81848 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1142,11 +1142,6 @@ M: Vassili Karpov (malc) S: Maintained F: tcg/p

[Qemu-devel] [PATCH 06/14] MAINTAINERS: add IPack section

2015-09-22 Thread Paolo Bonzini
Cc: Alberto Garcia Signed-off-by: Paolo Bonzini --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c827b04..1a9bfe4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -669,6 +669,12 @@ M: Peter Maydell S: Maintained F: hw/*/omap* +IPack +M:

[Qemu-devel] [PATCH 08/14] MAINTAINERS: add more devices to the PC section

2015-09-22 Thread Paolo Bonzini
For chipset devices, I can co-maintain it with Michael. Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1578db4..8474d22 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -62

[Qemu-devel] [PATCH 05/14] MAINTAINERS: Add more s390 files

2015-09-22 Thread Paolo Bonzini
Cc: Christian Borntraeger Cc: Alexander Graf Signed-off-by: Paolo Bonzini --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 432edc7..c827b04 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -583,6 +583,7 @@ M: Cornelia Huck M: Christian Borntraeg

[Qemu-devel] [PATCH 14/14] MAINTAINERS: Add more devices to realview board

2015-09-22 Thread Paolo Bonzini
Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fe3fb7..85a62d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -374,6 +374,8 @@ Real View M: Peter Maydell S: Maintained F: hw/arm/realview* +F

[Qemu-devel] [PATCH 10/14] MAINTAINERS: add maintainer for character device front-ends

2015-09-22 Thread Paolo Bonzini
Only "Odd Fixes" status, but let's add a point of contact. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 366d763..0580fb9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -732,6 +732,11 @@ F: hw

[Qemu-devel] [PATCH 09/14] MAINTAINERS: add more devices to the PCI section

2015-09-22 Thread Paolo Bonzini
Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8474d22..366d763 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -698,7 +698,9 @@ PCI M: Michael S. Tsirkin S: Supported F: include/hw/pci/*

[Qemu-devel] [PATCH 13/14] MAINTAINERS: Add maintainer for ARM PrimeCell and integrated devices

2015-09-22 Thread Paolo Bonzini
Cc: Peter Maydell Signed-off-by: Paolo Bonzini --- MAINTAINERS | 28 1 file changed, 28 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4f4b523..0fe3fb7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -291,6 +291,34 @@ F: hw/*/allwinner-a10* F: include/hw/

[Qemu-devel] [PATCH 12/14] MAINTAINERS: Add more pxa2xx files and boards

2015-09-22 Thread Paolo Bonzini
Cc: Peter Maydell Cc: Andrzej Zaborowski Signed-off-by: Paolo Bonzini --- MAINTAINERS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2305c48..4f4b523 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -327,11 +327,6 @@ M: Peter Maydell

[Qemu-devel] [PATCH 11/14] MAINTAINERS: add maintainer for network device front-ends

2015-09-22 Thread Paolo Bonzini
Only "Odd Fixes" status, but let's add a point of contact. Cc: Jason Wang Signed-off-by: Paolo Bonzini --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0580fb9..2305c48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -737,6

Re: [Qemu-devel] [PATCH v10 5/7] vhost: introduce vhost_backend_get_vq_index method

2015-09-22 Thread Jason Wang
On 09/18/2015 10:58 PM, Yuanhan Liu wrote: > Minusing the idx with the base(dev->vq_index) for vhost-kernel, and > then adding it back for vhost-user doesn't seem right. Here introduces > a new method vhost_backend_get_vq_index() for getting the right vq > index for following vhost messages calls

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-22 Thread Cao jin
Hi Alex On 09/22/2015 02:00 AM, Alex Williamson wrote: Please use different subjects that uniquely identify what each patch does, don't simply re-use the subject for the cover patch on each. OK, will change it in next version. On Wed, 2015-09-16 at 10:02 +0800, Cao jin wrote: In case user

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: > > > Markus Armbruster writes: > > > >> In my experience, too many files are not covered by MAINTAINERS. > >> scripts/get_maintainer.pl falls back to git then, unless y

Re: [Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap()

2015-09-22 Thread Kevin Wolf
Am 18.09.2015 um 13:03 hat Alberto Garcia geschrieben: > On Thu 17 Sep 2015 03:48:04 PM CEST, Kevin Wolf wrote: > > > bdrv_swap() has always been an ugly hack that we would rather have > > avoided. When it was introduced, we simply didn't have the > > infrastructure to update pointers instead of

[Qemu-devel] [Bug 1481750] Re: qemu-system-ppc hangs when running -M ppce500 -bios u-boot.e500

2015-09-22 Thread thh
Problem should now be fixed with this commit: http://git.qemu-project.org/?p=qemu.git;a=commit;h=d4574435a6530bbd96ae130eddfe5b676f91367a Please test, and close this bug if it is working now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-22 Thread Michael S. Tsirkin
On Mon, Sep 21, 2015 at 11:44:38PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Sep 21, 2015 at 9:29 PM, Michael S. Tsirkin wrote: > >> Can this be considered a future enhancement? > > > > What's the big issue? Just count the devices that need a shared one, if > > that count is 0 reallocate w

Re: [Qemu-devel] [PATCH 1/2] target-ppc: fix vcipher, vcipherlast, vncipherlast and vpermxor

2015-09-22 Thread Thomas Huth
On 13/09/15 23:03, Aurelien Jarno wrote: > For vector instructions, the helpers get pointers to the vector register > in arguments. Some operands might point to the same register, including > the operand holding the result. > > When emulating instructions which access the vector elements in a > no

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Jason Wang
On 09/18/2015 10:58 PM, Yuanhan Liu wrote: > From: Changchun Ouyang > > This patch is initially based a patch from Nikolay Nikolaev. > > This patch adds vhost-user multiple queue support, by creating a nc > and vhost_net pair for each queue. > > Qemu exits if find that the backend can't support

Re: [Qemu-devel] [PATCH 06/14] MAINTAINERS: add IPack section

2015-09-22 Thread Alberto Garcia
On Tue 22 Sep 2015 11:56:45 AM CEST, Paolo Bonzini wrote: > +IPack > +M: Alberto Garcia > +S: Odd Fixes > +F: hw/char/ipoctal232.c > +F: hw/ipack/ Also include/hw/ipack/ipack.h I guess Otherwise, Reviewed-by: Alberto Garcia Thanks, Berto

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 12:06, Daniel P. Berrange wrote: > We could extend the checkpatch.pl script so that it reports an error > if the patch contains a new file which is not covered by MAINTAINERS. > That would immediately prevent the situation getting any worse. Actually Linux has such a check. Any vo

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix xscmpodp and xscmpudp decoding

2015-09-22 Thread Thomas Huth
On 13/09/15 23:03, Aurelien Jarno wrote: > The xscmpodp and xscmpudp instructions only have the AX, BX bits in > there encoding, the lowest bit (usually TX) is marked as an invalid > bit. We therefore can't decode them with GEN_XX2FORM, which decodes > the two lowest bit. > > Introduce a new form

[Qemu-devel] [PATCH v4 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-22 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple backup volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://server1[:port]/testvol/a.img Assuming we have hav

Re: [Qemu-devel] [PATCH 05/14] MAINTAINERS: Add more s390 files

2015-09-22 Thread Christian Borntraeger
Am 22.09.2015 um 11:56 schrieb Paolo Bonzini: > Cc: Christian Borntraeger > Cc: Alexander Graf > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 432edc7..c827b04 100644 > --- a/MAINTAINERS > +++ b/MAINT

Re: [Qemu-devel] [PATCH 08/14] MAINTAINERS: add more devices to the PC section

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 11:56:47AM +0200, Paolo Bonzini wrote: > For chipset devices, I can co-maintain it with Michael. > > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini Thanks a lot, I'll merge this! > --- > MAINTAINERS | 19 +++ > 1 file changed, 19 insertions(+) >

Re: [Qemu-devel] [PATCH 08/14] MAINTAINERS: add more devices to the PC section

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 11:56:47AM +0200, Paolo Bonzini wrote: > For chipset devices, I can co-maintain it with Michael. > > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin > --- > MAINTAINERS | 19 +++ > 1 file changed, 19 insertions(+)

Re: [Qemu-devel] [PATCH 09/14] MAINTAINERS: add more devices to the PCI section

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 11:56:48AM +0200, Paolo Bonzini wrote: > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8474d22..366d763 100644 > --

[Qemu-devel] [ANNOUNCE] libcacard 2.5.0 released

2015-09-22 Thread Marc-André Lureau
Hi As previously discussed in the thread "libcacard: use the library?", libcacard has been made a standalone project, which is now hosted next with the Spice project. release: http://www.spice-space.org/download/libcacard/libcacard-2.5.0.tar.xz sha1sum: bbb211beaea3085bc2ced14c610f508db181fc2d g

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-22 Thread Marc-André Lureau
Hi On Tue, Sep 22, 2015 at 12:12 PM, Michael S. Tsirkin wrote: >> But then it should also VHOST_SET_LOG_BASE all the other devices with >> the new log, unless you want to tackle only the future log users. So >> it needs to track all the users of the log. > > We already do this. > Same applies to

Re: [Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-22 Thread Pavel Butsykin
On 21.09.2015 16:59, Paolo Bonzini wrote: IRR 239 APR 0x00 TPR 0x00 DFR 0x0f LDR 0x00 PPR 0x00 (qemu) info ioapic ioapic id=0x00 sel=0x2e (redir[15]) pin 0 0x0001 dest=0 vec=0 active-hi edge masked fixed physical pin 1 0x0031 dest=0 vec=49 active-hi edge

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

2015-09-22 Thread Paolo Bonzini
On 30/08/2015 13:29, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > As previously discussed in the thread "libcacard: use the library?", > make libcacard a standalone library and use it if --enable-smartcard. > > I made the following repo out of a qemu filter-branch and added

Re: [Qemu-devel] [PATCH v3 0/9] hmp command IO- and Local APIC dump state

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 12:46, Pavel Butsykin wrote: >>> >> I would print IRR as a bitmap here, like ISR/IRR in the local APIC dump. >> Similarly, it would be nice to print the "Remote IRR" bits of the >> redirection table (printing them as a bitmap with the same format). > ... > > pin 9 0x0001

Re: [Qemu-devel] [PATCH v5 0/4] qapi: child add/delete support

2015-09-22 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > If quorum's child is broken, we can use mirror job to replace it. > But sometimes, the user only need to remove the broken child, and > add it later when the problem is fixed. > Hi, Two questions: 1) Do you have an example of a pair of add/remo

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

2015-09-22 Thread Marc-André Lureau
Hi On Tue, Sep 22, 2015 at 1:06 PM, Paolo Bonzini wrote: > > > On 30/08/2015 13:29, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> As previously discussed in the thread "libcacard: use the library?", >> make libcacard a standalone library and use it if --enable-smartcard. >>

Re: [Qemu-devel] [PATCH] libcacard: use the standalone project

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 13:29, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > libcacard is now a standalone project hosted with the Spice project (see > the 2.5.0 release announcement), remove it from qemu tree. > > Use the library if found during configure or if --enable-smartcard. >

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 01:01:03PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Sep 22, 2015 at 12:12 PM, Michael S. Tsirkin wrote: > >> But then it should also VHOST_SET_LOG_BASE all the other devices with > >> the new log, unless you want to tackle only the future log users. So > >> it need

Re: [Qemu-devel] [PATCH] libcacard: use the standalone project

2015-09-22 Thread Michael Tokarev
22.09.2015 14:29, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > libcacard is now a standalone project hosted with the Spice project (see > the 2.5.0 release announcement), remove it from qemu tree. > > Use the library if found during configure or if --enable-smartcard. > > Si

Re: [Qemu-devel] [PULL 0/1] spice: surface switch fast path requires same format too.

2015-09-22 Thread Peter Maydell
On 21 September 2015 at 02:13, Gerd Hoffmann wrote: > Hi, > > Spice patch queue, carrying a single bugfix. > > please pull, > Gerd > > The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter'

Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support

2015-09-22 Thread Michael S. Tsirkin
On Fri, Sep 18, 2015 at 10:58:43PM +0800, Yuanhan Liu wrote: > From: Changchun Ouyang > > This patch is initially based a patch from Nikolay Nikolaev. > > This patch adds vhost-user multiple queue support, by creating a nc > and vhost_net pair for each queue. > > Qemu exits if find that the bac

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-22 Thread Marc-André Lureau
hi On Tue, Sep 22, 2015 at 1:41 PM, Michael S. Tsirkin wrote: > There's a single log at the moment: > static struct vhost_log *vhost_log; > > But all devices are updated by the memory core, we don't > have a list in the vhost code. Do you mean that all devices will have their memory list

Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

2015-09-22 Thread Michael S. Tsirkin
On Tue, Sep 22, 2015 at 01:50:47PM +0200, Marc-André Lureau wrote: > hi > > On Tue, Sep 22, 2015 at 1:41 PM, Michael S. Tsirkin wrote: > > There's a single log at the moment: > > static struct vhost_log *vhost_log; > > > > But all devices are updated by the memory core, we don't > > have

[Qemu-devel] [PULL 2/2] hmp: Restore "info pci"

2015-09-22 Thread Markus Armbruster
From: Paolo Bonzini Dropped by commit da76ee76f78b9705e2a91e3c964aef28fecededb's transition to hmp-commands-info.hx. Reported-by: Markus Armbruster Signed-off-by: Paolo Bonzini Message-Id: <1442589509-10806-1-git-send-email-pbonz...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Markus Ar

[Qemu-devel] [PULL 1/2] monitor: allow device_del to accept QOM paths

2015-09-22 Thread Markus Armbruster
From: "Daniel P. Berrange" Currently device_del requires that the client provide the device short ID. device_add allows devices to be created without giving an ID, at which point there is no way to delete them with device_del. The QOM object path, however, provides an alternative way to identify

[Qemu-devel] [PULL 0/2] Monitor patches

2015-09-22 Thread Markus Armbruster
The following changes since commit 9e72681d16792d0ffc42bab634b1753ff299bdfd: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-09-21' into staging (2015-09-21 22:33:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-09-22

Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Paolo Bonzini
On 18/09/2015 15:19, Daniel P. Berrange wrote: > The Buffer code in the VNC server is useful for the IO channel > code, so pull it out into a shared module, QIOBuffer. Do all traces disappear from VNC once you're done? If not, can you instead move it to util/? Paolo > Signed-off-by: Daniel P.

Re: [Qemu-devel] [PATCH v1 06/16] coroutine: move into libqemuutil.a library

2015-09-22 Thread Paolo Bonzini
On 18/09/2015 15:19, Daniel P. Berrange wrote: > The coroutine files are currently referenced by the block-obj-y > variable. The coroutine functionality though is already used by > more than just the block code. eg migration code uses coroutine > yield. In the future the I/O channel code will als

Re: [Qemu-devel] [PULL 0/4] update to 35c53797 to 4e03af8

2015-09-22 Thread Gerd Hoffmann
On Di, 2015-09-15 at 12:25 +0200, Gerd Hoffmann wrote: > On Do, 2015-09-03 at 14:32 +0100, Peter Maydell wrote: > > On 3 September 2015 at 14:02, Gerd Hoffmann wrote: > > > Hi, > > > > > > Here comes the ipxe update pull. Thanks to Stefan all bits are upstream > > > now. Also upstream has a na

Re: [Qemu-devel] [PATCH v1 07/16] io: add abstract QIOChannel classes

2015-09-22 Thread Paolo Bonzini
On 18/09/2015 15:19, Daniel P. Berrange wrote: > +QIO_CHANNEL_FEATURE_FD_PASS = (1 << 0), > +QIO_CHANNEL_FEATURE_SHUTDOWN = (1 << 1), > +QIO_CHANNEL_FEATURE_DELAY= (1 << 2), > +QIO_CHANNEL_FEATURE_CORK = (1 << 3), TCP_NODELAY and TCP_CORK are just hints; I think it is ok

Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:04:35PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > The Buffer code in the VNC server is useful for the IO channel > > code, so pull it out into a shared module, QIOBuffer. > > Do all traces disappear from VNC once you're done?

Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 14:20, Daniel P. Berrange wrote: > It is still used in VNC code for decoding of various framebuffer > encodings. Only the websock usage gets eliminated. I'm happy to > move it to util/ directory. Any preference on a name for the > APIs. I used QIOBuffer since i placed it under io/

Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework

2015-09-22 Thread Paolo Bonzini
On 18/09/2015 15:18, Daniel P. Berrange wrote: > David Gilbert had some feedback on my previous RFC series which > I have incorporated into this new posting. I did forget his > comments about using #defines instead of magic constants in > the websock patch, so that's still on my todo list. > > F

Re: [Qemu-devel] [PATCH v1 07/16] io: add abstract QIOChannel classes

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:19:27PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > +QIO_CHANNEL_FEATURE_FD_PASS = (1 << 0), > > +QIO_CHANNEL_FEATURE_SHUTDOWN = (1 << 1), > > +QIO_CHANNEL_FEATURE_DELAY= (1 << 2), > > +QIO_CHANNEL_FEATURE_CO

Re: [Qemu-devel] [PATCH v1 07/16] io: add abstract QIOChannel classes

2015-09-22 Thread Paolo Bonzini
On 22/09/2015 14:24, Daniel P. Berrange wrote: > On Tue, Sep 22, 2015 at 02:19:27PM +0200, Paolo Bonzini wrote: >> >> >> On 18/09/2015 15:19, Daniel P. Berrange wrote: >>> +QIO_CHANNEL_FEATURE_FD_PASS = (1 << 0), >>> +QIO_CHANNEL_FEATURE_SHUTDOWN = (1 << 1), >>> +QIO_CHANNEL_FEATURE_

Re: [Qemu-devel] [PATCH v12 1/5] apic: move APIC's MMIO region mapping into APIC

2015-09-22 Thread Igor Mammedov
On Wed, 16 Sep 2015 17:19:11 +0800 Zhu Guihua wrote: > From: Chen Fan > > When ICC bus/bridge is removed, APIC MMIO will be left > unmapped since it was mapped into system's address space > indirectly by ICC bridge. > Fix it by moving mapping into APIC code, so it would be > possible to remove

Re: [Qemu-devel] [PATCH v12 3/5] x86: use new method to correct reset sequence

2015-09-22 Thread Igor Mammedov
On Wed, 16 Sep 2015 17:19:13 +0800 Zhu Guihua wrote: > During reset some devices (such as hpet, rtc) might send IRQ to APIC > which changes APIC's state from default one it's supposed to have > at machine startup time. > Fix this by resetting APIC after devices have been reset to cancel > any cha

Re: [Qemu-devel] [PATCH v12 2/5] apic: use per CPU AS to map APIC MMIO for TCG

2015-09-22 Thread Igor Mammedov
On Wed, 16 Sep 2015 17:19:12 +0800 Zhu Guihua wrote: > TCG supports per CPU address space, and the emulation quality is > a bit better with it. > So use per CPU address space to map APIC MMIO area. This allows the > APIC base address of each cpu to be moved independent of others. > > Signed-off-

Re: [Qemu-devel] [PATCH v12 5/5] icc_bus: drop the unused files

2015-09-22 Thread Igor Mammedov
On Wed, 16 Sep 2015 17:19:15 +0800 Zhu Guihua wrote: > ICC bus impl has been droped, so all icc related files are not useful > any more; delete them. > > Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov > --- > default-configs/i386-softmmu.mak | 1 - > default-configs/x86_64-softmmu

Re: [Qemu-devel] [PATCH v12 4/5] cpu/apic: drop icc bus/bridge

2015-09-22 Thread Igor Mammedov
On Wed, 16 Sep 2015 17:19:14 +0800 Zhu Guihua wrote: > From: Chen Fan > > After CPU hotplug has been converted to BUS-less hot-plug infrastructure, > the only function ICC bus performs is to propagate reset to LAPICs. However > LAPIC could be reset by registering its reset handler after all dev

Re: [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64

2015-09-22 Thread Michael S. Tsirkin
On Fri, Jun 05, 2015 at 03:38:21PM +0100, Stefan Hajnoczi wrote: > Hi Stefan, > I get the following compiler warning in Fedora 22 > (mingw32-headers-4.0.2-1.fc22): > > In file included from qemu/include/qemu-common.h:47:0, > from qemu/include/qemu/timer.h:5, > fro

Re: [Qemu-devel] [PATCH v18 00/21] Deterministic replay core

2015-09-22 Thread Paolo Bonzini
On 21/09/2015 09:12, Pavel Dovgaluk wrote: > Hi! > > Paolo, have you reviewed these patches? Yes, I'll reply to a couple of them but there's no need to send v19. Paolo > Pavel Dovgalyuk > >> -Original Message- >> From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] >> Sent: Thursd

Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-22 Thread Paolo Bonzini
On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > +if ((now < last || now > (last + get_max_clock_jump())) > +&& replay_mode == REPLAY_MODE_NONE) { > notifier_list_notify(&clock->reset_notifiers, &now); This seems wrong. You will have different timers in the record

  1   2   3   4   >