Make valgrind happy with the current state of the test, so that
it is easier to see if future patches introduce new memory
problems without being drowned in noise.
Signed-off-by: Eric Blake
---
tests/test-qmp-input-visitor.c | 34 +++---
1 file changed, 31 insertions(
We finally have all the required pieces for doing a type-safe
representation of netdev_add as a flat union, where the
discriminator 'type' now selects which additional members may
appear in the "arguments" JSON object sent over QMP, while
making no changes to the set of previously-valid QMP command
Now that we no longer have any clients of the 'void *data'
member injected into unions, we can drop it. Update the
testsuite to drop the negative test union-clash2, and
replace it with a positive test in qapi-schema-test that
proves that we no longer have a name collision.
Signed-off-by: Eric Bla
From: Kővágó, Zoltán
This way we no longer need NetClientOptions and can convert Netdev
into a flat union.
Signed-off-by: Kővágó, Zoltán
Reviewed-by: Eric Blake
Message-Id:
<93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com>
[rework net_client_init1() to pass Net
A future qapi patch will rework generated structs with a base
class to be unboxed. In preparation for that, change the code
that allocates then populates an info struct to instead merely
populate the fields of an info field passed in as a parameter.
Add rudimentary Error handling for cases where t
This patch completes support for boxed types, by allowing
union types to be used when 'box':true is specified. It also
avoids a python crash when attempting to use boxing on an
anonymous type. While it was possible to support 'box':true
on an empty event, it was easier to just reject missing 'dat
From: Chen Gang
v4* are implemented in normal code, another are implemented in helper
functions.
Signed-off-by: Chen Gang
---
target-tilegx/helper.h | 5 +
target-tilegx/simd_helper.c | 23 +++
target-tilegx/translate.c | 46 +
is_netdev is only used as a bool, so make it one.
Signed-off-by: Eric Blake
---
hw/usb/dev-network.c | 2 +-
include/net/net.h| 2 +-
net/net.c| 12 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 97b
A future patch will add support for passing a qapi union
type as the 'data' of a command. But to do that, the user
function for implementing the command, as called by the
generated marshal command, must take the corresponding C
struct as a single boxed pointer, rather than a breakdown
into one par
On 2015-09-17 21:55, Richard Henderson wrote:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-arm/cpu.h | 1 +
> target-arm/translate-a64.c | 2 +-
> target-arm/translate.c | 3 ++-
> 3 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Aure
On 2015-09-17 21:55, Richard Henderson wrote:
> With an eye toward having this data replace the gen_opc_* arrays
> that each target collects in order to enable restore_state_from_tb.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg-op.h | 52 +++
On 2015-09-17 21:55, Richard Henderson wrote:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-mips/cpu.h | 1 +
> target-mips/translate.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Aurelien Jarno
--
Aurelien Jarno
On 2015-09-17 21:55, Richard Henderson wrote:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-s390x/cpu.h | 1 +
> target-s390x/translate.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Aurelien Jarno
--
Aurelien Jarno
On 2015-09-17 21:55, Richard Henderson wrote:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-i386/cpu.h | 1 +
> target-i386/translate.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Aurelien Jarno
--
Aurelien Jarno
Rather than requiring all flat unions to explicitly create
a separate base struct, we want to allow the qapi schema
to specify the common fields via an inline dictionary. This
is similar to how commands can specify inline types for the
arguments.
Now that the feature is legal, we can drop the form
On 2015-09-17 21:55, Richard Henderson wrote:
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target-sh4/cpu.h | 1 +
> target-sh4/translate.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Aurelien Jarno
--
Aurelien Jarno
On 09/15/2015 02:11 AM, Fam Zheng wrote:
> So that block_job_complete_sync can be simplified.
>
> Reviewed-by: Max Reitz
> Signed-off-by: Fam Zheng
> ---
> block/mirror.c | 2 +-
> blockjob.c | 22 ++
> include/block/blockjob.h | 18 +++
On 09/15/2015 02:11 AM, Fam Zheng wrote:
> Reviewed-by: Max Reitz
> Signed-off-by: Fam Zheng
> ---
> include/block/blockjob.h | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/include/block/blockjob.h b/include/block/blockjob.h
> index 3e7ad21..a7b497c 100644
> ---
From: Chen Gang
Only according to v1shrs implementation.
Signed-off-by: Chen Gang
Reviewed-by: Richard Henderson
---
target-tilegx/helper.h | 2 ++
target-tilegx/simd_helper.c | 13 +
target-tilegx/translate.c | 4
3 files changed, 19 insertions(+)
diff --git a/targ
The related code are changed, so this patch has to be reconstructed.
Thanks
On 9/22/15 06:26, gang.chen.5...@gmail.com wrote:
> From: Chen Gang
>
> Only according to v1shrs implementation.
>
> Signed-off-by: Chen Gang
> Reviewed-by: Richard Henderson
> ---
> target-tilegx/helper.h | 2 ++
> ta
On 09/15/2015 02:11 AM, Fam Zheng wrote:
> With job->completed and job->ret to replace BlockFinishData.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: Max Reitz
> ---
> blockjob.c | 27 ++-
> 1 file changed, 6 insertions(+), 21 deletions(-)
>
> diff --git a/blockjob.c b/
On 09/15/2015 02:11 AM, Fam Zheng wrote:
> Sometimes block jobs must execute as a transaction group. Finishing
> jobs wait until all other jobs are ready to complete successfully.
> Failure or cancellation of one job cancels the other jobs in the group.
>
> Signed-off-by: Stefan Hajnoczi
> [Re
On 21 September 2015 at 01:03, Markus Armbruster wrote:
> The following changes since commit 18640989a9f5e4d2e84b566c52ff1fccfa0dbf4a:
>
> Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter'
> into staging (2015-09-19 15:59:52 +0100)
>
> are available in the git repositor
Sorry, at this point, I've moved to compiling from Ubuntu as you suggested
earlier.
On Sun, Sep 20, 2015 at 9:19 PM, Mike Ladouceur
wrote:
> Okay, i followed the steps from the reply to my email I noticed on the
> website, but never made its way to my inbox. Now, I'm stuck with the
> following e
Oh, v1sub and v2sub look incorrect, need use ^b instead of ^~b.
Thanks.
> From: gang.chen.5...@gmail.com
> To: peter.mayd...@linaro.org; r...@twiddle.net
> CC: qemu-devel@nongnu.org; xili_gchen_5...@hotmail.com;
> gang.chen.5...@gmail.com
> Subject: [PATCH v2] target-tilegx: Implement v*add and
Thanks for looking into it, Laszlo. I've already tried dosbox and had
no idea qemu was impractical.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/893208
Title:
qemu on ARM hosts can't boot i386 ima
On Fri, 09/18 13:45, Max Reitz wrote:
> On 15.09.2015 08:11, Fam Zheng wrote:
> > From: Stefan Hajnoczi
> >
> > The BlockJobTxn unit test verifies that both single jobs and pairs of
> > jobs behave as a transaction group. Either all jobs complete
> > successfully or the group is cancelled.
> >
On Mon, Sep 21, 2015 at 10:37:28AM +0200, Greg Kurz wrote:
> On Mon, 21 Sep 2015 10:26:52 +0200
> Thomas Huth wrote:
>
> > On 21/09/15 10:01, Greg Kurz wrote:
> > > On Mon, 21 Sep 2015 12:10:00 +1000
> > > David Gibson wrote:
> > >
> > >> On Fri, Sep 18, 2015 at 11:05:52AM +0200, Greg Kurz wrot
On Mon, 09/21 18:29, John Snow wrote:
>
>
> On 09/15/2015 02:11 AM, Fam Zheng wrote:
> > Reviewed-by: Max Reitz
> > Signed-off-by: Fam Zheng
> > ---
> > include/block/blockjob.h | 18 ++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/include/block/blockjob.h b/inclu
On Mon, 09/21 19:23, John Snow wrote:
> > void block_job_completed(BlockJob *job, int ret)
> > {
> > BlockDriverState *bs = job->bs;
> > @@ -98,8 +191,13 @@ void block_job_completed(BlockJob *job, int ret)
> > assert(!job->completed);
> > job->completed = true;
> > job->ret =
Sometimes block jobs must execute as a transaction group. Finishing
jobs wait until all other jobs are ready to complete successfully.
Failure or cancellation of one job cancels the other jobs in the group.
Signed-off-by: Stefan Hajnoczi
[Rewrite the implementation which is now contained in bloc
From: John Snow
These structures are misnomers, somewhat.
(1) BlockTransactionState is not state for a transaction,
but is rather state for a single transaction action.
Rename it "BlkActionState" to be more accurate.
(2) The BdrvActionOps describes operations for the BlkActionState,
v7: Add Eric's rev-by in 1, 11.
Add Max's rev-by in 4, 5, 9, 10, 11.
Add John's rev-by in 5, 6, 8.
Fix wording for 6. [John]
Fix comment of block_job_txn_add_job() in 9. [Max]
Remove superfluous hunks, and document default value in 11. [Eric]
Update Makefile dep in 14. [Max]
From: John Snow
Test simple usage cases for using transactions to create
and synchronize incremental backups.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/
So that block_job_complete_sync can be simplified.
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Signed-off-by: Fam Zheng
---
block/mirror.c | 2 +-
blockjob.c | 22 ++
include/block/blockjob.h | 18 +++---
3 files changed, 30 insertions
They are set when block_job_completed is called.
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Reviewed-by: Max Reitz
---
blockjob.c | 3 +++
include/block/blockjob.h | 9 +
2 files changed, 12 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index ec12887..293b62a 1
From: Stefan Hajnoczi
Join the transaction when the 'transactional-cancel' QMP argument is
true.
This ensures that the sync bitmap is not thrown away if another block
job in the transaction is cancelled or fails. This is critical so
incremental backup with multiple disks can be retried in case
With job->completed and job->ret to replace BlockFinishData.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Reviewed-by: John Snow
---
blockjob.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 293b62a..36c18e0 100
From: Stefan Hajnoczi
Provide a BlockJobTxn to actions executed in a qmp 'transaction'
command. This allows actions to make their block jobs either complete
as a group or fail/cancel together.
The next patch adds the first user.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Reviewed-
From: Stefan Hajnoczi
The BlockJobTxn unit test verifies that both single jobs and pairs of
jobs behave as a transaction group. Either all jobs complete
successfully or the group is cancelled.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/Makefile
From: John Snow
Use a transaction to request an incremental backup across two drives.
Coerce one of the jobs to fail, and then re-run the transaction.
Verify that no bitmap data was lost due to the partial transaction
failure.
To support the 'transactional-cancel' QMP argument name it's necessa
From: Kashyap Chamarthy
Although the canonical source of reference for QMP commands is
qapi-schema.json, for consistency's sake, update qmp-commands.hx to
state the list of supported transactionable operations, namely:
drive-backup
blockdev-backup
blockdev-snapshot-internal-sync
From: John Snow
This adds two qmp commands to transactions.
block-dirty-bitmap-add allows you to create a bitmap simultaneously
alongside a new full backup to accomplish a clean synchronization
point.
block-dirty-bitmap-clear allows you to reset a bitmap back to as-if
it were new, which can als
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Signed-off-by: Fam Zheng
---
include/block/blockjob.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index 3e7ad21..aee39a4 100644
--- a/include/block/blockjob.h
+++ b/in
This will be reused by the coming new transactional completion code.
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Reviewed-by: Max Reitz
---
block/backup.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index
HTAB size is a factor of maximum memory size that is specified by maxmem=
command line option. In cases where there is shortage of host memory, host
will not be able to allocate contiguous memory for guest HTAB and will
instead allocate a smaller HTAB. This usually is not a problem but when
user st
Terminate the guest when HTAB of requested size isn't allocated by
the host.
When memory hotplug is attempted on a guest that has booted with
less than requested HTAB size, the guest kernel will not be able
to gracefully fail the hotplug request. This patch will ensure that
we never end up in a si
Allocate HTAB from ppc_spapr_init() so that we can abort the guest
if requested HTAB size is't allocated by the host. However retain the
htab reset call in spapr_reset_htab() so that HTAB gets reset (and
not allocated) during machine reset.
Signed-off-by: Bharata B Rao
---
hw/ppc/spapr.c | 13 ++
On 09/21/2015 05:45 PM, Chen Gang wrote:
Oh, v1sub and v2sub look incorrect, need use ^b instead of ^~b.
They're incorrect, but it's not ~b. Look back and the equation I gave you.
r~
> On 22 Sep 2015, at 03:00, Mike Ladouceur wrote:
>
> Sorry, at this point, I've moved to compiling from Ubuntu as you suggested
> earlier.
another option, suitable for production environments, where repeatability is
important, is to use Docker images.
you can take a look at how GNU ARM Ecli
On 2015年09月19日 10:34, Richard Henderson wrote:
>
> There's a trick for this that's more efficient for 4 or more elements
> per vector (i.e. good for v2 and v1, but not v4):
>
>a + b = (a & 0x7f7f7f7f) + (b & 0x7f7f7f7f)) ^ ((a ^ b) & 0x80808080)
>
>a - b = (a | 0x80808080) - (b & 0x7f7f7
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi:
On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote:
upcoming libnfs versions will support logging debug messages. Add
support for it in qemu through an URL parameter.
Signed-off-by: Peter Lieven
---
block/nfs.c | 4
1 file chang
Move sdhci.h splitting it into common and internal.
Create a new directory for sd in include/hw/.
Correct paths of sd.h in at every instance of #include.
Sai Pavan Boddu (2):
sd.h: Move sd.h to include/hw/sd/
sdhci: Split sdhci.h for public and internal device usage
hw/sd/milkymist-memcard.c
Create a sd director under include/hw/ and move sd.h to same.
Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
---
Changes for V5:
None
Changes for V4:
Fix commit message.
Changes for V3:
None.
---
hw/sd/milkymist-memcard.c | 2 +-
hw/sd/omap_mmc.c | 2 +-
hw/sd
Split sdhci.h into pubilc Version (i.e include/hw/sd/sdhci.h) and
internal version (i.e hw/sd/sdhci-interna.h) base on register
declarations and object declaration.
Signed-off-by: Sai Pavan Boddu
---
Chagdes for V5:
Rename pubilc header version as sdhci.h and internal version to
sdhci-interna
Move sdhci.h splitting it into common and internal.
Create a new directory for sd in include/hw/.
Correct paths of sd.h in at every instance of #include.
Sai Pavan Boddu (2):
sd.h: Move sd.h to include/hw/sd/
sdhci: Split sdhci.h for public and internal device usage
hw/sd/milkymist-memcard.c
Create a sd directory under include/hw/ and move sd.h to same.
Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
---
Changes for V6:
Fix commit message.
Changes for V5:
None
Changes for V4:
Fix commit message.
Changes for V3:
None.
---
hw/sd/milkymist-memcard.c | 2 +-
Split sdhci.h into Pubilc version (i.e include/hw/sd/sdhci.h) and
Internal version (i.e hw/sd/sdhci-interna.h) based on register
declarations and object declaration.
Signed-off-by: Sai Pavan Boddu
---
Changes for V6:
Fix commit message.
Chages for V5:
Rename pubilc header version as sdhci
201 - 258 of 258 matches
Mail list logo
