[Qemu-devel] [PULL 26/35] target-tilegx: Handle shift instructions

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 56 +-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index ba56a2e..f15d0d0 100644 --- a

[Qemu-devel] [PULL 28/35] target-tilegx: Handle scalar multiply instructions

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 31b6a6c..673b441 100644 --- a/target-tilegx/

[Qemu-devel] [PULL 15/35] target-tilegx: Handle arithmetic instructions

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 96 --- 1 file changed, 90 insertions(+), 6 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 68c7db2..6b5de55 100644 --- a

Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- The commit message summary mentions a one-line "what" (good), but is lacking a body that says "why" (that is, what was broken that needed fixing?) > block.c | 2 +- > in

Re: [Qemu-devel] [PATCH 02/17] block: add bdrv_dirty_bitmap_size()

On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 5 + > include/block/block.h | 1 + > 2 files changed, 6 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Lib

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

ping On 08/24/2015 06:15 PM, John Snow wrote: > > > On 06/18/2015 10:05 AM, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 18 June 2015 at 10:28, Markus Armbruster wrote: However, I can't see how I could define a new C style there without pushing the "local variables" fe

[Qemu-devel] KVM call for agenda for 2015-09-29

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

On 09/15/2015 04:06 AM, Markus Armbruster wrote: > John Snow writes: > >> We're supposed to abort on transfers like this, unless we fill >> Word 125 of our IDENTIFY data with a default transfer size, which >> we don't currently do. >> >> This is an ATA error, not a SCSI/ATAPI one. >> See ATA8-A

[Qemu-devel] [PULL 30/35] target-tilegx: Handle v1cmpeq, v1cmpne

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 8b7c719..9b0d819 100644 --- a/target-tilegx/t

[Qemu-devel] [PATCH v3 14/46] ivshmem: remove useless ivshmem_update_irq() val argument

From: Marc-André Lureau val isn't used in ivshmem_update_irq() function. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index e890967..3398a57 100644 --- a/hw/misc/ivshmem.

[Qemu-devel] [PATCH v3 25/46] ivshmem: check shm isn't already initialized

From: Marc-André Lureau The server should not change the shm, and this isn't handled by qemu. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index c80503d..493e3c7 100644 --- a/hw/misc/ivshm

[Qemu-devel] [PATCH v3 34/46] ivshmem-server: fix hugetlbfs support

From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, create a shareable file there. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-server/ivshmem-server.c | 40

[Qemu-devel] [PATCH v3 02/46] msix: add VMSTATE_MSIX_TEST

From: Marc-André Lureau ivshmem is going to use MSIX state conditionally. Signed-off-by: Marc-André Lureau --- include/hw/pci/msix.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h index 954d82b..72e5f93 100644

[Qemu-devel] [PATCH v3 16/46] ivshmem: remove max_peer field

From: Marc-André Lureau max_peer isn't really useful, it tracks the maximum received VM id, but that quickly matches nb_peers, the size of the peers array. Since VM come and go, there might be sparse peers so it doesn't help much in general to have this value around. Signed-off-by: Marc-André Lu

[Qemu-devel] [PATCH v3 08/46] ivshmem: remove useless doorbell field

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 5e4b2cc..1b8204e 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -71,7 +71,6 @@ typedef struct IVShmemState {

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

On Tue, Sep 15, 2015 at 09:31:08AM -0600, Eric Blake wrote: > ping > > On 08/24/2015 06:15 PM, John Snow wrote: > > > > > > On 06/18/2015 10:05 AM, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On 18 June 2015 at 10:28, Markus Armbruster wrote: > However, I can't see how

[Qemu-devel] [PATCH v3 01/46] char: add qemu_chr_free()

From: Marc-André Lureau If a chardev is allowed to be created outside of QMP, then it must be also possible to free it. This is useful for ivshmem that creates chardev anonymously and must be able to free them. Signed-off-by: Marc-André Lureau Acked-by: Paolo Bonzini --- include/sysemu/char.h

[Qemu-devel] [PATCH v3 27/46] ivshmem: fix pci_ivshmem_exit()

From: Marc-André Lureau Free all objects owned by the device, making sure the device is free, fixing hot-unplug. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v3 00/46] ivshmem improvements (please review)

From: Marc-André Lureau Hi, This series is mostly about adding the client/server code from David Marchand, code cleanups, and little improvements and fixes for ivshmem. Finally there is some ivshmem tests (they work fine without kvm btw). The first two series didn't get much feedback, and the t

[Qemu-devel] [PATCH v3 19/46] ivshmem: print error on invalid peer id

From: Marc-André Lureau The server shouldn't send invalid peer id, so print an error if it's the case. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 52e1e63..1c98ec3 100644 --- a/hw/misc/iv

[Qemu-devel] [PATCH v3 05/46] ivshmem: factor out the incoming fifo handling

From: Marc-André Lureau Make a new function fifo_update_and_get() that can be reused by other functions (in next commits). Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-) dif

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On 26/08/2015 12:40, Xiao Guangrong wrote: >>> >>> + >>> +size = get_file_size(fd); >>> +buf = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); >> >> I guess the user will want to choose between MAP_SHARED and MAP_PRIVATE. >> This can be added in the future. > > Good idea, it

[Qemu-devel] [PATCH v3 15/46] ivshmem: initialize max_peer to -1

From: Marc-André Lureau There is no peer when device is initialized, do not let doorbell for inexisting peer 0. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 3398a57..07

[Qemu-devel] [PATCH v3 22/46] ivshmem: use common is_power_of_2()

From: Marc-André Lureau The common version correctly checks for 0 value case. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index e391396..f40bc98 100644 --- a/hw/misc/ivshme

[Qemu-devel] [PATCH v3 03/46] ivhsmem: read do not accept more than sizeof(long)

From: Marc-André Lureau ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

[Qemu-devel] [PATCH v3 41/46] ivshmem: do not keep shm_fd open

From: Marc-André Lureau Remove shm_fd from device state, closing it as early as possible to avoid leaks. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 4adcac5

[Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

From: Marc-André Lureau Some misc improvements to ivshmem debug. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index cda7dce..084bc89 100644 --- a/hw/misc/ivshmem.c +++

[Qemu-devel] [PATCH v3 26/46] ivshmem: add device description

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 493e3c7..5e96360 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -922,6 +922,7 @@ static void ivshmem_class_in

[Qemu-devel] [PATCH v3 23/46] ivshmem: migrate with VMStateDescription

From: Marc-André Lureau load_state_old() is used to keep compatibility with version 0. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 141 ++ 1 file changed, 88 insertions(+), 53 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/mis

[Qemu-devel] [PATCH v3 12/46] ivshmem: simplify around increase_dynamic_storage()

From: Marc-André Lureau Set the number of peers and array allocation in a single place. Rename to better reflect the function content. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/hw/mis

[Qemu-devel] [PATCH v3 46/46] ivshmem: use kvm irqfd for msi notifications

From: Marc-André Lureau Use irqfd for improving context switch when notifying the guest. If the host doesn't support kvm irqfd, regular msi notifications are still supported. Note: the ivshmem implementation doesn't allow switching between MSI and IO interrupts, this patch doesn't either. Signe

[Qemu-devel] [PATCH v3 20/46] ivshmem: simplify a bit the code

From: Marc-André Lureau Use some more explicit variables to simplify the code. nth_eventfd variable is the current eventfd to be manipulated. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On 01/09/2015 11:14, Stefan Hajnoczi wrote: >> > >> > When I was digging into live migration code, i noticed that the same MR >> > name may >> > cause the name "idstr", please refer to qemu_ram_set_idstr(). >> > >> > Since nvdimm devices do not have parent-bus, it will trigger the abort() >>

[Qemu-devel] [PULL 35/35] target-tilegx: Handle v1shl, v1shru, v1shrs

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/Makefile.objs | 2 +- target-tilegx/helper.h | 4 target-tilegx/simd_helper.c | 55 + target-tilegx/translate.c | 17 +- 4 files changed, 76 inserti

[Qemu-devel] [PATCH v3 10/46] ivshmem: remove last exit(1)

From: Marc-André Lureau Failing to create a chardev shouldn't be fatal. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 3af73a5..7ba93c0 100644 --- a/hw/misc/ivshmem.c +++ b/h

Re: [Qemu-devel] [PATCH v2 09/18] nvdimm: build ACPI NFIT table

On 14/08/2015 16:52, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 tables: > - SPA table, define the PMEM region info > > - MEM DEV table, it has the @handle which is used to associa

[Qemu-devel] [PATCH v3 30/46] ivshmem: reset mask on device reset

From: Marc-André Lureau The interrupt mask is a state value, it should be reset, like the value. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 63e4c4f..6c0a829 100644 --- a/hw/misc/ivshmem.

[Qemu-devel] [PATCH v3 21/46] ivshmem: use common return

From: Marc-André Lureau Both if branches return, move this out to common end. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index a60454f..e391396 100644 --- a/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v3 11/46] ivshmem: limit maximum number of peers to G_MAXUINT16

From: Marc-André Lureau Limit the maximum number of peers to MAXUINT16. This is more realistic and better matches the limit of the doorbell register. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On 25/08/2015 18:03, Stefan Hajnoczi wrote: >> > >> > +static uint64_t get_file_size(int fd) >> > +{ >> > +struct stat stat_buf; >> > +uint64_t size; >> > + >> > +if (fstat(fd, &stat_buf) < 0) { >> > +return 0; >> > +} >> > + >> > +if (S_ISREG(stat_buf.st_mode)) { >>

[Qemu-devel] [PATCH v3 04/46] ivshmem: fix number of bytes to push to fifo

From: Marc-André Lureau If the fifo has 0 bytes, and the read is of size 1, the call to fifo8_push_all() will copy off boundary data. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v3 18/46] ivshmem: improve error

From: Marc-André Lureau The test whether the chardev is an AF_UNIX socket rejects "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device ivshmem,chardev=chr0", but fails to explain why. Use an explicit error on why a chardev may be rejected. Signed-off-by: Marc-André Lureau --- hw/misc/

[Qemu-devel] [PATCH v3 13/46] ivshmem: allocate eventfds in resize_peers()

From: Marc-André Lureau It simplifies a bit the code to allocate the array when setting the number of peers instead of lazily when receiving the first vector. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 07/46] ivshmem: remove superflous ivshmem_attr field

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index fbeb731..5e4b2cc 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -85,7 +85,6

[Qemu-devel] [PATCH v3 09/46] ivshmem: more qdev conversion

From: Marc-André Lureau Use the latest qemu device modeling API, in particular, convert to realize to fix the error handling; right now a botched device_add ivhsmem command kills the VM. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 119 +++---

[Qemu-devel] [PATCH v3 28/46] ivshmem: replace 'guest' for 'peer' appropriately

From: Marc-André Lureau The terms 'guest' and 'peer' are used sometime interchangeably which may be confusing. Instead, use 'peer' for the remote instances of ivshmem clients, and 'guest' for the local VM. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 28 ++--

[Qemu-devel] [PULL 21/35] target-tilegx: Handle unconditional jump instructions

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 58 +-- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 7fe42e8..c08a3a6 100644 ---

[Qemu-devel] [PATCH v3 31/46] contrib: add ivshmem client and server

From: David Marchand When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz Signed-off-by: David Marchand [fix a valgrind warning, op

[Qemu-devel] [PATCH v3 24/46] ivshmem: shmfd can be 0

From: Marc-André Lureau 0 is a valid fd value, so change conditions and set -1 value early Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 14c7d58..c80503d 100644 --- a/

[Qemu-devel] [PATCH v3 35/46] docs: update ivshmem device spec

From: David Marchand Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it. Signed-off-by: David Marchand Reviewed

[Qemu-devel] [PATCH v3 39/46] qtest: add qtest_add_abrt_handler()

From: Marc-André Lureau Allow a test to add abort handlers, use GHook for all handlers. There is currently no way to remove a handler, but it could be later added if needed. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 37 - tests/libqtest.h | 2

[Qemu-devel] [PATCH v3 29/46] ivshmem: error on too many eventfd received

From: Marc-André Lureau The number of eventfd that can be handled per peer is limited by the number of vectors. Return an error when receiving too many of them. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/misc/ivshmem.c b

[Qemu-devel] [PATCH v3 32/46] ivshmem-client: check the number of vectors

From: Marc-André Lureau Check the number of vectors received from the server, to avoid out of bound array access. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/ivshmem-client.c | 4 1 file changed, 4 insertions(+) diff --git a/contrib/ivshmem-client/ivshmem-client.c b/cont

[Qemu-devel] [PATCH v3 37/46] contrib: remove unnecessary strdup()

From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau --- contrib/ivshmem-client/main.c | 2 +- contrib/ivshmem-server/main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 del

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero disk size but with > several dirty bitmaps

[Qemu-devel] [PATCH v3 33/46] ivshmem-server: use a uint16 for client ID

From: Marc-André Lureau In practice, the number of VM is limited to MAXUINT16 in ivshmem, so use the same limit on the server (removes a theorical infinite loop) Signed-off-by: Marc-André Lureau --- contrib/ivshmem-server/ivshmem-server.c | 11 ++- contrib/ivshmem-server/ivshmem-server

[Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

From: Marc-André Lureau qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index dd1

[Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector

From: Marc-André Lureau No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/ivshmem

Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c| 1 + > include/qemu/hbitmap.h | 8 > qapi/block-core.json | 4 +++- > util/hbitm

[Qemu-devel] [PATCH v3 36/46] ivshmem: add check on protocol version in QEMU

From: David Marchand Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eve

[Qemu-devel] [PATCH v3 45/46] ivshmem: rename MSI eventfd_table

From: Marc-André Lureau The array is used to have vector specific data, so use a more descriptive name. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 976f

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On 07/09/2015 16:11, Igor Mammedov wrote: > > here is common concepts that could be reused. > - on physical system both DIMM and NVDIMM devices use > the same slots. We could share QEMU's '-m slots' option between > both devices. An alternative to not sharing would be to introduce >

[Qemu-devel] [PATCH v3 38/46] msix: implement pba write (but read-only)

From: Marc-André Lureau qpci_msix_pending() writes on pba region, causing qemu to SEGV: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x77fba8c0 (LWP 25882)] 0x in ?? () (gdb) bt #0 0x in () #1 0x556556c5 in m

[Qemu-devel] [PATCH v3 40/46] tests: add ivshmem qtest

From: Marc-André Lureau Adds 4 ivshmemtests: - single qemu instance and basic IO - pair of instances, check memory sharing - pair of instances with server, and MSIX - hot plug/unplug A temporary shm is created as well as a directory to place server socket, both should be clear on exit and abort.

[Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic

From: Marc-André Lureau Use a more explicit function name parse_mem_size(). I guess such function could be common (or exists already somewhere). Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/misc/ivshmem

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

"Daniel P. Berrange" writes: > On Tue, Sep 15, 2015 at 09:31:08AM -0600, Eric Blake wrote: >> ping >> >> On 08/24/2015 06:15 PM, John Snow wrote: >> > >> > >> > On 06/18/2015 10:05 AM, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> >> >>> On 18 June 2015 at 10:28, Markus Armbruste

Re: [Qemu-devel] [PATCH PULL v3 00/11] Extract TLS handling code from VNC server

On 15 September 2015 at 15:36, Daniel P. Berrange wrote: > The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-09-14 18:51:09 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add DBG2 table

On Tue, Sep 15, 2015 at 03:44:41PM +0100, Leif Lindholm wrote: > Add a DBG2 table, describing the pl011 UART. > > Signed-off-by: Leif Lindholm > --- > hw/arm/virt-acpi-build.c | 88 > +++- > 1 file changed, 87 insertions(+), 1 deletion(-) > > diff --

[Qemu-devel] [PATCH v3 43/46] ivshmem: add hostmem backend

From: Marc-André Lureau Instead of handling allocation, teach ivshmem to use a memory backend. This allows to use hugetlbfs backed memory now. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c| 84 tests/ivshmem-test.c | 12

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATAPI drive handle. >> Clamp down on the IDE command execution table to remove CD_OK permissions >> from commands that are not and have never been ATAPI commands. >> >> Fo

Re: [Qemu-devel] I want to recover my QEMU password.

SkyKiDS is mine, and Skykids is maybe mine, too, but could be removed. Any helps? 2015-09-12 14:09 GMT+09:00 Stefan Weil : > Am 11.09.2015 um 17:38 schrieb SkyKiDS: > > Hi, there! > > > > Long long time ago, in 2010, I am a member of QEMU wiki, just had an > > account, and contributed some news

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add DBG2 table

On 15 September 2015 at 17:42, Andrew Jones wrote: > On Tue, Sep 15, 2015 at 03:44:41PM +0100, Leif Lindholm wrote: >> Add a DBG2 table, describing the pl011 UART. >> >> Signed-off-by: Leif Lindholm >> --- >> hw/arm/virt-acpi-build.c | 88 >> +++- >>

Re: [Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability

On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Reviewed-by: John Snow > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/migration/migration.h | 1 + > migration/migration.c | 9 + > qapi-schema.json

Re: [Qemu-devel] [PATCH v7 04/11] target-mips: improve exception handling

On 28/08/2015 10:08, Pavel Dovgaluk wrote: >> From: Aurelien Jarno [mailto:aurel...@aurel32.net] >> On 2015-08-13 14:12, Leon Alrae wrote: >>> On 10/07/2015 10:57, Pavel Dovgalyuk wrote: @@ -2364,14 +2363,12 @@ static void gen_st_cond (DisasContext *ctx, uint32_t opc, int rt, #if d

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

On 15/09/2015 11:20, Gonglei wrote: > On 2015/9/15 14:33, Gonglei wrote: >> On 2015/9/15 9:16, Gonglei wrote: >>> On 2015/9/14 17:28, Paolo Bonzini wrote: On 14/09/2015 10:01, Gonglei (Arei) wrote: > [2015-09-11 13:42:44] domain is rebooting > qemu-kvm: /home/abuild/rpmbui

Re: [Qemu-devel] [PATCH v2 3/5] acpi: pc: add fw_cfg device node to ssdt

On Mon, Sep 14, 2015 at 04:54:25PM -0400, Gabriel L. Somlo wrote: > On Mon, Sep 14, 2015 at 04:34:02PM -0400, Gabriel L. Somlo wrote: > > > > So I'll replace the "if (guest_info->fw_cfg)" check with > > > > "if machine-type >= (pc-q35-2.5 or pc-i440fx-2.5))", in v3, > > > > as soon as the patches f

Re: [Qemu-devel] [PATCH v7 25/42] Postcopy: Maintain sentmap and calculate discard

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Where postcopy is preceeded by a period of precopy, the destination will > > have received pages that may have been dirtied on the source after the > > page was sent. T

Re: [Qemu-devel] [RFC PATCH] os-android: Add support to android platform, built by ndk-r10

Hi Paolo, (Please ignore the previous mail that did not include "qemu-devel") Thanks for your review and suggestions. I'll fix this patch accordingly and please see my replies below. best regards, Houcheng Lin 2015-09-15 17:41 GMT+08:00 Paolo Bonzini : > This is okay and can be done unconditio

Re: [Qemu-devel] [PATCH v2 09/18] nvdimm: build ACPI NFIT table

On Tue, 15 Sep 2015 18:12:43 +0200 Paolo Bonzini wrote: > > > On 14/08/2015 16:52, Xiao Guangrong wrote: > > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > > > Currently, we only support PMEM mode. Each device has 3 tables: > > - SPA table, define the PMEM regio

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

15.09.2015 19:22, Markus Armbruster wrote: > "Daniel P. Berrange" writes: [] >> Personally I be fine with both the minimal approach or the more >> comprehensive approach of Peter's, but I'd probably tend towards >> the minimal approach to avoid the warnings problem. > > Seconded. > > The "minima

Re: [Qemu-devel] [PATCH v2] add macro file for coccinelle

07.09.2015 13:21, Paolo Bonzini wrote: > Coccinelle chokes on some idioms from compiler.h and queue.h. > Extract those in a macro file, to be used with "--macro-file > scripts/cocci-macro-file.h". Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [RFT PATCH v1 0/3] net: smc91c111 can_receive fixes

On Mon, Sep 14, 2015 at 2:09 PM, Richard Purdie wrote: > Hi Peter, > > On Thu, 2015-09-10 at 21:23 -0700, Peter Crosthwaite wrote: >> This should hopefully fix your bug, while addressing the extra concern >> I raised. >> >> There was also inconsistent behaviour with corking packets through a >> so

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

John Snow writes: > On 09/15/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're a little too lenient with what we'll let an ATAPI drive handle. >>> Clamp down on the IDE command execution table to remove CD_OK permissions >>> from commands that are not and have never been

Re: [Qemu-devel] [PATCH RFC v5 00/32] qapi: QMP introspection

Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection

Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

On 09/15/2015 02:11 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:53 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE command execution table to remove CD_OK per

[Qemu-devel] Canceled Event: Dr Velano @ Wed Sep 16, 2015 17:50 - 18:50 (shlomopongr...@gmail.com)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VEVENT DTSTART:20150916T145000Z DTEND:20150916T155000Z DTSTAMP:20150915T184155Z ORGANIZER;CN=Shlomo Pongratz:mailto:shlomopongr...@gmail.com UID:mhfgd22vmap7kbtja2d8p70...@google.com

[Qemu-devel] [PATCH 2/8] target-i386: Make check_hw_breakpoints static

The function is now only used from within a single file. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 2 +- target-i386/cpu.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index 6f6537d..c071c24

[Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

Best guess, since I can't find any code that actually uses them. Linux actively turns them off at boot... r~ Richard Henderson (8): target-i386: Move breakpoint related functions to new file target-i386: Make check_hw_breakpoints static target-i386: Introduce cpu_x86_update_dr7 target-i

[Qemu-devel] [PATCH 3/8] target-i386: Introduce cpu_x86_update_dr7

This moves the last of the iteration over breakpoints into the bpt_helper.c file. This also allows us to make several breakpoint functions static. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 ++--- target-i386/cpu.h| 4 ++-- target-i386/ma

[Qemu-devel] [PATCH 1/8] target-i386: Move breakpoint related functions to new file

Signed-off-by: Richard Henderson --- target-i386/Makefile.objs | 2 +- target-i386/bpt_helper.c | 182 ++ target-i386/helper.c | 128 target-i386/misc_helper.c | 34 - 4 files changed, 183 insertions(+),

[Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

Before the last patch, we had an efficient loop that disabled local breakpoints on task switch. Re-add that, but in a more general way that handles changes to the global enable bits too. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 34 -- 1 fil

[Qemu-devel] [PATCH 6/8] target-i386: Optimize setting dr[0-3]

If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c index 10bbf9f..f

[Qemu-devel] [PATCH 5/8] target-i386: Move hw_*breakpoint_* functions

They're only used from bpt_helper.c now. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 - target-i386/cpu.h| 27 --- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/target-i386/bpt_helper.c b/target

[Qemu-devel] [PATCH 8/8] target-i386: Check CR4[DE] for processing DR4/DR5

Introduce helper_get_dr so that we don't have to put CR4[DE] into the scarce HFLAGS resource. At the same time, rename helper_movl_drN_T0 to helper_set_dr and set the helper flags. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 46 +-

[Qemu-devel] [PATCH 7/8] target-i386: Handle I/O breakpoints

Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 99 +++- target-i386/cpu.h| 2 + target-i386/helper.h | 1 + target-i386/translate.c | 20 +- 4 files changed, 94 insertions(+), 28 deletions(-) diff --git a/target-

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

John Snow writes: > On 09/15/2015 02:11 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command executio

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

On 09/15/2015 02:50 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:11 PM, Markus Armbruster wrote: >>> John Snow writes: >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> We're a little too lenient with what we'll let an ATA

Re: [Qemu-devel] [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

On Thu, Sep 03, 2015 at 12:45:12PM +0200, Juergen Gross wrote: > When Xen is using the qemu usb framework for pure passthrough of I/Os > to host devices the handling of isoc jobs is rather complicated if > multiple isoc frames are transferred with one call. > > Instead of calling the framework wit

Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

On 4 August 2015 at 20:16, Richard Henderson wrote: > On 08/04/2015 12:08 PM, Alex Bennée wrote: Would that make sense as a debug option or should we have a specific set of TCG options to alter its behaviour? >>> >>> >>> That's what I'm saying -- probably a separate debug option is bette

<    1   2   3   4   >