On 09.06.2015 18:50, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:24PM +0300, Vladimir Sementsov-Ogievskiy wrote:
diff --git a/block/qcow2.c b/block/qcow2.c
index 406e55d..f85a55a 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -182,6 +182,14 @@ static int qcow2_read_extensions(BlockDr
On 08/26/2015 11:49 PM, Eduardo Habkost wrote:
On Wed, Aug 26, 2015 at 11:27:08AM -0400, Paolo Bonzini wrote:
[...]
+if (tcg_enabled()) {
+memory_region_add_subregion_overlap(cpu->cpu_as_root,
+apic->apicbase &
+
On Wed, Aug 26, 2015 at 03:53:16PM -0600, Eric Blake wrote:
> On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
> > If the administrator incorrectly sets up their x509 certificates,
> > the errors seen at runtime during connection attempts are very
> > obscure and difficult to diagnose. This has be
Ping
>On Mon, 17 Aug 2015 10:09:33 +0200
>Marc Marí wrote:
>
> The current module infrastructure has been improved to enable dynamic
> module loading.
>
> This reduces the load time for very simple guests. For the following
> configuration (very loaded)
>
> ./configure --enable-sdl --enable-gtk
vmexit using test assumes BAR size is exactly 4K.
Remove this restriction, allow any BAR size.
Signed-off-by: Michael S. Tsirkin
---
x86/vmexit.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/x86/vmexit.c b/x86/vmexit.c
index 7e9af15..3ff7fbf 100644
--- a/
Will be used for pci-testdev.
Signed-off-by: Michael S. Tsirkin
---
lib/x86/pci.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/lib/x86/pci.c b/lib/x86/pci.c
index 231668a..5116dac 100644
--- a/lib/x86/pci.c
+++ b/lib/x86/pci.c
@@ -19,6 +19,13 @@ static uint32_t pc
commit 9b8424d5735278ca382f11adc7c63072b632ab83
"exec: split length -> used_length/max_length"
changed field names in struct RAMBlock
It turns out that scripts/dump-guest-memory.py was
poking at this field, update it accordingly.
Cc: qemu-sta...@nongnu.org
Cc: Paolo Bonzini
Signed-off-by: Mi
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
In order to avoid any confusion, let's allocate new strings when
splitting.
Signed-off-by: Marc-André Lureau
---
qga/commands-posix.c | 6 +++---
qga/commands-win32.c | 4 ++--
qga/main.c | 22 +
On 08/27/2015 12:13 PM, Denis V. Lunev wrote:
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
In order to avoid any confusion, let's allocate new strings when
splitting.
Signed-off-by: Marc-André Lureau
---
qga/commands-posix.c | 6 +++---
qga/commands-
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
The function is going to be reused in a later patch.
Signed-off-by: Marc-André Lureau
Reviewed-by: Michael Roth
---
qga/main.c | 33 ++---
1 file changed, 22 insertions(+), 11 de
On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote:
> Extend the current module interface to allow for block drivers to be loaded
> dynamically on request.
>
> The only block drivers that can be converted into modules are the drivers
> that don't perform any init operation except for regist
On Mon, Aug 17, 2015 at 10:09:35AM +0200, Marc Marí wrote:
> To simplify the addition of new block modules, add a script that generates
> include/qemu/module_block.h automatically from the modules' source code.
>
> This script assumes that the QEMU coding style rules are followed.
>
> Signed-off-
Hi,
i was debugging increased memory footprint of qemu over the past time and found
that the coroutine
pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And
those 70MB are never
freed.
Is this expected? Wouldn't it make sense to asynchronically throw some
coroutines (or a
> Am 26.08.2015 um 15:25 schrieb Jeff Cody :
>
> On Wed, Aug 26, 2015 at 10:08:26AM +0200, Christian Rößner wrote:
>>
>>> Am 25.08.2015 um 08:02 schrieb Christian Rößner :
>>>
>>> Hello,
>>>
>>> I wrote this mail to the qemu-discuss mailing list, but today I am unsure,
>>> if I chose the righ
Update cpu_model in MachineState for i386, so that the field can be used
for cpu hotplug, instead of using a static variable.
Signed-off-by: Zhu Guihua
---
v3:
-use PCMachineState in pc_cpus_init() instead MachineState
v2:
-transfer MachineState from all pc_cpus_init() callers
---
hw/i386/pc.
On Thu, 27 Aug 2015 10:19:35 +0100
"Daniel P. Berrange" wrote:
> On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote:
> > Extend the current module interface to allow for block drivers to
> > be loaded dynamically on request.
> >
> > The only block drivers that can be converted into module
On Thu, 27 Aug 2015 10:23:32 +0100
"Daniel P. Berrange" wrote:
> On Mon, Aug 17, 2015 at 10:09:35AM +0200, Marc Marí wrote:
> > To simplify the addition of new block modules, add a script that
> > generates include/qemu/module_block.h automatically from the
> > modules' source code.
> >
> > This
On Thu, Aug 27, 2015 at 11:35:41AM +0200, Marc Marí wrote:
> On Thu, 27 Aug 2015 10:19:35 +0100
> "Daniel P. Berrange" wrote:
>
> > On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote:
> > > Extend the current module interface to allow for block drivers to
> > > be loaded dynamically on req
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Following patch will return allocated strings, so we must correctly
initialize alloc & free them. The nice side effect is that we no longer
have to check for "fixed_state_dir" to call ga_install_service() with a
On 08/27/2015 02:38 AM, Marc-André Lureau wrote:
Hi
On Thu, Aug 27, 2015 at 1:34 AM, wrote:
+if (keyfile) {
+g_key_file_free(keyfile);
+}
+}
I forgot the if () can be removed now.
yep...
On 08/27/2015 02:38 AM, Marc-André Lureau wrote:
Hi
On Thu, Aug 27, 2015 at 1:34 AM, wrote:
+if (keyfile) {
+g_key_file_free(keyfile);
+}
+}
I forgot the if () can be removed now.
yep...
The rest is
Reviewed-by: Denis V. Lunev
Pls note that there is the same thing in p
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Learn to configure the agent with a system configuration.
This may simplify command-line handling, especially when the blacklist
is long.
Among the other benefits, this may standardize the configuration of an
i
We can start a nbd server in qemu, and the nbd client will connect
to this server later. Each client has a export name, and the server
will know the disk the client want to use according to the export
name.
If there are two clients that have the same export name, we don't
refuse the second client.
On 24.06.2015 03:21, John Snow wrote:
On 06/17/2015 10:29 AM, Vladimir Sementsov-Ogievskiy wrote:
On 12.06.2015 22:34, John Snow wrote:
...
(9) Data consistency
We need to discuss the data safety element to this. I think that
atomically before the first write is flushed to disk, the dirty
This makes sure the number of reallocs is in O(log N).
Signed-off-by: Peter Lieven
---
ui/vnc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index caf82f5..8cfd2d8 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -653,10 +653,13 @@ void vnc_framebuffer_updat
While debugging increased memory footprint of Qemu (since qemu-kvm-1.2.0)
I found some culprits in the VNC code. This series includes some
first optimizations.
Peter Lieven (4):
vnc: make the Buffer capacity increase in powers of two
vnc: allow the Buffer to shrink again
vnc-jobs: move buffe
if no client is connected there is no need to keep the server
surface. Throw it away and replace it with a dummy surface to
save memory.
Signed-off-by: Peter Lieven
---
ui/vnc.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 061e33
now that we are able to shrink the buffer it makes sense
to move the buffer_reset to vnc_async_encoding_end to
actually shrink the buffer when it is no longer used.
Signed-off-by: Peter Lieven
---
ui/vnc-jobs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/vnc-jobs.c b
currently the Buffer can only grow. This increases Qemu memory footprint
dramatically since normally the biggest VNC updates are at connection time.
But also after a VNC session has terminated there is one persistent buffer
in queue->buffer which I have seen to increase to over 100MB and it is neve
On Wed, Aug 26, 2015 at 06:04:08PM +0800, Jason Wang wrote:
> Test fast mmio by using zero size eventfd.
>
> Signed-off-by: Jason Wang
wildcard is not the same as ignoring length.
I think I have a nicer patch, will post now.
> ---
> hw/misc/pci-testdev.c | 6 +-
> 1 file changed, 5 inserti
On Wed, Aug 26, 2015 at 8:09 AM, Christoffer Dall
wrote:
> On Tue, Aug 25, 2015 at 04:43:13PM +0100, Stefan Hajnoczi wrote:
>> I have created a wiki page for virtio-vsock.
>>
>> It links to my git repos and the draft virtio specification:
>> http://qemu-project.org/Features/VirtioVsock
>>
>> I'll
Add nodata test where data length is ignored.
Skip it for port IO since kvm does not support it there.
Signed-off-by: Michael S. Tsirkin
---
hw/misc/pci-testdev.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c
in
If the file is readonly its not expected to grow so
save the blocking call to nfs_fstat_async and use
the value saved at connection time. Also important
the monitor (and thus the main loop) will not hang
if block device info is queried and the NFS share
is unresponsive.
Signed-off-by: Peter Lieven
On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote:
> currently the Buffer can only grow. This increases Qemu memory footprint
> dramatically since normally the biggest VNC updates are at connection time.
> But also after a VNC session has terminated there is one persistent buffer
> in qu
From: Marc-André Lureau
For consistency with the rest of the comment blocks.
Signed-off-by: Marc-André Lureau
---
qga/qapi-schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 6b0bd16..82894c6 100644
--- a/qga/qapi-
On 27 August 2015 at 05:50, Jason Wang wrote:
> On 08/26/2015 10:51 PM, Greg Kurz wrote:
>> On Wed, 26 Aug 2015 15:21:59 +0100
>> Peter Maydell wrote:
>>> This seems to me like a bug in the caller. Why would anything
>>> try to call into the memory subsystem to do a zero-size
>>> transaction?
>>
On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote:
> > John Snow writes:
> >
> > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote:
> > >> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > >>> Migration wi
On Tue, Aug 25, 2015 at 12:16:04PM -0400, John Snow wrote:
>
>
> On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote:
> > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote:
> >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote:
> >>> * Eduardo Habkost (ehabk...@re
From: Marc-André Lureau
Add some local guest agent tests (as it is better than nothing).
They can be run inside or outside a VM, when run inside a VM, they will
do a bit more side effects, such as freezing/thawing the FS or changing
the time.
A better test would involve a managed VM (or contain
From: Marc-André Lureau
Add a few functions to interact with qmp via a simple fd.
Signed-off-by: Marc-André Lureau
---
tests/libqtest.c | 45 +
tests/libqtest.h | 7 +++
2 files changed, 48 insertions(+), 4 deletions(-)
diff --git a/tests/libqt
On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote:
> On 27 August 2015 at 05:50, Jason Wang wrote:
> > On 08/26/2015 10:51 PM, Greg Kurz wrote:
> >> On Wed, 26 Aug 2015 15:21:59 +0100
> >> Peter Maydell wrote:
> >>> This seems to me like a bug in the caller. Why would anything
> >>> t
On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote:
> On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote:
> > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote:
> > > John Snow writes:
> > >
> > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wro
On Wed, Aug 26, 2015 at 09:22:55AM -0600, Eric Blake wrote:
> On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
> > The camel_to_upper() method applies some heuristics to turn
> > a mixed case type name into an all-uppercase name. This is
> > used for example, to generate enum constant name prefixe
On 27 August 2015 at 11:53, Michael S. Tsirkin wrote:
> On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote:
>> But *why* does it require the size to be zero? I still think
>> the caller should just avoid trying to do zero-size memory
>> operations: they don't make sense. What is a zero
On Thu, Aug 27, 2015 at 12:01:17PM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote:
> > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote:
> > > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote:
> > > > John Sno
On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote:
> On 27 August 2015 at 11:53, Michael S. Tsirkin wrote:
> > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote:
> >> But *why* does it require the size to be zero? I still think
> >> the caller should just avoid trying to do
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> We need communications protocol of user-defined to control the checkpoint
> process.
>
> The new checkpoint request is started by Primary VM, and the interactive
> process
> like below:
> Checkpoint synchronizing points,
>
>
On Wed, Aug 26, 2015 at 08:05:32PM +0200, Laurent Vivier wrote:
> Originally, timers were ticks based, and it made sense to
> add ticks to current time to know when to trigger an alarm.
>
> But since commit:
>
> 7447545 change all other clock references to use nanosecond resolution
> accessors
>
On Wed, Aug 26, 2015 at 03:24:42PM +0200, Pierre Morel wrote:
> Let dataplane allocate different region for the desc/avail/used
> ring regions.
>
> Signed-off-by: Pierre Morel
> Acked-by: Greg Kurz
> Tested-by: Greg Kurz
Also need to Cc stable on this.
> ---
> hw/virtio/dataplane/vring.c
On 08/25/2015 12:54 PM, Denis V. Lunev wrote:
On 08/12/2015 02:50 PM, Denis V. Lunev wrote:
The monivation of this set is simple. Recently we have proposed patch
to monitor.c with specific x86 APIC HMP commands. The patchset was
denied
with the main motivation "No more arch specific code in mo
Hi Dave,
On 2015/8/27 18:40, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
We need communications protocol of user-defined to control the checkpoint
process.
The new checkpoint request is started by Primary VM, and the interactive process
like below:
Che
On Thu, Aug 27, 2015 at 12:52 PM, wrote:
> +success = success && status == 0 && g_strcmp0(virt_what, virt);
this is now:
g_strcmp0(g_strstrip(virt_what), virt) == 0
--
Marc-André Lureau
On 2015/8/27 18:30, Michael S. Tsirkin wrote:
> Add nodata test where data length is ignored.
> Skip it for port IO since kvm does not support it there.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/misc/pci-testdev.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
On Tue, Aug 25, 2015 at 12:40:15AM +0100, Ken Moffat wrote:
> (Cc'ing qemu-devel, please keep me in the Cc).
>
> TL;DR - qemu locks up my machine when I use 4.2-rc kernels.
>
Previous mail, or at least the copy to qemu, archived at
https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02784.ht
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> We should save PVM's RAM/device to slave when needed.
>
> For VM state, we will cache them in slave, we use QEMUSizedBuffer
> to store the data, we need know the data size of VM state, so in master,
> we use qsb to store VM state temporaril
On 27 August 2015 at 12:08, Michael S. Tsirkin wrote:
> On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote:
>> On 27 August 2015 at 11:53, Michael S. Tsirkin wrote:
>> > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Peter Maydell wrote:
>> >> But *why* does it require the size to be zero?
On 27 August 2015 at 12:27, Denis V. Lunev wrote:
> On 08/25/2015 12:54 PM, Denis V. Lunev wrote:
>>
>> On 08/12/2015 02:50 PM, Denis V. Lunev wrote:
>>>
>>> The monivation of this set is simple. Recently we have proposed patch
>>> to monitor.c with specific x86 APIC HMP commands. The patchset was
On Thu, Aug 27, 2015 at 01:12:32PM +0100, Peter Maydell wrote:
> On 27 August 2015 at 12:08, Michael S. Tsirkin wrote:
> > On Thu, Aug 27, 2015 at 12:04:49PM +0100, Peter Maydell wrote:
> >> On 27 August 2015 at 11:53, Michael S. Tsirkin wrote:
> >> > On Thu, Aug 27, 2015 at 11:49:32AM +0100, Pet
On 27 August 2015 at 13:17, Michael S. Tsirkin wrote:
> Basically the point is that ABI is extended to make
> ioeventfd with len = 0 mean "any length".
> 0 is thus not meaningless anymore.
But how can you do adjustment for incorrect endianness
if you don't know the size of the data that you're
tr
On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote:
> On 27 August 2015 at 13:17, Michael S. Tsirkin wrote:
> > Basically the point is that ABI is extended to make
> > ioeventfd with len = 0 mean "any length".
> > 0 is thus not meaningless anymore.
>
> But how can you do adjustment for
On 27 August 2015 at 13:25, Michael S. Tsirkin wrote:
> On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote:
>> On 27 August 2015 at 13:17, Michael S. Tsirkin wrote:
>> > Basically the point is that ABI is extended to make
>> > ioeventfd with len = 0 mean "any length".
>> > 0 is thus no
On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote:
> On 27 August 2015 at 13:25, Michael S. Tsirkin wrote:
> > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote:
> >> On 27 August 2015 at 13:17, Michael S. Tsirkin wrote:
> >> > Basically the point is that ABI is extended t
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
wrote:
> MSI probe assumes that qemu-ga support has been probed already, but in
> cases where --enable-guest-agent/--disable-guest-agent have not been
> passed to configure, qemu-ga support may end up getting enabled later,
> as is the case with w32 b
(Added Eric back in to the CC list. Looks like he got dropped
somewhere along the way)
On Wed, Aug 26, 2015 at 11:22:08PM -0400, Programmingkid wrote:
>
> On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote:
>
> > On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote:
> >>
> >> On Aug 26, 20
On 08/27/2015 03:13 PM, Peter Maydell wrote:
On 27 August 2015 at 12:27, Denis V. Lunev wrote:
On 08/25/2015 12:54 PM, Denis V. Lunev wrote:
On 08/12/2015 02:50 PM, Denis V. Lunev wrote:
The monivation of this set is simple. Recently we have proposed patch
to monitor.c with specific x86 APIC
On Thu, Aug 27, 2015 at 11:26:13AM +0200, Christian Rößner wrote:
>
> > Am 26.08.2015 um 15:25 schrieb Jeff Cody :
> >
> > On Wed, Aug 26, 2015 at 10:08:26AM +0200, Christian Rößner wrote:
> >>
> >>> Am 25.08.2015 um 08:02 schrieb Christian Rößner :
> >>>
> >>> Hello,
> >>>
> >>> I wrote this
Am 27.08.2015 um 12:39 schrieb Daniel P. Berrange:
On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote:
currently the Buffer can only grow. This increases Qemu memory footprint
dramatically since normally the biggest VNC updates are at connection time.
But also after a VNC session has t
Hi
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
wrote:
> This makes it easier to report on whether or not MSI support was
> enabled via probe by looking at the ./configure summary.
Sorry I don't get what that really changes. Otherwise the patch looks fine.
--
Marc-André Lureau
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> Hi Dave,
>
> On 2015/8/27 18:40, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >>We need communications protocol of user-defined to control the checkpoint
> >>process.
> >>
> >>The new checkpoint
I've made this similar to snapshots, but now I think...
Why should we maintain dirty bitmap directory in ram? This only gives us
saving of one extra bdrv_read of header on loading bitmap, but is
doesn't matter in comparison with reading the whole bitmap to memory.
Also, the bitmap should not b
I have observed that depending on the contents and the encoding it happens
that sending data as RAW sometimes would take less space than the encoded data.
This is especially the case for small updates or areas with high color images.
If sending RAW encoded data is beneficial allow a fall back to RA
Hi
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
wrote:
> +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a
> $(QGA_VSS_PROVIDER)
> + $(call LINK, $(filter-out %.tlb %.dll, $^))
Strictly this is not so great, but that makes sense: so perhaps a
small comment above to explain it
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
wrote:
> + @echo "MSI build not configured or dependency resolution failed
> (reconfigure with --enable-guest-agent-msi option)"
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
On 08/27/2015 06:32 AM, Jeff Cody wrote:
> (Added Eric back in to the CC list. Looks like he got dropped
> somewhere along the way)
No thanks to mailman's inept behavior that thinks that it is okay to
rewrite cc's to drop anyone that doesn't want duplicate email. But
don't worry about it; I have
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> unfortunately I do have some more review comments; that can happen when
> going back to the code after a few months, and it's also a good thing
> because it means that the code _is_ actually getting cleaner.
Tha
On Tue, Aug 25, 2015 at 03:25:54AM +, Ouyang, Changchun wrote:
> Hi Michael,
>
> > -Original Message-
> > From: snabb-de...@googlegroups.com [mailto:snabb-
> > de...@googlegroups.com] On Behalf Of Michael S. Tsirkin
> > Sent: Thursday, August 13, 2015 5:19 PM
> > To: Ouyang, Changchun
On Thu, 27 Aug 2015 15:30:55 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote:
> > On 27 August 2015 at 13:25, Michael S. Tsirkin wrote:
> > > On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote:
> > >> On 27 August 2015 at 13:17, Michae
On Thu, Aug 27, 2015 at 02:05:49PM +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 27, 2015 at 12:01:17PM +0100, Daniel P. Berrange wrote:
> > On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote:
> > > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote:
> > > > On Mon,
On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:
> (Added Eric back in to the CC list. Looks like he got dropped
> somewhere along the way)
>
> On Wed, Aug 26, 2015 at 11:22:08PM -0400, Programmingkid wrote:
>>
>> On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote:
>>
>>> On Wed, Aug 26, 2015 at 02:17
On Aug 27, 2015, at 9:00 AM, Eric Blake wrote:
> On 08/27/2015 06:32 AM, Jeff Cody wrote:
>> (Added Eric back in to the CC list. Looks like he got dropped
>> somewhere along the way)
>
> No thanks to mailman's inept behavior that thinks that it is okay to
> rewrite cc's to drop anyone that does
Quoting Marc-André Lureau (2015-08-27 07:49:19)
> Hi
>
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> wrote:
> > +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a
> > $(QGA_VSS_PROVIDER)
> > + $(call LINK, $(filter-out %.tlb %.dll, $^))
>
> Strictly this is not so great, but
On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote:
>
> On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:
>
> >
> > On the generation scheme proposed above:
> >
> > I understand that something you desire is an ID that is easier to
> > type.
> >
> > If we wanted to make it shorter, perh
On Wed, Jul 29, 2015 at 12:42:04PM +0800, Fam Zheng wrote:
> The parameter is added but not used.
>
> The callers are converted with following coccinelle semantic patch:
>
> @@
> expression E1, E2, E3, E4, E5;
> @@
> (
> -aio_set_event_notifier(E1, E2, E3)
> +aio_set_event
On Wed, Jul 29, 2015 at 12:42:05PM +0800, Fam Zheng wrote:
> So it can be used by aio_poll later.
>
> Signed-off-by: Fam Zheng
> ---
> aio-posix.c | 2 ++
> aio-win32.c | 3 +++
> 2 files changed, 5 insertions(+)
Reviewed-by: Stefan Hajnoczi
On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote:
>
> > Better still might be fixing things to where we add a global command
> > line option that outright fails any attempt to create an unnamed object.
> > The option would be off by default for back-compat. But management
> > apps l
On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote:
> diff --git a/include/block/aio.h b/include/block/aio.h
> index bd1d44b..d02ddfa 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx);
> bool aio_dispatch(AioContext *ctx);
On Wed, Aug 26, 2015 at 02:01:41PM -0400, Programmingkid wrote:
> > If a user is talking to the QEMU monitor directly there are plenty of ways
> > to go wrong, of which forgetting to provide an ID is a really minor one.
>
> What other problems did you have in mind?
>
> > That's why it is generall
Quoting Marc-André Lureau (2015-08-27 07:41:17)
> Hi
>
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> wrote:
> > This makes it easier to report on whether or not MSI support was
> > enabled via probe by looking at the ./configure summary.
>
> Sorry I don't get what that really changes. Other
On Aug 27, 2015, at 9:49 AM, Daniel P. Berrange wrote:
> On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote:
>>
>> On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:
>>
>>>
>>> On the generation scheme proposed above:
>>>
>>> I understand that something you desire is an ID that is easi
On Thu, Aug 27, 2015 at 3:46 PM, Michael Roth wrote:
> Will add a comment either way, but perhaps something like:
>
thanks
> qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVIDER)
>$(call LINK, $(filter-out $(QGA_VSS_PROVIDER), $^))
>
> would be clearer? I suppose
On Aug 27, 2015, at 9:51 AM, Daniel P. Berrange wrote:
> On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote:
>>
>>> Better still might be fixing things to where we add a global command
>>> line option that outright fails any attempt to create an unnamed object.
>>> The option would b
On 08/27/2015 07:51 AM, Daniel P. Berrange wrote:
> On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote:
>>
>>> Better still might be fixing things to where we add a global command
>>> line option that outright fails any attempt to create an unnamed object.
>>> The option would be off by
On Wed, Jul 29, 2015 at 12:42:07PM +0800, Fam Zheng wrote:
> So we could distinguish it from "protocol" to avoid handling in nested aio
> polls.
>
> Signed-off-by: Fam Zheng
> ---
> include/block/aio.h | 1 +
> nbd.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
Rev
On 08/27/2015 07:56 AM, Programmingkid wrote:
>> If we did have auto-generated names, we would need to come up with a
>> scheme that is not going to clash with any existing naming that users
>> of QEMU may already be doing, otherwise we risk causing a regression.
>> Something as simple as what you
On Aug 27, 2015, at 9:54 AM, Daniel P. Berrange wrote:
> On Wed, Aug 26, 2015 at 02:01:41PM -0400, Programmingkid wrote:
>>> If a user is talking to the QEMU monitor directly there are plenty of ways
>>> to go wrong, of which forgetting to provide an ID is a really minor one.
>>
>> What other pr
Hi
On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth wrote:
> If we keep the $enabled != "no" logic all the way through, $enabled,
> unless explicitly turned off or missing dependencies, will be
> undefined when the configure options are summarized via:
>
> configure: qemu-ga: report MSI install su
On Thu, Aug 27, 2015 at 09:56:47AM -0400, Programmingkid wrote:
>
> On Aug 27, 2015, at 9:49 AM, Daniel P. Berrange wrote:
>
> > On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote:
> >>
> >> On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:
> >>
> >>>
> >>> On the generation scheme pro
On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote:
>
> On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:
>
[snip]
> >
> > I'm not married to the ID generation scheme I proposed.
> >
> > What I am trying to do, however, is have a technical discussion on
> > generating an ID in a well
On Thu, Aug 27, 2015 at 08:01:12AM -0600, Eric Blake wrote:
> On 08/27/2015 07:51 AM, Daniel P. Berrange wrote:
> > On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote:
> >>
> >>> Better still might be fixing things to where we add a global command
> >>> line option that outright fails a
On Aug 27, 2015, at 10:01 AM, Eric Blake wrote:
> On 08/27/2015 07:51 AM, Daniel P. Berrange wrote:
>> On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote:
>>>
Better still might be fixing things to where we add a global command
line option that outright fails any attempt to
1 - 100 of 252 matches
Mail list logo
