Re: [Qemu-devel] Modifying qemu-option.hx

2015-07-29 Thread Markus Armbruster
"Chris Johnson" writes: > Hello, > > I am in the process of writing my own back-end driver and am trying to > figure out how to get this driver to work with qemu. I have found this > link that mentions editing the qemu-option.hx file and rebuilding > QEMU: > http://stackoverflow.com/questions/291

Re: [Qemu-devel] [PATCH v2 6/7] error: Revamp interface documentation

2015-07-29 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> include/qapi/error.h | 177 >> --- >> 1 file changed, 127 insertions(+), 50 deletions(-) >

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/01/2015 02:21 PM, Markus Armbruster wrote: >> The struct generated for a flat union is weird: the members of its >> base are at the end, except for the union tag, which is renamed to >> 'kind' and put at the beginning. > > The renaming to 'kind' was a bug waiting to hap

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 06:42, Fam Zheng wrote: > @@ -2613,6 +2613,8 @@ bool bdrv_aio_poll(AioContext *ctx, bool blocking) > { > bool ret; > > +aio_disable_clients(ctx, AIO_CLIENT_DATAPLANE | AIO_CLIENT_NBD_SERVER); > ret = aio_poll(ctx, blocking); > +aio_enable_clients(ctx, AIO_CLIENT

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-29 Thread Jan Kiszka
On 2015-07-29 00:12, Samuel Thibault wrote: > Hello, > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : >> Of course, I'm fine with handing this over to someone who'd like to >> pick up. Do we have volunteers? >> >> Samuel, would you like to do this? As a subsystem maintainer, you are >>

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 06:42, Fam Zheng wrote: > @@ -2613,6 +2613,8 @@ bool bdrv_aio_poll(AioContext *ctx, bool blocking) > { > bool ret; > > +aio_disable_clients(ctx, AIO_CLIENT_DATAPLANE | AIO_CLIENT_NBD_SERVER); > ret = aio_poll(ctx, blocking); > +aio_enable_clients(ctx, AIO_CLIENT

Re: [Qemu-devel] qemu 2.4rc2 : iothread hanging vm (2.4rc1 works fine)

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 06:50, Alexandre DERUMIER wrote: > seem to come from this commit: > > http://git.qemu.org/?p=qemu.git;a=commit;h=eabc977973103527bbb8fed69c91cfaa6691f8ab > "AioContext: fix broken ctx->dispatching optimization" Stefan has a set of patches that fix it. Paolo

Re: [Qemu-devel] [PATCH v2 00/11] aio: Introduce handler type to fix nested aio_poll for dataplane

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 06:42, Fam Zheng wrote: > v2: Switch to disable/enable model. [Paolo] > > Most existing nested aio_poll()'s in block layer are inconsiderate of > dispatching potential new r/w requests from ioeventfds and nbd exports, which > might result in responsiveness issues (e.g. bdrv_drain_a

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Jan Kiszka
On 2015-07-29 00:57, Samuel Thibault wrote: > Samuel Thibault, le Wed 29 Jul 2015 00:13:57 +0200, a écrit : >> I can rebase the patch series over the current master and submit again >> the patches. > > Here it is: > > Hello, > > This is another respin of IPv6 in Qemu -net user mode. > > These p

Re: [Qemu-devel] [PATCH v2 01/45] char: add qemu_chr_free()

2015-07-29 Thread Paolo Bonzini
On 28/07/2015 02:32, Marc-André Lureau wrote: > From: Marc-André Lureau > > If a chardev is allowed to be created outside of QMP, then it must be > also possible to free it. This is useful for ivshmem that creates > chardev anonymously and must be able to free them. > > Signed-off-by: Marc-And

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Paolo Bonzini
On 28/07/2015 02:32, Marc-André Lureau wrote: > From: Marc-André Lureau > > ivshmem is going to use MSIX state conditionally. > > Signed-off-by: Marc-André Lureau > --- > include/hw/pci/msix.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/include

Re: [Qemu-devel] qemu 2.4rc2 : iothread hanging vm (2.4rc1 works fine)

2015-07-29 Thread Alexandre DERUMIER
>>Stefan has a set of patches that fix it. Yes, I just see it. I'll them today. Thanks ! - Mail original - De: "pbonzini" À: "aderumier" , "qemu-devel" Envoyé: Mercredi 29 Juillet 2015 09:39:03 Objet: Re: qemu 2.4rc2 : iothread hanging vm (2.4rc1 works fine) On 29/07/2015 06:50, Alexa

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Samuel Thibault
Jan Kiszka, le Wed 29 Jul 2015 09:39:06 +0200, a écrit : > Make sure to add the proper From: of the actual author. Ok. Two of the patches are however from a different author, I haven't found how to specify different From addresses with git send-email. > Also, some are signed-off by you, others no

Re: [Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long)

2015-07-29 Thread Paolo Bonzini
On 28/07/2015 02:32, Marc-André Lureau wrote: > From: Marc-André Lureau > > ivshmem_read() only reads sizeof(long) from the input buffer. Accepting > more could lead to fifo8 abort() on x86 if it's not empty. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 2 +- > 1 file ch

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Jan Kiszka
On 2015-07-29 09:47, Samuel Thibault wrote: > Jan Kiszka, le Wed 29 Jul 2015 09:39:06 +0200, a écrit : >> Make sure to add the proper From: of the actual author. > > Ok. Two of the patches are however from a different author, I haven't > found how to specify different From addresses with git send-

Re: [Qemu-devel] [PATCH RFC v2 27/47] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 12:41 AM, Markus Armbruster wrote: >>> Like reserving ourselves a namespace based on single _ for internal use. >>> We practically already have that - all user names either start with a >>> letter or double underscore, so we could use single (and triple) >>> un

Re: [Qemu-devel] [PATCH RFC v2 27/47] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 12:44 AM, Markus Armbruster wrote: > >>> +def gen_visit_union(name, base, variants): +ret = '' if base: -assert discriminator -base_fields = find_struct(base)['data'].copy() -del base_fields[d

Re: [Qemu-devel] Live migration hangs after migration to remote host

2015-07-29 Thread Eduardo Otubo
On Tue, Jul 28, 2015 at 04=19=46PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > Hello all, > > > > I'm facing a weird behavior on my tests: I am able to live migrate > > between two virtual machines on my localhost, but not to another > > machi

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-29 Thread Dennis Luehring
currently qemu emulates an TI UltraSparc IIi (Sabre) does that mean that qemu emulates the sparc somwhere around 270-480Mhz (i can't find the running mhz in qemu) how can i get the Mhz the sparc is running? (cpuinfo and lscpu missing Mhz, dmidecode is not available, /sys/devices/system/cpu/cpu

Re: [Qemu-devel] Live migration hangs after migration to remote host

2015-07-29 Thread Dr. David Alan Gilbert
* Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > On Tue, Jul 28, 2015 at 04=19=46PM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > > Hello all, > > > > > > I'm facing a weird behavior on my tests: I am able to live migrate > > > betwee

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-29 Thread Artyom Tarasenko
On Wed, Jul 29, 2015 at 8:20 AM, Dennis Luehring wrote: > Am 28.07.2015 um 11:54 schrieb Artyom Tarasenko: >>> >>> >anything i can do to speedup the emulation? >> >> Maybe try the fresh tcg optimizer improvements from Aurelien: >> https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg05133.html

Re: [Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long)

2015-07-29 Thread Marc-André Lureau
Hi On Wed, Jul 29, 2015 at 9:47 AM, Paolo Bonzini wrote: > I would prefer to change all longs to uint64_t, to avoid a dependency on > the host long size. Even better one could have uint32_t for the id plus > a flags value that for now would always be zero. I would prefer too, but that would br

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Marc-André Lureau
Hi On Wed, Jul 29, 2015 at 9:41 AM, Paolo Bonzini wrote: > Why can't it be saved unconditionally? It can, it's just that in some case (msi=0) it's unused. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long)

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 10:26, Marc-André Lureau wrote: >> I would prefer to change all longs to uint64_t, to avoid a dependency on >> > the host long size. Even better one could have uint32_t for the id plus >> > a flags value that for now would always be zero. > > I would prefer too, but that would bre

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 10:28, Marc-André Lureau wrote: >> Why can't it be saved unconditionally? > > It can, it's just that in some case (msi=0) it's unused. I think what we've been doing (e.g. hw/scsi/megasas.c) is to just always save it. Paolo

Re: [Qemu-devel] [PATCH RFC v2 29/47] qapi: Replace dirty is_c_ptr() by method c_null()

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 01:34 AM, Markus Armbruster wrote: >> Let me rephrase to make sure I understand. >> >> Ignore the (not rets) case, because retval doesn't exist then. >> >> qmp_marshal_output_FOO() visits retval twice. First, with a QMP output >> visitor to do the actual mars

Re: [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory

2015-07-29 Thread Paolo Bonzini
On 28/07/2015 17:08, Igor Mammedov wrote: >> > hw/mem/pc-dimm.c | 7 +++ >> > hw/virtio/vhost-backend.c | 23 ++- >> > hw/virtio/vhost-user.c| 8 +++- >> > hw/virtio/vhost.c | 21 + >> > includ

Re: [Qemu-devel] [PATCH RFC v2 33/47] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 03:13 PM, Eric Blake wrote: > >> > -def generate_command_decl(name, args, ret_type): > -arglist="" > +def gen_command_decl(name, args, rets): I can see how 'args' is plural (even if it is a single string for the name of a type con

Re: [Qemu-devel] [PATCH RFC v2 37/47] qapi: De-duplicate parameter list generation

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 05:15 AM, Markus Armbruster wrote: > >>> Yeah, avoiding line wraps consumes fewer source bytes (fewer runs of >>> spaces), but the space isn't being wasted by storing generated files in >>> git, nor does the C compiler care which layout we use. And honestly, >>

Re: [Qemu-devel] Live migration hangs after migration to remote host

2015-07-29 Thread Eduardo Otubo
On Wed, Jul 29, 2015 at 09=11=21AM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > On Tue, Jul 28, 2015 at 04=19=46PM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > > > Hello all, > > > > > >

Re: [Qemu-devel] [PATCH] fixup! virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-29 Thread Stefan Hajnoczi
On Mon, Jul 27, 2015 at 01:41:32PM +0200, Paolo Bonzini wrote: > Tweak the error message so that it does not mention SCSI passthrough. That > can be confusing because you can have scsi=on even for file-backed image, > which obviously do not support SCSI passthrough at the block layer level. > > S

[Qemu-devel] [PATCH 2/2] virtio-scsi-test: Add test case for tail unaligned WRITE SAME

2015-07-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/virtio-scsi-test.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 11ccdd6..afd22c6 100644 --- a/tests/virtio-scsi-test.c +++ b/tests/virtio-scsi-test.c @@ -221,9 +221,12

[Qemu-devel] [PATCH 0/2] scsi-disk: Fix an assertion failure

2015-07-29 Thread Fam Zheng
The first patch fixes the bug, and second patch adds a regression test case. Fam Zheng (2): scsi-disk: Fix assertion failure on WRITE SAME virtio-scsi-test: Add test case for tail unaligned WRITE SAME hw/scsi/scsi-disk.c | 3 +++ tests/virtio-scsi-test.c | 12 +--- 2 files ch

[Qemu-devel] [PATCH COLO-Frame v8 01/34] configure: Add parameter for configure to enable/disable COLO support

2015-07-29 Thread zhanghailiang
configure --enable-colo/--disable-colo to switch COLO support on/off. COLO support is off by default. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei --- configure | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure b/configure index 704b

[Qemu-devel] [PATCH COLO-Frame v8 11/34] COLO: Save VM state to slave when do checkpoint

2015-07-29 Thread zhanghailiang
We should save PVM's RAM/device to slave when needed. For VM state, we will cache them in slave, we use QEMUSizedBuffer to store the data, we need know the data size of VM state, so in master, we use qsb to store VM state temporarily, and then migrate the data to slave. Signed-off-by: zhanghailia

[Qemu-devel] [PATCH 1/2] scsi-disk: Fix assertion failure on WRITE SAME

2015-07-29 Thread Fam Zheng
The last portion of an unaligned WRITE SAME command could fail the assertion in bdrv_aligned_pwritev: assert(!qiov || bytes == qiov->size); Because we updated data->iov.iov_len right above this if block, but data->qiov still has the old size. Reinitialize the qiov to make them equal and keep

[Qemu-devel] [PATCH COLO-Frame v8 08/34] COLO: Implement colo checkpoint protocol

2015-07-29 Thread zhanghailiang
We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points, Primary Secondary NEW @

[Qemu-devel] [PATCH COLO-Frame v8 15/34] COLO RAM: Flush cached RAM into SVM's memory

2015-07-29 Thread zhanghailiang
During the time of VM's running, PVM/SVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be some with PVM's memory after checkpoint. Instead of flushing all content of SVM's

[Qemu-devel] [PATCH COLO-Frame v8 05/34] migration: Add state records for migration incoming

2015-07-29 Thread zhanghailiang
For migration destination, we also need to know its state, we will use it in COLO. Here we add a new member 'state' for MigrationIncomingState, and also use migrate_set_state() to modify its value. We fix the first parameter of migrate_set_state(), and make it public. Signed-off-by: zhanghailiang

[Qemu-devel] [PATCH COLO-Frame v8 09/34] COLO: Add a new RunState RUN_STATE_COLO

2015-07-29 Thread zhanghailiang
Guest will enter this state when paused to save/restore VM state under colo checkpoint. Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert --- qapi-schema.json | 5 - vl.c | 8

[Qemu-devel] [PATCH COLO-Frame v8 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2015-07-29 Thread zhanghailiang
This is the 8th version of COLO. Here is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include block replication. The block part is treated as a separate series. As usual, we provide 'basic' and 'developing' branches in github: https://github.com/co

Re: [Qemu-devel] Using the one disk image file on 2 virtual machines at the same time

2015-07-29 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:57:30AM +0900, Manjong Han wrote: > I was facing a weird behavior when I used the one disk image file on 2 > virtual machines at the same time. > > I made the instance of a virtual machine, using the below command. > $ qemu-system-x86_64 -smp 2 -m 1024 -hda 10G.qcow2 -en

[Qemu-devel] [PATCH COLO-Frame v8 12/34] COLO RAM: Load PVM's dirty page into SVM's RAM cache temporarily

2015-07-29 Thread zhanghailiang
The ram cache is initially the same as SVM/PVM's memory. At checkpoint, we cache the dirty RAM of PVM into RAM cache in the slave (so that RAM cache always the same as PVM's memory at every checkpoint), we will flush cached RAM to SVM after we receive all PVM's vmstate (RAM/device). Signed-off-by

[Qemu-devel] [PATCH COLO-Frame v8 07/34] migration: Integrate COLO checkpoint process into loadvm

2015-07-29 Thread zhanghailiang
Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. We add three new members to struct MigrationIncomingState, 'have_colo_incoming_thread' and 'colo_incoming_thread' record the colo related threads for secondary VM, 'migration_incoming_co' records the

[Qemu-devel] [PATCH COLO-Frame v8 10/34] QEMUSizedBuffer: Introduce two help functions for qsb

2015-07-29 Thread zhanghailiang
Introduce two new QEMUSizedBuffer APIs which will be used by COLO to buffer VM state: One is qsb_put_buffer(), which put the content of a given QEMUSizedBuffer into QEMUFile, this is used to send buffered VM state to secondary. Another is qsb_fill_buffer(), read 'size' bytes of data from the file i

[Qemu-devel] [PATCH COLO-Frame v8 17/34] COLO failover: Introduce state to record failover process

2015-07-29 Thread zhanghailiang
When handling failover, we do different things according to the different stage of failover process, here we introduce a global atomic variable to record the status of failover. We add four failover status to indicate the different stage of failover process. You should use the helpers to get and s

[Qemu-devel] [PATCH COLO-Frame v8 28/34] COLO: Handle nfnetlink message from proxy module

2015-07-29 Thread zhanghailiang
Proxy module will send message to qemu through nfnetlink. Now, the message only contains the result of packets comparation. We use a global variable 'packet_compare_different' to store the result. And this variable should be accessed by using atomic related function, such as 'atomic_set' 'atomic_x

[Qemu-devel] [PATCH COLO-Frame v8 16/34] COLO failover: Introduce a new command to trigger a failover

2015-07-29 Thread zhanghailiang
We leave users to use whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use command 'colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations accordingly. For example, If send the command to PVM, Primary will exit COLO mode, and

[Qemu-devel] [PATCH COLO-Frame v8 06/34] migration: Integrate COLO checkpoint process into migration

2015-07-29 Thread zhanghailiang
Add a migrate state: MIGRATION_STATUS_COLO, enter this migration state after the first live migration successfully finished. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei --- include/migration/colo.h | 3 +++ migration/colo.c | 58 ++

[Qemu-devel] [PATCH COLO-Frame v8 19/34] qmp event: Add event notification for COLO error

2015-07-29 Thread zhanghailiang
If some errors happen during VM's COLO FT stage, it's import to notify the users this event, Togehter with 'colo_lost_heartbeat', users can intervene in COLO's failover work immediately. If users don't want to get involved in COLO's failover verdict, it is still necessary to notify users that we ex

[Qemu-devel] [PATCH COLO-Frame v8 13/34] COLO VMstate: Load VM state into qsb before restore it

2015-07-29 Thread zhanghailiang
We should not destroy the state of secondary until we receive the whole state from the primary, in case the primary fails in the middle of sending the state, so, here we cache the device state in Secondary before restore it. Besides, we should call qemu_system_reset() before load VM state, which c

[Qemu-devel] [PATCH COLO-Frame v8 14/34] arch_init: Start to trace dirty pages of SVM

2015-07-29 Thread zhanghailiang
we will use this dirty bitmap together with VM's cache RAM dirty bitmap to decide which page in cache should be flushed into VM's RAM. Signed-off-by: zhanghailiang --- migration/ram.c | 16 1 file changed, 16 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 08

[Qemu-devel] [PATCH COLO-Frame v8 03/34] COLO: migrate colo related info to slave

2015-07-29 Thread zhanghailiang
We can know if VM in destination should go into COLO mode by refer to the info that been migrated from PVM. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei --- include/migration/colo.h | 2 ++ migration/Makefile.objs | 1 + migration/colo-comm.c| 49

[Qemu-devel] [PATCH COLO-Frame v8 22/34] COLO NIC: Init/remove colo nic devices when add/cleanup tap devices

2015-07-29 Thread zhanghailiang
When go into COLO mode, we need to some init work for all VM's nics. Here we use a list to record these nic, and for now we only support the 'tap' nic backend. Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 5 net/M

Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM

2015-07-29 Thread Xiao Guangrong
On 07/03/2015 02:11 AM, Paolo Bonzini wrote: On 02/07/2015 20:01, Xiao Guangrong wrote: Thanks for your review, Stefan and Paolo! On 07/02/2015 05:52 PM, Paolo Bonzini wrote: On 02/07/2015 11:20, Stefan Hajnoczi wrote: Currently, the NVDIMM driver has been merged into upstream Linux Ke

[Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread zhanghailiang
We also change the parameters of launch_script(). Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/tap.h | 2 ++ net/tap.c | 31 ++- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/i

[Qemu-devel] [PATCH COLO-Frame v8 20/34] COLO failover: Don't do failover during loading VM's state

2015-07-29 Thread zhanghailiang
We should not do failover work while the main thread is loading VM's state, otherwise it will destroy the consistent of VM's memory and device state. Here we add a new failover status 'RELAUNCH' which means we should relaunch the process of failover. Signed-off-by: zhanghailiang Signed-off-by: L

[Qemu-devel] [PATCH COLO-Frame v8 18/34] COLO failover: Implement COLO primary/secondary vm failover work

2015-07-29 Thread zhanghailiang
If there are some errors happen, we will give users(administrators) time to get involved in failover verdict, which they can decide which side should take over the work by using 'colo_lost_heartbeat' command. Note: The default verdict is primary VM takes over work while secondary VM exit. So if us

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread Jason Wang
On 07/29/2015 04:45 PM, zhanghailiang wrote: > We also change the parameters of launch_script(). A quick question (I don't go through the codes tough). What's the plan for management(libvirt)? I believe some setup (iptables, fd creation) should be offloaded to management (libvirt)? Thanks > Cc

[Qemu-devel] [PATCH COLO-Frame v8 04/34] colo-comm/migration: skip colo info section for special cases

2015-07-29 Thread zhanghailiang
For older machine types, we skip the colo info section when do migration, in this way, we can migrate successfully between older mainchine and the new one. We also skip this section if colo is not enabled (i.e. migrate_set_capability colo on), so that, It not break compatibility with migration ho

[Qemu-devel] [PATCH COLO-Frame v8 26/34] COLO NIC: Implement colo nic init/destroy function

2015-07-29 Thread zhanghailiang
When in colo mode, call colo nic init/destroy function. Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 3 +++ migration/colo.c | 14 ++ net/colo-nic.c | 69 ++

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Pavel Fedin
Hello! > I'm not sure but fixed hole start/size might be a problem later when adding > memory hotplug wasting > address space. But 'virt' machine entirely relies on fixed layout. And, we can always change it if we need to. > > On x86 we do it a little different, see call chain: > acpi_set

[Qemu-devel] [PATCH COLO-Frame v8 33/34] COLO: Implement shutdown checkpoint

2015-07-29 Thread zhanghailiang
For Secondary VM, we forbid it shutdown directly when in COLO mode, FOR Primary VM's shutdown, we should do some work to ensure the consistent action between PVM and SVM. Cc: Paolo Bonzini Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/sysemu/sysemu.h | 3 +++ migration/c

[Qemu-devel] [PATCH COLO-Frame v8 25/34] colo-nic: Handle secondary VM's original net device configure

2015-07-29 Thread zhanghailiang
For secondary VM, we need to reconfigure its original net devices, Before go into COLO mode, we detach its original net devices (here is tap) from its default configure (here is bridge), and attach the net devices to forward bridge. When exit from COLO mode, we resume its origianl configure. Signe

[Qemu-devel] [PATCH COLO-Frame v8 24/34] COLO NIC: Implement colo nic device interface configure()

2015-07-29 Thread zhanghailiang
Implement colo nic device interface configure() add a script to configure nic devices: ${QEMU_SCRIPT_DIR}/colo-proxy-script.sh Cc: Stefan Hajnoczi Cc: Jason Wang Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/tap.h| 17 net/colo-nic.c

Re: [Qemu-devel] [PATCH] sdhci: Pass drive parameter to sdhci-pci via qdev property

2015-07-29 Thread Stefan Hajnoczi
On Tue, Jul 28, 2015 at 12:22:43PM -0400, Kevin O'Connor wrote: > Commit 19109131 disabled the sdhci-pci support because it used > drive_get_next(). This patch reenables sdhci-pci and changes it to > pass the drive via a qdev property - for example: > -device sdhci-pci,drive=drive0 -drive id=driv

[Qemu-devel] [PATCH COLO-Frame v8 21/34] COLO: Add new command parameter 'forward_nic' 'colo_script' for net

2015-07-29 Thread zhanghailiang
The 'forward_nic' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', 'colo_script' should be assigned with an scirpt path. We parse these parameter in tap. Cc: Stefan Hajnoczi Cc: Jason Wang Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhan

[Qemu-devel] [PATCH COLO-Frame v8 29/34] COLO: Do checkpoint according to the result of packets comparation

2015-07-29 Thread zhanghailiang
Only do checkpoint, when the PVM's and SVM's output net packets are inconsistent, We also limit the min time between two continuous checkpoint action, to give VM a change to run. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 2 ++ migration/colo.c |

[Qemu-devel] [PATCH COLO-Frame v8 30/34] COLO: Improve checkpoint efficiency by do additional periodic checkpoint

2015-07-29 Thread zhanghailiang
Besides normal checkpoint which according to the result of net packets comparing, We do additional checkpoint periodically, it will reduce the number of dirty pages when do one checkpoint, if we don't do checkpoint for a long time (This is a special case when the net packets is always consistent).

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] AioContext: fix deadlock after aio_context_acquire() race

2015-07-29 Thread Stefan Hajnoczi
On Tue, Jul 28, 2015 at 06:34:06PM +0200, Paolo Bonzini wrote: > v3: same as v1, but include virtio-blk-dataplane fix and move thread_pool_free > before the loop. Same result as applying in order: > > [PATCH for-2.4 1/2] AioContext: avoid leaking BHs on cleanup > [PATCH for-2.4 2/2] AioContext: f

[Qemu-devel] [PATCH COLO-Frame v8 32/34] COLO NIC: Implement NIC checkpoint and failover

2015-07-29 Thread zhanghailiang
Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- include/net/colo-nic.h | 2 ++ migration/colo.c | 22 +++--- net/colo-nic.c | 23 +++ 3 files changed, 44 insertions(+), 3 deletions(-) diff --git a/include/net/colo-nic.h b/include/net

[Qemu-devel] [PATCH COLO-Frame v8 02/34] migration: Introduce capability 'colo' to migration

2015-07-29 Thread zhanghailiang
We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'colo' string to users, they can use qmp command 'query-migrate-capabilities' or hmp command 'info migrate_capabilities' to learn if colo is supported. Cc: Juan

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Peter Maydell
On 29 July 2015 at 09:58, Pavel Fedin wrote: > So, can we leave fixed layout for now? I am currently reworking the patch > because i discovered problems with 32-bit guests. They simply truncate > high word and end up in attempt to put PCI at 0x - 0x, fail, > and do not work of cou

[Qemu-devel] [PATCH COLO-Frame v8 27/34] COLO NIC: Some init work related with proxy module

2015-07-29 Thread zhanghailiang
Implement communication protocol with proxy module by using nfnetlink, which requires libnfnetlink libs. Tell proxy module to do initialization work and moreover ask kernel to acknowledge the request. It's is necessary for the first time because Netlink is not a reliable protocol. Cc: Stefan Hajn

[Qemu-devel] [PATCH COLO-Frame v8 31/34] COLO: Add colo-set-checkpoint-period command

2015-07-29 Thread zhanghailiang
With this command, we can control the period of checkpoint, if there is no comparison of net packets. Cc: Luiz Capitulino Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- hmp-commands.hx| 15 +++ hmp.c | 7 +

[Qemu-devel] [PATCH COLO-Frame v8 34/34] COLO: Add block replication into colo process

2015-07-29 Thread zhanghailiang
Make sure master start block replication after slave's block replication started. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang Signed-off-by: Li Zhijian --- migration/colo.c | 71 +--- trace-events

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] AioContext: fix deadlock after aio_context_acquire() race

2015-07-29 Thread Cornelia Huck
On Tue, 28 Jul 2015 18:34:06 +0200 Paolo Bonzini wrote: > v3: same as v1, but include virtio-blk-dataplane fix and move thread_pool_free > before the loop. Same result as applying in order: > > [PATCH for-2.4 1/2] AioContext: avoid leaking BHs on cleanup > [PATCH for-2.4 2/2] AioContext: force

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Igor Mammedov
On Mon, 27 Jul 2015 14:09:28 +0300 Pavel Fedin wrote: > @@ -234,6 +236,12 @@ static void acpi_dsdt_add_pci(Aml *scope, const > MemMapEntry *memmap, int irq) > AML_ENTIRE_RANGE, 0x, 0x, size_pio - 1, > base_pio, > size_pio)); > > +aml_app

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2015 at 04:57:49PM +0800, Jason Wang wrote: > > > On 07/29/2015 04:45 PM, zhanghailiang wrote: > > We also change the parameters of launch_script(). > > A quick question (I don't go through the codes tough). What's the plan > for management(libvirt)? I believe some setup (iptable

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread zhanghailiang
On 2015/7/29 16:57, Jason Wang wrote: On 07/29/2015 04:45 PM, zhanghailiang wrote: We also change the parameters of launch_script(). A quick question (I don't go through the codes tough). What's the plan for management(libvirt)? I believe some setup (iptables, fd creation) should be offloade

Re: [Qemu-devel] [PATCH RFC v2 45/47] qapi: New QMP command query-schema for QMP schema introspection

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 08:33 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 07/01/2015 02:22 PM, Markus Armbruster wrote: Caution, rough edges. >>> >>> No joke. It doesn't even compile without this fixup to a rebase snafu >>> (see [0] below): >> >> Uh, how did th

Re: [Qemu-devel] [PATCH RFC v2 47/47] qapi-introspect: Hide type names

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 12:39 PM, Markus Armbruster wrote: > >> >> Could do plain integer. I guess I started down the base32 road to >> squeeze out a few more characters, then sabotaged myself by always using >> three base32 characters. >> > >> >> In the introspection schema, every

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread Jason Wang
On 07/29/2015 05:17 PM, zhanghailiang wrote: > On 2015/7/29 16:57, Jason Wang wrote: >> >> >> On 07/29/2015 04:45 PM, zhanghailiang wrote: >>> We also change the parameters of launch_script(). >> >> A quick question (I don't go through the codes tough). What's the plan >> for management(libvirt)?

Re: [Qemu-devel] [PATCH] xen: Drop net_rx_ok

2015-07-29 Thread Stefano Stabellini
On Mon, 27 Jul 2015, Stefan Hajnoczi wrote: > On Mon, Jul 20, 2015 at 06:12:09PM +0100, Stefan Hajnoczi wrote: > > On Thu, Jul 02, 2015 at 01:39:16PM +0100, Stefan Hajnoczi wrote: > > > On Tue, Jun 30, 2015 at 10:42:37AM +0800, Fam Zheng wrote: > > > > This is necessary because once we return false

Re: [Qemu-devel] [PATCH] net/vmxnet3: Fix incorrect debug message

2015-07-29 Thread Stefan Hajnoczi
On Tue, Jul 28, 2015 at 09:44:50PM +0300, Shmulik Ladkani wrote: > From: Dana Rubin > > From: Dana Rubin > > In commit 80da311d81, >"net/vmxnet3: Fix RX TCP/UDP checksum on partially summed packets" > a debug message was introduced in vmxnet3_rx_need_csum_calculate() for > an unlikely input

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-29 Thread Liu Yuan
On Wed, Jul 29, 2015 at 02:04:55PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jul 2015 12:02:35 +0800, > Liu Yuan wrote: > > > > From: Liu Yuan > > > > Current sheepdog driver use a range update_inode(min_idx, max_idx) for > > batching > > the updates. But there is subtle problem by determining

Re: [Qemu-devel] Live migration hangs after migration to remote host

2015-07-29 Thread Dr. David Alan Gilbert
* Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > On Wed, Jul 29, 2015 at 09=11=21AM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > > On Tue, Jul 28, 2015 at 04=19=46PM +0100, Dr. David Alan Gilbert wrote: > > > > * Eduardo Otubo (eduard

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Igor Mammedov
On Wed, 29 Jul 2015 11:58:11 +0300 Pavel Fedin wrote: > Hello! > > > I'm not sure but fixed hole start/size might be a problem later when > > adding memory hotplug > wasting > > address space. > > But 'virt' machine entirely relies on fixed layout. And, we can always > change it if we need

[Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2015-07-29 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit : > On 2015-07-29 00:12, Samuel Thibault wrote: > > Hello, > > > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : > >> Of course, I'm fine with handing this over to someone who'd like to > >> pick

Re: [Qemu-devel] [PATCH RFC v2 47/47] qapi-introspect: Hide type names

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2015 12:24 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 07/01/2015 02:22 PM, Markus Armbruster wrote: To eliminate the temptation for clients to look up types by name (which are not ABI), replace all type names by meaningless strings.

Re: [Qemu-devel] [PATCH RFC v2 47/47] qapi-introspect: Hide type names

2015-07-29 Thread Markus Armbruster
Eric Blake writes: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> To eliminate the temptation for clients to look up types by name >> (which are not ABI), replace all type names by meaningless strings. >> >> Reduces output of query-schema by 9 out of 80KiB. > > Among other things, it repl

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Jul 29, 2015 at 04:57:49PM +0800, Jason Wang wrote: > > > > > > On 07/29/2015 04:45 PM, zhanghailiang wrote: > > > We also change the parameters of launch_script(). > > > > A quick question (I don't go through the codes tough). What's t

Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public

2015-07-29 Thread zhanghailiang
On 2015/7/29 17:24, Jason Wang wrote: On 07/29/2015 05:17 PM, zhanghailiang wrote: On 2015/7/29 16:57, Jason Wang wrote: On 07/29/2015 04:45 PM, zhanghailiang wrote: We also change the parameters of launch_script(). A quick question (I don't go through the codes tough). What's the plan f

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Samuel Thibault
Jan Kiszka, le Wed 29 Jul 2015 09:58:36 +0200, a écrit : > On 2015-07-29 09:47, Samuel Thibault wrote: > > Ok. Two of the patches are however from a different author, I haven't > > found how to specify different From addresses with git send-email. > > This knowledge is buried in scripts here, but

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Pavel Fedin
> > because i discovered problems with 32-bit guests. They simply truncate > > high word and end up in attempt to put PCI at 0x - 0x, fail, > > and do not work of course. So, my next version will have high MMIO > > only for 64-bit guests. > > That sounds like a guest bug to me. If

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Pavel Fedin
Hello! > this is wrong since dword is too small for values of high memory > use aml_qword_memory() instead Thanks, will fix it. > since window is at fixed position and it's not possible for guest to > move base address of the range, make AddressMaximum the same as > AddressMinimum i.e. But

Re: [Qemu-devel] [aswg] request for ACPI ID for QEMU

2015-07-29 Thread Michael S. Tsirkin
On Thu, Jul 16, 2015 at 12:04:23AM +, Doran, Mark wrote: > Hi Everyone: > > > > The QEMU community would like to register a vendor ID prefix for use with QEMU > and some of the drivers for “soft” devices used in that VM environment. After > some discussion the consensus is to have Red Hat

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Peter Maydell
On 29 July 2015 at 10:45, Pavel Fedin wrote: >> > because i discovered problems with 32-bit guests. They simply truncate >> > high word and end up in attempt to put PCI at 0x - 0x, >> > fail, >> > and do not work of course. So, my next version will have high MMIO >> > only for 64-

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-07-29 Thread Pavel Fedin
Hello! > > I'm not sure that ARM architecture has this machine_done callback. > Maybe this would help you, >git grep machine_done Heh, i was not patient enough. I have already discovered this by myself, and yes, "virt" uses the same mechanism. But, still, i perhaps can have problems with

Re: [Qemu-devel] Live migration hangs after migration to remote host

2015-07-29 Thread Eduardo Otubo
On Wed, Jul 29, 2015 at 10=32=59AM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > On Wed, Jul 29, 2015 at 09=11=21AM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Otubo (eduardo.ot...@profitbricks.com) wrote: > > > > On Tue, Jul 28, 2015 at

  1   2   3   4   >