Re: [Qemu-devel] [PATCH 3/3] mirror: Speed up bitmap initial scanning

2015-07-14 Thread Stefan Hajnoczi
On Thu, Jul 09, 2015 at 11:47:58AM +0800, Fam Zheng wrote: > Limiting to sectors_per_chunk for each bdrv_is_allocated_above is slow, > because the underlying protocol driver would issue much more queries > than necessary. We should coalesce the query. > > Signed-off-by: Fam Zheng > --- > block/m

[Qemu-devel] [PATCH 1/2] virtio-input: move sys/ioctl.h include

2015-07-14 Thread Gerd Hoffmann
Drop from include/standard-headers/linux/input.h Add to hw/input/virtio-input-host.c instead. That allows to build virtio-input (except pass-through) on windows. Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-host.c | 1 + include/standard-headers/linux/input.h | 1 - scripts/

[Qemu-devel] [PATCH 2/2] virtio-input: enable on non-linux hosts

2015-07-14 Thread Gerd Hoffmann
As we include a copy of the linux input layer header file in the qemu source tree (include/standard-headers/linux/input.h) the virtio-input bits (except pass-through) should build and work just fine on non-linux hosts too. Tweak Makefile accordingly. Cc: Paolo Bonzini Cc: qemu-triv...@nongnu.org

Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests

2015-07-14 Thread Andreas Färber
Am 07.07.2015 um 10:53 schrieb Cornelia Huck: > From: Xu Wang > > The diag288 watchdog is no sysbus device, therefore it doesn't get > triggered on resets automatically using dc->reset. > > Let's register the reset handler manually, so we get correctly notified > again when a system reset was re

[Qemu-devel] [PULL for-2.4 0/1] vnc: fix vnc client authentication

2015-07-14 Thread Gerd Hoffmann
tags/pull-vnc-20150714-1 for you to fetch changes up to a16951375f7669b7faf27f72ca753e25325c5179: vnc: fix vnc client authentication (2015-07-14 15:33:48 +0200) vnc: fix vnc client authentication

[Qemu-devel] [PULL 1/1] vnc: fix vnc client authentication

2015-07-14 Thread Gerd Hoffmann
From: Wolfgang Bumiller Commit 800567a61 updated the code to the generic crypto API and mixed up encrypt and decrypt functions in procotol_client_auth_vnc. (Used to be: deskey(key, EN0) which encrypts, and was changed to qcrypto_cipher_decrypt in 800567a61.) Changed it to qcrypto_cipher_encrypt n

Re: [Qemu-devel] [PATCH v3] qxl: allow to specify head limit to qxl driver

2015-07-14 Thread Gerd Hoffmann
Hi, > > This patch rely on some change in spice-protocol which are not still > > accepted. See > > http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. What is the upstream status here? accepted meanwhile? cheers, Gerd

Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly register for system reset requests

2015-07-14 Thread Peter Maydell
On 9 July 2015 at 17:16, Peter Crosthwaite wrote: > On Thu, Jul 9, 2015 at 5:41 AM, Cornelia Huck > wrote: >> On Wed, 8 Jul 2015 12:31:40 +0200 >> Cornelia Huck wrote: >>> OTOH, this is less code than I expected. With the following code, I see >>> the diag288 reset callback called on system res

Re: [Qemu-devel] [PATCH v2] ich9: initialise RCBA register through LPC interface

2015-07-14 Thread Gerd Hoffmann
On Do, 2015-07-09 at 21:04 -0300, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features on QEMU. qemu patches are merged, committed this one too now. Also cherry-picked into 1.8-stable. So, time to roll 1.8.3? Anythi

Re: [Qemu-devel] [PULL for-2.4 0/1] vnc: fix vnc client authentication

2015-07-14 Thread Vasiliy Tolstov
2015-07-14 16:39 GMT+03:00 Gerd Hoffmann : > > Here comes the vnc queue with a single one-line fix. > > please pull, > Gerd > > The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899: > > Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100) Thanks! This vnc p

Re: [Qemu-devel] unable to auth to vnc with qemu 2.4.0-rc0

2015-07-14 Thread Vasiliy Tolstov
2015-07-14 15:01 GMT+03:00 Paolo Bonzini : > Can you send the config.log and config-host.mak file from the build > directory? I see in list that patch already created. Thanks! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] unable to auth to vnc with qemu 2.4.0-rc0

2015-07-14 Thread Paolo Bonzini
On 14/07/2015 15:59, Vasiliy Tolstov wrote: > 2015-07-14 15:01 GMT+03:00 Paolo Bonzini : >> > Can you send the config.log and config-host.mak file from the build >> > directory? > > I see in list that patch already created. Thanks! Which patch is it? Paolo

Re: [Qemu-devel] unable to auth to vnc with qemu 2.4.0-rc0

2015-07-14 Thread Vasiliy Tolstov
2015-07-14 17:05 GMT+03:00 Paolo Bonzini : > Which patch is it? From: Wolfgang Bumiller Commit 800567a61 updated the code to the generic crypto API and mixed up encrypt and decrypt functions in procotol_client_auth_vnc. (Used to be: deskey(key, EN0) which encrypts, and was changed to qcrypto_ci

Re: [Qemu-devel] [PATCH v3] qxl: allow to specify head limit to qxl driver

2015-07-14 Thread Frediano Ziglio
> > Hi, > > > > This patch rely on some change in spice-protocol which are not still > > > accepted. See > > > http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. > > What is the upstream status here? accepted meanwhile? > > cheers, > Gerd > Accepted and merged, see pa

Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-07-14 Thread Kevin Wolf
Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: > > Ping > > > > On 06/10/2015 08:28 PM, Josh Durgin wrote: > > >Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of > > >cache options and ceph settings. The cache

Re: [Qemu-devel] [PULL for-2.4 0/1] vnc: fix vnc client authentication

2015-07-14 Thread Peter Maydell
ase (2015-07-09 17:56:56 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-vnc-20150714-1 > > for you to fetch changes up to a16951375f7669b7faf27f72ca753e25325c5179: > > vnc: fi

Re: [Qemu-devel] [PATCH for-2.4 00/12] hw/net: Fix .can_receive() for NICs

2015-07-14 Thread Stefan Hajnoczi
On Tue, Jul 14, 2015 at 03:53:29PM +0800, Fam Zheng wrote: > Since a90a742 "tap: Drop tap_can_send", all nics that returns false from > .can_receive() are required to explicitly flush the incoming queue when the > status of it is changing back to true, otherwise the backend will sop > processing mo

Re: [Qemu-devel] Patches

2015-07-14 Thread Stefan Hajnoczi
On Tue, Jul 14, 2015 at 01:12:22AM -0700, Peter Crosthwaite wrote: > Hi Stefan, Peter, > > Is patches down? I don't see any patches for the last 3 days and there > is definitely new things on list: > > $ ./patches fetch http://vmsplice.net/~patches/patches.json Please switch ~/.patchesrc to this

Re: [Qemu-devel] [Qemu-block] [PATCH v4] block/curl: Don't lose original error when a connection fails.

2015-07-14 Thread Stefan Hajnoczi
On Wed, Jul 08, 2015 at 02:37:48PM +0100, Richard W.M. Jones wrote: > Currently if qemu is connected to a curl source (eg. web server), and > the web server fails / times out / dies, you always see a bogus EIO > "Input/output error". > > For example, choose a large file located on any local webser

Re: [Qemu-devel] [PATCH v7 36/42] Host page!=target page: Cleanup bitmaps

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Prior to the start of postcopy, ensure that everything that will > be transferred later is a whole host-page in size. > > This is accomplished by discarding partially transferred host pages > and marking any that are parti

Re: [Qemu-devel] [RFC PATCH] target-arm: kvm: Differentiate registers based on write-back levels

2015-07-14 Thread Peter Maydell
On 11 July 2015 at 13:18, Christoffer Dall wrote: > On Fri, Jul 10, 2015 at 12:22:31PM +0100, Peter Maydell wrote: >> On 10 July 2015 at 12:00, Christoffer Dall >> wrote: >> > +/* All system registers not listed in the following table are assumed to >> > be >> > + * of the level KVM_PUT_RUNTIME

Re: [Qemu-devel] [PATCH v3 10/15] block: add block job transactions

2015-07-14 Thread John Snow
On 07/13/2015 11:04 PM, Fam Zheng wrote: > On Mon, 07/13 19:12, John Snow wrote: >> >> >> On 07/09/2015 11:46 PM, Fam Zheng wrote: >>> From: Stefan Hajnoczi >>> >>> Sometimes block jobs must execute as a transaction group. Finishing >>> jobs wait until all other jobs are ready to complete succe

Re: [Qemu-devel] [PATCH v7 37/42] Postcopy; Handle userfault requests

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > userfaultfd is a Linux syscall that gives an fd that receives a stream > of notifications of accesses to pages registered with it and allows > the program to acknowledge those stalls and tell the accessing > thread to carr

Re: [Qemu-devel] [PATCH v7 38/42] Start up a postcopy/listener thread ready for incoming page data

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The loading of a device state (during postcopy) may access guest > memory that's still on the source machine and thus might need > a page fill; split off a separate thread that handles the incoming > page data so that the

Re: [Qemu-devel] [PATCH v7 37/42] Postcopy; Handle userfault requests

2015-07-14 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > userfaultfd is a Linux syscall that gives an fd that receives a stream > > of notifications of accesses to pages registered with it and allows > > the program to acknowl

Re: [Qemu-devel] [PATCH v7 40/42] End of migration for postcopy

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Tweak the end of migration cleanup; we don't want to close stuff down > at the end of the main stream, since the postcopy is still sending pages > on the other thread. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-b

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Userfault doesn't work with mlock; mlock is designed to nail down pages > so they don't move, userfault is designed to tell you when they're not > there. > > munlock the pages we userfault protect before postcopy. > mlock

Re: [Qemu-devel] [PATCH v7 42/42] Inhibit ballooning during postcopy

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Postcopy detects accesses to pages that haven't been transferred yet > using userfaultfd, and it causes exceptions on pages that are 'not > present'. > Ballooning also causes pages to be marked as 'not present' when the >

Re: [Qemu-devel] [PATCH v7 37/42] Postcopy; Handle userfault requests

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > userfaultfd is a Linux syscall that gives an fd that receives a stream >> > of notifications of accesses to pages registered with

Re: [Qemu-devel] [PATCH v7 39/42] postcopy: Wire up loadvm_postcopy_handle_ commands

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Wire up more of the handlers for the commands on the destination side, > in particular loadvm_postcopy_handle_run now has enough to start the > guest running. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Q

[Qemu-devel] Write requests, during read operations

2015-07-14 Thread Gleb Stepanov
Hello, all. We are testing disk I/O perfomance using fio tool. I've measured performance on qcow2 image mounted to nb0 device. I run tests and launch iostat -x 1 command to browse I/O operations. Test consists of sequential read operations with 1 MB size. I've get following output. Device:

[Qemu-devel] [PULL 02/11] nvme: properly report volatile write caches

2015-07-14 Thread Kevin Wolf
From: Christoph Hellwig Implement support in Identify and Get/Set Features to properly report and allow to change the Volatile Write Cache status reported by the virtual NVMe device. Signed-off-by: Christoph Hellwig Acked-by: Keith Busch Signed-off-by: Kevin Wolf --- hw/block/nvme.c | 19 +++

[Qemu-devel] [PULL 05/11] block: Introduce bdrv_unref_child()

2015-07-14 Thread Kevin Wolf
This is the counterpart for bdrv_open_child(). It decreases the reference count of the child BDS and removes it from the list of children of the given parent BDS. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 23 +-- include/block/block.h | 1

[Qemu-devel] [PULL 03/11] block: Move bdrv_attach_child() calls up the call chain

2015-07-14 Thread Kevin Wolf
Let the callers of bdrv_open_inherit() call bdrv_attach_child(). It needs to be called in all cases where bdrv_open_inherit() succeeds (i.e. returns 0) and a child_role is given. bdrv_attach_child() is moved upwards to avoid a forward declaration. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz

[Qemu-devel] [PULL 10/11] rbd: make qemu's cache setting override any ceph setting

2015-07-14 Thread Kevin Wolf
From: Josh Durgin To be safe, when cache=none is used ceph settings should not be able to override it to turn on caching. This was previously possible with rbd_cache=true in the rbd device configuration or a ceph configuration file. Similarly, rbd settings could have turned off caching when qemu

[Qemu-devel] [PULL 04/11] block: Introduce bdrv_open_child()

2015-07-14 Thread Kevin Wolf
It is the same as bdrv_open_image(), except that it doesn't only return success or failure, but the newly created BdrvChild object for the new child node. As the BdrvChild object already contains a BlockDriverState pointer (and this is supposed to become the only pointer so that bdrv_append() and

[Qemu-devel] [PULL 09/11] MAINTAINERS: update email address

2015-07-14 Thread Kevin Wolf
From: Josh Durgin The old one still works for now, but will not work indefinitely. Signed-off-by: Josh Durgin Reviewed-by: Jeff Cody Signed-off-by: Kevin Wolf --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 411da3c..978b717

[Qemu-devel] [PULL 00/11] Block layer patches for 2.4.0-rc1

2015-07-14 Thread Kevin Wolf
The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-07-13 13:35:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch cha

[Qemu-devel] [PULL 01/11] nvme: implement the Flush command

2015-07-14 Thread Kevin Wolf
From: Christoph Hellwig Implement a real flush instead of faking it. This is especially important as Qemu assume Write back cashing by default and thus requires a working cache flush operation for data integrity. Signed-off-by: Christoph Hellwig Acked-by: Keith Busch Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 08/11] rbd: remove unused constants and fields

2015-07-14 Thread Kevin Wolf
From: Josh Durgin RBDAIOCB.status was only used for cancel, which was removed in 7691e24dbebb46658e89b3f950fda6ec78bbb823. RBDAIOCB.sector_num was never used. RADOSCB.done and rcbid were never used. RBD_FD* are obsolete since the pipe was removed in e04fb07fd1676e9facd7f3f878c1bbe03bccd26b. S

[Qemu-devel] [PULL 07/11] block: Fix backing file child when modifying graph

2015-07-14 Thread Kevin Wolf
This patch moves bdrv_attach_child() from the individual places that add a backing file to a BDS to bdrv_set_backing_hd(), which is called by all of them. It also adds bdrv_detach_child() there. For normal operation (starting with one backing file chain and not changing it until the topmost image

[Qemu-devel] [PULL 11/11] rbd: fix ceph settings precedence

2015-07-14 Thread Kevin Wolf
From: Josh Durgin Apply the ceph settings from a config file before any ceph settings from the command line. Since the ceph config file location may be specified on the command line, parse it once to read the config file, and do a second pass to apply the rest of the command line ceph options. S

[Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

2015-07-14 Thread Aurelien Jarno
The LWL/LDL instructions mask the GPR with a mask depending on the address alignement. It is currently computed by doing: mask = 0x7fffull >> (t1 ^ 63) It's simpler to generate it by doing: mask = (1 << t1) - 1 It uses the same number of TCG instructions, but it avoids a 32/

Re: [Qemu-devel] [PATCH] target-mips: fix resource leak reported by Coverity

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 11:08, Leon Alrae wrote: > UHI assert and link operations call lock_user_string() twice to obtain two > strings pointed by gpr[4] and gpr[5]. If the second lock_user_string() > fails, then the first one won't get freed. Fix this by introducing another > macro responsible for obtaining

[Qemu-devel] [PATCH for-2.4 1/2] target-mips: fix page fault address for LWL/LWR/LDL/LDR

2015-07-14 Thread Aurelien Jarno
When a LWL, LWR, LDL or LDR instruction triggers a page fault, QEMU currently reports the aligned address in CP0 BadVAddr, while the Windows NT kernel expects the unaligned address. This patch adds a byte access with the unaligned address at the beginning of the LWL/LWR/LDL/LDR instructions to pos

Re: [Qemu-devel] [PATCH] target-mips: correct DERET instruction

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 11:08, Leon Alrae wrote: > Fix Debug Mode flag clearing, and when DERET is placed between LL and SC > do not make SC fail. > > Signed-off-by: Leon Alrae > --- > target-mips/op_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-mips/op_helper

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 11:08, Leon Alrae wrote: > Make use of CMPOP in floating-point compare instructions. > > Signed-off-by: Leon Alrae > --- > target-mips/translate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 7302857..4a1ffdb

Re: [Qemu-devel] [PATCH 6/8] disas: sh4: QOMify target specific disas setup

2015-07-14 Thread Aurelien Jarno
On 2015-07-11 19:00, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > Move the target_disas() sh4 specifics to the QOM disas_set_info hook > and delete the #ifdef specific code in disas.c. > > Cc: Aurelien Jarno > Signed-off-by: Peter Crosthwaite > --- > Testing: > $ ../../qemu/sh4-softm

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-14 Thread John Snow
On 07/14/2015 04:30 AM, Paolo Bonzini wrote: > > > On 13/07/2015 21:41, John Snow wrote: >> s->ports should never exceed 32, but coverity doesn't know that. >> ncq_tfs->sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false posi

[Qemu-devel] [PATCH 0/2] target-mips: fix Windows NT support

2015-07-14 Thread Aurelien Jarno
This patch set fix Windows NT support by correctly emulating the LWL/LWR/LDL/LDR instructions. The first patch is the actual fix and we might want to see it included in 2.4, though the problem is not new to 2.4. The second patch is a small improvement in the generated TCG code, so we probably want

[Qemu-devel] [PULL 06/11] block: Reorder cleanups in bdrv_close()

2015-07-14 Thread Kevin Wolf
Block drivers may still want to access their child nodes in their .bdrv_close handler. If they unref and/or detach a child by themselves, this should not result in a double free. There is additional code for backing files, which are just a special case of child nodes. The same applies for them. S

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

2015-07-14 Thread Paolo Bonzini
On 14/07/2015 17:45, Aurelien Jarno wrote: > The LWL/LDL instructions mask the GPR with a mask depending on the > address alignement. It is currently computed by doing: > > mask = 0x7fffull >> (t1 ^ 63) > > It's simpler to generate it by doing: > > mask = (1 << t1) - 1 Usi

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Leon Alrae
On 14/07/2015 16:45, Aurelien Jarno wrote: > By the way, is this debug code really useful? I think by looking at the > TCG code (-d in_asm,op), it's easy to determine if an instruction is > correctly disassembled or not. > For me this debug code doesn't seem to be useful at all and it only clutte

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 17:22, Leon Alrae wrote: > On 14/07/2015 16:45, Aurelien Jarno wrote: > > By the way, is this debug code really useful? I think by looking at the > > TCG code (-d in_asm,op), it's easy to determine if an instruction is > > correctly disassembled or not. > > > > For me this debug cod

Re: [Qemu-devel] [PATCH 1/6] ARM: add Cortex-M3/M4 exception configuration and status registers

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/cpu.h | 51 > ++ > target-arm/machine.c |6 ++ > 2 files changed, 57 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > i

[Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Leon Alrae
There seems to be an issue when trying to keep a pointer in bottom 32-bits of a 64-bit floating point register. Load and store instructions accessing this address for some reason use the whole 64-bit content of floating point register rather than truncated 32-bit value. The following load uses inco

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 18:17, Paolo Bonzini wrote: > > > On 14/07/2015 17:45, Aurelien Jarno wrote: > > The LWL/LDL instructions mask the GPR with a mask depending on the > > address alignement. It is currently computed by doing: > > > > mask = 0x7fffull >> (t1 ^ 63) > > > > It's simpler

Re: [Qemu-devel] [PATCH 2/6] ARM: accessors to Cortex-M3/M4 exception configuration and status registers

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > hw/intc/armv7m_nvic.c | 70 > ++--- > 1 file changed, 61 insertions(+), 9 deletions(-) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c > index e13b729.

Re: [Qemu-devel] [PATCH 3/6] ARM: Cortex-M3/M4: honor STKALIGN in CCR

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > hw/intc/armv7m_nvic.c |2 +- > target-arm/helper.c |5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c > index e6ae047..369ef94 100

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Gabriel L. Somlo
On Mon, Jul 13, 2015 at 05:03:02PM -0600, Eric Blake wrote: > On 07/13/2015 02:09 PM, Gabriel L. Somlo wrote: > > 2. File names are listed in /sys/fs/fw_cfg/... with slashes replaced > >exclamation marks, e.g.: > > Instead of inventing yet another escaping mechanism, can you mimic an > already

Re: [Qemu-devel] [PATCH 1/6] ARM: add Cortex-M3/M4 exception configuration and status registers

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/cpu.h | 51 > ++ > target-arm/machine.c |6 ++ > 2 files changed, 57 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > i

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 17:38, Leon Alrae wrote: > There seems to be an issue when trying to keep a pointer in bottom 32-bits > of a 64-bit floating point register. Load and store instructions accessing > this address for some reason use the whole 64-bit content of floating point > register rather than trunc

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

2015-07-14 Thread Paolo Bonzini
On 14/07/2015 18:45, Aurelien Jarno wrote: >>> > > >>> > > mask = 0x7fffull >> (t1 ^ 63) >>> > > >>> > > It's simpler to generate it by doing: >>> > > >>> > > mask = (1 << t1) - 1 >> > >> > Using ~(-1 << t1) may let you use an ANDN instruction, and is also the >> > same nu

Re: [Qemu-devel] [PATCH 4/6] ARM: Cortex-M3/M4: on exception, set basic bits in exhandling registers

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/helper.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 812204f..555bc5f 100644 > --- a/target-arm/helper.c > +++ b/

[Qemu-devel] [PULL for-2.4 1/2] watchdog/diag288: correctly register for system reset requests

2015-07-14 Thread Cornelia Huck
From: Xu Wang The diag288 watchdog is no sysbus device, therefore it doesn't get triggered on resets automatically using dc->reset. Let's register the reset handler manually, so we get correctly notified again when a system reset was requested. Also reset the watchdog on subsystem resets that do

[Qemu-devel] [PULL for-2.4 2/2] s390/virtio-ccw: Fix migration

2015-07-14 Thread Cornelia Huck
From: Christian Borntraeger commit 213941d73b ("virtio-ccw: migrate ->revision") broke migration: 2015-07-07T11:22:55.570968Z qemu-system-s390x: VQ 39 address 0x0 inconsistent with Host index 0x100 2015-07-07T11:22:55.571008Z qemu-system-s390x: error while loading state for instance 0x0 of If

[Qemu-devel] [PULL for-2.4 0/2] Fixes for s390x

2015-07-14 Thread Cornelia Huck
The following changes since commit 0030ff40472b9ebf0e0595afbc8d7e428218c5d7: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150714-1' into staging (2015-07-14 14:52:45 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20150714

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-14 Thread Cornelia Huck
On Mon, 13 Jul 2015 18:35:53 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 15:36:00 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > > > On Mon, 13 Jul

Re: [Qemu-devel] [PATCH 6/6] ARM: enable PMSAv7-style MPU on Cortex-M3/M4

2015-07-14 Thread Peter Maydell
On 7 July 2015 at 19:25, Alex Zuepke wrote: A commit message that wasn't just the one-line summary would be nice. Sometimes a patch really is trivial enough that it's not worth describing in more than just a single line, but those situations are the exception rather than the rule. > Signed-off-b

Re: [Qemu-devel] [PULL 00/11] Block layer patches for 2.4.0-rc1

2015-07-14 Thread Peter Maydell
On 14 July 2015 at 16:39, Kevin Wolf wrote: > The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-07-13 13:35:51 +0100) > > are available in the git repository at: > > > git://repo.o

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Paolo Bonzini
On 14/07/2015 19:09, Aurelien Jarno wrote: > On 2015-07-14 17:38, Leon Alrae wrote: >> There seems to be an issue when trying to keep a pointer in bottom 32-bits >> of a 64-bit floating point register. Load and store instructions accessing >> this address for some reason use the whole 64-bit cont

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Gabriel L. Somlo
On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > 3. I'm currently only handling x86 and I/O ports. I could drop the > >fw_cfg_dmi_whitelist and just check the signature, using mmio where > >appropriat

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 20:20, Paolo Bonzini wrote: > > > On 14/07/2015 19:09, Aurelien Jarno wrote: > > On 2015-07-14 17:38, Leon Alrae wrote: > >> There seems to be an issue when trying to keep a pointer in bottom 32-bits > >> of a 64-bit floating point register. Load and store instructions accessing > >

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Gabriel L. Somlo
On Tue, Jul 14, 2015 at 02:23:14PM -0400, Gabriel L. Somlo wrote: > On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > > 3. I'm currently only handling x86 and I/O ports. I could drop the > > >fw_cfg_dmi_

Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-14 Thread Marcus
Looks like this is fixed in master. commit af957387547b05ed6dc4d84c10cca42700a7aeda Author: Zhang Haoyu Date: Mon Sep 29 16:38:02 2014 +0800 snapshot: fix referencing wrong variable in while loop in do_delvm The while loop variabal is "bs1", but "bs" is always passed to bdrv

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Richard W.M. Jones
On Tue, Jul 14, 2015 at 02:23:14PM -0400, Gabriel L. Somlo wrote: > On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > > 3. I'm currently only handling x86 and I/O ports. I could drop the > > >fw_cfg_dmi_

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Richard W.M. Jones
On Tue, Jul 14, 2015 at 07:48:29PM +0100, Richard W.M. Jones wrote: > On aarch64 kernel loading is really slow because it can only transfer > (IIRC) 8 bytes at a time, and there are no string instructions we can > use to speed it up. I should note here I'm talking about AAVMF (ie. guest UEFI) whic

Re: [Qemu-devel] [PULL for-2.4 0/2] Fixes for s390x

2015-07-14 Thread Peter Maydell
On 14 July 2015 at 18:26, Cornelia Huck wrote: > The following changes since commit 0030ff40472b9ebf0e0595afbc8d7e428218c5d7: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150714-1' into > staging (2015-07-14 14:52:45 +0100) > > are availa

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Peter Maydell
On 14 July 2015 at 19:48, Richard W.M. Jones wrote: > A long time ago I wrote a memcpy and a "pseudo-DMA" interface for > fw_cfg, but they were both roundly rejected as you can find in the > archives. IIRC opinions have changed on the pseudo-DMA approach since then; last time it was suggested I t

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Gerd Hoffmann
Hi, > > > /* read chunk of given fw_cfg blob (caller responsible for sanity-check) > > > */ > > > static inline void fw_cfg_read_blob(uint16_t select, > > >void *buf, loff_t pos, size_t count) > > > { > > > mutex_lock(&fw_cfg_dev_lock); > > > outw(select, FW_

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Gabriel L. Somlo
On Tue, Jul 14, 2015 at 07:48:30PM +0100, Richard W.M. Jones wrote: > > > > /* read chunk of given fw_cfg blob (caller responsible for > > > > sanity-check) */ > > > > static inline void fw_cfg_read_blob(uint16_t select, > > > > void *buf, loff_t pos, size_t >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-07-14 Thread Josh Durgin
On 07/14/2015 07:20 AM, Kevin Wolf wrote: Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: Ping On 06/10/2015 08:28 PM, Josh Durgin wrote: Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and c

Re: [Qemu-devel] [PATCH] gdbstub: Implement Xfer:auxv:read

2015-07-14 Thread Peter Maydell
On 1 July 2015 at 12:00, Bhushan Attarde wrote: > Implementation of "Xfer:auxv:read" to provide auxiliary vector information > to clients which relies on it. > > For example: AT_ENTRY in auxiliary vector provides the entry point > information. > Client can use this information to compare it with

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

2015-07-14 Thread Zavadovsky Yan
On Wed, Jul 1, 2015 at 9:00 PM, Stefan Weil wrote: > > Fabien, you suggested "extensive tests". Do you think that > patch v2 is fine, or are you still waiting for test results? On Mon, Jul 6, 2015 at 12:29 PM, Fabien Chouteau wrote: > That's good for me. > Ping... http://patchwork.ozlabs.org/

[Qemu-devel] [ARM SMBIOS RFC PATCH 3/5] smbios: pass ram size as a parameter to build smbios tables

2015-07-14 Thread Wei Huang
This patch adds a new parameter, mem_size, to smbios_get_tables() function. This step is required to make smbios code architect-independent. Signed-off-by: Wei Huang --- hw/i386/pc.c | 2 +- hw/i386/smbios.c | 8 include/hw/i386/smbios.h | 2 ++ 3 files changed, 7 in

[Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM

2015-07-14 Thread Wei Huang
SMBIOS tables present userful system hardware info to management applications, such as DMI tools. Even though SMBIOS was originally developed for Intel x86, it has been extended to both Itanium and ARM (32bit & 64bit). More and more ARM server releases, such as RHEL Server for ARM, start to integ

[Qemu-devel] [ARM SMBIOS RFC PATCH 2/5] smbios: remove dependency on x86 e820 tables

2015-07-14 Thread Wei Huang
Current smbios builds type 19 table from e820, which is x86 specific. This patch removes smbios' dependency on e820 by passing an array of memory area to smbios_get_tables(). Signed-off-by: Wei Huang --- hw/i386/pc.c | 18 +- hw/i386/smbios.c | 14 +++-

[Qemu-devel] [ARM SMBIOS RFC PATCH 1/5] smbios: extract x86 smbios building code into a function

2015-07-14 Thread Wei Huang
This patch extracts out the procedure of buidling x86 SMBIOS tables into a dedicated function. Signed-off-by: Wei Huang --- hw/i386/pc.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7661ea9..00e45f3

[Qemu-devel] [ARM SMBIOS RFC PATCH 5/5] smbios: implement smbios support for mach-virt

2015-07-14 Thread Wei Huang
This patch generates smbios tables for ARM mach-virt. Also add CONFIG_SMBIOS=y for ARM default config. Signed-off-by: Wei Huang --- default-configs/arm-softmmu.mak | 1 + hw/arm/virt.c| 24 include/hw/arm/virt-acpi-build.h | 1 + 3 files changed, 2

[Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder

2015-07-14 Thread Wei Huang
To share smbios among different architectures, this patch moves SMBIOS code (smbios.c and smbios.h) from x86 specific folders into new hw/smbios directories. As a result, CONFIG_SMBIOS=y is defined in x86 default config files. Signed-off-by: Wei Huang --- arch_init.c|

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

2015-07-14 Thread Stefan Weil
Am 14.07.2015 um 21:44 schrieb Zavadovsky Yan: On Wed, Jul 1, 2015 at 9:00 PM, Stefan Weil > wrote: Fabien, you suggested "extensive tests". Do you think that patch v2 is fine, or are you still waiting for test results? On Mon, Jul 6, 2015 at 12:29 PM, Fabien Ch

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

2015-07-14 Thread Zavadovsky Yan
On Tue, Jul 14, 2015 at 11:29 PM, Stefan Weil wrote: > I'll send a pull request for this patch after the release of QEMU 2.4. > Ok. Thanks.

Re: [Qemu-devel] [PATCH v2] ich9: initialise RCBA register through LPC interface

2015-07-14 Thread Paulo Alcantara
On Tue, 14 Jul 2015 15:55:24 +0200 Gerd Hoffmann wrote: > On Do, 2015-07-09 at 21:04 -0300, Paulo Alcantara wrote: > > This patch initialises root complex register block BAR in order to > > support TCO watchdog emulation features on QEMU. > > qemu patches are merged, committed this one too now.

Re: [Qemu-devel] [PATCH] linux-user: add signalfd/signalfd4 syscalls

2015-07-14 Thread Peter Maydell
On 29 May 2015 at 23:50, Laurent Vivier wrote: > This patch introduces a system very similar to the one used in the kernel > to attach specific functions to a given file descriptor. > > In this case, we attach a specific "read()" to the fd returned by > signalfd() to be able to byte-swap the signa

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Paolo Bonzini
On 14/07/2015 20:37, Aurelien Jarno wrote: >> > >> > I certainly don't have a global view, so much that I didn't think at >> > all of the optimizer... Instead, it looks to me like a bug in the >> > register allocator. In particular this code in tcg_reg_alloc_mov: > That's exactly my point whe

Re: [Qemu-devel] [PATCH] linux-user: add signalfd/signalfd4 syscalls

2015-07-14 Thread Laurent Vivier
Thank you for your comments. I'm currently writing a v2 of this patch with what I've learned working on the netlink interface. I will fix it accordingly all your comments. [ Now, I can boot a PPC64 container with systemd on an x86_64 host: https://asciinema.org/a/7sgwvok72m34v7hg08hfspg4s ] Laur

Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM

2015-07-14 Thread Laszlo Ersek
Cc'ing Ard. On 07/14/15 22:23, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM serv

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

2015-07-14 Thread Aurelien Jarno
On 2015-07-14 22:56, Paolo Bonzini wrote: > > > On 14/07/2015 20:37, Aurelien Jarno wrote: > >> > > >> > I certainly don't have a global view, so much that I didn't think at > >> > all of the optimizer... Instead, it looks to me like a bug in the > >> > register allocator. In particular this

Re: [Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-14 Thread Alex Williamson
On Tue, 2015-07-14 at 16:58 +1000, Alexey Kardashevskiy wrote: > On 07/14/2015 05:13 AM, Alex Williamson wrote: > > On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: > >> These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to > >> a real host page size: > >> 4e51361d7 "cpu-

[Qemu-devel] TLB, cpu_mmu_index() and load/store vs ifetch

2015-07-14 Thread Benjamin Herrenschmidt
Hi Paolo, Alex ! I was looking at the patches for speeding up ppc and was trying to figure out if we could do things better, and reduce the number of modes and flushes associated with them. While trying to understand it all, I found something that might be a problem: How we handle the fact that we

<    1   2   3   >