Re: [Qemu-devel] [PATCH v4 1/5] block: Use bdrv_is_sg() everywhere

2015-06-19 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 12:57:35PM +0300, Dimitris Aragiorgis wrote: > Instead of checking bs->sg use bdrv_is_sg() consistently throughout > the code. > > Signed-off-by: Dimitris Aragiorgis > Reviewed-by: Paolo Bonzini > --- > block.c |6 +++--- > block/iscsi.c |2 +- > bl

Re: [Qemu-devel] [PATCH v4 2/5] Fix migration in case of scsi-generic

2015-06-19 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 12:57:36PM +0300, Dimitris Aragiorgis wrote: > During migration, QEMU uses fsync()/fdatasync() on the open file > descriptor for read-write block devices to flush data just before > stopping the VM. > > However, fsync() on a scsi-generic device returns -EINVAL which > cause

Re: [Qemu-devel] [PATCH v4 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY

2015-06-19 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 12:57:38PM +0300, Dimitris Aragiorgis wrote: > Get rid of several #ifdef DEBUG_FLOPPY and substitute them with > DPRINTF. > > Signed-off-by: Dimitris Aragiorgis > --- > block/raw-posix.c | 22 +- > 1 file changed, 5 insertions(+), 17 deletions(-) Re

Re: [Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-06-19 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 12:57:37PM +0300, Dimitris Aragiorgis wrote: > Building the QEMU tools fails if we #define DEBUG_BLOCK inside > block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y > so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with > a simple DPRINTF() (th

Re: [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()

2015-06-19 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 12:57:39PM +0300, Dimitris Aragiorgis wrote: > This is very fragile, e.g. it fails with symlinks or relative paths. This is not true since realpath(3) is used to resolve symlinks and product an absolute path. Is this patch really necessary? pgphpPAmRu_eu.pgp Description:

Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Andreas Färber
Hi Markus, Could you please add a verbose rationale here like "qdev_init() does not propagate the Error* and should be replaced by ..."? Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > hw/core/qdev.c | 47 ++

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi-build: Add GICv2m description in ACPI MADT table

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 02:10, wrote: > From: Shannon Zhao > > Add GICv2m description in ACPI MADT table, so guest can use MSI when > booting with ACPI. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- This looks ok, but I would like a review or ack from somebody before I put it

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix table revision and some comments

2015-06-19 Thread Peter Maydell
On 9 June 2015 at 04:26, Shannon Zhao wrote: > From: Shannon Zhao > > The table revision is not the ACPI spec version. Fix the wrong revision > and also some comments. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletio

Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Andreas Färber
Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > It's a perfectly sensible helper function. But only in the current state. Once/if we just set realized=true on /machine level, then no other helper functions will need to set it, as pointed out in the following paragraph. > > Signed-off-by: Mar

Re: [Qemu-devel] [PATCH v2 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive()

2015-06-19 Thread Andreas Färber
Did you mean avalanche? Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Reproducer: > > $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device > virtio-rng-pci -device virtio-rng-device,bus=virtio-bus > qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus > 'vi

Re: [Qemu-devel] [PATCH v2 1/1] vvfat: add a label option

2015-06-19 Thread Eric Blake
On 06/19/2015 03:35 AM, Wolfgang Bumiller wrote: > Until now the vvfat volume label was hardcoded to be > "QEMU VVFAT", now you can pass a file.label=labelname option > to the -drive to change it. > > The FAT structure defines the volume label to be limited to > 11 bytes and is filled up spaces wh

Re: [Qemu-devel] [PATCH v2 6/7] qdev-monitor: Propagate errors through set_property()

2015-06-19 Thread Andreas Färber
Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > qdev-monitor.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Andreas Färber Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany

Re: [Qemu-devel] [PATCH v2 0/1] vvfat label option updated

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 11:35:28AM +0200, Wolfgang Bumiller wrote: > * Till/Until changed > * Added (since 2.4) to json file > * Added the 11-byte limit description. Without mentioning the trailing > spaces in the json file since the guest OS doesn't expose them to > the user. However, I mentio

Re: [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-19 Thread Laszlo Ersek
On 06/19/15 09:01, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> From: Laszlo Ersek >> >> It is Very annoying to carry forward an outdatEd coNtroller with a mOdern >> Machine type. >> >> Hence, let us not instantiate the FDC when all of the following apply: >> - the machine type i

Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote: Please CC the maintainer of this source file: $ scripts/get_maintainer.pl -f hw/block/nvme.c Keith Busch (supporter:nvme) Kevin Wolf (supporter:Block layer core) qemu-bl...@nongnu.org (open list:nvme) > From: Lu Lina > > Sign

Re: [Qemu-devel] [PATCH v2 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Andreas Färber
Am 13.06.2015 um 13:18 schrieb Markus Armbruster: > Also polish an error message while I'm touching the line anyway, > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > include/monitor/qdev.h | 2 +- > qdev-monitor.c | 36 +++- > vl.c

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-19 Thread Peter Lieven
Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: > On Thu, Jun 18, 2015 at 10:29 AM, Peter Lieven wrote: >> Am 18.06.2015 um 10:42 schrieb Kevin Wolf: >>> Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: > Am 18.06.2015 um 09:12 hat Peter Liev

Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Markus Armbruster
Andreas Färber writes: > Hi Markus, > > Could you please add a verbose rationale here like "qdev_init() does not > propagate the Error* and should be replaced by ..."? What about: qdev_init() is a wrapper around setting property "realized" to true plus error handling, which passes error

Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Markus Armbruster
Andreas Färber writes: > Am 13.06.2015 um 13:18 schrieb Markus Armbruster: >> It's a perfectly sensible helper function. > > But only in the current state. Once/if we just set realized=true on > /machine level, then no other helper functions will need to set it, as > pointed out in the following

Re: [Qemu-devel] [PATCH v2 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive()

2015-06-19 Thread Markus Armbruster
Andreas Färber writes: > Did you mean avalanche? Yes, fixing... > Am 13.06.2015 um 13:18 schrieb Markus Armbruster: >> Reproducer: >> >> $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device >> virtio-rng-pci -device virtio-rng-device,bus=virtio-bus >> qemu-system-x86_64: -d

Re: [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 02:52:16PM +0200, Laszlo Ersek wrote: > > Your merge is closer to a rewrite than to conflict resolution, rendering > > my R-by totally meaningless. > > > > In the future, please either fully test such a merge, or ask the > > submitter / reviewers to review and test. > > Ye

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: > >> On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: > >> > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote: > >> >

[Qemu-devel] [PATCH v2 0/3] m68k: fix ColdFire support

2015-06-19 Thread gerg
Some small issues are causing problems with running modern versions of Linux on the m68k/ColdFire 5208 target. These 3 patches fix those problems. They are all due to use of more advanced architecture features not used in older Linux kernels. Regards Greg v2: * rebased to current master head *

[Qemu-devel] [PATCH v2 2/3] m68k: implement move to/from usp register instruction

2015-06-19 Thread gerg
From: Greg Ungerer Fill out the code support for the move to/from usp instructions. They are being decoded, but there is no code to support there actions. So add it. Current versions of Linux running on the ColdFire 5208 use these instructions. Signed-off-by: Greg Ungerer Reviewed-by: Richard

[Qemu-devel] [PATCH v2 3/3] m68k: fix usp processing on interrupt entry and exception exit

2015-06-19 Thread gerg
From: Greg Ungerer The action to potentially switch sp register is not occurring at the correct point in the interrupt entry or exception exit sequences. For the interrupt entry case the sp on entry is used to create the stack exception frame - but this may well be the user stack pointer, since

[Qemu-devel] [PATCH v2 1/3] m68k: implement more ColdFire 5208 interrupt controller functionality

2015-06-19 Thread gerg
From: Greg Ungerer Implement the SIMR and CIMR registers of the 5208 interrupt controller. These are used by modern versions of Linux running on ColdFire (not sure of the exact version they were introduced, but they have been in for quite a while now). Without this change when attempting to run

[Qemu-devel] [PULL 00/12] target-arm queue

2015-06-19 Thread Peter Maydell
tle more review time. Other than that I think we should be down to bugfix patches. -- PMM The following changes since commit ffdb1409a79c9cc91afd9f58df625fdca16bf8b9: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20150619-1' into staging (2015-06-19 12:54:08 +0100)

[Qemu-devel] [PULL 10/12] arm: xlnx-zynqmp: Add 2xCortexR5 CPUs

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Add the 2xCortexR5 CPUs to zynqmp board. They are powered off on reset (this is true of real hardware) by default or selectable as the boot processor. Signed-off-by: Peter Crosthwaite Message-id: da34128c73ca13fc4f8c3293e1a33d1e1e345655.1434501320.git.peter.crosthwa...@

[Qemu-devel] [PULL 09/12] arm: xlnx-zynqmp: Add boot-cpu property

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Add a string property that specifies the primary boot cpu. All CPUs except the one selected will start-powered-off. This allows for elf boots on any CPU, which prepares support for booting R5 elfs directly on the R5 processors. Signed-off-by: Peter Crosthwaite Message-id

[Qemu-devel] [PULL 01/12] target-arm: Add the Cortex-M4 CPU

2015-06-19 Thread Peter Maydell
From: "Aurelio C. Remonda" This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. Only no-FPU cortex-M4 is implemented here, cortex-M4F is not because the core target-arm code doesn't support the M-profile F

[Qemu-devel] [PULL 08/12] arm: xlnx-zynqmp: Preface CPU variables with "apu"

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite The CPUs currently supported by zynqmp are the APU (application processing unit) CPUs. There are other CPUs in Zynqmp so unqualified "cpus" in ambiguous. Preface the variables with "APU" accordingly, to prepare support adding the RPU (realtime processing unit) processors.

[Qemu-devel] [PULL 04/12] target-arm/helper.c: define MPUIR register

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Define the MPUIR register for MPU supporting ARMv6 and onwards. Currently we only support unified MPU. The size of the unified MPU is defined via the number of "dregions". So just a single config is added to specify this size. (When split MPU is implemented we will add an

[Qemu-devel] [PULL 07/12] target-arm: Add support for Cortex-R5

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Introduce a CPU model for the Cortex R5 processor. ARMv7 with MPU, and both thumb and ARM div instructions. Also implement dummy ATCM and BTCM. These CPs are defined for R5 but don't have a lot of meaning in QEMU yet. Raz them so the guest can proceed if they are read. Th

[Qemu-devel] [PULL 11/12] semihosting: create SemihostingConfig structure and semihost.h

2015-06-19 Thread Peter Maydell
From: Leon Alrae Remove semihosting_enabled and semihosting_target and replace them with SemihostingConfig structure containing equivalent fields. The structure is defined in vl.c where it is actually set. Also introduce separate header file include/exec/semihost.h allowing to access semihosting

[Qemu-devel] [PULL 12/12] semihosting: add --semihosting-config arg sub-argument

2015-06-19 Thread Peter Maydell
From: Leon Alrae Add new "arg" sub-argument to the --semihosting-config allowing the user to pass multiple input arguments separately. It is required for example by UHI semihosting to construct argc and argv. Also, update ARM semihosting to support new option (at the moment it is the only target

Re: [Qemu-devel] [PATCH v2 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Markus Armbruster
Andreas Färber writes: > Am 13.06.2015 um 13:18 schrieb Markus Armbruster: >> Also polish an error message while I'm touching the line anyway, >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> include/monitor/qdev.h | 2 +- >> qdev-monitor.c | 36 +++

[Qemu-devel] [PULL 06/12] target-arm: Implement PMSAv7 MPU

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Unified MPU only. Uses ARM architecture major revision to switch between PMSAv5 and v7 when ARM_FEATURE_MPU is set. PMSA v6 remains unsupported and is asserted against. Reviewed-by: Peter Maydell Signed-off-by: Peter Crosthwaite Message-id: dcb03cda6dd754c5cc6a962fa11f

[Qemu-devel] [PULL 02/12] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-06-19 Thread Peter Maydell
From: Eric Auger This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=""). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts properties. Signed-off-by: Eric Aug

[Qemu-devel] [PULL 05/12] target-arm: Add registers for PMSAv7

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite Define the arm CP registers for PMSAv7 and their accessor functions. RGNR serves as a shared index that indexes into arrays storing the DRBAR, DRSR and DRACR registers. DRBAR and friends have to be VMSDd separately from the CP interface using a new PMSA specific VMSD subse

[Qemu-devel] [PULL 03/12] target-arm: Do not reset sysregs marked as ALIAS

2015-06-19 Thread Peter Maydell
From: Sergey Fedorov cp_reg_reset() is called from g_hash_table_foreach() which does not define a specific ordering of the hash table iteration. Thus doing reset for registers marked as ALIAS would give an ambiguous result when resetvalue is different for original and alias registers. Exit cp_reg

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: >> >> On 19 June 2015 at 11:07, Michael S. Tsirkin wrote: >> >> > On Fri, Jun 19, 2015 at 12:

Re: [Qemu-devel] [PATCH v3 3/8] qapi: change Netdev and NetLegacy into a flat union

2015-06-19 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 06:43:45PM +0200, Kővágó, Zoltán wrote: > @@ -713,8 +710,6 @@ int net_init_tap(const NetClientOptions *opts, const char > *name, > const char *vhostfdname; > char ifname[128]; > > -assert(opts->kind == NET_CLIENT_OPTIONS_KIND_TAP); > -tap = opts->tap; ..

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 04:00:05PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: > >> >> On 19 J

[Qemu-devel] [PATCH v3 3/7] qdev-monitor: Stop error avalanche in qbus_find_recursive()

2015-06-19 Thread Markus Armbruster
Reproducer: $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device virtio-rng-pci -device virtio-rng-device,bus=virtio-bus qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus 'virtio-bus' is full qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus

[Qemu-devel] [PATCH v3 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Markus Armbruster
Also polish an error message while I'm touching the line anyway, Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Andreas Färber --- include/monitor/qdev.h | 2 +- qdev-monitor.c | 36 +++- vl.c | 7 +-- 3 fil

[Qemu-devel] [PATCH v3 2/7] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Markus Armbruster
It's a perfectly sensible helper function. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/hw/qdev-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 5789b91..b736b03 100644 --- a/include/hw/q

[Qemu-devel] [PATCH v3 6/7] qdev-monitor: Propagate errors through set_property()

2015-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Andreas Färber --- qdev-monitor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 12d8f6b..c7b00e0 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -156,8 +15

[Qemu-devel] [PATCH v3 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Markus Armbruster
qdev_init() is a wrapper around setting property "realized" to true, plus error handling that passes errors to qerror_report_err(). qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. All code has been moderniz

[Qemu-devel] [PATCH v3 0/7] qdev: Mostly wean off QError

2015-06-19 Thread Markus Armbruster
Only the calls in do_device_add() remain, because QMP's command handler interface requires them. They'll go away when I wean QMP off QError. Bonus: a few error reporting improvements. Casualty: some explanatory messages, see PATCH 5. v3: * Trivially rebased, R-bys retained * PATCH 1: Add ration

[Qemu-devel] [PATCH v3 5/7] qdev-monitor: Convert qbus_find() to Error

2015-06-19 Thread Markus Armbruster
As usual, the conversion breaks printing explanatory messages after the error: actual printing of the error gets delayed, so the explanations precede rather than follow it. Pity. Disable them for now. See also commit 7216ae3. While there, eliminate QERR_BUS_NOT_FOUND, and clean up unusual spell

[Qemu-devel] [PATCH v3 4/7] qdev-monitor: Fix check for full bus

2015-06-19 Thread Markus Armbruster
Property bus has always been too screwed up to be really usable for values other than plain bus IDs. This just fixes a bug that crept in in commit 1395af6 "qdev: add a maximum device allowed field for the bus." It doesn't always fail when it should: $ qemu-system-x86_64 -nodefaults -device v

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
On Fri, 19 Jun 2015 16:06:04 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jun 19, 2015 at 04:00:05PM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: > > >> "Michael S. Tsirkin" writes: > > >> > > >> >

[Qemu-devel] [PATCH 5/8] hmp: added local apic dump state

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. For command name uses "apic-local" because it has to be grouped with command "apic-io". (qemu) info apic-local apic.lvt00-timer 000300fd i

[Qemu-devel] [PATCH 8/8] hmp: implemented io apic dump state for emulator

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info apic-io" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Luiz Capitulino --- hw/intc/ioapic.c | 12 include/hw/i386/pc.h | 1 + monitor.c| 2 ++ 3 files cha

[Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info apic-io ioapic ID=00 IRR= SEL=18 ioapic 00 000100ff: int=ff delmod=0:

Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp

2015-06-19 Thread Keith Busch
On Fri, 19 Jun 2015, Stefan Hajnoczi wrote: From: Lu Lina Signed-off-by: Lu Lina Thanks for the fix. Acked-by: Keith Busch @@ -154,6 +154,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len, qemu_sglist_destroy(&qsg); return NVME_INVALID_FIEL

[Qemu-devel] [PATCH 1/8] apic_internal.h: move apic_get_bit(), apic_set_bit() to apic_internal.h

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin It's necessary to work with bitmap isr, tmr, irr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini --- hw/intc/apic.c | 16 include/hw/i386/apic_internal.h | 16 2 files

Re: [Qemu-devel] [PATCH 0/8] hmp command IO- and Local APIC dump state

2015-06-19 Thread Eric Blake
On 06/19/2015 08:48 AM, Denis V. Lunev wrote: > Added the hmp command to query IO- and Local APIC registers state, > it can be very useful to identify problems related to the emulation devices. Will there ever be a desire to expose this via QMP, or is it really a debugging aid unlikely to be used

[Qemu-devel] [PATCH 0/8] hmp command IO- and Local APIC dump state

2015-06-19 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info apic-local apic.lvt00-timer 000300fd int=fd .H.EMP delmod=0:Fixed apic.lvt00-thermal 0001 int=00 .H.EM. delmod=0:Fixed apic.lvt

Re: [Qemu-devel] [PATCH v3 3/8] qapi: change Netdev and NetLegacy into a flat union

2015-06-19 Thread Kővágó Zoltán
2015-06-19 16:06 keltezéssel, Stefan Hajnoczi írta: On Thu, Jun 18, 2015 at 06:43:45PM +0200, Kővágó, Zoltán wrote: @@ -713,8 +710,6 @@ int net_init_tap(const NetClientOptions *opts, const char *name, const char *vhostfdname; char ifname[128]; -assert(opts->kind == NET_CLIENT_O

[Qemu-devel] [PATCH 4/8] apic_internal.h: Fix formatting and drop unused consts

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini --- include/hw/

[Qemu-devel] [PATCH 6/8] ioapic_internal.h: added more constants

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini --- include/hw/i386/ioapic_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/i386/ioapic_i

Re: [Qemu-devel] [PATCH 0/8] hmp command IO- and Local APIC dump state

2015-06-19 Thread Denis V. Lunev
On 19/06/15 17:56, Eric Blake wrote: On 06/19/2015 08:48 AM, Denis V. Lunev wrote: Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. Will there ever be a desire to expose this via QMP, or is it really

[Qemu-devel] [PATCH 3/8] apic_internal.h: added more constants

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin These constants are needed for optimal access to bit fields local apic registers without magic numbers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini --- include/hw/i386/apic_internal.h | 54 + 1 fil

[Qemu-devel] [PATCH 2/8] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-06-19 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini --- hw/intc/apic.c | 4 ++-- include/

Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method

2015-06-19 Thread Andreas Färber
Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange: > Now that properties can be explicitly registered as an enum > type, there is no need to pass the string table to the > object_get_enum method. The object property registration > already has a pointer to the string table. > > In changing this met

Re: [Qemu-devel] Greate difference of disk I/O performance for guest on Qemu-2.30 of CentOS.

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 08:40:11AM +0800, cauchy-love wrote: > > the iozone command line is: > ./iozone -i 0 -i 1 -f ./iotmp -Rab ./iotmp.xls -g 8G -n 4G -c > > The problem is why the performance difference is so big for different linux > kernels. The guest's io performance test is by both FTP

Re: [Qemu-devel] [PULL 00/15] Timer, virtio-scsi-test, build, memory changes for 2015-06-19

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 11:19, Peter Maydell wrote: > On 19 June 2015 at 08:45, Paolo Bonzini wrote: >> The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' >> into staging (2015-06-16 10:35:43 +010

Re: [Qemu-devel] [PATCH 5/8] hmp: added local apic dump state

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: > From: Pavel Butsykin > > Added the hmp command to query local apic registers state, may be > usefull after guest crashes to understand IRQ routing in guest. > > For command name uses "apic-local" because it has to be grouped with > command "apic-i

Re: [Qemu-devel] [PATCH] q35: Re-enable FDC on pc-q35-2.3 and older

2015-06-19 Thread Eduardo Habkost
On Fri, Jun 19, 2015 at 08:43:29AM +0200, Markus Armbruster wrote: > Laszlo Ersek writes: > > > On 06/18/15 18:49, Eduardo Habkost wrote: > >> commit ea96bc629cbd52be98b2967a4b4f72e91dfc3ee4 doesn't match the patch > >> submitted by Laszlo to qemu-devel. We reuse pc_q35_2_4_machine_options() > >>

Re: [Qemu-devel] [PATCH v2] target-i386: emulate CPUID level of real hardware

2015-06-19 Thread Eduardo Habkost
On Fri, Jun 19, 2015 at 01:20:40PM +0200, Radim Krčmář wrote: [...] > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index e142f75649d8..c335e230277b 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -307,6 +307,24 @@ static void pc_init1(MachineState *machine) > static void pc

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: > From: Pavel Butsykin > > Added the hmp command to query io apic state, may be usefull after guest > crashes to understand IRQ routing in guest. > > Implementation is only for kvm here. The dump will look like > (qemu) info apic-io > ioapic ID=00 I

Re: [Qemu-devel] QEMU ARM SMP: IPI delivery delayed until next main loop event // how to improve IPI latency?

2015-06-19 Thread Peter Maydell
On 16 June 2015 at 12:53, Peter Maydell wrote: > In particular I think the > 'do cpu_exit if one CPU triggers an interrupt on another' > approach is probably good, but I need to investigate why > it isn't working on your test programs without that extra > 'level &&' condition first... I've figure

Re: [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors

2015-06-19 Thread Eric Blake
On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: > It is reasonably common to want to create an object, set a > number of properties, register it in the hierarchy and then > mark it as complete (if a user creatable type). This requires > quite a lot of error prone, verbose, boilerplate code to ach

Re: [Qemu-devel] [PATCH v5 6/8] qom: make enum string tables const-correct

2015-06-19 Thread Eric Blake
On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: > The enum string table parameters in various QOM/QAPI methods > are declared 'const char *strings[]'. This results in const > warnings if passed a variable that was declared as > >static const char * const strings[] = { }; Not sure if th

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 15:48, Denis V. Lunev wrote: > From: Pavel Butsykin > > Added the hmp command to query io apic state, may be usefull after guest > crashes to understand IRQ routing in guest. > > Implementation is only for kvm here. The dump will look like > (qemu) info apic-io > ioapic ID=00 I

Re: [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 18:04 schrieb Eric Blake: > On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >> It is reasonably common to want to create an object, set a >> number of properties, register it in the hierarchy and then >> mark it as complete (if a user creatable type). This requires >> quite a lot

Re: [Qemu-devel] [PATCH v5 7/8] qom: add a object_property_add_enum helper method

2015-06-19 Thread Eric Blake
On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: > A QOM property can be parsed as enum using the visit_type_enum() > helper method, but this forces callers to use the more complex > generic object_property_add() method when registering it. It > also requires that users of that object have access

Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method

2015-06-19 Thread Eric Blake
On 06/19/2015 09:15 AM, Andreas Färber wrote: > Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange: >> Now that properties can be explicitly registered as an enum >> type, there is no need to pass the string table to the >> object_get_enum method. The object property registration >> already has a po

Re: [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors

2015-06-19 Thread Eric Blake
On 06/19/2015 10:08 AM, Andreas Färber wrote: > Am 19.06.2015 um 18:04 schrieb Eric Blake: >> On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >>> It is reasonably common to want to create an object, set a >>> number of properties, register it in the hierarchy and then >>> mark it as complete (if

[Qemu-devel] [PULL v2 00/15] Timer, virtio-scsi-test, build, memory changes for 2015-06-19

2015-06-19 Thread Paolo Bonzini
The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' into staging (2015-06-16 10:35:43 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you t

[Qemu-devel] [PULL 11/15] tests: virtio-scsi: Add test for unaligned WRITE SAME

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng This is an exercise for virtio-scsi tests using the libqos virtio library. A few common routines are added to facilitate future extensions of the test set. The added test case is a regression test for the bug in d7f4b1999e. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 04/15] target-mips: refactor {D}LSA, {D}ALIGN, {D}BITSWAP

2015-06-19 Thread Yongbok Kim
Refactor those instructions in order to reuse them for microMIPS32 Release 6. Rearrange gen_move_low32(). Signed-off-by: Yongbok Kim --- target-mips/translate.c | 166 --- 1 files changed, 99 insertions(+), 67 deletions(-) diff --git a/target-mips/tr

[Qemu-devel] [PATCH v2 07/15] target-mips: signal RI for removed instructions in microMIPS R6

2015-06-19 Thread Yongbok Kim
Signal a Reserved Instruction exception for removed instruction encoding in microMIPS Release 6. Signed-off-by: Yongbok Kim --- target-mips/translate.c | 68 +++ 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c

[Qemu-devel] [PATCH v2 01/15] target-mips: fix {RD, WR}PGPR in microMIPS

2015-06-19 Thread Yongbok Kim
rt, rs were swapped Signed-off-by: Yongbok Kim Reviewed-by: Aurelien Jarno Reviewed-by: Leon Alrae --- target-mips/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 1d128ee..97b74ba 100644 --- a/targe

[Qemu-devel] [PATCH v2 02/15] target-mips: add microMIPS TLBINV, TLBINVF

2015-06-19 Thread Yongbok Kim
add microMIPS TLBINV, TLBINVF Signed-off-by: Yongbok Kim Reviewed-by: Aurelien Jarno Reviewed-by: Leon Alrae --- target-mips/translate.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 97b74ba..963ff8b 1006

[Qemu-devel] [PATCH v2 00/15] target-mips: add microMIPS32 R6 Instruction Set support

2015-06-19 Thread Yongbok Kim
The patchset implements the latest microMIPS32 Release 6 Instruction Set. However LLX, LLXE, SCX and SCXE aren't included in the patchset. For more information, microMIPS R6 Instruction Set document is available: MIPS Architecture for Programmers Volume II-B: microMIPS32 Instruction Set Revision 6

[Qemu-devel] [PATCH v2 03/15] target-mips: remove an unused argument

2015-06-19 Thread Yongbok Kim
remove an unused argument from decode_micromips32_opc() Signed-off-by: Yongbok Kim --- target-mips/translate.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 963ff8b..83dfb2f 100644 --- a/target-mips/translate.

[Qemu-devel] [PATCH v2 08/15] target-mips: add microMIPS32 R6 opcode enum

2015-06-19 Thread Yongbok Kim
add microMIPS32 Release 6 opcode enum remove RI checking for pre-R6 reserved opcode. Signed-off-by: Yongbok Kim --- target-mips/translate.c | 119 -- 1 files changed, 103 insertions(+), 16 deletions(-) diff --git a/target-mips/translate.c b/target-mi

[Qemu-devel] [PATCH v2 14/15] target-mips: microMIPS32 R6 POOL16{A, C} instructions

2015-06-19 Thread Yongbok Kim
microMIPS32 Release 6 POOL16A/ POOL16C instructions Signed-off-by: Yongbok Kim --- target-mips/translate.c | 107 ++- 1 files changed, 105 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 9483d31..658

[Qemu-devel] [PATCH v2 05/15] target-mips: rearrange gen_compute_compact_branch

2015-06-19 Thread Yongbok Kim
The function will be also used for microMIPS Release 6. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae --- target-mips/translate.c | 472 +++--- 1 files changed, 236 insertions(+), 236 deletions(-) diff --git a/target-mips/translate.c b/target-mips/

Re: [Qemu-devel] [PATCH v5 7/8] qom: add a object_property_add_enum helper method

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 18:12 schrieb Eric Blake: > On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: >> A QOM property can be parsed as enum using the visit_type_enum() >> helper method, but this forces callers to use the more complex >> generic object_property_add() method when registering it. It >> als

[Qemu-devel] [PATCH v2 15/15] target-mips: add mips32r6-generic CPU definition

2015-06-19 Thread Yongbok Kim
Define a new CPU definition supporting MIPS32 Release 6 ISA and microMIPS32 Release 6 ISA. Signed-off-by: Yongbok Kim --- target-mips/translate_init.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/target-mips/translate_init.c b/targ

[Qemu-devel] [PATCH v2 10/15] target-mips: microMIPS32 R6 POOL32A{XF} instructions

2015-06-19 Thread Yongbok Kim
add new microMIPS32 Release 6 pool32a/pool32axf instructions. Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae --- target-mips/translate.c | 80 -- 1 files changed, 69 insertions(+), 11 deletions(-) diff --git a/target-mips/translate.c b/target-m

[Qemu-devel] [PATCH v2 06/15] target-mips: raise RI exceptions when FIR.PS = 0

2015-06-19 Thread Yongbok Kim
64-bit paired-single (PS) floating point data type could not be implemented in the pre-Release 6. It has to raise RI exception when PS type is not implemented. (FIR.PS = 0) (The PS data type is removed in the Release 6.) Signed-off-by: Yongbok Kim --- target-mips/translate.c | 77 +

[Qemu-devel] [PATCH v2 11/15] target-mips: microMIPS32 R6 POOL32F instructions

2015-06-19 Thread Yongbok Kim
add new microMIPS32 Release 6 POOL32F instructions Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae --- target-mips/translate.c | 231 --- 1 files changed, 199 insertions(+), 32 deletions(-) diff --git a/target-mips/translate.c b/target-mips/trans

[Qemu-devel] [PATCH v2 13/15] target-mips: microMIPS32 R6 Major instructions

2015-06-19 Thread Yongbok Kim
add new microMIPS32 Release 6 Major opcode instructions Signed-off-by: Yongbok Kim --- target-mips/translate.c | 62 ++- 1 files changed, 45 insertions(+), 17 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 54c14b6.

[Qemu-devel] [PATCH v2 12/15] target-mips: microMIPS32 R6 POOL32{I, C} instructions

2015-06-19 Thread Yongbok Kim
add new microMIPS32 Release 6 POOL32I/POOL32C type instructions Signed-off-by: Yongbok Kim --- target-mips/translate.c | 31 +-- 1 files changed, 25 insertions(+), 6 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 5f6ae43..54c14b6

[Qemu-devel] [PATCH v2 09/15] target-mips: microMIPS32 R6 branches and jumps

2015-06-19 Thread Yongbok Kim
add new microMIPS32 Release 6 branch and jump instructions. Signed-off-by: Yongbok Kim --- target-mips/translate.c | 242 +++ 1 files changed, 202 insertions(+), 40 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 3dc

Re: [Qemu-devel] [PATCH v5 7/8] qom: add a object_property_add_enum helper method

2015-06-19 Thread Eric Blake
On 05/27/2015 09:07 AM, Daniel P. Berrange wrote: > A QOM property can be parsed as enum using the visit_type_enum() > helper method, but this forces callers to use the more complex > generic object_property_add() method when registering it. It > also requires that users of that object have access

<    1   2   3   4   >