Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven geschrieben: Thread 2 (Thread 0x75550700 (LWP 2636)): #0 0x75d87aa3 in ppoll () from /lib/x86_64-linux

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values

2015-06-18 Thread Gerd Hoffmann
On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote: > For the same reason there is the v >= l test. > The v >= l test state that the value can be out of range so it not always a > constant in the range. > Adding the v < 0 check for every invalid value. As these are executed only > for loggin

Re: [Qemu-devel] How to trigger faults for missing peripherals?

2015-06-18 Thread Peter Maydell
On 18 June 2015 at 10:45, Liviu Ionescu wrote: > In order to make the Cortex-M emulation accurate, I would need to configure > the missing address ranges to trigger memory faults. > > I noticed that the emulator defines a memory range to > cover the entire 64-bits memory space. Is it possible > t

Re: [Qemu-devel] [PATCH] vfio: fix build error on CentOS 5.7

2015-06-18 Thread Peter Maydell
On 17 June 2015 at 15:47, Alex Williamson wrote: > On Wed, 2015-06-17 at 13:35 +0100, Leon Alrae wrote: >> Include linux/vfio.h after sys/ioctl.h, just like in hw/vfio/common.c. >> >> Signed-off-by: Leon Alrae > > Thanks for the patch. Peter, if you want to pop this in as a build fix, > I'd wel

Re: [Qemu-devel] [PATCH 06/11] migration: Add configuration section

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It needs to be the first one and it is not optional, that is the reason > why it is opencoded. For new machine types, it is required than machine > type name is the same in both sides. > > It is just done right now for pc's. Reviewed-by: Dr. David A

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Shannon Zhao
On 2015/6/17 17:42, Andrew Jones wrote: > On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: >> >> >> On 2015/6/16 22:19, Michael S. Tsirkin wrote: >>> On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: On 2015/6/16 2:13, Michael S. Tsirkin wrote: > On Mon

Re: [Qemu-devel] [RFC v9 14/18] vfio: improve vfio_pci_hot_reset to support more case

2015-06-18 Thread Chen Fan
On 06/17/2015 11:23 PM, Alex Williamson wrote: On Wed, 2015-06-17 at 14:28 +0800, Chen Fan wrote: On 06/16/2015 10:08 PM, Alex Williamson wrote: On Tue, 2015-06-16 at 16:10 +0800, Chen Fan wrote: On 06/10/2015 05:24 AM, Alex Williamson wrote: On Tue, 2015-06-09 at 11:37 +0800, Chen Fan wrote

Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store irq array

2015-06-18 Thread Shannon Zhao
On 2015/6/17 15:30, Michael Tokarev wrote: > 17.06.2015 05:59, Shannon Zhao wrote: >> From: Shannon Zhao >> >> These are relevant to memory leak in machine init function. Here we add >> a member in MachineState to store irq array returned from >> qemu_allocate_irqs. >> >> PS. These patches are s

Re: [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > cmpxchg returns the old value > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Nice spot. > --- > migration/migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migrati

Re: [Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:06PM +0800, Wen Congyang wrote: > +== Failure Handling == > +There are 6 internal errors when block replication is running: > +1. I/O error on primary disk > +2. Forwarding primay write requests failed s/primay/primary/ > +3. Bacup failed or writing to secondary disk

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-18 Thread Peter Maydell
On 17 June 2015 at 20:38, Michael S. Tsirkin wrote: > OK things seem to be calming down nicely. > Here's to an uneventful 2.4! > > The following changes since commit 4ebc736e9938a7e88ecc785734b17145bf802a56: > > i386/acpi-build: fix PXB workarounds for unsupported BIOSes (2015-06-11 > 12:40:30

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:08PM +0800, Wen Congyang wrote: > When opening BDS, we need to create backup jobs for > image-fleecing. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Jeff Cody > --- > block/Makefile.objs | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values

2015-06-18 Thread Frediano Ziglio
> On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote: > > For the same reason there is the v >= l test. > > The v >= l test state that the value can be out of range so it not always a > > constant in the range. > > Adding the v < 0 check for every invalid value. As these are executed only >

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Kevin Wolf
Am 16.06.2015 um 10:51 hat Alberto Garcia geschrieben: > Ping... > > https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02580.html I believe our conclusion from an earlier version of the series was that we need QAPI introspection so that libvirt can detect the presence of the feature. Mark

Re: [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state()

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We now use the helper everywhere, so no need to call this on this two > places. See on previous commit that there were a place where we missed > to mark the trace. Now all tracing is done in migrate_set_state(). Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description

2015-06-18 Thread Wen Congyang
On 06/18/2015 06:34 PM, Stefan Hajnoczi wrote: > On Thu, Jun 18, 2015 at 04:49:06PM +0800, Wen Congyang wrote: >> +== Failure Handling == >> +There are 6 internal errors when block replication is running: >> +1. I/O error on primary disk >> +2. Forwarding primay write requests failed > > s/primay/

Re: [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > There were three places that were not using the migrate_set_state() > helper, just fix that. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/migration/mig

Re: [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_reference" option to reference existing BDS

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:09PM +0800, Wen Congyang wrote: > Usage: > -drive file=xxx,id=Y, \ > -drive > file=,id=X,backing_reference.drive_id=Y,backing_reference.hidden-disk.* > > It will create such backing chain: >{virtio-blk dev 'Y'}

Re: [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We reuse the migration events from the source side, sending them on the > appropiate place. > > Signed-off-by: Juan Quintela > Reviewed-by: Eric Blake > --- > migration/migration.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > di

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2015-06-18 Thread Peter Maydell
On 17 June 2015 at 22:51, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the updated OpenBIOS binaries for 2.4 (apologies the request is a > little late because of the git mirror confusion). Please pull. > > > ATB, > > Mark. > > > The following changes since commit f754c3c9cce3c4789733d9068394be

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Andrew Jones
On Thu, Jun 18, 2015 at 06:28:36PM +0800, Shannon Zhao wrote: > > > On 2015/6/17 17:42, Andrew Jones wrote: > > On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/6/16 22:19, Michael S. Tsirkin wrote: > >>> On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao w

Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic

2015-06-18 Thread Dimitris Aragiorgis
Hi, did you have the time to take a look at this? Is there anything pending from my side? Thanks, dimara * Dimitris Aragiorgis [2015-05-29 08:15:34 +0300]: > Hi, > > * Dimitris Aragiorgis [2015-05-20 12:57:34 +0300]: > > > Hi all, > > > > These four patches make slight changes to the way Q

Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough

2015-06-18 Thread Peter Maydell
On 18 June 2015 at 10:39, Michael S. Tsirkin wrote: > On Thu, Jun 18, 2015 at 11:33:55AM +0200, Gerd Hoffmann wrote: >> +static Property virtio_input_host_pci_properties[] = { >> +DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputPCI, vdev.input), >> +DEFINE_PROP_STRING("evdev", VirtIOInputHostPCI

Re: [Qemu-devel] [PULL 1/1] virtio-input: evdev passthrough

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 12:11:47PM +0100, Peter Maydell wrote: > On 18 June 2015 at 10:39, Michael S. Tsirkin wrote: > > On Thu, Jun 18, 2015 at 11:33:55AM +0200, Gerd Hoffmann wrote: > >> +static Property virtio_input_host_pci_properties[] = { > >> +DEFINE_VIRTIO_INPUT_PROPERTIES(VirtIOInputP

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 11:36:26AM +0100, Peter Maydell wrote: > On 17 June 2015 at 20:38, Michael S. Tsirkin wrote: > > OK things seem to be calming down nicely. > > Here's to an uneventful 2.4! > > > > The following changes since commit 4ebc736e9938a7e88ecc785734b17145bf802a56: > > > > i386/ac

[Qemu-devel] [PATCH v8 1/3] spapr_pci: enumerate and add PCI device tree

2015-06-18 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [PATCH v8 0/3] spapr_pci: PCI DT node creation in QEMU

2015-06-18 Thread Nikunj A Dadhania
The patch series creates PCI device tree(DT) nodes in QEMU. The new hotplug code needs the device node creation in QEMU. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. New slof.bin is already there in spapr-next

[Qemu-devel] [PATCH v8 2/3] spapr_pci: populate ibm,loc-code

2015-06-18 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to ident

[Qemu-devel] [PATCH v8 3/3] spapr_pci: drop redundant args in spapr_[populate, create]_pci_child_dt

2015-06-18 Thread Nikunj A Dadhania
* phb_index is not being used and if required can be obtained from sphb * use helper to get drc_index in spapr_populate_pci_child_dt() * Check if drc_index is zero Suggested-by: Alexey Kardashevskiy Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 27 +++ 1 file

Re: [Qemu-devel] [PATCH qemu v7 13/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-06-18 Thread Alexey Kardashevskiy
On 05/05/2015 10:49 PM, David Gibson wrote: On Sat, Apr 25, 2015 at 10:24:43PM +1000, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) This implements DDW for emulated and VFIO dev

Re: [Qemu-devel] [PATCH 04/11] global_state: Make section optional

2015-06-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This section would be sent: > > a- for all new machine types > b- for old achine types if section state is different form {running,paused} >that were the only giving us troubles. > > So, in new qemus: it is alwasy there. In old qemus: they are o

Re: [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_reference" option to reference existing BDS

2015-06-18 Thread Wen Congyang
On 06/18/2015 06:50 PM, Stefan Hajnoczi wrote: > On Thu, Jun 18, 2015 at 04:49:09PM +0800, Wen Congyang wrote: >> Usage: >> -drive file=xxx,id=Y, \ >> -drive >> file=,id=X,backing_reference.drive_id=Y,backing_reference.hidden-disk.* >> >> It will create such backing chain: >>{v

[Qemu-devel] [PATCH qemu v8 03/14] spapr_pci_vfio: Enable multiple groups per container

2015-06-18 Thread Alexey Kardashevskiy
This enables multiple IOMMU groups in one VFIO container which means that multiple devices from different groups can share the same IOMMU table (or tables if DDW). This removes a group id from vfio_container_ioctl(). The kernel support is required for this; if the host kernel does not have the sup

[Qemu-devel] [PATCH qemu v8 04/14] spapr_pci: Convert finish_realize() to dma_capabilities_update()+dma_init_window()

2015-06-18 Thread Alexey Kardashevskiy
This reworks finish_realize() which used to finalize DMA setup with an assumption that it will not change later. New callbacks supports various window parameters such as page and windows sizes. The new callback return error code rather than Error**. This is a mechanical change so no change in beh

[Qemu-devel] [PATCH qemu v8 13/14] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-06-18 Thread Alexey Kardashevskiy
This makes use of the new "memory registering" feature. The idea is to provide the userspace ability to notify the host kernel about pages which are going to be used for DMA. Having this information, the host kernel can pin them all once per user process, do locked pages accounting (once) and not s

[Qemu-devel] [PATCH qemu v8 14/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-06-18 Thread Alexey Kardashevskiy
This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) This implements DDW for emulated and VFIO devices. As all TCE root regions are mapped at 0 and 64bit long (and actual tables are child regions), this replaces mem

[Qemu-devel] [PATCH qemu v8 05/14] spapr_iommu: Move table allocation to helpers

2015-06-18 Thread Alexey Kardashevskiy
At the moment presence of vfio-pci devices on a bus affect the way the guest view table is allocated. If there is no vfio-pci on a PHB and the host kernel supports KVM acceleration of H_PUT_TCE, a table is allocated in KVM. However, if there is vfio-pci and we do yet not KVM acceleration for these,

[Qemu-devel] [PATCH qemu v8 11/14] spapr_pci: Enable vfio-pci hotplug

2015-06-18 Thread Alexey Kardashevskiy
sPAPR IOMMU is managing two copies of an TCE table: 1) a guest view of the table - this is what emulated devices use and this is where H_GET_TCE reads from; 2) a hardware TCE table - only present if there is at least one vfio-pci device on a PHB; it is updated via a memory listener on a PHB address

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Alberto Garcia
On Thu 18 Jun 2015 12:45:35 PM CEST, Kevin Wolf wrote: > I believe our conclusion from an earlier version of the series was > that we need QAPI introspection so that libvirt can detect the > presence of the feature. The initial version of this series had an extra 'top' parameter to decide what im

[Qemu-devel] [PATCH qemu v8 01/14] vmstate: Define VARRAY with VMS_ALLOC

2015-06-18 Thread Alexey Kardashevskiy
This allows dynamic allocation for migrating arrays. Already existing VMSTATE_VARRAY_UINT32 requires an array to be pre-allocated, however there are cases when the size is not known in advance and there is no real need to enforce it. This defines another variant of VMSTATE_VARRAY_UINT32 with WMS_

[Qemu-devel] [PATCH qemu v8 10/14] spapr_vfio_pci: Remove redundant spapr-pci-vfio-host-bridge

2015-06-18 Thread Alexey Kardashevskiy
sPAPRTCETable is handling 2 TCE tables already: 1) guest view of the TCE table - emulated devices use only this table; 2) hardware IOMMU table - VFIO PCI devices use it for actual work but it does not replace 1) and it is not visible to the guest. The initialization of this table is driven by vfi

[Qemu-devel] [PATCH qemu v8 08/14] spapr_iommu: Add root memory region

2015-06-18 Thread Alexey Kardashevskiy
We are going to have multiple DMA windows at different offsets on a PCI bus. For the sake of migration, we will have as many TCE table objects pre-created as many windows supported. So we need a way to map windows dynamically onto a PCI bus when migration of a table is completed but at this stage a

[Qemu-devel] [PATCH qemu v8 02/14] vfio: spapr: Move SPAPR-related code to a separate file

2015-06-18 Thread Alexey Kardashevskiy
This moves SPAPR bits to a separate file to avoid pollution of x86 code. This enables spapr-vfio on CONFIG_SOFTMMU (not CONFIG_PSERIES) as the config options are only visible in makefiles and not in the source code so there is no an obvious way of implementing stubs if hw/vfio/spapr.c is not compi

[Qemu-devel] [PATCH qemu v8 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW)

2015-06-18 Thread Alexey Kardashevskiy
(cut-n-paste from kernel patchset) Each Partitionable Endpoint (IOMMU group) has an address range on a PCI bus where devices are allowed to do DMA. These ranges are called DMA windows. By default, there is a single DMA window, 1 or 2GB big, mapped at zero on a PCI bus. PAPR defines a DDW RTAS AP

[Qemu-devel] [PATCH qemu v8 12/14] linux headers update for DDW on SPAPR

2015-06-18 Thread Alexey Kardashevskiy
Since the changes are not in upstream yet, no tag or branch is specified here. Signed-off-by: Alexey Kardashevskiy --- linux-headers/linux/vfio.h | 88 -- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/linux-headers/linux/vfio.h b/linux

[Qemu-devel] [PATCH qemu v8 06/14] spapr_iommu: Introduce "enabled" state for TCE table

2015-06-18 Thread Alexey Kardashevskiy
Currently TCE tables are created once at start and their size never changes. We are going to change that by introducing a Dynamic DMA windows support where DMA configuration may change during the guest execution. This changes spapr_tce_new_table() to create an empty stub object. Only LIOBN is assi

[Qemu-devel] [PATCH qemu v8 09/14] spapr_pci: Do complete reset of DMA config when resetting PHB

2015-06-18 Thread Alexey Kardashevskiy
On a system reset, DMA configuration has to reset too. At the moment it clears the table content. This is enough for the single table case but with DDW, we will also have to disable all DMA windows except the default one. Furthermore according to sPAPR, if the guest removed the default window and c

[Qemu-devel] [PATCH qemu v8 07/14] spapr_iommu: Remove vfio_accel flag from sPAPRTCETable

2015-06-18 Thread Alexey Kardashevskiy
sPAPRTCETable has a vfio_accel flag which is passed to kvmppc_create_spapr_tce() and controls whether to create a guest view table in KVM as this depends on the host kernel ability to accelerate H_PUT_TCE for VFIO devices. We would set this flag at the moment when sPAPRTCETable is created in spapr_

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Kevin Wolf
Am 18.06.2015 um 13:41 hat Alberto Garcia geschrieben: > On Thu 18 Jun 2015 12:45:35 PM CEST, Kevin Wolf wrote: > > > I believe our conclusion from an earlier version of the series was > > that we need QAPI introspection so that libvirt can detect the > > presence of the feature. > > The initial

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-18 Thread Shannon Zhao
On 2015/6/18 19:03, Andrew Jones wrote: > On Thu, Jun 18, 2015 at 06:28:36PM +0800, Shannon Zhao wrote: >> >> >> On 2015/6/17 17:42, Andrew Jones wrote: >>> On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: On 2015/6/16 22:19, Michael S. Tsirkin wrote: > On Tue, Jun

Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"

2015-06-18 Thread Markus Armbruster
Falling back to qemu-trivial, hope that's okay. Markus Armbruster writes: > Ping? > > Markus Armbruster writes: > >> Since we now require GLib 2.22+ (commit f40685c), we don't have to >> work around lack of g_strcmp0() anymore. >> >> This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Alberto Garcia
On Thu 18 Jun 2015 01:47:20 PM CEST, Kevin Wolf wrote: >> > I believe our conclusion from an earlier version of the series was >> > that we need QAPI introspection so that libvirt can detect the >> > presence of the feature. >> >> The initial version of this series had an extra 'top' parameter to

Re: [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side

2015-06-18 Thread Eric Blake
On 06/18/2015 04:53 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We reuse the migration events from the source side, sending them on the >> appropiate place. s/appropiate/appropriate/ >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Eric Blake >> --- >>

[Qemu-devel] [PULL 13/15] qapi-types: Drop unused members parameters

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-types.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 86e5ddc..c408542 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.p

[Qemu-devel] [PULL 01/15] MAINTAINERS: Fix up QAPI and QAPI schema file patterns

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32c7ca4..0f801e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -952,7 +952,10 @@ M: Markus Armbruster M: Michael Roth S: Supported

[Qemu-devel] [PULL 05/15] qapi: Fix file name in error messages for included files

2015-06-18 Thread Markus Armbruster
We print the name as it appears in the include expression. Tools processing error messages want it relative to the working directory. Make it so. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 7 +++ tests/qapi-schema/include-cycle.e

[Qemu-devel] [PULL 02/15] qapi: Drop bogus command from docs

2015-06-18 Thread Markus Armbruster
Commit 87a560c4 added it in the wrong place. Commit 59a2c4ce added it in the right place, but didn't remove it from the wrong place. Do that now. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/qapi-

[Qemu-devel] [PULL 11/15] qapi: Catch and reject flat union branch of array type

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 2 +- tests/qapi-schema/flat-union-array-branch.err | 11 +-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 8f23267..06d

[Qemu-devel] [PULL 08/15] qapi: Move exprs checking from parse_schema() to check_exprs()

2015-06-18 Thread Markus Armbruster
To have expression semantic analysis in one place rather than two. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 142 ++-- 1 file changed, 66 insertions(+), 76 deletions(-) diff --git a/scripts/qapi.py b/scrip

[Qemu-devel] [PULL 03/15] qapi: Eliminate superfluous QAPISchema attribute input_dir

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index f96a777..683669e 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -109,7 +109,6 @@ class QAPISchema:

[Qemu-devel] [PULL 00/15] QAPI patches

2015-06-18 Thread Markus Armbruster
The following changes since commit 1b58f5a7f6fbe811cc486cd5786483bad5d51bbf: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging (2015-06-18 11:36:42 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-06-18

[Qemu-devel] [PULL 04/15] qapi: Improve a couple of confusing variable names

2015-06-18 Thread Markus Armbruster
old name new name input_filefname input_relname fname input_fname abs_fname include_path incl_abs_fname parent_info incl_info Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 45 +++-

[Qemu-devel] [PULL 12/15] qapi-types: Don't filter out expressions with 'gen'

2015-06-18 Thread Markus Armbruster
Useless, because it can only occur in commands, and we're not dealing with commands here. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-types.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 6bd0b13..86e5ddc 10

[Qemu-devel] [PULL 15/15] qapi-types: Bury code dead since commit 6b5abc7

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-types.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 12fb2ef..d28a6b0 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -7

[Qemu-devel] [PULL 09/15] qapi: Better separate the different kinds of helpers

2015-06-18 Thread Markus Armbruster
Insert comments to separate sections dealing with parsing, semantic analysis, code generation, and so forth. Move helpers to their proper section. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 128 1 file

[Qemu-devel] [PULL 10/15] tests/qapi-schema: New flat union array branch test case

2015-06-18 Thread Markus Armbruster
The new test demonstrates another generator crash. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/Makefile | 3 ++- tests/qapi-schema/flat-union-array-branch.err | 10 ++ tests/qapi-schema/flat-union-array-branch.exit | 1 + tests/q

[Qemu-devel] [PULL 14/15] qapi-types: Split generate_fwd_builtin() off generate_fwd_struct()

2015-06-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-types.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index c408542..12fb2ef 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py

[Qemu-devel] [PULL 07/15] qapi: Fix to reject stray 't', 'f' and 'n'

2015-06-18 Thread Markus Armbruster
Screwed up in commit e53188a. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index a24a7e2..6faa897 100644 --- a/scripts/qapi.py +++ b

Re: [Qemu-devel] [PATCH v4 2/2] semihosting: add --semihosting-config arg sub-argument

2015-06-18 Thread Peter Maydell
On 16 June 2015 at 15:20, Leon Alrae wrote: > On 16/06/2015 15:03, Peter Maydell wrote: >> On 16 June 2015 at 13:32, Liviu Ionescu wrote: >>> would it be possible to have all the semihosting patches ready for 2.4? >> >> Yes, I agree that would be good. Is it just this 2 patch >> series, or are th

[Qemu-devel] [PULL 06/15] qapi: Simplify inclusion cycle detection

2015-06-18 Thread Markus Armbruster
We maintain a stack of filenames in include_hist for convenient cycle detection. As error_path() demonstrates, the same information is readily available in the expr_info, so just use that, and drop include_hist. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 18

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Eric Blake
On 06/18/2015 06:07 AM, Alberto Garcia wrote: > On Thu 18 Jun 2015 01:47:20 PM CEST, Kevin Wolf wrote: > I believe our conclusion from an earlier version of the series was that we need QAPI introspection so that libvirt can detect the presence of the feature. Detecting the presence

Re: [Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:11PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/block.c b/block.c > index d1ed227..0b41af4 100644 > --- a/block.

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-18 Thread Peter Maydell
On 18 June 2015 at 10:28, Markus Armbruster wrote: > However, I can't see how I could define a new C style there without > pushing the "local variables" feature well beyond its intended use, and > triggering the confirmation prompts. We wouldn't want to define a new C style, but in general the it

Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"

2015-06-18 Thread Michael Tokarev
27.05.2015 20:53, Markus Armbruster wrote: > Since we now require GLib 2.22+ (commit f40685c), we don't have to > work around lack of g_strcmp0() anymore. > qga/main.c | 2 +- > -if (domain && strcmp(domain, "syslog") == 0) { > +if (g_strcmp0(domain, "syslog") == 0) { Why bother? To me

Re: [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side

2015-06-18 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 06/18/2015 04:53 AM, Dr. David Alan Gilbert wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We reuse the migration events from the source side, sending them on the > >> appropiate place. > > s/appropiate/appropriate/ > > >> > >> Signed-off

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: > +void bdrv_connect(BlockDriverState *bs, Error **errp) > +{ > +BlockDriver *drv = bs->drv; > + > +if (drv && drv->bdrv_connect) { > +drv->bdrv_connect(bs, errp); > +} else if (bs->file) { > +bdrv_connect(bs-

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-18 Thread Eric Blake
[adding libvirt, to make sure I capture a design idea] On 06/18/2015 06:36 AM, Eric Blake wrote: > On 06/18/2015 06:07 AM, Alberto Garcia wrote: >> On Thu 18 Jun 2015 01:47:20 PM CEST, Kevin Wolf wrote: >> > I believe our conclusion from an earlier version of the series was > that we need

Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-18 Thread Paul Donohue
On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote: > On 12/06/2015 16:08, Paul Donohue wrote: > > +static inline int64_t get_max_clock_jump(void) > > +{ > > +// This should be small enough to prevent excessive interrupts from > > being > > +// generated by the RTC on clock jump

Re: [Qemu-devel] [PATCH COLO-Block v6 13/16] quorum: implement block driver interfaces for block replication

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:18PM +0800, Wen Congyang wrote: CCing Alberto Garcia for the quorum block driver. > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block/quorum.c | 78 > ++ > 1

Re: [Qemu-devel] [PATCH COLO-Block v6 15/16] quorum: allow ignoring child errors

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:20PM +0800, Wen Congyang wrote: CCing Alberto Garcia for the quorum block driver. > If the child is not ready, read/write/getlength/flush will > return -errno. It is not critical error, and can be ignored: > 1. read/write: >Just not report the error event. > 2. g

Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 14:58, Paul Donohue wrote: > On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote: >> On 12/06/2015 16:08, Paul Donohue wrote: >>> +static inline int64_t get_max_clock_jump(void) >>> +{ >>> +// This should be small enough to prevent excessive interrupts from >>> being

[Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-06-18 Thread Jan Beulich
The number of slots per page being 511 (i.e. not a power of two) means that the (32-bit) read and write indexes going beyond 2^32 will likely disturb operation. The hypervisor side gets I/O req server creation extended so we can indicate that we're using suitable atomic accesses where needed (not a

Re: [Qemu-devel] [PATCH v6 7/7] hw/pci-bridge: format SeaBIOS-compliant OFW device node for PXB

2015-06-18 Thread Laszlo Ersek
On 06/17/15 23:49, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 09:35:20PM +0200, Laszlo Ersek wrote: >> On 06/17/15 21:21, Michael S. Tsirkin wrote: >>> On Wed, Jun 17, 2015 at 02:45:05PM +0200, Laszlo Ersek wrote: SeaBIOS expects OpenFirmware device paths in the "bootorder" fw_cfg fil

Re: [Qemu-devel] [PATCH v6 7/7] hw/pci-bridge: format SeaBIOS-compliant OFW device node for PXB

2015-06-18 Thread Laszlo Ersek
On 06/17/15 23:50, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 09:44:07PM +0200, Laszlo Ersek wrote: >> On 06/17/15 21:32, Michael S. Tsirkin wrote: >>> On Wed, Jun 17, 2015 at 03:28:44PM -0400, Kevin O'Connor wrote: On Wed, Jun 17, 2015 at 09:15:24PM +0200, Laszlo Ersek wrote: > O

[Qemu-devel] [PATCH v3 0/3] Fix exceptions handling for MIPS and i386

2015-06-18 Thread Pavel Dovgalyuk
QEMU targets ISAs contain instruction that can break the execution flow with exceptions. When exception breaks the execution of the translation block it may corrupt PC and icount values. This set of patches fixes exception handling for MIPS and i386 targets. Incorrect execution for i386 is causes

Re: [Qemu-devel] [PATCH 0/5] net: error when -net type isn't compiled in

2015-06-18 Thread Stefan Hajnoczi
On Wed, May 27, 2015 at 05:16:47PM +0100, Stefan Hajnoczi wrote: > This series cleans up net_client_init1() and reports an error when the -net > type isn't compiled into the QEMU binary. > > It is based on my net branch with Markus' error cleanups: > https://github.com/stefanha/qemu/tree/net > >

[Qemu-devel] [PATCH v3 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Pavel Dovgalyuk
This patch introduces several helpers to pass return address which points to the TB. Correct return address allows correct restoring of the guest PC and icount. These functions should be used when helpers embedded into TB invoke memory operations. Signed-off-by: Pavel Dovgalyuk --- include/exec/

[Qemu-devel] [PATCH v3 3/3] target-i386: fix memory operations in helpers

2015-06-18 Thread Pavel Dovgalyuk
This patch passes TB return address into softmmu functions that are invoked from target helpers. This allows correct PC and icount recovering while handling MMU faults. Signed-off-by: Pavel Dovgalyuk --- target-i386/cc_helper.c |2 target-i386/cpu.h |5 target-i386/excp_helpe

[Qemu-devel] [PATCH v3 2/3] target-mips: improve exceptions handling

2015-06-18 Thread Pavel Dovgalyuk
This patch improves exception handling in MIPS. Instructions generate several types of exceptions. When exception is generated, it breaks the execution of the current translation block. Implementation of the exceptions handling does not correctly restore icount for the instruction which caused the

Re: [Qemu-devel] [PATCH v6 7/7] hw/pci-bridge: format SeaBIOS-compliant OFW device node for PXB

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 03:22:59PM +0200, Laszlo Ersek wrote: > On 06/17/15 23:50, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2015 at 09:44:07PM +0200, Laszlo Ersek wrote: > >> On 06/17/15 21:32, Michael S. Tsirkin wrote: > >>> On Wed, Jun 17, 2015 at 03:28:44PM -0400, Kevin O'Connor wrote: > >>

Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property

2015-06-18 Thread Paolo Bonzini
On 17/06/2015 16:02, Michael S. Tsirkin wrote: > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not, > > what would be your preference? > > PCI_BRIDGE_DEV_F_SHPC_REQ Do not abbrev unless necessary. :) What about PCI_BRIDGE_DEV_F_HAS_SHPC or even just PCI_BRIDGE_DEV_F_SHPC?

Re: [Qemu-devel] [Spice-devel] [RFC PATCH v2] qxl: allows to specify head limit to qxl driver

2015-06-18 Thread Christophe Fergeau
On Fri, Jun 12, 2015 at 03:05:10PM +0100, Frediano Ziglio wrote: > This patch allow to limit number of heads using qxl driver. By default > qxl driver is not limited on any kind on head use so can decide to use > as much heads. > > libvirt has this as a video card parameter (actually set to 1 but

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values

2015-06-18 Thread Gerd Hoffmann
On Do, 2015-06-18 at 06:45 -0400, Frediano Ziglio wrote: > > On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote: > > > For the same reason there is the v >= l test. > > > The v >= l test state that the value can be out of range so it not always > > > a > > > constant in the range. > > > Addi

Re: [Qemu-devel] [PULL 00/15] QAPI patches

2015-06-18 Thread Peter Maydell
On 18 June 2015 at 13:25, Markus Armbruster wrote: > The following changes since commit 1b58f5a7f6fbe811cc486cd5786483bad5d51bbf: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' > into staging (2015-06-18 11:36:42 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH v2] Add .dir-locals.el file to configure emacs coding style

2015-06-18 Thread Markus Armbruster
Peter Maydell writes: > On 18 June 2015 at 10:28, Markus Armbruster wrote: >> However, I can't see how I could define a new C style there without >> pushing the "local variables" feature well beyond its intended use, and >> triggering the confirmation prompts. > > We wouldn't want to define a ne

Re: [Qemu-devel] linux-user crashes on clone(2) when run on ppc host

2015-06-18 Thread Emilio G. Cota
On Thu, Jun 18, 2015 at 08:42:40 +0100, Peter Maydell wrote: > > What data structures are you referring to? Are they ppc-specific? > > None of the code generation data structures are locked at all -- > if two threads try to generate code at the same time they'll > tend to clobber each other. AFAI

Re: [Qemu-devel] How to trigger faults for missing peripherals?

2015-06-18 Thread Liviu Ionescu
> On 18 Jun 2015, at 13:21, Peter Maydell wrote: > > ... "do_unassigned_access" is the QOM CPUClass hook for this, this hook seems associated with the "Trying to execute code outside RAM or ROM at 0x" error, which is a bit different, I want to catch read/write accesses, not execute accesses.

Re: [Qemu-devel] [PATCH 2/2] mc146818rtc: Reset the periodic timer on load

2015-06-18 Thread Paul Donohue
On Wed, Jun 17, 2015 at 04:01:33PM +0200, Paolo Bonzini wrote: > On 12/06/2015 16:10, Paul Donohue wrote: > > To correct that problem, this commit resets the periodic timer after > > loading from a snapshot or migration if the clock has either jumped > > backward or has jumped forward by more than

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +BlockDriver *drv = bs->drv; + +if (drv && drv->bdrv_connect) { +drv->bdrv_connect(bs, errp); +} else if (bs->fil

Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property

2015-06-18 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 03:47:41PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 16:02, Michael S. Tsirkin wrote: > > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not, > > > what would be your preference? > > > > PCI_BRIDGE_DEV_F_SHPC_REQ > > Do not abbrev unless necessar

<    1   2   3   4   >