Re: [Qemu-devel] qemu freeze, seabios release

2015-06-17 Thread Gerd Hoffmann
On Do, 2015-06-11 at 09:42 +0200, Gerd Hoffmann wrote: > Hi, > > qemu soft freeze for 2.4 is just around the corner, time to think about > the seabios release which should be included there. > > A new release from master isn't even planned yet[1], so I think we > should go for a 1.8.2 stable re

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-17 Thread Thibaut Collet
On Wed, Jun 17, 2015 at 8:42 AM, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 12:16:09PM +0800, Jason Wang wrote: >> >> >> On 06/16/2015 04:16 PM, Thibaut Collet wrote: >> > For a live migration my understanding is there are a suspend resume >> > operation: >> > - The VM image is regularly

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Jun 17, 2015 at 08:52:42AM +0200, Markus Armbruster wrote: >> "Dr. David Alan Gilbert (git)" writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > Older QEMUs dont understand the new (sub)sections that >> > may be generated in the serial device. Limi

Re: [Qemu-devel] [PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU

2015-06-17 Thread Markus Armbruster
Peter Crosthwaite writes: > Neither the monitor or disassembly core has a good reason to navigate from an > env pointer to a cpu pointer. Disas should not need env awarness at all, that > is removed in P2. > > The monitor is trickier, the env is still needed by some #ifdef switched > target > sp

Re: [Qemu-devel] [PATCH v2 1/2] monitor: Split mon_get_cpu fn to remove ENV_GET_CPU

2015-06-17 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 11:42 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> On Tue, Jun 16, 2015 at 8:09 AM, Markus Armbruster wrote: >>> Peter Crosthwaite writes: >>> The monitor currently has one helper, mon_get_cpu() which will return an env pointer. The target spec

[Qemu-devel] [PATCH v2 0/3] error: allow local errors to trigger abort

2015-06-17 Thread Michael S. Tsirkin
It's a common idiom: Error *local_err = NULL; foo(&local_err); ... if (local_err) { error_propagate(errp, local_err); return; } Unfortunately it means that call to foo(&local_err) will not abort even

[Qemu-devel] [PATCH v2 3/3] block/nfs: switch to error_init_local

2015-06-17 Thread Michael S. Tsirkin
We probably should just switch everyone, this is just to demonstrate the API usage. Signed-off-by: Michael S. Tsirkin --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index ca9e24e..de4b8c3 100644 --- a/block/nfs.c +++ b/block/nfs.c @@

[Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Michael S. Tsirkin
makes it possible to copy error_abort pointers, not just pass them on directly. This is needed because follow-up patches add support for Error *local_err = ...; as a way to set an abort-on-error pointer, which requires that we have more than just a global error_abort abort-on-error pointer, bu

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:11:56AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Jun 17, 2015 at 08:52:42AM +0200, Markus Armbruster wrote: > >> "Dr. David Alan Gilbert (git)" writes: > >> > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Older QEMUs dont under

Re: [Qemu-devel] [PATCH v2 5/5] cpu-exec: Purge all uses of CPU_GET_ENV()

2015-06-17 Thread Peter Crosthwaite
On Tue, Jun 16, 2015 at 3:44 AM, Aurelien Jarno wrote: > On 2015-06-16 00:42, Peter Crosthwaite wrote: >> Remove un-needed usages of CPU_GET_ENV() by converting the APIs to use > > Your patch subject and your commit message talks about CPU_GET_ENV(), > while the patch itself changes ENV_GET_CPU().

[Qemu-devel] [PATCH v2 2/3] error: allow local errors to trigger abort

2015-06-17 Thread Michael S. Tsirkin
It's a common idiom: Error *local_err = NULL; foo(&local_err); ... if (local_err) { error_propagate(errp, local_err); return; } Unfortunately it means that call to foo(&local_err) will not abort even if errp is set to error_abort. Instead, we get an a

Re: [Qemu-devel] [PATCH v3 0/8] Add a member in MachineState to store irq array

2015-06-17 Thread Michael Tokarev
17.06.2015 05:59, Shannon Zhao wrote: > From: Shannon Zhao > > These are relevant to memory leak in machine init function. Here we add > a member in MachineState to store irq array returned from > qemu_allocate_irqs. > > PS. These patches are split from my previous patchset [1] since they are >

Re: [Qemu-devel] [PATCH v7 4/6] spapr_pci: set device node unit address as hex

2015-06-17 Thread David Gibson
On Thu, Jun 11, 2015 at 04:32:27PM +0530, Nikunj A Dadhania wrote: > Device node names should encode the unit address as hex, while the > code was encodind it as integers. > > Also, use FDT_NAME_MAX macro for allocating and composing the name. > > Signed-off-by: Nikunj A Dadhania > Reviewed-by:

Re: [Qemu-devel] [PATCH v7 3/6] spapr_pci: enumerate and add PCI device tree

2015-06-17 Thread David Gibson
On Thu, Jun 11, 2015 at 04:32:26PM +0530, Nikunj A Dadhania wrote: > All the PCI enumeration and device node creation was off-loaded to > SLOF. With PCI hotplug support, code needed to be added to add device > node. This creates multiple copy of the code one in SLOF and other in > hotplug code. To

Re: [Qemu-devel] [PATCH v7 1/6] spapr_pci: encode missing 64-bit memory address space

2015-06-17 Thread David Gibson
On Thu, Jun 11, 2015 at 04:32:24PM +0530, Nikunj A Dadhania wrote: > The properties reg/assigned-resources need to encode 64-bit memory > address space as part of phys.hi dword. > > 00 if configuration space > 01 if IO region, > 10 if 32-bit MEM region > 11 if 64-bit MEM region > > Signed

Re: [Qemu-devel] [PATCH v7 2/6] spapr_pci: encode class code including Prog IF register

2015-06-17 Thread David Gibson
On Thu, Jun 11, 2015 at 04:32:25PM +0530, Nikunj A Dadhania wrote: > Current code missed the Prog IF register. All Class Code, Subclass, > and Prog IF registers are needed to identify the accurate device type. > > For example: USB controllers use the PROG IF for denoting: USB > FullSpeed, HighSpee

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-17 Thread David Gibson
On Tue, Jun 16, 2015 at 08:36:34AM +0200, Thomas Huth wrote: > On Tue, 16 Jun 2015 15:40:05 +1000 > David Gibson wrote: > > > On Mon, Jun 15, 2015 at 10:15:09AM +0200, Thomas Huth wrote: > > > On Mon, 15 Jun 2015 16:59:08 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Jun 05, 2015 at 09:

[Qemu-devel] [PULL 1/3] update seabios submodule to release 1.8.2

2015-06-17 Thread Gerd Hoffmann
git shortlog rel-1.8.1..rel-1.8.2 = Gerd Hoffmann (1): vga: rework virtio-vga support Kevin O'Connor (5): vgabios: Add config option for assembler fixups vgabios: Emulate "leal" instruction build: Support "make VERSION=xyz" to override the d

[Qemu-devel] [PULL 2/3] tag our seabios builds

2015-06-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index c76cd5b..7b3f156 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -34,6 +34,9 @@ powerpc64_cross_prefix := $(call find-cross-prefix,powerpc64) powerpc_cros

[Qemu-devel] [PULL 0/3] update seabios to 1.8.2, add virtio-vga vgabios

2015-06-17 Thread Gerd Hoffmann
l.org/qemu tags/pull-seabios-1.8.2-20150617-1 for you to fetch changes up to f3bcd42683dcc48c576281399d6cf6b34da6ba41: update seabios and vgabios binaries (2015-06-17 09:28:03 +0200) update seabios to release 1.8.2 add vgabios for

[Qemu-devel] [PULL 3/3] update seabios and vgabios binaries

2015-06-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/bios.bin | Bin 131072 -> 131072 bytes pc-bios/vgabios-cirrus.bin | Bin 37888 -> 38400 bytes pc-bios/vgabios-qxl.bin| Bin 38400 -> 38400 bytes pc-bios/vgabios-stdvga.bin | Bin 38400 -

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Older QEMUs dont understand the new (sub)sections that > may be generated in the serial device. Limit their generation > to newer machine types. > > Signed-off-by: Dr. David Alan Gilbert No, pleas

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Markus Armbruster
Copying Eric for additional QAPI schema expertise. My questions inline, pretty sure they show my ignorance. "Kővágó, Zoltán" writes: > This patch adds structures into qapi to replace the existing configuration > structures used by audio backends currently. This qapi will be the base of the > -a

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Markus Armbruster
Copying László because his fingerprints are on OptsVisitor. "Kővágó, Zoltán" writes: > The current OptsVisitor flattens the whole structure, if there are same named > fields under different paths (like `in' and `out' in `Audiodev'), the current > visitor can't cope with them (for example setting

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: > > > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > >

Re: [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-17 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This allows to print options in a format that the user would actually write it > on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious > comma at the beginning of the list. Suggest: This will let us print... > Only block.c depended on the old be

Re: [Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor

2015-06-17 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > Simple visitor that recursively allocates structures with only optional > variables. Unions are initialized to the first type specified. Other non > optional types are not supported. Sounds dubious :) Can you explain why it's useful? I guess later patches provide an

Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors

2015-06-17 Thread Paolo Bonzini
On 09/06/2015 20:08, Richard Henderson wrote: > > > +bool be = !!(pfl->features & (1 << PFLASH_BE)); > > > > > > !!() not needed. Otherwise > > > > I don't like magic bool-ification... > > I don't like !! just as much. If you don't like implicit conversion, then use > != 0. Fair enough, l

Re: [Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e

2015-06-17 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > I had to include an enum for audio sampling formats into qapi, but that meant > duplicating the audfmt_e enum. This patch replaces audfmt_e and associated > values with the qapi generated AudioFormat enum. > > This patch is mostly a search-and-replace, except for switch

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 09:52, Michael S. Tsirkin wrote: > > No, please. Upstream QEMU doesn't want to get into judgement about when > > migration quality might be "good enough" that you can drop subsections. > > It's one thing to perfect the .needed functions to make the appearance > > of subsections as

Re: [Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

2015-06-17 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This patch adds an -audiodev command line option, and deprecates the QEMU_* > environment variables for audio backend configuration. It's syntax is similar > to > existing options (-netdev, -device, etc): > -audiodev driver_name,property=value,... Sounds really good.

Re: [Qemu-devel] [RFC v2 3/6] memory: support unmapping of MemoryRegion mapped into HVA parent

2015-06-17 Thread Paolo Bonzini
On 09/06/2015 12:08, Igor Mammedov wrote: > > 3. until #2 is done we can't allow to map another memory region in >current flatview at the same range, hence need to keep list of >still active HVA ranges so we could check at memory_region_add_subregion() >time that new mapping is allow

Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors

2015-06-17 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/06/2015 20:08, Richard Henderson wrote: >> > > +bool be = !!(pfl->features & (1 << PFLASH_BE)); >> > > >> > > !!() not needed. Otherwise >> > >> > I don't like magic bool-ification... >> >> I don't like !! just as much. If you don't like implicit conversion, t

Re: [Qemu-devel] [PATCH v5 1/4] hw/pci-bridge: create interrupt-less, hotplug-less bridge for PXB

2015-06-17 Thread Laszlo Ersek
On 06/17/15 08:24, Michael S. Tsirkin wrote: > On Tue, Jun 16, 2015 at 08:30:42PM +0200, Laszlo Ersek wrote: >> OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI >> Bus driver globally signals the firmware that PCI enumeration and resource >> allocation have completed. At thi

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

2015-06-17 Thread Mark Cave-Ayland
On 16/06/15 13:55, Stefan Hajnoczi wrote: >> I've just done a complete OpenBIOS test run on my images here so I'm >> ready to send the pull request. Should I just send it regardless or wait >> for the repository switch first? > > I got confused when looking at the git mirror configuration. > > g

Re: [Qemu-devel] [PATCH] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers

2015-06-17 Thread Paolo Bonzini
On 16/06/2015 19:48, Aurelien Jarno wrote: > The code assumes that if you don't have an IOMMU, the address range in > the underlying memory region is linear. I think this is exactly what Peter Crosthwaite's infamous :) "exec: Respect as_translate_internal length clamp" patch was trying to fix. H

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-17 Thread Kevin Wolf
Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven wrote: > > I wonder how difficult it would be to have the IDE CDROM run in its own > > thread? > > We usually have ISOs mounted on an NFS share as CDROM. Problem: If the NFS > > Share > > goes d

Re: [Qemu-devel] [PULL 0/3] update seabios to 1.8.2, add virtio-vga vgabios

2015-06-17 Thread Michael Tokarev
17.06.2015 10:38, Gerd Hoffmann wrote: [] > pc-bios/vgabios-cirrus.bin | Bin 37888 -> 38400 bytes > pc-bios/vgabios-qxl.bin| Bin 38400 -> 38400 bytes > pc-bios/vgabios-stdvga.bin | Bin 38400 -> 38400 bytes > pc-bios/vgabios-virtio.bin | Bin 0 -> 38400 bytes > pc-bios/vgabios-vmware.bin | B

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > > to newer machine

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Gerd Hoffmann
On Mi, 2015-06-17 at 09:50 +0200, Markus Armbruster wrote: > Copying László because his fingerprints are on OptsVisitor. > > "Kővágó, Zoltán" writes: > > > The current OptsVisitor flattens the whole structure, if there are same > > named > > fields under different paths (like `in' and `out' in

Re: [Qemu-devel] [PATCH v7 3/6] spapr_pci: enumerate and add PCI device tree

2015-06-17 Thread Nikunj A Dadhania
David Gibson writes: > On Thu, Jun 11, 2015 at 04:32:26PM +0530, Nikunj A Dadhania wrote: >> All the PCI enumeration and device node creation was off-loaded to >> SLOF. With PCI hotplug support, code needed to be added to add device >> node. This creates multiple copy of the code one in SLOF and

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 10:37, Dr. David Alan Gilbert wrote: >> > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: >> > > From: "Dr. David Alan Gilbert" >> > > >> > > Older QEMUs dont understand the new (sub)sections that >> > > may be generated in the serial device. Limit their generation >> >

Re: [Qemu-devel] [Qemu-block] [PATCH v3 07/38] block/quorum: Implement bdrv_is_inserted()

2015-06-17 Thread Alberto Garcia
On Wed 03 Jun 2015 09:43:48 PM CEST, Max Reitz wrote: > bdrv_is_inserted() should be invoked recursively on the children of > quorum. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-17 Thread Paolo Bonzini
On 09/06/2015 09:42, Peter Crosthwaite wrote: > > Acked-by: Paolo Bonzini > > > > About to leave on vacation, so someone else will have to pick it up. > > Enjoy. If you are not back before soft freeze would you object to me > sending a [PULL] for some of the multi-arch related mainloop header >

Re: [Qemu-devel] [PULL 0/3] update seabios to 1.8.2, add virtio-vga vgabios

2015-06-17 Thread Gerd Hoffmann
On Mi, 2015-06-17 at 11:36 +0300, Michael Tokarev wrote: > 17.06.2015 10:38, Gerd Hoffmann wrote: > [] > > pc-bios/vgabios-cirrus.bin | Bin 37888 -> 38400 bytes > > pc-bios/vgabios-qxl.bin| Bin 38400 -> 38400 bytes > > pc-bios/vgabios-stdvga.bin | Bin 38400 -> 38400 bytes > > pc-bios/vgabio

Re: [Qemu-devel] linux-user crashes on clone(2) when run on ppc host

2015-06-17 Thread Peter Maydell
On 17 June 2015 at 01:52, Emilio G. Cota wrote: > Hi, > > I'm having trouble running a simple multithreaded program on a PowerPC host > machine. > > The machine I'm using is a ppc VM--I think it's running under KVM (I'm using > OVH's RunAbove Power8 service): > admin@adsf:~/qemu$ uname -a > L

Re: [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-17 Thread Kevin Wolf
Am 16.06.2015 um 14:49 hat Kővágó, Zoltán geschrieben: > This allows to print options in a format that the user would actually write it > on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious > comma at the beginning of the list. Note that if you really want to produce a val

Re: [Qemu-devel] QOM patches

2015-06-17 Thread Peter Maydell
On 17 June 2015 at 04:09, Peter Crosthwaite wrote: > It's been a while since a QOM PULL and there are a good number of > already-reviewed patches on list. Is Andreas on vacation and returning > before hard freeze or should we do a PULL in the meantime? I believe Andreas is back this week (and pre

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jun 16, 2015 at 07:54:09PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Older QEMUs dont understand the new (sub)sections that > > may be generated in the serial device. Limit their generation > > t

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Kevin Wolf
Am 17.06.2015 um 08:57 hat Michael S. Tsirkin geschrieben: > On Tue, Jun 16, 2015 at 09:03:44AM -0600, Eric Blake wrote: > > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > > makes it possible to copy error_abort pointers, > > > not just pass them on directly. > > > > > > Signed-off-by: Mich

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: >> >> >> On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Older QEMUs dont understand the new (sub)sections that >> > may be generated in the seria

Re: [Qemu-devel] [PATCH v1 4/4] vhost-user: Add new option to specify vhost-user backend features

2015-06-17 Thread Tetsuya Mukawa
On 2015/06/16 21:27, Eric Blake wrote: > On 05/28/2015 10:42 PM, Tetsuya Mukawa wrote: >> This patch adds below '-net' options to let QEMU know which features >> vhost-user backend will support. > [meta-comment: when posting a new revision of a series, do it as a new > top-level thread rather than

Re: [Qemu-devel] [PATCH v1] pci: Don't register a specialized 'config_write' if default behavior is intended

2015-06-17 Thread Marcel Apfelbaum
On 06/16/2015 11:24 AM, Shmulik Ladkani wrote: Few devices have their specialized 'config_write' methods which simply call 'pci_default_write_config' followed by a 'msix_write_config' or 'msi_write_config' calls, using exact same arguments. This is unnecessary as 'pci_default_write_config' alrea

Re: [Qemu-devel] [PATCH v1] pci: Don't register a specialized 'config_write' if default behavior is intended

2015-06-17 Thread Marcel Apfelbaum
On 06/17/2015 12:36 PM, Marcel Apfelbaum wrote: On 06/16/2015 11:24 AM, Shmulik Ladkani wrote: Few devices have their specialized 'config_write' methods which simply call 'pci_default_write_config' followed by a 'msix_write_config' or 'msi_write_config' calls, using exact same arguments. This i

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2015 10:37, Dr. David Alan Gilbert wrote: > >> > On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > >> > > From: "Dr. David Alan Gilbert" > >> > > > >> > > Older QEMUs dont understand the new (sub)sections that > >> > > may be

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-17 Thread Andrew Jones
On Wed, Jun 17, 2015 at 09:06:47AM +0800, Shannon Zhao wrote: > > > On 2015/6/16 22:19, Michael S. Tsirkin wrote: > > On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/6/16 2:13, Michael S. Tsirkin wrote: > >>> On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter May

Re: [Qemu-devel] [RFC] generic-gpio-led & stm32-gpio-led

2015-06-17 Thread Liviu Ionescu
> On 17 Jun 2015, at 03:25, Peter Crosthwaite > wrote: > >> ... >> connecting a gpio_out to a gpio_in seems not possible, gpio_in irqs are >> parented to the device and parenting them to the gpio_out fail with the >> parent != 0 assertion. >> > > This should work. Can I see the backtrace of

Re: [Qemu-devel] [RFC v10 03/19] pcie: modify the capability size assert

2015-06-17 Thread Marcel Apfelbaum
On 06/16/2015 11:10 AM, Chen Fan wrote: because the capabilities need to be DWORD aligned, so the size should DWORD aligned too, and then the last capability size can to be the greatest 0x1000. e.g. if I have a capability starting 4 bytes from the end, 0xFFC. The max size should be 4 bytes, 0x10

Re: [Qemu-devel] [RFC v10 17/19] pcie_aer: expose pcie_aer_msg() interface

2015-06-17 Thread Marcel Apfelbaum
On 06/16/2015 11:11 AM, Chen Fan wrote: For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+), 1 d

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 09:52, Michael S. Tsirkin wrote: > > > No, please. Upstream QEMU doesn't want to get into judgement about when > > > migration quality might be "good enough" that you can drop subsections. > > > It's one thing to

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 11:26:07AM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 09:41:49AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 16/06/2015 20:54, Dr. David Alan Gilbert (git) wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > Older QEMU

[Qemu-devel] [PATCH v3 1/2] block-backend: Introduce blk_drain()

2015-06-17 Thread Alexander Yarygin
This patch introduces the blk_drain() function which allows to replace blk_drain_all() when only one BlockDriverState needs to be drained. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Stefan Hajnoczi Signed-off-by: Alexander Yarygin Reviewed-by: Paolo Bonz

[Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-06-17 Thread Alexander Yarygin
Each call of the virtio_blk_reset() function calls blk_drain_all(), which works for all existing BlockDriverStates, while draining only one is needed. This patch replaces blk_drain_all() by blk_drain() in virtio_blk_reset(). virtio_blk_data_plane_stop() should be called after draining because it r

[Qemu-devel] [PATCH v3 0/2] Fix slow startup with many disks

2015-06-17 Thread Alexander Yarygin
Changes in v3: - Added aio_context_acquire/aio_context_release around blk_drain() in "virtio-blk: Use blk_drain() to drain IO requests" + updated commit description Please update Cc: qemu-stable@ if it necessarily. Changes in v2: - Patch "block-backend: Introduce blk_drain() and

[Qemu-devel] [PULL 03/26] virtio-ccw: disable ioevent bit when ioeventfds are not enabled

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This remove the corresponding error messages in TCG mode, and allow to simplify the s390_assign_subch_ioeventfd() function. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- hw/s390x/virtio-ccw.c | 4 target-s390x/cpu.h| 6 +- 2 files changed, 5

[Qemu-devel] [PULL 04/26] target-s390x: fix setcc in TCG mode

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno In TCG mode we should store the CC value in env->cc_op. However do it inconditionnaly because: - the tcg_enabled function is not inlined - it's probably faster to always store the value, especially given it is likely in the same cache line than env->psw.mask. Signed-off-by

[Qemu-devel] [PULL 15/26] target-s390x: add PER related constants

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/cpu.h | 16 1 file changed, 16 insertions(+) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 66bd639..c18d81b 100644 --- a/target-s390x/cpu.h +++ b/target-s390x/cpu.h

[Qemu-devel] [PULL 12/26] target-s390x: function to adjust the length wrt page boundary

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This patch adds a function to adjust the length of a transfer so that it doesn't cross a page boundary in softmmu mode. It does nothing in user mode. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/mem_helper.c | 11 +++ 1 file changed

[Qemu-devel] [PULL 06/26] target-s390x: initialize I/O interrupt queue

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno env->io_index[] should be set to -1 during CPU reset to mark the I/O interrupt queue as empty. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-s390x/cpu.c b/target-s390x/

[Qemu-devel] [PULL 09/26] target-s390x: wire up DIAG REIPL in TCG mode

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/misc_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c index eebe608..c32aebf 100644 --- a/target-s390x/misc_helper.c +++ b

[Qemu-devel] [PULL 05/26] target-s390x: correctly initialize ext interrupt queue

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno env->ext_index should be initialized to -1 to mark the external interrupt queue as emtpy. This should not be done in s390_cpu_initfn as all the interrupt fields are later reset to 0 by the memset in s390_cpu_initial_reset or s390_cpu_full_reset. Move the initialization there.

[Qemu-devel] [PULL 11/26] softmmu: provide tlb_vaddr_to_host function for user mode

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno To avoid to many #ifdef in target code, provide a tlb_vaddr_to_host for both user and softmmu modes. In the first case the function always succeed and just call the g2h function. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- include/exec/cpu_ldst.h | 8 +

[Qemu-devel] [PULL 01/26] s390/ioinst: fix IO_INT_WORD_ISC macro

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno The I/O-Interruption Subclass field corresponds to bits 2 to 5 (BE notation) of the Interruption-Identification Word. The value should be shift by 27 instead of 24. Signed-off-by: Aurelien Jarno Reviewed-by: Christian Borntraeger Signed-off-by: Alexander Graf --- target-

[Qemu-devel] [PULL 20/26] target-s390x: PER instruction-fetch event support

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno For the PER instruction-fetch, we can't use the QEMU breakpoint infrastructure as it triggers for a single address and not a full address range, and as it actually stop before the instruction and not before. We therefore call an helper with the just fetched instruction addre

[Qemu-devel] [PULL 25/26] target-s390x: PER: add Breaking-Event-Address register

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This patch adds support for PER Breaking-Event-Address register. Like real hardware, it save the current PSW address when the PSW address is changed by an instruction. We have to take care of optimizations QEMU does, a branch to the next instruction is still a branch. This r

[Qemu-devel] [PULL 21/26] translate-all: fix watchpoints if retranslation not possible

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno The tb_check_watchpoint function currently assumes that all memory access is done either directly through the TCG code or through an helper which knows its return address. This is obviously wrong as the helpers use cpu_ldxx/stxx_data functions to access the memory. Instead o

[Qemu-devel] [PULL 16/26] target-s390x: add get_per_atmid function

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This function returns the ATMID field that is stored in the per_perc_atmid lowcore entry. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/cpu.h | 12 1 file changed, 12 insertions(+) diff --git a/target-s390x/cpu.h b/target-s390x

[Qemu-devel] [PULL 02/26] s390/ioinst: fix endianness in ioinst_schib_valid

2015-06-17 Thread Alexander Graf
The ioinst_schib_valid gets a SCHIB in guest endianness, we should byteswap the fields we access. Signed-off-by: Alexander Graf Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/ioinst.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target

[Qemu-devel] [PULL 22/26] target-s390x: PER storage-alteration event support

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno For the PER storage-alteration event we can use the QEMU watchpoint infrastructure. When PER is enabled or PER control register changed we enable the corresponding watchpoints. When a watchpoint arises we can save the event. Unfortunately the current code does not provide the

[Qemu-devel] [PULL 07/26] target-s390x: fix s390_cpu_initial_reset

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno The s390_cpu_initial_reset function zeroes a big part of the CPU state structure, including CPU_COMMON, and thus the QEMU TLB structure. As they should not be initialized with zeroes only, we need to call the tlb_flush to initialize it correctly. Signed-off-by: Aurelien Jarn

[Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17

2015-06-17 Thread Alexander Graf
Hi Peter, This is my current patch queue for s390. Please pull. Alex The following changes since commit 8c29f8d6b9595ac0f9ab1b41f22e91aebab482d7: Merge remote-tracking branch 'remotes/kvaneesh/tags/for-upstream-signed' into staging (2015-06-17 10:13:40 +0100) are available in the git repo

[Qemu-devel] [PULL 18/26] target-s390x: basic PER event handling

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This patch add basic support to generate PER exceptions. It adds two fields to the cpu structure to record for the PER address and PER code & ATMID values. When an exception is triggered and a PER event is pending, the two PER values are copied to the lowcore area. At the en

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > >> > > No, please. Upstream QEMU doesn't want to get into judgement about > >> > > when

[Qemu-devel] [PULL 17/26] target-s390x: add get_per_in_range function

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This function checks if an address is in between the PER starting address and the PER ending address, taking care of a possible address range loop. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/cpu.h | 11 +++ 1 file changed, 11 inse

[Qemu-devel] [PULL 10/26] target-s390x: wire up I/O instructions in TCG mode

2015-06-17 Thread Alexander Graf
The code handling the I/O instructions for KVM decodes the instruction itself. In TCG mode also pass the full instruction word to the helpers. Signed-off-by: Alexander Graf Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/helper.h | 11 ++ target-s390x/insn

[Qemu-devel] [PULL 26/26] s390x: Switch to s390-ccw machine as default

2015-06-17 Thread Alexander Graf
We now finally have TCG support for the basic set of instructions necessary to run the s390-ccw machine. That means in any aspect possible that machine type is now superior to the legacy s390-virtio machine. Switch over to the ccw machine as default. That way people don't get a halfway broken mach

Re: [Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-17 Thread Kővágó Zoltán
2015-06-17 09:46 keltezéssel, Markus Armbruster írta: Copying Eric for additional QAPI schema expertise. My questions inline, pretty sure they show my ignorance. "Kővágó, Zoltán" writes: This patch adds structures into qapi to replace the existing configuration structures used by audio backe

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: >> >> >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: >> > > No, please. Upstream QEMU doesn't want to get into judgement about when >> > > migration quality might be "good enough" that you can drop s

[Qemu-devel] [PULL 23/26] target-s390x: PER store-using-real-address event support

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno This PER event happens each time the STURA or STURG instructions are used. As they use helpers, we can just save the event in the PER code there, if enabled. Signed-off-by: Aurelien Jarno Signed-off-by: Alexander Graf --- target-s390x/mem_helper.c | 16 1

[Qemu-devel] [PULL 19/26] target-s390x: PER successful-branching event support

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno For the PER successful-branching event support, we can't rely on any QEMU infrastucture. We therefore call an helper in all places where a branch can be taken. We have to pay attention to the branch to next case, as it's still a taken branch. We don't need to care about the

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Michael S. Tsirkin
On Wed, Jun 17, 2015 at 12:48:00PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 09:52, Michael S. Tsirkin wrote: > >> > > No, please. Upstream QEMU doesn't want to get into judgement abo

[Qemu-devel] [PULL 13/26] target-s390x: mvc_fast_memset: access memory through softmmu

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno mvc_fast_memset is bypassing the softmmu functions, getting the physical address using the mmu_translate function and accessing the corresponding physical memory. This prevents watchpoints to work correctly. Instead use the tlb_vaddr_to_host function to get the host address

[Qemu-devel] [PATCH] i8254: fix out-of-bounds memory access in pit_ioport_read()

2015-06-17 Thread Petr Matousek
Due converting PIO to the new memory read/write api we no longer provide separate I/O region lenghts for read and write operations. As a result, reading from PIT Mode/Command register will end with accessing pit->channels with invalid index. Fix this by ignoring read from the Mode/Command register

[Qemu-devel] [PULL 08/26] target-s390x: wire up DIAG IPL in TCG mode

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno DIAG IPL is already implemented for KVM, but not wired from TCG. For that change the format of the instruction so that we can get R1 and R3 numbers in addition to the function code. The diag function can change plenty of things, including CC, so we should enter with a static

Re: [Qemu-devel] [PATCH v2 00/11] Sprint to the finish: purge QError

2015-06-17 Thread Stefan Hajnoczi
On Tue, Jun 16, 2015 at 04:21:36PM +0200, Markus Armbruster wrote: > After a bit over a year and many patches, QError is finally ripe. All > that's left of qerror.h after this series is a bunch of QERR_ macros. > Killing them is left for another day. > > The diffstat looks a bit scary, but that's

[Qemu-devel] [PULL 14/26] target-s390x: mvc_fast_memmove: access memory through softmmu

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno mvc_fast_memmove is bypassing the softmmu functions, getting the physical source and destination addresses using the mmu_translate function and accessing the corresponding physical memory. This prevents watchpoints to work correctly. Instead use the tlb_vaddr_to_host functio

Re: [Qemu-devel] [PATCH] Migration compatibility for serial

2015-06-17 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Jun 17, 2015 at 11:51:57AM +0100, Dr. David Alan Gilbert wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > > > "Michael S. Tsirkin" wrote: > > > > On Wed, Jun 17, 2015 at 10:11:48AM +0200, Paolo Bonzini wrote: > > > >> > > > >> > >

Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-17 Thread Kővágó Zoltán
2015-06-17 10:41 keltezéssel, Gerd Hoffmann írta: On Mi, 2015-06-17 at 09:50 +0200, Markus Armbruster wrote: Copying László because his fingerprints are on OptsVisitor. "Kővágó, Zoltán" writes: The current OptsVisitor flattens the whole structure, if there are same named fields under differe

[Qemu-devel] [PULL 24/26] target-s390x: PER instruction-fetch nullification event support

2015-06-17 Thread Alexander Graf
From: Aurelien Jarno For the instruction-fetch nullification event, we just reuse the existing instruction-fetch code and trigger the exception immediately in that case. There is no need to save the CPU state in the TCG code as it has been saved by the previous instruction before calling the per

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-17 Thread zhanghailiang
Hi, Is there any news about this discussion? Is anyone working on it? ;) Since the 'hard feature freeze' time is closer, we'd better to fix it in 2.4 before libvirt uses it. I have sent a RFC patch "[RFC] migration: Re-implement 'migrate-set-parameters' to make it easily for extension" http://

  1   2   3   4   >