[Qemu-devel] [PATCH 0/2] mirror: Allow detection of zeroes on source sectors

2015-06-08 Thread Fam Zheng
[These patches go on top of the "block: Mirror discarded sectors" series] Some protocols don't have an easy way to query sparseness, (e.g. block/nfs.c, block/nbd.c), for which block layer always reports block status as "allocated data". This will let mirror job do full provisioning even if data i

[Qemu-devel] [PATCH 2/2] iotests: Add test cases for drive-mirror "detect-zeroes" option

2015-06-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/132| 26 +++--- tests/qemu-iotests/132.out| 4 ++-- tests/qemu-iotests/iotests.py | 7 +++ 3 files changed, 32 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/132 b/tests/qemu-iotests/132 index f5

[Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-08 Thread Fam Zheng
The new optional flag defaults to true, in which case, mirror job would check the read sectors and use sparse write if they are zero. Otherwise data will be fully copied. Signed-off-by: Fam Zheng --- block/mirror.c| 21 +++-- blockdev.c| 6 +- hm

Re: [Qemu-devel] [PATCH] xen/pass-through: ROM BAR handling adjustments

2015-06-08 Thread Jan Beulich
>>> On 05.06.15 at 18:41, wrote: > On Fri, 5 Jun 2015, Jan Beulich wrote: >> >>> On 05.06.15 at 13:32, wrote: >> >> --- a/hw/xen/xen_pt.c >> >> +++ b/hw/xen/xen_pt.c >> >> @@ -248,7 +248,9 @@ static void xen_pt_pci_write_config(PCID >> >> >> >> /* check unused BAR register */ >> >> in

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-08 Thread Markus Armbruster
Copying Andreas in case he has further advice. Peter Crosthwaite writes: > On Wed, Jun 3, 2015 at 5:31 AM, Liviu Ionescu wrote: >> >>> On 01 Jun 2015, at 23:36, Liviu Ionescu wrote: >>> >>> ... I just pushed a preliminary version where all STM32 MCUs and >>> STM32 related boards use the new fr

Re: [Qemu-devel] fw cfg files cross-version migration races

2015-06-08 Thread Gerd Hoffmann
Hi, > > So, sorting entries (and the index assigned too) should fix this, right? > > That looks easiest to me. > > Presumably, anything happening before (and after) user-provided blobs > are inserted will continue happening in the same order everywhere. Which might change in the future though,

Re: [Qemu-devel] [PATCH 4/4] acpi: unify rsdp generation

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 09:52:22AM +0800, Shannon Zhao wrote: > > But how does one test ARM ACPI code? > > Could you upload an image with instructions to the wiki? > > http://wiki.qemu.org/System_Images > > > > Ok, no problem. But I don't have an account of the wiki. Stefan, you have admin right

Re: [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all()

2015-06-08 Thread Christian Borntraeger
Am 03.06.2015 um 15:46 schrieb Alexander Yarygin: > Each call of the virtio_blk_reset() function calls blk_drain_all(), > which works for all existing BlockDriverStates, while only one > BlockDriverState needs to be drained. > > This patch introduces the blk_drain() function and replaces > blk_dra

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-08 Thread Gerd Hoffmann
On Fr, 2015-06-05 at 15:54 +0200, Kővágó Zoltán wrote: > Hi, > > 2015-06-05 12:57 keltezéssel, Gerd Hoffmann írta: > >> Yeah, I've already hit a problem. The opts_visitor doesn't really handle > >> nested structs (it just flattens it into a single, non hierarchic > >> namespace), which is a proble

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Jan Beulich
>>> On 07.06.15 at 08:23, wrote: > On Mon, Apr 20, 2015 at 04:32:12PM +0200, Michael S. Tsirkin wrote: >> On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: >> > >>> On 20.04.15 at 15:43, wrote: >> > > On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: >> > >> >>> On 13.04.15

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Pavel Fedin
> I think it would be less confusing to store the entire MPIDR > here, and then mask it out if there are places that only > want the affinity bits. I thought about it when i developed this, but in my implementation affinity bits are assigned during CPU instantiation, while feature bits can be ad

Re: [Qemu-devel] ELF loader?

2015-06-08 Thread Peter Maydell
On 7 June 2015 at 17:03, Liviu Ionescu wrote: > >> On 07 Jun 2015, at 13:46, Peter Maydell wrote: >> ... Some ELF files intended for embedded use have >> a little self-initializing bit on the front that manually clears >> their own .bss section, but that's not part of the ELF spec, and >> QEMU wi

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add virtio gpu core code

2015-06-08 Thread Gerd Hoffmann
Hi, > > +static uint32_t virtio_gpu_get_features(VirtIODevice *vdev, uint32_t > > features) > > +{ > > +return features; > > +} > > Does this series rely on some other patches? Because in master, > VirtioDeviceClass::get_features() is still uint64_t (*)(VirtioDevice *, > uint64_t) (which

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-06-08 Thread Peter Maydell
On 7 June 2015 at 20:19, Peter Crosthwaite wrote: > On Sun, Jun 7, 2015 at 3:51 AM, Peter Maydell > wrote: >> worked when I looked at it :-) We'd get duplicate lines in >> the config files, but we already have those when host==target. >> > > Brute force it and sort -u? sort is considered a core

Re: [Qemu-devel] [PATCH 4/4] i386/acpi-build: build_crs(): fetch BAR from PCI config space directly

2015-06-08 Thread Laszlo Ersek
On 06/07/15 11:23, Michael S. Tsirkin wrote: > On Sat, Jun 06, 2015 at 01:46:29AM +0200, Laszlo Ersek wrote: >> OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI >> Bus driver globally signals the firmware that PCI enumeration and resource >> allocation have completed. At thi

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 08:50, Pavel Fedin wrote: >> I think it would be less confusing to store the entire MPIDR >> here, and then mask it out if there are places that only >> want the affinity bits. > > I thought about it when i developed this, but in my implementation > affinity bits are assigned du

Re: [Qemu-devel] [PATCH 0/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-08 Thread Christian Borntraeger
Am 04.06.2015 um 18:20 schrieb Peter Maydell: > blockdev.c will create implicit virtio-blk-* devices for IF_VIRTIO > drives. I want to turn this on for the ARM virt board (now it has PCI), > so that users can use shorter and more comprehensible command lines. > > Unfortunately, the code as it stan

Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-08 Thread Markus Armbruster
Eric Blake writes: > [adding Markus, as author of the regression] > > On 06/04/2015 03:59 PM, Don Slutz wrote: >> On 06/04/15 11:04, Fabio Fantoni wrote: >>> Today after trying xen-unstable build (tested many hours) of some days >>> ago I tried update qemu to latest development version (from git

Re: [Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-08 Thread Markus Armbruster
Wen Congyang writes: > On 06/05/2015 06:09 AM, Don Slutz wrote: >> Public bug reported: >> >> On 06/04/15 11:04, Fabio Fantoni wrote: >>> Today after trying xen-unstable build (tested many hours) of some days >>> ago I tried update qemu to latest development version (from git master >>> commit 6

Re: [Qemu-devel] [BUG] Monitor QMP is broken ?

2015-06-08 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Jun 05, 2015 at 04:58:46PM +0300, Pavel Fedin wrote: >> Hello! >> >> > I have updated my qemu to the recent version and it seems to have >> > lost compatibility >> with >> > libvirt. The error message is: >> > --- cut --- >> > internal error: unable to e

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Markus Armbruster
Eric Blake writes: > On 06/05/2015 08:32 AM, Daniel P. Berrange wrote: >> On Fri, Jun 05, 2015 at 05:17:29PM +0300, Pavel Fedin wrote: >>> This fixes QMP regression: >>> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >>> >>> Signed-off-by: Pavel Fedin >>> --- >>> monitor.c |

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/06/2015 16:17, Pavel Fedin wrote: >> This fixes QMP regression: >> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >> >> Signed-off-by: Pavel Fedin >> --- >> monitor.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/monitor.c b/mo

Re: [Qemu-devel] Windows2012R2 virtio-win drivers and IPv6

2015-06-08 Thread Peter Lieven
Am 28.05.2015 um 16:24 schrieb Vadim Rozenfeld: On Thu, 2015-05-28 at 16:07 +0200, Peter Lieven wrote: Hi, we observed problems with Windows Update Services and Uploading Files from a Windows System to other systems. We tracked this down to IPv6 connections only. IPv4 and IPv6 in Receive dire

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 10:10, Markus Armbruster wrote: > > > +} else if (!strcmp(arg_name, "id")) { > > > +/* Ignored, necessary for backwards compatibility */ > > > } else { > > > error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); > > > return NULL; >

Re: [Qemu-devel] [PATCH 0/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-08 Thread Christian Borntraeger
Am 08.06.2015 um 10:02 schrieb Christian Borntraeger: > So I would prefer to not have this workaround and doing > > index c480f64..7627d57 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -976,17 +976,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, > BlockInterfaceType block_default_type) >

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Thibaut Collet
Hi, My understanding of gratuitous packet with virtio for any backend (vhost user or other): - When the VM is loaded (first start or migration) the virtio net interfaces are loaded ( virtio_net_load_device function in hw/net/virtio-net.c) - If the guest has the VIRTIO_NET_F_GUEST_ANNOUNCE capabili

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Wen Congyang
On 06/08/2015 04:17 PM, Paolo Bonzini wrote: > > > On 08/06/2015 10:10, Markus Armbruster wrote: +} else if (!strcmp(arg_name, "id")) { +/* Ignored, necessary for backwards compatibility */ } else { error_set(errp, QERR_QMP_EXTRA_MEMBE

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 10:08, Markus Armbruster wrote: > > Remember, Markus' patch was about removing asynchronous commands, > > because _those_ commands were where "id" was mishandled (and if we DID > > want asynch commands, it would be even MORE important that they handle > > id corerctly). But he acci

Re: [Qemu-devel] ELF loader?

2015-06-08 Thread Liviu Ionescu
> On 08 Jun 2015, at 10:50, Peter Maydell wrote: > > On 7 June 2015 at 17:03, Liviu Ionescu wrote: >> >>> On 07 Jun 2015, at 13:46, Peter Maydell wrote: >>> ... Some ELF files intended for embedded use have >>> a little self-initializing bit on the front that manually clears >>> their own .bs

[Qemu-devel] [PATCH 0/1] monitor: Fix QMP ABI breakage around "id"

2015-06-08 Thread Markus Armbruster
First, my apologies for screwing this up, and for my slow reaction (I've been offline since Wednesday night). A number of patches for the regression have been posted. They all change the code the same way, but either restore a comment that's no longer correct, or add a new one that isn't quite ri

[Qemu-devel] [PATCH 1/1] monitor: Fix QMP ABI breakage around "id"

2015-06-08 Thread Markus Armbruster
Commit 65207c5 accidentally dropped a line of code we need along with a comment that became wrong then. This made QMP reject "id": {"execute": "system_reset", "id": "1"} {"error": {"class": "GenericError", "desc": "QMP input object member 'id' is unexpected"}} Put the lost line right ba

Re: [Qemu-devel] Trying to execute code outside RAM or ROM at 0x08000230

2015-06-08 Thread Liviu Ionescu
> On 07 Jun 2015, at 01:11, Peter Maydell wrote: > > One handy debugging tool for tracking down this kind of thing is to > use the QEMU monitor's "info mtree" command, I added "-monitor stdio" to the Eclipse configuration used to start the emulator, and I got access to the monitor, but apparen

Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-08 Thread Markus Armbruster
Copying HMP maintainer Luiz. Series Reviewed-by: Markus Armbruster Bandan, thanks for your patience. Luiz, my monitor/QMP queue is currently empty, but if it fills up before you get around to doing a monitor/HMP pull request, I'm happy to take this series along, if it gets your Acked-by.

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 09:09:15AM +0100, Malcolm Crossley wrote: > On 08/06/15 08:42, Jan Beulich wrote: > On 07.06.15 at 08:23, wrote: > >> On Mon, Apr 20, 2015 at 04:32:12PM +0200, Michael S. Tsirkin wrote: > >>> On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: > >>> On 20.

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Jan Beulich
>>> On 08.06.15 at 10:09, wrote: > On 08/06/15 08:42, Jan Beulich wrote: >> Not really. All we concluded so far is that _maybe_ the bridge, upon >> seeing the UR, generates a Master Abort, rendering the whole thing >> fatal. Otoh the respective root port also has >> - Received Master Abort set in

Re: [Qemu-devel] [PATCH 1/1] monitor: Fix QMP ABI breakage around "id"

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 09:44, Markus Armbruster wrote: > Commit 65207c5 accidentally dropped a line of code we need along with > a comment that became wrong then. This made QMP reject "id": > > {"execute": "system_reset", "id": "1"} > {"error": {"class": "GenericError", "desc": "QMP input obje

Re: [Qemu-devel] ELF loader?

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 09:27, Liviu Ionescu wrote: > >> On 08 Jun 2015, at 10:50, Peter Maydell wrote: >> >> On 7 June 2015 at 17:03, Liviu Ionescu wrote: >>> On 07 Jun 2015, at 13:46, Peter Maydell wrote: ... Some ELF files intended for embedded use have a little self-initializing bi

Re: [Qemu-devel] [PATCH] OvmfPkg/PlatformPei: Initialise RCBA (B0:D31:F0 0xf0) register

2015-06-08 Thread Laszlo Ersek
On 06/06/15 21:10, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features (e.g. reboot upon NO_REBOOT bit > not set) on QEMU. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Paulo Alcantara

Re: [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all()

2015-06-08 Thread Stefan Hajnoczi
On Wed, Jun 03, 2015 at 04:46:14PM +0300, Alexander Yarygin wrote: > Each call of the virtio_blk_reset() function calls blk_drain_all(), > which works for all existing BlockDriverStates, while only one > BlockDriverState needs to be drained. > > This patch introduces the blk_drain() function and r

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Jason Wang
On 06/08/2015 04:21 PM, Thibaut Collet wrote: > Hi, > > My understanding of gratuitous packet with virtio for any backend > (vhost user or other): > - When the VM is loaded (first start or migration) the virtio net > interfaces are loaded ( virtio_net_load_device function in > hw/net/virtio-net.c

Re: [Qemu-devel] [PATCH v2 04/10] crypto: introduce generic cipher API & built-in implementation

2015-06-08 Thread Gonglei
On 2015/6/2 21:45, Daniel P. Berrange wrote: > + > +static int qcrypto_cipher_encrypt_des_rfb(QCryptoCipher *cipher, > + const void *in, > + void *out, > + size_t len, > +

Re: [Qemu-devel] Trying to execute code outside RAM or ROM at 0x08000230

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 09:46, Liviu Ionescu wrote: > >> On 07 Jun 2015, at 01:11, Peter Maydell wrote: >> >> One handy debugging tool for tracking down this kind of thing is to >> use the QEMU monitor's "info mtree" command, > > I added "-monitor stdio" to the Eclipse configuration used to start the

Re: [Qemu-devel] [PATCH v2 05/10] crypto: add a gcrypt cipher implementation

2015-06-08 Thread Gonglei
On 2015/6/2 21:45, Daniel P. Berrange wrote: > + > +void qcrypto_cipher_free(QCryptoCipher *cipher) > +{ > +gcry_cipher_hd_t handle = cipher->opaque; > +if (!cipher) { > +return; > +} The check is too late. :( > +gcry_cipher_close(handle); > +g_free(cipher); > +} Rega

Re: [Qemu-devel] Redundant redeclaration of 'gmtime_r' with mingw64

2015-06-08 Thread Stefan Hajnoczi
On Fri, Jun 05, 2015 at 07:18:53PM +0200, Stefan Weil wrote: > Am 05.06.2015 um 16:38 schrieb Stefan Hajnoczi: > >Hi Stefan, > >I get the following compiler warning in Fedora 22 > >(mingw32-headers-4.0.2-1.fc22): > > > >In file included from qemu/include/qemu-common.h:47:0, > > fro

Re: [Qemu-devel] QEMU's CVE Procedures

2015-06-08 Thread Stefan Hajnoczi
On Fri, Jun 05, 2015 at 06:16:30PM -0400, John Snow wrote: > Anyway, my apologies for the wall of text. I wanted to take this > opportunity post-venom to ask some questions to the list to see if the > interest is there in revamping our CVE policy which is in need of, at > the very least, some clari

[Qemu-devel] [Bug 1462944] [NEW] vpc file causes qemu-img to consume lots of time and memory

2015-06-08 Thread Richard Jones
Public bug reported: The attached vpc file causes 'qemu-img info' to consume 3 or 4 seconds of CPU time and 1.3 GB of heap, causing a minor denial of service. $ /usr/bin/time ~/d/qemu/qemu-img info afl12.img block-vpc: The header checksum of 'afl12.img' is incorrect. qemu-img: Could not open 'afl

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 08:42:57AM +0100, Jan Beulich wrote: > >>> On 07.06.15 at 08:23, wrote: > > On Mon, Apr 20, 2015 at 04:32:12PM +0200, Michael S. Tsirkin wrote: > >> On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: > >> > >>> On 20.04.15 at 15:43, wrote: > >> > > On Mon, Apr 13

Re: [Qemu-devel] segfault in memcmp

2015-06-08 Thread Stefan Hajnoczi
On Fri, Jun 05, 2015 at 05:19:53PM -0500, perrier vincent wrote: > Using a very old guest (lenny) with spice and vga=cirrus, I have > a segfault: > > FILE: ui/spice-display.c > FUNCTION: qemu_spice_create_update > LINE: if (memcmp(guest + yoff + xoff, >mirror + y

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 10:03:18AM +0100, Jan Beulich wrote: > >>> On 08.06.15 at 10:09, wrote: > > On 08/06/15 08:42, Jan Beulich wrote: > >> Not really. All we concluded so far is that _maybe_ the bridge, upon > >> seeing the UR, generates a Master Abort, rendering the whole thing > >> fatal. Ot

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Pavel Fedin
Hello! > > I thought about it when i developed this, but in my implementation > > affinity bits are assigned during CPU instantiation, while feature > > bits can be added later, during realize. I could tweak set_feature() > > to sync up MPIDR value but perhaps it isn't the best thing to do. > >

Re: [Qemu-devel] [PATCH 4/4] i386/acpi-build: build_crs(): fetch BAR from PCI config space directly

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 09:56:15AM +0200, Laszlo Ersek wrote: > On 06/07/15 11:23, Michael S. Tsirkin wrote: > > On Sat, Jun 06, 2015 at 01:46:29AM +0200, Laszlo Ersek wrote: > >> OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI > >> Bus driver globally signals the firmware

[Qemu-devel] [Bug 1462944] Re: vpc file causes qemu-img to consume lots of time and memory

2015-06-08 Thread Richard Jones
This slightly modified example takes about 7 seconds and 2 GB of heap: $ /usr/bin/time ~/d/qemu/qemu-img info /mnt/scratch/afl13.img block-vpc: The header checksum of '/mnt/scratch/afl13.img' is incorrect. qemu-img: Could not open '/mnt/scratch/afl13.img': block-vpc: free_data_block_offset point

Re: [Qemu-devel] fw cfg files cross-version migration races

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 09:21:45AM +0200, Gerd Hoffmann wrote: > Hi, > > > > So, sorting entries (and the index assigned too) should fix this, right? > > > That looks easiest to me. > > > > Presumably, anything happening before (and after) user-provided blobs > > are inserted will continue happ

[Qemu-devel] [Bug 1462949] Re: vmdk files cause qemu-img to consume lots of time and memory

2015-06-08 Thread Richard Jones
Both files were found by using american-fuzzy-lop. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1462949 Title: vmdk files cause qemu-img to consume lots of time and memory Status in QEMU: New

[Qemu-devel] [Bug 1462949] Re: vmdk files cause qemu-img to consume lots of time and memory

2015-06-08 Thread Richard Jones
** Attachment added: "afl11.img" https://bugs.launchpad.net/qemu/+bug/1462949/+attachment/4411476/+files/afl11.img -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1462949 Title: vmdk files cause

[Qemu-devel] [Bug 1462949] [NEW] vmdk files cause qemu-img to consume lots of time and memory

2015-06-08 Thread Richard Jones
Public bug reported: The two attached files cause 'qemu-img info' to consume lots of time and memory. Around 10-12 seconds of CPU time, and around 3-4 GB of heap. $ /usr/bin/time ~/d/qemu/qemu-img info afl10.img qemu-img: Can't get size of device 'image': File too large 0.40user 11.57system 0:1

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-06-08 Thread Igor Mammedov
On Mon, 8 Jun 2015 11:28:18 +0530 Bharata B Rao wrote: > On Mon, May 25, 2015 at 02:42:40PM -0300, Eduardo Habkost wrote: > > On Mon, May 25, 2015 at 01:17:57PM +0530, Bharata B Rao wrote: > > > On Thu, May 14, 2015 at 11:39:06AM +0200, Paolo Bonzini wrote: > > > > On 13/05/2015 20:06, Eduardo Ha

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Thibaut Collet
Hi, I agree that my patch is OK only for recent drivers. To have a simple patch with only few modifications I do not implement a solution for old driver but I can be done later. For legacy guest without VIRTIO_NET_F_GUEST_ANNOUNCE the problem is more complex. The RARP must be sent by the vhost cl

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 12:01:38PM +0200, Thibaut Collet wrote: > Hi, > > I agree that my patch is OK only for recent drivers. To have a simple patch > with only few modifications I do not implement a solution for old driver but I > can be done later. > > For legacy guest without VIRTIO_NET_F_GUE

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Michael S. Tsirkin
On Fri, Jun 05, 2015 at 03:24:12PM +0200, Thibaut Collet wrote: > Add VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is > vhost-user. > > For netdev backend using virtio-net NIC the self announce is managed directly > by the virtio-net NIC and not by the netdev backend its

[Qemu-devel] [PATCH] s390x/migration: add comment about floating point migration

2015-06-08 Thread Christian Borntraeger
commit 46c804def4bd ("s390x: move fpu regs into a subsection of the vmstate") moved the fprs into a subsection and bumped the version number. This will allow to not transfer fprs in the future if necessary. Add a comment to mark the return true as intentional. CC: Juan Quintela CC: David Hildenbr

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 10:39, Pavel Fedin wrote: > Last argument: the rest of qemu code (property assignment, lookup > in PSCI, etc) actually needs IDs without feature bits. The only > function which needs full version is mpidr_read(). So does it still > worth of putting AND with bitmasks everywhere?

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Jason Wang
On 06/08/2015 06:01 PM, Thibaut Collet wrote: > Hi, > > I agree that my patch is OK only for recent drivers. To have a simple > patch with only few modifications I do not implement a solution for > old driver but I can be done later. > This makes sense. > For legacy guest without VIRTIO_NET_F_G

[Qemu-devel] poor virtio-scsi performance

2015-06-08 Thread Vasiliy Tolstov
Hi all! I suspected poor performance of virtio-scsi driver. I did a few tests: Host machine: linux 3.19.1, QEMU emulator version 2.3.0 Guest machine: linux 4.0.4 part of domain xml: /usr/bin/kvm /dev/ram0 I got by running `modprobe

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Igor Mammedov
On Thu, 4 Jun 2015 18:17:39 +0100 Peter Maydell wrote: > On 4 June 2015 at 17:40, Shlomo Pongratz wrote: > > From: Pavel Fedin > > Hi. I think this patch largely makes sense, but I have some comments > below. If you want to fix these and resend as a standalone patch > I'm happy to apply that.

[Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-08 Thread Fam Zheng
The logic will be shared with qmp_drive_mirror. Signed-off-by: Fam Zheng --- block.c | 26 ++ blockdev.c| 14 ++ include/block/block.h | 3 +++ 3 files changed, 31 insertions(+), 12 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v2 3/3] iotests: Add test cases for drive-mirror "detect-zeroes" option

2015-06-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/132| 28 +--- tests/qemu-iotests/132.out| 4 ++-- tests/qemu-iotests/iotests.py | 7 +++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/132 b/tests/qemu-iotests/132 index

[Qemu-devel] [PATCH v2 0/3] mirror: Allow detection of zeroes on source sectors

2015-06-08 Thread Fam Zheng
[These patches go on top of the "block: Mirror discarded sectors" series] v2: Rely on block/io.c zero detection. [Paolo] Some protocols don't have an easy way to query sparseness, (e.g. block/nfs.c, block/nbd.c), for which block layer always reports block status as "allocated data". This will le

[Qemu-devel] [PATCH v2 2/3] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-08 Thread Fam Zheng
The new optional flag defaults to true, in which case, mirror job would check the read sectors and use sparse write if they are zero. Otherwise data will be fully copied. Signed-off-by: Fam Zheng --- blockdev.c | 26 +- hmp.c| 2 +- qapi/block-

[Qemu-devel] [PATCH v8 0/4] remove icc bus/bridge

2015-06-08 Thread Zhu Guihua
ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary. This code has passed the new pc-cpu-test. And I have tested with kvm along with kernel_irqchip=on/off, it works fine. This patch series is based on Eduardo

[Qemu-devel] [PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-08 Thread Zhu Guihua
Add a wrapper to specify reset order when registering reset handler, instead of non-obvious initiazation code ordering. Signed-off-by: Zhu Guihua --- include/hw/hw.h | 4 vl.c| 18 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/include/hw/hw.h

[Qemu-devel] [PATCH v8 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-06-08 Thread Zhu Guihua
From: Chen Fan Replace mapping APIC at global system address space with mapping it at per-CPU address spaces. Signed-off-by: Chen Fan Signed-off-by: Zhu Guihua --- exec.c| 5 + hw/i386/pc.c | 7 --- hw/intc/apic_common.c | 14 -- include/exec/mem

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Jan Beulich
>>> On 08.06.15 at 11:30, wrote: > On Mon, Jun 08, 2015 at 08:42:57AM +0100, Jan Beulich wrote: >> Otoh the respective root port also has >> - Received Master Abort set in its Secondary Status register (but >> that's also already the case in the log that we have before the UR >> occurs, i.e. t

Re: [Qemu-devel] [PATCH RFC V3 1/4] Use Aff1 with mpidr This is an improved and KVM-aware alternative to

2015-06-08 Thread Igor Mammedov
On Mon, 08 Jun 2015 12:39:56 +0300 Pavel Fedin wrote: > Hello! > > > > I thought about it when i developed this, but in my implementation > > > affinity bits are assigned during CPU instantiation, while feature > > > bits can be added later, during realize. I could tweak set_feature() > > > to

[Qemu-devel] [PATCH v8 4/4] icc_bus: drop the unused files

2015-06-08 Thread Zhu Guihua
ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu/Makefile.objs | 1 - hw/cpu/icc_bus.c | 118

[Qemu-devel] [PATCH v8 3/4] cpu/apic: drop icc bus/bridge

2015-06-08 Thread Zhu Guihua
From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by registering its reset handler after all device are initialized. Do so and drop ~200LOC of not needed anymore

Re: [Qemu-devel] [PATCH 0/2] vmdk: Fix vmdk_co_get_block_status

2015-06-08 Thread Kevin Wolf
Am 04.06.2015 um 08:02 hat Fam Zheng geschrieben: > The buggy index_in_cluster was missed in b1649fae49a8. Fix that and dedup the > calculation. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 12:34, Fam Zheng wrote: > - "unmap": whether the target sectors should be discarded where source has > only >zeroes. (json-bool, optional, default true) > +- "detect-zeroes": if true, the source sectors that are zeroes will be > written as > + sparse on target. (json-bool, o

Re: [Qemu-devel] [PATCH v2] memory_mapping: Rework cpu related includes

2015-06-08 Thread Paolo Bonzini
On 07/06/2015 23:59, Peter Crosthwaite wrote: > This makes it more consistent with all other core code files, which > either just rely on qemu-common.h inclusion or precede cpu.h with > qemu-common.h. > > cpu-all.h should not be included in addition to cpu.h. Remove it. > > Signed-off-by: Peter

Re: [Qemu-devel] Trying to execute code outside RAM or ROM at 0x08000230

2015-06-08 Thread Liviu Ionescu
> On 08 Jun 2015, at 12:17, Peter Maydell wrote: > > On 8 June 2015 at 09:46, Liviu Ionescu wrote: >> >> Q: is there any simple way to get rid of them? > > This is probably the readline support (so you can do cursor > editing of command lines). You can turn that off, though I forget > the syn

[Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 11:32, Igor Mammedov wrote: > On Thu, 4 Jun 2015 18:17:39 +0100 > Peter Maydell wrote: >> On 4 June 2015 at 17:40, Shlomo Pongratz wrote: >> In order for it to work correctly we must use MPIDR values in >> the device tree which match the MPIDR values the kernel has picked >>

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Jan Beulich
>>> On 08.06.15 at 11:36, wrote: > On Mon, Jun 08, 2015 at 10:03:18AM +0100, Jan Beulich wrote: >> >>> On 08.06.15 at 10:09, wrote: >> > I believe the correct behaviour is happening but a PCIE completion timeout >> > is occurring instead of a >> > unsupported request. >> >> Might it be that wit

[Qemu-devel] [PULL v3 00/62] KVM, dirty bitmap, build system, SMM, icount changes for 2015-06-05

2015-06-08 Thread Paolo Bonzini
The following changes since commit 00967f4e0bab246679d0ddc32fd31a7179345baf: Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' into staging (2015-06-05 12:04:42 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

Re: [Qemu-devel] Trying to execute code outside RAM or ROM at 0x08000230

2015-06-08 Thread Peter Maydell
On 8 June 2015 at 11:51, Liviu Ionescu wrote: >> On 08 Jun 2015, at 12:17, Peter Maydell wrote: >> What is printing the "Execute ..." line? A quick grep of the >> sources suggests it's not QEMU. > > it is part of the increased verbosity needed by my use case. > for this I added -verbose, which ca

Re: [Qemu-devel] [PATCH 0/3] acpi: Clean up some GLib compatibility cruft

2015-06-08 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster (3): > Revert "aml-build: fix build for glib < 2.22" > acpi: Drop superfluous GLIB_CHECK_VERSION() > acpi: Simplify printing to dynamic string 3/3 got in (commit c3bdc56, thanks), but what about the other two? They still apply cleanly.

Re: [Qemu-devel] QEMU's CVE Procedures

2015-06-08 Thread Stefano Stabellini
On Fri, 5 Jun 2015, John Snow wrote: > - Topal: Output generated on Mon Jun 8 11:48:03 BST 2015 > - Topal: GPG output starts - > gpg: Signature made Fri 05 Jun 2015 23:16:30 BST using RSA key ID AAFC390E > gpg: Can't check signature: public key not found > - Topal: GPG output ends

Re: [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all()

2015-06-08 Thread Kevin Wolf
Am 03.06.2015 um 15:46 hat Alexander Yarygin geschrieben: > Each call of the virtio_blk_reset() function calls blk_drain_all(), > which works for all existing BlockDriverStates, while only one > BlockDriverState needs to be drained. > > This patch introduces the blk_drain() function and replaces >

Re: [Qemu-devel] Trying to execute code outside RAM or ROM at 0x08000230

2015-06-08 Thread Liviu Ionescu
> On 08 Jun 2015, at 13:56, Peter Maydell wrote: > > Is this verbosity also the thing printing the line with all > the escape characters in it? I don't think so, the code added at around line 4135 in monitor.c looks like: #if defined(CONFIG_VERBOSE) if (verbosity_level >= VERBOSITY_COM

Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing

2015-06-08 Thread Yongbok Kim
On 01/06/2015 16:28, Richard Henderson wrote: > On 06/01/2015 02:42 AM, Yongbok Kim wrote: >> I have noticed that you haven't changed it for the tci, is it deliberate? >> Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st >> names correctly but hex code will be printed out. >

[Qemu-devel] [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM

2015-06-08 Thread Stefan Berger
The following series of patches extends TPM support with an external TPM that offers a Linux CUSE (character device in userspace) interface. This TPM lets each VM access its own private vTPM. The CUSE TPM supports suspend/resume and migration. Much out-of-band functionality necessary to control the

[Qemu-devel] [PATCH v4 2/4] Introduce condition to notify waiters of completed command

2015-06-08 Thread Stefan Berger
Introduce a lock and a condition to notify anyone waiting for the completion of the execution of a TPM command by the backend (thread). The backend uses the condition to signal anyone waiting for command completion. We need to place the condition in two locations: one is invoked by the backend thre

[Qemu-devel] [PATCH v4 3/4] Introduce condition in TPM backend for notification

2015-06-08 Thread Stefan Berger
TPM backends will suspend independently of the frontends. Also here we need to be able to wait for the TPM command to have been completely processed. Signed-off-by: Stefan Berger --- hw/tpm/tpm_passthrough.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/tpm/tpm_pas

Re: [Qemu-devel] fw cfg files cross-version migration races

2015-06-08 Thread Gerd Hoffmann
> > I would simply sort everything (and do it for new machine types only, > > for backward compatibility reasons). Sorting user-provided blobs only > > adds complexity for no reason. > Do we want this for all machine types,

[Qemu-devel] [PATCH v4 4/4] Add support for VM suspend/resume for TPM TIS

2015-06-08 Thread Stefan Berger
Extend the TPM TIS code to support suspend/resume. In case a command is being processed by the external TPM when suspending, wait for the command to complete to catch the result. In case the bottom half did not run, run the one function the bottom half is supposed to run. This then makes the resume

[Qemu-devel] [PATCH v4 1/4] Provide support for the CUSE TPM

2015-06-08 Thread Stefan Berger
Rather than integrating TPM functionality into QEMU directly using the TPM emulation of libtpms, we now integrate an external emulated TPM device. This device is expected to implement a Linux CUSE interface (CUSE = character device in userspace). QEMU talks to the CUSE TPM using much functionality

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Michael S. Tsirkin
On Mon, Jun 08, 2015 at 11:55:22AM +0100, Jan Beulich wrote: > >>> On 08.06.15 at 11:36, wrote: > > On Mon, Jun 08, 2015 at 10:03:18AM +0100, Jan Beulich wrote: > >> >>> On 08.06.15 at 10:09, wrote: > >> > I believe the correct behaviour is happening but a PCIE completion > >> > timeout > >> >

Re: [Qemu-devel] [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user

2015-06-08 Thread Thibaut Collet
Hi, > I don't think qemu_send_packet_raw can ever work for vhost user. > What happens if you merely add VIRTIO_NET_F_GUEST_ANNOUNCE > to the feature list, and drop the rest of the patch? If you merely add VIRTIO_NET_F_GUEST_ANNOUNCE you have the GARP with recent guest after a live migration. The

Re: [Qemu-devel] [PATCH] xen/pass-through: ROM BAR handling adjustments

2015-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2015, Jan Beulich wrote: > >>> On 05.06.15 at 18:41, wrote: > > On Fri, 5 Jun 2015, Jan Beulich wrote: > >> >>> On 05.06.15 at 13:32, wrote: > >> >> --- a/hw/xen/xen_pt.c > >> >> +++ b/hw/xen/xen_pt.c > >> >> @@ -248,7 +248,9 @@ static void xen_pt_pci_write_config(PCID > >> >> > >

Re: [Qemu-devel] segfault in memcmp

2015-06-08 Thread Gerd Hoffmann
On Mo, 2015-06-08 at 10:31 +0100, Stefan Hajnoczi wrote: > On Fri, Jun 05, 2015 at 05:19:53PM -0500, perrier vincent wrote: > > Using a very old guest (lenny) with spice and vga=cirrus, I have > > a segfault: Hmm, doesn't reproduce on master (booting i386 lenny install iso). Which qemu version is

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-08 Thread Jan Beulich
>>> On 08.06.15 at 13:28, wrote: > On Mon, Jun 08, 2015 at 11:55:22AM +0100, Jan Beulich wrote: >> But you asking this made me look more closely at the >> memory ranges dumped out to the ITP log: The root port has >> >> 0x20: Memory Base = 0xca40 >> 0x22: Memory Limit = 0

  1   2   3   4   5   >