Re: [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes

2015-06-01 Thread Peter Maydell
On 31 May 2015 at 19:34, Michael S. Tsirkin wrote: > The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150529' into staging (2015-05-29 > 17:10:57 +0100) > > are available in the git reposito

Re: [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:04:03PM +0100, Peter Maydell wrote: > On 31 May 2015 at 19:34, Michael S. Tsirkin wrote: > > The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20150529' into sta

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: > On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: > > On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: > > > On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel Apfelbaum wrote: > > >> PXB does not work with unsupported bioses,

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Marcel Apfelbaum
On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel Apfelbaum wrote: PXB do

[Qemu-devel] [PULL v2 04/60] pc: Replace tab with spaces

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Coding style change only. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 12 ++-- hw/i386/pc_piix.c| 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw

[Qemu-devel] [PULL v2 01/60] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao This is in preparation for using alias property in virtio-balloon-pci and virtio-balloon-ccw. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Paolo Bonzini -

[Qemu-devel] [PULL v2 00/60] pc, pci, tpm, virtio, vhost enhancements and fixes

2015-06-01 Thread Michael S. Tsirkin
The following changes since commit 97af820f539efe80b87615a04f9de11ea585f725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150529' into staging (2015-05-29 17:10:57 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

[Qemu-devel] [PULL v2 14/60] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost The compat property was added by commit 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older machine-types were not changed because virtio-9p-pci was introduced on QEMU 0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d282df). The only problem is that this break

[Qemu-devel] [PULL v2 02/60] hw/virtio/virtio-pci: use alias property for virtio-balloon-pci

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Paolo Bonzini --- hw/virtio/virtio-pci.c | 40 ++-- 1 file changed, 6 ins

[Qemu-devel] [PULL v2 17/60] pc: Define MACHINE_OPTIONS macros consistently for all machines

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Define a MACHINE_OPTIONS macro for each PC machine, and move every field inside the QEMUMachine structs to the macros, except for name, init, and compat_props. This also ensures that all MACHINE_OPTIONS inherit the fields from the next version, so their definitions carry on

[Qemu-devel] [PULL v2 06/60] pc: Move commas inside PC_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/p

[Qemu-devel] [PULL v2 19/60] pc: Convert *_MACHINE_OPTIONS macros into functions

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost By now the new functions will get QEMUMachine as argument, but they will be later converted to initialize a MachineClass struct directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 42

[Qemu-devel] [PULL v2 20/60] pc: Move compat_props setting inside *_machine_options() functions

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost This will simplify the DEFINE_PC_MACHINE macro, and will help us to implement reuse of PC_COMPAT_* macros through class_init function reuse, in the future. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i3

[Qemu-devel] [PULL v2 03/60] hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c | 39 ++- 1 file changed, 6 inser

[Qemu-devel] [PULL v2 08/60] hw: Define empty HW_COMPAT_2_[23] macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Now we can make everything consistent and define the macros even if they are still empty. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/compat.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/i

[Qemu-devel] [PULL v2 21/60] pc: Don't use QEMUMachine anymore

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Now that we have a DEFINE_PC_MACHINE helper macro that just requires an initialization function, it is trivial to convert them to register a QOM machine class directly, instead of using QEMUMachine. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off

[Qemu-devel] [PULL v2 05/60] hw: Move commas inside HW_COMPAT_2_1 macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/compat

[Qemu-devel] [PULL v2 24/60] piix: Add kvmclock_enabled, pci_enabled globals

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost This looks like a step backwards, but it will allow pc-0.1[0123] and isapc to follow the same compat+init pattern used by the other machine-types, allowing us to generate all init function using the same macro later. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. T

[Qemu-devel] [PULL v2 22/60] pc: Remove qemu_register_pc_machine() function

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost The helper is not needed anymore, as the PC machine classes are registered using QOM directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 2 -- hw/i386/pc.c | 45 --

[Qemu-devel] [PULL v2 16/60] piix: Define PC_COMPAT_0_10

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Move compat_props from pc-0.10 to the macro, to make it consistent with the other machines. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 47 +-- 1 fil

[Qemu-devel] [PULL v2 07/60] spapr: Move commas inside SPAPR_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Changing the convention to include commas inside the macros will allow macros containing empty lists to be defined and used without compilation errors. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ppc/spapr.c |

[Qemu-devel] [PULL v2 25/60] piix: Eliminate pc_init_pci()

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost The function is not needed anymore, we can simply call pc_init1() directly. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 31 +-- 1 file changed, 13 insertions(+), 18

[Qemu-devel] [PULL v2 23/60] machine: Remove unused fields from QEMUMachine

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost This removes the following fields from QEMUMachine: family, alias, reset, hot_add_cpu, units_per_default_bus, no_serial, no_parallel, use_virtcon, use_sclp, no_floppy, no_cdrom, default_display, compat_props, and hw_version. The only users of those fields were already conve

[Qemu-devel] [PULL v2 18/60] pc: Define machines using a DEFINE_PC_MACHINE macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost This will automatically generate the existing QEMUMachine structs based on the *_MACHINE_OPTIONS macros, and automatically add registration code for them. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i38

[Qemu-devel] [PULL v2 09/60] pc: Define PC_COMPAT_2_[123] macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Once we start adding compat code for pc-2.3, the usage of HW_COMPAT_2_1 in pc-*-2.2 won't be enough, as it also has to include PC_COMPAT_2_3 inside it. To ensure that, define PC_COMPAT_2_3, PC_COMPAT_2_2, and PC_COMPAT_2_1 macros. Signed-off-by: Eduardo Habkost Reviewed-by

[Qemu-devel] [PULL v2 28/60] virtio: move host_features

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck Move host_features from the individual transport proxies into the virtio device. Transports may continue to add feature bits during device plugging. This should it make easier to offer different sets of host features for virtio-1/transitional support. Tested-by: Shannon Zhao

[Qemu-devel] [PULL v2 26/60] pc: Generate init functions with a macro

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost All pc-i440fx and pc-q35 init functions simply call the corresponding compat function and then call the main init function. Use a macro to generate that code. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc

[Qemu-devel] [PULL v2 34/60] virtio-ccw: introduce ccw specific queue limit

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/s390x/s390_flic.h | 5 - hw/s390x/s390-virtio-ccw.c | 2 +- hw/s390x/vir

[Qemu-devel] [PULL v2 10/60] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost SPAPR_COMPAT_2_1 will need to include both HW_COMPAT_2_2 and HW_COMPAT_2_1, so include HW_COMPAT_2_1 inside SPAPR_COMPAT_2_1 and HW_COMPAT_2_2 inside SPAPR_COMPAT_2_2. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- h

[Qemu-devel] [PULL v2 29/60] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck This was copied from virtio-pci, but it doesn't make much sense for ccw, as it doesn't have to handle the broken implementations this bit is supposed to deal with. Remove it. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[Qemu-devel] [PULL v2 32/60] virtio: device_plugged() can fail

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang This patch passes error pointer to transport specific device_plugged() callback. Through this way, device_plugged() can do some transport specific check and fail. This will be uesd by following patches that check the number of virtqueues against the transport limitation. Cc: Cor

[Qemu-devel] [PULL v2 11/60] spapr: define SPAPR_COMPAT_2_3

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Don't add the pseries-2.3 machine yet, but define the corresponding SPAPR_COMPAT macro to make sure both pseries-2.2 and pseries-2.1 will inherit HW_COMPAT_2_3. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ppc/s

[Qemu-devel] [PULL v2 30/60] virtio: move VIRTIO_F_NOTIFY_ON_EMPTY into core

2015-06-01 Thread Michael S. Tsirkin
From: Cornelia Huck Nearly all transports have been offering VIRTIO_F_NOTIFY_ON_EMPTY, s390-virtio being the exception. There's no reason why it shouldn't offer it as well, though (handling is done in core anyway), so let's move it to the common virtio features. While we're changing it anyway, f

[Qemu-devel] [PULL v2 35/60] virtio-ccw: validate the number of queues against bus limitation

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/s390x/virtio-ccw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x

[Qemu-devel] [PULL v2 41/60] i386/pc: '-drive if=floppy' should imply a board-default FDC

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek Even if board code decides not to request the creation of the FDC (keyed off board-level factors, to be determined later), we should create the FDC nevertheless if the user passes '-drive if=floppy' on the command line. Otherwise '-drive if=floppy' would break without explicit

[Qemu-devel] [PULL v2 31/60] virtio-net: adding all queues in .realize()

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang Instead of adding queues for multiqueue during feature set. This patch did this in .realize(), this will help the following patches that count the number of virtqueues used in .device_plugged() callback. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v2 13/60] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11 breaks the PC_COMPAT_* nesting pattern we currently use. As those variables are overwritten in pc-0.10 too, they can be inherited by pc-0.10 with no side-effects at all. Cc: Gerd Hoffmann Signed-off-by: E

[Qemu-devel] [PULL v2 37/60] virtio-s390: introduce virtio_s390_device_plugged()

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang This patch introduce a virtio-s390 specific device_plugged() function and doing the number of virtqueue validation inside. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/s390x/s390

[Qemu-devel] [PULL v2 12/60] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost Those properties were introduced by commit 3827cdb1c3aa17a792d1658161195b9d7173c26b. They were not duplicated into pc-0.13 and older because 0.14 was the first QEMU version supporting qxl. The only problem is that this breaks the PC_COMPAT_* nesting pattern we currently use.

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Gerd Hoffmann
On Mo, 2015-06-01 at 14:17 +0200, Michael S. Tsirkin wrote: > On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: > > On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: > > > On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote: > > > > On Mon, May 25, 2015 at 06:34:01PM +0300, Marcel

[Qemu-devel] [PULL v2 48/60] TPM2 ACPI table support

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger Add a TPM2 ACPI table if a TPM 2 is used in the backend. Also add an SSDT for the TPM 2. Rename tpm_find() to tpm_get_version() and have this function return the version of the TPM found, TPMVersion_Unspec if no TPM is found. Use the version number to build version specific A

[Qemu-devel] [PULL v2 38/60] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang VIRTIO_PCI_QUEUE_MAX is not only used for pci, so rename it be generic. Cc: Amit Shah Cc: Paolo Bonzini Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 2 +- hw/char/virtio-serial-bus.c | 2 +-

[Qemu-devel] [PULL v2 39/60] virtio: increase the queue limit to 1024

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang Increase the queue limit to 1024. But virtio-ccw and s390-virtio won't support this, this is done through failing device_plugged() for those two transports if the number of virtqueues is greater than 64. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v2 44/60] acpi: Simplify printing to dynamic string

2015-06-01 Thread Michael S. Tsirkin
From: Markus Armbruster build_append_namestringv() and aml_string() first calculate the resulting string's length with vsnprintf(NULL, ...), then allocate, then print for real. Simply use g_strdup_vprintf() or g_vasprintf() instead. Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsir

[Qemu-devel] [PULL v2 15/60] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13

2015-06-01 Thread Michael S. Tsirkin
From: Eduardo Habkost The VGA and vmware-svga rombar compat properties were added by commit 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently follow. The new variables will now be inherited by pc-0.11 and older, bu

[Qemu-devel] [PULL v2 52/60] acpi: add aml_shiftleft() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefShiftLeft Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Shannon Zhao --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 10

[Qemu-devel] [PULL v2 40/60] i386/pc: pc_basic_device_init(): delegate FDC creation request

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek This patch introduces no observable change, but it allows the callers of pc_basic_device_init(), ie. pc_init1() and pc_q35_init(), to request (or not request) the creation of the FDC explicitly. At the moment both callers pass constant create_fdctrl=true (hence no observable c

[Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper

2015-06-01 Thread Leon Yu
as comparing boolean with constant 3 is always false. Signed-off-by: Leon Yu --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab..30f2374 100644 --- a/target-arm/op_helper.c +++ b/target-arm/

[Qemu-devel] [PULL v2 27/60] pc: acpi: fix pvpanic for buggy guests

2015-06-01 Thread Michael S. Tsirkin
From: Radim Krčmář In the old times, we always had pvpanic in ACPI and a _STA method told the guest not to use it. Automatic generation dropped the _STA method as the specification says that missing _STA means enabled and working. Some guests (Linux) had buggy drivers and this change made them u

[Qemu-devel] [PULL v2 45/60] Add stream ID to MSI write

2015-06-01 Thread Michael S. Tsirkin
From: Pavel Fedin GICv3 ITS distinguishes between devices by using hardwired device IDs passed on the bus. This patch implements passing these IDs in qemu. SMMU is also known to use stream IDs, therefore this addition can also be useful for implementing platforms with SMMU. Signed-off-by: Pave

[Qemu-devel] [PULL v2 53/60] acpi: add aml_shiftright() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefShiftRight Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Shannon Zhao --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 10

[Qemu-devel] [PULL v2 33/60] virtio: introduce virtio_get_num_queues()

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang This patch introduces virtio_get_num_queues() which iterates the vqs array and return the number of virtqueues used by device. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio.

[Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek It is Very annoying to carry forward an outdatEd coNtroller with a mOdern Machine type. Hence, let us not instantiate the FDC when all of the following apply: - the machine type is pc-q35-2.4 or later, - "-device isa-fdc" is not passed on the command line (nor in the config

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 03:21:19PM +0300, Marcel Apfelbaum wrote: > On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: > >On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: > >>On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: > >>>On 05/31/2015 09:12 PM, Michael S. Tsirkin wrote

[Qemu-devel] [PULL v2 36/60] virtio-s390: introduce virito s390 queue limit

2015-06-01 Thread Michael S. Tsirkin
From: Jason Wang Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/s390x/s390-virtio-bus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390

[Qemu-devel] [PULL v2 55/60] acpi: add aml_while() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefWhile Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + 1 file changed, 1 insertion(+) diff -

[Qemu-devel] [PULL v2 49/60] acpi: add aml_add() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefAdd Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Shannon Zhao --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 10 ++

[Qemu-devel] [PULL v2 42/60] i386/pc_q35: don't insist on board FDC if there's no default floppy

2015-06-01 Thread Michael S. Tsirkin
From: Laszlo Ersek The "no_floppy = 1" machine class setting causes "default_floppy" in main() to become zero. Consequently, default_drive() will not call drive_add() and drive_new() for IF_FLOPPY, index=0, meaning that no default floppy drive will be created for the virtual machine. In that case

[Qemu-devel] [PULL v2 56/60] hw/acpi/aml-build: Fix memory leak

2015-06-01 Thread Michael S. Tsirkin
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

[Qemu-devel] [PULL v2 50/60] acpi: add aml_lless() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefLLess Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 9 ++

[Qemu-devel] [PULL v2 46/60] Extend TPM TIS interface to support TPM 2

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger Following the recent upgrade to version 1.3, extend the TPM TIS interface with capabilities introduced for support of a TPM 2. TPM TIS for TPM 2 introduced the following extensions beyond the TPM TIS 1.3 (used for TPM 1.2): - A new 32bit interface Id register was introduced.

[Qemu-devel] [PULL v2 58/60] qdev: add 64bit properties

2015-06-01 Thread Michael S. Tsirkin
From: Gerd Hoffmann Needed for virtio features which go from 32bit to 64bit with virtio 1.0 Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/qdev-properties.h | 10 hw/core/qdev-properties.c| 58 +++

[Qemu-devel] [PULL v2 51/60] acpi: add aml_index() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Shannon Zhao --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 10 ++ 2 files changed, 11

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
<#secure method=pgpmime mode=sign> Paolo Bonzini writes: > On 01/06/2015 13:16, Dmitry Monakhov wrote: >> 259,0 31 385 0.719283423 10729 Q WS 29376775 + 248 [qemu-io] >> 259,0 31 388 0.719287600 10729 Q WS 29377023 + 8 [qemu-io] >> 259,0 31 391 0.719315193

[Qemu-devel] [PULL v2 47/60] tpm: Probe for connected TPM 1.2 or TPM 2

2015-06-01 Thread Michael S. Tsirkin
From: Stefan Berger In the TPM passthrough backend driver, modify the probing code so that we can check whether a TPM 1.2 or TPM 2 is being used and adapt the behavior of the TPM TIS accordingly. Move the code that tested for a TPM 1.2 into tpm_utils.c and extend it with test for probing for TPM

[Qemu-devel] [PULL v2 59/60] virtio: make features 64bit wide

2015-06-01 Thread Michael S. Tsirkin
From: Gerd Hoffmann Make features 64bit wide everywhere. On migration a full 64bit guest_features field is sent if one of the high bits is set, in addition to the lower 32bit guest_features field which must stay for compatibility reasons. That way we send the lower 32 feature bits twice, but th

[Qemu-devel] [PULL v2 57/60] virtio-mmio: ioeventfd support

2015-06-01 Thread Michael S. Tsirkin
From: Ying-Shiuan Pan set_host_notifier and set_guest_notifiers supported by virtio-mmio now. Most code copied from virtio-pci. This makes it possible to use vhost-net with virtio-mmio, improving performance by about 30%. The kvm-arm does not yet support irqfd, need to fix the hard-coded part a

[Qemu-devel] [PULL v2 54/60] acpi: add aml_increment() term

2015-06-01 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Add encoding for ACPI DefIncrement Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 8 ++

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 01:26:53PM +0200, Laszlo Ersek wrote: > On 06/01/15 12:48, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 01/06/2015 12:23, Michael S. Tsirkin wrote: > >>> Still, reserving part of the namespace for QEMU interna

[Qemu-devel] [PULL v2 60/60] vhost-user: add multi queue support

2015-06-01 Thread Michael S. Tsirkin
From: Ouyang Changchun Based on patch by Nikolay Nikolaev: Vhost-user will implement the multi queue support in a similar way to what vhost already has - a separate thread for each queue. To enable the multi queue functionality - a new command line parameter "queues" is introduced for the vhost-u

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 14:38, Michael S. Tsirkin wrote: > I'm sorry - I don't understand. It's easy to do the right thing. Just > add the opt prefix. Why insist on user doing the right thing, and punish > violations with failing at random? > > If it's useful for developers somehow, add a config flag for

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-06-01 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * John Snow (js...@redhat.com) wrote: >> >> >> >> >> >> On 05/21/2015 09:19 AM, Kevin Wolf wrote: >> >> > The floppy controller spec describes three different controll

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 14:41, Michael S. Tsirkin wrote: > On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: >> >> >> On 01/06/2015 14:38, Michael S. Tsirkin wrote: >>> I'm sorry - I don't understand. It's easy to do the right thing. Just >>> add the opt prefix. Why insist on user doing the r

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 02:24:02PM +0200, Gerd Hoffmann wrote: > On Mo, 2015-06-01 at 14:17 +0200, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: > > > On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: > > > > On 05/31/2015 09:12 PM, Michael S.

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
Paolo Bonzini writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 01/06/2015 12:34, Dmitry Monakhov wrote: >> Yes. Improvement is not huge, but it can be detected for old qemu >> unpatched kernel: 728 MiB/sec ± 20Mb patched kernel : 748 MiB/sec >> ± 10Mb > > Ok, so about 3-4

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: > > > On 01/06/2015 14:38, Michael S. Tsirkin wrote: > > I'm sorry - I don't understand. It's easy to do the right thing. Just > > add the opt prefix. Why insist on user doing the right thing, and punish > > violations with failing a

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-06-01 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 29 May 2015 at 11:34, Dr. David Alan Gilbert wrote: >> > It's the destination I'm worried about here, not the source; lets say >> > you have two devices, a & b. 'a' gets serialised, but then 'b' finds >>

Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-06-01 Thread Dmitry Monakhov
Paolo Bonzini writes: > On 13/05/2015 18:46, Denis V. Lunev wrote: >> I agree with this. Kernel guys are aware and may be we will have >> the fix after a while... I have heard (not tested) that performance >> loss over multi-queue SSD is around 30%. > > I came up with this patch... can you test i

Re: [Qemu-devel] [PATCH 1/2] target-arm/kvm64: Add cortex-a53 cpu support

2015-06-01 Thread Shannon Zhao
On 2015/6/1 18:54, Peter Crosthwaite wrote: On Mon, Jun 1, 2015 at 3:34 AM, wrote: From: Shannon Zhao Say more about the changes. Why the gap to index 4? You mean why the KVM_ARM_TARGET_CORTEX_A53 is 4? linux-headers/asm-arm64/kvm.h defines it to 4. /* Supported Processor Types */ #d

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Gerd Hoffmann
Hi, > > Devices behind pxb wouldn't be working because they didn't got resources > > assigned, yes. > > I mean that there's no way to get old seabios+pxb when bisecting. When bisecting in qemu (with bundled seabios) yes. But when bisection in seabios ... Anyway, at the end of the day it doesn

Re: [Qemu-devel] [Qemu-block] [PATCH] mirror: Skip block_job_defer_to_main_loop if already in the main context

2015-06-01 Thread Stefan Hajnoczi
On Mon, Jun 01, 2015 at 09:46:39AM +0800, Fam Zheng wrote: > On Fri, 05/29 13:37, Stefan Hajnoczi wrote: > > On Fri, May 29, 2015 at 10:22:13AM +0800, Fam Zheng wrote: > > > mirror_exit does the replacing, which requires source and target to be > > > in sync, unfortunately we can't guarantee that b

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Marcel Apfelbaum
On 06/01/2015 03:27 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 03:21:19PM +0300, Marcel Apfelbaum wrote: On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-01 at 12:44 +0300, Marcel Apfelbaum wrote: On 05/

Re: [Qemu-devel] VirtIO windows driver: viostor.sys not post-installable

2015-06-01 Thread Philipp Hahn
Hello, On 31.05.2015 12:58, Vadim Rozenfeld wrote: > On Sun, 2015-05-31 at 11:26 +0300, Yan Vugenfirer wrote: >>> On May 29, 2015, at 5:43 PM, Philipp Hahn >>> wrote: ... >>> we tried to migrate some Windows 2008 and 2012 VMs from Xen to KVM, >>> but >>> installing the VirtIO viostor.sys driver f

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-01 Thread Laszlo Ersek
On 06/01/15 14:38, Michael S. Tsirkin wrote: > On Mon, Jun 01, 2015 at 01:26:53PM +0200, Laszlo Ersek wrote: >> On 06/01/15 12:48, Michael S. Tsirkin wrote: >>> On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote: On 01/06/2015 12:23, Michael S. Tsirkin wrote: > Still,

[Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-01 Thread Kővágó, Zoltán
This series of patch removes the following audio backends: esd, fmod, sdl, winwave. It also cleans up the remaining drivers to do not use global variables where possible. This is a preparation for my GSoC project where I will enable multiple simultaneous audio backends. Please also test the corea

[Qemu-devel] [PATCH 03/12] audio: remove sdl backend

2015-06-01 Thread Kővágó, Zoltán
It's broken and we have native drivers for almost all platforms. Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 3 - audio/audio_int.h | 1 - audio/sdlaudio.c| 458 configure | 24 ++- 4 files changed, 11 insertio

[Qemu-devel] [PATCH 01/12] audio: remove esd backend

2015-06-01 Thread Kővágó, Zoltán
ESD is no longer developed and replaced by PulseAudio. Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 1 - audio/audio_int.h | 1 - audio/esdaudio.c| 557 configure | 18 +- 4 files changed, 6 insertions(+), 571 d

[Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in

2015-06-01 Thread Kővágó, Zoltán
Currently the opaque pointer returned by audio_driver's init is only exposed to the driver's fini, but not to audio_pcm_ops. This way if someone wants to share a variable with the driver and the pcm, he must use global variables. This patch fixes it by adding a third parameter to audio_pcm_op's ini

[Qemu-devel] [PATCH 07/12] paaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 102 +--- 1 file changed, 52 insertions(+), 50 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 11c2d29..35e8887 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -9,6 +9,

[Qemu-devel] [PATCH 06/12] alsaaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 154 +- 1 file changed, 82 insertions(+), 72 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index eb33bff..d7e181b 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 02:57:02PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Devices behind pxb wouldn't be working because they didn't got resources > > > assigned, yes. > > > > I mean that there's no way to get old seabios+pxb when bisecting. > > When bisecting in qemu (with bundled seabios)

[Qemu-devel] [PATCH 10/12] dsoundaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 18 audio/dsoundaudio.c | 106 2 files changed, 74 insertions(+), 50 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index 98276fb..85ba858 10064

[Qemu-devel] [PATCH 02/12] audio: remove fmod backend

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 2 - audio/audio_int.h | 1 - audio/fmodaudio.c | 685 configure | 27 +-- 4 files changed, 2 insertions(+), 713 deletions(-) delete mode 100644 audio/fmodaudio.c diff

[Qemu-devel] [PATCH 08/12] ossaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/ossaudio.c | 114 +-- 1 file changed, 61 insertions(+), 53 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 80ac610..d247969 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -38,

Re: [Qemu-devel] [PATCH V7 23/24] apci: fix PXB behaviour if used with unsupported BIOS

2015-06-01 Thread Laszlo Ersek
On 06/01/15 15:05, Marcel Apfelbaum wrote: > On 06/01/2015 03:27 PM, Michael S. Tsirkin wrote: >> On Mon, Jun 01, 2015 at 03:21:19PM +0300, Marcel Apfelbaum wrote: >>> On 06/01/2015 03:17 PM, Michael S. Tsirkin wrote: On Mon, Jun 01, 2015 at 01:40:19PM +0200, Gerd Hoffmann wrote: > On Mo,

[Qemu-devel] [PATCH 04/12] audio: remove winwave audio driver

2015-06-01 Thread Kővágó, Zoltán
DirectSound should be a superior choice on Windows. Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 1 - audio/audio_int.h| 1 - audio/winwaveaudio.c | 717 --- configure| 11 +- 4 files changed, 2 insertions(+), 728 d

[Qemu-devel] [PATCH 11/12] paaudio: fix possible resource leak

2015-06-01 Thread Kővágó, Zoltán
qpa_audio_init did not clean up resources properly if the initialization failed. This hopefully fixes it. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 35e8887..fea6071 100644 ---

[Qemu-devel] [PATCH 12/12] coreaudio: do not use global variables where possible

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/coreaudio.c | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index f38fd82..6dfd63e 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -32,20 +32

[Qemu-devel] [PATCH 09/12] wavaudio: do not use global variables

2015-06-01 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/wavaudio.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index 5132aed..8acea8f 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -36,15 +36,10 @@ typede

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-01 Thread Michael Tokarev
01.06.2015 16:23, Kővágó, Zoltán wrote: > This series of patch removes the following audio backends: > esd, fmod, sdl, winwave. Why do you remove sdl backend? This is my preferred backend so far, it works better than all other backends available to me... Thanks, /mjt

<    1   2   3   4   5   >