[Qemu-devel] [PATCH v3 14/15] target-arm: Add HYP timer

2015-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu-qom.h | 1 + target-arm/cpu.c | 2 ++ target-arm/cpu.h | 3 ++- target-arm/helper.c | 64 4 files changed, 69 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v3 15/15] hw/arm/virt: Connect the Hypervisor timer

2015-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/arm/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 6e939d8..e85d118 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -397,6 +397,9 @@ static void create_gic(VirtBoardInfo *vbi,

Re: [Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options

2015-05-29 Thread Edgar E. Iglesias
On Fri, May 29, 2015 at 04:28:51PM +1000, Alistair Francis wrote: > Firstly this patch series tidies up some code and removes > a "xlnx." prefix. > > Then it moves the Microblaze PVR registers to the end > of the CPUMBState to preserve them during reset. This > allows most of the operations on the

Re: [Qemu-devel] [PATCH v3 0/6] Add Microblaze configuration options

2015-05-29 Thread Alistair Francis
On Fri, May 29, 2015 at 4:58 PM, Edgar E. Iglesias wrote: > On Fri, May 29, 2015 at 04:28:51PM +1000, Alistair Francis wrote: >> Firstly this patch series tidies up some code and removes >> a "xlnx." prefix. >> >> Then it moves the Microblaze PVR registers to the end >> of the CPUMBState to preser

[Qemu-devel] STM32F205 SysTick emulation

2015-05-29 Thread Liviu Ionescu
I did some tests and comparisons between my new Cortex-M implementation and the existing lm3s6965evb and netduino2 boards, and it seems the stm32f205 does not enable the SysTick device, since my simple seconds counting application hangs. exactly the same application works properly on lm3s6965evb

Re: [Qemu-devel] [PATCH 09/10] block: convert qcow/qcow2 to use generic cipher API

2015-05-29 Thread Gonglei
On 2015/5/21 18:56, Daniel P. Berrange wrote: > Switch the qcow/qcow2 block driver over to use the generic cipher > API, this allows it to use the pluggable AES implementations, > instead of being hardcoded to use QEMU's built-in impl. > > Signed-off-by: Daniel P. Berrange > --- > block/qcow.c

Re: [Qemu-devel] [PATCH v3 3/3] ppc: Move cpu_exec_init() call to realize function

2015-05-29 Thread Bharata B Rao
On Thu, May 28, 2015 at 10:17:25PM -0700, Peter Crosthwaite wrote: > On Wed, May 20, 2015 at 10:02 PM, Bharata B Rao > wrote: > > Move cpu_exec_init() call from instance_init to realize. This allows > > any failures from cpu_exec_init() to be handled appropriately. > > Also add corresponding cpu_e

Re: [Qemu-devel] [RFC 4/7] qemu-agent: add qemuAgentCreateBond interface

2015-05-29 Thread Michal Privoznik
On 17.04.2015 10:53, Chen Fan wrote: > via initialize callback to create bond device. > > Signed-off-by: Chen Fan > --- > src/qemu/qemu_agent.c | 118 > > src/qemu/qemu_agent.h | 10 > src/qemu/qemu_domain.c | 70 +

[Qemu-devel] [PATCH] virtio: make features 64bit wide

2015-05-29 Thread Gerd Hoffmann
Make features 64bit wide everywhere. Exception: command line flags remain 32bit and are copyed into the lower 32 host_features at initialization time. On migration a full 64bit guest_features field is sent if one of the high bits is set, additionally to the lower 32bit guest_features field which

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * John Snow (js...@redhat.com) wrote: >> >> >> On 05/21/2015 09:19 AM, Kevin Wolf wrote: >> > The floppy controller spec describes three different controller phases, >> > which are currently not explicitly modelled in our emulation. Instead, >> > each phase is

[Qemu-devel] [PATCH v2] virtio: make features 64bit wide

2015-05-29 Thread Gerd Hoffmann
Make features 64bit wide everywhere. Exception: command line flags remain 32bit and are copyed into the lower 32 host_features at initialization time. On migration a full 64bit guest_features field is sent if one of the high bits is set, additionally to the lower 32bit guest_features field which

Re: [Qemu-devel] [PATCH] virtio: make features 64bit wide

2015-05-29 Thread Gerd Hoffmann
On Fr, 2015-05-29 at 09:48 +0200, Gerd Hoffmann wrote: > Make features 64bit wide everywhere. Exception: command line flags > remain 32bit and are copyed into the lower 32 host_features at > initialization time. Oops, forgot to "git commit --amend", scratch this, v2 coming. sorry, Gerd

Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-29 Thread Markus Armbruster
Bandan Das writes: > Eric Blake writes: > >> On 05/28/2015 12:48 PM, Bandan Das wrote: >>> Markus Armbruster writes: >>> Bandan Das writes: > There's too much going on in monitor_parse_command(). > Split up the arguments parsing bits into a separate function > monitor_pa

Re: [Qemu-devel] [PATCH v2 1/4] hw/display/cg3.c: Fix memory leak

2015-05-29 Thread Markus Armbruster
Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Suffering an identity crisis? ;) > --- > hw/display/cg3.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/display/cg3.c b/hw/display/cg3.c > index 1e6ff2b..

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-29 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >> This is the 5th version of COLO, here is only COLO frame part, include: VM > >> checkpoint, > >> failover, proxy API, block replicat

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-29 Thread zhanghailiang
On 2015/5/29 9:29, Wen Congyang wrote: On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 5th version of COLO, here is only COLO frame part, include: VM checkpoint, failover, proxy API, block replication API, not include bl

Re: [Qemu-devel] [PATCH v2 04/20] monitor: Convert client_migrate_info to QAPI

2015-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 26 May 2015 17:20:39 +0200 > Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake [...] >> index 8170309..38ff972 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -1032,39 +1032,33 @@ static void hmp_info_trace_events(Mon

Re: [Qemu-devel] [PATCH v2 13/20] monitor: Limit QError use to command handlers

2015-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 26 May 2015 17:20:48 +0200 > Markus Armbruster wrote: > >> The previous commits narrowed use of QError to handle_qmp_command() >> and its helpers monitor_protocol_emitter(), build_qmp_error_dict(). >> Narrow it further to just the command handler call: instead o

Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups

2015-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 26 May 2015 17:20:35 +0200 > Markus Armbruster wrote: > >> Command handlers still use QError. Left for another day. > > Great work! I've found one bug that has to be addressed before merging. > Also, for the error conversions you're doing you're going from > qe

[Qemu-devel] [PULL 0/4] spice patch queue

2015-05-29 Thread Gerd Hoffmann
-05-28 16:57:35 +0100) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150529-1 for you to fetch changes up to f7a8beb5e6a13dc924895244777d9ef08b23b367: spice: fix spice_chr_add_watch() pre-condition (2015-05-29 09:5

[Qemu-devel] [PULL 2/4] spice-char: notify the server when chardev is writable

2015-05-29 Thread Gerd Hoffmann
From: Marc-André Lureau The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Signed-off-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c

[Qemu-devel] [PULL 4/4] spice: fix spice_chr_add_watch() pre-condition

2015-05-29 Thread Gerd Hoffmann
From: Marc-André Lureau Since e02bc6de30c44fd668dc0d6e1cd1804f2eed3ed3, add_watch() is called with G_IO_HUP. Even if spice-qemu-char ignores this flag, the precondition must be changed. https://bugzilla.redhat.com/show_bug.cgi?id=1128992 Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c | 2

[Qemu-devel] [PULL 3/4] spice: don't update mm_time when spice-server is stopped.

2015-05-29 Thread Gerd Hoffmann
Skip mm_time updates (in qxl device memory) in case the guest is stopped. Guest isn't able to look anyway, and it causes problems with migration. Also make sure the initial state for spice server is stopped. Reported-by: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c

[Qemu-devel] [PULL 1/4] virtio-console: notify chardev when writable

2015-05-29 Thread Gerd Hoffmann
From: Marc-André Lureau When the virtio serial is writable, notify the chardev backend with qemu_chr_accept_input(). Signed-off-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- hw/char/virtio-console.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/char/virtio-consol

Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

2015-05-29 Thread Kevin Wolf
Am 28.05.2015 um 21:41 hat Eric Blake geschrieben: > On 05/28/2015 09:23 AM, Max Reitz wrote: > > Can we mark the parameter optional, and only provide it when it is > non-zero? That way, qemu-img (which cannot set an interval) will not > report it, and the only time it will appear

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * John Snow (js...@redhat.com) wrote: > >> > >> > >> On 05/21/2015 09:19 AM, Kevin Wolf wrote: > >> > The floppy controller spec describes three different controller phases, > >> > which are currently not ex

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-05-29 Thread Igor Mammedov
On Fri, 22 May 2015 13:32:54 +0300 Pavel Fedin wrote: > This is an improved and KVM-aware alternative to > https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00942.html. Changes > are: > 1. MPIDR value (minus feature bits) is now directly stored in CPU instance. > 2. Default assignment is

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-05-29 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/5/29 9:29, Wen Congyang wrote: > >On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: > >>* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>>This is the 5th version of COLO, here is only COLO frame part, include: VM > >>

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Kevin Wolf
Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: > Touches vl.c, which gives me pretext to ask Paolo: would you be > willing to take this through your tree? Or should I take it through > mine? After this series we have an ugly half-converted state where qemu_opts_foreach() has both a ret

Re: [Qemu-devel] [PATCH] pc: acpi: keep pvpanic backward compatible

2015-05-29 Thread Igor Mammedov
On Wed, 27 May 2015 18:29:17 +0200 Radim Krčmář wrote: > In the old times, we always had pvpanic in ACPI and a _STA function told > the guest not to use it. Now, we only include pvpanic in ACPI if it is > enabled, so the _STA function is useless from qemu's point of view, but > guests still want

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-05-29 Thread Pavel Fedin
Hello! > > +/* > > + * When KVM is in use, psci is emulated in-kernel and not by qemu. > > + * In order for it to work correctly we should use correct MPIDR > > values, > > + * which appear to be inherited from the host. > why it must be inherited from host? > Could you point out

Re: [Qemu-devel] [PATCH 0/3] implement a new icount_no_rt mode

2015-05-29 Thread Victor Clement
- Mail original - > De: "Paolo Bonzini" > À: "Victor CLEMENT" , qemu-devel@nongnu.org > Cc: "francois guerret" > Envoyé: Mercredi 27 Mai 2015 14:52:55 > Objet: Re: [Qemu-devel] [PATCH 0/3] implement a new icount_no_rt mode > > [...] Or are there other cases besides RTC devices? > > Paol

Re: [Qemu-devel] [PATCH 0/3] acpi: Clean up some GLib compatibility cruft

2015-05-29 Thread Igor Mammedov
On Wed, 27 May 2015 19:55:52 +0200 Markus Armbruster wrote: > Markus Armbruster (3): > Revert "aml-build: fix build for glib < 2.22" > acpi: Drop superfluous GLIB_CHECK_VERSION() > acpi: Simplify printing to dynamic string > > hw/acpi/aml-build.c | 34 +++--- >

Re: [Qemu-devel] [PATCH 1/3] icount: implement a new icount_no_rt mode without real time cpu sleeping

2015-05-29 Thread Victor Clement
- Mail original - > De: "Paolo Bonzini" > À: "Victor CLEMENT" , qemu-devel@nongnu.org > Cc: "francois guerret" > Envoyé: Mercredi 27 Mai 2015 14:52:00 > Objet: Re: [Qemu-devel] [PATCH 1/3] icount: implement a new icount_no_rt mode > without real time cpu sleeping > > > > On 27/05/2015

[Qemu-devel] [PULL 1/5] kbd: add brazil kbd keys to qemu

2015-05-29 Thread Gerd Hoffmann
The brazilian computer keyboard layout has two extra keys (compared to the usual 105-key intl ps/2 keyboard). This patch makes these two keys known to qemu. For historic reasons qemu has two ways to specify a key: A QKeyCode (name-based) or a number (ps/2 scancode based). Therefore we have to u

[Qemu-devel] [PULL 5/5] virtio-input: emulated devices [device]

2015-05-29 Thread Gerd Hoffmann
This patch adds the virtio-input-hid base class and virtio-{keyboard,mouse,tablet} subclasses building on the base class. They are hooked up to the qemu input core and deliver input events to the guest like all other hid devices (ps/2 kbd, usb tablet, ...). Using them is as simple as adding "-devi

[Qemu-devel] [PULL 0/5] input patch queue.

2015-05-29 Thread Gerd Hoffmann
ce0274f730eacbd24c706523ddbbabb6b95d0659: Revert "gdbstub: Do not kill target in system emulation mode" (2015-05-28 16:57:35 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-input-20150529-1 for you to fetch changes up to 55a1d80a41032d6133adec041c0096820beaa1b7: virtio-input

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-05-29 Thread Igor Mammedov
On Fri, 29 May 2015 01:11:30 +0300 Liviu Ionescu wrote: > for more flexibility, in the new Cortex-M implementation I'm working on, I > can overwrite the vendor defined MCU internal SRAM size by using: > > -m sizeK > > I'm trying to find a way to also overwrite the internal flash size an

[Qemu-devel] [PULL 2/5] kbd: add brazil kbd keys to x11 evdev map

2015-05-29 Thread Gerd Hoffmann
This patch adds the two extra brazilian keys to the evdev keymap for X11. This patch gets the two keys going with the vnc, gtk and sdl1 UIs. The SDL2 library complains it doesn't know these keys, so the SDL2 library must be fixed before we can update ui/sdl2-keymap.h Cc: qemu-sta...@nongnu.org S

[Qemu-devel] [PULL 4/5] virtio-input: core code & base class [device]

2015-05-29 Thread Gerd Hoffmann
This patch adds virtio-input support to qemu. It brings a abstract base class providing core support, other classes can build on it to actually implement input devices. virtio-input basically sends linux input layer events (evdev) over virtio. Signed-off-by: Gerd Hoffmann --- hw/input/Makefile

[Qemu-devel] [PULL 3/5] virtio-input: add linux/input.h

2015-05-29 Thread Gerd Hoffmann
Linux input layer (evdev) header file. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input.h | 1198 scripts/update-linux-headers.sh|4 +- 2 files changed, 1201 insertions(+), 1 deletion(-) create mode 100644 include/standard-header

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Kevin Wolf
Am 29.05.2015 um 10:33 hat Dr. David Alan Gilbert geschrieben: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * John Snow (js...@redhat.com) wrote: > > >> > > >> > > >> On 05/21/2015 09:19 AM, Kevin Wolf wrote: > > >> > The floppy controller spec

Re: [Qemu-devel] [PATCH] Use Aff1 with mpidr

2015-05-29 Thread Igor Mammedov
On Fri, 29 May 2015 11:53:38 +0300 Pavel Fedin wrote: > Hello! > > > > +/* > > > + * When KVM is in use, psci is emulated in-kernel and not by qemu. > > > + * In order for it to work correctly we should use correct MPIDR > > > values, > > > + * which appear to be inherited from

[Qemu-devel] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

2015-05-29 Thread Alberto Garcia
Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5

[Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-05-29 Thread Alberto Garcia
After having emptied the cache, the data in the cache tables is no longer useful, so we can tell the kernel that we are done with it. In Linux this frees the resources associated with it. The effect of this can be seen in the HMP commit operation: it moves data from the top to the base image (and

[Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

2015-05-29 Thread Alberto Garcia
This adds a new 'cache-clean-interval' option that cleans all qcow2 cache entries that haven't been used in a certain interval, given in seconds. This allows setting a large L2 cache size so it can handle scenarios with lots of I/O and at the same time use little memory during periods of inactivit

[Qemu-devel] [PATCH v4 0/3] Clean unused entries in the qcow2 L2/refcount cache

2015-05-29 Thread Alberto Garcia
v4: - Revert the 'cache-clean-interval' change. This should probably go into a new BlockDeviceInfoSpecific struct (along with other settings), but is out of the scope for this series. v3: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg05473.html - Add 'cache-clean-interval' field to

[Qemu-devel] [PATCH 1/2] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE

2015-05-29 Thread Cornelia Huck
This was copied from virtio-pci, but it doesn't make much sense for ccw, as it doesn't have to handle the broken implementations this bit is supposed to deal with. Remove it. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/virtio

[Qemu-devel] [PATCH 0/2] virtio: further feature bit cleanup

2015-05-29 Thread Cornelia Huck
We can git rid of most of the feature bit manipulation by transports (except virtio-pci needing to advertise BAD_FEATURE). Passed sniff tests with virtio-ccw and s390-virtio. Patches are on top of "virtio: move host_features". Cornelia Huck (2): virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE

[Qemu-devel] [PATCH 2/2] virtio: move VIRTIO_F_NOTIFY_ON_EMPTY into core

2015-05-29 Thread Cornelia Huck
Nearly all transports have been offering VIRTIO_F_NOTIFY_ON_EMPTY, s390-virtio being the exception. There's no reason why it shouldn't offer it as well, though (handling is done in core anyway), so let's move it to the common virtio features. While we're changing it anyway, fix the indentation for

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 29.05.2015 um 10:33 hat Dr. David Alan Gilbert geschrieben: > > * Markus Armbruster (arm...@redhat.com) wrote: > > > "Dr. David Alan Gilbert" writes: > > > > > > > * John Snow (js...@redhat.com) wrote: > > > >> > > > >> > > > >> On 05/21/2015 09:19 AM

[Qemu-devel] [PATCH v3 00/21] monitor: Wean core off QError, and other cleanups

2015-05-29 Thread Markus Armbruster
Command handlers still use QError. Left for another day. v3: * Trivially rebased, R-bys retained. * PATCH 11: New [Luiz] v2: * Trivially rebased, R-bys retained. * PATCH 01: Drop another async remnant [Eric] * PATCH 01+02+18: Improve commit messages * PATCH 03+04: client_migrate_info still hasn'

[Qemu-devel] [PATCH v3 02/21] monitor: Clean up after previous commit

2015-05-29 Thread Markus Armbruster
Inline qmp_call_cmd() along with its helper handler_audit() into its only caller handle_qmp_command(), and simplify the result. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 40 +++- 1 file changed, 11

[Qemu-devel] [PATCH v3 03/21] monitor: Improve and document client_migrate_info protocol error

2015-05-29 Thread Markus Armbruster
Protocol must be spice, vnc isn't implemented. Fix up documentation. Attempts to use vnc or any other unknown protocol yield the misleading error message "Invalid parameter 'protocol'". Improve it to "Parameter 'protocol' expects spice". Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Revi

[Qemu-devel] [PATCH v3 06/21] monitor: Use traditional command interface for HMP device_add

2015-05-29 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. For device_add, that's easy:

[Qemu-devel] [PATCH v3 05/21] monitor: Use traditional command interface for HMP drive_del

2015-05-29 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. For drive_del, that's easy:

[Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode()

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- monitor.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 61ea346..d336b8f 100644 --- a/monitor.c +++ b/monitor.c @@ -4708,19 +4708,20 @@ static int monitor_can_read(void *opaque) return

[Qemu-devel] [PATCH v3 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error

2015-05-29 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. pcie_aer_inject_error's impl

[Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into its only caller

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 56564d5..91f8a4e 100644 --- a/monitor.c +++ b/monitor.c @@ -377,11 +377,6 @@ static int GCC_F

[Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers

2015-05-29 Thread Markus Armbruster
The previous commits narrowed use of QError to handle_qmp_command() and its helpers monitor_protocol_emitter(), build_qmp_error_dict(). Narrow it further to just the command handler call: instead of converting Error to QError throughout handle_qmp_command(), convert the QError gotten from the comma

[Qemu-devel] [PATCH v3 10/21] monitor: Propagate errors through qmp_check_input_obj()

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 0afcf60..61ea346 100644 --- a/monitor.c +++ b/monitor.c @@ -4929,14 +4929,14 @

[Qemu-devel] [PATCH v3 09/21] monitor: Propagate errors through qmp_check_client_args()

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 65 --- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/monitor.c b/monitor.c index 9403c2c..0afcf60 100644 --- a/mon

[Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/monitor.c b/monitor.c index 85bb71e..9403c2c 100644 --- a/monitor.c +++ b/monitor.c @@ -123,7 +123,6 @@

[Qemu-devel] [PATCH v3 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check

2015-05-29 Thread Markus Armbruster
Superfluous since commit 30f5041 removed it from HMP. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 187ccdb..d01d270 100644 --- a/monitor.c

[Qemu-devel] [PATCH v3 21/21] monitor: Change return type of monitor_cur_is_qmp() to bool

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- include/monitor/monitor.h | 2 +- monitor.c | 6 -- stubs/mon-is-qmp.c| 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/monitor/monitor.h b/includ

[Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error

2015-05-29 Thread Markus Armbruster
Move mon->error handling to its caller handle_qmp_command(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index d336b8f..56564d5 100644

[Qemu-devel] [PATCH v3 04/21] monitor: Convert client_migrate_info to QAPI

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- hmp-commands.hx | 3 +-- hmp.c| 17 + hmp.h| 1 + monitor.c| 42 ++ qapi-schema.json | 19 +++ qmp

[Qemu-devel] [PATCH v3 16/21] monitor: Rename monitor_control_read(), monitor_control_event()

2015-05-29 Thread Markus Armbruster
... to monitor_qmp_read(), monitor_qmp_event(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/monitor.c b/monitor.c index ac7d851..cf80d10 100644 --- a/moni

[Qemu-devel] [PATCH v3 15/21] monitor: Rename handle_user_command() to handle_hmp_command()

2015-05-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 16bd567..ac7d851 100644 --- a/monitor.c +++ b/monitor.c @@ -574,7 +574,7 @@ static int d

[Qemu-devel] [PATCH v3 01/21] monitor: Drop broken, unused asynchronous command interface

2015-05-29 Thread Markus Armbruster
The asynchronous monitor command interface goes back to commit 940cc30 (Jan 2010). Added a third case to command execution. The hope back then according to the commit message was that all commands get converted to the asynchronous interface, killing off the other two cases. Didn't happen. The i

[Qemu-devel] [PATCH v3 19/21] monitor: Turn int command_mode into bool in_command_mode

2015-05-29 Thread Markus Armbruster
While there, inline the pointless qmp_cmd_mode() wrapper. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index d01d270..75ae0

[Qemu-devel] [PATCH v3 17/21] monitor: Unbox Monitor member mc and rename to qmp

2015-05-29 Thread Markus Armbruster
While there, rename its type as well, from MonitorControl to MonitorQMP. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/monitor.c b/monit

[Qemu-devel] [PATCH v3 20/21] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp()

2015-05-29 Thread Markus Armbruster
... and change return type to bool. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 75ae035..3426bdc 100644 --- a/monitor.c +++ b/m

[Qemu-devel] [PULL 5/5] gtk: Replace gdk_cursor_new()

2015-05-29 Thread Gerd Hoffmann
From: Max Reitz gdk_cursor_new() has been deprecated in GTK 3.16, it is recommended to use gdk_cursor_new_for_display() instead, so do that. Signed-off-by: Max Reitz Reviewed-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v3 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces

2015-05-29 Thread Olga Krishtal
On 29/05/15 01:56, Eric Blake wrote: On 05/28/2015 12:41 PM, Kirk Allan wrote: By default, IP addresses and prefixes will be derived from information obtained by various calls and structures. IPv4 prefixes can be found by matching the address to those returned by GetAdaptersInfo. IPv6 prefixes

[Qemu-devel] [PULL 3/5] ui: add egl-helpers

2015-05-29 Thread Gerd Hoffmann
Add helper functions to initialize OpenGL using egl. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- configure| 2 +- include/ui/egl-helpers.h | 16 + ui/Makefile.objs | 3 + ui/egl-helpers.c | 148 +++

[Qemu-devel] [PULL 2/5] ui: shader.h protect against double inclusion

2015-05-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/shader.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/ui/shader.h b/include/ui/shader.h index 992cde6..8509596 100644 --- a/include/ui/shader.h +++ b/include/ui/shader.h @@ -1,3 +1,6 @@ +#ifndef QEMU_SHADER_H

[Qemu-devel] [PULL 0/5] gtk: add opengl rendering support.

2015-05-29 Thread Gerd Hoffmann
ository at: git://git.kraxel.org/qemu tags/pull-gtk-20150529-1 for you to fetch changes up to 63c67b6d4462b6589b371d55e3740e9f0dba3281: gtk: Replace gdk_cursor_new() (2015-05-29 11:43:29 +0200) gtk: add opengl rendering supp

[Qemu-devel] [PULL 4/5] gtk: add opengl support, using egl

2015-05-29 Thread Gerd Hoffmann
This adds opengl rendering support to the gtk ui, using egl. It's off by default for now, use 'qemu -display gtk,gl=on' to play with this. Note that gtk got native opengl support with release 3.16. There most likely will be a separate implementation for 3.16+, using the native gtk opengl support.

[Qemu-devel] [PULL 1/5] ui: use libexpoxy

2015-05-29 Thread Gerd Hoffmann
libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages instead of silently failing or segfaulting in case we do something wrong, like using gl commands not supported by the current context. Signed-off-by: Gerd Hoffmann Reviewe

Re: [Qemu-devel] [PULL 0/4] spice patch queue

2015-05-29 Thread Peter Maydell
babb6b95d0659: > > Revert "gdbstub: Do not kill target in system emulation mode" (2015-05-28 > 16:57:35 +0100) > > are available in the git repository at: > > git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150529-1 > > for you to fetch changes

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Kevin Wolf
Am 29.05.2015 um 11:38 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 29.05.2015 um 10:33 hat Dr. David Alan Gilbert geschrieben: > > > * Markus Armbruster (arm...@redhat.com) wrote: > > > > "Dr. David Alan Gilbert" writes: > > > > > > > > > * John Snow (j

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 29.05.2015 um 11:38 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 29.05.2015 um 10:33 hat Dr. David Alan Gilbert geschrieben: > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > > > > "Dr. David Alan Gi

Re: [Qemu-devel] [PATCH v3 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces

2015-05-29 Thread Olga Krishtal
On 28/05/15 23:54, Denis V. Lunev wrote: On 28/05/15 21:41, Kirk Allan wrote: By default, IP addresses and prefixes will be derived from information obtained by various calls and structures. IPv4 prefixes can be found by matching the address to those returned by GetAdaptersInfo. IPv6 prefixes c

[Qemu-devel] [RFC PATCH 00/12] block: Protect block jobs with lock / unlock API

2015-05-29 Thread Fam Zheng
This is the partial work to introduce bdrv_lock / bdrv_unlock and use them in block jobs where exclusive access to a BDS is necessary. It address the same category of problems as [1] with a different API, as the idea proposed by Paolo and Kevin. What's implemented in this series is also very close

[Qemu-devel] [RFC PATCH 07/12] block-backend: Add blk_add_lock_unlock_notifier

2015-05-29 Thread Fam Zheng
Forward the call to bdrv_add_lock_unlock_notifier. Signed-off-by: Fam Zheng --- block/block-backend.c | 6 ++ include/sysemu/block-backend.h | 1 + 2 files changed, 7 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 93e46f3..79fdf75 100644 --- a/block/

[Qemu-devel] [RFC PATCH 04/12] blockdev: Lock BDS during external snapshot transaction

2015-05-29 Thread Fam Zheng
Lock immediately follows aio_context_acquire, so unlock right before the corresponding aio_context_release. Signed-off-by: Fam Zheng --- blockdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockdev.c b/blockdev.c index 46f8d60..1c3946a 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1

[Qemu-devel] [RFC PATCH 02/12] block: Introduce bdrv_lock and bdrv_unlock API

2015-05-29 Thread Fam Zheng
For various purposes, BDS users call bdrv_drain or bdrv_drain_all to make sure there are no pending requests duringA a series of operations on the BDS. But in the middle of operations, the caller may 1) yield from a coroutine (mirror_run); 2) defer the next part of work to a BH (mirror_run); 3) cal

[Qemu-devel] [RFC PATCH 01/12] block: Use bdrv_drain to replace uncessary bdrv_drain_all

2015-05-29 Thread Fam Zheng
There callers work on a single BlockDriverState subtree, where using bdrv_drain() is more accurate. Signed-off-by: Fam Zheng --- block.c | 6 +++--- block/snapshot.c | 2 +- migration/block.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c inde

[Qemu-devel] [RFC PATCH 09/12] virtio-blk: Don't handle output when backend is locked

2015-05-29 Thread Fam Zheng
virtio-blk now listens to locking and unlocking of the associated block backend. Up on locking: non-dataplane: 1) Set VirtIOBlock.paused 2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused dataplane: 1) Clear the host event notifier 2) In handle_notify, do nothing if

[Qemu-devel] [RFC PATCH 11/12] nbd-server: Clear "can_read" when backend is locked

2015-05-29 Thread Fam Zheng
So that NBD export will not process more requests. Signed-off-by: Fam Zheng --- nbd.c | 21 + 1 file changed, 21 insertions(+) diff --git a/nbd.c b/nbd.c index 06b501b..854d6a5 100644 --- a/nbd.c +++ b/nbd.c @@ -160,6 +160,8 @@ struct NBDExport { uint32_t nbdflags;

Re: [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl->phase

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 11:34, Dr. David Alan Gilbert wrote: > It's the destination I'm worried about here, not the source; lets say > you have two devices, a & b. 'a' gets serialised, but then 'b' finds > it has to wait, so we return to running the source and sending pages > across. However the dest

[Qemu-devel] [RFC PATCH 03/12] blockdev: Lock BDS during internal snapshot transaction

2015-05-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..46f8d60 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1262,6 +1262,7 @@ typedef struct InternalSnapshotState { BlockDriverState *bs; AioContext *aio_co

[Qemu-devel] [RFC PATCH 10/12] virtio-scsi-dataplane: Add backend lock listener

2015-05-29 Thread Fam Zheng
When a disk is attached to scsi-bus, virtio_scsi_hotplug will take care of protecting the block device with op blockers. Currently we haven't enabled block jobs (like what's done in virtio_blk_data_plane_create), but it is better to disable ioeventfd when backend is locked. This is useful to make

[Qemu-devel] [RFC PATCH 05/12] blockdev: Lock BDS during drive-backup transaction

2015-05-29 Thread Fam Zheng
To save the bs pointer for drive_backup_clean, pull the assignment to state->bs up. It will not be a problem for drive_backup_abort because state->job will still be NULL. Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/b

[Qemu-devel] [RFC PATCH 12/12] mirror: Protect source between bdrv_drain and bdrv_swap

2015-05-29 Thread Fam Zheng
Source and target are in sync when we leave the mirror_run loop, they should remain so until bdrv_swap. Before block_job_defer_to_main_loop was introduced, it has been easy to prove that. Now that tricky things can happen after mirror_run returns and before mirror_exit runs, for example, ioeventfd

[Qemu-devel] [RFC PATCH 06/12] blockdev: Lock BDS during blockdev-backup transaction

2015-05-29 Thread Fam Zheng
The change is similar to drive-backup in last patch. Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 517def4..80cf7d5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1669,6 +1669,8 @@ static void blockdev_b

[Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O

2015-05-29 Thread Alex Bennée
If your trying to debug and want to force -O0 then don't allow the configure script to try and set -O2. You can use --enable-debug but that enables a lot more stuff by default. Signed-off-by: Alex Bennée --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/config

[Qemu-devel] [PATCH v4 3/4] target-arm: Extend the gic node properties

2015-05-29 Thread Christoffer Dall
In preparation for adding the GICv2m which requires address specifiers and is a subnode of the gic, we extend the gic DT definition to specify the #address-cells and #size-cells properties and add an empty ranges property properties of the DT node, since this is required to add the v2m node as a ch

[Qemu-devel] [RFC PATCH 08/12] virtio-blk: Move complete_request to 'ops' structure

2015-05-29 Thread Fam Zheng
Should more ops be added to differentiate code between dataplane and non-dataplane, the new saved_ops approach will be cleaner than messing with N pointers. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- hw/block/dataplane/virtio-blk.c | 13 - hw/block/virtio-blk.c |

  1   2   3   >