Hi,
> +Scope(\_SB) {
> +OperationRegion (RCRB, SystemMemory, 0xfed1c000, 0x4000)
Where does this address come from?
Is this a standard location suggested by intel specs?
Or is the firmware free to choose it?
cheers,
Gerd
Bandan Das writes:
> There's too much going on in monitor_parse_command().
> Split up the arguments parsing bits into a separate function
> monitor_parse_arguments(). Let the original function check for
> command validity and sub-commands if any and return data (*cmd)
> that the newly introduced
> -Original Message-
> From: Igor Mammedov [mailto:imamm...@redhat.com]
> Sent: Wednesday, 27 May, 2015 7:12 PM
> To: shlomopongr...@gmail.com
> Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; Shlomo Pongratz
> Subject: Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr
>
> On
This patch adds the two extra brazilian keys to the evdev keymap for
X11. This patch gets the two keys going with the vnc, gtk and sdl1
UIs.
The SDL2 library complains it doesn't know these keys, so the SDL2
library must be fixed before we can update ui/sdl2-keymap.h
Signed-off-by: Gerd Hoffmann
The brazilian computer keyboard layout has two extra keys (compared to
the usual 105-key intl ps/2 keyboard). This patch makes these two keys
known to qemu.
For historic reasons qemu has two ways to specify a key: A QKeyCode
(name-based) or a number (ps/2 scancode based). Therefore we have to
u
On 27/05/2015 23:06, Laszlo Ersek wrote:
> It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
> Machine type.
>
> Hence, let us not instantiate the FDC when all of the following apply:
> - the machine type is pc-q35-2.4 or later,
> - "-device isa-fdc" is not passed on the
On 28/05/2015 03:46, Fam Zheng wrote:
> The main context uses iohandler and aio_dispatch, neither calls
> aio_set_dispatching(). However, if we have [2], they can be changed to
> aio_poll(), then would this idea work?
I think it's a bad idea to handle aio_poll for context B in a different
way, j
On 28/05/2015 04:49, Fam Zheng wrote:
>
> On a second thought, although in this series, we only need to modify
> virtio-{scsi,blk}, Wen pointed out that mirror job also wants this during
> completion (because bdrv_swap is in a BH after the job coroutine returns).
Mirror needs to pause/resume th
On 28/05/2015 07:29, Fam Zheng wrote:
> Like bdrv_is_allocated_above, this function follows the backing chain until
> seeing
> BDRV_BLOCK_ALLOCATED. Base is not included.
>
> Reimplement bdrv_is_allocated on top.
"Reimplement bdrv_get_block_status on top".
Can be fixed by whoever commits thi
On 28/05/2015 07:29, Fam Zheng wrote:
> If specified as "true", it allows discarding on target sectors where source is
> not allocated.
>
> Signed-off-by: Fam Zheng
Reviewed-by: Paolo Bonzini
> ---
> block/mirror.c| 7 +--
> blockdev.c| 5 +
> hmp.c
On 28/05/2015 07:29, Fam Zheng wrote:
> If guest discards a source cluster, mirroring with bdrv_aio_readv is overkill.
> Some protocols do zero upon discard, where it's best to use
> bdrv_aio_write_zeroes, otherwise, bdrv_aio_discard will be enough.
>
> Signed-off-by: Fam Zheng
Reviewed-by: Paol
On 28/05/2015 07:29, Fam Zheng wrote:
> This checks that the discard on mirror source that effectively zeroes
> data is also reflected by the data of target.
>
> Signed-off-by: Fam Zheng
> Reviewed-by: John Snow
> ---
> tests/qemu-iotests/132 | 59
> ++
On 28/05/2015 07:29, Fam Zheng wrote:
> Only poll the specific type of event we are interested in, to avoid
> stealing events that should be consumed by someone else.
>
> Suggested-by: John Snow
> Signed-off-by: Fam Zheng
> Reviewed-by: John Snow
> ---
> tests/qemu-iotests/iotests.py | 9 ++-
On 28 May 2015 at 06:30, Edgar E. Iglesias wrote:
> On Tue, May 19, 2015 at 07:33:23PM +0100, Peter Maydell wrote:
>> If the SCTLR.UMA trap bit is set then attempts by EL0 to update
>> the PSTATE DAIF bits via "MSR DAIFSet, imm" and "MSR DAIFClr, imm"
>> instructions will raise an exception. We we
Laszlo Ersek writes:
> It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
> Machine type.
Surely Unnecessary Crap can still Kill Security.
> Hence, let us not instantiate the FDC when all of the following apply:
> - the machine type is pc-q35-2.4 or later,
> - "-device is
On 28/05/2015 10:39, Markus Armbruster wrote:
> > -pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > +pc_basic_device_init(isa_bus, gsi, &rtc_state, force_fdctrl, &floppy,
> > (pc_machine->vmport != ON_OFF_AUTO_ON), 0xff0104);
> >
> > /* connect
The function originally behaves very badly when adding properties with "[*]"
suffix.
Nomnally these are used for numbering IRQ pins. In order to find the correct
starting
number the function started from zero and checked for duplicates. This took
incredibly
long time with large number of CPUs b
From: Eric Farman
Add handling for the Store Additional Status at Address order
that exists for the Signal Processor (SIGP) instruction.
Signed-off-by: Eric Farman
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h | 1 +
target-s390x/kvm.c | 55 +++
From: Eric Farman
gdb allows registers to be displayed/modified, and is being updated
to account for the new vector registers. Mirror these changes in
the gdb stub in qemu so that this can be performed when gdb is
attached to the qemu gdbserver.
Signed-off-by: Eric Farman
Reviewed-by: David Hi
From: Eric Farman
Sync with kernel elf.h updates to get s390x vector register definitions.
Signed-off-by: Eric Farman
Signed-off-by: Cornelia Huck
---
include/elf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/elf.h b/include/elf.h
index 3e75f05..4afd474 100644
--- a/include/
The following changes since commit 0915aed5842bd4dbe396b92d4f3b846ae29ad663:
Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
staging (2015-05-26 11:31:03 +0100)
are available in the git repository at:
git://github.com/cohuck/qemu tags/s390x-20150528
From: Eric Farman
Handle the actual syncing of the vector registers with kernel space,
via the get/put register IOCTLs.
The vector registers that were introduced with the z13 overlay
the existing floating point registers. FP registers 0-15 are
the high-halves of vector registers 0-15. Thus, re
From: Eric Farman
There are mechanisms to dump registers via the qemu HMP interface,
such as the "info registers" command. Expand this output to dump
the new vector registers.
Signed-off-by: Eric Farman
Reviewed-by: David Hildenbrand
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
From: Eric Farman
Everything is finally in place, inform the kernel that user space
supports vector registers.
Signed-off-by: Eric Farman
Reviewed-by: Thomas Huth
Signed-off-by: Cornelia Huck
---
target-s390x/kvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-s390x/kvm.c b/targ
From: Eric Farman
When migrating a guest, be sure to include the vector registers.
The vector registers are defined in a subsection, similar to the
existing subsection for floating point registers. Since the
floating point registers are always present (and thus migrated),
we can skip them when p
From: Eric Farman
Include the vector registers XML file that is provided by gdb,
and can be used by the qemu gdbserver interface.
Signed-off-by: Eric Farman
Reviewed-by: David Hildenbrand
Signed-off-by: Cornelia Huck
---
gdb-xml/s390-vx.xml | 59 ++
From: Eric Farman
Provide a routine to access the correct floating point register,
to simplify future expansion.
Suggested-by: David Hildenbrand
Signed-off-by: Eric Farman
Reviewed-by: David Hildenbrand
Signed-off-by: Cornelia Huck
---
linux-user/signal.c | 4 ++--
target-s390x/arch_du
The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a
PCI device has a static address. This is not true for PCI devices
that are on the secondary bus of a PCI to PCI bridge.
BIOS and/or guest OS can change the secondary bus number to a new
value at any time.
When a PCI to PCI bridge
From: Eric Farman
Create ELF notes for the vector registers where applicable, so that
their contents can be examined by utilities such as crash or readelf.
Signed-off-by: Eric Farman
Reviewed-by: David Hildenbrand
Signed-off-by: Cornelia Huck
---
target-s390x/arch_dump.c | 39 +++
Gerd Hoffmann writes:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11. This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can update ui/sdl2-key
On Thu, May 28, 2015 at 08:24:04AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> > does not match your patch. I'm not sure where I got that mapping
> > from originally - probably from the Linux kernel's XT <-> evdev
> > keymapping
On Thu, May 28, 2015 at 09:40:44AM +0200, Gerd Hoffmann wrote:
> The brazilian computer keyboard layout has two extra keys (compared to
> the usual 105-key intl ps/2 keyboard). This patch makes these two keys
> known to qemu.
>
> For historic reasons qemu has two ways to specify a key: A QKeyCod
On Thu, May 28, 2015 at 09:40:45AM +0200, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11. This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must b
On Thu, 28 May 2015 07:23:55 +
Shlomo Pongratz wrote:
>
>
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: Wednesday, 27 May, 2015 7:12 PM
> > To: shlomopongr...@gmail.com
> > Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; Shlomo Pongratz
>
Copying John Snow (FDC maintainer) and the qemu-block list.
Am 27.05.2015 um 23:06 hat Laszlo Ersek geschrieben:
> It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
> Machine type.
>
> Hence, let us not instantiate the FDC when all of the following apply:
> - the machine t
On Thu, May 28, 2015 at 04:46:37AM -0400, Don Slutz wrote:
> The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a
> PCI device has a static address. This is not true for PCI devices
> that are on the secondary bus of a PCI to PCI bridge.
>
> BIOS and/or guest OS can change the secon
On Thu, May 28, 2015 at 10:39:59AM +0200, Markus Armbruster wrote:
> Laszlo Ersek writes:
>
> > It is Very annoying to carry forward an outdatEd coNtroller with a mOdern
> > Machine type.
>
> Surely Unnecessary Crap can still Kill Security.
>
> > Hence, let us not instantiate the FDC when all o
Am 28.05.2015 um 04:49 hat Fam Zheng geschrieben:
> On Wed, 05/27 12:43, Paolo Bonzini wrote:
> >
> >
> > On 27/05/2015 12:10, Kevin Wolf wrote:
> > > Am 27.05.2015 um 11:50 hat Paolo Bonzini geschrieben:
> > >>
> > >>
> > >> On 27/05/2015 11:07, Kevin Wolf wrote:
> > >>> This is the first part o
Hi,
This patch series adds virtio input devices. It's basically sending
linux evdev events over virtio. There is support for emulated hid
devices (i.e. send usual input to virtio device instead of usb or ps2
device).
For v4 I've splitted the patches, so virtio-*-device and virtio-*-pci
are ad
Signed-off-by: Gerd Hoffmann
---
include/hw/pci/pci_ids.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
index c6de710..49c062b 100644
--- a/include/hw/pci/pci_ids.h
+++ b/include/hw/pci/pci_ids.h
@@ -47,6 +47,13 @@
#define PCI_CLAS
This patch adds virtio-input support to qemu. It brings a abstract
base class providing core support, other classes can build on it to
actually implement input devices.
virtio-input basically sends linux input layer events (evdev) over
virtio.
Signed-off-by: Gerd Hoffmann
---
hw/input/Makefile
This patch adds the virtio-pci support bits for virtio-input-device.
Signed-off-by: Gerd Hoffmann
---
hw/virtio/virtio-pci.c | 36
hw/virtio/virtio-pci.h | 14 ++
2 files changed, 50 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/v
This patch adds the virtio-input-hid base class and
virtio-{keyboard,mouse,tablet} subclasses building on the base class.
They are hooked up to the qemu input core and deliver input events
to the guest like all other hid devices (ps/2 kbd, usb tablet, ...).
Using them is as simple as adding "-devi
Am 28.05.2015 um 02:59 hat Wen Congyang geschrieben:
> On 05/27/2015 08:31 PM, Kevin Wolf wrote:
> > Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben:
> >> On 05/09/2015 01:21 AM, Kevin Wolf wrote:
> >>> For bs->file, using references to existing BDSes has been possible for a
> >>> while already
This patch adds virtio-pci support for the emulated virtio-input
devices. Using them is as simple as adding "-device virtio-tablet-pci"
to your command line. If you want add multiple devices but don't want
waste a pci slot for each you can compose a multifunction device this way:
qemu -device vi
Linux input layer (evdev) header file.
Signed-off-by: Gerd Hoffmann
---
include/standard-headers/linux/input.h | 1198
scripts/update-linux-headers.sh|4 +-
2 files changed, 1201 insertions(+), 1 deletion(-)
create mode 100644 include/standard-header
On Thu, May 28, 2015 at 11:46:32AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> This patch series adds virtio input devices. It's basically sending
> linux evdev events over virtio. There is support for emulated hid
> devices (i.e. send usual input to virtio device instead of usb or ps2
> device).
>
Hi Tu Bo!
On Thu, 28 May 2015 12:29:57 +0800
tu bo wrote:
> Hi Kevin:
>
> On 05/26/2015 07:55 PM, Kevin Wolf wrote:
...
> > Is this still an RFC series, as the subject indicates, or is it meant
> > for inclusion?
> This is my first task for qemu which I took over from Xiao Guang Chen,
> and
On 05/28/2015 05:48 PM, Kevin Wolf wrote:
> Am 28.05.2015 um 02:59 hat Wen Congyang geschrieben:
>> On 05/27/2015 08:31 PM, Kevin Wolf wrote:
>>> Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben:
On 05/09/2015 01:21 AM, Kevin Wolf wrote:
> For bs->file, using references to existing BDSe
On 27/04/2015 13:19, Gal Hammer wrote:
> +static void vmgenid_init(Object *obj)
> +{
> +SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> +VmGenIdState *s = VMGENID(obj);
> +
> +memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16);
This is a small problem. The spec says t
Hi Thomas:
thanks a lot. I'll remove 'RFC' from the subject line and drop the
backslash according to Max's advice, and create v10.
On 05/28/2015 06:01 PM, Thomas Huth wrote:
Hi Tu Bo!
On Thu, 28 May 2015 12:29:57 +0800
tu bo wrote:
Hi Kevin:
On 05/26/2015 07:55 PM, Kevin Wolf wrote:
On Di, 2015-05-26 at 11:10 +0200, Cornelia Huck wrote:
> On Fri, 22 May 2015 15:56:13 +0200
> Gerd Hoffmann wrote:
>
> > Hi,
> >
> > Where we are in terms of virtio 1.0 support in qemu?
> >
> > There hasn't been much activity in mst's virtio-1.0 branch recently, at
> > least not in the public
28.05.2015 10:40, Gerd Hoffmann wrote:
> This patch adds the two extra brazilian keys to the evdev keymap for
> X11. This patch gets the two keys going with the vnc, gtk and sdl1
> UIs.
>
> The SDL2 library complains it doesn't know these keys, so the SDL2
> library must be fixed before we can up
On Thu, 05/28 10:23, Paolo Bonzini wrote:
>
>
> On 28/05/2015 04:49, Fam Zheng wrote:
> >
> > On a second thought, although in this series, we only need to modify
> > virtio-{scsi,blk}, Wen pointed out that mirror job also wants this during
> > completion (because bdrv_swap is in a BH after the
On 28/05/2015 12:46, Fam Zheng wrote:
>> >
>> > Mirror needs to pause/resume the source. It doesn't need to handle
>> > pause/resume of the target, does it?
>> >
>>> > > So, in order for the solution to be general, and complete, this
>>> > > nofitier list
>>> > > approach relies on the listen
On Thu, 05/28 11:40, Kevin Wolf wrote:
> Indeed. blk_pause/resume would handle everything in one central place
> in the block layer instead of spreading the logic across all the block
> layer users.
Sorry, I'm confused. Do you mean there is a way to implement blk_pause
completely in block layer, w
On Thu, 28 May 2015 12:29:17 +0200
Gerd Hoffmann wrote:
> On Di, 2015-05-26 at 11:10 +0200, Cornelia Huck wrote:
> > On Fri, 22 May 2015 15:56:13 +0200
> > Gerd Hoffmann wrote:
> >
> > > Hi,
> > >
> > > Where we are in terms of virtio 1.0 support in qemu?
> > >
> > > There hasn't been much
On Thu, 05/28 12:52, Paolo Bonzini wrote:
>
>
> On 28/05/2015 12:46, Fam Zheng wrote:
> >> >
> >> > Mirror needs to pause/resume the source. It doesn't need to handle
> >> > pause/resume of the target, does it?
> >> >
> >>> > > So, in order for the solution to be general, and complete, this
>
On 05/09/2015 01:21 AM, Kevin Wolf wrote:
> Instead of letting every caller of bdrv_open() determine the right flags
> for its child node manually and pass them to the function, pass the
> parent node and the role of the newly opened child (like backing file,
> protocol layer, etc.).
>
> Signed-of
From: Shannon Zhao
Before I sent some patches to fix memory leak spotted by valgrind. Then
I'd like to dig deeper and find that two places have memory leak due to
calling qemu_find_file and not freeing return buf. Then through code
searching another two places are found. So this patchset is to fi
On 28/05/2015 12:55, Fam Zheng wrote:
> > Indeed. blk_pause/resume would handle everything in one central place
> > in the block layer instead of spreading the logic across all the block
> > layer users.
>
> Sorry, I'm confused. Do you mean there is a way to implement blk_pause
> completely in bl
From: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
hw/display/cg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/cg3.c b/hw/display/cg3.c
index 1e6ff2b..b86e5c0 100644
--- a/hw/display/cg3.c
+++ b/hw/display/cg3.c
@@ -302,6 +302,7 @@ static void cg
From: Shannon Zhao
valgrind complains about:
==7055== 58 bytes in 1 blocks are definitely lost in loss record 1,471 of 2,192
==7055==at 0x4C2845D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==7055==by 0x24410F: malloc_and_trace (vl.c:2556)
==7055==by 0x64C770E:
In this version I used mkdtemp(3) which is:
_BSD_SOURCE
|| /* Since glibc 2.10: */
(_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700)
so should be available on systems we care about.
Signed-off-by: Michael Tokarev
---
net/slirp.c | 6 ++
1 file changed, 2 inse
From: Shannon Zhao
valgrind complains about:
==23693== 55 bytes in 1 blocks are definitely lost in loss record 1,277 of 2,014
==23693==at 0x4C2845D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==23693==by 0x21B93F: malloc_and_trace (vl.c:2556)
==23693==by 0x64C7
From: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
---
hw/ppc/e500.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index c10e1b5..f74e6f2 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -1027,9 +1027,11 @@ void ppce500_init(Machin
---
target-arm/helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 5d0f011..fc3f192 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -5333,6 +5333,8 @@ static int get_phys_addr_v6(CPUARMState *env, uint32_t
address, int acces
On Thu, 05/28 10:21, Paolo Bonzini wrote:
>
>
> On 28/05/2015 03:46, Fam Zheng wrote:
> > The main context uses iohandler and aio_dispatch, neither calls
> > aio_set_dispatching(). However, if we have [2], they can be changed to
> > aio_poll(), then would this idea work?
>
> I think it's a bad i
On 28/05/2015 13:16, Fam Zheng wrote:
> > On 28/05/2015 03:46, Fam Zheng wrote:
> > > The main context uses iohandler and aio_dispatch, neither calls
> > > aio_set_dispatching(). However, if we have [2], they can be changed to
> > > aio_poll(), then would this idea work?
> >
> > I think it's a b
13.05.2015 16:15, Fam Zheng wrote:
> raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi
> should relax.
Applied to -trivial, thank you!
/mjt
On 28/05/2015 13:11, Fam Zheng wrote:
> > Whoever uses ioeventfd needs to implement pause/resume, yes---not just
> > dataplane, also "regular" virtio-blk/virtio-scsi.
> >
> > However, everyone else should be okay, because the bottom half runs
> > immediately and the big QEMU lock is not released
Am 28.05.2015 um 13:00 hat Paolo Bonzini geschrieben:
> On 28/05/2015 12:55, Fam Zheng wrote:
> > > Indeed. blk_pause/resume would handle everything in one central place
> > > in the block layer instead of spreading the logic across all the block
> > > layer users.
> >
> > Sorry, I'm confused. Do y
15.05.2015 15:24, Markus Armbruster wrote:
> Peter Krempa writes:
>
>> The 'socket_optslist' structure does not contain the 'localaddr' and
>> 'localport' options that are parsed in case you are creating a
>> 'connect' type UDP character device.
..
Applied to -trivial, with commit message fixup
On 05/28/15 05:30, Michael S. Tsirkin wrote:
> On Thu, May 28, 2015 at 04:46:37AM -0400, Don Slutz wrote:
>> The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a
>> PCI device has a static address. This is not true for PCI devices
>> that are on the secondary bus of a PCI to PCI brid
On 27 May 2015 at 11:02, Stefan Hajnoczi wrote:
> The following changes since commit 0915aed5842bd4dbe396b92d4f3b846ae29ad663:
>
> Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
> staging (2015-05-26 11:31:03 +0100)
>
> are available in the git repository at:
>
> git
26.05.2015 12:25, Chen Hanxiao wrote:
> s/interation/iteration
>
> Signed-off-by: Chen Hanxiao
> ---
> docs/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt
> index f3df206..ab1fdd3 10
Michael Tokarev writes:
> In this version I used mkdtemp(3) which is:
>
> _BSD_SOURCE
> || /* Since glibc 2.10: */
> (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700)
In short, it's POSIX.1-2008.
> so should be available on systems we care about.
Yes.
> Signed-o
26.05.2015 04:46, Shannon Zhao wrote:
> From: Shannon Zhao
>
> These patches fix memmory leak spotted by valgrind.
>
> changes since v1:
> * use qemu_allocate_irq instead of qemu_allocate_irqs for allocating
> one irq (Paolo)
> * Add review-by from Igor for PATCH 3/3
>
> Shannon Zhao (3
On 28 May 2015 at 09:30, Peter Maydell wrote:
> On 28 May 2015 at 06:30, Edgar E. Iglesias wrote:
>>> @@ -381,6 +381,9 @@ void HELPER(msr_i_pstate)(CPUARMState *env, uint32_t
>>> op, uint32_t imm)
>>> */
>>> if (arm_current_el(env) == 0 && !(env->cp15.sctlr_el[1] & SCTLR_UMA)) {
>>>
On 28/05/2015 13:24, Kevin Wolf wrote:
> Am 28.05.2015 um 13:00 hat Paolo Bonzini geschrieben:
>> On 28/05/2015 12:55, Fam Zheng wrote:
Indeed. blk_pause/resume would handle everything in one central place
in the block layer instead of spreading the logic across all the block
layer
On Thu, 05/28 13:24, Kevin Wolf wrote:
> Am 28.05.2015 um 13:00 hat Paolo Bonzini geschrieben:
> > On 28/05/2015 12:55, Fam Zheng wrote:
> > > > Indeed. blk_pause/resume would handle everything in one central place
> > > > in the block layer instead of spreading the logic across all the block
> > >
On 27 May 2015 at 19:20, Andreas Färber wrote:
> Hello Peter,
>
> This is my QOM (devices) patch queue. Please pull.
>
> v2 contains changes that hopefully fix warnings on gcc 4.7.
Hi. I'm afraid this doesn't build on our minimum glib version (2.22):
/Users/pm215/src/qemu/tests/check-qom-proplis
On 28/05/2015 13:44, Fam Zheng wrote:
> > The reason for doing it in the block layer is that it's in one place and
> > we can be sure that it's applied. We can still in addition modify
> > specific users to avoid even trying to send requests, but I think it's
> > good to have the single place tha
On Thu, May 28, 2015 at 12:40:42PM +0100, Peter Maydell wrote:
> On 28 May 2015 at 09:30, Peter Maydell wrote:
> > On 28 May 2015 at 06:30, Edgar E. Iglesias
> > wrote:
> >>> @@ -381,6 +381,9 @@ void HELPER(msr_i_pstate)(CPUARMState *env, uint32_t
> >>> op, uint32_t imm)
> >>> */
> >>>
On Thu, 05/28 13:19, Paolo Bonzini wrote:
>
>
> On 28/05/2015 13:16, Fam Zheng wrote:
> > > On 28/05/2015 03:46, Fam Zheng wrote:
> > > > The main context uses iohandler and aio_dispatch, neither calls
> > > > aio_set_dispatching(). However, if we have [2], they can be changed to
> > > > aio_poll
On Thu, May 28, 2015 at 12:25:40PM +0200, Paolo Bonzini wrote:
>
>
> On 27/04/2015 13:19, Gal Hammer wrote:
> > +static void vmgenid_init(Object *obj)
> > +{
> > +SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> > +VmGenIdState *s = VMGENID(obj);
> > +
> > +memory_region_init_io(&s->iomem,
28.05.2015 14:13, Shannon Zhao пишет:
> From: Shannon Zhao
>
> valgrind complains about:
> ==7055== 58 bytes in 1 blocks are definitely lost in loss record 1,471 of
> 2,192
> ==7055==at 0x4C2845D: malloc (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==7055==by 0x24410F:
On Tue, May 19, 2015 at 07:33:28PM +0100, Peter Maydell wrote:
> Some coprocessor access functions will need to indicate that the
> instruction should trap to EL2 or EL3 rather than the default
> target exception level; add corresponding CPAccessResult enum
> entries and handling code.
>
> Signed-
Applied to -trivial, thanks!
/mjt
On 28 May 2015 at 12:44, Edgar E. Iglesias wrote:
> One of the patches had a missing target_el assigment for
> CP_ACCESS_TRAP_UNCATEGORIZED that I commented on a while back.
That's fixed in this series, I think.
Patches in this series I don't think I've seen a review or ack for:
target-arm: All
28.05.2015 14:13, Shannon Zhao wrote:
> From: Shannon Zhao
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/display/cg3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/cg3.c b/hw/display/cg3.c
> index 1e6ff2b..b86e5c0 100644
> --- a/hw/display/cg3
On 28 May 2015 at 12:48, Edgar E. Iglesias wrote:
> On Tue, May 19, 2015 at 07:33:28PM +0100, Peter Maydell wrote:
>> Some coprocessor access functions will need to indicate that the
>> instruction should trap to EL2 or EL3 rather than the default
>> target exception level; add corresponding CPAcc
On 28/05/2015 13:25, Paolo Bonzini wrote:
On 27/04/2015 13:19, Gal Hammer wrote:
+static void vmgenid_init(Object *obj)
+{
+SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
+VmGenIdState *s = VMGENID(obj);
+
+memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16);
This is
28.05.2015 14:13, Shannon Zhao wrote:
> From: Shannon Zhao
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/ppc/e500.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index c10e1b5..f74e6f2 100644
> --- a/hw/ppc/e500.c
> +++ b
On 2015/5/28 19:50, Michael Tokarev wrote:
> 28.05.2015 14:13, Shannon Zhao пишет:
>> From: Shannon Zhao
>>
>> valgrind complains about:
>> ==7055== 58 bytes in 1 blocks are definitely lost in loss record 1,471 of
>> 2,192
>> ==7055==at 0x4C2845D: malloc (in
>> /usr/lib64/valgrind/vgpreloa
On 28/05/2015 13:49, Fam Zheng wrote:
> On Thu, 05/28 13:19, Paolo Bonzini wrote:
>>
>>
>> On 28/05/2015 13:16, Fam Zheng wrote:
On 28/05/2015 03:46, Fam Zheng wrote:
> The main context uses iohandler and aio_dispatch, neither calls
> aio_set_dispatching(). However, if we have [2], t
28.05.2015 14:54, Michael Tokarev wrote:
> Applied to -trivial, thanks!
..or not applied yet... :)
This is again the same situation with the error message as with
1/4 hw/display/cg3.c, and the same question - is the error fatal?
And note that you're the number-one person who made changes to
this
See below.
> -Original Message-
> From: Igor Mammedov [mailto:imamm...@redhat.com]
> Sent: Thursday, 28 May, 2015 12:30 PM
> To: Shlomo Pongratz
> Cc: shlomopongr...@gmail.com; qemu-devel@nongnu.org;
> peter.mayd...@linaro.org
> Subject: Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mp
24.05.2015 23:20, Peter Crosthwaite wrote:
> There is no reason for device tree API to be built per-target.
> common-obj it. There is an extraneous inclusion of config.h that
> needs to be removed.
>
> Cc: Alexander Graf
> Reviewed-by: Andreas Färber
> Signed-off-by: Peter Crosthwaite
Applied
On Thu, 05/28 13:47, Paolo Bonzini wrote:
>
>
> On 28/05/2015 13:44, Fam Zheng wrote:
> > > The reason for doing it in the block layer is that it's in one place and
> > > we can be sure that it's applied. We can still in addition modify
> > > specific users to avoid even trying to send requests,
1 - 100 of 373 matches
Mail list logo
